From ffe3eb03daf9e21497e147e8010ba9e52c5472f6 Mon Sep 17 00:00:00 2001 From: Ka-Hing Cheung Date: Mon, 23 Mar 2020 00:51:36 -0700 Subject: [PATCH] rw and ro were flipped (#80) when user mount via fstab, we get '-o rw' implicitly, and under directmount this _enabled_ MS_RDONLY, which is the opposite of what we want refs https://github.com/kahing/goofys/issues/483 --- mount_linux.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mount_linux.go b/mount_linux.go index 58dd39c..b0348d3 100644 --- a/mount_linux.go +++ b/mount_linux.go @@ -108,8 +108,8 @@ func disableFunc(flag uintptr) func(uintptr) uintptr { // As per libfuse/fusermount.c:602: https://bit.ly/2SgtWYM#L602 var mountflagopts = map[string]func(uintptr) uintptr{ - "rw": enableFunc(unix.MS_RDONLY), - "ro": disableFunc(unix.MS_RDONLY), + "rw": disableFunc(unix.MS_RDONLY), + "ro": enableFunc(unix.MS_RDONLY), "suid": disableFunc(unix.MS_NOSUID), "nosuid": enableFunc(unix.MS_NOSUID), "dev": disableFunc(unix.MS_NODEV),