vitalif
/
gf-complete
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gf_general.c: fix pointless expression 

Instead of checking w128[0] twice check for w128[0] and w128[1].

Fix for coverity issue from Ceph project:

CID 1193072 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
 pointless_expression: The expression v1->w128[0] == v2->w128[0] &&
 v1->w128[0] == v2->w128[0] does not accomplish anything because it
 evaluates to either of its identical operands, v1->w128[0] == v2->w128[0].
 Did you intend the operands to be different?

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
master
Danny Al-Gaaf 2014-03-19 18:30:16 +01:00
parent 1559c2b515
commit 173f82442d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gf_general.c
View File

@ -240,7 +240,7 @@ int gf_general_are_equal(gf_general_t *v1, gf_general_t *v2, int w)
return (v1->w64 == v2->w64);
} else {
return (v1->w128[0] == v2->w128[0] &&
v1->w128[0] == v2->w128[0]);
v1->w128[1] == v2->w128[1]);
}
}