kwin/keyboard_layout_switching.h

139 lines
2.9 KiB
C
Raw Permalink Normal View History

2020-08-03 01:22:19 +03:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
2020-08-03 01:22:19 +03:00
SPDX-FileCopyrightText: 2017 Martin Gräßlin <mgraesslin@kde.org>
2020-08-03 01:22:19 +03:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_KEYBOARD_LAYOUT_SWITCHING_H
#define KWIN_KEYBOARD_LAYOUT_SWITCHING_H
#include <QObject>
#include <QHash>
#include <KConfigGroup>
namespace KWin
{
class AbstractClient;
class KeyboardLayout;
class Xkb;
class VirtualDesktop;
namespace KeyboardLayoutSwitching
{
class Policy : public QObject
{
Q_OBJECT
public:
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 19:52:26 +03:00
~Policy() override;
virtual QString name() const = 0;
static Policy *create(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config, const QString &policy);
protected:
explicit Policy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config = KConfigGroup());
virtual void clearCache() = 0;
virtual void layoutChanged() = 0;
void setLayout(quint32 layout);
quint32 layout() const;
KConfigGroup m_config;
virtual const QString defaultLayoutEntryKey() const;
void clearLayouts();
static const char defaultLayoutEntryKeyPrefix[];
private:
Xkb *m_xkb;
KeyboardLayout *m_layout;
};
class GlobalPolicy : public Policy
{
Q_OBJECT
public:
explicit GlobalPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~GlobalPolicy() override;
QString name() const override {
return QStringLiteral("Global");
}
protected:
void clearCache() override {}
void layoutChanged() override {}
private:
const QString defaultLayoutEntryKey() const override;
};
class VirtualDesktopPolicy : public Policy
{
Q_OBJECT
public:
explicit VirtualDesktopPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~VirtualDesktopPolicy() override;
QString name() const override {
return QStringLiteral("Desktop");
}
protected:
void clearCache() override;
void layoutChanged() override;
private:
void desktopChanged();
QHash<VirtualDesktop *, quint32> m_layouts;
};
class WindowPolicy : public Policy
{
Q_OBJECT
public:
explicit WindowPolicy(Xkb *xkb, KeyboardLayout *layout);
~WindowPolicy() override;
QString name() const override {
return QStringLiteral("Window");
}
protected:
void clearCache() override;
void layoutChanged() override;
private:
QHash<AbstractClient*, quint32> m_layouts;
};
class ApplicationPolicy : public Policy
{
Q_OBJECT
public:
explicit ApplicationPolicy(Xkb *xkb, KeyboardLayout *layout, const KConfigGroup &config);
~ApplicationPolicy() override;
QString name() const override {
return QStringLiteral("WinClass");
}
protected:
void clearCache() override;
void layoutChanged() override;
private:
void clientActivated(AbstractClient *c);
QHash<AbstractClient*, quint32> m_layouts;
QHash<QByteArray, quint32> m_layoutsRestored;
};
}
}
#endif