vitalif
/
kwin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
kwin/autotests/CMakeLists.txt

448 lines
14 KiB
CMake
Raw Normal View History

[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
add_definitions(-DKWIN_UNIT_TEST)
optimize string operations -use qstringliteral only when necessary (i.e. not in concat or comparison) -use qbytearray instead of qstring when dealing with latin1 input and output (glplatform) -use qstringref to extract numbers from strings (glplatform) -define qt_use_qstringbuilder to optimize all string concatenations -anidata: use ctor init lists, add windowType member initialization REVIEW: 125933
2015-11-05 17:14:06 +03:00
remove_definitions(-DQT_USE_QSTRINGBUILDER)
[autotests] Move libkwineffects/autotests to autotests/libkwineffects All autotests shall be in autotests subdirectory.
2016-07-18 09:47:45 +03:00
add_subdirectory(libkwineffects)
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731
2016-06-01 11:21:19 +03:00
add_subdirectory(libxrenderutils)
Rename autotests/wayland to autotests/integration It's not about Wayland, but more about Integration. It can test both Wayland and X11 windows. Reviewed-By: Bhushan Shah
2016-06-29 11:29:45 +03:00
add_subdirectory(integration)
Require libinput and udev Summary: The main reason for not having it as a mandatory dependency was that BSD doesn't support it. But as I learned recently it is available on our CI system. So BSDs have support now. Even more it showed that the code doesn't compile if the dependency is missing. And there's one thing I hate: broken build configuration options. So let's make UDEV and libinput a required dependency and get rid of the problems. Test Plan: Compiles Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D10057
2018-01-23 19:28:18 +03:00
add_subdirectory(libinput)
[autotests] Add tests for DRM platform plugin Summary: The addition of the test infrastructure is motivated by the regressions caused by adding mode switching and transformation support. A contributing factor to these regression is the fact that the DRM platform does not have any tests. It is difficult to test this code as it needs to work with hardware, thus we cannot use the real DRM library. Instead we need to use mocking. This change sets up some first basic tests with the help of a mockDrm library. In order to better test the code as units the Drm classes are slightly refactored. Most importantly the dependency to DrmBackend is removed wherever possible and replaced by a simple int fd which is mostly the only element used by the classes. This first test introduces basic testing of a DrmObject. It is intended to extend this to at least also test DrmPlane as a central piece of our Drm platform plugin. This will also extend the tests of DrmObject. Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8776
2017-11-12 23:00:02 +03:00
if (HAVE_DRM)
add_subdirectory(drm)
endif()
Move tabbox/autotests to autotests/tabbox Let's have all autotests in autotests subdirectory instead of spread out over the source tree.
2016-06-29 11:38:17 +03:00
add_subdirectory(tabbox)
[kwin-wayland] Create dedicated thread for wayland connection The Wayland event queue is moved into a dedicated thread and a new class is created for just creating the connection and listening for events. The WaylandBackend creates the thread and uses an event queue for the main thread. REVIEW: 119761
2014-08-13 14:54:02 +04:00
Adding unit test for ScreenPaintData and WindowPaintData
2012-06-03 11:15:10 +04:00
########################################################
# Test ScreenPaintData
########################################################
set( testScreenPaintData_SRCS test_screen_paint_data.cpp )
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable(testScreenPaintData ${testScreenPaintData_SRCS})
Stop including KDE4_INCLUDES globally Depend on libraries specifically instead.
2014-03-18 20:53:22 +04:00
target_link_libraries( testScreenPaintData kwineffects Qt5::Test Qt5::Widgets KF5::WindowSystem)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testScreenPaintData COMMAND testScreenPaintData)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testScreenPaintData)
Adding unit test for ScreenPaintData and WindowPaintData
2012-06-03 11:15:10 +04:00
########################################################
# Test WindowPaintData
########################################################
set( testWindowPaintData_SRCS test_window_paint_data.cpp )
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable(testWindowPaintData ${testWindowPaintData_SRCS})
Use Qt5:: in target link libraries in KWin
2013-08-20 11:10:18 +04:00
target_link_libraries( testWindowPaintData kwineffects Qt5::Widgets Qt5::Test )
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testWindowPaintData COMMAND testWindowPaintData)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testWindowPaintData)
Move handling of Virtual Desktops into a VirtualDesktopManager The ownership for virtual desktops is moved from Workspace into a new VirtualDesktopManager. The manager is responsible for providing the count of virtual desktops and keeping track of the currently used virtual desktop. All methods related to moving between desktops are also moved from Workspace to the new manager, though all methods related to Clients on Virtual Desktops remain in Workspace for the time being. This is to have the new manager as independent from KWin core as possible. An rather important change for the handling of virtual desktops is that the count and the id of a desktop is now an unsinged integer instead of an integer. The reason for that is that we cannot have a negative count of desktops as well as it is not possible to be on a desktop with a negative identifier. In that regard it is important to remember that a Client can be on a desktop with a negative identifier. The special value for a Client being on all desktops is handled by using -1 as a desktop. For the time being this is not adjusted but instead of comparing the virtual desktop ids one should prefer to use the convenient methods like isOnDesktop and isOnAllDesktops. This would allow in future to internally change the representation for on all desktops.
2012-11-16 11:23:47 +04:00
########################################################
# Test VirtualDesktopManager
########################################################
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 16:45:25 +04:00
set( testVirtualDesktops_SRCS
test_virtual_desktops.cpp
../virtualdesktops.cpp
)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable(testVirtualDesktops ${testVirtualDesktops_SRCS})
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 16:45:25 +04:00
target_link_libraries( testVirtualDesktops
Qt5::Test
Qt5::Widgets
KF5::I18n
KF5::GlobalAccel
KF5::ConfigCore
KF5::WindowSystem
[wayland] Use the new plasma virtual desktop protocol Summary: implement virtual desktop support for Wayland. use the new virtual desktop protocol from D12820 The VirtualDesktopManager class needed some big change in order to accomodate it, which is where most changes are. Other than that, it's mostly connections to wire up VirtualDesktopsManager and VirtualDesktopsManagement(the wayland protocol impl) Depends on D12820 Other notable detail, is the client visibility updated to reflect the presence of the client in the plasmavirtualdesktop. (and the unSetDesktop concept) Test Plan: used a bit a plasma session together with D12820, D13748 and D13746 Reviewers: #plasma, #kwin, graesslin, davidedmundson Reviewed By: #plasma, #kwin, davidedmundson Subscribers: hein, zzag, davidedmundson, kwin Tags: #kwin Maniphest Tasks: T4457 Differential Revision: https://phabricator.kde.org/D13887
2018-10-30 01:29:15 +03:00
KF5::WaylandServer
[kwin] Fix TestVirtualDesktops * enable compilation * Remove KActionCollection
2014-01-07 16:45:25 +04:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testVirtualDesktops COMMAND testVirtualDesktops)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testVirtualDesktops)
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 11:07:27 +04:00
########################################################
# Test ClientMachine
########################################################
set( testClientMachine_SRCS
test_client_machine.cpp
../client_machine.cpp
)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable( testClientMachine ${testClientMachine_SRCS} )
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 19:47:58 +03:00
set_target_properties(testClientMachine PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 11:07:27 +04:00
target_link_libraries( testClientMachine
Fix linking and includes Seems like there were some changes, we need more explicit linking.
2013-10-02 17:23:56 +04:00
Qt5::Concurrent
Use Qt5:: in target link libraries in KWin
2013-08-20 11:10:18 +04:00
Qt5::Test
Qt5::X11Extras
Qt5::Widgets
Track used cursor theme and size in Cursor Reads the settings from kcminputrc. Unfortunately there is no update when the settings change. This needs fixing in the cursors KCM first.
2013-06-27 11:06:16 +04:00
KF5::ConfigCore
Port to KF5 renaming changes
2013-12-12 00:41:47 +04:00
KF5::WindowSystem
[kwin] Use imported targets for all XCB libs Requires 04f78489265b6e52cabd2980dfc417abeee3a695 from ECM
2014-02-25 18:48:39 +04:00
XCB::XCB
XCB::XFIXES
Make Jenkins happy Yes, it linked on my system.
2013-05-13 11:58:04 +04:00
${X11_X11_LIB} # to make jenkins happy
Improved resolving whether a window is on local machine Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows using the FQDN (for example libreoffice). So instead of "foo" it is "foo.local.net" or similar. The logic so far has been unable to properly determine whether windows with FQDN are on the local system. In order to solve this problem the handling is split out into an own class which stores the information of hostname and whether it is a local machine. This is to not query multiple times. To determine whether the Client is on the local system getaddrinfo is used for the own hostname and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried names matches, we know that it is on the local machine. The old logic to compare the hostname is still used and getaddrinfo is only a fallback in case hostname does not match. The problem with getaddrinfo is, that it accesses the network and by that could block. To circumvent this problem the calls are moved into threads by using QtConcurrent::run. Obviously this brings disadvantages. When trying to resolve whether a Client is on the local machine and a FQDN is used, the information is initially wrong. The new ClientMachine class emits a signal when the information that the system is local becomes available, but for some things this is just too late: * window rules are already gathered * Session Management has already taken place In both cases this is an acceptable loss. For window rules it just needs a proper matching of the machine in case of localhost (remote hosts are not affected). And the case of session management is very academic as it is unlikely that a restoring session contains remote windows. BUG: 308391 FIXED-IN: 4.11 REVIEW: 108235
2013-01-07 11:07:27 +04:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testClientMachine COMMAND testClientMachine)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testClientMachine)
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 12:20:59 +04:00
########################################################
# Test XcbWrapper
########################################################
set( testXcbWrapper_SRCS
test_xcb_wrapper.cpp
)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable( testXcbWrapper ${testXcbWrapper_SRCS} )
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 12:20:59 +04:00
target_link_libraries( testXcbWrapper
Use Qt5:: in target link libraries in KWin
2013-08-20 11:10:18 +04:00
Qt5::Test
Qt5::X11Extras
Qt5::Widgets
KWin::Application holdes a KSharedConfigPtr with the config This allows the integration tests to provide their own configuration as they need it. Setting the configuration should be done before invoking start()
2016-01-29 11:48:02 +03:00
KF5::ConfigCore
[kwin] Add missing target link libraries Missing libs caused compile error if built standalone.
2014-03-18 17:38:00 +04:00
KF5::WindowSystem
[kwin] Use imported targets for all XCB libs Requires 04f78489265b6e52cabd2980dfc417abeee3a695 from ECM
2014-02-25 18:48:39 +04:00
XCB::XCB
Do not use a shared pointer for the Xcb::Wrapper It's not really needed, the required functionality can be achieved in a more implicit way. The reply pointer is managed by the Wrapper class as long as the method take() is not invoked. This method follows the semantics of QScopedPointer::take(). That is the pointer is set to null and the responsibility to free the pointer is passed to the callee. By this change we do not have the overhead of creating a QSharedPointer. In addition the Wrapper provides a copy ctor and assignment operator also using the semantics of take().
2013-01-14 12:20:59 +04:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testXcbWrapper COMMAND testXcbWrapper)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testXcbWrapper)
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 17:03:05 +04:00
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 16:54:20 +03:00
if (XCB_ICCCM_FOUND)
add_executable( testXcbSizeHints test_xcb_size_hints.cpp )
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 19:47:58 +03:00
set_target_properties(testXcbSizeHints PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 16:54:20 +03:00
target_link_libraries( testXcbSizeHints
Qt5::Test
Qt5::X11Extras
Fix build with a KWindowSystem framework that doesn't pull QWidget Summary: Fixes the build with D8705 Test Plan: Just adds includes, I wonder if it should go into Plasma/5.8 and /5.11 too Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: graesslin, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8706
2017-11-08 13:23:00 +03:00
Qt5::Widgets
KWin::Application holdes a KSharedConfigPtr with the config This allows the integration tests to provide their own configuration as they need it. Setting the configuration should be done before invoking start()
2016-01-29 11:48:02 +03:00
KF5::ConfigCore
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 16:54:20 +03:00
KF5::WindowSystem
XCB::XCB
XCB::ICCCM
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testXcbSizeHints COMMAND testXcbSizeHints)
Add Xcb::GeometryHints class It's a convenient class to encapsulate the ICCCM WM_SIZE_HINT. Instead of exposing just the properties it provides accessors for the interesting parts and applies sanity checks.
2015-01-21 16:54:20 +03:00
ecm_mark_as_test(testXcbSizeHints)
endif()
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 17:03:05 +04:00
########################################################
# Test XcbWindow
########################################################
set( testXcbWindow_SRCS
test_xcb_window.cpp
)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
add_executable( testXcbWindow ${testXcbWindow_SRCS} )
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 17:03:05 +04:00
target_link_libraries( testXcbWindow
Use Qt5:: in target link libraries in KWin
2013-08-20 11:10:18 +04:00
Qt5::Test
Qt5::X11Extras
Qt5::Widgets
KWin::Application holdes a KSharedConfigPtr with the config This allows the integration tests to provide their own configuration as they need it. Setting the configuration should be done before invoking start()
2016-01-29 11:48:02 +03:00
KF5::ConfigCore
[kwin] Add missing target link libraries Missing libs caused compile error if built standalone.
2014-03-18 17:38:00 +04:00
KF5::WindowSystem
[kwin] Use imported targets for all XCB libs Requires 04f78489265b6e52cabd2980dfc417abeee3a695 from ECM
2014-02-25 18:48:39 +04:00
XCB::XCB
Light-weight wrapper class for an xcb_window_t The idea behind this class is to relieve the developer from having to call xcb_destroy_window once it is no longer needed. That is having a RAII approach to windows. In addition the class provides some simple method wrappers for the most common use cases inside KWin: * map * unmap * setGeometry - basically a moveResizeWindow * ...
2013-01-29 17:03:05 +04:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testXcbWindow COMMAND testXcbWindow)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 14:49:53 +04:00
ecm_mark_as_test(testXcbWindow)
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
########################################################
# Test BuiltInEffectLoader
########################################################
set( testBuiltInEffectLoader_SRCS
test_builtin_effectloader.cpp
mock_effectshandler.cpp
../effectloader.cpp
)
add_executable( testBuiltInEffectLoader ${testBuiltInEffectLoader_SRCS})
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 19:47:58 +03:00
set_target_properties(testBuiltInEffectLoader PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
target_link_libraries(testBuiltInEffectLoader
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
Qt5::Concurrent
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
Qt5::Test
Remove KWin::display from kwinglobals Summary: And finally nothing inside libkwineffects, libkwinglutils, libkwinxrenderutils and kwineffect and kwin core uses KWin::display. We are finally XLib free! This change drops KWin::display and removes the include to QX11Info from kwinglobals.h. And the libraries no longer need to link X11Extras. Due to that removal a few seeming unrelated changes are required to add the include where needed and linkage to X11Extras. The biggest change is to x11 platform plugin which still needs the display and caches it in the Platform and passes it to various places in a way that the code doesn't need to be adjusted. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3337
2016-11-11 11:59:46 +03:00
Qt5::X11Extras
Port scripted effect loading from KService to KPackage Advantage: no more ksycoca cache for loading scripted effects.
2015-07-06 17:50:33 +03:00
KF5::Package
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
kwineffects
kwin4_effect_builtins
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testBuiltInEffectLoader COMMAND testBuiltInEffectLoader)
[kwin] Introduce a new Effect Loading mechanism Effect loading gets split by the kind of effects KWin supports: * Built-In Effects * Scripted Effects * Binary Plugin Effects For this a new AbstractEffectLoader is added which will have several sub-classes: * BuiltInEffectLoader * ScriptedEffectLoader * PluginEffectLoader * EffectLoader The EffectLoader will be what the EffectsHandlerImpl is using and it just delegates to the three other types of loaders. Thus the handler doesn't need to care about the different kinds of effects. The loading is supposed to be completely async and the EffectLoader emits a signal whenever an Effect got loaded. The EffectsHandlerImpl is supposed to connect to this signal and insert it into its own Effect management. Unloading is not performed by the loader, but by the EffectsHandler. There is one important change which needs to be implemented: the ordering cannot be provided by the loader and thus needs to be added to the Effects directly. So far only the BuiltInEffectsLoader is implemented. It's not yet integrated into the EffectsHandlerImpl, but a unit test is added which tries to perform the various operations provided by the loader and the BuiltInEffects. The test should cover all cases except the Check Default functionality which is only used by Blur and Contrast effects. This cannot be mocked yet as the GLPlatform doesn't allow mocking yet.
2014-03-22 12:48:07 +04:00
ecm_mark_as_test(testBuiltInEffectLoader)
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
########################################################
# Test ScriptedEffectLoader
########################################################
include_directories(${KWIN_SOURCE_DIR})
set( testScriptedEffectLoader_SRCS
test_scripted_effectloader.cpp
Port some displayWidth/displayHeight usages to Screens::size() Summary: KWin::displayWidth and KWin::displayHeight are bound to X11 which doesn't make much sense on X11. In addition KWin internally knows the overall display dimensions through the Screens singleton class. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D1798
2016-06-08 13:46:02 +03:00
mock_abstract_client.cpp
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
mock_effectshandler.cpp
Port some displayWidth/displayHeight usages to Screens::size() Summary: KWin::displayWidth and KWin::displayHeight are bound to X11 which doesn't make much sense on X11. In addition KWin internally knows the overall display dimensions through the Screens singleton class. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D1798
2016-06-08 13:46:02 +03:00
mock_screens.cpp
mock_workspace.cpp
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
../effectloader.cpp
../scripting/scriptedeffect.cpp
../scripting/scriptingutils.cpp
[scripting] Add dedicated logging category
2015-07-31 14:24:56 +03:00
../scripting/scripting_logging.cpp
Port some displayWidth/displayHeight usages to Screens::size() Summary: KWin::displayWidth and KWin::displayHeight are bound to X11 which doesn't make much sense on X11. In addition KWin internally knows the overall display dimensions through the Screens singleton class. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D1798
2016-06-08 13:46:02 +03:00
../screens.cpp
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
../orientation_sensor.cpp
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
)
Port some displayWidth/displayHeight usages to Screens::size() Summary: KWin::displayWidth and KWin::displayHeight are bound to X11 which doesn't make much sense on X11. In addition KWin internally knows the overall display dimensions through the Screens singleton class. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D1798
2016-06-08 13:46:02 +03:00
kconfig_add_kcfg_files(testScriptedEffectLoader_SRCS ../settings.kcfgc)
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
qt5_add_dbus_adaptor( testScriptedEffectLoader_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.kde.kwin.OrientationSensor.xml ${CMAKE_CURRENT_SOURCE_DIR}/../orientation_sensor.h KWin::OrientationSensor)
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
add_executable( testScriptedEffectLoader ${testScriptedEffectLoader_SRCS})
target_link_libraries(testScriptedEffectLoader
Qt5::Concurrent
Fix: Missing dependencies for kwin autotests guix (like nix) used a separate prefix for each package. Thus the header files for qtdeclarative are in /gnu/store/…-qtdeclarative-5.9.1/include/qt5/ while the ones for qtbase are in /gnu/store/…-base-5.9.1/include/qt5/. This means that *each* dependency's include directory must be specified. This is in contrast to a "normal" Unix-system, where all includes end up in /usr/include/qt5 and missing to defined some include-dependencies does often not raise an error. Differential Revision: https://phabricator.kde.org/D8112
2017-10-04 12:09:18 +03:00
Qt5::Qml
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
Qt5::Script
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
Qt5::Sensors
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
Qt5::Test
Remove KWin::display from kwinglobals Summary: And finally nothing inside libkwineffects, libkwinglutils, libkwinxrenderutils and kwineffect and kwin core uses KWin::display. We are finally XLib free! This change drops KWin::display and removes the include to QX11Info from kwinglobals.h. And the libraries no longer need to link X11Extras. Due to that removal a few seeming unrelated changes are required to add the include where needed and linkage to X11Extras. The biggest change is to x11 platform plugin which still needs the display and caches it in the Platform and passes it to various places in a way that the code doesn't need to be adjusted. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3337
2016-11-11 11:59:46 +03:00
Qt5::X11Extras
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
KF5::ConfigGui
KF5::GlobalAccel
KF5::I18n
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
KF5::Notifications
Port scripted effect loading from KService to KPackage Advantage: no more ksycoca cache for loading scripted effects.
2015-07-06 17:50:33 +03:00
KF5::Package
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
kwineffects
kwin4_effect_builtins
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testScriptedEffectLoader COMMAND testScriptedEffectLoader)
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 12:23:30 +04:00
ecm_mark_as_test(testScriptedEffectLoader)
[kwin] Add a PluginEffectLoader This is a specialized subclass of AbstractEffectLoader to load binary effect plugins. It used the KPluginTrader to find all candidates to load. The loader is able to detect incorrect ABI versions through the pluginVersion() and uses the methods exposed by the new KWin::EffectPluginFactory to check whether the Effect is supported and should be enabled by default. The unit test for this loader comes with two plugins: one is able to be loaded and provides a supported and enabledByDefault method which can be tweaked during the test to get all the conditions we want to test for. The second plugin uses an incorrect plugin version and thus cannot get loaded.
2014-03-25 14:39:07 +04:00
########################################################
# Test PluginEffectLoader
########################################################
set( testPluginEffectLoader_SRCS
test_plugin_effectloader.cpp
mock_effectshandler.cpp
../effectloader.cpp
)
add_executable( testPluginEffectLoader ${testPluginEffectLoader_SRCS})
target_link_libraries(testPluginEffectLoader
Qt5::Concurrent
Qt5::Test
Remove KWin::display from kwinglobals Summary: And finally nothing inside libkwineffects, libkwinglutils, libkwinxrenderutils and kwineffect and kwin core uses KWin::display. We are finally XLib free! This change drops KWin::display and removes the include to QX11Info from kwinglobals.h. And the libraries no longer need to link X11Extras. Due to that removal a few seeming unrelated changes are required to add the include where needed and linkage to X11Extras. The biggest change is to x11 platform plugin which still needs the display and caches it in the Platform and passes it to various places in a way that the code doesn't need to be adjusted. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3337
2016-11-11 11:59:46 +03:00
Qt5::X11Extras
Port scripted effect loading from KService to KPackage Advantage: no more ksycoca cache for loading scripted effects.
2015-07-06 17:50:33 +03:00
KF5::Package
[kwin] Add a PluginEffectLoader This is a specialized subclass of AbstractEffectLoader to load binary effect plugins. It used the KPluginTrader to find all candidates to load. The loader is able to detect incorrect ABI versions through the pluginVersion() and uses the methods exposed by the new KWin::EffectPluginFactory to check whether the Effect is supported and should be enabled by default. The unit test for this loader comes with two plugins: one is able to be loaded and provides a supported and enabledByDefault method which can be tweaked during the test to get all the conditions we want to test for. The second plugin uses an incorrect plugin version and thus cannot get loaded.
2014-03-25 14:39:07 +04:00
kwineffects
kwin4_effect_builtins
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testPluginEffectLoader COMMAND testPluginEffectLoader)
[kwin] Add a PluginEffectLoader This is a specialized subclass of AbstractEffectLoader to load binary effect plugins. It used the KPluginTrader to find all candidates to load. The loader is able to detect incorrect ABI versions through the pluginVersion() and uses the methods exposed by the new KWin::EffectPluginFactory to check whether the Effect is supported and should be enabled by default. The unit test for this loader comes with two plugins: one is able to be loaded and provides a supported and enabledByDefault method which can be tweaked during the test to get all the conditions we want to test for. The second plugin uses an incorrect plugin version and thus cannot get loaded.
2014-03-25 14:39:07 +04:00
ecm_mark_as_test(testPluginEffectLoader)
########################################################
# FakeEffectPlugin
########################################################
add_library(fakeeffectplugin MODULE fakeeffectplugin.cpp)
set_target_properties(fakeeffectplugin PROPERTIES PREFIX "")
target_link_libraries(fakeeffectplugin kwineffects)
########################################################
# FakeEffectPlugin-Version
########################################################
add_library(effectversionplugin MODULE fakeeffectplugin_version.cpp)
set_target_properties(effectversionplugin PROPERTIES PREFIX "")
target_link_libraries(effectversionplugin kwineffects)
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
########################################################
# Test Screens
########################################################
set( testScreens_SRCS
test_screens.cpp
[autotests] Adjust to changes regarding AbstractClient We need a Mock for AbstractClient and our mock Client needs to inherit from it.
2015-04-29 15:13:20 +03:00
mock_abstract_client.cpp
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
mock_client.cpp
mock_screens.cpp
mock_workspace.cpp
../screens.cpp
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
../x11eventfilter.cpp
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
../orientation_sensor.cpp
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
)
kconfig_add_kcfg_files(testScreens_SRCS ../settings.kcfgc)
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
qt5_add_dbus_adaptor( testScreens_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.kde.kwin.OrientationSensor.xml ${CMAKE_CURRENT_SOURCE_DIR}/../orientation_sensor.h KWin::OrientationSensor)
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
add_executable( testScreens ${testScreens_SRCS})
target_include_directories(testScreens BEFORE PRIVATE ./)
target_link_libraries(testScreens
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
Qt5::DBus
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
Qt5::Sensors
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
Qt5::Test
Qt5::X11Extras
Fix build with a KWindowSystem framework that doesn't pull QWidget Summary: Fixes the build with D8705 Test Plan: Just adds includes, I wonder if it should go into Plasma/5.8 and /5.11 too Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: graesslin, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8706
2017-11-08 13:23:00 +03:00
Qt5::Widgets
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
KF5::ConfigCore
KF5::ConfigGui
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
KF5::I18n
KF5::Notifications
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
KF5::WindowSystem
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin_testScreens COMMAND testScreens)
[auto-tests] Add an initial test for Screens This is a very interesting auto test as Screens uses both Workspace and Client. Thus it operates in the "impossible to mock" area. The solution is to provide mock includes in autotests and ensure that when building the auto-test the mock header includes will be picked first. There is now a mock class for Workspace and Client providing just the API pieces used inside Screens. As Screens is abstract and we cannot properly interact with QDesktopWidget there is also a MockScreens class inheriting from Screens and mocking the required functionality (by just operating on a list of QRects). The auto-test itself is only performing checks on the abstract class. The mock class is indirectly tested by Screens calling into the virtual methods. The test case is not yet complete, but looking quite good already.
2014-09-17 12:29:03 +04:00
ecm_mark_as_test(testScreens)
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
########################################################
# Test XrandRScreens
########################################################
set( testXRandRScreens_SRCS
test_xrandr_screens.cpp
[autotests] Adjust to changes regarding AbstractClient We need a Mock for AbstractClient and our mock Client needs to inherit from it.
2015-04-29 15:13:20 +03:00
mock_abstract_client.cpp
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
mock_client.cpp
mock_screens.cpp
mock_workspace.cpp
../screens.cpp
Move XRandrScreens to the x11/standalone plugin By moving XRandrScreens the creation of screens gets simplified a lot as there is no need to have windowing system specific init code. It all just goes through the platform. This also marks the point where the first X11 specific code is removed from kwin_wayland. Reviewers: #plasma, sebas Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1355
2016-04-08 11:32:37 +03:00
../plugins/platforms/x11/standalone/screens_xrandr.cpp
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
../xcbutils.cpp # init of extensions
../x11eventfilter.cpp
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
../orientation_sensor.cpp
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
)
kconfig_add_kcfg_files(testXRandRScreens_SRCS ../settings.kcfgc)
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
qt5_add_dbus_adaptor( testXRandRScreens_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.kde.kwin.OrientationSensor.xml ${CMAKE_CURRENT_SOURCE_DIR}/../orientation_sensor.h KWin::OrientationSensor)
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
add_executable( testXRandRScreens ${testXRandRScreens_SRCS} )
target_link_libraries( testXRandRScreens
Qt5::Test
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
Qt5::DBus
Qt5::Gui
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
Qt5::Sensors
Fix build with a KWindowSystem framework that doesn't pull QWidget Summary: Fixes the build with D8705 Test Plan: Just adds includes, I wonder if it should go into Plasma/5.8 and /5.11 too Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: graesslin, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8706
2017-11-08 13:23:00 +03:00
Qt5::Widgets
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
KF5::ConfigCore
KF5::ConfigGui
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
KF5::I18n
KF5::Notifications
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
KF5::WindowSystem
XCB::XCB
XCB::RANDR
XCB::XFIXES
XCB::SYNC
XCB::COMPOSITE
XCB::DAMAGE
XCB::GLX
XCB::SHM
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testXRandRScreens COMMAND testXRandRScreens)
[screens] Replace DesktopWidgetScreens by XRandRScreens A new implementation of the Screens interface is added which uses XRandR directly instead of relying on QDesktopWidget. The implementation is provided in a new implementation file screens_xrandr.cpp. XRandRScreens comes with a unit test. Unfortunately it's rather difficult to provide a proper unit test against XRandR. Xvfb (which is obviously used on the CI system) doesn't provide the XRandR extension. Also on a "normal" developer system one would not want to just execute the test as the results are not predictable (number of available outputs?) and the test would mess up the setup resulting in nobody wanting to execute the test. As a solution to both problems the unit test starts Xephyr as a nested X server. This allows to have at least some limited tests against XRandR. Nevertheless there are a few things which I was not able to test: * multiple outputs * no output at all The nested X Server approach makes the interaction rather complex. Qt opens it's connection against the main X Server thus QX11Info provides a wrong connection and also KWin::connection() which is heavily used by xcbutils and thus all the RandR wrappers have the wrong connection. To circumvent this problem the test is GUILESS. In case it would call into any code using QX11Info, it would probably either runtime fail or crash. REVIEW: 117614
2014-04-17 19:33:11 +04:00
ecm_mark_as_test(testXRandRScreens)
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
########################################################
# Test ScreenEdges
########################################################
set( testScreenEdges_SRCS
test_screen_edges.cpp
[autotests] Adjust to changes regarding AbstractClient We need a Mock for AbstractClient and our mock Client needs to inherit from it.
2015-04-29 15:13:20 +03:00
mock_abstract_client.cpp
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
mock_client.cpp
mock_screens.cpp
mock_workspace.cpp
../atoms.cpp
Add support for activating screenedges through touch swipe gestures Summary: Each Edge creates a SwipeGesture for touch activation. The swipe needs to be a single finger starting from the edge into the screen for at least 20 %. The SwipeGesture and GestureRecognizer is extended to support the use cases of the touch screen edge swipe. New features supported by the gesture system are: * minimum and maximum position * a minimum delta for the swipe * progress signal based on the minimum delta * starting a swipe with a start point The Edge has the progress signal connected to its approach signal, thus visual feedback is provided through the screen edge effect. The screen edge system supports touch only for the edges (corners are too difficult to activate on touch screens). At the moment the following features are supported: * screen edge show/raise of windows (e.g. auto hidden panels) * trigger the configured action * trigger the configured callback function (e.g. script) In future it might make sense to add a touch specific configuration action to support different actions for screen edges activated by mouse and touch. BUG: 370323 Test Plan: configured a screen edge and triggered through touch, added an auto-hiding panel and triggered through touch Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5106
2017-03-19 13:40:03 +03:00
../gestures.cpp
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
../screens.cpp
../screenedge.cpp
../virtualdesktops.cpp
[autotest] Add workaround for broken no-XRandr in screen edge test With Qt 5.5 the physicalSize of a screen is broken if the X system does not provide the XRandR extension. This caused our screen edge test to fail on the CI system (Xvfb) due to approach window being based on the dpi. The problem itself is addressed for Qt in: https://codereview.qt-project.org/126808 This change just worksaround till the change has made it into our CI system (at which point the expected fails will break). Reviewed-By: David Edmundson
2015-09-30 16:06:01 +03:00
../xcbutils.cpp # init of extensions
Create screen edge through the Platform Removes a diversion between X11 and Wayland. The base class Platform creates an instance of class Edge with plugin implementations being able to create a different type. The X11StandalonePlugin does that and creates a WindowBasedEdge. For this the implementation of WindowBasedEdge is moved from screenedges into the plugin. Unfortunately an ifdef is needed to make the screenedge test still work as expected. This should be improved in future, e.g. have a good way to load the platform plugin from the tests. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1419
2016-04-15 14:47:56 +03:00
../plugins/platforms/x11/standalone/edge.cpp
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
../orientation_sensor.cpp
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
)
kconfig_add_kcfg_files(testScreenEdges_SRCS ../settings.kcfgc)
qt5_add_dbus_interface( testScreenEdges_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.freedesktop.ScreenSaver.xml screenlocker_interface)
Add DBus interface to OrientationSensor and a persistent configuration Summary: The initial state for user enabled is now read from config. In addition a DBus interface is provided exporting this property. This allows KScreen to determine whether automatic screen rotation is available and whether the user has it enabled or not. Furthermore KScreen can change the property and this gets stored into the configuration. Thus KScreen can offer a user interface to enable/disable automatic screen rotation as well as enabling/disabling the manual rotation based on the current user settings. Test Plan: Not yet tested, coded on the system which doesn't have an orientation sensor Reviewers: #kwin, #plasma, sebas, davidedmundson Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8738
2017-11-09 20:03:15 +03:00
qt5_add_dbus_adaptor( testScreenEdges_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.kde.kwin.OrientationSensor.xml ${CMAKE_CURRENT_SOURCE_DIR}/../orientation_sensor.h KWin::OrientationSensor)
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
add_executable( testScreenEdges ${testScreenEdges_SRCS})
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 19:47:58 +03:00
set_target_properties(testScreenEdges PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
target_include_directories(testScreenEdges BEFORE PRIVATE ./)
target_link_libraries(testScreenEdges
Qt5::DBus
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
Qt5::Sensors
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
Qt5::Test
Qt5::X11Extras
KF5::ConfigCore
KF5::ConfigGui
KF5::I18n
KF5::GlobalAccel
Support automatic screen rotation based on orientation sensor Summary: This change introduces an OrientationSensor class which wraps a QOrientationSensor. The OrientationSensor is hold by Screens and gets enabled if Screens knows about an internal (e.g. LVDS) display which supports rotation. In addition the OrientationSensor holds an KSni to enable/disable the automatic rotation support. The drm platform plugin is adjusted to make use of the OrientationSensor. The API is defined in a way that this can also be implemented on other platforms supporting rotation. Most important are hwcomposer and X11 standalone. The latter should be straight forward as rotation is provided through XRandR. The former needs addition for rotation support first. Test Plan: Rotated my Yoga 12 Reviewers: #kwin, #plasma, sebas Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D8699
2017-11-06 19:00:15 +03:00
KF5::Notifications
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
KF5::WindowSystem
[wayland] Use the new plasma virtual desktop protocol Summary: implement virtual desktop support for Wayland. use the new virtual desktop protocol from D12820 The VirtualDesktopManager class needed some big change in order to accomodate it, which is where most changes are. Other than that, it's mostly connections to wire up VirtualDesktopsManager and VirtualDesktopsManagement(the wayland protocol impl) Depends on D12820 Other notable detail, is the client visibility updated to reflect the presence of the client in the plasmavirtualdesktop. (and the unSetDesktop concept) Test Plan: used a bit a plasma session together with D12820, D13748 and D13746 Reviewers: #plasma, #kwin, graesslin, davidedmundson Reviewed By: #plasma, #kwin, davidedmundson Subscribers: hein, zzag, davidedmundson, kwin Tags: #kwin Maniphest Tasks: T4457 Differential Revision: https://phabricator.kde.org/D13887
2018-10-30 01:29:15 +03:00
KF5::WaylandServer
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
XCB::XCB
[autotest] Add workaround for broken no-XRandr in screen edge test With Qt 5.5 the physicalSize of a screen is broken if the X system does not provide the XRandR extension. This caused our screen edge test to fail on the CI system (Xvfb) due to approach window being based on the dpi. The problem itself is addressed for Qt in: https://codereview.qt-project.org/126808 This change just worksaround till the change has made it into our CI system (at which point the expected fails will break). Reviewed-By: David Edmundson
2015-09-30 16:06:01 +03:00
XCB::RANDR
XCB::XFIXES
XCB::SYNC
XCB::COMPOSITE
XCB::DAMAGE
XCB::GLX
XCB::SHM
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin_testScreenEdges COMMAND testScreenEdges)
Add an auto-test for ScreenEdges The new test does not cover ScreenEdges completely, so far the following areas are handled: * creating of the edges * reserving of edges * trigger callback * cursor pushback * blocking of edges for fullscreen active clients
2014-09-26 16:01:44 +04:00
ecm_mark_as_test(testScreenEdges)
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 13:53:50 +03:00
########################################################
# Test OnScreenNotification
########################################################
set( testOnScreenNotification_SRCS
onscreennotificationtest.cpp
../onscreennotification.cpp
Fade out OnScreenNotification when moving with the mouse over it Summary: This change triggers a fade out animation when the mouse is moved over the OnScreenNotification, thus revealing the windows underneath. When moving the mouse out of the OnScreenNotification it gets faded in again. This is useful for various cases, e.g. when picking a color and the pixel one wants to pick is underneath the notification, or when trying to kill a window... Test Plan: Manual testing in nested setup Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3964
2017-01-04 20:01:25 +03:00
../input_event_spy.cpp
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 13:53:50 +03:00
)
add_executable( testOnScreenNotification ${testOnScreenNotification_SRCS})
target_link_libraries(testOnScreenNotification
Qt5::Test
Fade out OnScreenNotification when moving with the mouse over it Summary: This change triggers a fade out animation when the mouse is moved over the OnScreenNotification, thus revealing the windows underneath. When moving the mouse out of the OnScreenNotification it gets faded in again. This is useful for various cases, e.g. when picking a color and the pixel one wants to pick is underneath the notification, or when trying to kill a window... Test Plan: Manual testing in nested setup Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3964
2017-01-04 20:01:25 +03:00
Qt5::Widgets # QAction include
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 13:53:50 +03:00
Qt5::Quick
KF5::ConfigCore
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testOnScreenNotification COMMAND testOnScreenNotification)
Introduce a KWin internal on-screen-notification service Summary: Recently we noticed that there are multiple areas where KWin needs to inform the user about how to operate. Examples are: * Screenshot * ColorPicker * Pointer constraint enabled * Pointer constraint about to be removed * Kill Window For Screenshot and ColorPicker we used an EffectFrame to render it. But this is not an optimal solution as it's lacking many features we would need. We cannot properly use it from within KWin core, we cannot implement features like hide on mouse over, etc. etc. This change introduces an OnScreenNotification which supports: * showing an icon * showing a message * timeout It is Qml styled, so that it can be easily adjusted. This is a big improvement over the EffectFrame solution. The Qml file creates a Plasma Dialog of type OSD. Thus KWin places it like the normal OSD windows and also looks kind of similar. In the case of KWin the focus is more on the message, than an icon, so the icon is placed left of the text. While the OnScreenNotification is supposed to be used like a singleton, it doesn't use the KWin singleton pattern. Instead a small wrapper namespace OSD is introduced which provides a convenient API for KWin internal areas to show/hide the notification. By not using the KWin singleton pattern, the OnScreenNotification does not depend on any other parts of KWin and can be easily unit-tested. A few features are still missing and will be added in further commits: * hide-out on mouse over * optional skip close animation (needed for screenshot) * X11 support (not that important as it's mostly for Wayland features) Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D3723
2016-12-18 13:53:50 +03:00
ecm_mark_as_test(testOnScreenNotification)
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 13:00:30 +03:00
########################################################
# Test Gestures
########################################################
set( testGestures_SRCS
test_gestures.cpp
../gestures.cpp
)
add_executable( testGestures ${testGestures_SRCS})
target_link_libraries(testGestures
Qt5::Test
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testGestures COMMAND testGestures)
Add support for global touchpad swipe gestures Summary: This change adds global touchpad swipe gestures to the GlobalShortcutsManager and hooks up the swipe gestures as defined at the Plasma Affenfels sprint: * swipe up: Desktop Grid * swipe down: Present Windows * swipe left: previous virtual desktop * swipe right: next virtual desktop The main work is handled by two new classes: SwipeGesture and GestureRecognizer. This is implemented in a way that it can be extended to also recognize touch screen gestures and pinch gestures. The SwipeGesture defines what is required for the gesture to trigger. Currently this includes the minimum and maximum number of fingers participating in the gesture and the direction. The gesture gets registered in the GestureRecognizer. The events for the gesture are fed into the GestureRecognizer. It evaluates which gestures could trigger and tracks them for every update of the gesture. In the process of the gesture tracking the GestureRecognizer emits signals on the Gesture: * started: when the Gesture gets considered for a sequence * cancelled: the Gesture no longer matches the sequence * triggered: the sequence ended and the Gesture still matches The remaining changes are related to hook up the existing shortcut framework with the new touchpad gestures. The GlobalShortcutManager gained support for it, InputRedirection and EffectsHandler offer methods to register a QAction. VirtualDesktopManager, PresentWindows and DesktopGrid are adjusted to support the gesture. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel Tags: #plasma_on_wayland Differential Revision: https://phabricator.kde.org/D5097
2017-03-18 13:00:30 +03:00
ecm_mark_as_test(testGestures)
Merge branch 'Plasma/5.9'
2017-05-05 20:16:38 +03:00
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 22:17:25 +03:00
########################################################
# Test X11 TimestampUpdate
########################################################
add_executable(testX11TimestampUpdate test_x11_timestamp_update.cpp)
target_link_libraries(testX11TimestampUpdate
Qt5::Test
[autotests] Fix testX11TimestampUpdate after latest change We need to init the X11 standalone platform plugin now.
2017-08-24 22:48:29 +03:00
KF5::CoreAddons
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 22:17:25 +03:00
kwin
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testX11TimestampUpdate COMMAND testX11TimestampUpdate)
Improve the x11 timestamp handling Summary: So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates problems when the 32 bit msec based time stamp wraps around which happens after running an X server for 49 days. After the timestamp wrapped around KWin would not update the timestamp any more and thus some calls might fail. Most prominent victims are keyboard and pointer grab which fails as the timestamp is either larger than the server timestamp or smaller than the last grab timestamp. Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh which used to send a timestamp as unix time which is larger than the x timestamp and thus our timestamp gets too large. This change addresses these problems by allowing to reset the timestamp. This is only used from updateXTime (which is normally invoked before we do things like grabKeyboard). Thus we make QX11Info::getTimestamp the ultimate trusted source for timestamps. BUG: 377901 BUG: 348569 FIXED-IN: 5.8.7 Test Plan: As I cannot wait 50 days: unit tests for the two conditions added. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5704
2017-05-03 22:17:25 +03:00
ecm_mark_as_test(testX11TimestampUpdate)
Refactor the specification of OpenGL context attributes Summary: The current way to specify the OpenGL context attributes does no longer scale as can be seen in D6344. There are too many different context attribute sets and with every addition we grow lots of copied code. The chances to introduce errors in that code which is difficult to debug are very high. As can be seen in the glx backend which defines major 1, minor 2, but it should be major 2, minor 1. This change reworks this code by creating a builder class which contains only an abstract definition of what needs to be in the attributes. E.g. the version, whether it's robust and so on. Now we can just have a list of possible attributes in a well described way: auto builder; builder.setVersion(3, 1); builder.setRobust(true); All possible builders are added to a list and operated on in a for loop which tries to creat a context. Once it succeeded it breaks the list. In addition a debug statement is added which prints out the set of options which went into the context. So far this is only done for EGL, GLX can follow once D6344 is merged. Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6396
2017-06-26 07:56:55 +03:00
[platforms/x11] Use a GlxContextAttributeBuilder Summary: Based on the work of 3f4995fb9b4fd753a304ea65020bbafdd174936b this change introduces a GlxContextAttributeBuilder to make the requesting of context attributes cleaner, more verbose and less error prone copy and paste. Test Plan: Switched between Core and legacy and verified the output; extended auto test Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D6411
2017-06-27 22:08:19 +03:00
set(testOpenGLContextAttributeBuilder_SRCS
opengl_context_attribute_builder_test.cpp
../abstract_opengl_context_attribute_builder.cpp
../egl_context_attribute_builder.cpp
)
if(HAVE_EPOXY_GLX)
set(testOpenGLContextAttributeBuilder_SRCS ${testOpenGLContextAttributeBuilder_SRCS} ../plugins/platforms/x11/standalone/glx_context_attribute_builder.cpp)
endif()
add_executable(testOpenGLContextAttributeBuilder ${testOpenGLContextAttributeBuilder_SRCS})
Refactor the specification of OpenGL context attributes Summary: The current way to specify the OpenGL context attributes does no longer scale as can be seen in D6344. There are too many different context attribute sets and with every addition we grow lots of copied code. The chances to introduce errors in that code which is difficult to debug are very high. As can be seen in the glx backend which defines major 1, minor 2, but it should be major 2, minor 1. This change reworks this code by creating a builder class which contains only an abstract definition of what needs to be in the attributes. E.g. the version, whether it's robust and so on. Now we can just have a list of possible attributes in a well described way: auto builder; builder.setVersion(3, 1); builder.setRobust(true); All possible builders are added to a list and operated on in a for loop which tries to creat a context. Once it succeeded it breaks the list. In addition a debug statement is added which prints out the set of options which went into the context. So far this is only done for EGL, GLX can follow once D6344 is merged. Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6396
2017-06-26 07:56:55 +03:00
target_link_libraries(testOpenGLContextAttributeBuilder Qt5::Test)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testOpenGLContextAttributeBuilder COMMAND testOpenGLContextAttributeBuilder)
Refactor the specification of OpenGL context attributes Summary: The current way to specify the OpenGL context attributes does no longer scale as can be seen in D6344. There are too many different context attribute sets and with every addition we grow lots of copied code. The chances to introduce errors in that code which is difficult to debug are very high. As can be seen in the glx backend which defines major 1, minor 2, but it should be major 2, minor 1. This change reworks this code by creating a builder class which contains only an abstract definition of what needs to be in the attributes. E.g. the version, whether it's robust and so on. Now we can just have a list of possible attributes in a well described way: auto builder; builder.setVersion(3, 1); builder.setRobust(true); All possible builders are added to a list and operated on in a for loop which tries to creat a context. Once it succeeded it breaks the list. In addition a debug statement is added which prints out the set of options which went into the context. So far this is only done for EGL, GLX can follow once D6344 is merged. Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6396
2017-06-26 07:56:55 +03:00
ecm_mark_as_test(testOpenGLContextAttributeBuilder)
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 17:48:03 +03:00
set(testXkb_SRCS
test_xkb.cpp
../xkb.cpp
)
add_executable(testXkb ${testXkb_SRCS})
target_link_libraries(testXkb
Qt5::Test
Qt5::Gui
Qt5::Widgets
KF5::ConfigCore
KF5::WindowSystem
KF5::WaylandServer
XKB::XKB
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testXkb COMMAND testXkb)
[autotests] Add test case for Xkb::toQtKey Tests all key codes KKeyServer is able to map to Qt.
2017-08-15 17:48:03 +03:00
ecm_mark_as_test(testXkb)
[platforms/drm] Use a shared pointer for gbm_surface Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152
2017-10-05 19:58:57 +03:00
if(HAVE_GBM)
add_executable(testGbmSurface test_gbm_surface.cpp ../plugins/platforms/drm/gbm_surface.cpp)
target_link_libraries(testGbmSurface Qt5::Test)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testGbmSurface COMMAND testGbmSurface)
[autotests] Fix typo
2017-10-11 19:31:43 +03:00
ecm_mark_as_test(testGbmSurface)
[platforms/drm] Use a shared pointer for gbm_surface Summary: The gbm_surface is owned by the EglGbmBackend, but it's not the only one using it. The DrmSurfaceBuffer is also using it and needs it to destroy the gbm_bo. Now this can become a problem in the following situation: * a page flip is still pending * the EglGbmBackend destroys the gbm_surface -> when the page flip happens the DrmSurfaceBuffer will try to destroy the gbm_bo and crash as the gbm_surface is no longer valid. This situation can happen when switching screens or when switching compositing backend (OpenGL 2 -> OpenGL 3). To address this problem a class GbmSurface is added which wrapps the gbm_surface pointer. The EglGbmBackend creates and holds a shared pointer to the GbmSurface and passes that one to the DrmSurfaceBuffer. So when cleaning up the gbm_surface only the shared pointer is reset and in case the DrmSurfaceBuffer still needs it, it can access it without problems. BUG: 385372 FIXED-IN: 5.11.0 Test Plan: Not yet Reviewers: #kwin, #plasma, subdiff Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8152
2017-10-05 19:58:57 +03:00
endif()
Add DBus protocol to virtual keyboard Summary: This change adds a DBus API to query whether the virtual keyboard is currently enabled and provides DBus methods to request that the virtual keyboard gets enabled/disabled. This is useful for e.g. providing a Plasmoid or for convertables where the tablet mode needs to be enabled. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8166
2017-10-06 22:22:50 +03:00
add_executable(testVirtualKeyboardDBus test_virtualkeyboard_dbus.cpp ../virtualkeyboard_dbus.cpp)
target_link_libraries(testVirtualKeyboardDBus
Qt5::Test
Qt5::DBus
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 19:18:20 +03:00
add_test(NAME kwin-testVirtualKeyboardDBus COMMAND testVirtualKeyboardDBus)
Add DBus protocol to virtual keyboard Summary: This change adds a DBus API to query whether the virtual keyboard is currently enabled and provides DBus methods to request that the virtual keyboard gets enabled/disabled. This is useful for e.g. providing a Plasmoid or for convertables where the tablet mode needs to be enabled. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8166
2017-10-06 22:22:50 +03:00
ecm_mark_as_test(testVirtualKeyboardDBus)