Quick tile only resizeable clients

Summary:
Maximized clients weren't considered as resizeable when quick tiling was
added. Therefore, a special case was added in Client::setQuickTileMode().
However, that special case didn't take into account that a fullscreen
client can be also maximized. Clearly, we don't want users quick tile
fullscreen clients.

BUG: 411028
FIXED-IN: 5.17.0

Test Plan: No longer able to quick tile maximized fullscreen window of Konsole.

Reviewers: #kwin

Subscribers: romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D23604
icc-effect-5.17.5
Vlad Zagorodniy 2019-09-05 09:50:10 +03:00
parent e8f8033dc8
commit 2963c9ca56
1 changed files with 3 additions and 2 deletions

View File

@ -3221,9 +3221,10 @@ QRect AbstractClient::electricBorderMaximizeGeometry(QPoint pos, int desktop)
void AbstractClient::setQuickTileMode(QuickTileMode mode, bool keyboard)
{
// Only allow quick tile on a regular or maximized window
if (!isResizable() && maximizeMode() != MaximizeFull)
// Only allow quick tile on a regular window.
if (!isResizable()) {
return;
}
workspace()->updateFocusMousePosition(Cursor::pos()); // may cause leave event