From 33492358e5f898490df0ede658783eac3801c984 Mon Sep 17 00:00:00 2001 From: Casian Andrei Date: Tue, 22 May 2012 19:51:33 +0300 Subject: [PATCH] Fix windows like kickoff from disappearing When trying to launch kickoff (start menu) or the add widgets from Plasma, they disappeared immediately after appearing, making them completely unusable. This regression was traced back to commit bf0a241c2462072fbc52012784fa51b9b42a1baf. In Client::setOnActivities, if newActivitiesList was empty, after joining it and splitting it back, it would contain an empty string, i.e. it would have a different size than before. This eventually caused the problems. REVIEW: 105016 --- client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client.cpp b/client.cpp index dd2ad52ffe..046893ac51 100644 --- a/client.cpp +++ b/client.cpp @@ -1627,7 +1627,7 @@ void Client::setOnActivities(QStringList newActivitiesList) { QString joinedActivitiesList = newActivitiesList.join(","); joinedActivitiesList = rules()->checkActivity(joinedActivitiesList, false); - newActivitiesList = joinedActivitiesList.split(','); + newActivitiesList = joinedActivitiesList.split(',', QString::SkipEmptyParts); QStringList allActivities = workspace()->activityList(); if (newActivitiesList.size() == allActivities.size() || newActivitiesList.isEmpty()) {