Remove default button on kwinrules KCM

Summary:
The "default" button was behaving the same as "reset" which was unnecessary and confusing.

As the only settings are the list of rules, the only meaning "default" could have is to clear all the rules, which is probably not what the user would want. So I think the best course of action is to remove the button.

Reviewers: zzag, meven, crossi, bport, ervin

Reviewed By: zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D28071
master
Henri Chain 2020-03-09 19:39:08 +01:00
parent 7c1c9d8164
commit 518c85e91e
4 changed files with 1 additions and 12 deletions

View File

@ -51,6 +51,7 @@ KCMRules::KCMRules(QWidget *parent, const QVariantList &)
QString(), QString(), KAboutLicense::GPL, i18n("(c) 2004 KWin and KControl Authors"));
about->addAuthor(i18n("Lubos Lunak"), QString(), "l.lunak@kde.org");
setAboutData(about);
setButtons(KCModule::Help | KCModule::Apply);
}
void KCMRules::load()
@ -70,11 +71,6 @@ void KCMRules::save()
}
void KCMRules::defaults()
{
widget->defaults();
}
QString KCMRules::quickHelp() const
{
return i18n("<p><h1>Window-specific Settings</h1> Here you can customize window settings specifically only"

View File

@ -38,7 +38,6 @@ public:
KCMRules(QWidget *parent, const QVariantList &args);
void load() override;
void save() override;
void defaults() override;
QString quickHelp() const override;
protected Q_SLOTS:
void moduleChanged(bool state);

View File

@ -229,10 +229,5 @@ void KCMRulesList::save()
m_settings.save();
}
void KCMRulesList::defaults()
{
load();
}
} // namespace

View File

@ -36,7 +36,6 @@ public:
~KCMRulesList() override;
void load();
void save();
void defaults();
Q_SIGNALS:
void changed(bool);
private Q_SLOTS: