vitalif
/
kwin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

screencasting: Choose the correct GL type to download into an image 

BUG: 466299
icc-effect-5.27.2
Aleix Pol 2023-02-27 16:51:15 +01:00 committed by Aleix Pol Gonzalez
parent d30b7e49ab
commit 548ccc8036
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/plugins/screencast/screencastutils.h
View File

@ -25,6 +25,24 @@ static void mirrorVertically(uchar *data, int height, int stride)
}
}
static GLenum closestGLType(const QImage &image)
{
switch (image.format()) {
case QImage::Format_RGB888:
return GL_RGB;
case QImage::Format_BGR888:
return GL_BGR;
case QImage::Format_RGB32:
case QImage::Format_RGBX8888:
case QImage::Format_RGBA8888:
case QImage::Format_RGBA8888_Premultiplied:
return GL_RGBA;
default:
qDebug() << "unknown format" << image.format();
return GL_RGBA;
}
}
static void grabTexture(GLTexture *texture, QImage *image)
{
Q_ASSERT(texture->size() == image->size());
@ -39,11 +57,11 @@ static void grabTexture(GLTexture *texture, QImage *image)
texture->bind();
if (GLPlatform::instance()->isGLES()) {
glReadPixels(0, 0, image->width(), image->height(), image->hasAlphaChannel() ? GL_BGRA : GL_BGR, GL_UNSIGNED_BYTE, (GLvoid *)image->bits());
glReadPixels(0, 0, image->width(), image->height(), closestGLType(*image), GL_UNSIGNED_BYTE, (GLvoid *)image->bits());
} else if (GLPlatform::instance()->glVersion() >= kVersionNumber(4, 5)) {
glGetTextureImage(texture->texture(), 0, image->hasAlphaChannel() ? GL_BGRA : GL_BGR, GL_UNSIGNED_BYTE, image->sizeInBytes(), image->bits());
glGetTextureImage(texture->texture(), 0, closestGLType(*image), GL_UNSIGNED_BYTE, image->sizeInBytes(), image->bits());
} else {
glGetTexImage(texture->target(), 0, image->hasAlphaChannel() ? GL_BGRA : GL_BGR, GL_UNSIGNED_BYTE, image->bits());
glGetTexImage(texture->target(), 0, closestGLType(*image), GL_UNSIGNED_BYTE, image->bits());
}
if (invertNeededAndSupported) {