vitalif
/
kwin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

KCM Compositing: Fix save state 

use settings objects to track state instead of a class member that will need to be synchronized.

BUG: 423223
master
Benjamin Port 2020-06-22 09:20:13 +02:00
parent b5040fe425
commit a8979aa4e4
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
kcmkwin/kwincompositing/main.cpp
View File

@ -70,11 +70,6 @@ private:
OrgKdeKwinCompositingInterface *m_compositingInterface;
KWinCompositingSetting *m_settings;
// unmanaged states
int m_backend;
bool m_glCore;
double m_animationDurationFactor;
};
static const QVector<qreal> s_animationMultipliers = {8, 4, 2, 1, 0.5, 0.25, 0.125, 0};
@ -215,10 +210,10 @@ void KWinCompositingKCM::updateUnmanagedItemStatus()
const bool inPlasma = isRunningPlasma();
bool changed = glCore != m_glCore;
changed |= backend != m_backend;
bool changed = glCore != m_settings->glCore();
changed |= backend != m_settings->backend();
if (!inPlasma) {
changed |= (animationDuration != m_animationDurationFactor);
changed |= (animationDuration != m_settings->animationDurationFactor());
}
unmanagedWidgetChangeState(changed);
@ -244,10 +239,9 @@ void KWinCompositingKCM::load()
m_settings->findItem("Backend")->readConfig(m_settings->config());
m_settings->findItem("glCore")->readConfig(m_settings->config());
m_backend = m_settings->backend();
m_glCore = m_settings->glCore();
if (m_backend == KWinCompositingSetting::EnumBackend::OpenGL) {
if (m_glCore) {
if (m_settings->backend() == KWinCompositingSetting::EnumBackend::OpenGL) {
if (m_settings->glCore()) {
m_form.backend->setCurrentIndex(CompositingTypeIndex::OPENGL31_INDEX);
} else {
m_form.backend->setCurrentIndex(CompositingTypeIndex::OPENGL20_INDEX);