vitalif
/
kwin
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Pass area by const reference to placeFoo methods

icc-effect-5.17.5
Vlad Zahorodnii 2019-09-12 17:52:47 +03:00
parent 87a2100f6a
commit bccbb8f3a5
7 changed files with 29 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
abstract_client.cpp
View File

@ -88,7 +88,7 @@ AbstractClient::AbstractClient()
Q_UNUSED(c)
if (isOnScreenDisplay() && !geometry().isEmpty() && old.size() != geometry().size() && !isInitialPositionSet()) {
GeometryUpdatesBlocker blocker(this);
QRect area = workspace()->clientArea(PlacementArea, Screens::self()->current(), desktop());
const QRect area = workspace()->clientArea(PlacementArea, Screens::self()->current(), desktop());
Placement::self()->place(this, area);
setGeometryRestore(geometry());
}

2
manage.cpp
View File

@ -360,6 +360,8 @@ bool Client::manage(xcb_window_t w, bool isMapped)
if (!placementDone) {
// Placement needs to be after setting size
Placement::self()->place(this, area);
// The client may have been moved to another screen, update placement area.
area = workspace()->clientArea(PlacementArea, this);
dontKeepInArea = true;
placementDone = true;
}

27
placement.cpp
View File

@ -54,7 +54,7 @@ Placement::~Placement()
/**
* Places the client \a c according to the workspace's layout policy
*/
void Placement::place(AbstractClient* c, QRect& area)
void Placement::place(AbstractClient *c, const QRect &area)
{
Policy policy = c->rules()->checkPlacement(Default);
if (policy != Default) {
@ -78,7 +78,7 @@ void Placement::place(AbstractClient* c, QRect& area)
place(c, area, options->placement());
}
void Placement::place(AbstractClient* c, QRect& area, Policy policy, Policy nextPlacement)
void Placement::place(AbstractClient *c, const QRect &area, Policy policy, Policy nextPlacement)
{
if (policy == Unknown)
policy = Default;
@ -374,7 +374,7 @@ QPoint Workspace::cascadeOffset(const AbstractClient *c) const
/**
* Place windows in a cascading order, remembering positions for each desktop
*/
void Placement::placeCascaded(AbstractClient* c, QRect& area, Policy nextPlacement)
void Placement::placeCascaded(AbstractClient *c, const QRect &area, Policy nextPlacement)
{
if (!c->size().isValid()) {
return;
@ -481,7 +481,7 @@ void Placement::placeZeroCornered(AbstractClient* c, const QRect& area, Policy /
c->move(checkArea(c, area).topLeft());
}
void Placement::placeUtility(AbstractClient* c, QRect& area, Policy /*next*/)
void Placement::placeUtility(AbstractClient *c, const QRect &area, Policy /*next*/)
{
// TODO kwin should try to place utility windows next to their mainwindow,
// preferably at the right edge, and going down if there are more of them
@ -491,7 +491,7 @@ void Placement::placeUtility(AbstractClient* c, QRect& area, Policy /*next*/)
place(c, area, Default);
}
void Placement::placeOnScreenDisplay(AbstractClient* c, QRect& area)
void Placement::placeOnScreenDisplay(AbstractClient *c, const QRect &area)
{
// place at lower 1/3 of the screen
const int x = area.left() + (area.width() - c->width()) / 2;
@ -519,27 +519,25 @@ void Placement::placeTransient(AbstractClient *c)
}
}
void Placement::placeDialog(AbstractClient* c, QRect& area, Policy nextPlacement)
void Placement::placeDialog(AbstractClient *c, const QRect &area, Policy nextPlacement)
{
placeOnMainWindow(c, area, nextPlacement);
}
void Placement::placeUnderMouse(AbstractClient* c, QRect& area, Policy /*next*/)
void Placement::placeUnderMouse(AbstractClient *c, const QRect &area, Policy /*next*/)
{
area = checkArea(c, area);
QRect geom = c->geometry();
geom.moveCenter(Cursor::pos());
c->move(geom.topLeft());
c->keepInArea(area); // make sure it's kept inside workarea
}
void Placement::placeOnMainWindow(AbstractClient* c, QRect& area, Policy nextPlacement)
void Placement::placeOnMainWindow(AbstractClient *c, const QRect &area, Policy nextPlacement)
{
if (nextPlacement == Unknown)
nextPlacement = Centered;
if (nextPlacement == Maximizing) // maximize if needed
placeMaximizing(c, area, NoPlacement);
area = checkArea(c, area);
auto mainwindows = c->mainClients();
AbstractClient* place_on = nullptr;
AbstractClient* place_on2 = nullptr;
@ -582,11 +580,11 @@ void Placement::placeOnMainWindow(AbstractClient* c, QRect& area, Policy nextPla
geom.moveCenter(place_on->geometry().center());
c->move(geom.topLeft());
// get area again, because the mainwindow may be on different xinerama screen
area = checkArea(c, QRect());
c->keepInArea(area); // make sure it's kept inside workarea
const QRect placementArea = checkArea(c, QRect());
c->keepInArea(placementArea); // make sure it's kept inside workarea
}
void Placement::placeMaximizing(AbstractClient* c, QRect& area, Policy nextPlacement)
void Placement::placeMaximizing(AbstractClient *c, const QRect &area, Policy nextPlacement)
{
if (nextPlacement == Unknown)
nextPlacement = Smart;
@ -609,8 +607,7 @@ void Placement::cascadeDesktop()
Workspace *ws = Workspace::self();
const int desktop = VirtualDesktopManager::self()->current();
reinitCascading(desktop);
// TODO: make area const once placeFoo methods are fixed to take a const QRect&
QRect area = ws->clientArea(PlacementArea, QPoint(0, 0), desktop);
const QRect area = ws->clientArea(PlacementArea, QPoint(0, 0), desktop);
foreach (Toplevel *toplevel, ws->stackingOrder()) {
auto client = qobject_cast<AbstractClient*>(toplevel);
if (!client ||

18
placement.h
View File

@ -62,17 +62,17 @@ public:
Maximizing
};
void place(AbstractClient* c, QRect& area);
void place(AbstractClient *c, const QRect &area);
void placeAtRandom(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeCascaded(AbstractClient* c, QRect& area, Policy next = Unknown);
void placeCascaded(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeSmart(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeMaximizing(AbstractClient* c, QRect& area, Policy next = Unknown);
void placeMaximizing(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeCentered(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeZeroCornered(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeDialog(AbstractClient* c, QRect& area, Policy next = Unknown);
void placeUtility(AbstractClient* c, QRect& area, Policy next = Unknown);
void placeOnScreenDisplay(AbstractClient* c, QRect& area);
void placeDialog(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeUtility(AbstractClient* c, const QRect& area, Policy next = Unknown);
void placeOnScreenDisplay(AbstractClient* c, const QRect& area);
void reinitCascading(int desktop);
@ -89,9 +89,9 @@ public:
static const char* policyToString(Policy policy);
private:
void place(AbstractClient* c, QRect& area, Policy policy, Policy nextPlacement = Unknown);
void placeUnderMouse(AbstractClient* c, QRect& area, Policy next = Unknown);
void placeOnMainWindow(AbstractClient* c, QRect& area, Policy next = Unknown);
void place(AbstractClient *c, const QRect &area, Policy policy, Policy nextPlacement = Unknown);
void placeUnderMouse(AbstractClient *c, const QRect &area, Policy next = Unknown);
void placeOnMainWindow(AbstractClient *c, const QRect &area, Policy next = Unknown);
void placeTransient(AbstractClient *c);
QRect checkArea(const AbstractClient*c, const QRect& area);

4
shell_client.cpp
View File

@ -399,7 +399,7 @@ void ShellClient::finishInit() {
}
if (needsPlacement) {
QRect area = workspace()->clientArea(PlacementArea, Screens::self()->current(), desktop());
const QRect area = workspace()->clientArea(PlacementArea, Screens::self()->current(), desktop());
placeIn(area);
}
@ -1884,7 +1884,7 @@ void ShellClient::finishCompositing(ReleaseReason releaseReason)
Toplevel::finishCompositing(releaseReason);
}
void ShellClient::placeIn(QRect &area)
void ShellClient::placeIn(const QRect &area)
{
Placement::self()->place(this, area);
setGeometryRestore(geometry());

3
shell_client.h
View File

@ -148,8 +148,7 @@ public:
void killWindow() override;
// TODO: const-ref
void placeIn(QRect &area);
void placeIn(const QRect &area);
bool hasPopupGrab() const override;
void popupDone() override;

4
workspace.cpp
View File

@ -294,7 +294,7 @@ void Workspace::init()
c->updateDecoration(false);
updateClientLayer(c);
if (!c->isInternal()) {
QRect area = clientArea(PlacementArea, Screens::self()->current(), c->desktop());
const QRect area = clientArea(PlacementArea, Screens::self()->current(), c->desktop());
bool placementDone = false;
if (c->isInitialPositionSet()) {
placementDone = true;
@ -329,7 +329,7 @@ void Workspace::init()
updateClientLayer(c);
// TODO: when else should we send the client through placement?
if (c->hasTransientPlacementHint()) {
QRect area = clientArea(PlacementArea, Screens::self()->current(), c->desktop());
const QRect area = clientArea(PlacementArea, Screens::self()->current(), c->desktop());
c->placeIn(area);
}
markXStackingOrderAsDirty();