From e7d6f12bbaf4c94be9ab201431fb2daedad356cd Mon Sep 17 00:00:00 2001
From: Vlad Zagorodniy <vladzzag@gmail.com>
Date: Mon, 2 Jul 2018 11:10:04 +0300
Subject: [PATCH] Lookup loaded effects only once when building support
 information

Test Plan: Ran `qdbus org.kde.KWin /KWin supportInformation`

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13837
---
 effects.cpp | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/effects.cpp b/effects.cpp
index a3864a12ba..c845b985b2 100644
--- a/effects.cpp
+++ b/effects.cpp
@@ -1473,24 +1473,23 @@ QVariant EffectsHandlerImpl::kwinOption(KWinOption kwopt)
 
 QString EffectsHandlerImpl::supportInformation(const QString &name) const
 {
-    if (!isEffectLoaded(name)) {
+    auto it = std::find_if(loaded_effects.constBegin(), loaded_effects.constEnd(),
+        [name](const EffectPair &pair) { return pair.first == name; });
+    if (it == loaded_effects.constEnd()) {
         return QString();
     }
-    for (QVector< EffectPair >::const_iterator it = loaded_effects.constBegin(); it != loaded_effects.constEnd(); ++it) {
-        if ((*it).first == name) {
-            QString support((*it).first + QLatin1String(":\n"));
-            const QMetaObject *metaOptions = (*it).second->metaObject();
-            for (int i=0; i<metaOptions->propertyCount(); ++i) {
-                const QMetaProperty property = metaOptions->property(i);
-                if (qstrcmp(property.name(), "objectName") == 0) {
-                    continue;
-                }
-                support += QString::fromUtf8(property.name()) + QLatin1String(": ") + (*it).second->property(property.name()).toString() + QLatin1Char('\n');
-            }
-            return support;
+
+    QString support((*it).first + QLatin1String(":\n"));
+    const QMetaObject *metaOptions = (*it).second->metaObject();
+    for (int i=0; i<metaOptions->propertyCount(); ++i) {
+        const QMetaProperty property = metaOptions->property(i);
+        if (qstrcmp(property.name(), "objectName") == 0) {
+            continue;
         }
+        support += QString::fromUtf8(property.name()) + QLatin1String(": ") + (*it).second->property(property.name()).toString() + QLatin1Char('\n');
     }
-    return QString();
+
+    return support;
 }