vitalif/kwin - kwin

Commit Graph

Author	SHA1	Message	Date
Vlad Zahorodnii	4ce853e8e4	Prettify license headers	2020-08-07 19:57:56 +00:00
Vlad Zahorodnii	1fb9f6f13a	Switch to SPDX license markers The main advantage of SPDX license identifiers over the traditional license headers is that it's more difficult to overlook inappropriate licenses for kwin, for example GPL 3. We also don't have to copy a lot of boilerplate text. In order to create this change, I ran licensedigger -r -c from the toplevel source directory.	2020-08-07 19:57:56 +00:00
Martin Gräßlin	93e5ebac63	Try to wait for DESTROY_NOTIFY before releasing an Unmanaged So far the Unmanaged got released after an XCB_UNMAP_NOTIFY. This event gets created after xcb_unmap_window or after xcb_destroy_window. In the latter case the window is already distroyed and any of KWin's cleanup calls will cause a BadWindow (or similar) error. The idea to circumvent these errors is to try to wait for the DESTROY_NOTIFY event. To do so the processing of the release is slightly delayed. If KWin gets the destroy notify before the delay times out the Unamanged gets released immediately but with a Destroy flag. For this a new enum ReleaseToplevel is introduced and Unmanage::release takes this as an argument instead of the bool which indicated OnShutdown. Also this enum is added to Toplevel::finishCompositing so that it can ignore the destroyed case and not generate an error. REVIEW: 117422	2014-04-16 13:32:11 +02:00

Author

SHA1

Message

Date

Vlad Zahorodnii

4ce853e8e4

Prettify license headers

2020-08-07 19:57:56 +00:00

Vlad Zahorodnii

1fb9f6f13a

Switch to SPDX license markers

The main advantage of SPDX license identifiers over the traditional
license headers is that it's more difficult to overlook inappropriate
licenses for kwin, for example GPL 3. We also don't have to copy a
lot of boilerplate text.

In order to create this change, I ran licensedigger -r -c from the
toplevel source directory.

2020-08-07 19:57:56 +00:00

Martin Gräßlin

93e5ebac63

Try to wait for DESTROY_NOTIFY before releasing an Unmanaged

So far the Unmanaged got released after an XCB_UNMAP_NOTIFY. This event
gets created after xcb_unmap_window or after xcb_destroy_window. In the
latter case the window is already distroyed and any of KWin's cleanup
calls will cause a BadWindow (or similar) error.

The idea to circumvent these errors is to try to wait for the
DESTROY_NOTIFY event. To do so the processing of the release is slightly
delayed. If KWin gets the destroy notify before the delay times out the
Unamanged gets released immediately but with a Destroy flag. For this a
new enum ReleaseToplevel is introduced and Unmanage::release takes this
as an argument instead of the bool which indicated OnShutdown. Also this
enum is added to Toplevel::finishCompositing so that it can ignore the
destroyed case and not generate an error.

REVIEW: 117422

2014-04-16 13:32:11 +02:00

3 Commits (master)