From 5a991e1fcbcdcca9a191c8e377b4cfb89142761e Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Sat, 12 Feb 2022 14:09:40 +0300 Subject: [PATCH] Do not try to ZDR_DECODE bytes into a preallocated buffer (it also segfaults) --- lib/libnfs-zdr.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/libnfs-zdr.c b/lib/libnfs-zdr.c index 1896851..27f0e48 100644 --- a/lib/libnfs-zdr.c +++ b/lib/libnfs-zdr.c @@ -193,11 +193,7 @@ bool_t libnfs_zdr_bytes(ZDR *zdrs, char **bufp, uint32_t *size, uint32_t maxsize } return TRUE; case ZDR_DECODE: - if (*bufp != NULL) { - memcpy(*bufp, &zdrs->buf[zdrs->pos], *size); - } else { - *bufp = &zdrs->buf[zdrs->pos]; - } + *bufp = &zdrs->buf[zdrs->pos]; zdrs->pos += *size; zdrs->pos = (zdrs->pos + 3) & ~3; return TRUE;