vitalif
/
libnfs
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

nfs_fchown_async: plug potential memleak 

Spotted by clang analyzer.

Signed-off-by: Arne Redlich <arne.redlich@googlemail.com>
libnfs-4.0.0-vitalif
Arne Redlich 2014-02-17 23:17:15 +01:00 committed by Ronnie Sahlberg
parent a128749648
commit b6619d88e6
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libnfs.c
View File

@ -3433,10 +3433,10 @@ int nfs_fchown_async(struct nfs_context *nfs, struct nfsfh *nfsfh, int uid, int
chown_data->uid = uid;
chown_data->gid = gid;
data = malloc(sizeof(struct nfs_cb_data));
if (data == NULL) {
rpc_set_error(nfs->rpc, "out of memory. failed to allocate memory for fchown data");
free(chown_data);
return -1;
}
memset(data, 0, sizeof(struct nfs_cb_data));
@ -3453,7 +3453,6 @@ int nfs_fchown_async(struct nfs_context *nfs, struct nfsfh *nfsfh, int uid, int
}
memcpy(data->fh.data.data_val, nfsfh->fh.data.data_val, data->fh.data.data_len);
if (nfs_chown_continue_internal(nfs, data) != 0) {
free_nfs_cb_data(data);
return -1;