From da03ae5c9f5dd8df0d43f242e69cd79827d466bf Mon Sep 17 00:00:00 2001 From: "Julian M. Kunkel" Date: Tue, 1 Dec 2020 18:24:09 +0000 Subject: [PATCH 1/2] IOR add warning if file exists #273. To stop on warnings, use existing flag --warningAsErrors --- src/ior.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/ior.c b/src/ior.c index 55733d5..674112a 100755 --- a/src/ior.c +++ b/src/ior.c @@ -1293,6 +1293,15 @@ static void TestIoSys(IOR_test_t *test) /* loop over test iterations */ uint64_t params_saved_wearout = params->stoneWallingWearOutIterations; + + /* Check if the file exists and warn users */ + struct stat sb; + GetTestFileName(testFileName, params); + int ret = backend->stat(testFileName, & sb, params->backend_options); + if(ret == 0) { + EWARNF("The file \"%s\" exists already and will be overwritten", testFileName); + } + for (rep = 0; rep < params->repetitions; rep++) { /* Get iteration start time in seconds in task 0 and broadcast to all tasks */ From f71a144b1986ee15b12184276ae974f3fce1aea3 Mon Sep 17 00:00:00 2001 From: "Julian M. Kunkel" Date: Wed, 2 Dec 2020 10:14:28 +0000 Subject: [PATCH 2/2] IOR raise warning for existing file once if not filePerProc. --- src/ior.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/ior.c b/src/ior.c index 674112a..0daddff 100755 --- a/src/ior.c +++ b/src/ior.c @@ -1295,11 +1295,13 @@ static void TestIoSys(IOR_test_t *test) uint64_t params_saved_wearout = params->stoneWallingWearOutIterations; /* Check if the file exists and warn users */ - struct stat sb; - GetTestFileName(testFileName, params); - int ret = backend->stat(testFileName, & sb, params->backend_options); - if(ret == 0) { - EWARNF("The file \"%s\" exists already and will be overwritten", testFileName); + if( params->hints.filePerProc || rank == 0){ + struct stat sb; + GetTestFileName(testFileName, params); + int ret = backend->stat(testFileName, & sb, params->backend_options); + if(ret == 0) { + EWARNF("The file \"%s\" exists already and will be overwritten", testFileName); + } } for (rep = 0; rep < params->repetitions; rep++) {