vitalif
/
mdtest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not execute functions twice in MPI_CHECKF 

Assigning MPI_STATUS to a local variable and then referring to the
local will ensure that the same value is used in both the conditional
expression and the call to MPI_Error_string.

Otherwise, when MPI_STATUS is a function call, like

  MPI_CHECKF(fubar(), "%s", "error in fubar");

fubar() is called twice.  If there are underlying intermittent errors,
the error code/message for the first call is lost, with confusing output
like this:

  read      2206.18    17.27      145.93      262144     131072
  0.272595   291.88     0.290829   292.41
  ERROR: cannot access explicit, noncollective, MPI MPI_SUCCESS: no errors, (aiori-MPIIO.c:451)
master
Olaf Faaland 2020-12-03 10:39:36 -08:00
parent a8ab766483
commit 231868505d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/aiori-debug.h
View File

@ -94,12 +94,13 @@ extern int aiori_warning_as_errors;
#define MPI_CHECKF(MPI_STATUS, FORMAT, ...) do { \
char resultString[MPI_MAX_ERROR_STRING]; \
int resultLength; \
int checkf_mpi_status = MPI_STATUS; \
\
if (MPI_STATUS != MPI_SUCCESS) { \
MPI_Error_string(MPI_STATUS, resultString, &resultLength); \
fprintf(out_logfile, "ERROR: " FORMAT ", MPI %s, (%s:%d)\n", \
if (checkf_mpi_status != MPI_SUCCESS) { \
MPI_Error_string(checkf_mpi_status, resultString, &resultLength);\
fprintf(out_logfile, "ERROR: " FORMAT ", MPI %s, (%s:%d)\n", \
__VA_ARGS__, resultString, __FILE__, __LINE__); \
fflush(out_logfile); \
fflush(out_logfile); \
MPI_Abort(MPI_COMM_WORLD, -1); \
} \
} while(0)