From c702a98376a02841bbc5fe552bfe42028db183f4 Mon Sep 17 00:00:00 2001
From: "Julian M. Kunkel" <juliankunkel@googlemail.com>
Date: Sun, 22 Dec 2019 11:21:40 +0000
Subject: [PATCH] Strict prototypes for AIORI

---
 src/aiori.h  | 8 ++++----
 src/ior.c    | 4 ++--
 src/mdtest.c | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/aiori.h b/src/aiori.h
index 3fc9f06..4be7bd5 100755
--- a/src/aiori.h
+++ b/src/aiori.h
@@ -74,7 +74,7 @@ typedef struct ior_aiori {
                              IOR_offset_t, IOR_param_t *);
         void (*close)(void *, IOR_param_t *);
         void (*delete)(char *, IOR_param_t *);
-        char* (*get_version)();
+        char* (*get_version)(void);
         void (*fsync)(void *, IOR_param_t *);
         IOR_offset_t (*get_file_size)(IOR_param_t *, MPI_Comm, char *);
         int (*statfs) (const char *, ior_aiori_statfs_t *, IOR_param_t * param);
@@ -82,8 +82,8 @@ typedef struct ior_aiori {
         int (*rmdir) (const char *path, IOR_param_t * param);
         int (*access) (const char *path, int mode, IOR_param_t * param);
         int (*stat) (const char *path, struct stat *buf, IOR_param_t * param);
-        void (*initialize)(); /* called once per program before MPI is started */
-        void (*finalize)(); /* called once per program after MPI is shutdown */
+        void (*initialize)(void); /* called once per program before MPI is started */
+        void (*finalize)(void); /* called once per program after MPI is shutdown */
         option_help * (*get_options)(void ** init_backend_options, void* init_values); /* initializes the backend options as well and returns the pointer to the option help structure */
         bool enable_mdtest;
         int (*check_params)(IOR_param_t *); /* check if the provided parameters for the given test and the module options are correct, if they aren't print a message and exit(1) or return 1*/
@@ -123,7 +123,7 @@ void * airoi_update_module_options(const ior_aiori_t * backend, options_all_t *
 const char *aiori_default (void);
 
 /* some generic POSIX-based backend calls */
-char * aiori_get_version();
+char * aiori_get_version (void);
 int aiori_posix_statfs (const char *path, ior_aiori_statfs_t *stat_buf, IOR_param_t * param);
 int aiori_posix_mkdir (const char *path, mode_t mode, IOR_param_t * param);
 int aiori_posix_rmdir (const char *path, IOR_param_t * param);
diff --git a/src/ior.c b/src/ior.c
index 5e343d1..c7c2c27 100755
--- a/src/ior.c
+++ b/src/ior.c
@@ -1268,7 +1268,7 @@ static void TestIoSys(IOR_test_t *test)
         /* IO Buffer Setup */
 
         if (params->setTimeStampSignature) { // initialize the buffer properly
-                params->timeStampSignatureValue = (unsigned int)params->setTimeStampSignature;
+                params->timeStampSignatureValue = (unsigned int) params->setTimeStampSignature;
         }
         XferBuffersSetup(&ioBuffers, params, pretendRank);
         reseed_incompressible_prng = TRUE; // reset pseudo random generator, necessary to guarantee the next call to FillBuffer produces the same value as it is right now
@@ -1289,7 +1289,7 @@ static void TestIoSys(IOR_test_t *test)
                                         ERR("cannot get current time");
                                 }
                                 params->timeStampSignatureValue =
-                                        (unsigned int)currentTime;
+                                        (unsigned int) currentTime;
                                 if (verbose >= VERBOSE_2) {
                                         fprintf(out_logfile,
                                                 "Using Time Stamp %u (0x%x) for Data Signature\n",
diff --git a/src/mdtest.c b/src/mdtest.c
index 05e8a44..3b478ca 100644
--- a/src/mdtest.c
+++ b/src/mdtest.c
@@ -2264,7 +2264,7 @@ mdtest_results_t * mdtest_run(int argc, char **argv, MPI_Comm world_com, FILE *
     }
 
     if (backend->finalize)
-            backend->finalize(NULL);
+            backend->finalize();
 
     return summary_table;
 }