mirror of https://github.com/proxmox/mirror_qemu
qtest: use synchronous I/O for char device
Peter reported that rtc-test would periodically hang. It turns out this was due to an EAGAIN occurring on qemu_chr_fe_write. Instead of heavily refactoring qtest, just use a synchronous version of the write operation for qemu_chr_fe_write to address this problem. Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>master
parent
cd18720a29
commit
0fbf01fe91
2
qtest.c
2
qtest.c
|
@ -191,7 +191,7 @@ static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr,
|
||||||
len = vsnprintf(buffer, sizeof(buffer), fmt, ap);
|
len = vsnprintf(buffer, sizeof(buffer), fmt, ap);
|
||||||
va_end(ap);
|
va_end(ap);
|
||||||
|
|
||||||
qemu_chr_fe_write(chr, (uint8_t *)buffer, len);
|
qemu_chr_fe_write_all(chr, (uint8_t *)buffer, len);
|
||||||
if (qtest_log_fp && qtest_opened) {
|
if (qtest_log_fp && qtest_opened) {
|
||||||
fprintf(qtest_log_fp, "%s", buffer);
|
fprintf(qtest_log_fp, "%s", buffer);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue