ui: avoid pointless VNC updates if framebuffer isn't dirty

The vnc_update_client() method checks the 'has_dirty' flag to see if there are
dirty regions that are pending to send to the client. Regardless of this flag,
if a forced update is requested, updates must be sent. For unknown reasons
though, the code also tries to sent updates if audio capture is enabled. This
makes no sense as audio capture state does not impact framebuffer contents, so
this check is removed.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-5-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
master
Daniel P. Berrange 2017-12-18 19:12:19 +00:00 committed by Gerd Hoffmann
parent b939eb89b6
commit 3541b08475
1 changed files with 1 additions and 1 deletions

View File

@ -984,7 +984,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
return 0;
}
if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) {
if (!vs->has_dirty && !vs->force_update) {
return 0;
}