error handling: Use RETRY_ON_EINTR() macro where applicable

There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h
which handles the same while loop.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415
Signed-off-by: Nikita Ivanov <nivanov@cloudlinux.com>
Message-Id: <20221023090422.242617-3-nivanov@cloudlinux.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
[thuth: Dropped the hunk that changed socket_accept() in libqtest.c]
Signed-off-by: Thomas Huth <thuth@redhat.com>

block/file-posix.c

@@ -1229,9 +1229,7 @@ static int hdev_get_max_segments(int fd, struct stat *st)
         ret = -errno;
         goto out;
     }
-    do {
+    ret = RETRY_ON_EINTR(read(sysfd, buf, sizeof(buf) - 1));
-        ret = read(sysfd, buf, sizeof(buf) - 1);
-    } while (ret == -1 && errno == EINTR);
     if (ret < 0) {
         ret = -errno;
         goto out;
@@ -1379,9 +1377,9 @@ static int handle_aiocb_ioctl(void *opaque)
     RawPosixAIOData *aiocb = opaque;
     int ret;
 
-    do {
+    ret = RETRY_ON_EINTR(
-        ret = ioctl(aiocb->aio_fildes, aiocb->ioctl.cmd, aiocb->ioctl.buf);
+        ioctl(aiocb->aio_fildes, aiocb->ioctl.cmd, aiocb->ioctl.buf)
-    } while (ret == -1 && errno == EINTR);
+    );
     if (ret == -1) {
         return -errno;
     }
@@ -1463,18 +1461,17 @@ static ssize_t handle_aiocb_rw_vector(RawPosixAIOData *aiocb)
 {
     ssize_t len;
 
-    do {
+    len = RETRY_ON_EINTR(
-        if (aiocb->aio_type & QEMU_AIO_WRITE)
+        (aiocb->aio_type & QEMU_AIO_WRITE) ?
-            len = qemu_pwritev(aiocb->aio_fildes,
+            qemu_pwritev(aiocb->aio_fildes,
-                               aiocb->io.iov,
+                           aiocb->io.iov,
-                               aiocb->io.niov,
+                           aiocb->io.niov,
-                               aiocb->aio_offset);
+                           aiocb->aio_offset) :
-         else
+            qemu_preadv(aiocb->aio_fildes,
-            len = qemu_preadv(aiocb->aio_fildes,
+                          aiocb->io.iov,
-                              aiocb->io.iov,
+                          aiocb->io.niov,
-                              aiocb->io.niov,
+                          aiocb->aio_offset)
-                              aiocb->aio_offset);
+    );
-    } while (len == -1 && errno == EINTR);
 
     if (len == -1) {
         return -errno;
@@ -1899,9 +1896,7 @@ static int allocate_first_block(int fd, size_t max_size)
     buf = qemu_memalign(max_align, write_size);
     memset(buf, 0, write_size);
 
-    do {
+    n = RETRY_ON_EINTR(pwrite(fd, buf, write_size, 0));
-        n = pwrite(fd, buf, write_size, 0);
-    } while (n == -1 && errno == EINTR);
 
     ret = (n == -1) ? -errno : 0;
 

chardev/char-pty.c

@@ -93,9 +93,7 @@ static void pty_chr_update_read_handler(Chardev *chr)
     pfd.fd = fioc->fd;
     pfd.events = G_IO_OUT;
     pfd.revents = 0;
-    do {
+    rc = RETRY_ON_EINTR(g_poll(&pfd, 1, 0));
-        rc = g_poll(&pfd, 1, 0);
-    } while (rc == -1 && errno == EINTR);
     assert(rc >= 0);
 
     if (pfd.revents & G_IO_HUP) {

hw/9pfs/9p-local.c

@@ -470,9 +470,7 @@ static ssize_t local_readlink(FsContext *fs_ctx, V9fsPath *fs_path,
         if (fd == -1) {
             return -1;
         }
-        do {
+        tsize = RETRY_ON_EINTR(read(fd, (void *)buf, bufsz));
-            tsize = read(fd, (void *)buf, bufsz);
-        } while (tsize == -1 && errno == EINTR);
         close_preserve_errno(fd);
     } else if ((fs_ctx->export_flags & V9FS_SM_PASSTHROUGH) ||
                (fs_ctx->export_flags & V9FS_SM_NONE)) {
@@ -908,9 +906,7 @@ static int local_symlink(FsContext *fs_ctx, const char *oldpath,
         }
         /* Write the oldpath (target) to the file. */
         oldpath_size = strlen(oldpath);
-        do {
+        write_size = RETRY_ON_EINTR(write(fd, (void *)oldpath, oldpath_size));
-            write_size = write(fd, (void *)oldpath, oldpath_size);
-        } while (write_size == -1 && errno == EINTR);
         close_preserve_errno(fd);
 
         if (write_size != oldpath_size) {

net/l2tpv3.c

@@ -240,9 +240,7 @@ static ssize_t net_l2tpv3_receive_dgram_iov(NetClientState *nc,
     message.msg_control = NULL;
     message.msg_controllen = 0;
     message.msg_flags = 0;
-    do {
+    ret = RETRY_ON_EINTR(sendmsg(s->fd, &message, 0));
-        ret = sendmsg(s->fd, &message, 0);
-    } while ((ret == -1) && (errno == EINTR));
     if (ret > 0) {
         ret -= s->offset;
     } else if (ret == 0) {
@@ -285,9 +283,7 @@ static ssize_t net_l2tpv3_receive_dgram(NetClientState *nc,
     message.msg_control = NULL;
     message.msg_controllen = 0;
     message.msg_flags = 0;
-    do {
+    ret = RETRY_ON_EINTR(sendmsg(s->fd, &message, 0));
-        ret = sendmsg(s->fd, &message, 0);
-    } while ((ret == -1) && (errno == EINTR));
     if (ret > 0) {
         ret -= s->offset;
     } else if (ret == 0) {
@@ -434,12 +430,9 @@ static void net_l2tpv3_send(void *opaque)
 
     msgvec = s->msgvec + s->queue_head;
     if (target_count > 0) {
-        do {
+        count = RETRY_ON_EINTR(
-            count = recvmmsg(
+                recvmmsg(s->fd, msgvec, target_count, MSG_DONTWAIT, NULL)
-                s->fd,
+        );
-                msgvec,
-                target_count, MSG_DONTWAIT, NULL);
-        } while ((count == -1) && (errno == EINTR));
         if (count < 0) {
             /* Recv error - we still need to flush packets here,
              * (re)set queue head to current position

net/socket.c

@@ -117,15 +117,13 @@ static ssize_t net_socket_receive_dgram(NetClientState *nc, const uint8_t *buf,
     NetSocketState *s = DO_UPCAST(NetSocketState, nc, nc);
     ssize_t ret;
 
-    do {
+    ret = RETRY_ON_EINTR(
-        if (s->dgram_dst.sin_family != AF_UNIX) {
+        s->dgram_dst.sin_family != AF_UNIX ?
-            ret = sendto(s->fd, buf, size, 0,
+            sendto(s->fd, buf, size, 0,
-                         (struct sockaddr *)&s->dgram_dst,
+                     (struct sockaddr *)&s->dgram_dst,
-                         sizeof(s->dgram_dst));
+                     sizeof(s->dgram_dst)) :
-        } else {
+            send(s->fd, buf, size, 0)
-            ret = send(s->fd, buf, size, 0);
+    );
-        }
-    } while (ret == -1 && errno == EINTR);
 
     if (ret == -1 && errno == EAGAIN) {
         net_socket_write_poll(s, true);

net/tap.c

@@ -102,9 +102,7 @@ static ssize_t tap_write_packet(TAPState *s, const struct iovec *iov, int iovcnt
 {
     ssize_t len;
 
-    do {
+    len = RETRY_ON_EINTR(writev(s->fd, iov, iovcnt));
-        len = writev(s->fd, iov, iovcnt);
-    } while (len == -1 && errno == EINTR);
 
     if (len == -1 && errno == EAGAIN) {
         tap_write_poll(s, true);
@@ -577,9 +575,7 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
 
         close(sv[1]);
 
-        do {
+        fd = RETRY_ON_EINTR(recv_fd(sv[0]));
-            fd = recv_fd(sv[0]);
-        } while (fd == -1 && errno == EINTR);
         saved_errno = errno;
 
         close(sv[0]);

qga/commands-posix.c

@@ -63,9 +63,7 @@ static void ga_wait_child(pid_t pid, int *status, Error **errp)
 
     *status = 0;
 
-    do {
+    rpid = RETRY_ON_EINTR(waitpid(pid, status, 0));
-        rpid = waitpid(pid, status, 0);
-    } while (rpid == -1 && errno == EINTR);
 
     if (rpid == -1) {
         error_setg_errno(errp, errno, "failed to wait for child (pid: %d)",

semihosting/syscalls.c

@@ -317,9 +317,7 @@ static void host_read(CPUState *cs, gdb_syscall_complete_cb complete,
         complete(cs, -1, EFAULT);
         return;
     }
-    do {
+    ret = RETRY_ON_EINTR(read(gf->hostfd, ptr, len));
-        ret = read(gf->hostfd, ptr, len);
-    } while (ret == -1 && errno == EINTR);
     if (ret == -1) {
         complete(cs, -1, errno);
         unlock_user(ptr, buf, 0);

tests/qtest/libqtest.c

@@ -689,9 +689,7 @@ int qtest_socket_server(const char *socket_path)
     addr.sun_family = AF_UNIX;
     snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", socket_path);
 
-    do {
+    ret = RETRY_ON_EINTR(bind(sock, (struct sockaddr *)&addr, sizeof(addr)));
-        ret = bind(sock, (struct sockaddr *)&addr, sizeof(addr));
-    } while (ret == -1 && errno == EINTR);
     g_assert_cmpint(ret, !=, -1);
     ret = listen(sock, 1);
     g_assert_cmpint(ret, !=, -1);

tests/vhost-user-bridge.c

@@ -331,9 +331,7 @@ vubr_backend_recv_cb(int sock, void *ctx)
             .msg_iovlen = num,
             .msg_flags = MSG_DONTWAIT,
         };
-        do {
+        ret = RETRY_ON_EINTR(recvmsg(vubr->backend_udp_sock, &msg, 0));
-            ret = recvmsg(vubr->backend_udp_sock, &msg, 0);
-        } while (ret == -1 && (errno == EINTR));
 
         if (i == 0) {
             iov_restore_front(elem->in_sg, sg, hdrlen);

util/main-loop.c

@@ -64,9 +64,7 @@ static void sigfd_handler(void *opaque)
     ssize_t len;
 
     while (1) {
-        do {
+        len = RETRY_ON_EINTR(read(fd, &info, sizeof(info)));
-            len = read(fd, &info, sizeof(info));
-        } while (len == -1 && errno == EINTR);
 
         if (len == -1 && errno == EAGAIN) {
             break;

util/osdep.c

@@ -244,9 +244,7 @@ static int qemu_lock_fcntl(int fd, int64_t start, int64_t len, int fl_type)
         .l_type   = fl_type,
     };
     qemu_probe_lock_ops();
-    do {
+    ret = RETRY_ON_EINTR(fcntl(fd, fcntl_op_setlk, &fl));
-        ret = fcntl(fd, fcntl_op_setlk, &fl);
-    } while (ret == -1 && errno == EINTR);
     return ret == -1 ? -errno : 0;
 }
 

util/vfio-helpers.c

@@ -240,9 +240,9 @@ static int qemu_vfio_pci_read_config(QEMUVFIOState *s, void *buf,
                                     s->config_region_info.offset,
                                     s->config_region_info.size);
     assert(QEMU_IS_ALIGNED(s->config_region_info.offset + ofs, size));
-    do {
+    ret = RETRY_ON_EINTR(
-        ret = pread(s->device, buf, size, s->config_region_info.offset + ofs);
+        pread(s->device, buf, size, s->config_region_info.offset + ofs)
-    } while (ret == -1 && errno == EINTR);
+    );
     return ret == size ? 0 : -errno;
 }
 
@@ -254,9 +254,9 @@ static int qemu_vfio_pci_write_config(QEMUVFIOState *s, void *buf, int size, int
                                      s->config_region_info.offset,
                                      s->config_region_info.size);
     assert(QEMU_IS_ALIGNED(s->config_region_info.offset + ofs, size));
-    do {
+    ret = RETRY_ON_EINTR(
-        ret = pwrite(s->device, buf, size, s->config_region_info.offset + ofs);
+        pwrite(s->device, buf, size, s->config_region_info.offset + ofs)
-    } while (ret == -1 && errno == EINTR);
+    );
     return ret == size ? 0 : -errno;
 }