vitalif
/
mirror_qemu
mirror of https://github.com/proxmox/mirror_qemu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/pvrdma: Delete unneeded function argument 

The function's argument rdma_dev_res is not needed as it is stored in
the backend_dev object at init.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-Id: <1552300155-25216-9-git-send-email-yuval.shaia@oracle.com>
Reviewed-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
master
Yuval Shaia 2019-03-11 03:29:12 -07:00 committed by Marcel Apfelbaum
parent bf4414515b
commit 3c890bcf30
3 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hw/rdma/rdma_backend.c
View File

@ -594,7 +594,6 @@ static unsigned int save_mad_recv_buffer(RdmaBackendDev *backend_dev,
} }
void rdma_backend_post_recv(RdmaBackendDev *backend_dev, void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
RdmaDeviceResources *rdma_dev_res,
RdmaBackendQP *qp, uint8_t qp_type, RdmaBackendQP *qp, uint8_t qp_type,
struct ibv_sge *sge, uint32_t num_sge, void *ctx) struct ibv_sge *sge, uint32_t num_sge, void *ctx)
{ {
@ -613,9 +612,9 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
rc = save_mad_recv_buffer(backend_dev, sge, num_sge, ctx); rc = save_mad_recv_buffer(backend_dev, sge, num_sge, ctx);
if (rc) { if (rc) {
complete_work(IBV_WC_GENERAL_ERR, rc, ctx); complete_work(IBV_WC_GENERAL_ERR, rc, ctx);
rdma_dev_res->stats.mad_rx_bufs_err++; backend_dev->rdma_dev_res->stats.mad_rx_bufs_err++;
} else { } else {
rdma_dev_res->stats.mad_rx_bufs++; backend_dev->rdma_dev_res->stats.mad_rx_bufs++;
} }
} }
return; return;
@ -625,7 +624,7 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
bctx->up_ctx = ctx; bctx->up_ctx = ctx;
bctx->backend_qp = qp; bctx->backend_qp = qp;
rc = rdma_rm_alloc_cqe_ctx(rdma_dev_res, &bctx_id, bctx); rc = rdma_rm_alloc_cqe_ctx(backend_dev->rdma_dev_res, &bctx_id, bctx);
if (unlikely(rc)) { if (unlikely(rc)) {
complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NOMEM, ctx); complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NOMEM, ctx);
goto err_free_bctx; goto err_free_bctx;
@ -633,7 +632,7 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
rdma_protected_gslist_append_int32(&qp->cqe_ctx_list, bctx_id); rdma_protected_gslist_append_int32(&qp->cqe_ctx_list, bctx_id);
rc = build_host_sge_array(rdma_dev_res, new_sge, sge, num_sge, rc = build_host_sge_array(backend_dev->rdma_dev_res, new_sge, sge, num_sge,
&backend_dev->rdma_dev_res->stats.rx_bufs_len); &backend_dev->rdma_dev_res->stats.rx_bufs_len);
if (rc) { if (rc) {
complete_work(IBV_WC_GENERAL_ERR, rc, ctx); complete_work(IBV_WC_GENERAL_ERR, rc, ctx);
@ -652,13 +651,13 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
} }
atomic_inc(&backend_dev->rdma_dev_res->stats.missing_cqe); atomic_inc(&backend_dev->rdma_dev_res->stats.missing_cqe);
rdma_dev_res->stats.rx_bufs++; backend_dev->rdma_dev_res->stats.rx_bufs++;
return; return;
err_dealloc_cqe_ctx: err_dealloc_cqe_ctx:
backend_dev->rdma_dev_res->stats.rx_bufs_err++; backend_dev->rdma_dev_res->stats.rx_bufs_err++;
rdma_rm_dealloc_cqe_ctx(rdma_dev_res, bctx_id); rdma_rm_dealloc_cqe_ctx(backend_dev->rdma_dev_res, bctx_id);
err_free_bctx: err_free_bctx:
g_free(bctx); g_free(bctx);

1
hw/rdma/rdma_backend.h
View File

@ -111,7 +111,6 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev,
union ibv_gid *dgid, uint32_t dqpn, uint32_t dqkey, union ibv_gid *dgid, uint32_t dqpn, uint32_t dqkey,
void *ctx); void *ctx);
void rdma_backend_post_recv(RdmaBackendDev *backend_dev, void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
RdmaDeviceResources *rdma_dev_res,
RdmaBackendQP *qp, uint8_t qp_type, RdmaBackendQP *qp, uint8_t qp_type,
struct ibv_sge *sge, uint32_t num_sge, void *ctx); struct ibv_sge *sge, uint32_t num_sge, void *ctx);

3
hw/rdma/vmw/pvrdma_qp_ops.c
View File

@ -231,8 +231,7 @@ void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle)
continue; continue;
} }
rdma_backend_post_recv(&dev->backend_dev, &dev->rdma_dev_res, rdma_backend_post_recv(&dev->backend_dev, &qp->backend_qp, qp->qp_type,
&qp->backend_qp, qp->qp_type,
(struct ibv_sge *)&wqe->sge[0], wqe->hdr.num_sge, (struct ibv_sge *)&wqe->sge[0], wqe->hdr.num_sge,
comp_ctx); comp_ctx);