vitalif
/
mirror_qemu
mirror of https://github.com/proxmox/mirror_qemu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cleanup block driver option handling in vl.c 

Assign directly to the bdrv_flags variable instead of using
magic numbers before translating to the BDRV_O_* options.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
master
Christoph Hellwig 2010-04-06 19:12:04 +02:00 committed by Kevin Wolf
parent c46e116723
commit 763b6084ba
1 changed files with 16 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
vl.c
View File

@ -783,10 +783,8 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
QEMUMachine *machine = opaque; QEMUMachine *machine = opaque;
int max_devs; int max_devs;
int index; int index;
int cache;
int aio = 0;
int ro = 0; int ro = 0;
int bdrv_flags; int bdrv_flags = 0;
int on_read_error, on_write_error; int on_read_error, on_write_error;
const char *devaddr; const char *devaddr;
DriveInfo *dinfo; DriveInfo *dinfo;
@ -795,7 +793,6 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
*fatal_error = 1; *fatal_error = 1;
translation = BIOS_ATA_TRANSLATION_AUTO; translation = BIOS_ATA_TRANSLATION_AUTO;
cache = 1;
if (machine && machine->use_scsi) { if (machine && machine->use_scsi) {
type = IF_SCSI; type = IF_SCSI;
@ -909,13 +906,13 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
} }
if ((buf = qemu_opt_get(opts, "cache")) != NULL) { if ((buf = qemu_opt_get(opts, "cache")) != NULL) {
if (!strcmp(buf, "off") || !strcmp(buf, "none")) if (!strcmp(buf, "off") || !strcmp(buf, "none")) {
cache = 0; bdrv_flags |= BDRV_O_NOCACHE;
else if (!strcmp(buf, "writethrough")) } else if (!strcmp(buf, "writeback")) {
cache = 1; bdrv_flags |= BDRV_O_CACHE_WB;
else if (!strcmp(buf, "writeback")) } else if (!strcmp(buf, "writethrough")) {
cache = 2; /* this is the default */
else { } else {
fprintf(stderr, "qemu: invalid cache option\n"); fprintf(stderr, "qemu: invalid cache option\n");
return NULL; return NULL;
} }
@ -923,11 +920,11 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
#ifdef CONFIG_LINUX_AIO #ifdef CONFIG_LINUX_AIO
if ((buf = qemu_opt_get(opts, "aio")) != NULL) { if ((buf = qemu_opt_get(opts, "aio")) != NULL) {
if (!strcmp(buf, "threads")) if (!strcmp(buf, "native")) {
aio = 0; bdrv_flags |= BDRV_O_NATIVE_AIO;
else if (!strcmp(buf, "native")) } else if (!strcmp(buf, "threads")) {
aio = 1; /* this is the default */
else { } else {
fprintf(stderr, "qemu: invalid aio option\n"); fprintf(stderr, "qemu: invalid aio option\n");
return NULL; return NULL;
} }
@ -1101,20 +1098,10 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
*fatal_error = 0; *fatal_error = 0;
return NULL; return NULL;
} }
bdrv_flags = 0;
if (snapshot) { if (snapshot) {
bdrv_flags |= BDRV_O_SNAPSHOT; /* always use write-back with snapshot */
cache = 2; /* always use write-back with snapshot */ bdrv_flags &= ~BDRV_O_CACHE_MASK;
} bdrv_flags |= (BDRV_O_SNAPSHOT|BDRV_O_CACHE_WB);
if (cache == 0) /* no caching */
bdrv_flags |= BDRV_O_NOCACHE;
else if (cache == 2) /* write-back */
bdrv_flags |= BDRV_O_CACHE_WB;
if (aio == 1) {
bdrv_flags |= BDRV_O_NATIVE_AIO;
} else {
bdrv_flags &= ~BDRV_O_NATIVE_AIO;
} }
if (media == MEDIA_CDROM) { if (media == MEDIA_CDROM) {