From 88a8b27e556f5cb49a19d4c98a96590f61b74ed2 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Fri, 20 Nov 2020 08:31:49 +0100 Subject: [PATCH] qtest: do not return freed argument vector from qtest_rsp If expected_args is 0, qtest frees the argument vector and then returns it nevertheless. Coverity complains; in practice this is not an issue because expected_args == 0 means that the caller is not interested in the argument vector, but it would be a potential problem if somebody wanted to add commands with optional arguments to qtest. Suggested-by: Kamil Dudka Signed-off-by: Paolo Bonzini Message-Id: <20201120073149.99079-1-pbonzini@redhat.com> Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index be0fb430dd..e49f3a1e45 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -545,6 +545,7 @@ redo: } } else { g_strfreev(words); + words = NULL; } return words;