ftgmac100: Check for invalid len and address before doing a DMA transfer

According to the Aspeed specs, no interrupts are raised in that case
but a "Tx-packets lost" status seems like a good modeling choice for
all implementations. It is covered by the Linux kernel.

Cc: Frederic Konrad <konrad.frederic@yahoo.fr>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Message-Id: <20200819100956.2216690-14-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
master
Cédric Le Goater 2020-09-01 14:21:50 +02:00
parent 9c30f092a0
commit af6d66e235
1 changed files with 9 additions and 0 deletions

View File

@ -507,6 +507,15 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t tx_ring,
}
len = FTGMAC100_TXDES0_TXBUF_SIZE(bd.des0);
if (!len) {
/*
* 0 is an invalid size, however the HW does not raise any
* interrupt. Flag an error because the guest is buggy.
*/
qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid segment size\n",
__func__);
}
if (frame_size + len > sizeof(s->frame)) {
qemu_log_mask(LOG_GUEST_ERROR, "%s: frame too big : %d bytes\n",
__func__, len);