From c53af37f375ce9c4999ff451c51173bdc1167e67 Mon Sep 17 00:00:00 2001 From: Corentin Chary Date: Fri, 25 Feb 2011 22:54:53 +0100 Subject: [PATCH] vnc: fix a memory leak in threaded vnc server VncJobQueue's buffer is intended to be used for as the output buffer for all operations in this queue, but unfortunatly. vnc_async_encoding_start() is in charge of setting this buffer as the current output buffer, but vnc_async_encoding_end() was not writting the changes back to VncJobQueue, resulting in a big and ugly memleak. Signed-off-by: Corentin Chary Signed-off-by: Anthony Liguori --- ui/vnc-jobs-async.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c index 1d4c5e7f78..f596247004 100644 --- a/ui/vnc-jobs-async.c +++ b/ui/vnc-jobs-async.c @@ -186,6 +186,8 @@ static void vnc_async_encoding_end(VncState *orig, VncState *local) orig->hextile = local->hextile; orig->zrle = local->zrle; orig->lossy_rect = local->lossy_rect; + + queue->buffer = local->output; } static int vnc_worker_thread_loop(VncJobQueue *queue)