From d6f33c557ce9e4a9c5c7285e7aa71b5884241629 Mon Sep 17 00:00:00 2001 From: Igor Mammedov Date: Tue, 3 Mar 2020 04:12:54 -0500 Subject: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked SOC object returned by object_new() is leaked in current code. Set SOC parent explicitly to board and then unref to SOC object to make sure that refererence returned by object_new() is taken care of. The SOC object will be kept alive by its parent (machine) and will be automatically freed when MachineState is destroyed. Signed-off-by: Igor Mammedov Reported-by: Andrew Jones Tested-by: Niek Linnenbank Message-id: 20200303091254.22373-1-imammedo@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/cubieboard.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c index 871b1beef4..d791817646 100644 --- a/hw/arm/cubieboard.c +++ b/hw/arm/cubieboard.c @@ -54,6 +54,9 @@ static void cubieboard_init(MachineState *machine) } a10 = AW_A10(object_new(TYPE_AW_A10)); + object_property_add_child(OBJECT(machine), "soc", OBJECT(a10), + &error_abort); + object_unref(OBJECT(a10)); object_property_set_int(OBJECT(&a10->emac), 1, "phy-addr", &err); if (err != NULL) {