From d949396e5303f4f916ec3733eee0ab365f500dc8 Mon Sep 17 00:00:00 2001 From: "Edgar E. Iglesias" Date: Tue, 9 Aug 2011 13:24:04 +0200 Subject: [PATCH] etrax: QDevify the Ethernet MAC. Signed-off-by: Edgar E. Iglesias --- hw/cris_pic_cpu.c | 1 + hw/etraxfs.h | 21 +++++++++++-- hw/etraxfs_eth.c | 80 +++++++++++++++++++++++++++++------------------ 3 files changed, 69 insertions(+), 33 deletions(-) diff --git a/hw/cris_pic_cpu.c b/hw/cris_pic_cpu.c index a92d445f29..7f1e4ab855 100644 --- a/hw/cris_pic_cpu.c +++ b/hw/cris_pic_cpu.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ +#include "sysbus.h" #include "hw.h" #include "pc.h" #include "etraxfs.h" diff --git a/hw/etraxfs.h b/hw/etraxfs.h index 5c61f1b41b..1554b0b8e8 100644 --- a/hw/etraxfs.h +++ b/hw/etraxfs.h @@ -25,6 +25,21 @@ #include "etraxfs_dma.h" qemu_irq *cris_pic_init_cpu(CPUState *env); -void etraxfs_eth_init(NICInfo *nd, target_phys_addr_t base, int phyaddr, - struct etraxfs_dma_client *dma_out, - struct etraxfs_dma_client *dma_in); + +/* Instantiate an ETRAXFS Ethernet MAC. */ +static inline DeviceState * +etraxfs_eth_init(NICInfo *nd, target_phys_addr_t base, int phyaddr, + void *dma_out, void *dma_in) +{ + DeviceState *dev; + qemu_check_nic_model(nd, "fseth"); + + dev = qdev_create(NULL, "etraxfs-eth"); + qdev_set_nic_properties(dev, nd); + qdev_prop_set_uint32(dev, "phyaddr", phyaddr); + qdev_prop_set_ptr(dev, "dma_out", dma_out); + qdev_prop_set_ptr(dev, "dma_in", dma_in); + qdev_init_nofail(dev); + sysbus_mmio_map(sysbus_from_qdev(dev), 0, base); + return dev; +} diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 6453077056..92d4ecac8f 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -23,7 +23,7 @@ */ #include -#include "hw.h" +#include "sysbus.h" #include "net.h" #include "etraxfs.h" @@ -319,6 +319,7 @@ static void mdio_cycle(struct qemu_mdio *bus) struct fs_eth { + SysBusDevice busdev; NICState *nic; NICConf conf; int ethregs; @@ -327,8 +328,14 @@ struct fs_eth uint8_t macaddr[2][6]; uint32_t regs[FS_ETH_MAX_REGS]; - struct etraxfs_dma_client *dma_out; - struct etraxfs_dma_client *dma_in; + union { + void *vdma_out; + struct etraxfs_dma_client *dma_out; + }; + union { + void *vdma_in; + struct etraxfs_dma_client *dma_in; + }; /* MDIO bus. */ struct qemu_mdio mdio_bus; @@ -579,37 +586,50 @@ static NetClientInfo net_etraxfs_info = { .link_status_changed = eth_set_link, }; -void etraxfs_eth_init(NICInfo *nd, target_phys_addr_t base, int phyaddr, - struct etraxfs_dma_client *dma_out, - struct etraxfs_dma_client *dma_in) +static int fs_eth_init(SysBusDevice *dev) { - struct fs_eth *eth = NULL; + struct fs_eth *s = FROM_SYSBUS(typeof(*s), dev); + int eth_regs; - qemu_check_nic_model(nd, "fseth"); + if (!s->dma_out || !s->dma_in) { + hw_error("Unconnected ETRAX-FS Ethernet MAC.\n"); + } - eth = qemu_mallocz(sizeof *eth); + s->dma_out->client.push = eth_tx_push; + s->dma_out->client.opaque = s; + s->dma_in->client.opaque = s; + s->dma_in->client.pull = NULL; - dma_out->client.push = eth_tx_push; - dma_out->client.opaque = eth; - dma_in->client.opaque = eth; - dma_in->client.pull = NULL; + eth_regs = cpu_register_io_memory(eth_read, eth_write, s, + DEVICE_LITTLE_ENDIAN); + sysbus_init_mmio(dev, 0x5c, eth_regs); - eth->dma_out = dma_out; - eth->dma_in = dma_in; + qemu_macaddr_default_if_unset(&s->conf.macaddr); + s->nic = qemu_new_nic(&net_etraxfs_info, &s->conf, + dev->qdev.info->name, dev->qdev.id, s); + qemu_format_nic_info_str(&s->nic->nc, s->conf.macaddr.a); - /* Connect the phy. */ - eth->phyaddr = phyaddr & 0x1f; - tdk_init(ð->phy); - mdio_attach(ð->mdio_bus, ð->phy, eth->phyaddr); - - eth->ethregs = cpu_register_io_memory(eth_read, eth_write, eth, - DEVICE_NATIVE_ENDIAN); - cpu_register_physical_memory (base, 0x5c, eth->ethregs); - - eth->conf.macaddr = nd->macaddr; - eth->conf.vlan = nd->vlan; - eth->conf.peer = nd->netdev; - - eth->nic = qemu_new_nic(&net_etraxfs_info, ð->conf, - nd->model, nd->name, eth); + tdk_init(&s->phy); + mdio_attach(&s->mdio_bus, &s->phy, s->phyaddr); + return 0; } + +static SysBusDeviceInfo etraxfs_eth_info = { + .init = fs_eth_init, + .qdev.name = "etraxfs-eth", + .qdev.size = sizeof(struct fs_eth), + .qdev.props = (Property[]) { + DEFINE_PROP_UINT32("phyaddr", struct fs_eth, phyaddr, 1), + DEFINE_PROP_PTR("dma_out", struct fs_eth, vdma_out), + DEFINE_PROP_PTR("dma_in", struct fs_eth, vdma_in), + DEFINE_NIC_PROPERTIES(struct fs_eth, conf), + DEFINE_PROP_END_OF_LIST(), + } +}; + +static void etraxfs_eth_register(void) +{ + sysbus_register_withprop(&etraxfs_eth_info); +} + +device_init(etraxfs_eth_register)