mirror of https://github.com/proxmox/mirror_qemu
target/arm: Use ror32 instead of open-coding the operation
The helper function is more documentary, and also already handles the case of rotate by zero. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20190808202616.13782-5-richard.henderson@linaro.org Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>master
parent
464eaa9571
commit
dd861b3f29
|
@ -7964,8 +7964,7 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
|
|||
/* CPSR = immediate */
|
||||
val = insn & 0xff;
|
||||
shift = ((insn >> 8) & 0xf) * 2;
|
||||
if (shift)
|
||||
val = (val >> shift) | (val << (32 - shift));
|
||||
val = ror32(val, shift);
|
||||
i = ((insn & (1 << 22)) != 0);
|
||||
if (gen_set_psr_im(s, msr_mask(s, (insn >> 16) & 0xf, i),
|
||||
i, val)) {
|
||||
|
@ -8228,9 +8227,7 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
|
|||
/* immediate operand */
|
||||
val = insn & 0xff;
|
||||
shift = ((insn >> 8) & 0xf) * 2;
|
||||
if (shift) {
|
||||
val = (val >> shift) | (val << (32 - shift));
|
||||
}
|
||||
val = ror32(val, shift);
|
||||
tmp2 = tcg_temp_new_i32();
|
||||
tcg_gen_movi_i32(tmp2, val);
|
||||
if (logic_cc && shift) {
|
||||
|
|
Loading…
Reference in New Issue