From e947e9c8012b779dff6039fbe738a5584db6431d Mon Sep 17 00:00:00 2001 From: Kashyap Chamarthy Date: Wed, 5 Aug 2020 12:01:58 +0200 Subject: [PATCH] qapi/block-core.json: Remove stale description of 'blockdev-add' On a 'qemu-discuss' thread[1], Kevin identifies that the current doc blurb for @blockdev-add is stale: This is actually a documentation bug. @id doesn't exist, blockdev-add never creates a BlockBackend. This was different in the very first versions of the patches to add blockdev-add and we probably just forgot to update the documentation after removing it. So remove the stale bits. And the requirement for 'node-name' is already mentioned in the documentation of @BlockdevOptions: [...] # @node-name: the node name of the new node (Since 2.0). # This option is required on the top level of blockdev-add. # Valid node names start with an alphabetic character and may # contain only alphanumeric characters, '-', '.' and '_'. Their # maximum length is 31 characters. [...] [1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html -- equivalent to "-drive if=ide,id=disk0....." Fixes: be4b67bc7d ("blockdev: Allow creation of BDS trees without BB") Signed-off-by: Kashyap Chamarthy Suggested-by: Kevin Wolf Message-Id: <20200805100158.1239390-1-kchamart@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- qapi/block-core.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index db08c58d78..55b58ba892 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -4036,9 +4036,7 @@ ## # @blockdev-add: # -# Creates a new block device. If the @id option is given at the top level, a -# BlockBackend will be created; otherwise, @node-name is mandatory at the top -# level and no BlockBackend will be created. +# Creates a new block device. # # Since: 2.9 #