mirror of https://github.com/proxmox/mirror_qemu
sockets: Plug memory leak in socket_address_flatten()
socket_address_flatten() leaks a SocketAddress when its argument is
null. Happens when opening a ChardevBackend of type 'udp' that is
configured without a local address. Screwed up in commit bd269ebc
due
to last minute semantic conflict resolution. Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1494866344-11013-1-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
master
parent
fe2f74af2b
commit
fc0f005958
|
@ -1338,12 +1338,14 @@ char *socket_address_to_string(struct SocketAddress *addr, Error **errp)
|
||||||
|
|
||||||
SocketAddress *socket_address_flatten(SocketAddressLegacy *addr_legacy)
|
SocketAddress *socket_address_flatten(SocketAddressLegacy *addr_legacy)
|
||||||
{
|
{
|
||||||
SocketAddress *addr = g_new(SocketAddress, 1);
|
SocketAddress *addr;
|
||||||
|
|
||||||
if (!addr_legacy) {
|
if (!addr_legacy) {
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
addr = g_new(SocketAddress, 1);
|
||||||
|
|
||||||
switch (addr_legacy->type) {
|
switch (addr_legacy->type) {
|
||||||
case SOCKET_ADDRESS_LEGACY_KIND_INET:
|
case SOCKET_ADDRESS_LEGACY_KIND_INET:
|
||||||
addr->type = SOCKET_ADDRESS_TYPE_INET;
|
addr->type = SOCKET_ADDRESS_TYPE_INET;
|
||||||
|
|
Loading…
Reference in New Issue