mirror of https://github.com/proxmox/mirror_qemu
aadea887f4
We pass a ResetType argument to the Resettable class enter phase method, but we don't pass it to hold and exit, even though the callsites have it readily available. This means that if a device cared about the ResetType it would need to record it in the enter phase method to use later on. We should pass the type to all three of the phase methods to avoid having to do that. This coccinelle script adds the ResetType argument to the hold and exit phases of the Resettable interface. The first part of the script (rules holdfn_assigned, holdfn_defined, exitfn_assigned, exitfn_defined) update implementations of the interface within device models, both to change the signature of their method implementations and to pass on the reset type when they invoke reset on some other device. The second part of the script is various special cases: * method callsites in resettable_phase_hold(), resettable_phase_exit() and device_phases_reset() * updating the typedefs for the methods * isl_pmbus_vr.c has some code where one device's reset method directly calls the implementation of a different device's method Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Luc Michel <luc.michel@amd.com> Message-id: 20240412160809.1260625-4-peter.maydell@linaro.org |
||
|---|---|---|
| .. | ||
| cpu-reset.cocci | ||
| cpu_restore_state.cocci | ||
| err-bad-newline.cocci | ||
| error-use-after-free.cocci | ||
| error_propagate_null.cocci | ||
| errp-guard.cocci | ||
| exec_rw_const.cocci | ||
| inplace-byteswaps.cocci | ||
| memory-region-housekeeping.cocci | ||
| overflow_muldiv64.cocci | ||
| qobject.cocci | ||
| qom-parent-type.cocci | ||
| remove_local_err.cocci | ||
| remove_muldiv64.cocci | ||
| reset-type.cocci | ||
| return_directly.cocci | ||
| round.cocci | ||
| simplify_muldiv64.cocci | ||
| swap_muldiv64.cocci | ||
| tcg_gen_extract.cocci | ||
| timer-del-timer-free.cocci | ||
| typecast.cocci | ||
| use-error_fatal.cocci | ||
| use-g_new-etc.cocci | ||