mirror of https://github.com/proxmox/mirror_qemu
![]() In function cpu_physical_memory_sync_dirty_bitmap, file include/exec/ram_addr.h: if (src[idx][offset]) { unsigned long bits = atomic_xchg(&src[idx][offset], 0); unsigned long new_dirty; new_dirty = ~dest[k]; dest[k] |= bits; new_dirty &= bits; num_dirty += ctpopl(new_dirty); } After these codes executed, only the pages not dirtied in bitmap(dest), but dirtied in dirty_memory[DIRTY_MEMORY_MIGRATION] will be calculated. For example: When ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] = 0b00001111, and atomic_rcu_read(&migration_bitmap_rcu)->bmap = 0b00000011, the new_dirty will be 0b00001100, and this function will return 2 but not 4 which is expected. the dirty pages in dirty_memory[DIRTY_MEMORY_MIGRATION] are all new, so these should be calculated also. Signed-off-by: Chao Fan <fanc.fnst@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> |
||
---|---|---|
.. | ||
Makefile.objs | ||
block.c | ||
colo-comm.c | ||
colo-failover.c | ||
colo.c | ||
exec.c | ||
fd.c | ||
migration.c | ||
postcopy-ram.c | ||
qemu-file-channel.c | ||
qemu-file.c | ||
qjson.c | ||
ram.c | ||
rdma.c | ||
savevm.c | ||
socket.c | ||
tls.c | ||
trace-events | ||
vmstate.c | ||
xbzrle.c |