mirror of https://github.com/proxmox/mirror_qemu
3ae59580a0
If the BDS's refcnt > 0, drive_del() destroys the DriveInfo, but not the BDS. This can happen in three places: * Device model destruction during unplug: blockdev_auto_del() * Xen IDE unplug: pci_piix3_xen_ide_unplug() * drive_del command when no device model is attached: do_drive_del() The other callers of drive_del are on error paths where refcnt == 1. If the user somehow manages to plug in a device model using a BDS that has gone through drive_del(), the legacy configuration passed in DriveInfo doesn't reach the device model, and automatic deletion on unplug doesn't work. Worse, some device models such as scsi-disk crash when DriveInfo doesn't exist. This is theoretical; I didn't research an actual reproducer. The problem was introduced when we replaced DriveInfo reference counting by BDS reference counting in commit a94a3fa..fa510eb. Fix by keeping DriveInfo alive until its BDS dies. This affects qemu_drive_opts: now you can't reuse the same ID for new drive options until the BDS dies. Before, you could, but since the code always attempts to create a BDS with the same ID next, the enclosing operation "create a new drive" failed anyway. Different error path, same result. Unfortunately, the fix involves use of blockdev.c stuff from block.c, which is a layering violation. Fortunately, my forthcoming BlockBackend work will get rid of it again. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Benoît Canet <benoit.canet@nodalink.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> |
||
|---|---|---|
| .. | ||
| Makefile.objs | ||
| arch-query-cpu-def.c | ||
| bdrv-commit-all.c | ||
| blockdev.c | ||
| chr-baum-init.c | ||
| chr-msmouse.c | ||
| chr-testdev.c | ||
| clock-warp.c | ||
| cpu-get-clock.c | ||
| cpu-get-icount.c | ||
| cpus.c | ||
| dump.c | ||
| fd-register.c | ||
| fdset-add-fd.c | ||
| fdset-find-fd.c | ||
| fdset-get-fd.c | ||
| fdset-remove-fd.c | ||
| gdbstub.c | ||
| get-fd.c | ||
| get-next-serial.c | ||
| get-vm-name.c | ||
| iothread-lock.c | ||
| is-daemonized.c | ||
| kvm.c | ||
| machine-init-done.c | ||
| migr-blocker.c | ||
| mon-is-qmp.c | ||
| mon-printf.c | ||
| mon-set-error.c | ||
| monitor-init.c | ||
| notify-event.c | ||
| pci-drive-hot-add.c | ||
| qemu-chr-open-spice.c | ||
| qmp_pc_dimm_device_list.c | ||
| qtest.c | ||
| reset.c | ||
| runstate-check.c | ||
| set-fd-handler.c | ||
| slirp.c | ||
| sysbus.c | ||
| uuid.c | ||
| vc-init.c | ||
| vm-stop.c | ||
| vmstate.c | ||