mirror_qemu/hw/ide
Philippe Mathieu-Daudé 8e5c952b37 hw: Remove unnecessary DEVICE() cast
The DEVICE() macro is defined as:

  #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE)

which expands to:

  ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name),
                                             __FILE__, __LINE__,
                                             __func__))

This assertion can only fail when @obj points to something other
than its stated type, i.e. when we're in undefined behavior country.

Remove the unnecessary DEVICE() casts when we already know the
pointer is of DeviceState type.

Patch created mechanically using spatch with this script:

  @@
  typedef DeviceState;
  DeviceState *s;
  @@
  -   DEVICE(s)
  +   s

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Paul Durrant <paul@xen.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Acked-by: John Snow <jsnow@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200512070020.22782-4-f4bug@amsat.org>
2020-05-15 07:08:52 +02:00
..
Kconfig hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device 2019-05-13 09:36:31 +02:00
Makefile.objs hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device 2019-05-13 09:36:31 +02:00
ahci-allwinner.c various: Remove unnecessary OBJECT() cast 2020-05-15 07:08:14 +02:00
ahci.c hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument 2020-02-20 14:47:08 +01:00
ahci_internal.h hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h 2020-03-17 12:22:36 -04:00
atapi.c hw/ide/atapi: Use the ldst API 2019-08-16 19:14:04 -04:00
cmd646.c cmd646-ide: use qdev gpio rather than qemu_allocate_irqs() 2020-03-27 14:30:08 -04:00
core.c hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument 2020-02-20 14:47:08 +01:00
ich.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
ioport.c Clean up inclusion of sysemu/sysemu.h 2019-08-16 13:31:53 +02:00
isa.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
macio.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
microdrive.c add device_legacy_reset function to prepare for reset api change 2020-01-30 16:02:03 +00:00
mmio.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
pci.c hw/ide: Do ide_drive_get() within pci_ide_create_devs() 2020-03-17 12:22:36 -04:00
piix.c hw: Remove unnecessary DEVICE() cast 2020-05-15 07:08:52 +02:00
qdev.c qdev: Unrealize must not fail 2020-05-15 07:08:14 +02:00
sii3112.c hw/ide/sii3112: Remove dead assignment 2020-05-04 14:43:24 +02:00
trace-events trace-events: Fix attribution of trace points to source 2019-03-22 16:18:07 +00:00
via.c via-ide: use qdev gpio rather than qemu_allocate_irqs() 2020-03-27 14:30:08 -04:00