From f8126ea53368d0b92dd0504c8c467755c134916b Mon Sep 17 00:00:00 2001 From: Justin Riley Date: Thu, 21 Jul 2016 13:39:32 -0400 Subject: [PATCH] improve implementation of show_tb kwarg ...shows traceback while still showing ERROR or WARN --- onedns/exception.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/onedns/exception.py b/onedns/exception.py index 5ea6b68..63cb4dd 100644 --- a/onedns/exception.py +++ b/onedns/exception.py @@ -13,12 +13,10 @@ class OneDnsException(Exception): return '%s: %s' % (self.__class__.__name__, self.msg) def log(self, warn=False, show_tb=False): - if show_tb: - log.exception(self.explain()) - elif warn: - log.warn(self.explain()) + if warn: + log.warn(self.explain(), exc_info=show_tb) else: - log.error(self.explain()) + log.error(self.explain(), exc_info=show_tb) class NoNetworksError(OneDnsException):