vitalif
/
phantomjs
mirror of https://github.com/vitalif/phantomjs
1
0
Fork 0
Code Issues Releases Wiki Activity

Limit the maximum request post size to 10 MB (megabytes). 

std::numeric_limits<qint64>::max is too big for QByteArray (throws Out of Memory exception).
Set up the limit like it was done in Google Chrome
Ref: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

Related to issue #10158 https://github.com/ariya/phantomjs/issues/10158
1.x
Vitaliy Slobodin 2013-05-09 13:50:47 +04:00 committed by Ariya Hidayat
parent 23515550d5
commit f8e79fb8c6
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/networkaccessmanager.cpp
View File

@ -37,13 +37,15 @@
#include <QSslSocket>
#include <QSslCertificate>
#include <QRegExp>
#include <limits>
#include "phantom.h"
#include "config.h"
#include "cookiejar.h"
#include "networkaccessmanager.h"
// 10 MB
const qint64 MAX_REQUEST_POST_BODY_SIZE = 10 * 1000 * 1000;
static const char *toString(QNetworkAccessManager::Operation op)
{
const char *str = 0;
@ -208,7 +210,7 @@ QNetworkReply *NetworkAccessManager::createRequest(Operation op, const QNetworkR
// http://code.google.com/p/phantomjs/issues/detail?id=337
if (op == QNetworkAccessManager::PostOperation) {
if (outgoingData) postData = outgoingData->peek((std::numeric_limits<qint64>::max)());
if (outgoingData) postData = outgoingData->peek(MAX_REQUEST_POST_BODY_SIZE);
QString contentType = req.header(QNetworkRequest::ContentTypeHeader).toString();
if (contentType.isEmpty()) {
req.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded");