fix(glimmer): treat glimmer components as self closing tags (#4900)
parent
556fb3e646
commit
0571b2b884
|
@ -47,9 +47,14 @@ function print(path, options, print) {
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
case "ElementNode": {
|
case "ElementNode": {
|
||||||
const isVoid = voidTags.indexOf(n.tag) !== -1;
|
const tagFirstChar = n.tag[0];
|
||||||
const closeTag = isVoid ? concat([" />", softline]) : ">";
|
const isLocal = n.tag.indexOf(".") !== -1;
|
||||||
|
const isGlimmerComponent =
|
||||||
|
tagFirstChar.toUpperCase() === tagFirstChar || isLocal;
|
||||||
const hasChildren = n.children.length > 0;
|
const hasChildren = n.children.length > 0;
|
||||||
|
const isVoid =
|
||||||
|
(isGlimmerComponent && !hasChildren) || voidTags.indexOf(n.tag) !== -1;
|
||||||
|
const closeTag = isVoid ? concat([" />", softline]) : ">";
|
||||||
const getParams = (path, print) =>
|
const getParams = (path, print) =>
|
||||||
indent(
|
indent(
|
||||||
concat([
|
concat([
|
||||||
|
|
|
@ -135,9 +135,16 @@ exports[`block-statement.hbs - glimmer-verify 1`] = `
|
||||||
`;
|
`;
|
||||||
|
|
||||||
exports[`component.hbs - glimmer-verify 1`] = `
|
exports[`component.hbs - glimmer-verify 1`] = `
|
||||||
<user-greeting @name="Ricardo" @greeting="Olá" />
|
<UserGreeting @name="Ricardo" @greeting="Olá" />
|
||||||
{{@greeting}}, {{@name}}!
|
{{@greeting}}, {{@name}}!
|
||||||
|
|
||||||
|
<Form as |f|>
|
||||||
|
<f.input @title="hello" />
|
||||||
|
<f.input>hello</f.input>
|
||||||
|
</Form>
|
||||||
|
|
||||||
|
<this.label @title="hello" />
|
||||||
|
|
||||||
<button onclick={{action next}}>Next</button>
|
<button onclick={{action next}}>Next</button>
|
||||||
|
|
||||||
<button disabled class="disabled"></button>
|
<button disabled class="disabled"></button>
|
||||||
|
@ -146,11 +153,18 @@ exports[`component.hbs - glimmer-verify 1`] = `
|
||||||
|
|
||||||
<div ...attributes>Hello</div>
|
<div ...attributes>Hello</div>
|
||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
||||||
<user-greeting @name="Ricardo" @greeting="Olá"></user-greeting>
|
<UserGreeting @name="Ricardo" @greeting="Olá" />
|
||||||
{{@greeting}}
|
{{@greeting}}
|
||||||
,
|
,
|
||||||
{{@name}}
|
{{@name}}
|
||||||
!
|
!
|
||||||
|
<Form as |f|>
|
||||||
|
<f.input @title="hello" />
|
||||||
|
<f.input>
|
||||||
|
hello
|
||||||
|
</f.input>
|
||||||
|
</Form>
|
||||||
|
<this.label @title="hello" />
|
||||||
<button onclick={{action next}}>
|
<button onclick={{action next}}>
|
||||||
Next
|
Next
|
||||||
</button>
|
</button>
|
||||||
|
|
|
@ -1,6 +1,13 @@
|
||||||
<user-greeting @name="Ricardo" @greeting="Olá" />
|
<UserGreeting @name="Ricardo" @greeting="Olá" />
|
||||||
{{@greeting}}, {{@name}}!
|
{{@greeting}}, {{@name}}!
|
||||||
|
|
||||||
|
<Form as |f|>
|
||||||
|
<f.input @title="hello" />
|
||||||
|
<f.input>hello</f.input>
|
||||||
|
</Form>
|
||||||
|
|
||||||
|
<this.label @title="hello" />
|
||||||
|
|
||||||
<button onclick={{action next}}>Next</button>
|
<button onclick={{action next}}>Next</button>
|
||||||
|
|
||||||
<button disabled class="disabled"></button>
|
<button disabled class="disabled"></button>
|
||||||
|
|
Loading…
Reference in New Issue