From c9bb96cd526bb99268e0028aaf37ed7094423907 Mon Sep 17 00:00:00 2001 From: Evilebot Tnawi Date: Mon, 2 Apr 2018 14:16:39 +0300 Subject: [PATCH] fix: don't break value property with inlined URL (#4236) --- src/language-css/parser-postcss.js | 2 -- tests/css_inline_url/__snapshots__/jsfmt.spec.js.snap | 3 +++ tests/css_inline_url/inline_url.css | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/language-css/parser-postcss.js b/src/language-css/parser-postcss.js index d1fd2158..23c119a0 100644 --- a/src/language-css/parser-postcss.js +++ b/src/language-css/parser-postcss.js @@ -54,8 +54,6 @@ function parseValueNodes(nodes) { if (isUnquotedDataURLCall) { node.group.groups = [stringifyGroup(node)]; - - return node; } if (node.type === "paren" && node.value === "(") { diff --git a/tests/css_inline_url/__snapshots__/jsfmt.spec.js.snap b/tests/css_inline_url/__snapshots__/jsfmt.spec.js.snap index 29fd7cc3..2f9c0918 100644 --- a/tests/css_inline_url/__snapshots__/jsfmt.spec.js.snap +++ b/tests/css_inline_url/__snapshots__/jsfmt.spec.js.snap @@ -19,6 +19,7 @@ exports[`inline_url.css 1`] = ` background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=); background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII="); background-image: url(data:application/font-woff;charset=utf-8;base64,ThisIsNormalBut/+0ThisIsLowerCased); + background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=) center center no-repeat; } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .breadItem { @@ -28,6 +29,8 @@ exports[`inline_url.css 1`] = ` background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=); background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII="); background-image: url(data:application/font-woff;charset=utf-8;base64,ThisIsNormalBut/+0ThisIsLowerCased); + background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=) + center center no-repeat; } `; diff --git a/tests/css_inline_url/inline_url.css b/tests/css_inline_url/inline_url.css index fbae6914..08787f38 100644 --- a/tests/css_inline_url/inline_url.css +++ b/tests/css_inline_url/inline_url.css @@ -5,4 +5,5 @@ background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=); background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII="); background-image: url(data:application/font-woff;charset=utf-8;base64,ThisIsNormalBut/+0ThisIsLowerCased); + background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO4/B8AAqgB0yr7dJgAAAAASUVORK5CYII=) center center no-repeat; }