[JSX] Fix spurious newline (fixes #614) (#628)

src/printer.js

@@ -2318,9 +2318,9 @@ function printJSXChildren(path, options, print) {
             if (endSpace) {
               children.push(jsxWhitespace);
             }
-
-            children.push(softline);
           });
+
+          children.push(softline);
         } else if (/\n/.test(value)) {
           children.push(hardline);
 

tests/jsx-newlines/__snapshots__/jsfmt.spec.js.snap

@@ -72,6 +72,15 @@ newlines_elems =
 
 
   </div>
+
+regression_extra_newline = (
+  <div>
+    <span
+      className=\"nuclide-console-new-messages-notification-icon icon icon-nuclicon-arrow-down\"
+    />
+    New Messages
+  </div>
+);
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 keep = (
   <p>
@@ -144,5 +153,12 @@ newlines_elems = (
 
   </div>
 );
+
+regression_extra_newline = (
+  <div>
+    <span className=\"nuclide-console-new-messages-notification-icon icon icon-nuclicon-arrow-down\" />
+    New Messages
+  </div>
+);
 "
 `;

tests/jsx-newlines/test.js

@@ -71,3 +71,12 @@ newlines_elems =
 
 
   </div>
+
+regression_extra_newline = (
+  <div>
+    <span
+      className="nuclide-console-new-messages-notification-icon icon icon-nuclicon-arrow-down"
+    />
+    New Messages
+  </div>
+);