vitalif
/
prettier
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Prevent formatting GQL template literals with expressions (#2975) 

* Prevent formatting GQL template literals with expressions

* Remove unnecessary check

* Change quasis check to expression check
master
Lucas Duailibe 2017-10-04 21:23:57 -03:00 committed by Lucas Azzola
parent 2fed6c873b
commit f82fcbc98e
3 changed files with 67 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/multiparser.js
View File

@ -67,9 +67,10 @@ function fromBabylonFlowOrTypeScript(path) {
* gql`...`
*/
if (
// We currently don't support expression inside GraphQL template literals
parent.expressions.length === 0 &&
parentParent &&
((parentParent.type === "TaggedTemplateExpression" &&
parent.quasis.length === 1 &&
((parentParent.tag.type === "MemberExpression" &&
parentParent.tag.object.name === "graphql" &&
parentParent.tag.property.name === "experimental") ||

47
tests/multiparser_js_graphql/__snapshots__/jsfmt.spec.js.snap
View File

@ -1,5 +1,52 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`expressions.js 1`] = `
// We currently don't support expressions in GraphQL template literals so these templates
// should not change.
graphql(schema, \`
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
\${fragments.all}
\`)
const veryLongVariableNameToMakeTheLineBreak = graphql(schema, \`
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
\${fragments.all}
\`)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// We currently don't support expressions in GraphQL template literals so these templates
// should not change.
graphql(
schema,
\`
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
\${fragments.all}
\`
);
const veryLongVariableNameToMakeTheLineBreak = graphql(
schema,
\`
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
\${fragments.all}
\`
);
`;
exports[`graphql.js 1`] = `
graphql(schema, \`
mutation MarkReadNotificationMutation(

18
tests/multiparser_js_graphql/expressions.js Normal file
View File

@ -0,0 +1,18 @@
// We currently don't support expressions in GraphQL template literals so these templates
// should not change.
graphql(schema, `
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
${fragments.all}
`)
const veryLongVariableNameToMakeTheLineBreak = graphql(schema, `
query allPartsByManufacturerName($name: String!) {
allParts(filter:{manufacturer: {name: $name}}) {
... PartAll
}}
${fragments.all}
`)