From 89520c1cd0f4ddf32c2da8bb8fa578779bad3388 Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Tue, 17 Oct 2023 14:10:06 +0200 Subject: [PATCH] d/rules: use disable-download option instead of git-submodules=ignore See the following QEMU commits for reference: 0c5f3dcbb2 ("configure: add --enable-pypi and --disable-pypi") ac4ccac740 ("configure: rename --enable-pypi to --enable-download, control subprojects too") 6f3ae23b29 ("configure: remove --with-git-submodules=") removed The last one removed the option and the closest thing to git-submodule=ignore is using disable-download. Which will then just verify that the submodules are present. Building now will require running either * Running 'meson subprojects download' in the qemu submodule first. * Using --enable-download, but then the submodules would be downloaded for each build (if not already downloaded in the submodule first) and it's just a bit too surprising if downloads happen during build. The disable-download option will also disable automatic downloading of missing Python modules from PyPI. Hopefully, it's enough to add them as Debian build dependencies when required. Signed-off-by: Fiona Ebner Signed-off-by: Thomas Lamprecht --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 4d06697..51f56c5 100755 --- a/debian/rules +++ b/debian/rules @@ -38,7 +38,7 @@ endif # guest-agent is only required for guest systems ./configure \ - --with-git-submodules=ignore \ + --disable-download \ --docdir=/usr/share/doc/pve-qemu-kvm \ --localstatedir=/var \ --prefix=/usr \