From aa42ea267e235fda4e879667adf04e35d31ba303 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 6 Apr 2021 16:00:26 +0200 Subject: [PATCH] alloc track: keep track_drop() closer to similar block drivers Reads just nicer with a drain begin *and* end call. Also clearing the backing link of the alloc track BDS makes it closer to bdrv_backup_top_drop() with which this driver has a bit in common. Signed-off-by: Thomas Lamprecht --- debian/patches/pve/0047-block-add-alloc-track-driver.patch | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/patches/pve/0047-block-add-alloc-track-driver.patch b/debian/patches/pve/0047-block-add-alloc-track-driver.patch index db46371..232ad7e 100644 --- a/debian/patches/pve/0047-block-add-alloc-track-driver.patch +++ b/debian/patches/pve/0047-block-add-alloc-track-driver.patch @@ -314,8 +314,6 @@ index 0000000000..b579380279 + return; + } + -+ /* we do not need a bdrv_drained_end, since this is applied only to the node -+ * which gets removed by bdrv_replace_node */ + bdrv_drained_begin(bs); + + /* now that we're drained, we can safely set 'DropInProgress' */ @@ -323,6 +321,8 @@ index 0000000000..b579380279 + bdrv_child_refresh_perms(bs, bs->file, &error_abort); + + bdrv_replace_node(bs, file, &error_abort); ++ bdrv_set_backing_hd(bs, NULL, &error_abort); ++ bdrv_drained_end(bs); + bdrv_unref(bs); +} +