Compare commits
223 Commits
v6.1.1-2-v
...
master
Author | SHA1 | Date |
---|---|---|
Vitaliy Filippov | f2653ef0b8 | |
Thomas Lamprecht | 9efd9cea96 | |
Fiona Ebner | 4154eea6e6 | |
Fiona Ebner | cf40e92996 | |
Fiona Ebner | 14afbdd55f | |
Fiona Ebner | 54d1666680 | |
Fiona Ebner | 49125e1708 | |
Fiona Ebner | b242e7f196 | |
Fiona Ebner | c2abb73df7 | |
Fiona Ebner | 5bdf1bebba | |
Fiona Ebner | 99c80e7492 | |
Fiona Ebner | 9664f5a132 | |
Fiona Ebner | b37841aa1a | |
Fiona Ebner | 822c99f3c3 | |
Jing Luo | 51df4937bf | |
Fiona Ebner | bb80c7f323 | |
Fiona Ebner | c1cd6a6221 | |
Thomas Lamprecht | 16b7dfe03b | |
Fiona Ebner | f06b222ece | |
Fiona Ebner | db293008ee | |
Fiona Ebner | 51232e2e40 | |
Thomas Lamprecht | 2cd560e0d2 | |
Fiona Ebner | 4fbd50e2f9 | |
Thomas Lamprecht | 766c61f1b6 | |
Thomas Lamprecht | c19617bf9b | |
Fiona Ebner | f1eed34ac7 | |
Fiona Ebner | 2e71c17f5b | |
Fiona Ebner | f76e07f370 | |
Fiona Ebner | 71dd2d48f9 | |
Thomas Lamprecht | 59ab88deb6 | |
Thomas Lamprecht | 20209d8d73 | |
Thomas Lamprecht | 47bdd04244 | |
Thomas Lamprecht | 8dd76cc52d | |
Fiona Ebner | cd7676f3e6 | |
Fiona Ebner | 862b46e3e0 | |
Fiona Ebner | 061e9ceb36 | |
Thomas Lamprecht | 0d4462207b | |
Fiona Ebner | ed159bc32a | |
Fiona Ebner | 86460aef76 | |
Thomas Lamprecht | 676adda3c6 | |
Thomas Lamprecht | 4ff04bdfa5 | |
Thomas Lamprecht | 12b69ed9c5 | |
Fiona Ebner | 5e8903f875 | |
Fiona Ebner | 4b7975e75d | |
Fiona Ebner | f366bb97ae | |
Fiona Ebner | 2a49e667ba | |
Thomas Lamprecht | c6eb05a799 | |
Fiona Ebner | dfac4f3593 | |
Fiona Ebner | 6b7c1815e1 | |
Thomas Lamprecht | 24d732ac0f | |
Fiona Ebner | df2cc786ee | |
Thomas Lamprecht | 38726d3473 | |
Fiona Ebner | 89b46e17ec | |
Thomas Lamprecht | 33b22c3fe0 | |
Fiona Ebner | c38e337f5d | |
Fiona Ebner | 763949965f | |
Thomas Lamprecht | 1807330a6f | |
Thomas Lamprecht | a31ab74058 | |
Fiona Ebner | b39f726f31 | |
Fiona Ebner | a36bda146c | |
Fiona Ebner | 03ff63aa61 | |
Fiona Ebner | 10e1093325 | |
Fiona Ebner | 0d9c737d61 | |
Fiona Ebner | a6ddea7ef7 | |
Fiona Ebner | 89520c1cd0 | |
Thomas Lamprecht | eca4daeeed | |
Fiona Ebner | 816077299c | |
Fiona Ebner | ef3308db71 | |
Filip Schauer | 0ff45eb23e | |
Thomas Lamprecht | 6c5563e30b | |
Fiona Ebner | 9e0186f289 | |
Fiona Ebner | 0cffb504e7 | |
Fiona Ebner | f7eed6caa1 | |
Filip Schauer | 0cff91a000 | |
Fiona Ebner | 6cadf3677d | |
Fiona Ebner | 5f9cb29c3a | |
Fiona Ebner | c36e3f9d17 | |
Filip Schauer | b8b4ce0480 | |
Fiona Ebner | df47146afe | |
Fabian Grünbichler | d9cbfafeeb | |
Fiona Ebner | 5919ec1446 | |
Thomas Lamprecht | 409db0cd7b | |
Fiona Ebner | ea7662074d | |
Fiona Ebner | d847446186 | |
Thomas Lamprecht | 3aaa855e5c | |
Fiona Ebner | 99f9ce2cd2 | |
Fiona Ebner | a816d2969e | |
Thomas Lamprecht | 0e9a7bfda2 | |
Fiona Ebner | a39364b9d1 | |
Fiona Ebner | 0f693c2cab | |
Thomas Lamprecht | 88b1550dfb | |
Thomas Lamprecht | bd3c1fa525 | |
Thomas Lamprecht | de2dde2da9 | |
Thomas Lamprecht | 04e0262e2e | |
Thomas Lamprecht | d3c2ae9683 | |
Thomas Lamprecht | d0603efa38 | |
Fiona Ebner | db5d2a4b77 | |
Fiona Ebner | b64c4dec1c | |
Fiona Ebner | 53b56ca781 | |
Fiona Ebner | bf251437e9 | |
Fiona Ebner | fb818ea5b9 | |
Thomas Lamprecht | 3c995a426d | |
Thomas Lamprecht | be7ce325c7 | |
Thomas Lamprecht | 19b4b4c50f | |
Thomas Lamprecht | 590adba81a | |
Fiona Ebner | abb04bb627 | |
Thomas Lamprecht | 6facdf3a08 | |
Thomas Lamprecht | cb2b3190a4 | |
Thomas Lamprecht | 2e416ad9d5 | |
Thomas Lamprecht | d80ca49db8 | |
Thomas Lamprecht | d65b507d3f | |
Thomas Lamprecht | 98fd8612cb | |
Thomas Lamprecht | 4f56d29218 | |
Thomas Lamprecht | cd148033f3 | |
Thomas Lamprecht | 92c6d84f6a | |
Thomas Lamprecht | b8af8dd4fa | |
Fiona Ebner | 6eb3e31968 | |
Fiona Ebner | c913853be7 | |
Fiona Ebner | 4fc4b533b5 | |
Fiona Ebner | 023b916380 | |
Fiona Ebner | 19a11f24a5 | |
Fiona Ebner | 030fa1db4b | |
Fiona Ebner | 2d17b4b4d9 | |
Fiona Ebner | 280d157f1c | |
Fiona Ebner | f6be0ca51a | |
Thomas Lamprecht | 93d558c1ee | |
Fiona Ebner | e752bbe5e2 | |
Thomas Lamprecht | 018ef788b3 | |
Fiona Ebner | 72fc94c0c6 | |
Thomas Lamprecht | 09186f4b6e | |
Fiona Ebner | ffda59f626 | |
Fiona Ebner | 3c4f941ac7 | |
Fiona Ebner | 3a94e1a186 | |
Thomas Lamprecht | 67cae45f41 | |
Fiona Ebner | 58659169de | |
Fiona Ebner | 10691e04e9 | |
Thomas Lamprecht | 09723b9298 | |
Fiona Ebner | 00e2507aac | |
Fiona Ebner | e7e5f63573 | |
Fiona Ebner | 1688b43738 | |
Fiona Ebner | eee064d954 | |
Fiona Ebner | 8051a24b5f | |
Fiona Ebner | ade9f50160 | |
Fiona Ebner | 0fde60fd10 | |
Thomas Lamprecht | d82c5eb632 | |
Fiona Ebner | d5f6ef56f0 | |
Fabian Grünbichler | 658cba46ee | |
Fiona Ebner | a02081501a | |
Thomas Lamprecht | baf4e3132d | |
Fiona Ebner | 48c307550a | |
Thomas Lamprecht | 89fdfe8975 | |
Fiona Ebner | f64132208a | |
Fiona Ebner | 271ac0a8a7 | |
Fiona Ebner | f4ed54ec37 | |
Fiona Ebner | 2277182712 | |
Fiona Ebner | 0906461df0 | |
Wolfgang Bumiller | 29bee92c59 | |
Fiona Ebner | 82640bb859 | |
Fiona Ebner | d03e1b3ce3 | |
Thomas Lamprecht | 55e33a045e | |
Thomas Lamprecht | 8a38e1da9e | |
Thomas Lamprecht | 3b3d5516ee | |
Thomas Lamprecht | 509409fb64 | |
Wolfgang Bumiller | bf03cd367f | |
Fiona Ebner | 0af826b448 | |
Wolfgang Bumiller | ed23707ed7 | |
Fiona Ebner | 4e1935c2c9 | |
Fiona Ebner | a262e9642b | |
Fiona Ebner | 73912aee39 | |
Fiona Ebner | 5b15e2ecaf | |
Wolfgang Bumiller | 2775b2e378 | |
Wolfgang Bumiller | ed01236593 | |
Fiona Ebner | 2b259b70ec | |
Thomas Lamprecht | a186335be5 | |
Fiona Ebner | 1976ca4607 | |
Fiona Ebner | 563c592898 | |
Thomas Lamprecht | 1de53d8a45 | |
Fabian Ebner | 0e88ec19db | |
Wolfgang Bumiller | 9ee866b2e9 | |
Fabian Ebner | 14ed554660 | |
Fabian Ebner | eba403aafc | |
Fabian Ebner | b2685aee04 | |
Fabian Ebner | dc9827a6a4 | |
Thomas Lamprecht | 4e4b9ab13f | |
Thomas Lamprecht | 39e84ba82d | |
Thomas Lamprecht | 4fd0fa7fb3 | |
Dominik Csapak | 539e333eaa | |
Fabian Grünbichler | 68569ea2ff | |
Fabian Grünbichler | 41aedfb6db | |
Fabian Ebner | 7bd4d8645a | |
Wolfgang Bumiller | ed3b5b8ab8 | |
Wolfgang Bumiller | 7f4326d1dc | |
Wolfgang Bumiller | 53bff441c5 | |
Thomas Lamprecht | f9a4b1cea7 | |
Fabian Ebner | dc265df350 | |
Thomas Lamprecht | e0076597c6 | |
Thomas Lamprecht | ee99c1f813 | |
Wolfgang Bumiller | 58a5492e9c | |
Thomas Lamprecht | e67b8b5bd9 | |
Thomas Lamprecht | 309b5c1694 | |
Thomas Lamprecht | 4ce5937f89 | |
Thomas Lamprecht | f87d0523df | |
Thomas Lamprecht | 2fd4ea2813 | |
Thomas Lamprecht | 2653a5f029 | |
Thomas Lamprecht | 664ecf59a9 | |
Thomas Lamprecht | 4de9440f87 | |
Thomas Lamprecht | 9b348f8c6d | |
Thomas Lamprecht | 799cf8c5a3 | |
Thomas Lamprecht | b02e62dba0 | |
Thomas Lamprecht | fc03e1b6bf | |
Thomas Lamprecht | c8ba14bed0 | |
Wolfgang Bumiller | daea534caa | |
Fabian Ebner | 27199bd753 | |
Thomas Lamprecht | e050683663 | |
Thomas Lamprecht | 13184117e4 | |
Thomas Lamprecht | aa4b14ea10 | |
Thomas Lamprecht | 3aa5b7598d | |
Thomas Lamprecht | 13d3e10aa6 | |
Thomas Lamprecht | 58c3533a58 | |
Thomas Lamprecht | fe0542bed9 | |
Fabian Ebner | f6d40bfdf4 | |
Fabian Ebner | 107132becc | |
Fabian Ebner | 4567474e95 |
|
@ -0,0 +1,7 @@
|
||||||
|
/*.build
|
||||||
|
/*.buildinfo
|
||||||
|
/*.changes
|
||||||
|
/*.deb
|
||||||
|
/*.dsc
|
||||||
|
/*.tar*
|
||||||
|
/pve-qemu-kvm-*.*/
|
82
Makefile
82
Makefile
|
@ -1,60 +1,90 @@
|
||||||
include /usr/share/dpkg/pkg-info.mk
|
include /usr/share/dpkg/default.mk
|
||||||
include /usr/share/dpkg/architecture.mk
|
|
||||||
|
|
||||||
PACKAGE = pve-qemu-kvm
|
PACKAGE = pve-qemu-kvm
|
||||||
|
|
||||||
SRCDIR := qemu
|
SRCDIR := qemu
|
||||||
BUILDDIR ?= ${PACKAGE}-${DEB_VERSION_UPSTREAM}
|
BUILDDIR ?= $(PACKAGE)-$(DEB_VERSION_UPSTREAM)
|
||||||
|
ORIG_SRC_TAR=$(PACKAGE)_$(DEB_VERSION_UPSTREAM).orig.tar.gz
|
||||||
|
|
||||||
GITVERSION := $(shell git rev-parse HEAD)
|
GITVERSION := $(shell git rev-parse HEAD)
|
||||||
|
|
||||||
DEB = ${PACKAGE}_${DEB_VERSION_UPSTREAM_REVISION}_${DEB_BUILD_ARCH}.deb
|
DSC=$(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION).dsc
|
||||||
DEB_DBG = ${PACKAGE}-dbg_${DEB_VERSION_UPSTREAM_REVISION}_${DEB_BUILD_ARCH}.deb
|
DEB = $(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION)_$(DEB_BUILD_ARCH).deb
|
||||||
|
DEB_DBG = $(PACKAGE)-dbgsym_$(DEB_VERSION_UPSTREAM_REVISION)_$(DEB_BUILD_ARCH).deb
|
||||||
DEBS = $(DEB) $(DEB_DBG)
|
DEBS = $(DEB) $(DEB_DBG)
|
||||||
|
|
||||||
all: $(DEBS)
|
all: $(DEBS)
|
||||||
|
|
||||||
.PHONY: submodule
|
.PHONY: submodule
|
||||||
submodule:
|
submodule:
|
||||||
test -f "${SRCDIR}/configure" || git submodule update --init --recursive
|
ifeq ($(shell test -f "$(SRCDIR)/configure" && echo 1 || echo 0), 0)
|
||||||
|
git submodule update --init --recursive
|
||||||
|
cd $(SRCDIR); meson subprojects download
|
||||||
|
endif
|
||||||
|
|
||||||
$(BUILDDIR): keycodemapdb | submodule
|
PC_BIOS_FW_PURGE_LIST_IN = \
|
||||||
|
hppa-firmware.img \
|
||||||
|
hppa-firmware64.img \
|
||||||
|
openbios-ppc \
|
||||||
|
openbios-sparc32 \
|
||||||
|
openbios-sparc64 \
|
||||||
|
palcode-clipper \
|
||||||
|
s390-ccw.img \
|
||||||
|
s390-netboot.img \
|
||||||
|
u-boot.e500 \
|
||||||
|
.*[a-zA-Z0-9]\.dtb \
|
||||||
|
.*[a-zA-Z0-9]\.dts \
|
||||||
|
qemu_vga.ndrv \
|
||||||
|
slof.bin \
|
||||||
|
opensbi-riscv.*-generic-fw_dynamic.bin \
|
||||||
|
|
||||||
|
BLOB_PURGE_SED_CMDS = $(foreach FILE,$(PC_BIOS_FW_PURGE_LIST_IN),-e "/$(FILE)/d")
|
||||||
|
BLOB_PURGE_FILTER = $(foreach FILE,$(PC_BIOS_FW_PURGE_LIST_IN),-e "$(FILE)")
|
||||||
|
|
||||||
|
$(BUILDDIR): submodule
|
||||||
# check if qemu/ was used for a build
|
# check if qemu/ was used for a build
|
||||||
# if so, please run 'make distclean' in the submodule and try again
|
# if so, please run 'make distclean' in the submodule and try again
|
||||||
test ! -f $(SRCDIR)/build/config.status
|
test ! -f $(SRCDIR)/build/config.status
|
||||||
rm -rf $(BUILDDIR)
|
rm -rf $@.tmp $@
|
||||||
cp -a $(SRCDIR) $(BUILDDIR)
|
cp -a $(SRCDIR) $@.tmp
|
||||||
cp -a debian $(BUILDDIR)/debian
|
cp -a debian $@.tmp/debian
|
||||||
rm -rf $(BUILDDIR)/ui/keycodemapdb
|
rm -rf $@.tmp/roms/edk2 # packaged separately
|
||||||
cp -a keycodemapdb $(BUILDDIR)/ui/
|
find $@.tmp/pc-bios -type f | grep $(BLOB_PURGE_FILTER) | xargs rm -f
|
||||||
echo "git clone git://git.proxmox.com/git/pve-qemu.git\\ngit checkout $(GITVERSION)" > $(BUILDDIR)/debian/SOURCE
|
sed -i $(BLOB_PURGE_SED_CMDS) $@.tmp/pc-bios/meson.build
|
||||||
|
echo "git clone git://git.proxmox.com/git/pve-qemu.git\\ngit checkout $(GITVERSION)" > $@.tmp/debian/SOURCE
|
||||||
|
mv $@.tmp $@
|
||||||
|
|
||||||
.PHONY: deb kvm
|
.PHONY: deb kvm
|
||||||
deb kvm: $(DEBS)
|
deb kvm: $(DEBS)
|
||||||
$(DEB_DBG): $(DEB)
|
$(DEB_DBG): $(DEB)
|
||||||
$(DEB): $(BUILDDIR)
|
$(DEB): $(BUILDDIR)
|
||||||
cd $(BUILDDIR); dpkg-buildpackage -b -us -uc -j
|
cd $(BUILDDIR); dpkg-buildpackage -b -us -uc -j32
|
||||||
lintian $(DEBS)
|
lintian $(DEBS)
|
||||||
|
|
||||||
.PHONY: update
|
sbuild: $(DSC)
|
||||||
update:
|
sbuild $(DSC)
|
||||||
cd $(SRCDIR) && git submodule deinit ui/keycodemapdb || true
|
|
||||||
rm -rf $(SRCDIR)/ui/keycodemapdb
|
$(ORIG_SRC_TAR): $(BUILDDIR)
|
||||||
mkdir $(SRCDIR)/ui/keycodemapdb
|
tar czf $(ORIG_SRC_TAR) --exclude="$(BUILDDIR)/debian" $(BUILDDIR)
|
||||||
cd $(SRCDIR) && git submodule update --init ui/keycodemapdb
|
|
||||||
rm -rf keycodemapdb
|
.PHONY: dsc
|
||||||
mkdir keycodemapdb
|
dsc:
|
||||||
cp -R $(SRCDIR)/ui/keycodemapdb/* keycodemapdb/
|
rm -rf *.dsc $(BUILDDIR)
|
||||||
git add keycodemapdb
|
$(MAKE) $(DSC)
|
||||||
|
lintian $(DSC)
|
||||||
|
|
||||||
|
$(DSC): $(ORIG_SRC_TAR) $(BUILDDIR)
|
||||||
|
cd $(BUILDDIR); dpkg-buildpackage -S -us -uc -d
|
||||||
|
|
||||||
.PHONY: upload
|
.PHONY: upload
|
||||||
|
upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION)
|
||||||
upload: $(DEBS)
|
upload: $(DEBS)
|
||||||
tar cf - ${DEBS} | ssh repoman@repo.proxmox.com upload --product pve --dist bullseye
|
tar cf - $(DEBS) | ssh repoman@repo.proxmox.com upload --product pve --dist $(UPLOAD_DIST)
|
||||||
|
|
||||||
.PHONY: distclean clean
|
.PHONY: distclean clean
|
||||||
distclean: clean
|
distclean: clean
|
||||||
clean:
|
clean:
|
||||||
rm -rf $(BUILDDIR) $(PACKAGE)*.deb *.buildinfo *.changes
|
rm -rf $(PACKAGE)-[0-9]*/ $(PACKAGE)*.tar* *.deb *.dsc *.build *.buildinfo *.changes
|
||||||
|
|
||||||
.PHONY: dinstall
|
.PHONY: dinstall
|
||||||
dinstall: $(DEBS)
|
dinstall: $(DEBS)
|
||||||
|
|
|
@ -1,14 +1,509 @@
|
||||||
pve-qemu-kvm (6.1.1-2+vitastor2) bullseye; urgency=medium
|
pve-qemu-kvm (9.0.2-1+vitastor1) bookworm; urgency=medium
|
||||||
|
|
||||||
* Add bdrv_co_block_status implementation for QCOW2 export support
|
|
||||||
|
|
||||||
-- Vitaliy Filippov <vitalif@yourcmc.ru> Fri, 13 Jan 2023 20:20:16 +0300
|
|
||||||
|
|
||||||
pve-qemu-kvm (6.1.1-2+vitastor1) bullseye; urgency=medium
|
|
||||||
|
|
||||||
* Add Vitastor support
|
* Add Vitastor support
|
||||||
|
|
||||||
-- Vitaliy Filippov <vitalif@yourcmc.ru> Thu, 14 Dec 2022 19:15:40 +0300
|
-- Vitaliy Filippov <vitalif@yourcmc.ru> Fri, 02 Aug 2024 00:03:15 +0300
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.2-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update submodule and patches to QEMU 9.0.2. While our version had most
|
||||||
|
stable fixes included already, there are new fixes for VirtIO and VGA
|
||||||
|
display screen blanking (#4786)
|
||||||
|
|
||||||
|
* backport fix for a regression with the LSI-53c895a controller and one for
|
||||||
|
the boot order getting ignored for USB storage
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 29 Jul 2024 18:59:40 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-6) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix a regression in the zeroinit block driver that prevented importing and
|
||||||
|
cloning disks to RBD storages which are not using the krbd setting
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 08 Jul 2024 16:11:15 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-5) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* backport fix for CVE-2024-4467 to prevent malicious qcow2 image files from
|
||||||
|
already causing bad effects if being queried via 'qemu-img info'. For
|
||||||
|
Proxmox VE, this is an additional safe guard, as currently it directly
|
||||||
|
creates and manages the qcow2 images used by VMs and does not allow
|
||||||
|
unprivileged users to import them
|
||||||
|
|
||||||
|
* fix #4726: code cleanup: avoid superfluous check in vma backup code
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 03 Jul 2024 13:13:35 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-4) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix crash after saving a snapshot without including VM state when a VirtIO
|
||||||
|
block device with iothread is configured.
|
||||||
|
|
||||||
|
* fix edge case in error handling when opening a block device from PBS fails
|
||||||
|
|
||||||
|
* minor code cleanup in backup code
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 01 Jul 2024 11:26:11 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-3) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix crash when doing resize after hotplugging a disk using io_uring
|
||||||
|
|
||||||
|
* fix some minor issues in software CPU emulation (i.e. non-KVM) for ARM and
|
||||||
|
x86(_64)
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 29 May 2024 15:55:44 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-2) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix #5409: backup: fix copy-before-write timeout
|
||||||
|
|
||||||
|
* backup: improve error when copy-before-write fails for fleecing
|
||||||
|
|
||||||
|
* fix forwards and backwards migration with VirtIO-GPU display
|
||||||
|
|
||||||
|
* fix a regression in pflash device introduced in 8.2
|
||||||
|
|
||||||
|
* revert a commit for VirtIO PCI devices that turned out to cause more
|
||||||
|
potential security issues than what it fixed
|
||||||
|
|
||||||
|
* move compatibility flags for a new VirtIO-net feature to the correct
|
||||||
|
machine type. The feature was introduced in QEMU 8.2, but the
|
||||||
|
compatibility flags got added to machine version 8.0 instead of 8.1. This
|
||||||
|
breaks backwards migration with machine version 8.1 from a 8.2/9.0 binary
|
||||||
|
to an 8.1 binary, in cases where the guest kernel enables the feature
|
||||||
|
(e.g. Ubuntu 23.10).
|
||||||
|
While that breaks migration with machine version 8.1 from an unpatched to
|
||||||
|
a patched binary, Proxmox VE only ever had 8.2 on the test repository and
|
||||||
|
9.0 not yet in any public repository.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 17 May 2024 17:04:52 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (9.0.0-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update submodule and patches to QEMU 9.0.0
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 29 Apr 2024 10:51:37 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.2.2-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update submodule and patches to QEMU 8.2.2
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Sat, 27 Apr 2024 12:44:30 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-5) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* implement support for backup fleecing
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 11 Apr 2024 17:46:48 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-4) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix live-import for certain kinds of VMDK images that rely on padding
|
||||||
|
|
||||||
|
* backup: avoid bubbling up first error if it's an ECANCELED one, as those
|
||||||
|
are often a result of cancling the job due to running into an actual
|
||||||
|
issue.
|
||||||
|
|
||||||
|
* backup: factor out & clean up gathering device info into helper
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 12 Mar 2024 14:08:40 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-3) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* backport fix for potential deadlock during QMP stop command if the VM has
|
||||||
|
disks attached through VirtIO-Block and IO-Thread enabled
|
||||||
|
|
||||||
|
* fix #4507: add patch to automatically increase NOFILE soft limit
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 21 Feb 2024 20:11:23 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-2) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* work around for a situation where guest IO might get stuck, if the VM is
|
||||||
|
configure with iothread and VirtIO block/SCSI
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 02 Feb 2024 19:41:27 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update to 8.1.5 stable release, including more relevant fixes like:
|
||||||
|
- virtio-net: correctly copy vnet header when flushing TX
|
||||||
|
- hw/pflash: implement update buffer for block writes
|
||||||
|
- Fixes to i386 emulation and ARM emulation.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 02 Feb 2024 19:08:13 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-6) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* revert attempted fix to avoid rare issue with stuck guest IO when using
|
||||||
|
iothread, because it caused a much more common issue with iothreads
|
||||||
|
consuming too much CPU
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 15 Dec 2023 14:22:06 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-5) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* backport workaround for stuck guest IO with iothread and VirtIO block/SCSI
|
||||||
|
in some rare edge cases
|
||||||
|
|
||||||
|
* backport fix for potential deadlock when issuing the "resize" QMP command
|
||||||
|
for a disk that is using iothread
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 11 Dec 2023 16:58:27 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-4) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix vnc clipboard in the host to guest direction
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 22 Nov 2023 14:28:21 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-3) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix #5054: backport fix for software reset with SATA, avoiding breakage
|
||||||
|
with, e.g., some FreeBSD VMs
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 20 Nov 2023 10:24:50 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-2) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* revert "x86: acpi: workaround Windows not handling name references in
|
||||||
|
Package properly" as that seems to have broken networking (and possibly
|
||||||
|
other things) one some localized variants of Windows (e.g., the German
|
||||||
|
versions).
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 17 Nov 2023 11:55:23 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.2-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update submodule and patches to QEMU 8.1.2
|
||||||
|
|
||||||
|
* use QEMU's keycode-map-db again instead of our static copy from QEMU 6.0
|
||||||
|
|
||||||
|
* disable graph locking, newly introduced in the 8.1 release, as it has
|
||||||
|
still various deadlock issuess, e.g., during canceling backup jobs.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 24 Oct 2023 13:42:45 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-7) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix #2874: SATA: avoid unsolicited write to sector 0 during reset
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 04 Oct 2023 08:33:35 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-6) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix #1534: vma: add extract-filter for disk images allowing users to pass
|
||||||
|
a comma separated list of the disks they want to extract from an archive.
|
||||||
|
|
||||||
|
* backup: create jobs in a drained section to avoid subtle bugs where
|
||||||
|
something interferes with the block-copy-state bitmap on initialization
|
||||||
|
|
||||||
|
* backup: drop experimental, and since a while also fully broken, directory
|
||||||
|
backup format (BACKUP_FORMAT_DIR). This format was never exposed via the
|
||||||
|
Proxmox VE API, but only available via QMP, as its broken since QEMU 8 and
|
||||||
|
we got zero reports about that, it's safe to assume that there are no
|
||||||
|
public users, so just remove it completely.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 06 Sep 2023 17:03:59 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-5) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* improve memory footprint after backup by not keeping as much memory
|
||||||
|
resident.
|
||||||
|
|
||||||
|
* fix file descriptor leak for vhost (used by default by vNICs).
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 16 Aug 2023 11:52:24 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-4) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix resume for snapshot and hibernate in combination with iothread and
|
||||||
|
dirty bitmap
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 28 Jul 2023 12:58:22 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-3) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix regression in QEMU 8.0 for drive mirror with bitmap
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 15 Jun 2023 13:57:46 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-2) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* drop custom get_link_status QMP command, was never really used.
|
||||||
|
|
||||||
|
* drop custom & deprecated drive snapshot QMP commands, we use a better
|
||||||
|
alternative since a while.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 09 Jun 2023 07:57:56 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.2-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 8.0.2
|
||||||
|
|
||||||
|
* update patches for avoiding issues with DMA reentrancy to current,
|
||||||
|
slightly optimized version.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 06 Jun 2023 16:34:50 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.0.0-1) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 8.0.0
|
||||||
|
|
||||||
|
* re-build for Proxmox VE 8 / Debian 12 Bookworm
|
||||||
|
|
||||||
|
* adapt to the local virtiofsd C variant being dropped, it has been
|
||||||
|
rewritten in Rust and is now hosted in a separate source repository.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 22 May 2023 13:45:49 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-8) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* backport fix for ACPI CPU hotplug issue with TCG
|
||||||
|
|
||||||
|
* cherry-pick TCG-related stable fixes for 7.2 for users that turned off KVM
|
||||||
|
HW acceleration
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 17 Mar 2023 15:47:08 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-7) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* improve fix for potential deadlock with trim for IDE/SATA and draining
|
||||||
|
|
||||||
|
* backport stable fixes:
|
||||||
|
- hw/nvme: fix missing endian conversions for doorbell buffers
|
||||||
|
- hw/smbios: fix field corruption in type 4 table
|
||||||
|
- virtio-rng-pci: fix transitional migration compat for vectors
|
||||||
|
- hw/timer/hpet: Fix expiration time overflow
|
||||||
|
- vhost/vdpa: stop all svq on device deletion
|
||||||
|
- vhost: avoid a potential use of an uninitialized variable in the call to
|
||||||
|
vhost_svq_poll
|
||||||
|
- chardev/char-socket: set s->listener = NULL in char_socket_finalize to
|
||||||
|
fix a potential crash after live-migration
|
||||||
|
- intel-iommu: fail MAP notifier without caching mode
|
||||||
|
- intel-iommu: fail DEVIOTLB_UNMAP without dt mode
|
||||||
|
|
||||||
|
* fix a regression for when the LSI SCSI controller is used
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 13 Mar 2023 17:42:49 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-6) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* fix 7.2 regression for Linux boot failures with megasas SCSI
|
||||||
|
|
||||||
|
* fix 7.0 regression for a potential deadlock with trim for IDE/SATA and
|
||||||
|
draining
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 08 Mar 2023 14:32:17 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-5) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* fix #4476: savevm-async: avoid looping without progress
|
||||||
|
|
||||||
|
* savevm-async: decrease the boundary for free space for (memory) state left
|
||||||
|
on target from 30 MiB to 100 MiB, improving the heuristic for when to
|
||||||
|
enter the final "pause and sync" stage.
|
||||||
|
|
||||||
|
* QMP backup: use correct error number when getting blockdrive length fails
|
||||||
|
|
||||||
|
* backport fix for some DMA reentrancy issues, better protecting against
|
||||||
|
malicious guests
|
||||||
|
|
||||||
|
* backport fix for iSCSI double free issue leading to crashes
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 21 Feb 2023 13:49:43 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-4) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* backport fix for a 7.2 regression when using VirtIO disk with
|
||||||
|
detect-zeroes=unmap
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 27 Jan 2023 09:37:49 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-3) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* add fix for live-migration with virtio-rng devices, which regressed in
|
||||||
|
QEMU 7.2.0.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 12 Jan 2023 13:13:14 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-2) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* enable slirp again for now, as in qemu-server, user networking is
|
||||||
|
supported (via CLI/API) when no bridge is set on a virtual NIC
|
||||||
|
|
||||||
|
* cherry-pick stable fixes for 7.2. Two for virtio-mem and one for vIOMMU.
|
||||||
|
Both features are not yet exposed in PVE's qemu-server, but there's work
|
||||||
|
going on to change that.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 10 Jan 2023 15:47:48 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.2.0-1) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 7.2.0
|
||||||
|
|
||||||
|
* drop 'slirp' networking
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 16 Dec 2022 13:18:21 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.1.0-4) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* cherry-pick "block/block-backend: blk_set_enable_write_cache is IO_CODE"
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 22 Nov 2022 09:21:06 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.1.0-3) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* init: daemonize: defuse PID file resolve error to a warning at max, fixing
|
||||||
|
some usecases that regressed with 7.1, like tracking start up in our
|
||||||
|
file-restore VM.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 28 Oct 2022 10:27:49 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.1.0-2) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* fix an issue with error handling in async backup code
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 18 Oct 2022 15:33:44 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.1.0-1) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 7.1.0
|
||||||
|
|
||||||
|
* add fix for io_uring_register_ring_fd from upstream
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 14 Oct 2022 14:54:09 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.0.0-4) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* add revision to version output
|
||||||
|
|
||||||
|
* PVE Backup: allow passing max-workers performance setting
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 10 Oct 2022 11:55:37 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.0.0-3) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* savevm-async: avoid segfault when aborting snapshot creation task
|
||||||
|
|
||||||
|
* savevm-async: set SAVE_STATE_DONE when closing state file was successful
|
||||||
|
allowing one to start a new snapshot task after aborting one.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Tue, 30 Aug 2022 12:54:03 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.0.0-2) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* backport "io_uring: fix short read slow path"
|
||||||
|
|
||||||
|
* backport "e1000: set RX descriptor status in a separate operation"
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 20 Jul 2022 09:17:07 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (7.0.0-1) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 7.0.0
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 30 Jun 2022 11:07:37 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-11) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* add 'namespace' to BlockdevOptionsPbs for live-restore support
|
||||||
|
|
||||||
|
* vma: create: support 64KiB-unaligned input images like to improve backing
|
||||||
|
up some VM templates
|
||||||
|
|
||||||
|
* block: alloc-track: avoid unlikely, but possible premature break
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 22 Jun 2022 15:54:54 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-10) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* fix #4101: fix backup cancellation bug with iothreads
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 9 Jun 2022 16:35:51 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-9) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* fix possible race conditions during cancellation of a PBS backup
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 08 Jun 2022 14:03:22 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-8) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* revert "block/rbd: implement bdrv_co_block_status" to work around
|
||||||
|
performance regression when backing up large RBD disk
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 19 May 2022 09:24:45 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-7) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* Proxmox Backup Server namespace support
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 12 May 2022 16:05:56 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-6) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* block/gluster: correctly set max_pdiscard which is int64_t to avoid
|
||||||
|
triggering assertion
|
||||||
|
|
||||||
|
* ui/vnc.c: Fixed a deadlock bug
|
||||||
|
|
||||||
|
* display/qxl-render: fix race condition in qxl_cursor (CVE-2021-4207) and
|
||||||
|
integer overflow in cursor_alloc (CVE-2021-4206)
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Wed, 11 May 2022 10:42:53 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-5) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* vma: allow partial restore by skipping some disk
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 25 Apr 2022 10:13:46 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-4) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* d/control: add libgbm to build dependencies
|
||||||
|
|
||||||
|
* d/control: add suggest dependency-hint for libgl1
|
||||||
|
|
||||||
|
* various stable backports:
|
||||||
|
+ virtio-net: fix map leaking on error during receive
|
||||||
|
+ memory: Fix incorrect calls of log_global_start/stop
|
||||||
|
+ acpi: fix OEM ID/OEM Table ID padding
|
||||||
|
+ vhost-vsock: detach the virqueue element in case of error
|
||||||
|
+ vhost-user: remove VirtQ notifier restore
|
||||||
|
+ vhost-user: fix VirtQ notifier cleanup
|
||||||
|
+ virtio: fix the condition for iommu_platform not supported
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 22 Apr 2022 11:52:30 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-3) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* cherry-pick fix for some manually added ACPI table SLIC entries via the
|
||||||
|
custom args flag.
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Fri, 15 Apr 2022 09:09:37 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-2) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* compile in virgl support
|
||||||
|
|
||||||
|
* enable zstd support
|
||||||
|
|
||||||
|
* drop sdl dependency (it was disabled at compile time already)
|
||||||
|
|
||||||
|
* recommend 'numactl'
|
||||||
|
|
||||||
|
* fix an issue with multi-disk backups where chunks would be written
|
||||||
|
multiple times
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 03 Mar 2022 12:03:44 +0100
|
||||||
|
|
||||||
|
pve-qemu-kvm (6.2.0-1) bullseye; urgency=medium
|
||||||
|
|
||||||
|
* update to QEMU stable release 6.2.0
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Thu, 17 Feb 2022 06:23:14 +0100
|
||||||
|
|
||||||
pve-qemu-kvm (6.1.1-2) bullseye; urgency=medium
|
pve-qemu-kvm (6.1.1-2) bullseye; urgency=medium
|
||||||
|
|
||||||
|
|
|
@ -1 +0,0 @@
|
||||||
10
|
|
|
@ -2,41 +2,43 @@ Source: pve-qemu-kvm
|
||||||
Section: admin
|
Section: admin
|
||||||
Priority: optional
|
Priority: optional
|
||||||
Maintainer: Proxmox Support Team <support@proxmox.com>
|
Maintainer: Proxmox Support Team <support@proxmox.com>
|
||||||
Build-Depends: autotools-dev,
|
Build-Depends: debhelper-compat (= 13),
|
||||||
check,
|
check,
|
||||||
debhelper (>= 9),
|
|
||||||
libacl1-dev,
|
libacl1-dev,
|
||||||
libaio-dev,
|
libaio-dev,
|
||||||
libattr1-dev,
|
libattr1-dev,
|
||||||
libcap-ng-dev,
|
libcap-ng-dev,
|
||||||
libcurl4-gnutls-dev,
|
libcurl4-gnutls-dev,
|
||||||
|
libepoxy-dev,
|
||||||
libfdt-dev,
|
libfdt-dev,
|
||||||
|
libgbm-dev,
|
||||||
libglusterfs-dev (>= 5.2-2),
|
libglusterfs-dev (>= 5.2-2),
|
||||||
libgnutls28-dev,
|
libgnutls28-dev,
|
||||||
libiscsi-dev (>= 1.12.0),
|
libiscsi-dev (>= 1.12.0),
|
||||||
libjemalloc-dev,
|
|
||||||
libjpeg-dev,
|
libjpeg-dev,
|
||||||
libjson-perl,
|
libjson-perl,
|
||||||
libnuma-dev,
|
libnuma-dev,
|
||||||
libpci-dev,
|
libpci-dev,
|
||||||
libpixman-1-dev,
|
libpixman-1-dev,
|
||||||
libproxmox-backup-qemu0-dev (>= 1.0.3-1),
|
libproxmox-backup-qemu0-dev (>= 1.3.0),
|
||||||
librbd-dev (>= 0.48),
|
librbd-dev (>= 0.48),
|
||||||
libsdl1.2-dev,
|
libsdl1.2-dev,
|
||||||
libseccomp-dev,
|
libseccomp-dev,
|
||||||
|
libslirp-dev,
|
||||||
libspice-protocol-dev (>= 0.12.14~),
|
libspice-protocol-dev (>= 0.12.14~),
|
||||||
libspice-server-dev (>= 0.14.0~),
|
libspice-server-dev (>= 0.14.0~),
|
||||||
libsystemd-dev,
|
libsystemd-dev,
|
||||||
liburing-dev,
|
liburing-dev,
|
||||||
libusb-1.0-0-dev (>= 1.0.17-1),
|
libusb-1.0-0-dev (>= 1.0.17),
|
||||||
libusbredirparser-dev (>= 0.6-2),
|
libusbredirparser-dev (>= 0.6-2),
|
||||||
|
libvirglrenderer-dev,
|
||||||
|
libzstd-dev,
|
||||||
meson,
|
meson,
|
||||||
python3-minimal,
|
python3-minimal,
|
||||||
python3-sphinx,
|
python3-sphinx,
|
||||||
python3-sphinx-rtd-theme,
|
python3-sphinx-rtd-theme,
|
||||||
|
python3-venv,
|
||||||
quilt,
|
quilt,
|
||||||
texi2html,
|
|
||||||
texinfo,
|
|
||||||
uuid-dev,
|
uuid-dev,
|
||||||
xfslibs-dev,
|
xfslibs-dev,
|
||||||
Standards-Version: 3.7.2
|
Standards-Version: 3.7.2
|
||||||
|
@ -45,7 +47,6 @@ Package: pve-qemu-kvm
|
||||||
Architecture: any
|
Architecture: any
|
||||||
Depends: ceph-common (>= 0.48),
|
Depends: ceph-common (>= 0.48),
|
||||||
iproute2,
|
iproute2,
|
||||||
libaio1,
|
|
||||||
libgfapi0 | glusterfs-common (>= 5.6),
|
libgfapi0 | glusterfs-common (>= 5.6),
|
||||||
libgfchangelog0 | glusterfs-common (>= 5.6),
|
libgfchangelog0 | glusterfs-common (>= 5.6),
|
||||||
libgfdb0 | glusterfs-common (>= 5.6),
|
libgfdb0 | glusterfs-common (>= 5.6),
|
||||||
|
@ -54,16 +55,16 @@ Depends: ceph-common (>= 0.48),
|
||||||
libglusterfs-dev | glusterfs-common (>= 5.6),
|
libglusterfs-dev | glusterfs-common (>= 5.6),
|
||||||
libglusterfs0 | glusterfs-common (>= 5.6),
|
libglusterfs0 | glusterfs-common (>= 5.6),
|
||||||
libiscsi4 (>= 1.12.0) | libiscsi7,
|
libiscsi4 (>= 1.12.0) | libiscsi7,
|
||||||
libjemalloc2,
|
|
||||||
libjpeg62-turbo,
|
libjpeg62-turbo,
|
||||||
libsdl1.2debian,
|
|
||||||
libspice-server1 (>= 0.14.0~),
|
libspice-server1 (>= 0.14.0~),
|
||||||
libusb-1.0-0 (>= 1.0.17-1),
|
libusb-1.0-0 (>= 1.0.17-1),
|
||||||
libusbredirparser1 (>= 0.6-2),
|
libusbredirparser1 (>= 0.6-2),
|
||||||
|
vitastor-client (>= 0.9.4),
|
||||||
libuuid1,
|
libuuid1,
|
||||||
numactl,
|
|
||||||
${misc:Depends},
|
${misc:Depends},
|
||||||
${shlibs:Depends},
|
${shlibs:Depends},
|
||||||
|
Recommends: numactl,
|
||||||
|
Suggests: libgl1,
|
||||||
Conflicts: kvm,
|
Conflicts: kvm,
|
||||||
pve-kvm,
|
pve-kvm,
|
||||||
pve-qemu-kvm-2.6.18,
|
pve-qemu-kvm-2.6.18,
|
||||||
|
@ -71,22 +72,17 @@ Conflicts: kvm,
|
||||||
qemu-kvm,
|
qemu-kvm,
|
||||||
qemu-system-arm,
|
qemu-system-arm,
|
||||||
qemu-system-common,
|
qemu-system-common,
|
||||||
|
qemu-system-data,
|
||||||
qemu-system-x86,
|
qemu-system-x86,
|
||||||
qemu-utils,
|
qemu-utils,
|
||||||
Provides: qemu-system-arm, qemu-system-x86, qemu-utils
|
Provides: qemu-system-arm, qemu-system-x86, qemu-utils,
|
||||||
Replaces: pve-kvm,
|
Replaces: pve-kvm,
|
||||||
pve-qemu-kvm-2.6.18,
|
pve-qemu-kvm-2.6.18,
|
||||||
qemu-system-arm,
|
qemu-system-arm,
|
||||||
qemu-system-x86,
|
qemu-system-x86,
|
||||||
qemu-utils,
|
qemu-utils,
|
||||||
|
Breaks: qemu-server (<= 8.0.6)
|
||||||
Description: Full virtualization on x86 hardware
|
Description: Full virtualization on x86 hardware
|
||||||
Using KVM, one can run multiple virtual PCs, each running unmodified Linux or
|
Using KVM, one can run multiple virtual PCs, each running unmodified Linux or
|
||||||
Windows images. Each virtual machine has private virtualized hardware: a
|
Windows images. Each virtual machine has private virtualized hardware: a
|
||||||
network card, disk, graphics adapter, etc.
|
network card, disk, graphics adapter, etc.
|
||||||
|
|
||||||
Package: pve-qemu-kvm-dbg
|
|
||||||
Architecture: any
|
|
||||||
Section: debug
|
|
||||||
Depends: pve-qemu-kvm (= ${binary:Version})
|
|
||||||
Description: pve qemu debugging symbols
|
|
||||||
This package contains the debugging symbols for pve-qemu-kvm.
|
|
||||||
|
|
|
@ -25,7 +25,7 @@ License:
|
||||||
|
|
||||||
In particular, the QEMU virtual CPU core library (libqemu.a) is
|
In particular, the QEMU virtual CPU core library (libqemu.a) is
|
||||||
released under the GNU Lesser General Public License version 2 or later.
|
released under the GNU Lesser General Public License version 2 or later.
|
||||||
On Debian systems, the complete text of the GNU Lesser General Public
|
On Debian systems, the complete text of the GNU Lesser General Public
|
||||||
License can be found in the file /usr/share/common-licenses/LGPL.
|
License can be found in the file /usr/share/common-licenses/LGPL.
|
||||||
|
|
||||||
Some hardware device emulation sources and other QEMU functionality are
|
Some hardware device emulation sources and other QEMU functionality are
|
||||||
|
|
|
@ -24,4 +24,5 @@ while (<STDIN>) {
|
||||||
|
|
||||||
die "no QEMU machine types detected from STDIN input" if scalar (@$machines) <= 0;
|
die "no QEMU machine types detected from STDIN input" if scalar (@$machines) <= 0;
|
||||||
|
|
||||||
print to_json($machines, { utf8 => 1 }) or die "$!\n";
|
print to_json($machines, { utf8 => 1, canonical => 1 })
|
||||||
|
or die "failed to encode detected machines as JSON - $!\n";
|
||||||
|
|
|
@ -27,19 +27,21 @@ Signed-off-by: Ma Haocong <mahaocong@didichuxing.com>
|
||||||
Signed-off-by: John Snow <jsnow@redhat.com>
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
||||||
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: rebased for 8.2.2]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/mirror.c | 98 +++++++++++++++++++++++++-------
|
block/mirror.c | 99 ++++++++++++++++++++------
|
||||||
blockdev.c | 39 ++++++++++++-
|
blockdev.c | 38 +++++++++-
|
||||||
include/block/block_int.h | 4 +-
|
include/block/block_int-global-state.h | 4 +-
|
||||||
qapi/block-core.json | 29 ++++++++--
|
qapi/block-core.json | 25 ++++++-
|
||||||
tests/unit/test-block-iothread.c | 4 +-
|
tests/unit/test-block-iothread.c | 4 +-
|
||||||
5 files changed, 145 insertions(+), 29 deletions(-)
|
5 files changed, 142 insertions(+), 28 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index 85b781bc21..0821214138 100644
|
index 1bdce3b657..0c5c72df2e 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -50,7 +50,7 @@ typedef struct MirrorBlockJob {
|
@@ -51,7 +51,7 @@ typedef struct MirrorBlockJob {
|
||||||
BlockDriverState *to_replace;
|
BlockDriverState *to_replace;
|
||||||
/* Used to block operations on the drive-mirror-replace target */
|
/* Used to block operations on the drive-mirror-replace target */
|
||||||
Error *replace_blocker;
|
Error *replace_blocker;
|
||||||
|
@ -48,7 +50,7 @@ index 85b781bc21..0821214138 100644
|
||||||
BlockMirrorBackingMode backing_mode;
|
BlockMirrorBackingMode backing_mode;
|
||||||
/* Whether the target image requires explicit zero-initialization */
|
/* Whether the target image requires explicit zero-initialization */
|
||||||
bool zero_target;
|
bool zero_target;
|
||||||
@@ -65,6 +65,8 @@ typedef struct MirrorBlockJob {
|
@@ -73,6 +73,8 @@ typedef struct MirrorBlockJob {
|
||||||
size_t buf_size;
|
size_t buf_size;
|
||||||
int64_t bdev_length;
|
int64_t bdev_length;
|
||||||
unsigned long *cow_bitmap;
|
unsigned long *cow_bitmap;
|
||||||
|
@ -57,9 +59,9 @@ index 85b781bc21..0821214138 100644
|
||||||
BdrvDirtyBitmap *dirty_bitmap;
|
BdrvDirtyBitmap *dirty_bitmap;
|
||||||
BdrvDirtyBitmapIter *dbi;
|
BdrvDirtyBitmapIter *dbi;
|
||||||
uint8_t *buf;
|
uint8_t *buf;
|
||||||
@@ -697,7 +699,8 @@ static int mirror_exit_common(Job *job)
|
@@ -722,7 +724,8 @@ static int mirror_exit_common(Job *job)
|
||||||
bdrv_child_refresh_perms(mirror_top_bs, mirror_top_bs->backing,
|
|
||||||
&error_abort);
|
&error_abort);
|
||||||
|
|
||||||
if (!abort && s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {
|
if (!abort && s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {
|
||||||
- BlockDriverState *backing = s->is_none_mode ? src : s->base;
|
- BlockDriverState *backing = s->is_none_mode ? src : s->base;
|
||||||
+ BlockDriverState *backing;
|
+ BlockDriverState *backing;
|
||||||
|
@ -67,7 +69,7 @@ index 85b781bc21..0821214138 100644
|
||||||
BlockDriverState *unfiltered_target = bdrv_skip_filters(target_bs);
|
BlockDriverState *unfiltered_target = bdrv_skip_filters(target_bs);
|
||||||
|
|
||||||
if (bdrv_cow_bs(unfiltered_target) != backing) {
|
if (bdrv_cow_bs(unfiltered_target) != backing) {
|
||||||
@@ -802,6 +805,16 @@ static void mirror_abort(Job *job)
|
@@ -819,6 +822,16 @@ static void mirror_abort(Job *job)
|
||||||
assert(ret == 0);
|
assert(ret == 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -84,7 +86,7 @@ index 85b781bc21..0821214138 100644
|
||||||
static void coroutine_fn mirror_throttle(MirrorBlockJob *s)
|
static void coroutine_fn mirror_throttle(MirrorBlockJob *s)
|
||||||
{
|
{
|
||||||
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
||||||
@@ -983,7 +996,8 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
|
@@ -1015,7 +1028,8 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
|
||||||
mirror_free_init(s);
|
mirror_free_init(s);
|
||||||
|
|
||||||
s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
||||||
|
@ -94,7 +96,7 @@ index 85b781bc21..0821214138 100644
|
||||||
ret = mirror_dirty_init(s);
|
ret = mirror_dirty_init(s);
|
||||||
if (ret < 0 || job_is_cancelled(&s->common.job)) {
|
if (ret < 0 || job_is_cancelled(&s->common.job)) {
|
||||||
goto immediate_exit;
|
goto immediate_exit;
|
||||||
@@ -1216,6 +1230,7 @@ static const BlockJobDriver mirror_job_driver = {
|
@@ -1304,6 +1318,7 @@ static const BlockJobDriver mirror_job_driver = {
|
||||||
.run = mirror_run,
|
.run = mirror_run,
|
||||||
.prepare = mirror_prepare,
|
.prepare = mirror_prepare,
|
||||||
.abort = mirror_abort,
|
.abort = mirror_abort,
|
||||||
|
@ -102,15 +104,15 @@ index 85b781bc21..0821214138 100644
|
||||||
.pause = mirror_pause,
|
.pause = mirror_pause,
|
||||||
.complete = mirror_complete,
|
.complete = mirror_complete,
|
||||||
.cancel = mirror_cancel,
|
.cancel = mirror_cancel,
|
||||||
@@ -1232,6 +1247,7 @@ static const BlockJobDriver commit_active_job_driver = {
|
@@ -1322,6 +1337,7 @@ static const BlockJobDriver commit_active_job_driver = {
|
||||||
.run = mirror_run,
|
.run = mirror_run,
|
||||||
.prepare = mirror_prepare,
|
.prepare = mirror_prepare,
|
||||||
.abort = mirror_abort,
|
.abort = mirror_abort,
|
||||||
+ .clean = mirror_clean,
|
+ .clean = mirror_clean,
|
||||||
.pause = mirror_pause,
|
.pause = mirror_pause,
|
||||||
.complete = mirror_complete,
|
.complete = mirror_complete,
|
||||||
},
|
.cancel = commit_active_cancel,
|
||||||
@@ -1594,7 +1610,10 @@ static BlockJob *mirror_start_job(
|
@@ -1714,7 +1730,10 @@ static BlockJob *mirror_start_job(
|
||||||
BlockCompletionFunc *cb,
|
BlockCompletionFunc *cb,
|
||||||
void *opaque,
|
void *opaque,
|
||||||
const BlockJobDriver *driver,
|
const BlockJobDriver *driver,
|
||||||
|
@ -122,11 +124,12 @@ index 85b781bc21..0821214138 100644
|
||||||
bool auto_complete, const char *filter_node_name,
|
bool auto_complete, const char *filter_node_name,
|
||||||
bool is_mirror, MirrorCopyMode copy_mode,
|
bool is_mirror, MirrorCopyMode copy_mode,
|
||||||
Error **errp)
|
Error **errp)
|
||||||
@@ -1606,10 +1625,39 @@ static BlockJob *mirror_start_job(
|
@@ -1728,10 +1747,39 @@ static BlockJob *mirror_start_job(
|
||||||
uint64_t target_perms, target_shared_perms;
|
|
||||||
int ret;
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
- if (granularity == 0) {
|
- if (granularity == 0) {
|
||||||
|
- granularity = bdrv_get_default_bitmap_granularity(target);
|
||||||
+ if (sync_mode == MIRROR_SYNC_MODE_INCREMENTAL) {
|
+ if (sync_mode == MIRROR_SYNC_MODE_INCREMENTAL) {
|
||||||
+ error_setg(errp, "Sync mode '%s' not supported",
|
+ error_setg(errp, "Sync mode '%s' not supported",
|
||||||
+ MirrorSyncMode_str(sync_mode));
|
+ MirrorSyncMode_str(sync_mode));
|
||||||
|
@ -147,8 +150,8 @@ index 85b781bc21..0821214138 100644
|
||||||
+ "sync mode '%s' is not compatible with bitmaps",
|
+ "sync mode '%s' is not compatible with bitmaps",
|
||||||
+ MirrorSyncMode_str(sync_mode));
|
+ MirrorSyncMode_str(sync_mode));
|
||||||
+ return NULL;
|
+ return NULL;
|
||||||
+ }
|
}
|
||||||
+
|
|
||||||
+ if (bitmap) {
|
+ if (bitmap) {
|
||||||
+ if (granularity) {
|
+ if (granularity) {
|
||||||
+ error_setg(errp, "granularity (%d)"
|
+ error_setg(errp, "granularity (%d)"
|
||||||
|
@ -158,13 +161,12 @@ index 85b781bc21..0821214138 100644
|
||||||
+ }
|
+ }
|
||||||
+ granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
+ granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
||||||
+ } else if (granularity == 0) {
|
+ } else if (granularity == 0) {
|
||||||
granularity = bdrv_get_default_bitmap_granularity(target);
|
+ granularity = bdrv_get_default_bitmap_granularity(target);
|
||||||
}
|
+ }
|
||||||
-
|
|
||||||
assert(is_power_of_2(granularity));
|
assert(is_power_of_2(granularity));
|
||||||
|
|
||||||
if (buf_size < 0) {
|
if (buf_size < 0) {
|
||||||
@@ -1747,7 +1795,9 @@ static BlockJob *mirror_start_job(
|
@@ -1871,7 +1919,9 @@ static BlockJob *mirror_start_job(
|
||||||
s->replaces = g_strdup(replaces);
|
s->replaces = g_strdup(replaces);
|
||||||
s->on_source_error = on_source_error;
|
s->on_source_error = on_source_error;
|
||||||
s->on_target_error = on_target_error;
|
s->on_target_error = on_target_error;
|
||||||
|
@ -174,10 +176,10 @@ index 85b781bc21..0821214138 100644
|
||||||
+ s->bitmap_mode = bitmap_mode;
|
+ s->bitmap_mode = bitmap_mode;
|
||||||
s->backing_mode = backing_mode;
|
s->backing_mode = backing_mode;
|
||||||
s->zero_target = zero_target;
|
s->zero_target = zero_target;
|
||||||
s->copy_mode = copy_mode;
|
qatomic_set(&s->copy_mode, copy_mode);
|
||||||
@@ -1768,6 +1818,18 @@ static BlockJob *mirror_start_job(
|
@@ -1897,6 +1947,18 @@ static BlockJob *mirror_start_job(
|
||||||
bdrv_disable_dirty_bitmap(s->dirty_bitmap);
|
*/
|
||||||
}
|
bdrv_disable_dirty_bitmap(s->dirty_bitmap);
|
||||||
|
|
||||||
+ if (s->sync_bitmap) {
|
+ if (s->sync_bitmap) {
|
||||||
+ bdrv_dirty_bitmap_set_busy(s->sync_bitmap, true);
|
+ bdrv_dirty_bitmap_set_busy(s->sync_bitmap, true);
|
||||||
|
@ -191,10 +193,10 @@ index 85b781bc21..0821214138 100644
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
bdrv_graph_wrlock();
|
||||||
ret = block_job_add_bdrv(&s->common, "source", bs, 0,
|
ret = block_job_add_bdrv(&s->common, "source", bs, 0,
|
||||||
BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE |
|
BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE |
|
||||||
BLK_PERM_CONSISTENT_READ,
|
@@ -1979,6 +2041,9 @@ fail:
|
||||||
@@ -1845,6 +1907,9 @@ fail:
|
|
||||||
if (s->dirty_bitmap) {
|
if (s->dirty_bitmap) {
|
||||||
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
||||||
}
|
}
|
||||||
|
@ -204,7 +206,7 @@ index 85b781bc21..0821214138 100644
|
||||||
job_early_fail(&s->common.job);
|
job_early_fail(&s->common.job);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1862,29 +1927,23 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
@@ -2001,35 +2066,28 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
||||||
BlockDriverState *target, const char *replaces,
|
BlockDriverState *target, const char *replaces,
|
||||||
int creation_flags, int64_t speed,
|
int creation_flags, int64_t speed,
|
||||||
uint32_t granularity, int64_t buf_size,
|
uint32_t granularity, int64_t buf_size,
|
||||||
|
@ -221,14 +223,20 @@ index 85b781bc21..0821214138 100644
|
||||||
- bool is_none_mode;
|
- bool is_none_mode;
|
||||||
BlockDriverState *base;
|
BlockDriverState *base;
|
||||||
|
|
||||||
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
- if ((mode == MIRROR_SYNC_MODE_INCREMENTAL) ||
|
- if ((mode == MIRROR_SYNC_MODE_INCREMENTAL) ||
|
||||||
- (mode == MIRROR_SYNC_MODE_BITMAP)) {
|
- (mode == MIRROR_SYNC_MODE_BITMAP)) {
|
||||||
- error_setg(errp, "Sync mode '%s' not supported",
|
- error_setg(errp, "Sync mode '%s' not supported",
|
||||||
- MirrorSyncMode_str(mode));
|
- MirrorSyncMode_str(mode));
|
||||||
- return;
|
- return;
|
||||||
- }
|
- }
|
||||||
|
-
|
||||||
|
bdrv_graph_rdlock_main_loop();
|
||||||
- is_none_mode = mode == MIRROR_SYNC_MODE_NONE;
|
- is_none_mode = mode == MIRROR_SYNC_MODE_NONE;
|
||||||
base = mode == MIRROR_SYNC_MODE_TOP ? bdrv_backing_chain_next(bs) : NULL;
|
base = mode == MIRROR_SYNC_MODE_TOP ? bdrv_backing_chain_next(bs) : NULL;
|
||||||
|
bdrv_graph_rdunlock_main_loop();
|
||||||
|
|
||||||
mirror_start_job(job_id, bs, creation_flags, target, replaces,
|
mirror_start_job(job_id, bs, creation_flags, target, replaces,
|
||||||
speed, granularity, buf_size, backing_mode, zero_target,
|
speed, granularity, buf_size, backing_mode, zero_target,
|
||||||
on_source_error, on_target_error, unmap, NULL, NULL,
|
on_source_error, on_target_error, unmap, NULL, NULL,
|
||||||
|
@ -239,7 +247,7 @@ index 85b781bc21..0821214138 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
||||||
@@ -1909,7 +1968,8 @@ BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
@@ -2056,7 +2114,8 @@ BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
||||||
job_id, bs, creation_flags, base, NULL, speed, 0, 0,
|
job_id, bs, creation_flags, base, NULL, speed, 0, 0,
|
||||||
MIRROR_LEAVE_BACKING_CHAIN, false,
|
MIRROR_LEAVE_BACKING_CHAIN, false,
|
||||||
on_error, on_error, true, cb, opaque,
|
on_error, on_error, true, cb, opaque,
|
||||||
|
@ -250,33 +258,32 @@ index 85b781bc21..0821214138 100644
|
||||||
errp);
|
errp);
|
||||||
if (!job) {
|
if (!job) {
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 3d8ac368a1..03e99264dc 100644
|
index 4c33c3f5f0..f3e508a6a7 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -2957,6 +2957,10 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2776,6 +2776,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
BlockDriverState *target,
|
BlockDriverState *target,
|
||||||
bool has_replaces, const char *replaces,
|
const char *replaces,
|
||||||
enum MirrorSyncMode sync,
|
enum MirrorSyncMode sync,
|
||||||
+ bool has_bitmap,
|
|
||||||
+ const char *bitmap_name,
|
+ const char *bitmap_name,
|
||||||
+ bool has_bitmap_mode,
|
+ bool has_bitmap_mode,
|
||||||
+ BitmapSyncMode bitmap_mode,
|
+ BitmapSyncMode bitmap_mode,
|
||||||
BlockMirrorBackingMode backing_mode,
|
BlockMirrorBackingMode backing_mode,
|
||||||
bool zero_target,
|
bool zero_target,
|
||||||
bool has_speed, int64_t speed,
|
bool has_speed, int64_t speed,
|
||||||
@@ -2976,6 +2980,7 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2794,6 +2797,7 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
{
|
{
|
||||||
BlockDriverState *unfiltered_bs;
|
BlockDriverState *unfiltered_bs;
|
||||||
int job_flags = JOB_DEFAULT;
|
int job_flags = JOB_DEFAULT;
|
||||||
+ BdrvDirtyBitmap *bitmap = NULL;
|
+ BdrvDirtyBitmap *bitmap = NULL;
|
||||||
|
|
||||||
if (!has_speed) {
|
GLOBAL_STATE_CODE();
|
||||||
speed = 0;
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
||||||
@@ -3030,6 +3035,29 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2848,6 +2852,29 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
sync = MIRROR_SYNC_MODE_FULL;
|
sync = MIRROR_SYNC_MODE_FULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
+ if (has_bitmap) {
|
+ if (bitmap_name) {
|
||||||
+ if (granularity) {
|
+ if (granularity) {
|
||||||
+ error_setg(errp, "Granularity and bitmap cannot both be set");
|
+ error_setg(errp, "Granularity and bitmap cannot both be set");
|
||||||
+ return;
|
+ return;
|
||||||
|
@ -299,53 +306,53 @@ index 3d8ac368a1..03e99264dc 100644
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
if (!has_replaces) {
|
if (!replaces) {
|
||||||
/* We want to mirror from @bs, but keep implicit filters on top */
|
/* We want to mirror from @bs, but keep implicit filters on top */
|
||||||
unfiltered_bs = bdrv_skip_implicit_filters(bs);
|
unfiltered_bs = bdrv_skip_implicit_filters(bs);
|
||||||
@@ -3076,8 +3104,8 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2889,8 +2916,8 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
* and will allow to check whether the node still exist at mirror completion
|
* and will allow to check whether the node still exist at mirror completion
|
||||||
*/
|
*/
|
||||||
mirror_start(job_id, bs, target,
|
mirror_start(job_id, bs, target,
|
||||||
- has_replaces ? replaces : NULL, job_flags,
|
- replaces, job_flags,
|
||||||
- speed, granularity, buf_size, sync, backing_mode, zero_target,
|
- speed, granularity, buf_size, sync, backing_mode, zero_target,
|
||||||
+ has_replaces ? replaces : NULL, job_flags, speed, granularity,
|
+ replaces, job_flags, speed, granularity, buf_size, sync,
|
||||||
+ buf_size, sync, bitmap, bitmap_mode, backing_mode, zero_target,
|
+ bitmap, bitmap_mode, backing_mode, zero_target,
|
||||||
on_source_error, on_target_error, unmap, filter_node_name,
|
on_source_error, on_target_error, unmap, filter_node_name,
|
||||||
copy_mode, errp);
|
copy_mode, errp);
|
||||||
}
|
}
|
||||||
@@ -3222,6 +3250,8 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)
|
@@ -3034,6 +3061,8 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)
|
||||||
|
|
||||||
blockdev_mirror_common(arg->has_job_id ? arg->job_id : NULL, bs, target_bs,
|
blockdev_mirror_common(arg->job_id, bs, target_bs,
|
||||||
arg->has_replaces, arg->replaces, arg->sync,
|
arg->replaces, arg->sync,
|
||||||
+ arg->has_bitmap, arg->bitmap,
|
+ arg->bitmap,
|
||||||
+ arg->has_bitmap_mode, arg->bitmap_mode,
|
+ arg->has_bitmap_mode, arg->bitmap_mode,
|
||||||
backing_mode, zero_target,
|
backing_mode, zero_target,
|
||||||
arg->has_speed, arg->speed,
|
arg->has_speed, arg->speed,
|
||||||
arg->has_granularity, arg->granularity,
|
arg->has_granularity, arg->granularity,
|
||||||
@@ -3243,6 +3273,8 @@ void qmp_blockdev_mirror(bool has_job_id, const char *job_id,
|
@@ -3053,6 +3082,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
||||||
const char *device, const char *target,
|
const char *device, const char *target,
|
||||||
bool has_replaces, const char *replaces,
|
const char *replaces,
|
||||||
MirrorSyncMode sync,
|
MirrorSyncMode sync,
|
||||||
+ bool has_bitmap, const char *bitmap,
|
+ const char *bitmap,
|
||||||
+ bool has_bitmap_mode, BitmapSyncMode bitmap_mode,
|
+ bool has_bitmap_mode, BitmapSyncMode bitmap_mode,
|
||||||
bool has_speed, int64_t speed,
|
bool has_speed, int64_t speed,
|
||||||
bool has_granularity, uint32_t granularity,
|
bool has_granularity, uint32_t granularity,
|
||||||
bool has_buf_size, int64_t buf_size,
|
bool has_buf_size, int64_t buf_size,
|
||||||
@@ -3292,7 +3324,8 @@ void qmp_blockdev_mirror(bool has_job_id, const char *job_id,
|
@@ -3093,7 +3124,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
||||||
}
|
}
|
||||||
|
|
||||||
blockdev_mirror_common(has_job_id ? job_id : NULL, bs, target_bs,
|
blockdev_mirror_common(job_id, bs, target_bs,
|
||||||
- has_replaces, replaces, sync, backing_mode,
|
- replaces, sync, backing_mode,
|
||||||
+ has_replaces, replaces, sync, has_bitmap,
|
+ replaces, sync,
|
||||||
+ bitmap, has_bitmap_mode, bitmap_mode, backing_mode,
|
+ bitmap, has_bitmap_mode, bitmap_mode, backing_mode,
|
||||||
zero_target, has_speed, speed,
|
zero_target, has_speed, speed,
|
||||||
has_granularity, granularity,
|
has_granularity, granularity,
|
||||||
has_buf_size, buf_size,
|
has_buf_size, buf_size,
|
||||||
diff --git a/include/block/block_int.h b/include/block/block_int.h
|
diff --git a/include/block/block_int-global-state.h b/include/block/block_int-global-state.h
|
||||||
index c31cbd034a..11442893d0 100644
|
index eb2d92a226..f0c642b194 100644
|
||||||
--- a/include/block/block_int.h
|
--- a/include/block/block_int-global-state.h
|
||||||
+++ b/include/block/block_int.h
|
+++ b/include/block/block_int-global-state.h
|
||||||
@@ -1254,7 +1254,9 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
@@ -158,7 +158,9 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
||||||
BlockDriverState *target, const char *replaces,
|
BlockDriverState *target, const char *replaces,
|
||||||
int creation_flags, int64_t speed,
|
int creation_flags, int64_t speed,
|
||||||
uint32_t granularity, int64_t buf_size,
|
uint32_t granularity, int64_t buf_size,
|
||||||
|
@ -357,31 +364,26 @@ index c31cbd034a..11442893d0 100644
|
||||||
BlockdevOnError on_source_error,
|
BlockdevOnError on_source_error,
|
||||||
BlockdevOnError on_target_error,
|
BlockdevOnError on_target_error,
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 675d8265eb..6356a63695 100644
|
index b179d65520..905da8be72 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -1938,10 +1938,19 @@
|
@@ -2174,6 +2174,15 @@
|
||||||
# (all the disk, only the sectors allocated in the topmost image, or
|
# destination (all the disk, only the sectors allocated in the
|
||||||
# only new I/O).
|
# topmost image, or only new I/O).
|
||||||
#
|
#
|
||||||
+# @bitmap: The name of a bitmap to use for sync=bitmap mode. This argument must
|
+# @bitmap: The name of a bitmap to use for sync=bitmap mode. This
|
||||||
+# be present for bitmap mode and absent otherwise. The bitmap's
|
+# argument must be present for bitmap mode and absent otherwise.
|
||||||
+# granularity is used instead of @granularity (since 4.1).
|
+# The bitmap's granularity is used instead of @granularity (Since
|
||||||
|
+# 4.1).
|
||||||
+#
|
+#
|
||||||
+# @bitmap-mode: Specifies the type of data the bitmap should contain after
|
+# @bitmap-mode: Specifies the type of data the bitmap should contain
|
||||||
+# the operation concludes. Must be present if sync is "bitmap".
|
+# after the operation concludes. Must be present if sync is
|
||||||
+# Must NOT be present otherwise. (Since 4.1)
|
+# "bitmap". Must NOT be present otherwise. (Since 4.1)
|
||||||
+#
|
+#
|
||||||
# @granularity: granularity of the dirty bitmap, default is 64K
|
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
||||||
# if the image format doesn't have clusters, 4K if the clusters
|
# image format doesn't have clusters, 4K if the clusters are
|
||||||
# are smaller than that, else the cluster size. Must be a
|
# smaller than that, else the cluster size. Must be a power of 2
|
||||||
-# power of 2 between 512 and 64M (since 1.4).
|
@@ -2216,7 +2225,9 @@
|
||||||
+# power of 2 between 512 and 64M. Must not be specified if
|
|
||||||
+# @bitmap is present (since 1.4).
|
|
||||||
#
|
|
||||||
# @buf-size: maximum amount of data in flight from source to
|
|
||||||
# target (since 1.4).
|
|
||||||
@@ -1979,7 +1988,9 @@
|
|
||||||
{ 'struct': 'DriveMirror',
|
{ 'struct': 'DriveMirror',
|
||||||
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
||||||
'*format': 'str', '*node-name': 'str', '*replaces': 'str',
|
'*format': 'str', '*node-name': 'str', '*replaces': 'str',
|
||||||
|
@ -392,28 +394,23 @@ index 675d8265eb..6356a63695 100644
|
||||||
'*speed': 'int', '*granularity': 'uint32',
|
'*speed': 'int', '*granularity': 'uint32',
|
||||||
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
||||||
'*on-target-error': 'BlockdevOnError',
|
'*on-target-error': 'BlockdevOnError',
|
||||||
@@ -2247,10 +2258,19 @@
|
@@ -2496,6 +2507,15 @@
|
||||||
# (all the disk, only the sectors allocated in the topmost image, or
|
# destination (all the disk, only the sectors allocated in the
|
||||||
# only new I/O).
|
# topmost image, or only new I/O).
|
||||||
#
|
#
|
||||||
+# @bitmap: The name of a bitmap to use for sync=bitmap mode. This argument must
|
+# @bitmap: The name of a bitmap to use for sync=bitmap mode. This
|
||||||
+# be present for bitmap mode and absent otherwise. The bitmap's
|
+# argument must be present for bitmap mode and absent otherwise.
|
||||||
+# granularity is used instead of @granularity (since 4.1).
|
+# The bitmap's granularity is used instead of @granularity (since
|
||||||
|
+# 4.1).
|
||||||
+#
|
+#
|
||||||
+# @bitmap-mode: Specifies the type of data the bitmap should contain after
|
+# @bitmap-mode: Specifies the type of data the bitmap should contain
|
||||||
+# the operation concludes. Must be present if sync is "bitmap".
|
+# after the operation concludes. Must be present if sync is
|
||||||
+# Must NOT be present otherwise. (Since 4.1)
|
+# "bitmap". Must NOT be present otherwise. (Since 4.1)
|
||||||
+#
|
+#
|
||||||
# @granularity: granularity of the dirty bitmap, default is 64K
|
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
||||||
# if the image format doesn't have clusters, 4K if the clusters
|
# image format doesn't have clusters, 4K if the clusters are
|
||||||
# are smaller than that, else the cluster size. Must be a
|
# smaller than that, else the cluster size. Must be a power of 2
|
||||||
-# power of 2 between 512 and 64M
|
@@ -2544,7 +2564,8 @@
|
||||||
+# power of 2 between 512 and 64M . Must not be specified if
|
|
||||||
+# @bitmap is present.
|
|
||||||
#
|
|
||||||
# @buf-size: maximum amount of data in flight from source to
|
|
||||||
# target
|
|
||||||
@@ -2299,7 +2319,8 @@
|
|
||||||
{ 'command': 'blockdev-mirror',
|
{ 'command': 'blockdev-mirror',
|
||||||
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
||||||
'*replaces': 'str',
|
'*replaces': 'str',
|
||||||
|
@ -424,10 +421,10 @@ index 675d8265eb..6356a63695 100644
|
||||||
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
||||||
'*on-target-error': 'BlockdevOnError',
|
'*on-target-error': 'BlockdevOnError',
|
||||||
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
|
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
|
||||||
index c39e70b2f5..470ef79ae0 100644
|
index 3766d5de6b..afa44cbd34 100644
|
||||||
--- a/tests/unit/test-block-iothread.c
|
--- a/tests/unit/test-block-iothread.c
|
||||||
+++ b/tests/unit/test-block-iothread.c
|
+++ b/tests/unit/test-block-iothread.c
|
||||||
@@ -617,8 +617,8 @@ static void test_propagate_mirror(void)
|
@@ -755,8 +755,8 @@ static void test_propagate_mirror(void)
|
||||||
|
|
||||||
/* Start a mirror job */
|
/* Start a mirror job */
|
||||||
mirror_start("job0", src, target, NULL, JOB_DEFAULT, 0, 0, 0,
|
mirror_start("job0", src, target, NULL, JOB_DEFAULT, 0, 0, 0,
|
||||||
|
@ -437,4 +434,4 @@ index c39e70b2f5..470ef79ae0 100644
|
||||||
+ false, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
|
+ false, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
|
||||||
false, "filter_node", MIRROR_COPY_MODE_BACKGROUND,
|
false, "filter_node", MIRROR_COPY_MODE_BACKGROUND,
|
||||||
&error_abort);
|
&error_abort);
|
||||||
job = job_get("job0");
|
|
||||||
|
|
|
@ -24,10 +24,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 18 insertions(+), 6 deletions(-)
|
1 file changed, 18 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index 0821214138..c688726fae 100644
|
index 0c5c72df2e..37fee3fa25 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -674,8 +674,6 @@ static int mirror_exit_common(Job *job)
|
@@ -693,8 +693,6 @@ static int mirror_exit_common(Job *job)
|
||||||
bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs);
|
bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -36,9 +36,9 @@ index 0821214138..c688726fae 100644
|
||||||
/* Make sure that the source BDS doesn't go away during bdrv_replace_node,
|
/* Make sure that the source BDS doesn't go away during bdrv_replace_node,
|
||||||
* before we can call bdrv_drained_end */
|
* before we can call bdrv_drained_end */
|
||||||
bdrv_ref(src);
|
bdrv_ref(src);
|
||||||
@@ -783,6 +781,18 @@ static int mirror_exit_common(Job *job)
|
@@ -800,6 +798,18 @@ static int mirror_exit_common(Job *job)
|
||||||
blk_set_perm(bjob->blk, 0, BLK_PERM_ALL, &error_abort);
|
bdrv_drained_end(target_bs);
|
||||||
blk_insert_bs(bjob->blk, mirror_top_bs, &error_abort);
|
bdrv_unref(target_bs);
|
||||||
|
|
||||||
+ if (s->sync_bitmap) {
|
+ if (s->sync_bitmap) {
|
||||||
+ if (s->bitmap_mode == BITMAP_SYNC_MODE_ALWAYS ||
|
+ if (s->bitmap_mode == BITMAP_SYNC_MODE_ALWAYS ||
|
||||||
|
@ -55,7 +55,7 @@ index 0821214138..c688726fae 100644
|
||||||
bs_opaque->job = NULL;
|
bs_opaque->job = NULL;
|
||||||
|
|
||||||
bdrv_drained_end(src);
|
bdrv_drained_end(src);
|
||||||
@@ -1635,10 +1645,6 @@ static BlockJob *mirror_start_job(
|
@@ -1757,10 +1767,6 @@ static BlockJob *mirror_start_job(
|
||||||
" sync mode",
|
" sync mode",
|
||||||
MirrorSyncMode_str(sync_mode));
|
MirrorSyncMode_str(sync_mode));
|
||||||
return NULL;
|
return NULL;
|
||||||
|
@ -66,7 +66,7 @@ index 0821214138..c688726fae 100644
|
||||||
}
|
}
|
||||||
} else if (bitmap) {
|
} else if (bitmap) {
|
||||||
error_setg(errp,
|
error_setg(errp,
|
||||||
@@ -1655,6 +1661,12 @@ static BlockJob *mirror_start_job(
|
@@ -1777,6 +1783,12 @@ static BlockJob *mirror_start_job(
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
||||||
|
|
|
@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 3 insertions(+)
|
1 file changed, 3 insertions(+)
|
||||||
|
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 03e99264dc..9e14feec87 100644
|
index f3e508a6a7..37b8437f3e 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -3056,6 +3056,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2873,6 +2873,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
|
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
@ -28,4 +28,4 @@ index 03e99264dc..9e14feec87 100644
|
||||||
+ return;
|
+ return;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!has_replaces) {
|
if (!replaces) {
|
||||||
|
|
|
@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 4 insertions(+), 7 deletions(-)
|
1 file changed, 4 insertions(+), 7 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index c688726fae..a7f829f766 100644
|
index 37fee3fa25..6b3cce1007 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -787,8 +787,8 @@ static int mirror_exit_common(Job *job)
|
@@ -804,8 +804,8 @@ static int mirror_exit_common(Job *job)
|
||||||
job->ret == 0 && ret == 0)) {
|
job->ret == 0 && ret == 0)) {
|
||||||
/* Success; synchronize copy back to sync. */
|
/* Success; synchronize copy back to sync. */
|
||||||
bdrv_clear_dirty_bitmap(s->sync_bitmap, NULL);
|
bdrv_clear_dirty_bitmap(s->sync_bitmap, NULL);
|
||||||
|
@ -30,7 +30,7 @@ index c688726fae..a7f829f766 100644
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
||||||
@@ -1835,11 +1835,8 @@ static BlockJob *mirror_start_job(
|
@@ -1964,11 +1964,8 @@ static BlockJob *mirror_start_job(
|
||||||
}
|
}
|
||||||
|
|
||||||
if (s->sync_mode == MIRROR_SYNC_MODE_BITMAP) {
|
if (s->sync_mode == MIRROR_SYNC_MODE_BITMAP) {
|
||||||
|
@ -43,4 +43,4 @@ index c688726fae..a7f829f766 100644
|
||||||
+ NULL, true);
|
+ NULL, true);
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = block_job_add_bdrv(&s->common, "source", bs, 0,
|
bdrv_graph_wrlock();
|
||||||
|
|
|
@ -12,6 +12,8 @@ uniform w.r.t. backup block jobs.
|
||||||
|
|
||||||
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: rebase for 8.2.2]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/mirror.c | 28 +++------------
|
block/mirror.c | 28 +++------------
|
||||||
blockdev.c | 29 +++++++++++++++
|
blockdev.c | 29 +++++++++++++++
|
||||||
|
@ -19,12 +21,12 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
3 files changed, 70 insertions(+), 59 deletions(-)
|
3 files changed, 70 insertions(+), 59 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index a7f829f766..6a126d18c8 100644
|
index 6b3cce1007..2f1223852b 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -1635,31 +1635,13 @@ static BlockJob *mirror_start_job(
|
@@ -1757,31 +1757,13 @@ static BlockJob *mirror_start_job(
|
||||||
uint64_t target_perms, target_shared_perms;
|
|
||||||
int ret;
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
- if (sync_mode == MIRROR_SYNC_MODE_INCREMENTAL) {
|
- if (sync_mode == MIRROR_SYNC_MODE_INCREMENTAL) {
|
||||||
- error_setg(errp, "Sync mode '%s' not supported",
|
- error_setg(errp, "Sync mode '%s' not supported",
|
||||||
|
@ -60,17 +62,17 @@ index a7f829f766..6a126d18c8 100644
|
||||||
|
|
||||||
if (bitmap_mode != BITMAP_SYNC_MODE_NEVER) {
|
if (bitmap_mode != BITMAP_SYNC_MODE_NEVER) {
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 9e14feec87..b6f797b41f 100644
|
index 37b8437f3e..ed8198f351 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -3035,7 +3035,36 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2852,7 +2852,36 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
sync = MIRROR_SYNC_MODE_FULL;
|
sync = MIRROR_SYNC_MODE_FULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
+ if ((sync == MIRROR_SYNC_MODE_BITMAP) ||
|
+ if ((sync == MIRROR_SYNC_MODE_BITMAP) ||
|
||||||
+ (sync == MIRROR_SYNC_MODE_INCREMENTAL)) {
|
+ (sync == MIRROR_SYNC_MODE_INCREMENTAL)) {
|
||||||
+ /* done before desugaring 'incremental' to print the right message */
|
+ /* done before desugaring 'incremental' to print the right message */
|
||||||
+ if (!has_bitmap) {
|
+ if (!bitmap_name) {
|
||||||
+ error_setg(errp, "Must provide a valid bitmap name for "
|
+ error_setg(errp, "Must provide a valid bitmap name for "
|
||||||
+ "'%s' sync mode", MirrorSyncMode_str(sync));
|
+ "'%s' sync mode", MirrorSyncMode_str(sync));
|
||||||
+ return;
|
+ return;
|
||||||
|
@ -91,7 +93,7 @@ index 9e14feec87..b6f797b41f 100644
|
||||||
+ bitmap_mode = BITMAP_SYNC_MODE_ON_SUCCESS;
|
+ bitmap_mode = BITMAP_SYNC_MODE_ON_SUCCESS;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
if (has_bitmap) {
|
if (bitmap_name) {
|
||||||
+ if (sync != MIRROR_SYNC_MODE_BITMAP) {
|
+ if (sync != MIRROR_SYNC_MODE_BITMAP) {
|
||||||
+ error_setg(errp, "Sync mode '%s' not supported with bitmap.",
|
+ error_setg(errp, "Sync mode '%s' not supported with bitmap.",
|
||||||
+ MirrorSyncMode_str(sync));
|
+ MirrorSyncMode_str(sync));
|
||||||
|
|
|
@ -48,7 +48,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
6 files changed, 59 insertions(+), 5 deletions(-)
|
6 files changed, 59 insertions(+), 5 deletions(-)
|
||||||
|
|
||||||
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
|
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
|
||||||
index 1a8a369b50..2c8a558c67 100644
|
index 965f5d5450..e04bd059b6 100644
|
||||||
--- a/include/monitor/monitor.h
|
--- a/include/monitor/monitor.h
|
||||||
+++ b/include/monitor/monitor.h
|
+++ b/include/monitor/monitor.h
|
||||||
@@ -16,6 +16,7 @@ extern QemuOptsList qemu_mon_opts;
|
@@ -16,6 +16,7 @@ extern QemuOptsList qemu_mon_opts;
|
||||||
|
@ -60,10 +60,10 @@ index 1a8a369b50..2c8a558c67 100644
|
||||||
void monitor_init_globals(void);
|
void monitor_init_globals(void);
|
||||||
void monitor_init_globals_core(void);
|
void monitor_init_globals_core(void);
|
||||||
diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h
|
diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h
|
||||||
index 9c3a09cb01..a92be8c3f7 100644
|
index 252de85681..8db28f9272 100644
|
||||||
--- a/monitor/monitor-internal.h
|
--- a/monitor/monitor-internal.h
|
||||||
+++ b/monitor/monitor-internal.h
|
+++ b/monitor/monitor-internal.h
|
||||||
@@ -144,6 +144,13 @@ typedef struct {
|
@@ -151,6 +151,13 @@ typedef struct {
|
||||||
QemuMutex qmp_queue_lock;
|
QemuMutex qmp_queue_lock;
|
||||||
/* Input queue that holds all the parsed QMP requests */
|
/* Input queue that holds all the parsed QMP requests */
|
||||||
GQueue *qmp_requests;
|
GQueue *qmp_requests;
|
||||||
|
@ -78,10 +78,10 @@ index 9c3a09cb01..a92be8c3f7 100644
|
||||||
|
|
||||||
/**
|
/**
|
||||||
diff --git a/monitor/monitor.c b/monitor/monitor.c
|
diff --git a/monitor/monitor.c b/monitor/monitor.c
|
||||||
index 46a171bca6..5ccdd2424b 100644
|
index 01ede1babd..5681bca346 100644
|
||||||
--- a/monitor/monitor.c
|
--- a/monitor/monitor.c
|
||||||
+++ b/monitor/monitor.c
|
+++ b/monitor/monitor.c
|
||||||
@@ -135,6 +135,21 @@ bool monitor_cur_is_qmp(void)
|
@@ -117,6 +117,21 @@ bool monitor_cur_is_qmp(void)
|
||||||
return cur_mon && monitor_is_qmp(cur_mon);
|
return cur_mon && monitor_is_qmp(cur_mon);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -104,10 +104,10 @@ index 46a171bca6..5ccdd2424b 100644
|
||||||
* Is @mon is using readline?
|
* Is @mon is using readline?
|
||||||
* Note: not all HMP monitors use readline, e.g., gdbserver has a
|
* Note: not all HMP monitors use readline, e.g., gdbserver has a
|
||||||
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
||||||
index 092c527b6f..6b8cfcf6d8 100644
|
index a239945e8d..589c9524f8 100644
|
||||||
--- a/monitor/qmp.c
|
--- a/monitor/qmp.c
|
||||||
+++ b/monitor/qmp.c
|
+++ b/monitor/qmp.c
|
||||||
@@ -141,6 +141,8 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
@@ -165,6 +165,8 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
||||||
QDict *rsp;
|
QDict *rsp;
|
||||||
QDict *error;
|
QDict *error;
|
||||||
|
|
||||||
|
@ -116,7 +116,7 @@ index 092c527b6f..6b8cfcf6d8 100644
|
||||||
rsp = qmp_dispatch(mon->commands, req, qmp_oob_enabled(mon),
|
rsp = qmp_dispatch(mon->commands, req, qmp_oob_enabled(mon),
|
||||||
&mon->common);
|
&mon->common);
|
||||||
|
|
||||||
@@ -156,7 +158,17 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
@@ -180,7 +182,17 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -135,7 +135,7 @@ index 092c527b6f..6b8cfcf6d8 100644
|
||||||
qobject_unref(rsp);
|
qobject_unref(rsp);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -444,6 +456,7 @@ static void monitor_qmp_event(void *opaque, QEMUChrEvent event)
|
@@ -461,6 +473,7 @@ static void monitor_qmp_event(void *opaque, QEMUChrEvent event)
|
||||||
|
|
||||||
switch (event) {
|
switch (event) {
|
||||||
case CHR_EVENT_OPENED:
|
case CHR_EVENT_OPENED:
|
||||||
|
@ -144,10 +144,10 @@ index 092c527b6f..6b8cfcf6d8 100644
|
||||||
monitor_qmp_caps_reset(mon);
|
monitor_qmp_caps_reset(mon);
|
||||||
data = qmp_greeting(mon);
|
data = qmp_greeting(mon);
|
||||||
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
|
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
|
||||||
index 59600210ce..95602446eb 100644
|
index 176b549473..790bb7d1da 100644
|
||||||
--- a/qapi/qmp-dispatch.c
|
--- a/qapi/qmp-dispatch.c
|
||||||
+++ b/qapi/qmp-dispatch.c
|
+++ b/qapi/qmp-dispatch.c
|
||||||
@@ -120,16 +120,28 @@ typedef struct QmpDispatchBH {
|
@@ -117,16 +117,28 @@ typedef struct QmpDispatchBH {
|
||||||
QObject **ret;
|
QObject **ret;
|
||||||
Error **errp;
|
Error **errp;
|
||||||
Coroutine *co;
|
Coroutine *co;
|
||||||
|
@ -180,19 +180,19 @@ index 59600210ce..95602446eb 100644
|
||||||
aio_co_wake(data->co);
|
aio_co_wake(data->co);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -243,6 +255,7 @@ QDict *qmp_dispatch(const QmpCommandList *cmds, QObject *request,
|
@@ -253,6 +265,7 @@ QDict *coroutine_mixed_fn qmp_dispatch(const QmpCommandList *cmds, QObject *requ
|
||||||
.ret = &ret,
|
.ret = &ret,
|
||||||
.errp = &err,
|
.errp = &err,
|
||||||
.co = qemu_coroutine_self(),
|
.co = qemu_coroutine_self(),
|
||||||
+ .conn_nr = monitor_get_connection_nr(cur_mon),
|
+ .conn_nr = monitor_get_connection_nr(cur_mon),
|
||||||
};
|
};
|
||||||
aio_bh_schedule_oneshot(qemu_get_aio_context(), do_qmp_dispatch_bh,
|
aio_bh_schedule_oneshot(iohandler_get_aio_context(), do_qmp_dispatch_bh,
|
||||||
&data);
|
&data);
|
||||||
diff --git a/stubs/monitor-core.c b/stubs/monitor-core.c
|
diff --git a/stubs/monitor-core.c b/stubs/monitor-core.c
|
||||||
index d058a2a00d..3290b58120 100644
|
index afa477aae6..d3ff124bf3 100644
|
||||||
--- a/stubs/monitor-core.c
|
--- a/stubs/monitor-core.c
|
||||||
+++ b/stubs/monitor-core.c
|
+++ b/stubs/monitor-core.c
|
||||||
@@ -13,6 +13,11 @@ Monitor *monitor_set_cur(Coroutine *co, Monitor *mon)
|
@@ -12,6 +12,11 @@ Monitor *monitor_set_cur(Coroutine *co, Monitor *mon)
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -1,55 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 1 Sep 2021 16:51:04 +0200
|
|
||||||
Subject: [PATCH] monitor/hmp: add support for flag argument with value
|
|
||||||
|
|
||||||
Adds support for the "-xS" parameter type, where "-x" denotes a flag
|
|
||||||
name and the "S" suffix indicates that this flag is supposed to take an
|
|
||||||
arbitrary string parameter.
|
|
||||||
|
|
||||||
These parameters are always optional, the entry in the qdict will be
|
|
||||||
omitted if the flag is not given.
|
|
||||||
|
|
||||||
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
monitor/hmp.c | 17 ++++++++++++++++-
|
|
||||||
1 file changed, 16 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/monitor/hmp.c b/monitor/hmp.c
|
|
||||||
index d50c3124e1..a32dce7a35 100644
|
|
||||||
--- a/monitor/hmp.c
|
|
||||||
+++ b/monitor/hmp.c
|
|
||||||
@@ -980,6 +980,7 @@ static QDict *monitor_parse_arguments(Monitor *mon,
|
|
||||||
{
|
|
||||||
const char *tmp = p;
|
|
||||||
int skip_key = 0;
|
|
||||||
+ int ret;
|
|
||||||
/* option */
|
|
||||||
|
|
||||||
c = *typestr++;
|
|
||||||
@@ -1002,8 +1003,22 @@ static QDict *monitor_parse_arguments(Monitor *mon,
|
|
||||||
}
|
|
||||||
if (skip_key) {
|
|
||||||
p = tmp;
|
|
||||||
+ } else if (*typestr == 'S') {
|
|
||||||
+ /* has option with string value */
|
|
||||||
+ typestr++;
|
|
||||||
+ tmp = p++;
|
|
||||||
+ while (qemu_isspace(*p)) {
|
|
||||||
+ p++;
|
|
||||||
+ }
|
|
||||||
+ ret = get_str(buf, sizeof(buf), &p);
|
|
||||||
+ if (ret < 0) {
|
|
||||||
+ monitor_printf(mon, "%s: value expected for -%c\n",
|
|
||||||
+ cmd->name, *tmp);
|
|
||||||
+ goto fail;
|
|
||||||
+ }
|
|
||||||
+ qdict_put_str(qdict, key, buf);
|
|
||||||
} else {
|
|
||||||
- /* has option */
|
|
||||||
+ /* has boolean option */
|
|
||||||
p++;
|
|
||||||
qdict_put_bool(qdict, key, true);
|
|
||||||
}
|
|
69
debian/patches/extra/0002-scsi-megasas-Internal-cdbs-have-16-byte-length.patch
vendored
Normal file
69
debian/patches/extra/0002-scsi-megasas-Internal-cdbs-have-16-byte-length.patch
vendored
Normal file
|
@ -0,0 +1,69 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Guenter Roeck <linux@roeck-us.net>
|
||||||
|
Date: Tue, 28 Feb 2023 09:11:29 -0800
|
||||||
|
Subject: [PATCH] scsi: megasas: Internal cdbs have 16-byte length
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Host drivers do not necessarily set cdb_len in megasas io commands.
|
||||||
|
With commits 6d1511cea0 ("scsi: Reject commands if the CDB length
|
||||||
|
exceeds buf_len") and fe9d8927e2 ("scsi: Add buf_len parameter to
|
||||||
|
scsi_req_new()"), this results in failures to boot Linux from affected
|
||||||
|
SCSI drives because cdb_len is set to 0 by the host driver.
|
||||||
|
Set the cdb length to its actual size to solve the problem.
|
||||||
|
|
||||||
|
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
(picked-up from https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg08653.html)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/megasas.c | 14 ++------------
|
||||||
|
1 file changed, 2 insertions(+), 12 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
|
||||||
|
index 2d0c607177..97e51733af 100644
|
||||||
|
--- a/hw/scsi/megasas.c
|
||||||
|
+++ b/hw/scsi/megasas.c
|
||||||
|
@@ -1781,7 +1781,7 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
uint8_t cdb[16];
|
||||||
|
int len;
|
||||||
|
struct SCSIDevice *sdev = NULL;
|
||||||
|
- int target_id, lun_id, cdb_len;
|
||||||
|
+ int target_id, lun_id;
|
||||||
|
|
||||||
|
lba_count = le32_to_cpu(cmd->frame->io.header.data_len);
|
||||||
|
lba_start_lo = le32_to_cpu(cmd->frame->io.lba_lo);
|
||||||
|
@@ -1790,7 +1790,6 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
|
||||||
|
target_id = cmd->frame->header.target_id;
|
||||||
|
lun_id = cmd->frame->header.lun_id;
|
||||||
|
- cdb_len = cmd->frame->header.cdb_len;
|
||||||
|
|
||||||
|
if (target_id < MFI_MAX_LD && lun_id == 0) {
|
||||||
|
sdev = scsi_device_find(&s->bus, 0, target_id, lun_id);
|
||||||
|
@@ -1805,15 +1804,6 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
return MFI_STAT_DEVICE_NOT_FOUND;
|
||||||
|
}
|
||||||
|
|
||||||
|
- if (cdb_len > 16) {
|
||||||
|
- trace_megasas_scsi_invalid_cdb_len(
|
||||||
|
- mfi_frame_desc(frame_cmd), 1, target_id, lun_id, cdb_len);
|
||||||
|
- megasas_write_sense(cmd, SENSE_CODE(INVALID_OPCODE));
|
||||||
|
- cmd->frame->header.scsi_status = CHECK_CONDITION;
|
||||||
|
- s->event_count++;
|
||||||
|
- return MFI_STAT_SCSI_DONE_WITH_ERROR;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
cmd->iov_size = lba_count * sdev->blocksize;
|
||||||
|
if (megasas_map_sgl(s, cmd, &cmd->frame->io.sgl)) {
|
||||||
|
megasas_write_sense(cmd, SENSE_CODE(TARGET_FAILURE));
|
||||||
|
@@ -1824,7 +1814,7 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
|
||||||
|
megasas_encode_lba(cdb, lba_start, lba_count, is_write);
|
||||||
|
cmd->req = scsi_req_new(sdev, cmd->index,
|
||||||
|
- lun_id, cdb, cdb_len, cmd);
|
||||||
|
+ lun_id, cdb, sizeof(cdb), cmd);
|
||||||
|
if (!cmd->req) {
|
||||||
|
trace_megasas_scsi_req_alloc_failed(
|
||||||
|
mfi_frame_desc(frame_cmd), target_id, lun_id);
|
100
debian/patches/extra/0003-ide-avoid-potential-deadlock-when-draining-during-tr.patch
vendored
Normal file
100
debian/patches/extra/0003-ide-avoid-potential-deadlock-when-draining-during-tr.patch
vendored
Normal file
|
@ -0,0 +1,100 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Tue, 7 Mar 2023 15:03:02 +0100
|
||||||
|
Subject: [PATCH] ide: avoid potential deadlock when draining during trim
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
The deadlock can happen as follows:
|
||||||
|
1. ide_issue_trim is called, and increments the in_flight counter.
|
||||||
|
2. ide_issue_trim_cb calls blk_aio_pdiscard.
|
||||||
|
3. Somebody else starts draining (e.g. backup to insert the cbw node).
|
||||||
|
4. ide_issue_trim_cb is called as the completion callback for
|
||||||
|
blk_aio_pdiscard.
|
||||||
|
5. ide_issue_trim_cb issues yet another blk_aio_pdiscard request.
|
||||||
|
6. The request is added to the wait queue via blk_wait_while_drained,
|
||||||
|
because draining has been started.
|
||||||
|
7. Nobody ever decrements the in_flight counter and draining can't
|
||||||
|
finish. This would be done by ide_trim_bh_cb, which is called after
|
||||||
|
ide_issue_trim_cb has issued its last request, but
|
||||||
|
ide_issue_trim_cb is not called anymore, because it's the
|
||||||
|
completion callback of blk_aio_pdiscard, which waits on draining.
|
||||||
|
|
||||||
|
Quoting Hanna Czenczek:
|
||||||
|
> The point of 7e5cdb345f was that we need any in-flight count to
|
||||||
|
> accompany a set s->bus->dma->aiocb. While blk_aio_pdiscard() is
|
||||||
|
> happening, we don’t necessarily need another count. But we do need
|
||||||
|
> it while there is no blk_aio_pdiscard().
|
||||||
|
> ide_issue_trim_cb() returns in two cases (and, recursively through
|
||||||
|
> its callers, leaves s->bus->dma->aiocb set):
|
||||||
|
> 1. After calling blk_aio_pdiscard(), which will keep an in-flight
|
||||||
|
> count,
|
||||||
|
> 2. After calling replay_bh_schedule_event() (i.e.
|
||||||
|
> qemu_bh_schedule()), which does not keep an in-flight count.
|
||||||
|
|
||||||
|
Thus, even after moving the blk_inc_in_flight to above the
|
||||||
|
replay_bh_schedule_event call, the invariant "ide_issue_trim_cb
|
||||||
|
returns with an accompanying in-flight count" is still satisfied.
|
||||||
|
|
||||||
|
However, the issue 7e5cdb345f fixed for canceling resurfaces, because
|
||||||
|
ide_cancel_dma_sync assumes that it just needs to drain once. But now
|
||||||
|
the in_flight count is not consistently > 0 during the trim operation.
|
||||||
|
So, change it to drain until !s->bus->dma->aiocb, which means that the
|
||||||
|
operation finished (s->bus->dma->aiocb is cleared by ide_set_inactive
|
||||||
|
via the ide_dma_cb when the end of the transfer is reached).
|
||||||
|
|
||||||
|
Discussion here:
|
||||||
|
https://lists.nongnu.org/archive/html/qemu-devel/2023-03/msg02506.html
|
||||||
|
|
||||||
|
Fixes: 7e5cdb345f ("ide: Increment BB in-flight counter for TRIM BH")
|
||||||
|
Suggested-by: Hanna Czenczek <hreitz@redhat.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/ide/core.c | 12 ++++++------
|
||||||
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/ide/core.c b/hw/ide/core.c
|
||||||
|
index e8cb2dac92..3b21acf651 100644
|
||||||
|
--- a/hw/ide/core.c
|
||||||
|
+++ b/hw/ide/core.c
|
||||||
|
@@ -456,7 +456,7 @@ static void ide_trim_bh_cb(void *opaque)
|
||||||
|
iocb->bh = NULL;
|
||||||
|
qemu_aio_unref(iocb);
|
||||||
|
|
||||||
|
- /* Paired with an increment in ide_issue_trim() */
|
||||||
|
+ /* Paired with an increment in ide_issue_trim_cb() */
|
||||||
|
blk_dec_in_flight(blk);
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -516,6 +516,8 @@ static void ide_issue_trim_cb(void *opaque, int ret)
|
||||||
|
done:
|
||||||
|
iocb->aiocb = NULL;
|
||||||
|
if (iocb->bh) {
|
||||||
|
+ /* Paired with a decrement in ide_trim_bh_cb() */
|
||||||
|
+ blk_inc_in_flight(s->blk);
|
||||||
|
replay_bh_schedule_event(iocb->bh);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -528,9 +530,6 @@ BlockAIOCB *ide_issue_trim(
|
||||||
|
IDEDevice *dev = s->unit ? s->bus->slave : s->bus->master;
|
||||||
|
TrimAIOCB *iocb;
|
||||||
|
|
||||||
|
- /* Paired with a decrement in ide_trim_bh_cb() */
|
||||||
|
- blk_inc_in_flight(s->blk);
|
||||||
|
-
|
||||||
|
iocb = blk_aio_get(&trim_aiocb_info, s->blk, cb, cb_opaque);
|
||||||
|
iocb->s = s;
|
||||||
|
iocb->bh = qemu_bh_new_guarded(ide_trim_bh_cb, iocb,
|
||||||
|
@@ -754,8 +753,9 @@ void ide_cancel_dma_sync(IDEState *s)
|
||||||
|
*/
|
||||||
|
if (s->bus->dma->aiocb) {
|
||||||
|
trace_ide_cancel_dma_sync_remaining();
|
||||||
|
- blk_drain(s->blk);
|
||||||
|
- assert(s->bus->dma->aiocb == NULL);
|
||||||
|
+ while (s->bus->dma->aiocb) {
|
||||||
|
+ blk_drain(s->blk);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
|
@ -1,479 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 25 Aug 2021 11:14:13 +0200
|
|
||||||
Subject: [PATCH] monitor: refactor set/expire_password and allow VNC display
|
|
||||||
id
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
It is possible to specify more than one VNC server on the command line,
|
|
||||||
either with an explicit ID or the auto-generated ones à la "default",
|
|
||||||
"vnc2", "vnc3", ...
|
|
||||||
|
|
||||||
It is not possible to change the password on one of these extra VNC
|
|
||||||
displays though. Fix this by adding a "display" parameter to the
|
|
||||||
"set_password" and "expire_password" QMP and HMP commands.
|
|
||||||
|
|
||||||
For HMP, the display is specified using the "-d" value flag.
|
|
||||||
|
|
||||||
For QMP, the schema is updated to explicitly express the supported
|
|
||||||
variants of the commands with protocol-discriminated unions.
|
|
||||||
|
|
||||||
Suggested-by: Eric Blake <eblake@redhat.com>
|
|
||||||
Suggested-by: Markus Armbruster <armbru@redhat.com>
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
hmp-commands.hx | 29 ++++----
|
|
||||||
monitor/hmp-cmds.c | 57 +++++++++++++++-
|
|
||||||
monitor/qmp-cmds.c | 62 ++++++-----------
|
|
||||||
qapi/ui.json | 165 ++++++++++++++++++++++++++++++++++++++-------
|
|
||||||
4 files changed, 233 insertions(+), 80 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
|
||||||
index 8e45bce2cd..d78e4cfc47 100644
|
|
||||||
--- a/hmp-commands.hx
|
|
||||||
+++ b/hmp-commands.hx
|
|
||||||
@@ -1514,34 +1514,35 @@ ERST
|
|
||||||
|
|
||||||
{
|
|
||||||
.name = "set_password",
|
|
||||||
- .args_type = "protocol:s,password:s,connected:s?",
|
|
||||||
- .params = "protocol password action-if-connected",
|
|
||||||
+ .args_type = "protocol:s,password:s,display:-dS,connected:s?",
|
|
||||||
+ .params = "protocol password [-d display] [action-if-connected]",
|
|
||||||
.help = "set spice/vnc password",
|
|
||||||
.cmd = hmp_set_password,
|
|
||||||
},
|
|
||||||
|
|
||||||
SRST
|
|
||||||
-``set_password [ vnc | spice ] password [ action-if-connected ]``
|
|
||||||
- Change spice/vnc password. Use zero to make the password stay valid
|
|
||||||
- forever. *action-if-connected* specifies what should happen in
|
|
||||||
- case a connection is established: *fail* makes the password change
|
|
||||||
- fail. *disconnect* changes the password and disconnects the
|
|
||||||
- client. *keep* changes the password and keeps the connection up.
|
|
||||||
- *keep* is the default.
|
|
||||||
+``set_password [ vnc | spice ] password [ -d display ] [ action-if-connected ]``
|
|
||||||
+ Change spice/vnc password. *display* can be used with 'vnc' to specify
|
|
||||||
+ which display to set the password on. *action-if-connected* specifies
|
|
||||||
+ what should happen in case a connection is established: *fail* makes
|
|
||||||
+ the password change fail. *disconnect* changes the password and
|
|
||||||
+ disconnects the client. *keep* changes the password and keeps the
|
|
||||||
+ connection up. *keep* is the default.
|
|
||||||
ERST
|
|
||||||
|
|
||||||
{
|
|
||||||
.name = "expire_password",
|
|
||||||
- .args_type = "protocol:s,time:s",
|
|
||||||
- .params = "protocol time",
|
|
||||||
+ .args_type = "protocol:s,time:s,display:-dS",
|
|
||||||
+ .params = "protocol time [-d display]",
|
|
||||||
.help = "set spice/vnc password expire-time",
|
|
||||||
.cmd = hmp_expire_password,
|
|
||||||
},
|
|
||||||
|
|
||||||
SRST
|
|
||||||
-``expire_password [ vnc | spice ]`` *expire-time*
|
|
||||||
- Specify when a password for spice/vnc becomes
|
|
||||||
- invalid. *expire-time* accepts:
|
|
||||||
+``expire_password [ vnc | spice ] expire-time [ -d display ]``
|
|
||||||
+ Specify when a password for spice/vnc becomes invalid.
|
|
||||||
+ *display* behaves the same as in ``set_password``.
|
|
||||||
+ *expire-time* accepts:
|
|
||||||
|
|
||||||
``now``
|
|
||||||
Invalidate password instantly.
|
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
|
||||||
index a7e197a90b..f4ef58d257 100644
|
|
||||||
--- a/monitor/hmp-cmds.c
|
|
||||||
+++ b/monitor/hmp-cmds.c
|
|
||||||
@@ -1451,10 +1451,41 @@ void hmp_set_password(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
const char *protocol = qdict_get_str(qdict, "protocol");
|
|
||||||
const char *password = qdict_get_str(qdict, "password");
|
|
||||||
+ const char *display = qdict_get_try_str(qdict, "display");
|
|
||||||
const char *connected = qdict_get_try_str(qdict, "connected");
|
|
||||||
Error *err = NULL;
|
|
||||||
+ DisplayProtocol proto;
|
|
||||||
|
|
||||||
- qmp_set_password(protocol, password, !!connected, connected, &err);
|
|
||||||
+ SetPasswordOptions opts = {
|
|
||||||
+ .password = g_strdup(password),
|
|
||||||
+ .u.vnc.display = NULL,
|
|
||||||
+ };
|
|
||||||
+
|
|
||||||
+ proto = qapi_enum_parse(&DisplayProtocol_lookup, protocol,
|
|
||||||
+ DISPLAY_PROTOCOL_VNC, &err);
|
|
||||||
+ if (err) {
|
|
||||||
+ hmp_handle_error(mon, err);
|
|
||||||
+ return;
|
|
||||||
+ }
|
|
||||||
+ opts.protocol = proto;
|
|
||||||
+
|
|
||||||
+ if (proto == DISPLAY_PROTOCOL_VNC) {
|
|
||||||
+ opts.u.vnc.has_display = !!display;
|
|
||||||
+ opts.u.vnc.display = g_strdup(display);
|
|
||||||
+ } else if (proto == DISPLAY_PROTOCOL_SPICE) {
|
|
||||||
+ opts.u.spice.has_connected = !!connected;
|
|
||||||
+ opts.u.spice.connected =
|
|
||||||
+ qapi_enum_parse(&SetPasswordAction_lookup, connected,
|
|
||||||
+ SET_PASSWORD_ACTION_KEEP, &err);
|
|
||||||
+ if (err) {
|
|
||||||
+ hmp_handle_error(mon, err);
|
|
||||||
+ return;
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ qmp_set_password(&opts, &err);
|
|
||||||
+ g_free(opts.password);
|
|
||||||
+ g_free(opts.u.vnc.display);
|
|
||||||
hmp_handle_error(mon, err);
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -1462,9 +1493,31 @@ void hmp_expire_password(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
const char *protocol = qdict_get_str(qdict, "protocol");
|
|
||||||
const char *whenstr = qdict_get_str(qdict, "time");
|
|
||||||
+ const char *display = qdict_get_try_str(qdict, "display");
|
|
||||||
Error *err = NULL;
|
|
||||||
+ DisplayProtocol proto;
|
|
||||||
|
|
||||||
- qmp_expire_password(protocol, whenstr, &err);
|
|
||||||
+ ExpirePasswordOptions opts = {
|
|
||||||
+ .time = g_strdup(whenstr),
|
|
||||||
+ .u.vnc.display = NULL,
|
|
||||||
+ };
|
|
||||||
+
|
|
||||||
+ proto = qapi_enum_parse(&DisplayProtocol_lookup, protocol,
|
|
||||||
+ DISPLAY_PROTOCOL_VNC, &err);
|
|
||||||
+ if (err) {
|
|
||||||
+ hmp_handle_error(mon, err);
|
|
||||||
+ return;
|
|
||||||
+ }
|
|
||||||
+ opts.protocol = proto;
|
|
||||||
+
|
|
||||||
+ if (proto == DISPLAY_PROTOCOL_VNC) {
|
|
||||||
+ opts.u.vnc.has_display = !!display;
|
|
||||||
+ opts.u.vnc.display = g_strdup(display);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ qmp_expire_password(&opts, &err);
|
|
||||||
+ g_free(opts.time);
|
|
||||||
+ g_free(opts.u.vnc.display);
|
|
||||||
hmp_handle_error(mon, err);
|
|
||||||
}
|
|
||||||
|
|
||||||
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
|
|
||||||
index f7d64a6457..65882b5997 100644
|
|
||||||
--- a/monitor/qmp-cmds.c
|
|
||||||
+++ b/monitor/qmp-cmds.c
|
|
||||||
@@ -164,45 +164,30 @@ void qmp_system_wakeup(Error **errp)
|
|
||||||
qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER, errp);
|
|
||||||
}
|
|
||||||
|
|
||||||
-void qmp_set_password(const char *protocol, const char *password,
|
|
||||||
- bool has_connected, const char *connected, Error **errp)
|
|
||||||
+void qmp_set_password(SetPasswordOptions *opts, Error **errp)
|
|
||||||
{
|
|
||||||
- int disconnect_if_connected = 0;
|
|
||||||
- int fail_if_connected = 0;
|
|
||||||
- int rc;
|
|
||||||
+ bool disconnect_if_connected = false;
|
|
||||||
+ bool fail_if_connected = false;
|
|
||||||
+ int rc = 0;
|
|
||||||
|
|
||||||
- if (has_connected) {
|
|
||||||
- if (strcmp(connected, "fail") == 0) {
|
|
||||||
- fail_if_connected = 1;
|
|
||||||
- } else if (strcmp(connected, "disconnect") == 0) {
|
|
||||||
- disconnect_if_connected = 1;
|
|
||||||
- } else if (strcmp(connected, "keep") == 0) {
|
|
||||||
- /* nothing */
|
|
||||||
- } else {
|
|
||||||
- error_setg(errp, QERR_INVALID_PARAMETER, "connected");
|
|
||||||
- return;
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- if (strcmp(protocol, "spice") == 0) {
|
|
||||||
+ if (opts->protocol == DISPLAY_PROTOCOL_SPICE) {
|
|
||||||
if (!qemu_using_spice(errp)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
- rc = qemu_spice.set_passwd(password, fail_if_connected,
|
|
||||||
+ if (opts->u.spice.has_connected) {
|
|
||||||
+ fail_if_connected =
|
|
||||||
+ opts->u.spice.connected == SET_PASSWORD_ACTION_FAIL;
|
|
||||||
+ disconnect_if_connected =
|
|
||||||
+ opts->u.spice.connected == SET_PASSWORD_ACTION_DISCONNECT;
|
|
||||||
+ }
|
|
||||||
+ rc = qemu_spice.set_passwd(opts->password, fail_if_connected,
|
|
||||||
disconnect_if_connected);
|
|
||||||
- } else if (strcmp(protocol, "vnc") == 0) {
|
|
||||||
- if (fail_if_connected || disconnect_if_connected) {
|
|
||||||
- /* vnc supports "connected=keep" only */
|
|
||||||
- error_setg(errp, QERR_INVALID_PARAMETER, "connected");
|
|
||||||
- return;
|
|
||||||
- }
|
|
||||||
+ } else if (opts->protocol == DISPLAY_PROTOCOL_VNC) {
|
|
||||||
/* Note that setting an empty password will not disable login through
|
|
||||||
* this interface. */
|
|
||||||
- rc = vnc_display_password(NULL, password);
|
|
||||||
- } else {
|
|
||||||
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "protocol",
|
|
||||||
- "'vnc' or 'spice'");
|
|
||||||
- return;
|
|
||||||
+ rc = vnc_display_password(
|
|
||||||
+ opts->u.vnc.has_display ? opts->u.vnc.display : NULL,
|
|
||||||
+ opts->password);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (rc != 0) {
|
|
||||||
@@ -210,11 +195,11 @@ void qmp_set_password(const char *protocol, const char *password,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
-void qmp_expire_password(const char *protocol, const char *whenstr,
|
|
||||||
- Error **errp)
|
|
||||||
+void qmp_expire_password(ExpirePasswordOptions *opts, Error **errp)
|
|
||||||
{
|
|
||||||
time_t when;
|
|
||||||
int rc;
|
|
||||||
+ const char* whenstr = opts->time;
|
|
||||||
|
|
||||||
if (strcmp(whenstr, "now") == 0) {
|
|
||||||
when = 0;
|
|
||||||
@@ -226,17 +211,14 @@ void qmp_expire_password(const char *protocol, const char *whenstr,
|
|
||||||
when = strtoull(whenstr, NULL, 10);
|
|
||||||
}
|
|
||||||
|
|
||||||
- if (strcmp(protocol, "spice") == 0) {
|
|
||||||
+ if (opts->protocol == DISPLAY_PROTOCOL_SPICE) {
|
|
||||||
if (!qemu_using_spice(errp)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
rc = qemu_spice.set_pw_expire(when);
|
|
||||||
- } else if (strcmp(protocol, "vnc") == 0) {
|
|
||||||
- rc = vnc_display_pw_expire(NULL, when);
|
|
||||||
- } else {
|
|
||||||
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "protocol",
|
|
||||||
- "'vnc' or 'spice'");
|
|
||||||
- return;
|
|
||||||
+ } else if (opts->protocol == DISPLAY_PROTOCOL_VNC) {
|
|
||||||
+ rc = vnc_display_pw_expire(
|
|
||||||
+ opts->u.vnc.has_display ? opts->u.vnc.display : NULL, when);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (rc != 0) {
|
|
||||||
diff --git a/qapi/ui.json b/qapi/ui.json
|
|
||||||
index fd9677d48e..cba8665b73 100644
|
|
||||||
--- a/qapi/ui.json
|
|
||||||
+++ b/qapi/ui.json
|
|
||||||
@@ -9,22 +9,23 @@
|
|
||||||
{ 'include': 'common.json' }
|
|
||||||
{ 'include': 'sockets.json' }
|
|
||||||
|
|
||||||
+##
|
|
||||||
+# @DisplayProtocol:
|
|
||||||
+#
|
|
||||||
+# Display protocols which support changing password options.
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'enum': 'DisplayProtocol',
|
|
||||||
+ 'data': [ { 'name': 'vnc', 'if': 'defined(CONFIG_VNC)' },
|
|
||||||
+ { 'name': 'spice', 'if': 'defined(CONFIG_SPICE)' } ] }
|
|
||||||
+
|
|
||||||
##
|
|
||||||
# @set_password:
|
|
||||||
#
|
|
||||||
# Sets the password of a remote display session.
|
|
||||||
#
|
|
||||||
-# @protocol: - 'vnc' to modify the VNC server password
|
|
||||||
-# - 'spice' to modify the Spice server password
|
|
||||||
-#
|
|
||||||
-# @password: the new password
|
|
||||||
-#
|
|
||||||
-# @connected: how to handle existing clients when changing the
|
|
||||||
-# password. If nothing is specified, defaults to 'keep'
|
|
||||||
-# 'fail' to fail the command if clients are connected
|
|
||||||
-# 'disconnect' to disconnect existing clients
|
|
||||||
-# 'keep' to maintain existing clients
|
|
||||||
-#
|
|
||||||
# Returns: - Nothing on success
|
|
||||||
# - If Spice is not enabled, DeviceNotFound
|
|
||||||
#
|
|
||||||
@@ -37,16 +38,123 @@
|
|
||||||
# <- { "return": {} }
|
|
||||||
#
|
|
||||||
##
|
|
||||||
-{ 'command': 'set_password',
|
|
||||||
- 'data': {'protocol': 'str', 'password': 'str', '*connected': 'str'} }
|
|
||||||
+{ 'command': 'set_password', 'boxed': true, 'data': 'SetPasswordOptions' }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @SetPasswordOptions:
|
|
||||||
+#
|
|
||||||
+# Data required to set a new password on a display server protocol.
|
|
||||||
+#
|
|
||||||
+# @protocol: - 'vnc' to modify the VNC server password
|
|
||||||
+# - 'spice' to modify the Spice server password
|
|
||||||
+#
|
|
||||||
+# @password: the new password
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'union': 'SetPasswordOptions',
|
|
||||||
+ 'base': { 'protocol': 'DisplayProtocol',
|
|
||||||
+ 'password': 'str' },
|
|
||||||
+ 'discriminator': 'protocol',
|
|
||||||
+ 'data': { 'vnc': 'SetPasswordOptionsVnc',
|
|
||||||
+ 'spice': 'SetPasswordOptionsSpice' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @SetPasswordAction:
|
|
||||||
+#
|
|
||||||
+# An action to take on changing a password on a connection with active clients.
|
|
||||||
+#
|
|
||||||
+# @fail: fail the command if clients are connected
|
|
||||||
+#
|
|
||||||
+# @disconnect: disconnect existing clients
|
|
||||||
+#
|
|
||||||
+# @keep: maintain existing clients
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'enum': 'SetPasswordAction',
|
|
||||||
+ 'data': [ 'fail', 'disconnect', 'keep' ] }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @SetPasswordActionVnc:
|
|
||||||
+#
|
|
||||||
+# See @SetPasswordAction. VNC only supports the keep action. 'connection'
|
|
||||||
+# should just be omitted for VNC, this is kept for backwards compatibility.
|
|
||||||
+#
|
|
||||||
+# @keep: maintain existing clients
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'enum': 'SetPasswordActionVnc',
|
|
||||||
+ 'data': [ 'keep' ] }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @SetPasswordOptionsSpice:
|
|
||||||
+#
|
|
||||||
+# Options for set_password specific to the VNC procotol.
|
|
||||||
+#
|
|
||||||
+# @connected: How to handle existing clients when changing the
|
|
||||||
+# password. If nothing is specified, defaults to 'keep'.
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'struct': 'SetPasswordOptionsSpice',
|
|
||||||
+ 'data': { '*connected': 'SetPasswordAction' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @SetPasswordOptionsVnc:
|
|
||||||
+#
|
|
||||||
+# Options for set_password specific to the VNC procotol.
|
|
||||||
+#
|
|
||||||
+# @display: The id of the display where the password should be changed.
|
|
||||||
+# Defaults to the first.
|
|
||||||
+#
|
|
||||||
+# @connected: How to handle existing clients when changing the
|
|
||||||
+# password.
|
|
||||||
+#
|
|
||||||
+# Features:
|
|
||||||
+# @deprecated: For VNC, @connected will always be 'keep', parameter should be
|
|
||||||
+# omitted.
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'struct': 'SetPasswordOptionsVnc',
|
|
||||||
+ 'data': { '*display': 'str',
|
|
||||||
+ '*connected': { 'type': 'SetPasswordActionVnc',
|
|
||||||
+ 'features': ['deprecated'] } } }
|
|
||||||
|
|
||||||
##
|
|
||||||
# @expire_password:
|
|
||||||
#
|
|
||||||
# Expire the password of a remote display server.
|
|
||||||
#
|
|
||||||
-# @protocol: the name of the remote display protocol 'vnc' or 'spice'
|
|
||||||
+# Returns: - Nothing on success
|
|
||||||
+# - If @protocol is 'spice' and Spice is not active, DeviceNotFound
|
|
||||||
#
|
|
||||||
+# Since: 0.14
|
|
||||||
+#
|
|
||||||
+# Example:
|
|
||||||
+#
|
|
||||||
+# -> { "execute": "expire_password", "arguments": { "protocol": "vnc",
|
|
||||||
+# "time": "+60" } }
|
|
||||||
+# <- { "return": {} }
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'command': 'expire_password', 'boxed': true, 'data': 'ExpirePasswordOptions' }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @ExpirePasswordOptions:
|
|
||||||
+#
|
|
||||||
+# Data required to set password expiration on a display server protocol.
|
|
||||||
+#
|
|
||||||
+# @protocol: - 'vnc' to modify the VNC server expiration
|
|
||||||
+# - 'spice' to modify the Spice server expiration
|
|
||||||
+
|
|
||||||
# @time: when to expire the password.
|
|
||||||
#
|
|
||||||
# - 'now' to expire the password immediately
|
|
||||||
@@ -54,24 +162,33 @@
|
|
||||||
# - '+INT' where INT is the number of seconds from now (integer)
|
|
||||||
# - 'INT' where INT is the absolute time in seconds
|
|
||||||
#
|
|
||||||
-# Returns: - Nothing on success
|
|
||||||
-# - If @protocol is 'spice' and Spice is not active, DeviceNotFound
|
|
||||||
-#
|
|
||||||
-# Since: 0.14
|
|
||||||
-#
|
|
||||||
# Notes: Time is relative to the server and currently there is no way to
|
|
||||||
# coordinate server time with client time. It is not recommended to
|
|
||||||
# use the absolute time version of the @time parameter unless you're
|
|
||||||
# sure you are on the same machine as the QEMU instance.
|
|
||||||
#
|
|
||||||
-# Example:
|
|
||||||
+# Since: 6.2
|
|
||||||
#
|
|
||||||
-# -> { "execute": "expire_password", "arguments": { "protocol": "vnc",
|
|
||||||
-# "time": "+60" } }
|
|
||||||
-# <- { "return": {} }
|
|
||||||
+##
|
|
||||||
+{ 'union': 'ExpirePasswordOptions',
|
|
||||||
+ 'base': { 'protocol': 'DisplayProtocol',
|
|
||||||
+ 'time': 'str' },
|
|
||||||
+ 'discriminator': 'protocol',
|
|
||||||
+ 'data': { 'vnc': 'ExpirePasswordOptionsVnc' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @ExpirePasswordOptionsVnc:
|
|
||||||
+#
|
|
||||||
+# Options for expire_password specific to the VNC procotol.
|
|
||||||
+#
|
|
||||||
+# @display: The id of the display where the expiration should be changed.
|
|
||||||
+# Defaults to the first.
|
|
||||||
+#
|
|
||||||
+# Since: 6.2
|
|
||||||
#
|
|
||||||
##
|
|
||||||
-{ 'command': 'expire_password', 'data': {'protocol': 'str', 'time': 'str'} }
|
|
||||||
+{ 'struct': 'ExpirePasswordOptionsVnc',
|
|
||||||
+ 'data': { '*display': 'str' } }
|
|
||||||
|
|
||||||
##
|
|
||||||
# @screendump:
|
|
45
debian/patches/extra/0004-Revert-x86-acpi-workaround-Windows-not-handling-name.patch
vendored
Normal file
45
debian/patches/extra/0004-Revert-x86-acpi-workaround-Windows-not-handling-name.patch
vendored
Normal file
|
@ -0,0 +1,45 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Fri, 17 Nov 2023 11:18:06 +0100
|
||||||
|
Subject: [PATCH] Revert "x86: acpi: workaround Windows not handling name
|
||||||
|
references in Package properly"
|
||||||
|
|
||||||
|
This reverts commit 44d975ef340e2f21f236f9520c53e1b30d2213a4.
|
||||||
|
|
||||||
|
As reported in the community forum [0] and reproduced locally this
|
||||||
|
breaks VirtIO network adapters in (at least) the German ISO of Windows
|
||||||
|
Server 2022. The fix itself was for
|
||||||
|
|
||||||
|
> Issue is not fatal but as result acpi-index/"PCI Label ID" property
|
||||||
|
> is either not shown in device details page or shows incorrect value.
|
||||||
|
|
||||||
|
so revert and tolerate that as a stop-gap, rather than have the
|
||||||
|
devices not working at all.
|
||||||
|
|
||||||
|
[0]: https://forum.proxmox.com/threads/92094/post-605684
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/i386/acpi-build.c | 8 ++------
|
||||||
|
1 file changed, 2 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
|
||||||
|
index 53f804ac16..9b1b9f0412 100644
|
||||||
|
--- a/hw/i386/acpi-build.c
|
||||||
|
+++ b/hw/i386/acpi-build.c
|
||||||
|
@@ -347,13 +347,9 @@ Aml *aml_pci_device_dsm(void)
|
||||||
|
{
|
||||||
|
Aml *params = aml_local(0);
|
||||||
|
Aml *pkg = aml_package(2);
|
||||||
|
- aml_append(pkg, aml_int(0));
|
||||||
|
- aml_append(pkg, aml_int(0));
|
||||||
|
+ aml_append(pkg, aml_name("BSEL"));
|
||||||
|
+ aml_append(pkg, aml_name("ASUN"));
|
||||||
|
aml_append(method, aml_store(pkg, params));
|
||||||
|
- aml_append(method,
|
||||||
|
- aml_store(aml_name("BSEL"), aml_index(params, aml_int(0))));
|
||||||
|
- aml_append(method,
|
||||||
|
- aml_store(aml_name("ASUN"), aml_index(params, aml_int(1))));
|
||||||
|
aml_append(method,
|
||||||
|
aml_return(aml_call5("PDSM", aml_arg(0), aml_arg(1),
|
||||||
|
aml_arg(2), aml_arg(3), params))
|
|
@ -1,83 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefano Garzarella <sgarzare@redhat.com>
|
|
||||||
Date: Fri, 10 Sep 2021 14:45:33 +0200
|
|
||||||
Subject: [PATCH] block/mirror: fix NULL pointer dereference in
|
|
||||||
mirror_wait_on_conflicts()
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
In mirror_iteration() we call mirror_wait_on_conflicts() with
|
|
||||||
`self` parameter set to NULL.
|
|
||||||
|
|
||||||
Starting from commit d44dae1a7c we dereference `self` pointer in
|
|
||||||
mirror_wait_on_conflicts() without checks if it is not NULL.
|
|
||||||
|
|
||||||
Backtrace:
|
|
||||||
Program terminated with signal SIGSEGV, Segmentation fault.
|
|
||||||
#0 mirror_wait_on_conflicts (self=0x0, s=<optimized out>, offset=<optimized out>, bytes=<optimized out>)
|
|
||||||
at ../block/mirror.c:172
|
|
||||||
172 self->waiting_for_op = op;
|
|
||||||
[Current thread is 1 (Thread 0x7f0908931ec0 (LWP 380249))]
|
|
||||||
(gdb) bt
|
|
||||||
#0 mirror_wait_on_conflicts (self=0x0, s=<optimized out>, offset=<optimized out>, bytes=<optimized out>)
|
|
||||||
at ../block/mirror.c:172
|
|
||||||
#1 0x00005610c5d9d631 in mirror_run (job=0x5610c76a2c00, errp=<optimized out>) at ../block/mirror.c:491
|
|
||||||
#2 0x00005610c5d58726 in job_co_entry (opaque=0x5610c76a2c00) at ../job.c:917
|
|
||||||
#3 0x00005610c5f046c6 in coroutine_trampoline (i0=<optimized out>, i1=<optimized out>)
|
|
||||||
at ../util/coroutine-ucontext.c:173
|
|
||||||
#4 0x00007f0909975820 in ?? () at ../sysdeps/unix/sysv/linux/x86_64/__start_context.S:91
|
|
||||||
from /usr/lib64/libc.so.6
|
|
||||||
|
|
||||||
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001404
|
|
||||||
Fixes: d44dae1a7c ("block/mirror: fix active mirror dead-lock in mirror_wait_on_conflicts")
|
|
||||||
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
||||||
Message-Id: <20210910124533.288318-1-sgarzare@redhat.com>
|
|
||||||
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
||||||
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
|
|
||||||
(cherry picked from commit 66fed30c9cd11854fc878a4eceb507e915d7c9cd)
|
|
||||||
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/mirror.c | 25 ++++++++++++++++---------
|
|
||||||
1 file changed, 16 insertions(+), 9 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
|
||||||
index 98fc66eabf..85b781bc21 100644
|
|
||||||
--- a/block/mirror.c
|
|
||||||
+++ b/block/mirror.c
|
|
||||||
@@ -160,18 +160,25 @@ static void coroutine_fn mirror_wait_on_conflicts(MirrorOp *self,
|
|
||||||
if (ranges_overlap(self_start_chunk, self_nb_chunks,
|
|
||||||
op_start_chunk, op_nb_chunks))
|
|
||||||
{
|
|
||||||
- /*
|
|
||||||
- * If the operation is already (indirectly) waiting for us, or
|
|
||||||
- * will wait for us as soon as it wakes up, then just go on
|
|
||||||
- * (instead of producing a deadlock in the former case).
|
|
||||||
- */
|
|
||||||
- if (op->waiting_for_op) {
|
|
||||||
- continue;
|
|
||||||
+ if (self) {
|
|
||||||
+ /*
|
|
||||||
+ * If the operation is already (indirectly) waiting for us,
|
|
||||||
+ * or will wait for us as soon as it wakes up, then just go
|
|
||||||
+ * on (instead of producing a deadlock in the former case).
|
|
||||||
+ */
|
|
||||||
+ if (op->waiting_for_op) {
|
|
||||||
+ continue;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ self->waiting_for_op = op;
|
|
||||||
}
|
|
||||||
|
|
||||||
- self->waiting_for_op = op;
|
|
||||||
qemu_co_queue_wait(&op->waiting_requests, NULL);
|
|
||||||
- self->waiting_for_op = NULL;
|
|
||||||
+
|
|
||||||
+ if (self) {
|
|
||||||
+ self->waiting_for_op = NULL;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
35
debian/patches/extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
35
debian/patches/extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
|
@ -0,0 +1,35 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 29 Apr 2024 15:41:11 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: use uint64_t for timeout in
|
||||||
|
nanoseconds
|
||||||
|
|
||||||
|
rather than the uint32_t for which the maximum is slightly more than 4
|
||||||
|
seconds and larger values would overflow. The QAPI interface allows
|
||||||
|
specifying the number of seconds, so only values 0 to 4 are safe right
|
||||||
|
now, other values lead to a much lower timeout than a user expects.
|
||||||
|
|
||||||
|
The block_copy() call where this is used already takes a uint64_t for
|
||||||
|
the timeout, so no change required there.
|
||||||
|
|
||||||
|
Fixes: 6db7fd1ca9 ("block/copy-before-write: implement cbw-timeout option")
|
||||||
|
Reported-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Tested-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 8aba27a71d..026fa9840f 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -43,7 +43,7 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
BlockCopyState *bcs;
|
||||||
|
BdrvChild *target;
|
||||||
|
OnCbwError on_cbw_error;
|
||||||
|
- uint32_t cbw_timeout_ns;
|
||||||
|
+ uint64_t cbw_timeout_ns;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* @lock: protects access to @access_bitmap, @done_bitmap and
|
87
debian/patches/extra/0006-Revert-virtio-pci-fix-use-of-a-released-vector.patch
vendored
Normal file
87
debian/patches/extra/0006-Revert-virtio-pci-fix-use-of-a-released-vector.patch
vendored
Normal file
|
@ -0,0 +1,87 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 16 May 2024 12:59:52 +0200
|
||||||
|
Subject: [PATCH] Revert "virtio-pci: fix use of a released vector"
|
||||||
|
|
||||||
|
This reverts commit 2ce6cff94df2650c460f809e5ad263f1d22507c0.
|
||||||
|
|
||||||
|
The fix causes some issues:
|
||||||
|
https://gitlab.com/qemu-project/qemu/-/issues/2321
|
||||||
|
https://gitlab.com/qemu-project/qemu/-/issues/2334
|
||||||
|
|
||||||
|
The CVE fixed by commit 2ce6cff94d ("virtio-pci: fix use of a released
|
||||||
|
vector") is CVE-2024-4693 [0] and allows a malicious guest that
|
||||||
|
controls the boot process in the guest to crash its QEMU process.
|
||||||
|
|
||||||
|
The issues sound worse than the CVE, so revert until there is a proper
|
||||||
|
fix.
|
||||||
|
|
||||||
|
[0]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-4693
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/virtio/virtio-pci.c | 37 ++-----------------------------------
|
||||||
|
1 file changed, 2 insertions(+), 35 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
|
||||||
|
index e04218a9fb..fd66713848 100644
|
||||||
|
--- a/hw/virtio/virtio-pci.c
|
||||||
|
+++ b/hw/virtio/virtio-pci.c
|
||||||
|
@@ -1410,38 +1410,6 @@ static int virtio_pci_add_mem_cap(VirtIOPCIProxy *proxy,
|
||||||
|
return offset;
|
||||||
|
}
|
||||||
|
|
||||||
|
-static void virtio_pci_set_vector(VirtIODevice *vdev,
|
||||||
|
- VirtIOPCIProxy *proxy,
|
||||||
|
- int queue_no, uint16_t old_vector,
|
||||||
|
- uint16_t new_vector)
|
||||||
|
-{
|
||||||
|
- bool kvm_irqfd = (vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
|
||||||
|
- msix_enabled(&proxy->pci_dev) && kvm_msi_via_irqfd_enabled();
|
||||||
|
-
|
||||||
|
- if (new_vector == old_vector) {
|
||||||
|
- return;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- /*
|
||||||
|
- * If the device uses irqfd and the vector changes after DRIVER_OK is
|
||||||
|
- * set, we need to release the old vector and set up the new one.
|
||||||
|
- * Otherwise just need to set the new vector on the device.
|
||||||
|
- */
|
||||||
|
- if (kvm_irqfd && old_vector != VIRTIO_NO_VECTOR) {
|
||||||
|
- kvm_virtio_pci_vector_release_one(proxy, queue_no);
|
||||||
|
- }
|
||||||
|
- /* Set the new vector on the device. */
|
||||||
|
- if (queue_no == VIRTIO_CONFIG_IRQ_IDX) {
|
||||||
|
- vdev->config_vector = new_vector;
|
||||||
|
- } else {
|
||||||
|
- virtio_queue_set_vector(vdev, queue_no, new_vector);
|
||||||
|
- }
|
||||||
|
- /* If the new vector changed need to set it up. */
|
||||||
|
- if (kvm_irqfd && new_vector != VIRTIO_NO_VECTOR) {
|
||||||
|
- kvm_virtio_pci_vector_use_one(proxy, queue_no);
|
||||||
|
- }
|
||||||
|
-}
|
||||||
|
-
|
||||||
|
int virtio_pci_add_shm_cap(VirtIOPCIProxy *proxy,
|
||||||
|
uint8_t bar, uint64_t offset, uint64_t length,
|
||||||
|
uint8_t id)
|
||||||
|
@@ -1588,8 +1556,7 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr,
|
||||||
|
} else {
|
||||||
|
val = VIRTIO_NO_VECTOR;
|
||||||
|
}
|
||||||
|
- virtio_pci_set_vector(vdev, proxy, VIRTIO_CONFIG_IRQ_IDX,
|
||||||
|
- vdev->config_vector, val);
|
||||||
|
+ vdev->config_vector = val;
|
||||||
|
break;
|
||||||
|
case VIRTIO_PCI_COMMON_STATUS:
|
||||||
|
if (!(val & VIRTIO_CONFIG_S_DRIVER_OK)) {
|
||||||
|
@@ -1629,7 +1596,7 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr,
|
||||||
|
} else {
|
||||||
|
val = VIRTIO_NO_VECTOR;
|
||||||
|
}
|
||||||
|
- virtio_pci_set_vector(vdev, proxy, vdev->queue_sel, vector, val);
|
||||||
|
+ virtio_queue_set_vector(vdev, vdev->queue_sel, val);
|
||||||
|
break;
|
||||||
|
case VIRTIO_PCI_COMMON_Q_ENABLE:
|
||||||
|
if (val == 1) {
|
|
@ -0,0 +1,55 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:22 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: fix permission
|
||||||
|
|
||||||
|
In case when source node does not have any parents, the condition still
|
||||||
|
works as required: backup job do create the parent by
|
||||||
|
|
||||||
|
block_job_create -> block_job_add_bdrv -> bdrv_root_attach_child
|
||||||
|
|
||||||
|
Still, in this case checking @perm variable doesn't work, as backup job
|
||||||
|
creates the root blk with empty permissions (as it rely on CBW filter
|
||||||
|
to require correct permissions and don't want to create extra
|
||||||
|
conflicts).
|
||||||
|
|
||||||
|
So, we should not check @perm.
|
||||||
|
|
||||||
|
The hack may be dropped entirely when transactional insertion of
|
||||||
|
filter (when we don't try to recalculate permissions in intermediate
|
||||||
|
state, when filter does conflict with original parent of the source
|
||||||
|
node) merged (old big series
|
||||||
|
"[PATCH v5 00/45] Transactional block-graph modifying API"[1] and it's
|
||||||
|
current in-flight part is "[PATCH v8 0/7] blockdev-replace"[2])
|
||||||
|
|
||||||
|
[1] https://patchew.org/QEMU/20220330212902.590099-1-vsementsov@openvz.org/
|
||||||
|
[2] https://patchew.org/QEMU/20231017184444.932733-1-vsementsov@yandex-team.ru/
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 10 +++++++---
|
||||||
|
1 file changed, 7 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 026fa9840f..5a9456d426 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -364,9 +364,13 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
perm, shared, nperm, nshared);
|
||||||
|
|
||||||
|
if (!QLIST_EMPTY(&bs->parents)) {
|
||||||
|
- if (perm & BLK_PERM_WRITE) {
|
||||||
|
- *nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
- }
|
||||||
|
+ /*
|
||||||
|
+ * Note, that source child may be shared with backup job. Backup job
|
||||||
|
+ * does create own blk parent on copy-before-write node, so this
|
||||||
|
+ * works even if source node does not have any parents before backup
|
||||||
|
+ * start
|
||||||
|
+ */
|
||||||
|
+ *nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
*nshared &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
|
||||||
|
}
|
||||||
|
}
|
48
debian/patches/extra/0008-block-copy-before-write-support-unligned-snapshot-di.patch
vendored
Normal file
48
debian/patches/extra/0008-block-copy-before-write-support-unligned-snapshot-di.patch
vendored
Normal file
|
@ -0,0 +1,48 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:23 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: support unligned snapshot-discard
|
||||||
|
|
||||||
|
First thing that crashes on unligned access here is
|
||||||
|
bdrv_reset_dirty_bitmap(). Correct way is to align-down the
|
||||||
|
snapshot-discard request.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 16 +++++++++++++---
|
||||||
|
1 file changed, 13 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 5a9456d426..c0e70669a2 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -325,14 +325,24 @@ static int coroutine_fn GRAPH_RDLOCK
|
||||||
|
cbw_co_pdiscard_snapshot(BlockDriverState *bs, int64_t offset, int64_t bytes)
|
||||||
|
{
|
||||||
|
BDRVCopyBeforeWriteState *s = bs->opaque;
|
||||||
|
+ uint32_t cluster_size = block_copy_cluster_size(s->bcs);
|
||||||
|
+ int64_t aligned_offset = QEMU_ALIGN_UP(offset, cluster_size);
|
||||||
|
+ int64_t aligned_end = QEMU_ALIGN_DOWN(offset + bytes, cluster_size);
|
||||||
|
+ int64_t aligned_bytes;
|
||||||
|
+
|
||||||
|
+ if (aligned_end <= aligned_offset) {
|
||||||
|
+ return 0;
|
||||||
|
+ }
|
||||||
|
+ aligned_bytes = aligned_end - aligned_offset;
|
||||||
|
|
||||||
|
WITH_QEMU_LOCK_GUARD(&s->lock) {
|
||||||
|
- bdrv_reset_dirty_bitmap(s->access_bitmap, offset, bytes);
|
||||||
|
+ bdrv_reset_dirty_bitmap(s->access_bitmap, aligned_offset,
|
||||||
|
+ aligned_bytes);
|
||||||
|
}
|
||||||
|
|
||||||
|
- block_copy_reset(s->bcs, offset, bytes);
|
||||||
|
+ block_copy_reset(s->bcs, aligned_offset, aligned_bytes);
|
||||||
|
|
||||||
|
- return bdrv_co_pdiscard(s->target, offset, bytes);
|
||||||
|
+ return bdrv_co_pdiscard(s->target, aligned_offset, aligned_bytes);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void GRAPH_RDLOCK cbw_refresh_filename(BlockDriverState *bs)
|
373
debian/patches/extra/0009-block-copy-before-write-create-block_copy-bitmap-in-.patch
vendored
Normal file
373
debian/patches/extra/0009-block-copy-before-write-create-block_copy-bitmap-in-.patch
vendored
Normal file
|
@ -0,0 +1,373 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:24 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: create block_copy bitmap in filter
|
||||||
|
node
|
||||||
|
|
||||||
|
Currently block_copy creates copy_bitmap in source node. But that is in
|
||||||
|
bad relation with .independent_close=true of copy-before-write filter:
|
||||||
|
source node may be detached and removed before .bdrv_close() handler
|
||||||
|
called, which should call block_copy_state_free(), which in turn should
|
||||||
|
remove copy_bitmap.
|
||||||
|
|
||||||
|
That's all not ideal: it would be better if internal bitmap of
|
||||||
|
block-copy object is not attached to any node. But that is not possible
|
||||||
|
now.
|
||||||
|
|
||||||
|
The simplest solution is just create copy_bitmap in filter node, where
|
||||||
|
anyway two other bitmaps are created.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 3 +-
|
||||||
|
block/copy-before-write.c | 2 +-
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
tests/qemu-iotests/257.out | 112 ++++++++++++++++++-------------------
|
||||||
|
4 files changed, 60 insertions(+), 58 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 9ee3dd7ef5..8fca2c3698 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -351,6 +351,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
}
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
+ BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
@@ -367,7 +368,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
|
- copy_bitmap = bdrv_create_dirty_bitmap(source->bs, cluster_size, NULL,
|
||||||
|
+ copy_bitmap = bdrv_create_dirty_bitmap(copy_bitmap_bs, cluster_size, NULL,
|
||||||
|
errp);
|
||||||
|
if (!copy_bitmap) {
|
||||||
|
return NULL;
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index c0e70669a2..94db31512d 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -468,7 +468,7 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
|
||||||
|
bs->file->bs->supported_zero_flags);
|
||||||
|
|
||||||
|
- s->bcs = block_copy_state_new(bs->file, s->target, bitmap, errp);
|
||||||
|
+ s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index 0700953ab8..8b41643bfa 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -25,6 +25,7 @@ typedef struct BlockCopyState BlockCopyState;
|
||||||
|
typedef struct BlockCopyCallState BlockCopyCallState;
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
+ BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
diff --git a/tests/qemu-iotests/257.out b/tests/qemu-iotests/257.out
|
||||||
|
index aa76131ca9..c33dd7f3a9 100644
|
||||||
|
--- a/tests/qemu-iotests/257.out
|
||||||
|
+++ b/tests/qemu-iotests/257.out
|
||||||
|
@@ -120,16 +120,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -596,16 +596,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -865,16 +865,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -1341,16 +1341,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -1610,16 +1610,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2086,16 +2086,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2355,16 +2355,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2831,16 +2831,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3100,16 +3100,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3576,16 +3576,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3845,16 +3845,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -4321,16 +4321,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -4590,16 +4590,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -5066,16 +5066,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
277
debian/patches/extra/0010-qapi-blockdev-backup-add-discard-source-parameter.patch
vendored
Normal file
277
debian/patches/extra/0010-qapi-blockdev-backup-add-discard-source-parameter.patch
vendored
Normal file
|
@ -0,0 +1,277 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:25 +0200
|
||||||
|
Subject: [PATCH] qapi: blockdev-backup: add discard-source parameter
|
||||||
|
|
||||||
|
Add a parameter that enables discard-after-copy. That is mostly useful
|
||||||
|
in "push backup with fleecing" scheme, when source is snapshot-access
|
||||||
|
format driver node, based on copy-before-write filter snapshot-access
|
||||||
|
API:
|
||||||
|
|
||||||
|
[guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target]
|
||||||
|
| |
|
||||||
|
| root | file
|
||||||
|
v v
|
||||||
|
[copy-before-write]
|
||||||
|
| |
|
||||||
|
| file | target
|
||||||
|
v v
|
||||||
|
[active disk] [temp.img]
|
||||||
|
|
||||||
|
In this case discard-after-copy does two things:
|
||||||
|
|
||||||
|
- discard data in temp.img to save disk space
|
||||||
|
- avoid further copy-before-write operation in discarded area
|
||||||
|
|
||||||
|
Note that we have to declare WRITE permission on source in
|
||||||
|
copy-before-write filter, for discard to work. Still we can't take it
|
||||||
|
unconditionally, as it will break normal backup from RO source. So, we
|
||||||
|
have to add a parameter and pass it thorough bdrv_open flags.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/backup.c | 5 +++--
|
||||||
|
block/block-copy.c | 9 +++++++++
|
||||||
|
block/copy-before-write.c | 15 +++++++++++++--
|
||||||
|
block/copy-before-write.h | 1 +
|
||||||
|
block/replication.c | 4 ++--
|
||||||
|
blockdev.c | 2 +-
|
||||||
|
include/block/block-common.h | 2 ++
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
include/block/block_int-global-state.h | 2 +-
|
||||||
|
qapi/block-core.json | 4 ++++
|
||||||
|
10 files changed, 37 insertions(+), 8 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
|
index ec29d6b810..3dd2e229d2 100644
|
||||||
|
--- a/block/backup.c
|
||||||
|
+++ b/block/backup.c
|
||||||
|
@@ -356,7 +356,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
BlockDriverState *target, int64_t speed,
|
||||||
|
MirrorSyncMode sync_mode, BdrvDirtyBitmap *sync_bitmap,
|
||||||
|
BitmapSyncMode bitmap_mode,
|
||||||
|
- bool compress,
|
||||||
|
+ bool compress, bool discard_source,
|
||||||
|
const char *filter_node_name,
|
||||||
|
BackupPerf *perf,
|
||||||
|
BlockdevOnError on_source_error,
|
||||||
|
@@ -457,7 +457,8 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
|
||||||
|
- cbw = bdrv_cbw_append(bs, target, filter_node_name, &bcs, errp);
|
||||||
|
+ cbw = bdrv_cbw_append(bs, target, filter_node_name, discard_source,
|
||||||
|
+ &bcs, errp);
|
||||||
|
if (!cbw) {
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 8fca2c3698..7e3b378528 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -137,6 +137,7 @@ typedef struct BlockCopyState {
|
||||||
|
CoMutex lock;
|
||||||
|
int64_t in_flight_bytes;
|
||||||
|
BlockCopyMethod method;
|
||||||
|
+ bool discard_source;
|
||||||
|
BlockReqList reqs;
|
||||||
|
QLIST_HEAD(, BlockCopyCallState) calls;
|
||||||
|
/*
|
||||||
|
@@ -353,6 +354,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
+ bool discard_source,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
ERRP_GUARD();
|
||||||
|
@@ -418,6 +420,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
cluster_size),
|
||||||
|
};
|
||||||
|
|
||||||
|
+ s->discard_source = discard_source;
|
||||||
|
block_copy_set_copy_opts(s, false, false);
|
||||||
|
|
||||||
|
ratelimit_init(&s->rate_limit);
|
||||||
|
@@ -589,6 +592,12 @@ static coroutine_fn int block_copy_task_entry(AioTask *task)
|
||||||
|
co_put_to_shres(s->mem, t->req.bytes);
|
||||||
|
block_copy_task_end(t, ret);
|
||||||
|
|
||||||
|
+ if (s->discard_source && ret == 0) {
|
||||||
|
+ int64_t nbytes =
|
||||||
|
+ MIN(t->req.offset + t->req.bytes, s->len) - t->req.offset;
|
||||||
|
+ bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 94db31512d..853e01a1eb 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -44,6 +44,7 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
BdrvChild *target;
|
||||||
|
OnCbwError on_cbw_error;
|
||||||
|
uint64_t cbw_timeout_ns;
|
||||||
|
+ bool discard_source;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* @lock: protects access to @access_bitmap, @done_bitmap and
|
||||||
|
@@ -357,6 +358,8 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
uint64_t perm, uint64_t shared,
|
||||||
|
uint64_t *nperm, uint64_t *nshared)
|
||||||
|
{
|
||||||
|
+ BDRVCopyBeforeWriteState *s = bs->opaque;
|
||||||
|
+
|
||||||
|
if (!(role & BDRV_CHILD_FILTERED)) {
|
||||||
|
/*
|
||||||
|
* Target child
|
||||||
|
@@ -381,6 +384,10 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
* start
|
||||||
|
*/
|
||||||
|
*nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
+ if (s->discard_source) {
|
||||||
|
+ *nperm = *nperm | BLK_PERM_WRITE;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
*nshared &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -468,7 +475,9 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
|
||||||
|
bs->file->bs->supported_zero_flags);
|
||||||
|
|
||||||
|
- s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap, errp);
|
||||||
|
+ s->discard_source = flags & BDRV_O_CBW_DISCARD_SOURCE;
|
||||||
|
+ s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap,
|
||||||
|
+ flags & BDRV_O_CBW_DISCARD_SOURCE, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
@@ -535,12 +544,14 @@ static BlockDriver bdrv_cbw_filter = {
|
||||||
|
BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
+ bool discard_source,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
BDRVCopyBeforeWriteState *state;
|
||||||
|
BlockDriverState *top;
|
||||||
|
QDict *opts;
|
||||||
|
+ int flags = BDRV_O_RDWR | (discard_source ? BDRV_O_CBW_DISCARD_SOURCE : 0);
|
||||||
|
|
||||||
|
assert(source->total_sectors == target->total_sectors);
|
||||||
|
GLOBAL_STATE_CODE();
|
||||||
|
@@ -553,7 +564,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
qdict_put_str(opts, "file", bdrv_get_node_name(source));
|
||||||
|
qdict_put_str(opts, "target", bdrv_get_node_name(target));
|
||||||
|
|
||||||
|
- top = bdrv_insert_node(source, opts, BDRV_O_RDWR, errp);
|
||||||
|
+ top = bdrv_insert_node(source, opts, flags, errp);
|
||||||
|
if (!top) {
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
|
index 6e72bb25e9..01af0cd3c4 100644
|
||||||
|
--- a/block/copy-before-write.h
|
||||||
|
+++ b/block/copy-before-write.h
|
||||||
|
@@ -39,6 +39,7 @@
|
||||||
|
BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
+ bool discard_source,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp);
|
||||||
|
void bdrv_cbw_drop(BlockDriverState *bs);
|
||||||
|
diff --git a/block/replication.c b/block/replication.c
|
||||||
|
index ca6bd0a720..0415a5e8b7 100644
|
||||||
|
--- a/block/replication.c
|
||||||
|
+++ b/block/replication.c
|
||||||
|
@@ -582,8 +582,8 @@ static void replication_start(ReplicationState *rs, ReplicationMode mode,
|
||||||
|
|
||||||
|
s->backup_job = backup_job_create(
|
||||||
|
NULL, s->secondary_disk->bs, s->hidden_disk->bs,
|
||||||
|
- 0, MIRROR_SYNC_MODE_NONE, NULL, 0, false, NULL,
|
||||||
|
- &perf,
|
||||||
|
+ 0, MIRROR_SYNC_MODE_NONE, NULL, 0, false, false,
|
||||||
|
+ NULL, &perf,
|
||||||
|
BLOCKDEV_ON_ERROR_REPORT,
|
||||||
|
BLOCKDEV_ON_ERROR_REPORT, JOB_INTERNAL,
|
||||||
|
backup_job_completed, bs, NULL, &local_err);
|
||||||
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
|
index 057601dcf0..4c33c3f5f0 100644
|
||||||
|
--- a/blockdev.c
|
||||||
|
+++ b/blockdev.c
|
||||||
|
@@ -2726,7 +2726,7 @@ static BlockJob *do_backup_common(BackupCommon *backup,
|
||||||
|
|
||||||
|
job = backup_job_create(backup->job_id, bs, target_bs, backup->speed,
|
||||||
|
backup->sync, bmap, backup->bitmap_mode,
|
||||||
|
- backup->compress,
|
||||||
|
+ backup->compress, backup->discard_source,
|
||||||
|
backup->filter_node_name,
|
||||||
|
&perf,
|
||||||
|
backup->on_source_error,
|
||||||
|
diff --git a/include/block/block-common.h b/include/block/block-common.h
|
||||||
|
index a846023a09..338fe5ff7a 100644
|
||||||
|
--- a/include/block/block-common.h
|
||||||
|
+++ b/include/block/block-common.h
|
||||||
|
@@ -243,6 +243,8 @@ typedef enum {
|
||||||
|
read-write fails */
|
||||||
|
#define BDRV_O_IO_URING 0x40000 /* use io_uring instead of the thread pool */
|
||||||
|
|
||||||
|
+#define BDRV_O_CBW_DISCARD_SOURCE 0x80000 /* for copy-before-write filter */
|
||||||
|
+
|
||||||
|
#define BDRV_O_CACHE_MASK (BDRV_O_NOCACHE | BDRV_O_NO_FLUSH)
|
||||||
|
|
||||||
|
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index 8b41643bfa..bdc703bacd 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -27,6 +27,7 @@ typedef struct BlockCopyCallState BlockCopyCallState;
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
+ bool discard_source,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
/* Function should be called prior any actual copy request */
|
||||||
|
diff --git a/include/block/block_int-global-state.h b/include/block/block_int-global-state.h
|
||||||
|
index d2201e27f4..eb2d92a226 100644
|
||||||
|
--- a/include/block/block_int-global-state.h
|
||||||
|
+++ b/include/block/block_int-global-state.h
|
||||||
|
@@ -193,7 +193,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
MirrorSyncMode sync_mode,
|
||||||
|
BdrvDirtyBitmap *sync_bitmap,
|
||||||
|
BitmapSyncMode bitmap_mode,
|
||||||
|
- bool compress,
|
||||||
|
+ bool compress, bool discard_source,
|
||||||
|
const char *filter_node_name,
|
||||||
|
BackupPerf *perf,
|
||||||
|
BlockdevOnError on_source_error,
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 4b18e01b85..b179d65520 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -1610,6 +1610,9 @@
|
||||||
|
# node specified by @drive. If this option is not given, a node
|
||||||
|
# name is autogenerated. (Since: 4.2)
|
||||||
|
#
|
||||||
|
+# @discard-source: Discard blocks on source which are already copied
|
||||||
|
+# to the target. (Since 9.0)
|
||||||
|
+#
|
||||||
|
# @x-perf: Performance options. (Since 6.0)
|
||||||
|
#
|
||||||
|
# Features:
|
||||||
|
@@ -1631,6 +1634,7 @@
|
||||||
|
'*on-target-error': 'BlockdevOnError',
|
||||||
|
'*auto-finalize': 'bool', '*auto-dismiss': 'bool',
|
||||||
|
'*filter-node-name': 'str',
|
||||||
|
+ '*discard-source': 'bool',
|
||||||
|
'*x-perf': { 'type': 'BackupPerf',
|
||||||
|
'features': [ 'unstable' ] } } }
|
||||||
|
|
92
debian/patches/extra/0011-hw-virtio-Fix-the-de-initialization-of-vhost-user-de.patch
vendored
Normal file
92
debian/patches/extra/0011-hw-virtio-Fix-the-de-initialization-of-vhost-user-de.patch
vendored
Normal file
|
@ -0,0 +1,92 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Thomas Huth <thuth@redhat.com>
|
||||||
|
Date: Tue, 18 Jun 2024 14:19:58 +0200
|
||||||
|
Subject: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices
|
||||||
|
|
||||||
|
The unrealize functions of the various vhost-user devices are
|
||||||
|
calling the corresponding vhost_*_set_status() functions with a
|
||||||
|
status of 0 to shut down the device correctly.
|
||||||
|
|
||||||
|
Now these vhost_*_set_status() functions all follow this scheme:
|
||||||
|
|
||||||
|
bool should_start = virtio_device_should_start(vdev, status);
|
||||||
|
|
||||||
|
if (vhost_dev_is_started(&vvc->vhost_dev) == should_start) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (should_start) {
|
||||||
|
/* ... do the initialization stuff ... */
|
||||||
|
} else {
|
||||||
|
/* ... do the cleanup stuff ... */
|
||||||
|
}
|
||||||
|
|
||||||
|
The problem here is virtio_device_should_start(vdev, 0) currently
|
||||||
|
always returns "true" since it internally only looks at vdev->started
|
||||||
|
instead of looking at the "status" parameter. Thus once the device
|
||||||
|
got started once, virtio_device_should_start() always returns true
|
||||||
|
and thus the vhost_*_set_status() functions return early, without
|
||||||
|
ever doing any clean-up when being called with status == 0. This
|
||||||
|
causes e.g. problems when trying to hot-plug and hot-unplug a vhost
|
||||||
|
user devices multiple times since the de-initialization step is
|
||||||
|
completely skipped during the unplug operation.
|
||||||
|
|
||||||
|
This bug has been introduced in commit 9f6bcfd99f ("hw/virtio: move
|
||||||
|
vm_running check to virtio_device_started") which replaced
|
||||||
|
|
||||||
|
should_start = status & VIRTIO_CONFIG_S_DRIVER_OK;
|
||||||
|
|
||||||
|
with
|
||||||
|
|
||||||
|
should_start = virtio_device_started(vdev, status);
|
||||||
|
|
||||||
|
which later got replaced by virtio_device_should_start(). This blocked
|
||||||
|
the possibility to set should_start to false in case the status flag
|
||||||
|
VIRTIO_CONFIG_S_DRIVER_OK was not set.
|
||||||
|
|
||||||
|
Fix it by adjusting the virtio_device_should_start() function to
|
||||||
|
only consider the status flag instead of vdev->started. Since this
|
||||||
|
function is only used in the various vhost_*_set_status() functions
|
||||||
|
for exactly the same purpose, it should be fine to fix it in this
|
||||||
|
central place there without any risk to change the behavior of other
|
||||||
|
code.
|
||||||
|
|
||||||
|
Fixes: 9f6bcfd99f ("hw/virtio: move vm_running check to virtio_device_started")
|
||||||
|
Buglink: https://issues.redhat.com/browse/RHEL-40708
|
||||||
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
||||||
|
Message-Id: <20240618121958.88673-1-thuth@redhat.com>
|
||||||
|
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
(cherry picked from commit d72479b11797c28893e1e3fc565497a9cae5ca16)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
include/hw/virtio/virtio.h | 8 ++++----
|
||||||
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
|
||||||
|
index 7d5ffdc145..2eafad17b8 100644
|
||||||
|
--- a/include/hw/virtio/virtio.h
|
||||||
|
+++ b/include/hw/virtio/virtio.h
|
||||||
|
@@ -470,9 +470,9 @@ static inline bool virtio_device_started(VirtIODevice *vdev, uint8_t status)
|
||||||
|
* @vdev - the VirtIO device
|
||||||
|
* @status - the devices status bits
|
||||||
|
*
|
||||||
|
- * This is similar to virtio_device_started() but also encapsulates a
|
||||||
|
- * check on the VM status which would prevent a device starting
|
||||||
|
- * anyway.
|
||||||
|
+ * This is similar to virtio_device_started() but ignores vdev->started
|
||||||
|
+ * and also encapsulates a check on the VM status which would prevent a
|
||||||
|
+ * device from starting anyway.
|
||||||
|
*/
|
||||||
|
static inline bool virtio_device_should_start(VirtIODevice *vdev, uint8_t status)
|
||||||
|
{
|
||||||
|
@@ -480,7 +480,7 @@ static inline bool virtio_device_should_start(VirtIODevice *vdev, uint8_t status
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
- return virtio_device_started(vdev, status);
|
||||||
|
+ return status & VIRTIO_CONFIG_S_DRIVER_OK;
|
||||||
|
}
|
||||||
|
|
||||||
|
static inline void virtio_set_started(VirtIODevice *vdev, bool started)
|
43
debian/patches/extra/0012-target-arm-Use-float_status-copy-in-sme_fmopa_s.patch
vendored
Normal file
43
debian/patches/extra/0012-target-arm-Use-float_status-copy-in-sme_fmopa_s.patch
vendored
Normal file
|
@ -0,0 +1,43 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Date: Wed, 17 Jul 2024 16:01:47 +1000
|
||||||
|
Subject: [PATCH] target/arm: Use float_status copy in sme_fmopa_s
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
We made a copy above because the fp exception flags
|
||||||
|
are not propagated back to the FPST register, but
|
||||||
|
then failed to use the copy.
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)")
|
||||||
|
Signed-off-by: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Message-id: 20240717060149.204788-2-richard.henderson@linaro.org
|
||||||
|
[rth: Split from a larger patch]
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
(cherry picked from commit 31d93fedf41c24b0badb38cd9317590d1ef74e37)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/sme_helper.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
|
||||||
|
index e2e0575039..5a6dd76489 100644
|
||||||
|
--- a/target/arm/tcg/sme_helper.c
|
||||||
|
+++ b/target/arm/tcg/sme_helper.c
|
||||||
|
@@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn,
|
||||||
|
if (pb & 1) {
|
||||||
|
uint32_t *a = vza_row + H1_4(col);
|
||||||
|
uint32_t *m = vzm + H1_4(col);
|
||||||
|
- *a = float32_muladd(n, *m, *a, 0, vst);
|
||||||
|
+ *a = float32_muladd(n, *m, *a, 0, &fpst);
|
||||||
|
}
|
||||||
|
col += 4;
|
||||||
|
pb >>= 4;
|
62
debian/patches/extra/0013-target-arm-Use-FPST_F16-for-SME-FMOPA-widening.patch
vendored
Normal file
62
debian/patches/extra/0013-target-arm-Use-FPST_F16-for-SME-FMOPA-widening.patch
vendored
Normal file
|
@ -0,0 +1,62 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Date: Wed, 17 Jul 2024 16:01:48 +1000
|
||||||
|
Subject: [PATCH] target/arm: Use FPST_F16 for SME FMOPA (widening)
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
This operation has float16 inputs and thus must use
|
||||||
|
the FZ16 control not the FZ control.
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)")
|
||||||
|
Reported-by: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Message-id: 20240717060149.204788-3-richard.henderson@linaro.org
|
||||||
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2374
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
(cherry picked from commit 207d30b5fdb5b45a36f26eefcf52fe2c1714dd4f)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/translate-sme.c | 12 ++++++++----
|
||||||
|
1 file changed, 8 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
|
||||||
|
index 46c7fce8b4..185a8a917b 100644
|
||||||
|
--- a/target/arm/tcg/translate-sme.c
|
||||||
|
+++ b/target/arm/tcg/translate-sme.c
|
||||||
|
@@ -304,6 +304,7 @@ static bool do_outprod(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
}
|
||||||
|
|
||||||
|
static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
+ ARMFPStatusFlavour e_fpst,
|
||||||
|
gen_helper_gvec_5_ptr *fn)
|
||||||
|
{
|
||||||
|
int svl = streaming_vec_reg_size(s);
|
||||||
|
@@ -319,15 +320,18 @@ static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
zm = vec_full_reg_ptr(s, a->zm);
|
||||||
|
pn = pred_full_reg_ptr(s, a->pn);
|
||||||
|
pm = pred_full_reg_ptr(s, a->pm);
|
||||||
|
- fpst = fpstatus_ptr(FPST_FPCR);
|
||||||
|
+ fpst = fpstatus_ptr(e_fpst);
|
||||||
|
|
||||||
|
fn(za, zn, zm, pn, pm, fpst, tcg_constant_i32(desc));
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
-TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_h)
|
||||||
|
-TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_s)
|
||||||
|
-TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a, MO_64, gen_helper_sme_fmopa_d)
|
||||||
|
+TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a,
|
||||||
|
+ MO_32, FPST_FPCR_F16, gen_helper_sme_fmopa_h)
|
||||||
|
+TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a,
|
||||||
|
+ MO_32, FPST_FPCR, gen_helper_sme_fmopa_s)
|
||||||
|
+TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a,
|
||||||
|
+ MO_64, FPST_FPCR, gen_helper_sme_fmopa_d)
|
||||||
|
|
||||||
|
/* TODO: FEAT_EBF16 */
|
||||||
|
TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa)
|
60
debian/patches/extra/0014-scsi-fix-regression-and-honor-bootindex-again-for-le.patch
vendored
Normal file
60
debian/patches/extra/0014-scsi-fix-regression-and-honor-bootindex-again-for-le.patch
vendored
Normal file
|
@ -0,0 +1,60 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Wed, 10 Jul 2024 17:25:29 +0200
|
||||||
|
Subject: [PATCH] scsi: fix regression and honor bootindex again for legacy
|
||||||
|
drives
|
||||||
|
|
||||||
|
Commit 3089637461 ("scsi: Don't ignore most usb-storage properties")
|
||||||
|
removed the call to object_property_set_int() and thus the 'set'
|
||||||
|
method for the bootindex property was also not called anymore. Here
|
||||||
|
that method is device_set_bootindex() (as configured by
|
||||||
|
scsi_dev_instance_init() -> device_add_bootindex_property()) which as
|
||||||
|
a side effect registers the device via add_boot_device_path().
|
||||||
|
|
||||||
|
As reported by a downstream user [0], the bootindex property did not
|
||||||
|
have the desired effect anymore for legacy drives. Fix the regression
|
||||||
|
by explicitly calling the add_boot_device_path() function after
|
||||||
|
checking that the bootindex is not yet used (to avoid
|
||||||
|
add_boot_device_path() calling exit()).
|
||||||
|
|
||||||
|
[0]: https://forum.proxmox.com/threads/149772/post-679433
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 3089637461 ("scsi: Don't ignore most usb-storage properties")
|
||||||
|
Suggested-by: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Link: https://lore.kernel.org/r/20240710152529.1737407-1-f.ebner@proxmox.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit 57a8a80d1a5b28797b21d30bfc60601945820e51)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/scsi-bus.c | 9 +++++++++
|
||||||
|
1 file changed, 9 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
|
||||||
|
index 9e40b0c920..53eff5dd3d 100644
|
||||||
|
--- a/hw/scsi/scsi-bus.c
|
||||||
|
+++ b/hw/scsi/scsi-bus.c
|
||||||
|
@@ -384,6 +384,7 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
|
||||||
|
DeviceState *dev;
|
||||||
|
SCSIDevice *s;
|
||||||
|
DriveInfo *dinfo;
|
||||||
|
+ Error *local_err = NULL;
|
||||||
|
|
||||||
|
if (blk_is_sg(blk)) {
|
||||||
|
driver = "scsi-generic";
|
||||||
|
@@ -403,6 +404,14 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
|
||||||
|
s = SCSI_DEVICE(dev);
|
||||||
|
s->conf = *conf;
|
||||||
|
|
||||||
|
+ check_boot_index(conf->bootindex, &local_err);
|
||||||
|
+ if (local_err) {
|
||||||
|
+ object_unparent(OBJECT(dev));
|
||||||
|
+ error_propagate(errp, local_err);
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+ add_boot_device_path(conf->bootindex, dev, NULL);
|
||||||
|
+
|
||||||
|
qdev_prop_set_uint32(dev, "scsi-id", unit);
|
||||||
|
if (object_property_find(OBJECT(dev), "removable")) {
|
||||||
|
qdev_prop_set_bit(dev, "removable", removable);
|
48
debian/patches/extra/0015-hw-scsi-lsi53c895a-bump-instruction-limit-in-scripts.patch
vendored
Normal file
48
debian/patches/extra/0015-hw-scsi-lsi53c895a-bump-instruction-limit-in-scripts.patch
vendored
Normal file
|
@ -0,0 +1,48 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 15 Jul 2024 15:14:03 +0200
|
||||||
|
Subject: [PATCH] hw/scsi/lsi53c895a: bump instruction limit in scripts
|
||||||
|
processing to fix regression
|
||||||
|
|
||||||
|
Commit 9876359990 ("hw/scsi/lsi53c895a: add timer to scripts
|
||||||
|
processing") reduced the maximum allowed instruction count by
|
||||||
|
a factor of 100 all the way down to 100.
|
||||||
|
|
||||||
|
This causes the "Check Point R81.20 Gaia" appliance [0] to fail to
|
||||||
|
boot after fully finishing the installation via the appliance's web
|
||||||
|
interface (there is already one reboot before that).
|
||||||
|
|
||||||
|
With a limit of 150, the appliance still fails to boot, while with a
|
||||||
|
limit of 200, it works. Bump to 500 to fix the regression and be on
|
||||||
|
the safe side.
|
||||||
|
|
||||||
|
Originally reported in the Proxmox community forum[1].
|
||||||
|
|
||||||
|
[0]: https://support.checkpoint.com/results/download/124397
|
||||||
|
[1]: https://forum.proxmox.com/threads/149772/post-683459
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 9876359990 ("hw/scsi/lsi53c895a: add timer to scripts processing")
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Acked-by: Sven Schnelle <svens@stackframe.org>
|
||||||
|
Link: https://lore.kernel.org/r/20240715131403.223239-1-f.ebner@proxmox.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit a4975023fb13cf229bd59c9ceec1b8cbdc5b9a20)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/lsi53c895a.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
|
||||||
|
index eb9828dd5e..f1935e5328 100644
|
||||||
|
--- a/hw/scsi/lsi53c895a.c
|
||||||
|
+++ b/hw/scsi/lsi53c895a.c
|
||||||
|
@@ -188,7 +188,7 @@ static const char *names[] = {
|
||||||
|
#define LSI_TAG_VALID (1 << 16)
|
||||||
|
|
||||||
|
/* Maximum instructions to process. */
|
||||||
|
-#define LSI_MAX_INSN 100
|
||||||
|
+#define LSI_MAX_INSN 500
|
||||||
|
|
||||||
|
typedef struct lsi_request {
|
||||||
|
SCSIRequest *req;
|
|
@ -0,0 +1,38 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Date: Thu, 27 Jun 2024 20:12:44 +0200
|
||||||
|
Subject: [PATCH] block-copy: Fix missing graph lock
|
||||||
|
|
||||||
|
The graph lock needs to be held when calling bdrv_co_pdiscard(). Fix
|
||||||
|
block_copy_task_entry() to take it for the call.
|
||||||
|
|
||||||
|
WITH_GRAPH_RDLOCK_GUARD() was implemented in a weak way because of
|
||||||
|
limitations in clang's Thread Safety Analysis at the time, so that it
|
||||||
|
only asserts that the lock is held (which allows calling functions that
|
||||||
|
require the lock), but we never deal with the unlocking (so even after
|
||||||
|
the scope of the guard, the compiler assumes that the lock is still
|
||||||
|
held). This is why the compiler didn't catch this locking error.
|
||||||
|
|
||||||
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||||||
|
(picked from https://lore.kernel.org/qemu-devel/20240627181245.281403-2-kwolf@redhat.com/)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 4 +++-
|
||||||
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 7e3b378528..cc618e4561 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -595,7 +595,9 @@ static coroutine_fn int block_copy_task_entry(AioTask *task)
|
||||||
|
if (s->discard_source && ret == 0) {
|
||||||
|
int64_t nbytes =
|
||||||
|
MIN(t->req.offset + t->req.bytes, s->len) - t->req.offset;
|
||||||
|
- bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ WITH_GRAPH_RDLOCK_GUARD() {
|
||||||
|
+ bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
return ret;
|
93
debian/patches/extra/0017-Revert-qemu-char-do-not-operate-on-sources-from-fina.patch
vendored
Normal file
93
debian/patches/extra/0017-Revert-qemu-char-do-not-operate-on-sources-from-fina.patch
vendored
Normal file
|
@ -0,0 +1,93 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Sergey Dyasli <sergey.dyasli@nutanix.com>
|
||||||
|
Date: Fri, 12 Jul 2024 09:26:59 +0000
|
||||||
|
Subject: [PATCH] Revert "qemu-char: do not operate on sources from finalize
|
||||||
|
callbacks"
|
||||||
|
|
||||||
|
This reverts commit 2b316774f60291f57ca9ecb6a9f0712c532cae34.
|
||||||
|
|
||||||
|
After 038b4217884c ("Revert "chardev: use a child source for qio input
|
||||||
|
source"") we've been observing the "iwp->src == NULL" assertion
|
||||||
|
triggering periodically during the initial capabilities querying by
|
||||||
|
libvirtd. One of possible backtraces:
|
||||||
|
|
||||||
|
Thread 1 (Thread 0x7f16cd4f0700 (LWP 43858)):
|
||||||
|
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
|
||||||
|
1 0x00007f16c6c21e65 in __GI_abort () at abort.c:79
|
||||||
|
2 0x00007f16c6c21d39 in __assert_fail_base at assert.c:92
|
||||||
|
3 0x00007f16c6c46e86 in __GI___assert_fail (assertion=assertion@entry=0x562e9bcdaadd "iwp->src == NULL", file=file@entry=0x562e9bcdaac8 "../chardev/char-io.c", line=line@entry=99, function=function@entry=0x562e9bcdab10 <__PRETTY_FUNCTION__.20549> "io_watch_poll_finalize") at assert.c:101
|
||||||
|
4 0x0000562e9ba20c2c in io_watch_poll_finalize (source=<optimized out>) at ../chardev/char-io.c:99
|
||||||
|
5 io_watch_poll_finalize (source=<optimized out>) at ../chardev/char-io.c:88
|
||||||
|
6 0x00007f16c904aae0 in g_source_unref_internal () from /lib64/libglib-2.0.so.0
|
||||||
|
7 0x00007f16c904baf9 in g_source_destroy_internal () from /lib64/libglib-2.0.so.0
|
||||||
|
8 0x0000562e9ba20db0 in io_remove_watch_poll (source=0x562e9d6720b0) at ../chardev/char-io.c:147
|
||||||
|
9 remove_fd_in_watch (chr=chr@entry=0x562e9d5f3800) at ../chardev/char-io.c:153
|
||||||
|
10 0x0000562e9ba23ffb in update_ioc_handlers (s=0x562e9d5f3800) at ../chardev/char-socket.c:592
|
||||||
|
11 0x0000562e9ba2072f in qemu_chr_fe_set_handlers_full at ../chardev/char-fe.c:279
|
||||||
|
12 0x0000562e9ba207a9 in qemu_chr_fe_set_handlers at ../chardev/char-fe.c:304
|
||||||
|
13 0x0000562e9ba2ca75 in monitor_qmp_setup_handlers_bh (opaque=0x562e9d4c2c60) at ../monitor/qmp.c:509
|
||||||
|
14 0x0000562e9bb6222e in aio_bh_poll (ctx=ctx@entry=0x562e9d4c2f20) at ../util/async.c:216
|
||||||
|
15 0x0000562e9bb4de0a in aio_poll (ctx=0x562e9d4c2f20, blocking=blocking@entry=true) at ../util/aio-posix.c:722
|
||||||
|
16 0x0000562e9b99dfaa in iothread_run (opaque=0x562e9d4c26f0) at ../iothread.c:63
|
||||||
|
17 0x0000562e9bb505a4 in qemu_thread_start (args=0x562e9d4c7ea0) at ../util/qemu-thread-posix.c:543
|
||||||
|
18 0x00007f16c70081ca in start_thread (arg=<optimized out>) at pthread_create.c:479
|
||||||
|
19 0x00007f16c6c398d3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
|
||||||
|
|
||||||
|
io_remove_watch_poll(), which makes sure that iwp->src is NULL, calls
|
||||||
|
g_source_destroy() which finds that iwp->src is not NULL in the finalize
|
||||||
|
callback. This can only happen if another thread has managed to trigger
|
||||||
|
io_watch_poll_prepare() callback in the meantime.
|
||||||
|
|
||||||
|
Move iwp->src destruction back to the finalize callback to prevent the
|
||||||
|
described race, and also remove the stale comment. The deadlock glib bug
|
||||||
|
was fixed back in 2010 by b35820285668 ("gmain: move finalization of
|
||||||
|
GSource outside of context lock").
|
||||||
|
|
||||||
|
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
Signed-off-by: Sergey Dyasli <sergey.dyasli@nutanix.com>
|
||||||
|
Link: https://lore.kernel.org/r/20240712092659.216206-1-sergey.dyasli@nutanix.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit e0bf95443ee9326d44031373420cf9f3513ee255)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
chardev/char-io.c | 19 +++++--------------
|
||||||
|
1 file changed, 5 insertions(+), 14 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/chardev/char-io.c b/chardev/char-io.c
|
||||||
|
index dab77b112e..3be17b51ca 100644
|
||||||
|
--- a/chardev/char-io.c
|
||||||
|
+++ b/chardev/char-io.c
|
||||||
|
@@ -87,16 +87,12 @@ static gboolean io_watch_poll_dispatch(GSource *source, GSourceFunc callback,
|
||||||
|
|
||||||
|
static void io_watch_poll_finalize(GSource *source)
|
||||||
|
{
|
||||||
|
- /*
|
||||||
|
- * Due to a glib bug, removing the last reference to a source
|
||||||
|
- * inside a finalize callback causes recursive locking (and a
|
||||||
|
- * deadlock). This is not a problem inside other callbacks,
|
||||||
|
- * including dispatch callbacks, so we call io_remove_watch_poll
|
||||||
|
- * to remove this source. At this point, iwp->src must
|
||||||
|
- * be NULL, or we would leak it.
|
||||||
|
- */
|
||||||
|
IOWatchPoll *iwp = io_watch_poll_from_source(source);
|
||||||
|
- assert(iwp->src == NULL);
|
||||||
|
+ if (iwp->src) {
|
||||||
|
+ g_source_destroy(iwp->src);
|
||||||
|
+ g_source_unref(iwp->src);
|
||||||
|
+ iwp->src = NULL;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
static GSourceFuncs io_watch_poll_funcs = {
|
||||||
|
@@ -139,11 +135,6 @@ static void io_remove_watch_poll(GSource *source)
|
||||||
|
IOWatchPoll *iwp;
|
||||||
|
|
||||||
|
iwp = io_watch_poll_from_source(source);
|
||||||
|
- if (iwp->src) {
|
||||||
|
- g_source_destroy(iwp->src);
|
||||||
|
- g_source_unref(iwp->src);
|
||||||
|
- iwp->src = NULL;
|
||||||
|
- }
|
||||||
|
g_source_destroy(&iwp->parent);
|
||||||
|
}
|
||||||
|
|
|
@ -1,17 +1,89 @@
|
||||||
Index: pve-qemu-kvm-6.1.0/qapi/block-core.json
|
Index: pve-qemu-kvm-9.0.0/block/meson.build
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-6.1.0.orig/qapi/block-core.json
|
--- pve-qemu-kvm-9.0.0.orig/block/meson.build
|
||||||
+++ pve-qemu-kvm-6.1.0/qapi/block-core.json
|
+++ pve-qemu-kvm-9.0.0/block/meson.build
|
||||||
@@ -3084,7 +3084,7 @@
|
@@ -126,6 +126,7 @@ foreach m : [
|
||||||
'preallocate', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
|
[libnfs, 'nfs', files('nfs.c')],
|
||||||
{ 'name': 'replication', 'if': 'defined(CONFIG_REPLICATION)' },
|
[libssh, 'ssh', files('ssh.c')],
|
||||||
'pbs',
|
[rbd, 'rbd', files('rbd.c')],
|
||||||
- 'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
|
+ [vitastor, 'vitastor', files('vitastor.c')],
|
||||||
+ 'ssh', 'throttle', 'vdi', 'vhdx', 'vitastor', 'vmdk', 'vpc', 'vvfat' ] }
|
]
|
||||||
|
if m[0].found()
|
||||||
|
module_ss = ss.source_set()
|
||||||
|
Index: pve-qemu-kvm-9.0.0/meson.build
|
||||||
|
===================================================================
|
||||||
|
--- pve-qemu-kvm-9.0.0.orig/meson.build
|
||||||
|
+++ pve-qemu-kvm-9.0.0/meson.build
|
||||||
|
@@ -1452,6 +1452,26 @@ if not get_option('rbd').auto() or have_
|
||||||
|
endif
|
||||||
|
endif
|
||||||
|
|
||||||
##
|
+vitastor = not_found
|
||||||
# @BlockdevOptionsFile:
|
+if not get_option('vitastor').auto() or have_block
|
||||||
@@ -4020,6 +4020,28 @@
|
+ libvitastor_client = cc.find_library('vitastor_client', has_headers: ['vitastor_c.h'],
|
||||||
|
+ required: get_option('vitastor'))
|
||||||
|
+ if libvitastor_client.found()
|
||||||
|
+ if cc.links('''
|
||||||
|
+ #include <vitastor_c.h>
|
||||||
|
+ int main(void) {
|
||||||
|
+ vitastor_c_create_qemu(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
|
||||||
|
+ return 0;
|
||||||
|
+ }''', dependencies: libvitastor_client)
|
||||||
|
+ vitastor = declare_dependency(dependencies: libvitastor_client)
|
||||||
|
+ elif get_option('vitastor').enabled()
|
||||||
|
+ error('could not link libvitastor_client')
|
||||||
|
+ else
|
||||||
|
+ warning('could not link libvitastor_client, disabling')
|
||||||
|
+ endif
|
||||||
|
+ endif
|
||||||
|
+endif
|
||||||
|
+
|
||||||
|
glusterfs = not_found
|
||||||
|
glusterfs_ftruncate_has_stat = false
|
||||||
|
glusterfs_iocb_has_stat = false
|
||||||
|
@@ -2254,6 +2274,7 @@ endif
|
||||||
|
config_host_data.set('CONFIG_OPENGL', opengl.found())
|
||||||
|
config_host_data.set('CONFIG_PLUGIN', get_option('plugins'))
|
||||||
|
config_host_data.set('CONFIG_RBD', rbd.found())
|
||||||
|
+config_host_data.set('CONFIG_VITASTOR', vitastor.found())
|
||||||
|
config_host_data.set('CONFIG_RDMA', rdma.found())
|
||||||
|
config_host_data.set('CONFIG_RELOCATABLE', get_option('relocatable'))
|
||||||
|
config_host_data.set('CONFIG_SAFESTACK', get_option('safe_stack'))
|
||||||
|
@@ -4454,6 +4475,7 @@ summary_info += {'fdt support': fd
|
||||||
|
summary_info += {'libcap-ng support': libcap_ng}
|
||||||
|
summary_info += {'bpf support': libbpf}
|
||||||
|
summary_info += {'rbd support': rbd}
|
||||||
|
+summary_info += {'vitastor support': vitastor}
|
||||||
|
summary_info += {'smartcard support': cacard}
|
||||||
|
summary_info += {'U2F support': u2f}
|
||||||
|
summary_info += {'libusb': libusb}
|
||||||
|
Index: pve-qemu-kvm-9.0.0/meson_options.txt
|
||||||
|
===================================================================
|
||||||
|
--- pve-qemu-kvm-9.0.0.orig/meson_options.txt
|
||||||
|
+++ pve-qemu-kvm-9.0.0/meson_options.txt
|
||||||
|
@@ -194,6 +194,8 @@ option('lzo', type : 'feature', value :
|
||||||
|
description: 'lzo compression support')
|
||||||
|
option('rbd', type : 'feature', value : 'auto',
|
||||||
|
description: 'Ceph block device driver')
|
||||||
|
+option('vitastor', type : 'feature', value : 'auto',
|
||||||
|
+ description: 'Vitastor block device driver')
|
||||||
|
option('opengl', type : 'feature', value : 'auto',
|
||||||
|
description: 'OpenGL support')
|
||||||
|
option('rdma', type : 'feature', value : 'auto',
|
||||||
|
Index: pve-qemu-kvm-9.0.0/qapi/block-core.json
|
||||||
|
===================================================================
|
||||||
|
--- pve-qemu-kvm-9.0.0.orig/qapi/block-core.json
|
||||||
|
+++ pve-qemu-kvm-9.0.0/qapi/block-core.json
|
||||||
|
@@ -3481,7 +3481,7 @@
|
||||||
|
'raw', 'rbd',
|
||||||
|
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
||||||
|
'pbs',
|
||||||
|
- 'ssh', 'throttle', 'vdi', 'vhdx',
|
||||||
|
+ 'ssh', 'throttle', 'vdi', 'vhdx', 'vitastor',
|
||||||
|
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
||||||
|
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
||||||
|
{ 'name': 'virtio-blk-vhost-vdpa', 'if': 'CONFIG_BLKIO' },
|
||||||
|
@@ -4591,6 +4591,28 @@
|
||||||
'*server': ['InetSocketAddressBase'] } }
|
'*server': ['InetSocketAddressBase'] } }
|
||||||
|
|
||||||
##
|
##
|
||||||
|
@ -40,15 +112,15 @@ Index: pve-qemu-kvm-6.1.0/qapi/block-core.json
|
||||||
# @ReplicationMode:
|
# @ReplicationMode:
|
||||||
#
|
#
|
||||||
# An enumeration of replication modes.
|
# An enumeration of replication modes.
|
||||||
@@ -4392,6 +4414,7 @@
|
@@ -5053,6 +5075,7 @@
|
||||||
'throttle': 'BlockdevOptionsThrottle',
|
'throttle': 'BlockdevOptionsThrottle',
|
||||||
'vdi': 'BlockdevOptionsGenericFormat',
|
'vdi': 'BlockdevOptionsGenericFormat',
|
||||||
'vhdx': 'BlockdevOptionsGenericFormat',
|
'vhdx': 'BlockdevOptionsGenericFormat',
|
||||||
+ 'vitastor': 'BlockdevOptionsVitastor',
|
+ 'vitastor': 'BlockdevOptionsVitastor',
|
||||||
'vmdk': 'BlockdevOptionsGenericCOWFormat',
|
'virtio-blk-vfio-pci':
|
||||||
'vpc': 'BlockdevOptionsGenericFormat',
|
{ 'type': 'BlockdevOptionsVirtioBlkVfioPci',
|
||||||
'vvfat': 'BlockdevOptionsVVFAT'
|
'if': 'CONFIG_BLKIO' },
|
||||||
@@ -4782,6 +4805,17 @@
|
@@ -5498,6 +5521,20 @@
|
||||||
'*encrypt' : 'RbdEncryptionCreateOptions' } }
|
'*encrypt' : 'RbdEncryptionCreateOptions' } }
|
||||||
|
|
||||||
##
|
##
|
||||||
|
@ -56,6 +128,9 @@ Index: pve-qemu-kvm-6.1.0/qapi/block-core.json
|
||||||
+#
|
+#
|
||||||
+# Driver specific image creation options for Vitastor.
|
+# Driver specific image creation options for Vitastor.
|
||||||
+#
|
+#
|
||||||
|
+# @location: Where to store the new image file. This location cannot
|
||||||
|
+# point to a snapshot.
|
||||||
|
+#
|
||||||
+# @size: Size of the virtual disk in bytes
|
+# @size: Size of the virtual disk in bytes
|
||||||
+##
|
+##
|
||||||
+{ 'struct': 'BlockdevCreateOptionsVitastor',
|
+{ 'struct': 'BlockdevCreateOptionsVitastor',
|
||||||
|
@ -66,7 +141,7 @@ Index: pve-qemu-kvm-6.1.0/qapi/block-core.json
|
||||||
# @BlockdevVmdkSubformat:
|
# @BlockdevVmdkSubformat:
|
||||||
#
|
#
|
||||||
# Subformat options for VMDK images
|
# Subformat options for VMDK images
|
||||||
@@ -4977,6 +5011,7 @@
|
@@ -5719,6 +5753,7 @@
|
||||||
'ssh': 'BlockdevCreateOptionsSsh',
|
'ssh': 'BlockdevCreateOptionsSsh',
|
||||||
'vdi': 'BlockdevCreateOptionsVdi',
|
'vdi': 'BlockdevCreateOptionsVdi',
|
||||||
'vhdx': 'BlockdevCreateOptionsVhdx',
|
'vhdx': 'BlockdevCreateOptionsVhdx',
|
||||||
|
@ -74,123 +149,53 @@ Index: pve-qemu-kvm-6.1.0/qapi/block-core.json
|
||||||
'vmdk': 'BlockdevCreateOptionsVmdk',
|
'vmdk': 'BlockdevCreateOptionsVmdk',
|
||||||
'vpc': 'BlockdevCreateOptionsVpc'
|
'vpc': 'BlockdevCreateOptionsVpc'
|
||||||
} }
|
} }
|
||||||
Index: pve-qemu-kvm-6.1.0/block/meson.build
|
Index: pve-qemu-kvm-9.0.0/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-6.1.0.orig/block/meson.build
|
--- pve-qemu-kvm-9.0.0.orig/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
+++ pve-qemu-kvm-6.1.0/block/meson.build
|
+++ pve-qemu-kvm-9.0.0/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
@@ -91,6 +91,7 @@ foreach m : [
|
@@ -30,7 +30,7 @@
|
||||||
[libnfs, 'nfs', files('nfs.c')],
|
--with-suffix="qemu-kvm" \
|
||||||
[libssh, 'ssh', files('ssh.c')],
|
--firmwarepath=/usr/share/qemu-firmware \
|
||||||
[rbd, 'rbd', files('rbd.c')],
|
--target-list="x86_64-softmmu" \
|
||||||
+ [vitastor, 'vitastor', files('vitastor.c')],
|
---block-drv-rw-whitelist="qcow2,raw,file,host_device,nbd,iscsi,rbd,blkdebug,luks,null-co,nvme,copy-on-read,throttle,gluster" \
|
||||||
]
|
+--block-drv-rw-whitelist="qcow2,raw,file,host_device,nbd,iscsi,rbd,vitastor,blkdebug,luks,null-co,nvme,copy-on-read,throttle,gluster" \
|
||||||
if m[0].found()
|
--audio-drv-list="" \
|
||||||
module_ss = ss.source_set()
|
--block-drv-ro-whitelist="vmdk,vhdx,vpc,https,ssh" \
|
||||||
Index: pve-qemu-kvm-6.1.0/configure
|
--with-coroutine=ucontext \
|
||||||
|
@@ -176,6 +176,7 @@
|
||||||
|
--enable-opengl \
|
||||||
|
--enable-pie \
|
||||||
|
--enable-rbd \
|
||||||
|
+--enable-vitastor \
|
||||||
|
--enable-rdma \
|
||||||
|
--enable-seccomp \
|
||||||
|
--enable-snappy \
|
||||||
|
Index: pve-qemu-kvm-9.0.0/scripts/meson-buildoptions.sh
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-6.1.0.orig/configure
|
--- pve-qemu-kvm-9.0.0.orig/scripts/meson-buildoptions.sh
|
||||||
+++ pve-qemu-kvm-6.1.0/configure
|
+++ pve-qemu-kvm-9.0.0/scripts/meson-buildoptions.sh
|
||||||
@@ -375,6 +375,7 @@ trace_file="trace"
|
@@ -168,6 +168,7 @@ meson_options_help() {
|
||||||
spice="$default_feature"
|
printf "%s\n" ' qed qed image format support'
|
||||||
spice_protocol="auto"
|
printf "%s\n" ' qga-vss build QGA VSS support (broken with MinGW)'
|
||||||
rbd="auto"
|
printf "%s\n" ' rbd Ceph block device driver'
|
||||||
+vitastor="auto"
|
+ printf "%s\n" ' vitastor Vitastor block device driver'
|
||||||
smartcard="auto"
|
printf "%s\n" ' rdma Enable RDMA-based migration'
|
||||||
u2f="auto"
|
printf "%s\n" ' replication replication support'
|
||||||
libusb="auto"
|
printf "%s\n" ' rutabaga-gfx rutabaga_gfx support'
|
||||||
@@ -1293,6 +1294,10 @@ for opt do
|
@@ -445,6 +446,8 @@ _meson_option_parse() {
|
||||||
;;
|
--disable-qom-cast-debug) printf "%s" -Dqom_cast_debug=false ;;
|
||||||
--enable-rbd) rbd="enabled"
|
--enable-rbd) printf "%s" -Drbd=enabled ;;
|
||||||
;;
|
--disable-rbd) printf "%s" -Drbd=disabled ;;
|
||||||
+ --disable-vitastor) vitastor="disabled"
|
+ --enable-vitastor) printf "%s" -Dvitastor=enabled ;;
|
||||||
+ ;;
|
+ --disable-vitastor) printf "%s" -Dvitastor=disabled ;;
|
||||||
+ --enable-vitastor) vitastor="enabled"
|
--enable-rdma) printf "%s" -Drdma=enabled ;;
|
||||||
+ ;;
|
--disable-rdma) printf "%s" -Drdma=disabled ;;
|
||||||
--disable-xfsctl) xfs="no"
|
--enable-relocatable) printf "%s" -Drelocatable=true ;;
|
||||||
;;
|
Index: pve-qemu-kvm-9.0.0/block/vitastor.c
|
||||||
--enable-xfsctl) xfs="yes"
|
|
||||||
@@ -1921,6 +1926,7 @@ disabled with --disable-FEATURE, default
|
|
||||||
spice spice
|
|
||||||
spice-protocol spice-protocol
|
|
||||||
rbd rados block device (rbd)
|
|
||||||
+ vitastor vitastor block device
|
|
||||||
libiscsi iscsi support
|
|
||||||
libnfs nfs support
|
|
||||||
smartcard smartcard support (libcacard)
|
|
||||||
@@ -5211,7 +5217,7 @@ if test "$skip_meson" = no; then
|
|
||||||
-Dcapstone=$capstone -Dslirp=$slirp -Dfdt=$fdt -Dbrlapi=$brlapi \
|
|
||||||
-Dcurl=$curl -Dglusterfs=$glusterfs -Dbzip2=$bzip2 -Dlibiscsi=$libiscsi \
|
|
||||||
-Dlibnfs=$libnfs -Diconv=$iconv -Dcurses=$curses -Dlibudev=$libudev\
|
|
||||||
- -Drbd=$rbd -Dlzo=$lzo -Dsnappy=$snappy -Dlzfse=$lzfse -Dlibxml2=$libxml2 \
|
|
||||||
+ -Drbd=$rbd -Dvitastor=$vitastor -Dlzo=$lzo -Dsnappy=$snappy -Dlzfse=$lzfse -Dlibxml2=$libxml2 \
|
|
||||||
-Dlibdaxctl=$libdaxctl -Dlibpmem=$libpmem -Dlinux_io_uring=$linux_io_uring \
|
|
||||||
-Dgnutls=$gnutls -Dnettle=$nettle -Dgcrypt=$gcrypt -Dauth_pam=$auth_pam \
|
|
||||||
-Dzstd=$zstd -Dseccomp=$seccomp -Dvirtfs=$virtfs -Dcap_ng=$cap_ng \
|
|
||||||
Index: pve-qemu-kvm-6.1.0/meson.build
|
|
||||||
===================================================================
|
|
||||||
--- pve-qemu-kvm-6.1.0.orig/meson.build
|
|
||||||
+++ pve-qemu-kvm-6.1.0/meson.build
|
|
||||||
@@ -729,6 +729,26 @@ if not get_option('rbd').auto() or have_
|
|
||||||
endif
|
|
||||||
endif
|
|
||||||
|
|
||||||
+vitastor = not_found
|
|
||||||
+if not get_option('vitastor').auto() or have_block
|
|
||||||
+ libvitastor_client = cc.find_library('vitastor_client', has_headers: ['vitastor_c.h'],
|
|
||||||
+ required: get_option('vitastor'), kwargs: static_kwargs)
|
|
||||||
+ if libvitastor_client.found()
|
|
||||||
+ if cc.links('''
|
|
||||||
+ #include <vitastor_c.h>
|
|
||||||
+ int main(void) {
|
|
||||||
+ vitastor_c_create_qemu(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
|
|
||||||
+ return 0;
|
|
||||||
+ }''', dependencies: libvitastor_client)
|
|
||||||
+ vitastor = declare_dependency(dependencies: libvitastor_client)
|
|
||||||
+ elif get_option('vitastor').enabled()
|
|
||||||
+ error('could not link libvitastor_client')
|
|
||||||
+ else
|
|
||||||
+ warning('could not link libvitastor_client, disabling')
|
|
||||||
+ endif
|
|
||||||
+ endif
|
|
||||||
+endif
|
|
||||||
+
|
|
||||||
glusterfs = not_found
|
|
||||||
glusterfs_ftruncate_has_stat = false
|
|
||||||
glusterfs_iocb_has_stat = false
|
|
||||||
@@ -1268,6 +1288,7 @@ config_host_data.set('CONFIG_LIBNFS', li
|
|
||||||
config_host_data.set('CONFIG_LINUX_IO_URING', linux_io_uring.found())
|
|
||||||
config_host_data.set('CONFIG_LIBPMEM', libpmem.found())
|
|
||||||
config_host_data.set('CONFIG_RBD', rbd.found())
|
|
||||||
+config_host_data.set('CONFIG_VITASTOR', vitastor.found())
|
|
||||||
config_host_data.set('CONFIG_SDL', sdl.found())
|
|
||||||
config_host_data.set('CONFIG_SDL_IMAGE', sdl_image.found())
|
|
||||||
config_host_data.set('CONFIG_SECCOMP', seccomp.found())
|
|
||||||
@@ -3087,6 +3108,7 @@ summary_info += {'bpf support': libbpf.f
|
|
||||||
# TODO: add back protocol and server version
|
|
||||||
summary_info += {'spice support': config_host.has_key('CONFIG_SPICE')}
|
|
||||||
summary_info += {'rbd support': rbd.found()}
|
|
||||||
+summary_info += {'vitastor support': vitastor.found()}
|
|
||||||
summary_info += {'xfsctl support': config_host.has_key('CONFIG_XFS')}
|
|
||||||
summary_info += {'smartcard support': cacard.found()}
|
|
||||||
summary_info += {'U2F support': u2f.found()}
|
|
||||||
Index: pve-qemu-kvm-6.1.0/meson_options.txt
|
|
||||||
===================================================================
|
|
||||||
--- pve-qemu-kvm-6.1.0.orig/meson_options.txt
|
|
||||||
+++ pve-qemu-kvm-6.1.0/meson_options.txt
|
|
||||||
@@ -102,6 +102,8 @@ option('lzo', type : 'feature', value :
|
|
||||||
description: 'lzo compression support')
|
|
||||||
option('rbd', type : 'feature', value : 'auto',
|
|
||||||
description: 'Ceph block device driver')
|
|
||||||
+option('vitastor', type : 'feature', value : 'auto',
|
|
||||||
+ description: 'Vitastor block device driver')
|
|
||||||
option('gtk', type : 'feature', value : 'auto',
|
|
||||||
description: 'GTK+ user interface')
|
|
||||||
option('sdl', type : 'feature', value : 'auto',
|
|
||||||
Index: a/block/vitastor.c
|
|
||||||
===================================================================
|
===================================================================
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ a/block/vitastor.c
|
+++ pve-qemu-kvm-9.0.0/block/vitastor.c
|
||||||
@@ -0,0 +1,797 @@
|
@@ -0,0 +1,1076 @@
|
||||||
+// Copyright (c) Vitaliy Filippov, 2019+
|
+// Copyright (c) Vitaliy Filippov, 2019+
|
||||||
+// License: VNPL-1.1 or GNU GPL-2.0+ (see README.md for details)
|
+// License: VNPL-1.1 or GNU GPL-2.0+ (see README.md for details)
|
||||||
+
|
+
|
||||||
|
@ -202,6 +207,9 @@ Index: a/block/vitastor.c
|
||||||
+#endif
|
+#endif
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
|
+#if QEMU_VERSION_MAJOR >= 8
|
||||||
|
+#include "block/block-io.h"
|
||||||
|
+#endif
|
||||||
+#include "block/block_int.h"
|
+#include "block/block_int.h"
|
||||||
+#include "qapi/error.h"
|
+#include "qapi/error.h"
|
||||||
+#include "qapi/qmp/qdict.h"
|
+#include "qapi/qmp/qdict.h"
|
||||||
|
@ -225,6 +233,11 @@ Index: a/block/vitastor.c
|
||||||
+#define qdict_put_str(options, name, value) qdict_put_obj(options, name, QOBJECT(qstring_from_str(value)))
|
+#define qdict_put_str(options, name, value) qdict_put_obj(options, name, QOBJECT(qstring_from_str(value)))
|
||||||
+#define qobject_unref QDECREF
|
+#define qobject_unref QDECREF
|
||||||
+#endif
|
+#endif
|
||||||
|
+#if QEMU_VERSION_MAJOR == 4 && QEMU_VERSION_MINOR >= 2 || QEMU_VERSION_MAJOR > 4
|
||||||
|
+#include "sysemu/replay.h"
|
||||||
|
+#else
|
||||||
|
+#include "sysemu/sysemu.h"
|
||||||
|
+#endif
|
||||||
+
|
+
|
||||||
+#include "vitastor_c.h"
|
+#include "vitastor_c.h"
|
||||||
+
|
+
|
||||||
|
@ -238,9 +251,13 @@ Index: a/block/vitastor.c
|
||||||
+}
|
+}
|
||||||
+#endif
|
+#endif
|
||||||
+
|
+
|
||||||
|
+typedef struct VitastorFdData VitastorFdData;
|
||||||
|
+
|
||||||
+typedef struct VitastorClient
|
+typedef struct VitastorClient
|
||||||
+{
|
+{
|
||||||
+ void *proxy;
|
+ void *proxy;
|
||||||
|
+ int uring_eventfd;
|
||||||
|
+
|
||||||
+ void *watch;
|
+ void *watch;
|
||||||
+ char *config_path;
|
+ char *config_path;
|
||||||
+ char *etcd_host;
|
+ char *etcd_host;
|
||||||
|
@ -257,12 +274,24 @@ Index: a/block/vitastor.c
|
||||||
+ int rdma_gid_index;
|
+ int rdma_gid_index;
|
||||||
+ int rdma_mtu;
|
+ int rdma_mtu;
|
||||||
+ QemuMutex mutex;
|
+ QemuMutex mutex;
|
||||||
|
+ AioContext *ctx;
|
||||||
|
+ VitastorFdData **fds;
|
||||||
|
+ int fd_count, fd_alloc;
|
||||||
|
+ int bh_uring_scheduled;
|
||||||
+
|
+
|
||||||
+ uint64_t last_bitmap_inode, last_bitmap_offset, last_bitmap_len;
|
+ uint64_t last_bitmap_inode, last_bitmap_offset, last_bitmap_len;
|
||||||
+ uint32_t last_bitmap_granularity;
|
+ uint32_t last_bitmap_granularity;
|
||||||
+ uint8_t *last_bitmap;
|
+ uint8_t *last_bitmap;
|
||||||
+} VitastorClient;
|
+} VitastorClient;
|
||||||
+
|
+
|
||||||
|
+typedef struct VitastorFdData
|
||||||
|
+{
|
||||||
|
+ VitastorClient *cli;
|
||||||
|
+ int fd;
|
||||||
|
+ IOHandler *fd_read, *fd_write;
|
||||||
|
+ void *opaque;
|
||||||
|
+} VitastorFdData;
|
||||||
|
+
|
||||||
+typedef struct VitastorRPC
|
+typedef struct VitastorRPC
|
||||||
+{
|
+{
|
||||||
+ BlockDriverState *bs;
|
+ BlockDriverState *bs;
|
||||||
|
@ -273,10 +302,21 @@ Index: a/block/vitastor.c
|
||||||
+ uint64_t inode, offset, len;
|
+ uint64_t inode, offset, len;
|
||||||
+ uint32_t bitmap_granularity;
|
+ uint32_t bitmap_granularity;
|
||||||
+ uint8_t *bitmap;
|
+ uint8_t *bitmap;
|
||||||
|
+#if QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR < 8
|
||||||
|
+ QEMUBH *bh;
|
||||||
|
+#endif
|
||||||
+} VitastorRPC;
|
+} VitastorRPC;
|
||||||
+
|
+
|
||||||
|
+#if QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR < 8
|
||||||
|
+typedef struct VitastorBH
|
||||||
|
+{
|
||||||
|
+ VitastorClient *cli;
|
||||||
|
+ QEMUBH *bh;
|
||||||
|
+} VitastorBH;
|
||||||
|
+#endif
|
||||||
|
+
|
||||||
+static void vitastor_co_init_task(BlockDriverState *bs, VitastorRPC *task);
|
+static void vitastor_co_init_task(BlockDriverState *bs, VitastorRPC *task);
|
||||||
+static void vitastor_co_generic_bh_cb(void *opaque, long retval);
|
+static void vitastor_co_generic_cb(void *opaque, long retval);
|
||||||
+static void vitastor_co_read_cb(void *opaque, long retval, uint64_t version);
|
+static void vitastor_co_read_cb(void *opaque, long retval, uint64_t version);
|
||||||
+static void vitastor_close(BlockDriverState *bs);
|
+static void vitastor_close(BlockDriverState *bs);
|
||||||
+
|
+
|
||||||
|
@ -354,8 +394,13 @@ Index: a/block/vitastor.c
|
||||||
+ !strcmp(name, "rdma-gid-index") ||
|
+ !strcmp(name, "rdma-gid-index") ||
|
||||||
+ !strcmp(name, "rdma-mtu"))
|
+ !strcmp(name, "rdma-mtu"))
|
||||||
+ {
|
+ {
|
||||||
|
+#if QEMU_VERSION_MAJOR < 8 || QEMU_VERSION_MAJOR == 8 && QEMU_VERSION_MINOR < 1
|
||||||
+ unsigned long long num_val;
|
+ unsigned long long num_val;
|
||||||
+ if (parse_uint_full(value, &num_val, 0))
|
+ if (parse_uint_full(value, &num_val, 0))
|
||||||
|
+#else
|
||||||
|
+ uint64_t num_val;
|
||||||
|
+ if (parse_uint_full(value, 0, &num_val))
|
||||||
|
+#endif
|
||||||
+ {
|
+ {
|
||||||
+ error_setg(errp, "Illegal %s: %s", name, value);
|
+ error_setg(errp, "Illegal %s: %s", name, value);
|
||||||
+ goto out;
|
+ goto out;
|
||||||
|
@ -392,6 +437,54 @@ Index: a/block/vitastor.c
|
||||||
+ return;
|
+ return;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
+#if defined VITASTOR_C_API_VERSION && VITASTOR_C_API_VERSION >= 2
|
||||||
|
+static void vitastor_uring_handler(void *opaque)
|
||||||
|
+{
|
||||||
|
+ VitastorClient *client = (VitastorClient*)opaque;
|
||||||
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
|
+ client->bh_uring_scheduled = 0;
|
||||||
|
+ vitastor_c_uring_handle_events(client->proxy);
|
||||||
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+#if QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR < 8
|
||||||
|
+static void vitastor_bh_uring_handler(void *opaque)
|
||||||
|
+{
|
||||||
|
+ VitastorBH *vbh = opaque;
|
||||||
|
+ vitastor_bh_handler(vbh->cli);
|
||||||
|
+ qemu_bh_delete(vbh->bh);
|
||||||
|
+ free(vbh);
|
||||||
|
+}
|
||||||
|
+#endif
|
||||||
|
+
|
||||||
|
+static void vitastor_schedule_uring_handler(VitastorClient *client)
|
||||||
|
+{
|
||||||
|
+ void *opaque = client;
|
||||||
|
+ if (client->uring_eventfd >= 0 && !client->bh_uring_scheduled)
|
||||||
|
+ {
|
||||||
|
+ client->bh_uring_scheduled = 1;
|
||||||
|
+#if QEMU_VERSION_MAJOR > 4 || QEMU_VERSION_MAJOR == 4 && QEMU_VERSION_MINOR >= 2
|
||||||
|
+ replay_bh_schedule_oneshot_event(client->ctx, vitastor_uring_handler, opaque);
|
||||||
|
+#elif QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 8
|
||||||
|
+ aio_bh_schedule_oneshot(client->ctx, vitastor_uring_handler, opaque);
|
||||||
|
+#else
|
||||||
|
+ VitastorBH *vbh = (VitastorBH*)malloc(sizeof(VitastorBH));
|
||||||
|
+ vbh->cli = client;
|
||||||
|
+#if QEMU_VERSION_MAJOR >= 2
|
||||||
|
+ vbh->bh = aio_bh_new(bdrv_get_aio_context(task->bs), vitastor_bh_uring_handler, vbh);
|
||||||
|
+#else
|
||||||
|
+ vbh->bh = qemu_bh_new(vitastor_bh_uring_handler, vbh);
|
||||||
|
+#endif
|
||||||
|
+ qemu_bh_schedule(vbh->bh);
|
||||||
|
+#endif
|
||||||
|
+ }
|
||||||
|
+}
|
||||||
|
+#else
|
||||||
|
+static void vitastor_schedule_uring_handler(VitastorClient *client)
|
||||||
|
+{
|
||||||
|
+}
|
||||||
|
+#endif
|
||||||
|
+
|
||||||
+static void coroutine_fn vitastor_co_get_metadata(VitastorRPC *task)
|
+static void coroutine_fn vitastor_co_get_metadata(VitastorRPC *task)
|
||||||
+{
|
+{
|
||||||
+ BlockDriverState *bs = task->bs;
|
+ BlockDriverState *bs = task->bs;
|
||||||
|
@ -399,7 +492,8 @@ Index: a/block/vitastor.c
|
||||||
+ task->co = qemu_coroutine_self();
|
+ task->co = qemu_coroutine_self();
|
||||||
+
|
+
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_watch_inode(client->proxy, client->image, vitastor_co_generic_bh_cb, task);
|
+ vitastor_c_watch_inode(client->proxy, client->image, vitastor_co_generic_cb, task);
|
||||||
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task->complete)
|
+ while (!task->complete)
|
||||||
|
@ -408,13 +502,32 @@ Index: a/block/vitastor.c
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void vitastor_aio_set_fd_handler(void *ctx, int fd, int unused1, IOHandler *fd_read, IOHandler *fd_write, void *unused2, void *opaque)
|
+static void vitastor_aio_fd_read(void *fddv)
|
||||||
|
+{
|
||||||
|
+ VitastorFdData *fdd = (VitastorFdData*)fddv;
|
||||||
|
+ qemu_mutex_lock(&fdd->cli->mutex);
|
||||||
|
+ fdd->fd_read(fdd->opaque);
|
||||||
|
+ vitastor_schedule_uring_handler(fdd->cli);
|
||||||
|
+ qemu_mutex_unlock(&fdd->cli->mutex);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void vitastor_aio_fd_write(void *fddv)
|
||||||
|
+{
|
||||||
|
+ VitastorFdData *fdd = (VitastorFdData*)fddv;
|
||||||
|
+ qemu_mutex_lock(&fdd->cli->mutex);
|
||||||
|
+ fdd->fd_write(fdd->opaque);
|
||||||
|
+ vitastor_schedule_uring_handler(fdd->cli);
|
||||||
|
+ qemu_mutex_unlock(&fdd->cli->mutex);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void universal_aio_set_fd_handler(AioContext *ctx, int fd, IOHandler *fd_read, IOHandler *fd_write, void *opaque)
|
||||||
+{
|
+{
|
||||||
+ aio_set_fd_handler(ctx, fd,
|
+ aio_set_fd_handler(ctx, fd,
|
||||||
+#if QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 5 || QEMU_VERSION_MAJOR >= 3
|
+#if QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 5 || QEMU_VERSION_MAJOR >= 3 && (QEMU_VERSION_MAJOR < 8 || QEMU_VERSION_MAJOR == 8 && QEMU_VERSION_MINOR < 1)
|
||||||
+ 0 /*is_external*/,
|
+ 0 /*is_external*/,
|
||||||
+#endif
|
+#endif
|
||||||
+ fd_read, fd_write,
|
+ fd_read,
|
||||||
|
+ fd_write,
|
||||||
+#if QEMU_VERSION_MAJOR == 1 && QEMU_VERSION_MINOR <= 6 || QEMU_VERSION_MAJOR < 1
|
+#if QEMU_VERSION_MAJOR == 1 && QEMU_VERSION_MINOR <= 6 || QEMU_VERSION_MAJOR < 1
|
||||||
+ NULL /*io_flush*/,
|
+ NULL /*io_flush*/,
|
||||||
+#endif
|
+#endif
|
||||||
|
@ -427,6 +540,92 @@ Index: a/block/vitastor.c
|
||||||
+ opaque);
|
+ opaque);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
+static void vitastor_aio_set_fd_handler(void *vcli, int fd, int unused1, IOHandler *fd_read, IOHandler *fd_write, void *unused2, void *opaque)
|
||||||
|
+{
|
||||||
|
+ VitastorClient *client = (VitastorClient*)vcli;
|
||||||
|
+ VitastorFdData *fdd = NULL;
|
||||||
|
+ int i;
|
||||||
|
+ for (i = 0; i < client->fd_count; i++)
|
||||||
|
+ {
|
||||||
|
+ if (client->fds[i]->fd == fd)
|
||||||
|
+ {
|
||||||
|
+ if (fd_read || fd_write)
|
||||||
|
+ {
|
||||||
|
+ fdd = client->fds[i];
|
||||||
|
+ fdd->opaque = opaque;
|
||||||
|
+ fdd->fd_read = fd_read;
|
||||||
|
+ fdd->fd_write = fd_write;
|
||||||
|
+ }
|
||||||
|
+ else
|
||||||
|
+ {
|
||||||
|
+ for (int j = i+1; j < client->fd_count; j++)
|
||||||
|
+ client->fds[j-1] = client->fds[j];
|
||||||
|
+ client->fd_count--;
|
||||||
|
+ }
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ if ((fd_read || fd_write) && !fdd)
|
||||||
|
+ {
|
||||||
|
+ fdd = (VitastorFdData*)malloc(sizeof(VitastorFdData));
|
||||||
|
+ fdd->cli = client;
|
||||||
|
+ fdd->fd = fd;
|
||||||
|
+ fdd->fd_read = fd_read;
|
||||||
|
+ fdd->fd_write = fd_write;
|
||||||
|
+ fdd->opaque = opaque;
|
||||||
|
+ if (client->fd_count >= client->fd_alloc)
|
||||||
|
+ {
|
||||||
|
+ client->fd_alloc = client->fd_alloc*2;
|
||||||
|
+ if (client->fd_alloc < 16)
|
||||||
|
+ client->fd_alloc = 16;
|
||||||
|
+ client->fds = (VitastorFdData**)realloc(client->fds, sizeof(VitastorFdData*) * client->fd_alloc);
|
||||||
|
+ }
|
||||||
|
+ client->fds[client->fd_count++] = fdd;
|
||||||
|
+ }
|
||||||
|
+ universal_aio_set_fd_handler(
|
||||||
|
+ client->ctx, fd, fd_read ? vitastor_aio_fd_read : NULL, fd_write ? vitastor_aio_fd_write : NULL, fdd
|
||||||
|
+ );
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+#if defined VITASTOR_C_API_VERSION && VITASTOR_C_API_VERSION >= 2
|
||||||
|
+typedef struct str_array
|
||||||
|
+{
|
||||||
|
+ const char **items;
|
||||||
|
+ int len, alloc;
|
||||||
|
+} str_array;
|
||||||
|
+
|
||||||
|
+static void strarray_push(str_array *a, const char *str)
|
||||||
|
+{
|
||||||
|
+ if (a->len >= a->alloc)
|
||||||
|
+ {
|
||||||
|
+ a->alloc = !a->alloc ? 4 : 2*a->alloc;
|
||||||
|
+ a->items = (const char**)realloc(a->items, a->alloc*sizeof(char*));
|
||||||
|
+ if (!a->items)
|
||||||
|
+ {
|
||||||
|
+ fprintf(stderr, "bad alloc\n");
|
||||||
|
+ abort();
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ a->items[a->len++] = str;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void strarray_push_kv(str_array *a, const char *key, const char *value)
|
||||||
|
+{
|
||||||
|
+ if (key && value)
|
||||||
|
+ {
|
||||||
|
+ strarray_push(a, key);
|
||||||
|
+ strarray_push(a, value);
|
||||||
|
+ }
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void strarray_free(str_array *a)
|
||||||
|
+{
|
||||||
|
+ free(a->items);
|
||||||
|
+ a->items = NULL;
|
||||||
|
+ a->len = a->alloc = 0;
|
||||||
|
+}
|
||||||
|
+#endif
|
||||||
|
+
|
||||||
+static int vitastor_file_open(BlockDriverState *bs, QDict *options, int flags, Error **errp)
|
+static int vitastor_file_open(BlockDriverState *bs, QDict *options, int flags, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ VitastorRPC task;
|
+ VitastorRPC task;
|
||||||
|
@ -444,10 +643,46 @@ Index: a/block/vitastor.c
|
||||||
+ client->rdma_port_num = qdict_get_try_int(options, "rdma-port-num", 0);
|
+ client->rdma_port_num = qdict_get_try_int(options, "rdma-port-num", 0);
|
||||||
+ client->rdma_gid_index = qdict_get_try_int(options, "rdma-gid-index", 0);
|
+ client->rdma_gid_index = qdict_get_try_int(options, "rdma-gid-index", 0);
|
||||||
+ client->rdma_mtu = qdict_get_try_int(options, "rdma-mtu", 0);
|
+ client->rdma_mtu = qdict_get_try_int(options, "rdma-mtu", 0);
|
||||||
+ client->proxy = vitastor_c_create_qemu(
|
+ client->ctx = bdrv_get_aio_context(bs);
|
||||||
+ vitastor_aio_set_fd_handler, bdrv_get_aio_context(bs), client->config_path, client->etcd_host, client->etcd_prefix,
|
+#if defined VITASTOR_C_API_VERSION && VITASTOR_C_API_VERSION >= 2
|
||||||
+ client->use_rdma, client->rdma_device, client->rdma_port_num, client->rdma_gid_index, client->rdma_mtu, 0
|
+ str_array opt = {};
|
||||||
+ );
|
+ strarray_push_kv(&opt, "config_path", qdict_get_try_str(options, "config-path"));
|
||||||
|
+ strarray_push_kv(&opt, "etcd_address", qdict_get_try_str(options, "etcd-host"));
|
||||||
|
+ strarray_push_kv(&opt, "etcd_prefix", qdict_get_try_str(options, "etcd-prefix"));
|
||||||
|
+ strarray_push_kv(&opt, "use_rdma", qdict_get_try_str(options, "use-rdma"));
|
||||||
|
+ strarray_push_kv(&opt, "rdma_device", qdict_get_try_str(options, "rdma-device"));
|
||||||
|
+ strarray_push_kv(&opt, "rdma_port_num", qdict_get_try_str(options, "rdma-port-num"));
|
||||||
|
+ strarray_push_kv(&opt, "rdma_gid_index", qdict_get_try_str(options, "rdma-gid-index"));
|
||||||
|
+ strarray_push_kv(&opt, "rdma_mtu", qdict_get_try_str(options, "rdma-mtu"));
|
||||||
|
+ strarray_push_kv(&opt, "client_writeback_allowed", (flags & BDRV_O_NOCACHE) ? "0" : "1");
|
||||||
|
+ client->proxy = vitastor_c_create_uring_json(opt.items, opt.len);
|
||||||
|
+ strarray_free(&opt);
|
||||||
|
+ if (client->proxy)
|
||||||
|
+ {
|
||||||
|
+ client->uring_eventfd = vitastor_c_uring_register_eventfd(client->proxy);
|
||||||
|
+ if (client->uring_eventfd < 0)
|
||||||
|
+ {
|
||||||
|
+ fprintf(stderr, "vitastor: failed to create io_uring eventfd: %s\n", strerror(errno));
|
||||||
|
+ error_setg(errp, "failed to create io_uring eventfd");
|
||||||
|
+ vitastor_close(bs);
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+ universal_aio_set_fd_handler(client->ctx, client->uring_eventfd, vitastor_uring_handler, NULL, client);
|
||||||
|
+ }
|
||||||
|
+ else
|
||||||
|
+ {
|
||||||
|
+ // Writeback cache is unusable without io_uring because the client can't correctly flush on exit
|
||||||
|
+ fprintf(stderr, "vitastor: failed to create io_uring: %s - I/O will be slower%s\n",
|
||||||
|
+ strerror(errno), (flags & BDRV_O_NOCACHE ? "" : " and writeback cache will be disabled"));
|
||||||
|
+#endif
|
||||||
|
+ client->uring_eventfd = -1;
|
||||||
|
+ client->proxy = vitastor_c_create_qemu(
|
||||||
|
+ vitastor_aio_set_fd_handler, client, client->config_path, client->etcd_host, client->etcd_prefix,
|
||||||
|
+ client->use_rdma, client->rdma_device, client->rdma_port_num, client->rdma_gid_index, client->rdma_mtu, 0
|
||||||
|
+ );
|
||||||
|
+#if defined VITASTOR_C_API_VERSION && VITASTOR_C_API_VERSION >= 2
|
||||||
|
+ }
|
||||||
|
+#endif
|
||||||
+ image = client->image = g_strdup(qdict_get_try_str(options, "image"));
|
+ image = client->image = g_strdup(qdict_get_try_str(options, "image"));
|
||||||
+ client->readonly = (flags & BDRV_O_RDWR) ? 1 : 0;
|
+ client->readonly = (flags & BDRV_O_RDWR) ? 1 : 0;
|
||||||
+ // Get image metadata (size and readonly flag) or just wait until the client is ready
|
+ // Get image metadata (size and readonly flag) or just wait until the client is ready
|
||||||
|
@ -461,7 +696,13 @@ Index: a/block/vitastor.c
|
||||||
+ }
|
+ }
|
||||||
+ else
|
+ else
|
||||||
+ {
|
+ {
|
||||||
|
+#if QEMU_VERSION_MAJOR >= 8
|
||||||
|
+ aio_co_enter(bdrv_get_aio_context(bs), qemu_coroutine_create((void(*)(void*))vitastor_co_get_metadata, &task));
|
||||||
|
+#elif QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 9 || QEMU_VERSION_MAJOR >= 3
|
||||||
+ bdrv_coroutine_enter(bs, qemu_coroutine_create((void(*)(void*))vitastor_co_get_metadata, &task));
|
+ bdrv_coroutine_enter(bs, qemu_coroutine_create((void(*)(void*))vitastor_co_get_metadata, &task));
|
||||||
|
+#else
|
||||||
|
+ qemu_coroutine_enter(qemu_coroutine_create((void(*)(void*))vitastor_co_get_metadata, &task));
|
||||||
|
+#endif
|
||||||
+ BDRV_POLL_WHILE(bs, !task.complete);
|
+ BDRV_POLL_WHILE(bs, !task.complete);
|
||||||
+ }
|
+ }
|
||||||
+ client->image = image;
|
+ client->image = image;
|
||||||
|
@ -500,6 +741,10 @@ Index: a/block/vitastor.c
|
||||||
+ return -1;
|
+ return -1;
|
||||||
+ }
|
+ }
|
||||||
+ bs->total_sectors = client->size / BDRV_SECTOR_SIZE;
|
+ bs->total_sectors = client->size / BDRV_SECTOR_SIZE;
|
||||||
|
+#if QEMU_VERSION_MAJOR > 5 || QEMU_VERSION_MAJOR == 5 && QEMU_VERSION_MINOR >= 1
|
||||||
|
+ /* When extending regular files, we get zeros from the OS */
|
||||||
|
+ bs->supported_truncate_flags = BDRV_REQ_ZERO_WRITE;
|
||||||
|
+#endif
|
||||||
+ //client->aio_context = bdrv_get_aio_context(bs);
|
+ //client->aio_context = bdrv_get_aio_context(bs);
|
||||||
+ qdict_del(options, "use-rdma");
|
+ qdict_del(options, "use-rdma");
|
||||||
+ qdict_del(options, "rdma-mtu");
|
+ qdict_del(options, "rdma-mtu");
|
||||||
|
@ -521,6 +766,12 @@ Index: a/block/vitastor.c
|
||||||
+{
|
+{
|
||||||
+ VitastorClient *client = bs->opaque;
|
+ VitastorClient *client = bs->opaque;
|
||||||
+ vitastor_c_destroy(client->proxy);
|
+ vitastor_c_destroy(client->proxy);
|
||||||
|
+ if (client->fds)
|
||||||
|
+ {
|
||||||
|
+ free(client->fds);
|
||||||
|
+ client->fds = NULL;
|
||||||
|
+ client->fd_alloc = client->fd_count = 0;
|
||||||
|
+ }
|
||||||
+ qemu_mutex_destroy(&client->mutex);
|
+ qemu_mutex_destroy(&client->mutex);
|
||||||
+ if (client->config_path)
|
+ if (client->config_path)
|
||||||
+ g_free(client->config_path);
|
+ g_free(client->config_path);
|
||||||
|
@ -590,7 +841,11 @@ Index: a/block/vitastor.c
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ // TODO: Resize inode to <offset> bytes
|
+ // TODO: Resize inode to <offset> bytes
|
||||||
+ client->size = offset / BDRV_SECTOR_SIZE;
|
+#if QEMU_VERSION_MAJOR >= 4
|
||||||
|
+ client->size = exact || client->size < offset ? offset : client->size;
|
||||||
|
+#else
|
||||||
|
+ client->size = offset;
|
||||||
|
+#endif
|
||||||
+
|
+
|
||||||
+ return 0;
|
+ return 0;
|
||||||
+}
|
+}
|
||||||
|
@ -637,25 +892,44 @@ Index: a/block/vitastor.c
|
||||||
+ };
|
+ };
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void vitastor_co_generic_bh_cb(void *opaque, long retval)
|
+static void vitastor_co_generic_bh_cb(void *opaque)
|
||||||
+{
|
+{
|
||||||
+ VitastorRPC *task = opaque;
|
+ VitastorRPC *task = opaque;
|
||||||
+ task->ret = retval;
|
|
||||||
+ task->complete = 1;
|
+ task->complete = 1;
|
||||||
+ if (qemu_coroutine_self() != task->co)
|
+ if (qemu_coroutine_self() != task->co)
|
||||||
+ {
|
+ {
|
||||||
+#if QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR > 8
|
+#if QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR > 8
|
||||||
+ aio_co_wake(task->co);
|
+ aio_co_wake(task->co);
|
||||||
+#else
|
+#else
|
||||||
|
+#if QEMU_VERSION_MAJOR == 2
|
||||||
|
+ qemu_bh_delete(task->bh);
|
||||||
|
+#endif
|
||||||
+ qemu_coroutine_enter(task->co, NULL);
|
+ qemu_coroutine_enter(task->co, NULL);
|
||||||
+ qemu_aio_release(task);
|
+ qemu_aio_release(task);
|
||||||
+#endif
|
+#endif
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
+static void vitastor_co_generic_cb(void *opaque, long retval)
|
||||||
|
+{
|
||||||
|
+ VitastorRPC *task = opaque;
|
||||||
|
+ task->ret = retval;
|
||||||
|
+#if QEMU_VERSION_MAJOR > 4 || QEMU_VERSION_MAJOR == 4 && QEMU_VERSION_MINOR >= 2
|
||||||
|
+ replay_bh_schedule_oneshot_event(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+#elif QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 8
|
||||||
|
+ aio_bh_schedule_oneshot(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+#elif QEMU_VERSION_MAJOR >= 2
|
||||||
|
+ task->bh = aio_bh_new(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+ qemu_bh_schedule(task->bh);
|
||||||
|
+#else
|
||||||
|
+ task->bh = qemu_bh_new(vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+ qemu_bh_schedule(task->bh);
|
||||||
|
+#endif
|
||||||
|
+}
|
||||||
|
+
|
||||||
+static void vitastor_co_read_cb(void *opaque, long retval, uint64_t version)
|
+static void vitastor_co_read_cb(void *opaque, long retval, uint64_t version)
|
||||||
+{
|
+{
|
||||||
+ vitastor_co_generic_bh_cb(opaque, retval);
|
+ vitastor_co_generic_cb(opaque, retval);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn vitastor_co_preadv(BlockDriverState *bs,
|
+static int coroutine_fn vitastor_co_preadv(BlockDriverState *bs,
|
||||||
|
@ -674,6 +948,7 @@ Index: a/block/vitastor.c
|
||||||
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_read(client->proxy, inode, offset, bytes, iov->iov, iov->niov, vitastor_co_read_cb, &task);
|
+ vitastor_c_read(client->proxy, inode, offset, bytes, iov->iov, iov->niov, vitastor_co_read_cb, &task);
|
||||||
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
|
@ -706,7 +981,8 @@ Index: a/block/vitastor.c
|
||||||
+
|
+
|
||||||
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_write(client->proxy, inode, offset, bytes, 0, iov->iov, iov->niov, vitastor_co_generic_bh_cb, &task);
|
+ vitastor_c_write(client->proxy, inode, offset, bytes, 0, iov->iov, iov->niov, vitastor_co_generic_cb, &task);
|
||||||
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
|
@ -724,7 +1000,6 @@ Index: a/block/vitastor.c
|
||||||
+ VitastorRPC *task = opaque;
|
+ VitastorRPC *task = opaque;
|
||||||
+ VitastorClient *client = task->bs->opaque;
|
+ VitastorClient *client = task->bs->opaque;
|
||||||
+ task->ret = retval;
|
+ task->ret = retval;
|
||||||
+ task->complete = 1;
|
|
||||||
+ if (retval >= 0)
|
+ if (retval >= 0)
|
||||||
+ {
|
+ {
|
||||||
+ task->bitmap = bitmap;
|
+ task->bitmap = bitmap;
|
||||||
|
@ -736,15 +1011,17 @@ Index: a/block/vitastor.c
|
||||||
+ client->last_bitmap = bitmap;
|
+ client->last_bitmap = bitmap;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+ if (qemu_coroutine_self() != task->co)
|
+#if QEMU_VERSION_MAJOR > 4 || QEMU_VERSION_MAJOR == 4 && QEMU_VERSION_MINOR >= 2
|
||||||
+ {
|
+ replay_bh_schedule_oneshot_event(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
+#if QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR > 8
|
+#elif QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR >= 8
|
||||||
+ aio_co_wake(task->co);
|
+ aio_bh_schedule_oneshot(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+#elif QEMU_VERSION_MAJOR >= 2
|
||||||
|
+ task->bh = aio_bh_new(bdrv_get_aio_context(task->bs), vitastor_co_generic_bh_cb, opaque);
|
||||||
|
+ qemu_bh_schedule(task->bh);
|
||||||
+#else
|
+#else
|
||||||
+ qemu_coroutine_enter(task->co, NULL);
|
+ task->bh = qemu_bh_new(vitastor_co_generic_bh_cb, opaque);
|
||||||
+ qemu_aio_release(task);
|
+ qemu_bh_schedule(task->bh);
|
||||||
+#endif
|
+#endif
|
||||||
+ }
|
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn vitastor_co_block_status(
|
+static int coroutine_fn vitastor_co_block_status(
|
||||||
|
@ -785,6 +1062,7 @@ Index: a/block/vitastor.c
|
||||||
+ task.bitmap = client->last_bitmap = NULL;
|
+ task.bitmap = client->last_bitmap = NULL;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_read_bitmap(client->proxy, task.inode, task.offset, task.len, !client->skip_parents, vitastor_co_read_bitmap_cb, &task);
|
+ vitastor_c_read_bitmap(client->proxy, task.inode, task.offset, task.len, !client->skip_parents, vitastor_co_read_bitmap_cb, &task);
|
||||||
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
+ {
|
+ {
|
||||||
|
@ -870,7 +1148,8 @@ Index: a/block/vitastor.c
|
||||||
+ vitastor_co_init_task(bs, &task);
|
+ vitastor_co_init_task(bs, &task);
|
||||||
+
|
+
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_sync(client->proxy, vitastor_co_generic_bh_cb, &task);
|
+ vitastor_c_sync(client->proxy, vitastor_co_generic_cb, &task);
|
||||||
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
|
@ -925,8 +1204,13 @@ Index: a/block/vitastor.c
|
||||||
+ .bdrv_parse_filename = vitastor_parse_filename,
|
+ .bdrv_parse_filename = vitastor_parse_filename,
|
||||||
+
|
+
|
||||||
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
|
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
|
||||||
|
+#if QEMU_VERSION_MAJOR >= 8
|
||||||
|
+ .bdrv_co_get_info = vitastor_get_info,
|
||||||
|
+ .bdrv_co_getlength = vitastor_getlength,
|
||||||
|
+#else
|
||||||
+ .bdrv_get_info = vitastor_get_info,
|
+ .bdrv_get_info = vitastor_get_info,
|
||||||
+ .bdrv_getlength = vitastor_getlength,
|
+ .bdrv_getlength = vitastor_getlength,
|
||||||
|
+#endif
|
||||||
+#if QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR > 2
|
+#if QEMU_VERSION_MAJOR >= 3 || QEMU_VERSION_MAJOR == 2 && QEMU_VERSION_MINOR > 2
|
||||||
+ .bdrv_probe_blocksizes = vitastor_probe_blocksizes,
|
+ .bdrv_probe_blocksizes = vitastor_probe_blocksizes,
|
||||||
+#endif
|
+#endif
|
|
@ -14,10 +14,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/file-posix.c b/block/file-posix.c
|
diff --git a/block/file-posix.c b/block/file-posix.c
|
||||||
index dd295cfc6d..3ac5177cbb 100644
|
index 35684f7e21..43bc0bd520 100644
|
||||||
--- a/block/file-posix.c
|
--- a/block/file-posix.c
|
||||||
+++ b/block/file-posix.c
|
+++ b/block/file-posix.c
|
||||||
@@ -533,7 +533,7 @@ static QemuOptsList raw_runtime_opts = {
|
@@ -563,7 +563,7 @@ static QemuOptsList raw_runtime_opts = {
|
||||||
{
|
{
|
||||||
.name = "locking",
|
.name = "locking",
|
||||||
.type = QEMU_OPT_STRING,
|
.type = QEMU_OPT_STRING,
|
||||||
|
@ -26,7 +26,7 @@ index dd295cfc6d..3ac5177cbb 100644
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
.name = "pr-manager",
|
.name = "pr-manager",
|
||||||
@@ -631,7 +631,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
|
@@ -663,7 +663,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
|
||||||
s->use_lock = false;
|
s->use_lock = false;
|
||||||
break;
|
break;
|
||||||
case ON_OFF_AUTO_AUTO:
|
case ON_OFF_AUTO_AUTO:
|
||||||
|
|
|
@ -9,10 +9,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/include/net/net.h b/include/net/net.h
|
diff --git a/include/net/net.h b/include/net/net.h
|
||||||
index 5d1508081f..f665924193 100644
|
index b1f9b35fcc..096c0d52e4 100644
|
||||||
--- a/include/net/net.h
|
--- a/include/net/net.h
|
||||||
+++ b/include/net/net.h
|
+++ b/include/net/net.h
|
||||||
@@ -219,8 +219,8 @@ void netdev_add(QemuOpts *opts, Error **errp);
|
@@ -317,8 +317,8 @@ void netdev_add(QemuOpts *opts, Error **errp);
|
||||||
int net_hub_id_for_client(NetClientState *nc, int *id);
|
int net_hub_id_for_client(NetClientState *nc, int *id);
|
||||||
NetClientState *net_hub_port_find(int hub_id);
|
NetClientState *net_hub_port_find(int hub_id);
|
||||||
|
|
||||||
|
|
|
@ -10,10 +10,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
|
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
|
||||||
index 21b33fbe2e..32514193a9 100644
|
index 6b05738079..d82869900a 100644
|
||||||
--- a/target/i386/cpu.h
|
--- a/target/i386/cpu.h
|
||||||
+++ b/target/i386/cpu.h
|
+++ b/target/i386/cpu.h
|
||||||
@@ -2007,9 +2007,9 @@ uint64_t cpu_get_tsc(CPUX86State *env);
|
@@ -2291,9 +2291,9 @@ uint64_t cpu_get_tsc(CPUX86State *env);
|
||||||
#define CPU_RESOLVING_TYPE TYPE_X86_CPU
|
#define CPU_RESOLVING_TYPE TYPE_X86_CPU
|
||||||
|
|
||||||
#ifdef TARGET_X86_64
|
#ifdef TARGET_X86_64
|
||||||
|
@ -24,4 +24,4 @@ index 21b33fbe2e..32514193a9 100644
|
||||||
+#define TARGET_DEFAULT_CPU_TYPE X86_CPU_TYPE_NAME("kvm32")
|
+#define TARGET_DEFAULT_CPU_TYPE X86_CPU_TYPE_NAME("kvm32")
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#define cpu_signal_handler cpu_x86_signal_handler
|
#define cpu_list x86_cpu_list
|
||||||
|
|
|
@ -9,10 +9,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 9 insertions(+), 6 deletions(-)
|
1 file changed, 9 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
||||||
index 0371055e6c..840cf56923 100644
|
index 15be640286..ea20e6153c 100644
|
||||||
--- a/ui/spice-core.c
|
--- a/ui/spice-core.c
|
||||||
+++ b/ui/spice-core.c
|
+++ b/ui/spice-core.c
|
||||||
@@ -694,32 +694,35 @@ static void qemu_spice_init(void)
|
@@ -690,32 +690,35 @@ static void qemu_spice_init(void)
|
||||||
|
|
||||||
if (tls_port) {
|
if (tls_port) {
|
||||||
x509_dir = qemu_opt_get(opts, "x509-dir");
|
x509_dir = qemu_opt_get(opts, "x509-dir");
|
||||||
|
|
|
@ -9,10 +9,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 11 insertions(+), 4 deletions(-)
|
1 file changed, 11 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/gluster.c b/block/gluster.c
|
diff --git a/block/gluster.c b/block/gluster.c
|
||||||
index e8ee14c8e9..3eb6a05500 100644
|
index cc74af06dc..3ba9bbfa5e 100644
|
||||||
--- a/block/gluster.c
|
--- a/block/gluster.c
|
||||||
+++ b/block/gluster.c
|
+++ b/block/gluster.c
|
||||||
@@ -42,7 +42,7 @@
|
@@ -43,7 +43,7 @@
|
||||||
#define GLUSTER_DEBUG_DEFAULT 4
|
#define GLUSTER_DEBUG_DEFAULT 4
|
||||||
#define GLUSTER_DEBUG_MAX 9
|
#define GLUSTER_DEBUG_MAX 9
|
||||||
#define GLUSTER_OPT_LOGFILE "logfile"
|
#define GLUSTER_OPT_LOGFILE "logfile"
|
||||||
|
@ -21,15 +21,15 @@ index e8ee14c8e9..3eb6a05500 100644
|
||||||
/*
|
/*
|
||||||
* Several versions of GlusterFS (3.12? -> 6.0.1) fail when the transfer size
|
* Several versions of GlusterFS (3.12? -> 6.0.1) fail when the transfer size
|
||||||
* is greater or equal to 1024 MiB, so we are limiting the transfer size to 512
|
* is greater or equal to 1024 MiB, so we are limiting the transfer size to 512
|
||||||
@@ -424,6 +424,7 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
@@ -425,6 +425,7 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
||||||
int old_errno;
|
int old_errno;
|
||||||
SocketAddressList *server;
|
SocketAddressList *server;
|
||||||
unsigned long long port;
|
uint64_t port;
|
||||||
+ const char *logfile;
|
+ const char *logfile;
|
||||||
|
|
||||||
glfs = glfs_find_preopened(gconf->volume);
|
glfs = glfs_find_preopened(gconf->volume);
|
||||||
if (glfs) {
|
if (glfs) {
|
||||||
@@ -466,9 +467,15 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
@@ -467,9 +468,15 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -18,10 +18,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+)
|
1 file changed, 2 insertions(+)
|
||||||
|
|
||||||
diff --git a/block/rbd.c b/block/rbd.c
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
index dcf82b15b8..feeec452f0 100644
|
index 84bb2fa5d7..63f60d41be 100644
|
||||||
--- a/block/rbd.c
|
--- a/block/rbd.c
|
||||||
+++ b/block/rbd.c
|
+++ b/block/rbd.c
|
||||||
@@ -814,6 +814,8 @@ static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
@@ -963,6 +963,8 @@ static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
||||||
rados_conf_set(*cluster, "rbd_cache", "false");
|
rados_conf_set(*cluster, "rbd_cache", "false");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 9 insertions(+), 1 deletion(-)
|
1 file changed, 9 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/block/gluster.c b/block/gluster.c
|
diff --git a/block/gluster.c b/block/gluster.c
|
||||||
index 3eb6a05500..b612918ee8 100644
|
index 3ba9bbfa5e..34936eb855 100644
|
||||||
--- a/block/gluster.c
|
--- a/block/gluster.c
|
||||||
+++ b/block/gluster.c
|
+++ b/block/gluster.c
|
||||||
@@ -57,6 +57,7 @@ typedef struct GlusterAIOCB {
|
@@ -58,6 +58,7 @@ typedef struct GlusterAIOCB {
|
||||||
int ret;
|
int ret;
|
||||||
Coroutine *coroutine;
|
Coroutine *coroutine;
|
||||||
AioContext *aio_context;
|
AioContext *aio_context;
|
||||||
|
@ -27,7 +27,7 @@ index 3eb6a05500..b612918ee8 100644
|
||||||
} GlusterAIOCB;
|
} GlusterAIOCB;
|
||||||
|
|
||||||
typedef struct BDRVGlusterState {
|
typedef struct BDRVGlusterState {
|
||||||
@@ -752,8 +753,10 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret,
|
@@ -753,8 +754,10 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret,
|
||||||
acb->ret = 0; /* Success */
|
acb->ret = 0; /* Success */
|
||||||
} else if (ret < 0) {
|
} else if (ret < 0) {
|
||||||
acb->ret = -errno; /* Read/Write failed */
|
acb->ret = -errno; /* Read/Write failed */
|
||||||
|
@ -39,15 +39,15 @@ index 3eb6a05500..b612918ee8 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
aio_co_schedule(acb->aio_context, acb->coroutine);
|
aio_co_schedule(acb->aio_context, acb->coroutine);
|
||||||
@@ -1021,6 +1024,7 @@ static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
|
@@ -1023,6 +1026,7 @@ static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
|
||||||
acb.ret = 0;
|
acb.ret = 0;
|
||||||
acb.coroutine = qemu_coroutine_self();
|
acb.coroutine = qemu_coroutine_self();
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
+ acb.is_write = true;
|
+ acb.is_write = true;
|
||||||
|
|
||||||
ret = glfs_zerofill_async(s->fd, offset, size, gluster_finish_aiocb, &acb);
|
ret = glfs_zerofill_async(s->fd, offset, bytes, gluster_finish_aiocb, &acb);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
@@ -1202,9 +1206,11 @@ static coroutine_fn int qemu_gluster_co_rw(BlockDriverState *bs,
|
@@ -1203,9 +1207,11 @@ static coroutine_fn int qemu_gluster_co_rw(BlockDriverState *bs,
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
|
|
||||||
if (write) {
|
if (write) {
|
||||||
|
@ -67,11 +67,11 @@ index 3eb6a05500..b612918ee8 100644
|
||||||
|
|
||||||
ret = glfs_fsync_async(s->fd, gluster_finish_aiocb, &acb);
|
ret = glfs_fsync_async(s->fd, gluster_finish_aiocb, &acb);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
@@ -1314,6 +1321,7 @@ static coroutine_fn int qemu_gluster_co_pdiscard(BlockDriverState *bs,
|
@@ -1316,6 +1323,7 @@ static coroutine_fn int qemu_gluster_co_pdiscard(BlockDriverState *bs,
|
||||||
acb.ret = 0;
|
acb.ret = 0;
|
||||||
acb.coroutine = qemu_coroutine_self();
|
acb.coroutine = qemu_coroutine_self();
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
+ acb.is_write = true;
|
+ acb.is_write = true;
|
||||||
|
|
||||||
ret = glfs_discard_async(s->fd, offset, size, gluster_finish_aiocb, &acb);
|
ret = glfs_discard_async(s->fd, offset, bytes, gluster_finish_aiocb, &acb);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
|
@ -1,88 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
||||||
Date: Mon, 6 Apr 2020 12:16:37 +0200
|
|
||||||
Subject: [PATCH] PVE: [Up] qmp: add get_link_status
|
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
net/net.c | 27 +++++++++++++++++++++++++++
|
|
||||||
qapi/net.json | 15 +++++++++++++++
|
|
||||||
qapi/pragma.json | 1 +
|
|
||||||
3 files changed, 43 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/net/net.c b/net/net.c
|
|
||||||
index 76bbb7c31b..82e0a768b4 100644
|
|
||||||
--- a/net/net.c
|
|
||||||
+++ b/net/net.c
|
|
||||||
@@ -1314,6 +1314,33 @@ void hmp_info_network(Monitor *mon, const QDict *qdict)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
+int64_t qmp_get_link_status(const char *name, Error **errp)
|
|
||||||
+{
|
|
||||||
+ NetClientState *ncs[MAX_QUEUE_NUM];
|
|
||||||
+ NetClientState *nc;
|
|
||||||
+ int queues;
|
|
||||||
+ bool ret;
|
|
||||||
+
|
|
||||||
+ queues = qemu_find_net_clients_except(name, ncs,
|
|
||||||
+ NET_CLIENT_DRIVER__MAX,
|
|
||||||
+ MAX_QUEUE_NUM);
|
|
||||||
+
|
|
||||||
+ if (queues == 0) {
|
|
||||||
+ error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
|
|
||||||
+ "Device '%s' not found", name);
|
|
||||||
+ return (int64_t) -1;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ nc = ncs[0];
|
|
||||||
+ ret = ncs[0]->link_down;
|
|
||||||
+
|
|
||||||
+ if (nc->peer->info->type == NET_CLIENT_DRIVER_NIC) {
|
|
||||||
+ ret = ncs[0]->peer->link_down;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ return (int64_t) ret ? 0 : 1;
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
void colo_notify_filters_event(int event, Error **errp)
|
|
||||||
{
|
|
||||||
NetClientState *nc;
|
|
||||||
diff --git a/qapi/net.json b/qapi/net.json
|
|
||||||
index 7fab2e7cd8..74c9a6109e 100644
|
|
||||||
--- a/qapi/net.json
|
|
||||||
+++ b/qapi/net.json
|
|
||||||
@@ -35,6 +35,21 @@
|
|
||||||
##
|
|
||||||
{ 'command': 'set_link', 'data': {'name': 'str', 'up': 'bool'} }
|
|
||||||
|
|
||||||
+##
|
|
||||||
+# @get_link_status:
|
|
||||||
+#
|
|
||||||
+# Get the current link state of the nics or nic.
|
|
||||||
+#
|
|
||||||
+# @name: name of the nic you get the state of
|
|
||||||
+#
|
|
||||||
+# Return: If link is up 1
|
|
||||||
+# If link is down 0
|
|
||||||
+# If an error occure an empty string.
|
|
||||||
+#
|
|
||||||
+# Notes: this is an Proxmox VE extension and not offical part of Qemu.
|
|
||||||
+##
|
|
||||||
+{ 'command': 'get_link_status', 'data': {'name': 'str'} , 'returns': 'int' }
|
|
||||||
+
|
|
||||||
##
|
|
||||||
# @netdev_add:
|
|
||||||
#
|
|
||||||
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
|
||||||
index 3bc0335d1f..7c91ea3685 100644
|
|
||||||
--- a/qapi/pragma.json
|
|
||||||
+++ b/qapi/pragma.json
|
|
||||||
@@ -22,6 +22,7 @@
|
|
||||||
'system_reset',
|
|
||||||
'system_wakeup' ],
|
|
||||||
'command-returns-exceptions': [
|
|
||||||
+ 'get_link_status',
|
|
||||||
'human-monitor-command',
|
|
||||||
'qom-get',
|
|
||||||
'query-tpm-models',
|
|
|
@ -9,10 +9,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/qemu-img.c b/qemu-img.c
|
diff --git a/qemu-img.c b/qemu-img.c
|
||||||
index 908fd0cce5..5dc1d0a2ca 100644
|
index 7668f86769..2575e97b43 100644
|
||||||
--- a/qemu-img.c
|
--- a/qemu-img.c
|
||||||
+++ b/qemu-img.c
|
+++ b/qemu-img.c
|
||||||
@@ -2977,7 +2977,8 @@ static int img_info(int argc, char **argv)
|
@@ -3075,7 +3075,8 @@ static int img_info(int argc, char **argv)
|
||||||
list = collect_image_info_list(image_opts, filename, fmt, chain,
|
list = collect_image_info_list(image_opts, filename, fmt, chain,
|
||||||
force_share);
|
force_share);
|
||||||
if (!list) {
|
if (!list) {
|
|
@ -31,16 +31,17 @@ override the output file's size.
|
||||||
|
|
||||||
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
qemu-img-cmds.hx | 4 +-
|
qemu-img-cmds.hx | 4 +-
|
||||||
qemu-img.c | 187 +++++++++++++++++++++++++++++------------------
|
qemu-img.c | 202 ++++++++++++++++++++++++++++++-----------------
|
||||||
2 files changed, 119 insertions(+), 72 deletions(-)
|
2 files changed, 133 insertions(+), 73 deletions(-)
|
||||||
|
|
||||||
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
|
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
|
||||||
index b3620f29e5..e70ef3dc91 100644
|
index c9dd70a892..048788b23d 100644
|
||||||
--- a/qemu-img-cmds.hx
|
--- a/qemu-img-cmds.hx
|
||||||
+++ b/qemu-img-cmds.hx
|
+++ b/qemu-img-cmds.hx
|
||||||
@@ -58,9 +58,9 @@ SRST
|
@@ -60,9 +60,9 @@ SRST
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
DEF("dd", img_dd,
|
DEF("dd", img_dd,
|
||||||
|
@ -53,10 +54,10 @@ index b3620f29e5..e70ef3dc91 100644
|
||||||
|
|
||||||
DEF("info", img_info,
|
DEF("info", img_info,
|
||||||
diff --git a/qemu-img.c b/qemu-img.c
|
diff --git a/qemu-img.c b/qemu-img.c
|
||||||
index 5dc1d0a2ca..f773182bd0 100644
|
index 2575e97b43..8ec68b346f 100644
|
||||||
--- a/qemu-img.c
|
--- a/qemu-img.c
|
||||||
+++ b/qemu-img.c
|
+++ b/qemu-img.c
|
||||||
@@ -4793,10 +4793,12 @@ static int img_bitmap(int argc, char **argv)
|
@@ -4993,10 +4993,12 @@ static int img_bitmap(int argc, char **argv)
|
||||||
#define C_IF 04
|
#define C_IF 04
|
||||||
#define C_OF 010
|
#define C_OF 010
|
||||||
#define C_SKIP 020
|
#define C_SKIP 020
|
||||||
|
@ -69,7 +70,7 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
};
|
};
|
||||||
|
|
||||||
struct DdIo {
|
struct DdIo {
|
||||||
@@ -4872,6 +4874,19 @@ static int img_dd_skip(const char *arg,
|
@@ -5072,6 +5074,19 @@ static int img_dd_skip(const char *arg,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -89,7 +90,7 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
static int img_dd(int argc, char **argv)
|
static int img_dd(int argc, char **argv)
|
||||||
{
|
{
|
||||||
int ret = 0;
|
int ret = 0;
|
||||||
@@ -4912,6 +4927,7 @@ static int img_dd(int argc, char **argv)
|
@@ -5112,6 +5127,7 @@ static int img_dd(int argc, char **argv)
|
||||||
{ "if", img_dd_if, C_IF },
|
{ "if", img_dd_if, C_IF },
|
||||||
{ "of", img_dd_of, C_OF },
|
{ "of", img_dd_of, C_OF },
|
||||||
{ "skip", img_dd_skip, C_SKIP },
|
{ "skip", img_dd_skip, C_SKIP },
|
||||||
|
@ -97,7 +98,7 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
{ NULL, NULL, 0 }
|
{ NULL, NULL, 0 }
|
||||||
};
|
};
|
||||||
const struct option long_options[] = {
|
const struct option long_options[] = {
|
||||||
@@ -4987,91 +5003,112 @@ static int img_dd(int argc, char **argv)
|
@@ -5187,91 +5203,112 @@ static int img_dd(int argc, char **argv)
|
||||||
arg = NULL;
|
arg = NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -134,11 +135,7 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
- error_report_err(local_err);
|
- error_report_err(local_err);
|
||||||
- ret = -1;
|
- ret = -1;
|
||||||
- goto out;
|
- goto out;
|
||||||
+ if (!blk1) {
|
- }
|
||||||
+ ret = -1;
|
|
||||||
+ goto out;
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
- if (!drv->create_opts) {
|
- if (!drv->create_opts) {
|
||||||
- error_report("Format driver '%s' does not support image creation",
|
- error_report("Format driver '%s' does not support image creation",
|
||||||
- drv->format_name);
|
- drv->format_name);
|
||||||
|
@ -150,7 +147,11 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
- proto_drv->format_name);
|
- proto_drv->format_name);
|
||||||
- ret = -1;
|
- ret = -1;
|
||||||
- goto out;
|
- goto out;
|
||||||
- }
|
+ if (!blk1) {
|
||||||
|
+ ret = -1;
|
||||||
|
+ goto out;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
- create_opts = qemu_opts_append(create_opts, drv->create_opts);
|
- create_opts = qemu_opts_append(create_opts, drv->create_opts);
|
||||||
- create_opts = qemu_opts_append(create_opts, proto_drv->create_opts);
|
- create_opts = qemu_opts_append(create_opts, proto_drv->create_opts);
|
||||||
-
|
-
|
||||||
|
@ -274,41 +275,54 @@ index 5dc1d0a2ca..f773182bd0 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
if (dd.flags & C_SKIP && (in.offset > INT64_MAX / in.bsz ||
|
if (dd.flags & C_SKIP && (in.offset > INT64_MAX / in.bsz ||
|
||||||
@@ -5089,11 +5126,17 @@ static int img_dd(int argc, char **argv)
|
@@ -5288,20 +5325,43 @@ static int img_dd(int argc, char **argv)
|
||||||
|
in.buf = g_new(uint8_t, in.bsz);
|
||||||
|
|
||||||
for (out_pos = 0; in_pos < size; block_count++) {
|
for (out_pos = 0; in_pos < size; ) {
|
||||||
int in_ret, out_ret;
|
+ int in_ret, out_ret;
|
||||||
|
int bytes = (in_pos + in.bsz > size) ? size - in_pos : in.bsz;
|
||||||
-
|
-
|
||||||
- if (in_pos + in.bsz > size) {
|
- ret = blk_pread(blk1, in_pos, bytes, in.buf, 0);
|
||||||
- in_ret = blk_pread(blk1, in_pos, in.buf, size - in_pos);
|
- if (ret < 0) {
|
||||||
+ size_t in_bsz = in_pos + in.bsz > size ? size - in_pos : in.bsz;
|
|
||||||
+ if (blk1) {
|
+ if (blk1) {
|
||||||
+ in_ret = blk_pread(blk1, in_pos, in.buf, in_bsz);
|
+ in_ret = blk_pread(blk1, in_pos, bytes, in.buf, 0);
|
||||||
} else {
|
+ if (in_ret == 0) {
|
||||||
- in_ret = blk_pread(blk1, in_pos, in.buf, in.bsz);
|
+ in_ret = bytes;
|
||||||
+ in_ret = read(STDIN_FILENO, in.buf, in_bsz);
|
+ }
|
||||||
|
+ } else {
|
||||||
|
+ in_ret = read(STDIN_FILENO, in.buf, bytes);
|
||||||
+ if (in_ret == 0) {
|
+ if (in_ret == 0) {
|
||||||
+ /* early EOF is considered an error */
|
+ /* early EOF is considered an error */
|
||||||
+ error_report("Input ended unexpectedly");
|
+ error_report("Input ended unexpectedly");
|
||||||
+ ret = -1;
|
+ ret = -1;
|
||||||
+ goto out;
|
+ goto out;
|
||||||
+ }
|
+ }
|
||||||
}
|
+ }
|
||||||
if (in_ret < 0) {
|
+ if (in_ret < 0) {
|
||||||
error_report("error while reading from input image file: %s",
|
error_report("error while reading from input image file: %s",
|
||||||
@@ -5103,9 +5146,13 @@ static int img_dd(int argc, char **argv)
|
- strerror(-ret));
|
||||||
|
+ strerror(-in_ret));
|
||||||
|
+ ret = -1;
|
||||||
|
goto out;
|
||||||
}
|
}
|
||||||
in_pos += in_ret;
|
in_pos += bytes;
|
||||||
|
|
||||||
- out_ret = blk_pwrite(blk2, out_pos, in.buf, in_ret, 0);
|
- ret = blk_pwrite(blk2, out_pos, bytes, in.buf, 0);
|
||||||
|
- if (ret < 0) {
|
||||||
+ if (blk2) {
|
+ if (blk2) {
|
||||||
+ out_ret = blk_pwrite(blk2, out_pos, in.buf, in_ret, 0);
|
+ out_ret = blk_pwrite(blk2, out_pos, in_ret, in.buf, 0);
|
||||||
|
+ if (out_ret == 0) {
|
||||||
|
+ out_ret = in_ret;
|
||||||
|
+ }
|
||||||
+ } else {
|
+ } else {
|
||||||
+ out_ret = write(STDOUT_FILENO, in.buf, in_ret);
|
+ out_ret = write(STDOUT_FILENO, in.buf, in_ret);
|
||||||
+ }
|
+ }
|
||||||
|
+
|
||||||
- if (out_ret < 0) {
|
|
||||||
+ if (out_ret != in_ret) {
|
+ if (out_ret != in_ret) {
|
||||||
error_report("error while writing to output image file: %s",
|
error_report("error while writing to output image file: %s",
|
||||||
strerror(-out_ret));
|
- strerror(-ret));
|
||||||
ret = -1;
|
+ strerror(-out_ret));
|
||||||
|
+ ret = -1;
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
out_pos += bytes;
|
|
@ -10,15 +10,16 @@ an expected end of input.
|
||||||
|
|
||||||
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
qemu-img.c | 28 +++++++++++++++++++++++++---
|
qemu-img.c | 28 +++++++++++++++++++++++++---
|
||||||
1 file changed, 25 insertions(+), 3 deletions(-)
|
1 file changed, 25 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
diff --git a/qemu-img.c b/qemu-img.c
|
diff --git a/qemu-img.c b/qemu-img.c
|
||||||
index f773182bd0..98a6562364 100644
|
index 8ec68b346f..b98184bba1 100644
|
||||||
--- a/qemu-img.c
|
--- a/qemu-img.c
|
||||||
+++ b/qemu-img.c
|
+++ b/qemu-img.c
|
||||||
@@ -4794,11 +4794,13 @@ static int img_bitmap(int argc, char **argv)
|
@@ -4994,11 +4994,13 @@ static int img_bitmap(int argc, char **argv)
|
||||||
#define C_OF 010
|
#define C_OF 010
|
||||||
#define C_SKIP 020
|
#define C_SKIP 020
|
||||||
#define C_OSIZE 040
|
#define C_OSIZE 040
|
||||||
|
@ -32,7 +33,7 @@ index f773182bd0..98a6562364 100644
|
||||||
};
|
};
|
||||||
|
|
||||||
struct DdIo {
|
struct DdIo {
|
||||||
@@ -4887,6 +4889,19 @@ static int img_dd_osize(const char *arg,
|
@@ -5087,6 +5089,19 @@ static int img_dd_osize(const char *arg,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -52,13 +53,13 @@ index f773182bd0..98a6562364 100644
|
||||||
static int img_dd(int argc, char **argv)
|
static int img_dd(int argc, char **argv)
|
||||||
{
|
{
|
||||||
int ret = 0;
|
int ret = 0;
|
||||||
@@ -4901,12 +4916,14 @@ static int img_dd(int argc, char **argv)
|
@@ -5101,12 +5116,14 @@ static int img_dd(int argc, char **argv)
|
||||||
int c, i;
|
int c, i;
|
||||||
const char *out_fmt = "raw";
|
const char *out_fmt = "raw";
|
||||||
const char *fmt = NULL;
|
const char *fmt = NULL;
|
||||||
- int64_t size = 0;
|
- int64_t size = 0;
|
||||||
+ int64_t size = 0, readsize = 0;
|
+ int64_t size = 0, readsize = 0;
|
||||||
int64_t block_count = 0, out_pos, in_pos;
|
int64_t out_pos, in_pos;
|
||||||
bool force_share = false;
|
bool force_share = false;
|
||||||
struct DdInfo dd = {
|
struct DdInfo dd = {
|
||||||
.flags = 0,
|
.flags = 0,
|
||||||
|
@ -68,7 +69,7 @@ index f773182bd0..98a6562364 100644
|
||||||
};
|
};
|
||||||
struct DdIo in = {
|
struct DdIo in = {
|
||||||
.bsz = 512, /* Block size is by default 512 bytes */
|
.bsz = 512, /* Block size is by default 512 bytes */
|
||||||
@@ -4928,6 +4945,7 @@ static int img_dd(int argc, char **argv)
|
@@ -5128,6 +5145,7 @@ static int img_dd(int argc, char **argv)
|
||||||
{ "of", img_dd_of, C_OF },
|
{ "of", img_dd_of, C_OF },
|
||||||
{ "skip", img_dd_skip, C_SKIP },
|
{ "skip", img_dd_skip, C_SKIP },
|
||||||
{ "osize", img_dd_osize, C_OSIZE },
|
{ "osize", img_dd_osize, C_OSIZE },
|
||||||
|
@ -76,20 +77,22 @@ index f773182bd0..98a6562364 100644
|
||||||
{ NULL, NULL, 0 }
|
{ NULL, NULL, 0 }
|
||||||
};
|
};
|
||||||
const struct option long_options[] = {
|
const struct option long_options[] = {
|
||||||
@@ -5124,14 +5142,18 @@ static int img_dd(int argc, char **argv)
|
@@ -5324,9 +5342,10 @@ static int img_dd(int argc, char **argv)
|
||||||
|
|
||||||
in.buf = g_new(uint8_t, in.bsz);
|
in.buf = g_new(uint8_t, in.bsz);
|
||||||
|
|
||||||
- for (out_pos = 0; in_pos < size; block_count++) {
|
- for (out_pos = 0; in_pos < size; ) {
|
||||||
+ readsize = (dd.isize > 0) ? dd.isize : size;
|
+ readsize = (dd.isize > 0) ? dd.isize : size;
|
||||||
+ for (out_pos = 0; in_pos < readsize; block_count++) {
|
+ for (out_pos = 0; in_pos < readsize; ) {
|
||||||
int in_ret, out_ret;
|
int in_ret, out_ret;
|
||||||
- size_t in_bsz = in_pos + in.bsz > size ? size - in_pos : in.bsz;
|
- int bytes = (in_pos + in.bsz > size) ? size - in_pos : in.bsz;
|
||||||
+ size_t in_bsz = in_pos + in.bsz > readsize ? readsize - in_pos : in.bsz;
|
+ int bytes = (in_pos + in.bsz > readsize) ? readsize - in_pos : in.bsz;
|
||||||
if (blk1) {
|
if (blk1) {
|
||||||
in_ret = blk_pread(blk1, in_pos, in.buf, in_bsz);
|
in_ret = blk_pread(blk1, in_pos, bytes, in.buf, 0);
|
||||||
|
if (in_ret == 0) {
|
||||||
|
@@ -5335,6 +5354,9 @@ static int img_dd(int argc, char **argv)
|
||||||
} else {
|
} else {
|
||||||
in_ret = read(STDIN_FILENO, in.buf, in_bsz);
|
in_ret = read(STDIN_FILENO, in.buf, bytes);
|
||||||
if (in_ret == 0) {
|
if (in_ret == 0) {
|
||||||
+ if (dd.isize == 0) {
|
+ if (dd.isize == 0) {
|
||||||
+ goto out;
|
+ goto out;
|
|
@ -0,0 +1,121 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Alexandre Derumier <aderumier@odiso.com>
|
||||||
|
Date: Mon, 6 Apr 2020 12:16:42 +0200
|
||||||
|
Subject: [PATCH] PVE: [Up] qemu-img dd: add -n skip_create
|
||||||
|
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: fix getopt-string + add documentation]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
docs/tools/qemu-img.rst | 11 ++++++++++-
|
||||||
|
qemu-img-cmds.hx | 4 ++--
|
||||||
|
qemu-img.c | 23 ++++++++++++++---------
|
||||||
|
3 files changed, 26 insertions(+), 12 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
|
||||||
|
index 3653adb963..d83e8fb3c0 100644
|
||||||
|
--- a/docs/tools/qemu-img.rst
|
||||||
|
+++ b/docs/tools/qemu-img.rst
|
||||||
|
@@ -212,6 +212,10 @@ Parameters to convert subcommand:
|
||||||
|
|
||||||
|
Parameters to dd subcommand:
|
||||||
|
|
||||||
|
+.. option:: -n
|
||||||
|
+
|
||||||
|
+ Skip the creation of the target volume
|
||||||
|
+
|
||||||
|
.. program:: qemu-img-dd
|
||||||
|
|
||||||
|
.. option:: bs=BLOCK_SIZE
|
||||||
|
@@ -492,7 +496,7 @@ Command description:
|
||||||
|
it doesn't need to be specified separately in this case.
|
||||||
|
|
||||||
|
|
||||||
|
-.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] if=INPUT of=OUTPUT
|
||||||
|
+.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] if=INPUT of=OUTPUT
|
||||||
|
|
||||||
|
dd copies from *INPUT* file to *OUTPUT* file converting it from
|
||||||
|
*FMT* format to *OUTPUT_FMT* format.
|
||||||
|
@@ -503,6 +507,11 @@ Command description:
|
||||||
|
|
||||||
|
The size syntax is similar to :manpage:`dd(1)`'s size syntax.
|
||||||
|
|
||||||
|
+ If the ``-n`` option is specified, the target volume creation will be
|
||||||
|
+ skipped. This is useful for formats such as ``rbd`` if the target
|
||||||
|
+ volume has already been created with site specific options that cannot
|
||||||
|
+ be supplied through ``qemu-img``.
|
||||||
|
+
|
||||||
|
.. option:: info [--object OBJECTDEF] [--image-opts] [-f FMT] [--output=OFMT] [--backing-chain] [-U] FILENAME
|
||||||
|
|
||||||
|
Give information about the disk image *FILENAME*. Use it in
|
||||||
|
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
|
||||||
|
index 048788b23d..0b29a67a06 100644
|
||||||
|
--- a/qemu-img-cmds.hx
|
||||||
|
+++ b/qemu-img-cmds.hx
|
||||||
|
@@ -60,9 +60,9 @@ SRST
|
||||||
|
ERST
|
||||||
|
|
||||||
|
DEF("dd", img_dd,
|
||||||
|
- "dd [--image-opts] [-U] [-f fmt] [-O output_fmt] [bs=block_size] [count=blocks] [skip=blocks] [osize=output_size] if=input of=output")
|
||||||
|
+ "dd [--image-opts] [-U] [-f fmt] [-O output_fmt] [-n] [bs=block_size] [count=blocks] [skip=blocks] [osize=output_size] if=input of=output")
|
||||||
|
SRST
|
||||||
|
-.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] [osize=OUTPUT_SIZE] if=INPUT of=OUTPUT
|
||||||
|
+.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] [osize=OUTPUT_SIZE] if=INPUT of=OUTPUT
|
||||||
|
ERST
|
||||||
|
|
||||||
|
DEF("info", img_info,
|
||||||
|
diff --git a/qemu-img.c b/qemu-img.c
|
||||||
|
index b98184bba1..6fc8384f64 100644
|
||||||
|
--- a/qemu-img.c
|
||||||
|
+++ b/qemu-img.c
|
||||||
|
@@ -5118,7 +5118,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
const char *fmt = NULL;
|
||||||
|
int64_t size = 0, readsize = 0;
|
||||||
|
int64_t out_pos, in_pos;
|
||||||
|
- bool force_share = false;
|
||||||
|
+ bool force_share = false, skip_create = false;
|
||||||
|
struct DdInfo dd = {
|
||||||
|
.flags = 0,
|
||||||
|
.count = 0,
|
||||||
|
@@ -5156,7 +5156,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
{ 0, 0, 0, 0 }
|
||||||
|
};
|
||||||
|
|
||||||
|
- while ((c = getopt_long(argc, argv, ":hf:O:U", long_options, NULL))) {
|
||||||
|
+ while ((c = getopt_long(argc, argv, ":hf:O:Un", long_options, NULL))) {
|
||||||
|
if (c == EOF) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
@@ -5176,6 +5176,9 @@ static int img_dd(int argc, char **argv)
|
||||||
|
case 'h':
|
||||||
|
help();
|
||||||
|
break;
|
||||||
|
+ case 'n':
|
||||||
|
+ skip_create = true;
|
||||||
|
+ break;
|
||||||
|
case 'U':
|
||||||
|
force_share = true;
|
||||||
|
break;
|
||||||
|
@@ -5306,13 +5309,15 @@ static int img_dd(int argc, char **argv)
|
||||||
|
size - in.bsz * in.offset, &error_abort);
|
||||||
|
}
|
||||||
|
|
||||||
|
- ret = bdrv_create(drv, out.filename, opts, &local_err);
|
||||||
|
- if (ret < 0) {
|
||||||
|
- error_reportf_err(local_err,
|
||||||
|
- "%s: error while creating output image: ",
|
||||||
|
- out.filename);
|
||||||
|
- ret = -1;
|
||||||
|
- goto out;
|
||||||
|
+ if (!skip_create) {
|
||||||
|
+ ret = bdrv_create(drv, out.filename, opts, &local_err);
|
||||||
|
+ if (ret < 0) {
|
||||||
|
+ error_reportf_err(local_err,
|
||||||
|
+ "%s: error while creating output image: ",
|
||||||
|
+ out.filename);
|
||||||
|
+ ret = -1;
|
||||||
|
+ goto out;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
/* TODO, we can't honour --image-opts for the target,
|
|
@ -1,65 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Alexandre Derumier <aderumier@odiso.com>
|
|
||||||
Date: Mon, 6 Apr 2020 12:16:42 +0200
|
|
||||||
Subject: [PATCH] PVE: [Up] qemu-img dd: add -n skip_create
|
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
qemu-img.c | 23 ++++++++++++++---------
|
|
||||||
1 file changed, 14 insertions(+), 9 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/qemu-img.c b/qemu-img.c
|
|
||||||
index 98a6562364..355b3b82f4 100644
|
|
||||||
--- a/qemu-img.c
|
|
||||||
+++ b/qemu-img.c
|
|
||||||
@@ -4918,7 +4918,7 @@ static int img_dd(int argc, char **argv)
|
|
||||||
const char *fmt = NULL;
|
|
||||||
int64_t size = 0, readsize = 0;
|
|
||||||
int64_t block_count = 0, out_pos, in_pos;
|
|
||||||
- bool force_share = false;
|
|
||||||
+ bool force_share = false, skip_create = false;
|
|
||||||
struct DdInfo dd = {
|
|
||||||
.flags = 0,
|
|
||||||
.count = 0,
|
|
||||||
@@ -4956,7 +4956,7 @@ static int img_dd(int argc, char **argv)
|
|
||||||
{ 0, 0, 0, 0 }
|
|
||||||
};
|
|
||||||
|
|
||||||
- while ((c = getopt_long(argc, argv, ":hf:O:U", long_options, NULL))) {
|
|
||||||
+ while ((c = getopt_long(argc, argv, ":hf:O:U:n", long_options, NULL))) {
|
|
||||||
if (c == EOF) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
@@ -4976,6 +4976,9 @@ static int img_dd(int argc, char **argv)
|
|
||||||
case 'h':
|
|
||||||
help();
|
|
||||||
break;
|
|
||||||
+ case 'n':
|
|
||||||
+ skip_create = true;
|
|
||||||
+ break;
|
|
||||||
case 'U':
|
|
||||||
force_share = true;
|
|
||||||
break;
|
|
||||||
@@ -5106,13 +5109,15 @@ static int img_dd(int argc, char **argv)
|
|
||||||
size - in.bsz * in.offset, &error_abort);
|
|
||||||
}
|
|
||||||
|
|
||||||
- ret = bdrv_create(drv, out.filename, opts, &local_err);
|
|
||||||
- if (ret < 0) {
|
|
||||||
- error_reportf_err(local_err,
|
|
||||||
- "%s: error while creating output image: ",
|
|
||||||
- out.filename);
|
|
||||||
- ret = -1;
|
|
||||||
- goto out;
|
|
||||||
+ if (!skip_create) {
|
|
||||||
+ ret = bdrv_create(drv, out.filename, opts, &local_err);
|
|
||||||
+ if (ret < 0) {
|
|
||||||
+ error_reportf_err(local_err,
|
|
||||||
+ "%s: error while creating output image: ",
|
|
||||||
+ out.filename);
|
|
||||||
+ ret = -1;
|
|
||||||
+ goto out;
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
|
|
||||||
/* TODO, we can't honour --image-opts for the target,
|
|
130
debian/patches/pve/0012-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch
vendored
Normal file
130
debian/patches/pve/0012-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch
vendored
Normal file
|
@ -0,0 +1,130 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 7 Feb 2022 14:21:01 +0100
|
||||||
|
Subject: [PATCH] qemu-img dd: add -l option for loading a snapshot
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
docs/tools/qemu-img.rst | 6 +++---
|
||||||
|
qemu-img-cmds.hx | 4 ++--
|
||||||
|
qemu-img.c | 33 +++++++++++++++++++++++++++++++--
|
||||||
|
3 files changed, 36 insertions(+), 7 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
|
||||||
|
index d83e8fb3c0..61c6b21859 100644
|
||||||
|
--- a/docs/tools/qemu-img.rst
|
||||||
|
+++ b/docs/tools/qemu-img.rst
|
||||||
|
@@ -496,10 +496,10 @@ Command description:
|
||||||
|
it doesn't need to be specified separately in this case.
|
||||||
|
|
||||||
|
|
||||||
|
-.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] if=INPUT of=OUTPUT
|
||||||
|
+.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [-l SNAPSHOT_PARAM] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] if=INPUT of=OUTPUT
|
||||||
|
|
||||||
|
- dd copies from *INPUT* file to *OUTPUT* file converting it from
|
||||||
|
- *FMT* format to *OUTPUT_FMT* format.
|
||||||
|
+ dd copies from *INPUT* file or snapshot *SNAPSHOT_PARAM* to *OUTPUT* file
|
||||||
|
+ converting it from *FMT* format to *OUTPUT_FMT* format.
|
||||||
|
|
||||||
|
The data is by default read and written using blocks of 512 bytes but can be
|
||||||
|
modified by specifying *BLOCK_SIZE*. If count=\ *BLOCKS* is specified
|
||||||
|
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
|
||||||
|
index 0b29a67a06..758f397232 100644
|
||||||
|
--- a/qemu-img-cmds.hx
|
||||||
|
+++ b/qemu-img-cmds.hx
|
||||||
|
@@ -60,9 +60,9 @@ SRST
|
||||||
|
ERST
|
||||||
|
|
||||||
|
DEF("dd", img_dd,
|
||||||
|
- "dd [--image-opts] [-U] [-f fmt] [-O output_fmt] [-n] [bs=block_size] [count=blocks] [skip=blocks] [osize=output_size] if=input of=output")
|
||||||
|
+ "dd [--image-opts] [-U] [-f fmt] [-O output_fmt] [-n] [-l snapshot_param] [bs=block_size] [count=blocks] [skip=blocks] [osize=output_size] if=input of=output")
|
||||||
|
SRST
|
||||||
|
-.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] [osize=OUTPUT_SIZE] if=INPUT of=OUTPUT
|
||||||
|
+.. option:: dd [--image-opts] [-U] [-f FMT] [-O OUTPUT_FMT] [-n] [-l SNAPSHOT_PARAM] [bs=BLOCK_SIZE] [count=BLOCKS] [skip=BLOCKS] [osize=OUTPUT_SIZE] if=INPUT of=OUTPUT
|
||||||
|
ERST
|
||||||
|
|
||||||
|
DEF("info", img_info,
|
||||||
|
diff --git a/qemu-img.c b/qemu-img.c
|
||||||
|
index 6fc8384f64..a6c88e0860 100644
|
||||||
|
--- a/qemu-img.c
|
||||||
|
+++ b/qemu-img.c
|
||||||
|
@@ -5110,6 +5110,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
BlockDriver *drv = NULL, *proto_drv = NULL;
|
||||||
|
BlockBackend *blk1 = NULL, *blk2 = NULL;
|
||||||
|
QemuOpts *opts = NULL;
|
||||||
|
+ QemuOpts *sn_opts = NULL;
|
||||||
|
QemuOptsList *create_opts = NULL;
|
||||||
|
Error *local_err = NULL;
|
||||||
|
bool image_opts = false;
|
||||||
|
@@ -5119,6 +5120,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
int64_t size = 0, readsize = 0;
|
||||||
|
int64_t out_pos, in_pos;
|
||||||
|
bool force_share = false, skip_create = false;
|
||||||
|
+ const char *snapshot_name = NULL;
|
||||||
|
struct DdInfo dd = {
|
||||||
|
.flags = 0,
|
||||||
|
.count = 0,
|
||||||
|
@@ -5156,7 +5158,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
{ 0, 0, 0, 0 }
|
||||||
|
};
|
||||||
|
|
||||||
|
- while ((c = getopt_long(argc, argv, ":hf:O:Un", long_options, NULL))) {
|
||||||
|
+ while ((c = getopt_long(argc, argv, ":hf:O:l:Un", long_options, NULL))) {
|
||||||
|
if (c == EOF) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
@@ -5179,6 +5181,19 @@ static int img_dd(int argc, char **argv)
|
||||||
|
case 'n':
|
||||||
|
skip_create = true;
|
||||||
|
break;
|
||||||
|
+ case 'l':
|
||||||
|
+ if (strstart(optarg, SNAPSHOT_OPT_BASE, NULL)) {
|
||||||
|
+ sn_opts = qemu_opts_parse_noisily(&internal_snapshot_opts,
|
||||||
|
+ optarg, false);
|
||||||
|
+ if (!sn_opts) {
|
||||||
|
+ error_report("Failed in parsing snapshot param '%s'",
|
||||||
|
+ optarg);
|
||||||
|
+ goto out;
|
||||||
|
+ }
|
||||||
|
+ } else {
|
||||||
|
+ snapshot_name = optarg;
|
||||||
|
+ }
|
||||||
|
+ break;
|
||||||
|
case 'U':
|
||||||
|
force_share = true;
|
||||||
|
break;
|
||||||
|
@@ -5238,11 +5253,24 @@ static int img_dd(int argc, char **argv)
|
||||||
|
if (dd.flags & C_IF) {
|
||||||
|
blk1 = img_open(image_opts, in.filename, fmt, 0, false, false,
|
||||||
|
force_share);
|
||||||
|
-
|
||||||
|
if (!blk1) {
|
||||||
|
ret = -1;
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
+ if (sn_opts) {
|
||||||
|
+ bdrv_snapshot_load_tmp(blk_bs(blk1),
|
||||||
|
+ qemu_opt_get(sn_opts, SNAPSHOT_OPT_ID),
|
||||||
|
+ qemu_opt_get(sn_opts, SNAPSHOT_OPT_NAME),
|
||||||
|
+ &local_err);
|
||||||
|
+ } else if (snapshot_name != NULL) {
|
||||||
|
+ bdrv_snapshot_load_tmp_by_id_or_name(blk_bs(blk1), snapshot_name,
|
||||||
|
+ &local_err);
|
||||||
|
+ }
|
||||||
|
+ if (local_err) {
|
||||||
|
+ error_reportf_err(local_err, "Failed to load snapshot: ");
|
||||||
|
+ ret = -1;
|
||||||
|
+ goto out;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
if (dd.flags & C_OSIZE) {
|
||||||
|
@@ -5397,6 +5425,7 @@ static int img_dd(int argc, char **argv)
|
||||||
|
out:
|
||||||
|
g_free(arg);
|
||||||
|
qemu_opts_del(opts);
|
||||||
|
+ qemu_opts_del(sn_opts);
|
||||||
|
qemu_opts_free(create_opts);
|
||||||
|
blk_unref(blk1);
|
||||||
|
blk_unref(blk2);
|
|
@ -7,17 +7,62 @@ Actually provide memory information via the query-balloon
|
||||||
command.
|
command.
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: add BalloonInfo to member name exceptions list
|
||||||
|
rebase for 8.0 - moved to hw/core/machine-hmp-cmds.c]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
|
hw/core/machine-hmp-cmds.c | 30 +++++++++++++++++++++++++++++-
|
||||||
hw/virtio/virtio-balloon.c | 33 +++++++++++++++++++++++++++++++--
|
hw/virtio/virtio-balloon.c | 33 +++++++++++++++++++++++++++++++--
|
||||||
monitor/hmp-cmds.c | 30 +++++++++++++++++++++++++++++-
|
|
||||||
qapi/machine.json | 22 +++++++++++++++++++++-
|
qapi/machine.json | 22 +++++++++++++++++++++-
|
||||||
3 files changed, 81 insertions(+), 4 deletions(-)
|
qapi/pragma.json | 1 +
|
||||||
|
4 files changed, 82 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c
|
||||||
|
index a6ff6a4875..e7f74d1c63 100644
|
||||||
|
--- a/hw/core/machine-hmp-cmds.c
|
||||||
|
+++ b/hw/core/machine-hmp-cmds.c
|
||||||
|
@@ -175,7 +175,35 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
- monitor_printf(mon, "balloon: actual=%" PRId64 "\n", info->actual >> 20);
|
||||||
|
+ monitor_printf(mon, "balloon: actual=%" PRId64, info->actual >> 20);
|
||||||
|
+ monitor_printf(mon, " max_mem=%" PRId64, info->max_mem >> 20);
|
||||||
|
+ if (info->has_total_mem) {
|
||||||
|
+ monitor_printf(mon, " total_mem=%" PRId64, info->total_mem >> 20);
|
||||||
|
+ }
|
||||||
|
+ if (info->has_free_mem) {
|
||||||
|
+ monitor_printf(mon, " free_mem=%" PRId64, info->free_mem >> 20);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (info->has_mem_swapped_in) {
|
||||||
|
+ monitor_printf(mon, " mem_swapped_in=%" PRId64, info->mem_swapped_in);
|
||||||
|
+ }
|
||||||
|
+ if (info->has_mem_swapped_out) {
|
||||||
|
+ monitor_printf(mon, " mem_swapped_out=%" PRId64, info->mem_swapped_out);
|
||||||
|
+ }
|
||||||
|
+ if (info->has_major_page_faults) {
|
||||||
|
+ monitor_printf(mon, " major_page_faults=%" PRId64,
|
||||||
|
+ info->major_page_faults);
|
||||||
|
+ }
|
||||||
|
+ if (info->has_minor_page_faults) {
|
||||||
|
+ monitor_printf(mon, " minor_page_faults=%" PRId64,
|
||||||
|
+ info->minor_page_faults);
|
||||||
|
+ }
|
||||||
|
+ if (info->has_last_update) {
|
||||||
|
+ monitor_printf(mon, " last_update=%" PRId64,
|
||||||
|
+ info->last_update);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ monitor_printf(mon, "\n");
|
||||||
|
|
||||||
|
qapi_free_BalloonInfo(info);
|
||||||
|
}
|
||||||
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
|
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
|
||||||
index ae7867a8db..956e3f4e46 100644
|
index 609e39a821..8cb6dfcac3 100644
|
||||||
--- a/hw/virtio/virtio-balloon.c
|
--- a/hw/virtio/virtio-balloon.c
|
||||||
+++ b/hw/virtio/virtio-balloon.c
|
+++ b/hw/virtio/virtio-balloon.c
|
||||||
@@ -820,8 +820,37 @@ static uint64_t virtio_balloon_get_features(VirtIODevice *vdev, uint64_t f,
|
@@ -781,8 +781,37 @@ static uint64_t virtio_balloon_get_features(VirtIODevice *vdev, uint64_t f,
|
||||||
static void virtio_balloon_stat(void *opaque, BalloonInfo *info)
|
static void virtio_balloon_stat(void *opaque, BalloonInfo *info)
|
||||||
{
|
{
|
||||||
VirtIOBalloon *dev = opaque;
|
VirtIOBalloon *dev = opaque;
|
||||||
|
@ -57,54 +102,13 @@ index ae7867a8db..956e3f4e46 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
|
static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
|
||||||
index f4ef58d257..c8b97909e7 100644
|
|
||||||
--- a/monitor/hmp-cmds.c
|
|
||||||
+++ b/monitor/hmp-cmds.c
|
|
||||||
@@ -698,7 +698,35 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
- monitor_printf(mon, "balloon: actual=%" PRId64 "\n", info->actual >> 20);
|
|
||||||
+ monitor_printf(mon, "balloon: actual=%" PRId64, info->actual >> 20);
|
|
||||||
+ monitor_printf(mon, " max_mem=%" PRId64, info->max_mem >> 20);
|
|
||||||
+ if (info->has_total_mem) {
|
|
||||||
+ monitor_printf(mon, " total_mem=%" PRId64, info->total_mem >> 20);
|
|
||||||
+ }
|
|
||||||
+ if (info->has_free_mem) {
|
|
||||||
+ monitor_printf(mon, " free_mem=%" PRId64, info->free_mem >> 20);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (info->has_mem_swapped_in) {
|
|
||||||
+ monitor_printf(mon, " mem_swapped_in=%" PRId64, info->mem_swapped_in);
|
|
||||||
+ }
|
|
||||||
+ if (info->has_mem_swapped_out) {
|
|
||||||
+ monitor_printf(mon, " mem_swapped_out=%" PRId64, info->mem_swapped_out);
|
|
||||||
+ }
|
|
||||||
+ if (info->has_major_page_faults) {
|
|
||||||
+ monitor_printf(mon, " major_page_faults=%" PRId64,
|
|
||||||
+ info->major_page_faults);
|
|
||||||
+ }
|
|
||||||
+ if (info->has_minor_page_faults) {
|
|
||||||
+ monitor_printf(mon, " minor_page_faults=%" PRId64,
|
|
||||||
+ info->minor_page_faults);
|
|
||||||
+ }
|
|
||||||
+ if (info->has_last_update) {
|
|
||||||
+ monitor_printf(mon, " last_update=%" PRId64,
|
|
||||||
+ info->last_update);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ monitor_printf(mon, "\n");
|
|
||||||
|
|
||||||
qapi_free_BalloonInfo(info);
|
|
||||||
}
|
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index 157712f006..34035c25d1 100644
|
index e8b60641f2..2054cdc70d 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -1018,10 +1018,30 @@
|
@@ -1079,9 +1079,29 @@
|
||||||
# @actual: the logical size of the VM in bytes
|
# @actual: the logical size of the VM in bytes Formula used:
|
||||||
# Formula used: logical_vm_size = vm_ram_size - balloon_size
|
# logical_vm_size = vm_ram_size - balloon_size
|
||||||
#
|
#
|
||||||
+# @last_update: time when stats got updated from guest
|
+# @last_update: time when stats got updated from guest
|
||||||
+#
|
+#
|
||||||
|
@ -123,7 +127,6 @@ index 157712f006..34035c25d1 100644
|
||||||
+# @max_mem: amount of memory (in bytes) assigned to the guest
|
+# @max_mem: amount of memory (in bytes) assigned to the guest
|
||||||
+#
|
+#
|
||||||
# Since: 0.14
|
# Since: 0.14
|
||||||
#
|
|
||||||
##
|
##
|
||||||
-{ 'struct': 'BalloonInfo', 'data': {'actual': 'int' } }
|
-{ 'struct': 'BalloonInfo', 'data': {'actual': 'int' } }
|
||||||
+{ 'struct': 'BalloonInfo',
|
+{ 'struct': 'BalloonInfo',
|
||||||
|
@ -134,3 +137,15 @@ index 157712f006..34035c25d1 100644
|
||||||
|
|
||||||
##
|
##
|
||||||
# @query-balloon:
|
# @query-balloon:
|
||||||
|
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
||||||
|
index 59fbe74b8c..be8fa304c5 100644
|
||||||
|
--- a/qapi/pragma.json
|
||||||
|
+++ b/qapi/pragma.json
|
||||||
|
@@ -90,6 +90,7 @@
|
||||||
|
'member-name-exceptions': [ # visible in:
|
||||||
|
'ACPISlotType', # query-acpi-ospm-status
|
||||||
|
'AcpiTableOptions', # -acpitable
|
||||||
|
+ 'BalloonInfo', # query-balloon
|
||||||
|
'BlkdebugEvent', # blockdev-add, -blockdev
|
||||||
|
'BlkdebugSetStateOptions', # blockdev-add, -blockdev
|
||||||
|
'BlockDeviceInfo', # query-block
|
||||||
|
|
|
@ -13,13 +13,13 @@ Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
||||||
2 files changed, 9 insertions(+), 1 deletion(-)
|
2 files changed, 9 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
||||||
index 216fdfaf3a..8f8d5d5276 100644
|
index 4b72009cd3..314351cdff 100644
|
||||||
--- a/hw/core/machine-qmp-cmds.c
|
--- a/hw/core/machine-qmp-cmds.c
|
||||||
+++ b/hw/core/machine-qmp-cmds.c
|
+++ b/hw/core/machine-qmp-cmds.c
|
||||||
@@ -98,6 +98,12 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
@@ -90,6 +90,12 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
||||||
info->hotpluggable_cpus = mc->has_hotpluggable_cpus;
|
|
||||||
info->numa_mem_supported = mc->numa_mem_supported;
|
info->numa_mem_supported = mc->numa_mem_supported;
|
||||||
info->deprecated = !!mc->deprecation_reason;
|
info->deprecated = !!mc->deprecation_reason;
|
||||||
|
info->acpi = !!object_class_property_find(OBJECT_CLASS(mc), "acpi");
|
||||||
+
|
+
|
||||||
+ if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
+ if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
||||||
+ info->has_is_current = true;
|
+ info->has_is_current = true;
|
||||||
|
@ -28,21 +28,21 @@ index 216fdfaf3a..8f8d5d5276 100644
|
||||||
+
|
+
|
||||||
if (mc->default_cpu_type) {
|
if (mc->default_cpu_type) {
|
||||||
info->default_cpu_type = g_strdup(mc->default_cpu_type);
|
info->default_cpu_type = g_strdup(mc->default_cpu_type);
|
||||||
info->has_default_cpu_type = true;
|
}
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index 34035c25d1..cf120ac343 100644
|
index 2054cdc70d..a024d5b05d 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -141,6 +141,8 @@
|
@@ -146,6 +146,8 @@
|
||||||
#
|
#
|
||||||
# @is-default: whether the machine is default
|
# @is-default: whether the machine is default
|
||||||
#
|
#
|
||||||
+# @is-current: whether this machine is currently used
|
+# @is-current: whether this machine is currently used
|
||||||
+#
|
+#
|
||||||
# @cpu-max: maximum number of CPUs supported by the machine type
|
# @cpu-max: maximum number of CPUs supported by the machine type
|
||||||
# (since 1.5)
|
# (since 1.5)
|
||||||
#
|
#
|
||||||
@@ -162,7 +164,7 @@
|
@@ -170,7 +172,7 @@
|
||||||
##
|
##
|
||||||
{ 'struct': 'MachineInfo',
|
{ 'struct': 'MachineInfo',
|
||||||
'data': { 'name': 'str', '*alias': 'str',
|
'data': { 'name': 'str', '*alias': 'str',
|
||||||
|
@ -50,4 +50,4 @@ index 34035c25d1..cf120ac343 100644
|
||||||
+ '*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
+ '*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
||||||
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
||||||
'deprecated': 'bool', '*default-cpu-type': 'str',
|
'deprecated': 'bool', '*default-cpu-type': 'str',
|
||||||
'*default-ram-id': 'str' } }
|
'*default-ram-id': 'str', 'acpi': 'bool' } }
|
||||||
|
|
|
@ -6,16 +6,18 @@ Subject: [PATCH] PVE: qapi: modify spice query
|
||||||
Provide the last ticket in the SpiceInfo struct optionally.
|
Provide the last ticket in the SpiceInfo struct optionally.
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to QAPI change]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
qapi/ui.json | 3 +++
|
qapi/ui.json | 3 +++
|
||||||
ui/spice-core.c | 5 +++++
|
ui/spice-core.c | 4 ++++
|
||||||
2 files changed, 8 insertions(+)
|
2 files changed, 7 insertions(+)
|
||||||
|
|
||||||
diff --git a/qapi/ui.json b/qapi/ui.json
|
diff --git a/qapi/ui.json b/qapi/ui.json
|
||||||
index cba8665b73..081115ea8a 100644
|
index f610bce118..6ea26a9acb 100644
|
||||||
--- a/qapi/ui.json
|
--- a/qapi/ui.json
|
||||||
+++ b/qapi/ui.json
|
+++ b/qapi/ui.json
|
||||||
@@ -333,11 +333,14 @@
|
@@ -314,11 +314,14 @@
|
||||||
#
|
#
|
||||||
# @channels: a list of @SpiceChannel for each active spice channel
|
# @channels: a list of @SpiceChannel for each active spice channel
|
||||||
#
|
#
|
||||||
|
@ -28,18 +30,17 @@ index cba8665b73..081115ea8a 100644
|
||||||
'*tls-port': 'int', '*auth': 'str', '*compiled-version': 'str',
|
'*tls-port': 'int', '*auth': 'str', '*compiled-version': 'str',
|
||||||
+ '*ticket': 'str',
|
+ '*ticket': 'str',
|
||||||
'mouse-mode': 'SpiceQueryMouseMode', '*channels': ['SpiceChannel']},
|
'mouse-mode': 'SpiceQueryMouseMode', '*channels': ['SpiceChannel']},
|
||||||
'if': 'defined(CONFIG_SPICE)' }
|
'if': 'CONFIG_SPICE' }
|
||||||
|
|
||||||
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
||||||
index 840cf56923..96be349635 100644
|
index ea20e6153c..55a15fba8b 100644
|
||||||
--- a/ui/spice-core.c
|
--- a/ui/spice-core.c
|
||||||
+++ b/ui/spice-core.c
|
+++ b/ui/spice-core.c
|
||||||
@@ -534,6 +534,11 @@ static SpiceInfo *qmp_query_spice_real(Error **errp)
|
@@ -548,6 +548,10 @@ static SpiceInfo *qmp_query_spice_real(Error **errp)
|
||||||
micro = SPICE_SERVER_VERSION & 0xff;
|
micro = SPICE_SERVER_VERSION & 0xff;
|
||||||
info->compiled_version = g_strdup_printf("%d.%d.%d", major, minor, micro);
|
info->compiled_version = g_strdup_printf("%d.%d.%d", major, minor, micro);
|
||||||
|
|
||||||
+ if (auth_passwd) {
|
+ if (auth_passwd) {
|
||||||
+ info->has_ticket = true;
|
|
||||||
+ info->ticket = g_strdup(auth_passwd);
|
+ info->ticket = g_strdup(auth_passwd);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
|
284
debian/patches/pve/0016-PVE-add-IOChannel-implementation-for-savevm-async.patch
vendored
Normal file
284
debian/patches/pve/0016-PVE-add-IOChannel-implementation-for-savevm-async.patch
vendored
Normal file
|
@ -0,0 +1,284 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 13 Oct 2022 11:33:50 +0200
|
||||||
|
Subject: [PATCH] PVE: add IOChannel implementation for savevm-async
|
||||||
|
|
||||||
|
based on migration/channel-block.c and the implementation that was
|
||||||
|
present in migration/savevm-async.c before QEMU 7.1.
|
||||||
|
|
||||||
|
Passes along read/write requests to the given BlockBackend, while
|
||||||
|
ensuring that a read request going beyond the end results in a
|
||||||
|
graceful short read.
|
||||||
|
|
||||||
|
Additionally, allows tracking the current position from the outside
|
||||||
|
(intended to be used for progress tracking).
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
migration/channel-savevm-async.c | 184 +++++++++++++++++++++++++++++++
|
||||||
|
migration/channel-savevm-async.h | 51 +++++++++
|
||||||
|
migration/meson.build | 1 +
|
||||||
|
3 files changed, 236 insertions(+)
|
||||||
|
create mode 100644 migration/channel-savevm-async.c
|
||||||
|
create mode 100644 migration/channel-savevm-async.h
|
||||||
|
|
||||||
|
diff --git a/migration/channel-savevm-async.c b/migration/channel-savevm-async.c
|
||||||
|
new file mode 100644
|
||||||
|
index 0000000000..081a192f49
|
||||||
|
--- /dev/null
|
||||||
|
+++ b/migration/channel-savevm-async.c
|
||||||
|
@@ -0,0 +1,184 @@
|
||||||
|
+/*
|
||||||
|
+ * QIO Channel implementation to be used by savevm-async QMP calls
|
||||||
|
+ */
|
||||||
|
+#include "qemu/osdep.h"
|
||||||
|
+#include "migration/channel-savevm-async.h"
|
||||||
|
+#include "qapi/error.h"
|
||||||
|
+#include "sysemu/block-backend.h"
|
||||||
|
+#include "trace.h"
|
||||||
|
+
|
||||||
|
+QIOChannelSavevmAsync *
|
||||||
|
+qio_channel_savevm_async_new(BlockBackend *be, size_t *bs_pos)
|
||||||
|
+{
|
||||||
|
+ QIOChannelSavevmAsync *ioc;
|
||||||
|
+
|
||||||
|
+ ioc = QIO_CHANNEL_SAVEVM_ASYNC(object_new(TYPE_QIO_CHANNEL_SAVEVM_ASYNC));
|
||||||
|
+
|
||||||
|
+ bdrv_ref(blk_bs(be));
|
||||||
|
+ ioc->be = be;
|
||||||
|
+ ioc->bs_pos = bs_pos;
|
||||||
|
+
|
||||||
|
+ return ioc;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static void
|
||||||
|
+qio_channel_savevm_async_finalize(Object *obj)
|
||||||
|
+{
|
||||||
|
+ QIOChannelSavevmAsync *ioc = QIO_CHANNEL_SAVEVM_ASYNC(obj);
|
||||||
|
+
|
||||||
|
+ if (ioc->be) {
|
||||||
|
+ bdrv_unref(blk_bs(ioc->be));
|
||||||
|
+ ioc->be = NULL;
|
||||||
|
+ }
|
||||||
|
+ ioc->bs_pos = NULL;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static ssize_t
|
||||||
|
+qio_channel_savevm_async_readv(QIOChannel *ioc,
|
||||||
|
+ const struct iovec *iov,
|
||||||
|
+ size_t niov,
|
||||||
|
+ int **fds,
|
||||||
|
+ size_t *nfds,
|
||||||
|
+ int flags,
|
||||||
|
+ Error **errp)
|
||||||
|
+{
|
||||||
|
+ QIOChannelSavevmAsync *saioc = QIO_CHANNEL_SAVEVM_ASYNC(ioc);
|
||||||
|
+ BlockBackend *be = saioc->be;
|
||||||
|
+ int64_t maxlen = blk_getlength(be);
|
||||||
|
+ QEMUIOVector qiov;
|
||||||
|
+ size_t size;
|
||||||
|
+ int ret;
|
||||||
|
+
|
||||||
|
+ qemu_iovec_init_external(&qiov, (struct iovec *)iov, niov);
|
||||||
|
+
|
||||||
|
+ if (*saioc->bs_pos >= maxlen) {
|
||||||
|
+ error_setg(errp, "cannot read beyond maxlen");
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (maxlen - *saioc->bs_pos < qiov.size) {
|
||||||
|
+ size = maxlen - *saioc->bs_pos;
|
||||||
|
+ } else {
|
||||||
|
+ size = qiov.size;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ // returns 0 on success
|
||||||
|
+ ret = blk_preadv(be, *saioc->bs_pos, size, &qiov, 0);
|
||||||
|
+ if (ret < 0) {
|
||||||
|
+ error_setg_errno(errp, -ret, "blk_preadv failed");
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ *saioc->bs_pos += size;
|
||||||
|
+ return size;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static ssize_t
|
||||||
|
+qio_channel_savevm_async_writev(QIOChannel *ioc,
|
||||||
|
+ const struct iovec *iov,
|
||||||
|
+ size_t niov,
|
||||||
|
+ int *fds,
|
||||||
|
+ size_t nfds,
|
||||||
|
+ int flags,
|
||||||
|
+ Error **errp)
|
||||||
|
+{
|
||||||
|
+ QIOChannelSavevmAsync *saioc = QIO_CHANNEL_SAVEVM_ASYNC(ioc);
|
||||||
|
+ BlockBackend *be = saioc->be;
|
||||||
|
+ QEMUIOVector qiov;
|
||||||
|
+ int ret;
|
||||||
|
+
|
||||||
|
+ qemu_iovec_init_external(&qiov, (struct iovec *)iov, niov);
|
||||||
|
+
|
||||||
|
+ if (qemu_in_coroutine()) {
|
||||||
|
+ ret = blk_co_pwritev(be, *saioc->bs_pos, qiov.size, &qiov, 0);
|
||||||
|
+ aio_wait_kick();
|
||||||
|
+ } else {
|
||||||
|
+ ret = blk_pwritev(be, *saioc->bs_pos, qiov.size, &qiov, 0);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (ret < 0) {
|
||||||
|
+ error_setg_errno(errp, -ret, "blk(_co)_pwritev failed");
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ *saioc->bs_pos += qiov.size;
|
||||||
|
+ return qiov.size;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static int
|
||||||
|
+qio_channel_savevm_async_set_blocking(QIOChannel *ioc,
|
||||||
|
+ bool enabled,
|
||||||
|
+ Error **errp)
|
||||||
|
+{
|
||||||
|
+ if (!enabled) {
|
||||||
|
+ error_setg(errp, "Non-blocking mode not supported for savevm-async");
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+ return 0;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static int
|
||||||
|
+qio_channel_savevm_async_close(QIOChannel *ioc,
|
||||||
|
+ Error **errp)
|
||||||
|
+{
|
||||||
|
+ QIOChannelSavevmAsync *saioc = QIO_CHANNEL_SAVEVM_ASYNC(ioc);
|
||||||
|
+ int rv = bdrv_flush(blk_bs(saioc->be));
|
||||||
|
+
|
||||||
|
+ if (rv < 0) {
|
||||||
|
+ error_setg_errno(errp, -rv, "Unable to flush VMState");
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ bdrv_unref(blk_bs(saioc->be));
|
||||||
|
+ saioc->be = NULL;
|
||||||
|
+ saioc->bs_pos = NULL;
|
||||||
|
+
|
||||||
|
+ return 0;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static void
|
||||||
|
+qio_channel_savevm_async_set_aio_fd_handler(QIOChannel *ioc,
|
||||||
|
+ AioContext *read_ctx,
|
||||||
|
+ IOHandler *io_read,
|
||||||
|
+ AioContext *write_ctx,
|
||||||
|
+ IOHandler *io_write,
|
||||||
|
+ void *opaque)
|
||||||
|
+{
|
||||||
|
+ // if channel-block starts doing something, check if this needs adaptation
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+static void
|
||||||
|
+qio_channel_savevm_async_class_init(ObjectClass *klass,
|
||||||
|
+ void *class_data G_GNUC_UNUSED)
|
||||||
|
+{
|
||||||
|
+ QIOChannelClass *ioc_klass = QIO_CHANNEL_CLASS(klass);
|
||||||
|
+
|
||||||
|
+ ioc_klass->io_writev = qio_channel_savevm_async_writev;
|
||||||
|
+ ioc_klass->io_readv = qio_channel_savevm_async_readv;
|
||||||
|
+ ioc_klass->io_set_blocking = qio_channel_savevm_async_set_blocking;
|
||||||
|
+ ioc_klass->io_close = qio_channel_savevm_async_close;
|
||||||
|
+ ioc_klass->io_set_aio_fd_handler = qio_channel_savevm_async_set_aio_fd_handler;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static const TypeInfo qio_channel_savevm_async_info = {
|
||||||
|
+ .parent = TYPE_QIO_CHANNEL,
|
||||||
|
+ .name = TYPE_QIO_CHANNEL_SAVEVM_ASYNC,
|
||||||
|
+ .instance_size = sizeof(QIOChannelSavevmAsync),
|
||||||
|
+ .instance_finalize = qio_channel_savevm_async_finalize,
|
||||||
|
+ .class_init = qio_channel_savevm_async_class_init,
|
||||||
|
+};
|
||||||
|
+
|
||||||
|
+static void
|
||||||
|
+qio_channel_savevm_async_register_types(void)
|
||||||
|
+{
|
||||||
|
+ type_register_static(&qio_channel_savevm_async_info);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+type_init(qio_channel_savevm_async_register_types);
|
||||||
|
diff --git a/migration/channel-savevm-async.h b/migration/channel-savevm-async.h
|
||||||
|
new file mode 100644
|
||||||
|
index 0000000000..17ae2cb261
|
||||||
|
--- /dev/null
|
||||||
|
+++ b/migration/channel-savevm-async.h
|
||||||
|
@@ -0,0 +1,51 @@
|
||||||
|
+/*
|
||||||
|
+ * QEMU I/O channels driver for savevm-async.c
|
||||||
|
+ *
|
||||||
|
+ * Copyright (c) 2022 Proxmox Server Solutions
|
||||||
|
+ *
|
||||||
|
+ * Authors:
|
||||||
|
+ * Fiona Ebner (f.ebner@proxmox.com)
|
||||||
|
+ *
|
||||||
|
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
|
||||||
|
+ * See the COPYING file in the top-level directory.
|
||||||
|
+ */
|
||||||
|
+
|
||||||
|
+#ifndef QIO_CHANNEL_SAVEVM_ASYNC_H
|
||||||
|
+#define QIO_CHANNEL_SAVEVM_ASYNC_H
|
||||||
|
+
|
||||||
|
+#include "io/channel.h"
|
||||||
|
+#include "qom/object.h"
|
||||||
|
+
|
||||||
|
+#define TYPE_QIO_CHANNEL_SAVEVM_ASYNC "qio-channel-savevm-async"
|
||||||
|
+OBJECT_DECLARE_SIMPLE_TYPE(QIOChannelSavevmAsync, QIO_CHANNEL_SAVEVM_ASYNC)
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+/**
|
||||||
|
+ * QIOChannelSavevmAsync:
|
||||||
|
+ *
|
||||||
|
+ * The QIOChannelBlock object provides a channel implementation that is able to
|
||||||
|
+ * perform I/O on any BlockBackend whose BlockDriverState directly contains a
|
||||||
|
+ * VMState (as opposed to indirectly, like qcow2). It allows tracking the
|
||||||
|
+ * current position from the outside.
|
||||||
|
+ */
|
||||||
|
+struct QIOChannelSavevmAsync {
|
||||||
|
+ QIOChannel parent;
|
||||||
|
+ BlockBackend *be;
|
||||||
|
+ size_t *bs_pos;
|
||||||
|
+};
|
||||||
|
+
|
||||||
|
+
|
||||||
|
+/**
|
||||||
|
+ * qio_channel_savevm_async_new:
|
||||||
|
+ * @be: the block backend
|
||||||
|
+ * @bs_pos: used to keep track of the IOChannels current position
|
||||||
|
+ *
|
||||||
|
+ * Create a new IO channel object that can perform I/O on a BlockBackend object
|
||||||
|
+ * whose BlockDriverState directly contains a VMState.
|
||||||
|
+ *
|
||||||
|
+ * Returns: the new channel object
|
||||||
|
+ */
|
||||||
|
+QIOChannelSavevmAsync *
|
||||||
|
+qio_channel_savevm_async_new(BlockBackend *be, size_t *bs_pos);
|
||||||
|
+
|
||||||
|
+#endif /* QIO_CHANNEL_SAVEVM_ASYNC_H */
|
||||||
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
|
index 1eeb915ff6..95d1cf2250 100644
|
||||||
|
--- a/migration/meson.build
|
||||||
|
+++ b/migration/meson.build
|
||||||
|
@@ -13,6 +13,7 @@ system_ss.add(files(
|
||||||
|
'block-dirty-bitmap.c',
|
||||||
|
'channel.c',
|
||||||
|
'channel-block.c',
|
||||||
|
+ 'channel-savevm-async.c',
|
||||||
|
'dirtyrate.c',
|
||||||
|
'exec.c',
|
||||||
|
'fd.c',
|
|
@ -1,188 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
||||||
Date: Mon, 4 May 2020 11:05:08 +0200
|
|
||||||
Subject: [PATCH] PVE: add optional buffer size to QEMUFile
|
|
||||||
|
|
||||||
So we can use a 4M buffer for savevm-async which should
|
|
||||||
increase performance storing the state onto ceph.
|
|
||||||
|
|
||||||
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
||||||
[increase max IOV count in QEMUFile to actually write more data]
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
migration/qemu-file.c | 38 +++++++++++++++++++++++++-------------
|
|
||||||
migration/qemu-file.h | 1 +
|
|
||||||
migration/savevm-async.c | 4 ++--
|
|
||||||
3 files changed, 28 insertions(+), 15 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
|
|
||||||
index 6338d8e2ff..6697a93a7e 100644
|
|
||||||
--- a/migration/qemu-file.c
|
|
||||||
+++ b/migration/qemu-file.c
|
|
||||||
@@ -30,8 +30,8 @@
|
|
||||||
#include "trace.h"
|
|
||||||
#include "qapi/error.h"
|
|
||||||
|
|
||||||
-#define IO_BUF_SIZE 32768
|
|
||||||
-#define MAX_IOV_SIZE MIN_CONST(IOV_MAX, 64)
|
|
||||||
+#define DEFAULT_IO_BUF_SIZE 32768
|
|
||||||
+#define MAX_IOV_SIZE MIN_CONST(IOV_MAX, 256)
|
|
||||||
|
|
||||||
struct QEMUFile {
|
|
||||||
const QEMUFileOps *ops;
|
|
||||||
@@ -45,7 +45,8 @@ struct QEMUFile {
|
|
||||||
when reading */
|
|
||||||
int buf_index;
|
|
||||||
int buf_size; /* 0 when writing */
|
|
||||||
- uint8_t buf[IO_BUF_SIZE];
|
|
||||||
+ size_t buf_allocated_size;
|
|
||||||
+ uint8_t *buf;
|
|
||||||
|
|
||||||
DECLARE_BITMAP(may_free, MAX_IOV_SIZE);
|
|
||||||
struct iovec iov[MAX_IOV_SIZE];
|
|
||||||
@@ -103,7 +104,7 @@ bool qemu_file_mode_is_not_valid(const char *mode)
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
-QEMUFile *qemu_fopen_ops(void *opaque, const QEMUFileOps *ops, bool has_ioc)
|
|
||||||
+QEMUFile *qemu_fopen_ops_sized(void *opaque, const QEMUFileOps *ops, bool has_ioc, size_t buffer_size)
|
|
||||||
{
|
|
||||||
QEMUFile *f;
|
|
||||||
|
|
||||||
@@ -112,9 +113,17 @@ QEMUFile *qemu_fopen_ops(void *opaque, const QEMUFileOps *ops, bool has_ioc)
|
|
||||||
f->opaque = opaque;
|
|
||||||
f->ops = ops;
|
|
||||||
f->has_ioc = has_ioc;
|
|
||||||
+ f->buf_allocated_size = buffer_size;
|
|
||||||
+ f->buf = malloc(buffer_size);
|
|
||||||
+
|
|
||||||
return f;
|
|
||||||
}
|
|
||||||
|
|
||||||
+QEMUFile *qemu_fopen_ops(void *opaque, const QEMUFileOps *ops, bool has_ioc)
|
|
||||||
+{
|
|
||||||
+ return qemu_fopen_ops_sized(opaque, ops, has_ioc, DEFAULT_IO_BUF_SIZE);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
|
|
||||||
void qemu_file_set_hooks(QEMUFile *f, const QEMUFileHooks *hooks)
|
|
||||||
{
|
|
||||||
@@ -349,7 +358,7 @@ static ssize_t qemu_fill_buffer(QEMUFile *f)
|
|
||||||
}
|
|
||||||
|
|
||||||
len = f->ops->get_buffer(f->opaque, f->buf + pending, f->pos,
|
|
||||||
- IO_BUF_SIZE - pending, &local_error);
|
|
||||||
+ f->buf_allocated_size - pending, &local_error);
|
|
||||||
if (len > 0) {
|
|
||||||
f->buf_size += len;
|
|
||||||
f->pos += len;
|
|
||||||
@@ -389,6 +398,9 @@ int qemu_fclose(QEMUFile *f)
|
|
||||||
ret = ret2;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
+
|
|
||||||
+ free(f->buf);
|
|
||||||
+
|
|
||||||
/* If any error was spotted before closing, we should report it
|
|
||||||
* instead of the close() return value.
|
|
||||||
*/
|
|
||||||
@@ -443,7 +455,7 @@ static void add_buf_to_iovec(QEMUFile *f, size_t len)
|
|
||||||
{
|
|
||||||
if (!add_to_iovec(f, f->buf + f->buf_index, len, false)) {
|
|
||||||
f->buf_index += len;
|
|
||||||
- if (f->buf_index == IO_BUF_SIZE) {
|
|
||||||
+ if (f->buf_index == f->buf_allocated_size) {
|
|
||||||
qemu_fflush(f);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -469,7 +481,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, size_t size)
|
|
||||||
}
|
|
||||||
|
|
||||||
while (size > 0) {
|
|
||||||
- l = IO_BUF_SIZE - f->buf_index;
|
|
||||||
+ l = f->buf_allocated_size - f->buf_index;
|
|
||||||
if (l > size) {
|
|
||||||
l = size;
|
|
||||||
}
|
|
||||||
@@ -516,8 +528,8 @@ size_t qemu_peek_buffer(QEMUFile *f, uint8_t **buf, size_t size, size_t offset)
|
|
||||||
size_t index;
|
|
||||||
|
|
||||||
assert(!qemu_file_is_writable(f));
|
|
||||||
- assert(offset < IO_BUF_SIZE);
|
|
||||||
- assert(size <= IO_BUF_SIZE - offset);
|
|
||||||
+ assert(offset < f->buf_allocated_size);
|
|
||||||
+ assert(size <= f->buf_allocated_size - offset);
|
|
||||||
|
|
||||||
/* The 1st byte to read from */
|
|
||||||
index = f->buf_index + offset;
|
|
||||||
@@ -567,7 +579,7 @@ size_t qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size)
|
|
||||||
size_t res;
|
|
||||||
uint8_t *src;
|
|
||||||
|
|
||||||
- res = qemu_peek_buffer(f, &src, MIN(pending, IO_BUF_SIZE), 0);
|
|
||||||
+ res = qemu_peek_buffer(f, &src, MIN(pending, f->buf_allocated_size), 0);
|
|
||||||
if (res == 0) {
|
|
||||||
return done;
|
|
||||||
}
|
|
||||||
@@ -601,7 +613,7 @@ size_t qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size)
|
|
||||||
*/
|
|
||||||
size_t qemu_get_buffer_in_place(QEMUFile *f, uint8_t **buf, size_t size)
|
|
||||||
{
|
|
||||||
- if (size < IO_BUF_SIZE) {
|
|
||||||
+ if (size < f->buf_allocated_size) {
|
|
||||||
size_t res;
|
|
||||||
uint8_t *src = NULL;
|
|
||||||
|
|
||||||
@@ -626,7 +638,7 @@ int qemu_peek_byte(QEMUFile *f, int offset)
|
|
||||||
int index = f->buf_index + offset;
|
|
||||||
|
|
||||||
assert(!qemu_file_is_writable(f));
|
|
||||||
- assert(offset < IO_BUF_SIZE);
|
|
||||||
+ assert(offset < f->buf_allocated_size);
|
|
||||||
|
|
||||||
if (index >= f->buf_size) {
|
|
||||||
qemu_fill_buffer(f);
|
|
||||||
@@ -778,7 +790,7 @@ static int qemu_compress_data(z_stream *stream, uint8_t *dest, size_t dest_len,
|
|
||||||
ssize_t qemu_put_compression_data(QEMUFile *f, z_stream *stream,
|
|
||||||
const uint8_t *p, size_t size)
|
|
||||||
{
|
|
||||||
- ssize_t blen = IO_BUF_SIZE - f->buf_index - sizeof(int32_t);
|
|
||||||
+ ssize_t blen = f->buf_allocated_size - f->buf_index - sizeof(int32_t);
|
|
||||||
|
|
||||||
if (blen < compressBound(size)) {
|
|
||||||
return -1;
|
|
||||||
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
|
|
||||||
index 3f36d4dc8c..67501fd9cf 100644
|
|
||||||
--- a/migration/qemu-file.h
|
|
||||||
+++ b/migration/qemu-file.h
|
|
||||||
@@ -121,6 +121,7 @@ typedef struct QEMUFileHooks {
|
|
||||||
} QEMUFileHooks;
|
|
||||||
|
|
||||||
QEMUFile *qemu_fopen_ops(void *opaque, const QEMUFileOps *ops, bool has_ioc);
|
|
||||||
+QEMUFile *qemu_fopen_ops_sized(void *opaque, const QEMUFileOps *ops, bool has_ioc, size_t buffer_size);
|
|
||||||
void qemu_file_set_hooks(QEMUFile *f, const QEMUFileHooks *hooks);
|
|
||||||
int qemu_get_fd(QEMUFile *f);
|
|
||||||
int qemu_fclose(QEMUFile *f);
|
|
||||||
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
|
||||||
index 79a0cda906..970ee3b3fc 100644
|
|
||||||
--- a/migration/savevm-async.c
|
|
||||||
+++ b/migration/savevm-async.c
|
|
||||||
@@ -418,7 +418,7 @@ void qmp_savevm_start(bool has_statefile, const char *statefile, Error **errp)
|
|
||||||
goto restart;
|
|
||||||
}
|
|
||||||
|
|
||||||
- snap_state.file = qemu_fopen_ops(&snap_state, &block_file_ops);
|
|
||||||
+ snap_state.file = qemu_fopen_ops_sized(&snap_state, &block_file_ops, false, 4 * 1024 * 1024);
|
|
||||||
|
|
||||||
if (!snap_state.file) {
|
|
||||||
error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
|
||||||
@@ -567,7 +567,7 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
|
||||||
blk_op_block_all(be, blocker);
|
|
||||||
|
|
||||||
/* restore the VM state */
|
|
||||||
- f = qemu_fopen_ops(be, &loadstate_file_ops);
|
|
||||||
+ f = qemu_fopen_ops_sized(be, &loadstate_file_ops, false, 4 * 1024 * 1024);
|
|
||||||
if (!f) {
|
|
||||||
error_setg(errp, "Could not open VM state file");
|
|
||||||
goto the_end;
|
|
|
@ -21,28 +21,35 @@ still opened by QEMU.
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
||||||
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
[improve aborting]
|
[SR: improve aborting
|
||||||
|
register yank before migration_incoming_state_destroy]
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
|
[FE: further improve aborting
|
||||||
|
adapt to removal of QEMUFileOps
|
||||||
|
improve condition for entering final stage
|
||||||
|
adapt to QAPI and other changes for 8.2
|
||||||
|
make sure to not call vm_start() from coroutine]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
hmp-commands-info.hx | 13 +
|
hmp-commands-info.hx | 13 +
|
||||||
hmp-commands.hx | 33 ++
|
hmp-commands.hx | 17 ++
|
||||||
include/migration/snapshot.h | 2 +
|
include/migration/snapshot.h | 2 +
|
||||||
include/monitor/hmp.h | 5 +
|
include/monitor/hmp.h | 3 +
|
||||||
migration/meson.build | 1 +
|
migration/meson.build | 1 +
|
||||||
migration/savevm-async.c | 598 +++++++++++++++++++++++++++++++++++
|
migration/savevm-async.c | 538 +++++++++++++++++++++++++++++++++++
|
||||||
monitor/hmp-cmds.c | 57 ++++
|
monitor/hmp-cmds.c | 38 +++
|
||||||
qapi/migration.json | 34 ++
|
qapi/migration.json | 34 +++
|
||||||
qapi/misc.json | 32 ++
|
qapi/misc.json | 18 ++
|
||||||
qemu-options.hx | 12 +
|
qemu-options.hx | 12 +
|
||||||
softmmu/vl.c | 10 +
|
system/vl.c | 10 +
|
||||||
11 files changed, 797 insertions(+)
|
11 files changed, 686 insertions(+)
|
||||||
create mode 100644 migration/savevm-async.c
|
create mode 100644 migration/savevm-async.c
|
||||||
|
|
||||||
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
||||||
index 27206ac049..e6dd3be07a 100644
|
index ad1b1306e3..d5ab880492 100644
|
||||||
--- a/hmp-commands-info.hx
|
--- a/hmp-commands-info.hx
|
||||||
+++ b/hmp-commands-info.hx
|
+++ b/hmp-commands-info.hx
|
||||||
@@ -551,6 +551,19 @@ SRST
|
@@ -525,6 +525,19 @@ SRST
|
||||||
Show current migration parameters.
|
Show current migration parameters.
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
|
@ -63,13 +70,13 @@ index 27206ac049..e6dd3be07a 100644
|
||||||
.name = "balloon",
|
.name = "balloon",
|
||||||
.args_type = "",
|
.args_type = "",
|
||||||
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
||||||
index d78e4cfc47..42203dbe92 100644
|
index 2e2a3bcf98..7506de251c 100644
|
||||||
--- a/hmp-commands.hx
|
--- a/hmp-commands.hx
|
||||||
+++ b/hmp-commands.hx
|
+++ b/hmp-commands.hx
|
||||||
@@ -1744,3 +1744,36 @@ ERST
|
@@ -1862,3 +1862,20 @@ SRST
|
||||||
.help = "start a round of guest dirty rate measurement",
|
List event channels in the guest
|
||||||
.cmd = hmp_calc_dirty_rate,
|
ERST
|
||||||
},
|
#endif
|
||||||
+
|
+
|
||||||
+ {
|
+ {
|
||||||
+ .name = "savevm-start",
|
+ .name = "savevm-start",
|
||||||
|
@ -80,22 +87,6 @@ index d78e4cfc47..42203dbe92 100644
|
||||||
+ },
|
+ },
|
||||||
+
|
+
|
||||||
+ {
|
+ {
|
||||||
+ .name = "snapshot-drive",
|
|
||||||
+ .args_type = "device:s,name:s",
|
|
||||||
+ .params = "device name",
|
|
||||||
+ .help = "Create internal snapshot.",
|
|
||||||
+ .cmd = hmp_snapshot_drive,
|
|
||||||
+ },
|
|
||||||
+
|
|
||||||
+ {
|
|
||||||
+ .name = "delete-drive-snapshot",
|
|
||||||
+ .args_type = "device:s,name:s",
|
|
||||||
+ .params = "device name",
|
|
||||||
+ .help = "Delete internal snapshot.",
|
|
||||||
+ .cmd = hmp_delete_drive_snapshot,
|
|
||||||
+ },
|
|
||||||
+
|
|
||||||
+ {
|
|
||||||
+ .name = "savevm-end",
|
+ .name = "savevm-end",
|
||||||
+ .args_type = "",
|
+ .args_type = "",
|
||||||
+ .params = "",
|
+ .params = "",
|
||||||
|
@ -104,21 +95,21 @@ index d78e4cfc47..42203dbe92 100644
|
||||||
+ .coroutine = true,
|
+ .coroutine = true,
|
||||||
+ },
|
+ },
|
||||||
diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h
|
diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h
|
||||||
index e72083b117..c846d37806 100644
|
index 9e4dcaaa75..2581730d74 100644
|
||||||
--- a/include/migration/snapshot.h
|
--- a/include/migration/snapshot.h
|
||||||
+++ b/include/migration/snapshot.h
|
+++ b/include/migration/snapshot.h
|
||||||
@@ -61,4 +61,6 @@ bool delete_snapshot(const char *name,
|
@@ -68,4 +68,6 @@ bool delete_snapshot(const char *name,
|
||||||
bool has_devices, strList *devices,
|
*/
|
||||||
Error **errp);
|
void load_snapshot_resume(RunState state);
|
||||||
|
|
||||||
+int load_snapshot_from_blockdev(const char *filename, Error **errp);
|
+int load_snapshot_from_blockdev(const char *filename, Error **errp);
|
||||||
+
|
+
|
||||||
#endif
|
#endif
|
||||||
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
||||||
index 3baa1058e2..1247d7362a 100644
|
index 13f9a2dedb..7a7def7530 100644
|
||||||
--- a/include/monitor/hmp.h
|
--- a/include/monitor/hmp.h
|
||||||
+++ b/include/monitor/hmp.h
|
+++ b/include/monitor/hmp.h
|
||||||
@@ -25,6 +25,7 @@ void hmp_info_status(Monitor *mon, const QDict *qdict);
|
@@ -28,6 +28,7 @@ void hmp_info_status(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_uuid(Monitor *mon, const QDict *qdict);
|
void hmp_info_uuid(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_chardev(Monitor *mon, const QDict *qdict);
|
void hmp_info_chardev(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_mice(Monitor *mon, const QDict *qdict);
|
void hmp_info_mice(Monitor *mon, const QDict *qdict);
|
||||||
|
@ -126,37 +117,38 @@ index 3baa1058e2..1247d7362a 100644
|
||||||
void hmp_info_migrate(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict);
|
||||||
@@ -79,6 +80,10 @@ void hmp_netdev_add(Monitor *mon, const QDict *qdict);
|
@@ -94,6 +95,8 @@ void hmp_closefd(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_netdev_del(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_move(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_getfd(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_button(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_closefd(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_set(Monitor *mon, const QDict *qdict);
|
||||||
+void hmp_savevm_start(Monitor *mon, const QDict *qdict);
|
+void hmp_savevm_start(Monitor *mon, const QDict *qdict);
|
||||||
+void hmp_snapshot_drive(Monitor *mon, const QDict *qdict);
|
|
||||||
+void hmp_delete_drive_snapshot(Monitor *mon, const QDict *qdict);
|
|
||||||
+void hmp_savevm_end(Monitor *mon, const QDict *qdict);
|
+void hmp_savevm_end(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_sendkey(Monitor *mon, const QDict *qdict);
|
void hmp_sendkey(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_screendump(Monitor *mon, const QDict *qdict);
|
void coroutine_fn hmp_screendump(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_chardev_add(Monitor *mon, const QDict *qdict);
|
void hmp_chardev_add(Monitor *mon, const QDict *qdict);
|
||||||
diff --git a/migration/meson.build b/migration/meson.build
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
index f8714dcb15..ea9aedeefc 100644
|
index 95d1cf2250..800f12a60d 100644
|
||||||
--- a/migration/meson.build
|
--- a/migration/meson.build
|
||||||
+++ b/migration/meson.build
|
+++ b/migration/meson.build
|
||||||
@@ -23,6 +23,7 @@ softmmu_ss.add(files(
|
@@ -28,6 +28,7 @@ system_ss.add(files(
|
||||||
'multifd-zlib.c',
|
'options.c',
|
||||||
'postcopy-ram.c',
|
'postcopy-ram.c',
|
||||||
'savevm.c',
|
'savevm.c',
|
||||||
+ 'savevm-async.c',
|
+ 'savevm-async.c',
|
||||||
'socket.c',
|
'socket.c',
|
||||||
'tls.c',
|
'tls.c',
|
||||||
), gnutls)
|
'threadinfo.c',
|
||||||
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..79a0cda906
|
index 0000000000..72cf6588c2
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/migration/savevm-async.c
|
+++ b/migration/savevm-async.c
|
||||||
@@ -0,0 +1,598 @@
|
@@ -0,0 +1,538 @@
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
|
+#include "migration/channel-savevm-async.h"
|
||||||
+#include "migration/migration.h"
|
+#include "migration/migration.h"
|
||||||
|
+#include "migration/migration-stats.h"
|
||||||
|
+#include "migration/options.h"
|
||||||
+#include "migration/savevm.h"
|
+#include "migration/savevm.h"
|
||||||
+#include "migration/snapshot.h"
|
+#include "migration/snapshot.h"
|
||||||
+#include "migration/global_state.h"
|
+#include "migration/global_state.h"
|
||||||
|
@ -176,12 +168,10 @@ index 0000000000..79a0cda906
|
||||||
+#include "qemu/timer.h"
|
+#include "qemu/timer.h"
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
+#include "qemu/rcu.h"
|
+#include "qemu/rcu.h"
|
||||||
|
+#include "qemu/yank.h"
|
||||||
+
|
+
|
||||||
+/* #define DEBUG_SAVEVM_STATE */
|
+/* #define DEBUG_SAVEVM_STATE */
|
||||||
+
|
+
|
||||||
+/* used while emulated sync operation in progress */
|
|
||||||
+#define NOT_DONE -EINPROGRESS
|
|
||||||
+
|
|
||||||
+#ifdef DEBUG_SAVEVM_STATE
|
+#ifdef DEBUG_SAVEVM_STATE
|
||||||
+#define DPRINTF(fmt, ...) \
|
+#define DPRINTF(fmt, ...) \
|
||||||
+ do { printf("savevm-async: " fmt, ## __VA_ARGS__); } while (0)
|
+ do { printf("savevm-async: " fmt, ## __VA_ARGS__); } while (0)
|
||||||
|
@ -210,7 +200,7 @@ index 0000000000..79a0cda906
|
||||||
+ int64_t total_time;
|
+ int64_t total_time;
|
||||||
+ QEMUBH *finalize_bh;
|
+ QEMUBH *finalize_bh;
|
||||||
+ Coroutine *co;
|
+ Coroutine *co;
|
||||||
+ QemuCoSleep *target_close_wait;
|
+ QemuCoSleep target_close_wait;
|
||||||
+} snap_state;
|
+} snap_state;
|
||||||
+
|
+
|
||||||
+static bool savevm_aborted(void)
|
+static bool savevm_aborted(void)
|
||||||
|
@ -229,24 +219,20 @@ index 0000000000..79a0cda906
|
||||||
+ info->bytes = s->bs_pos;
|
+ info->bytes = s->bs_pos;
|
||||||
+ switch (s->state) {
|
+ switch (s->state) {
|
||||||
+ case SAVE_STATE_ERROR:
|
+ case SAVE_STATE_ERROR:
|
||||||
+ info->has_status = true;
|
|
||||||
+ info->status = g_strdup("failed");
|
+ info->status = g_strdup("failed");
|
||||||
+ info->has_total_time = true;
|
+ info->has_total_time = true;
|
||||||
+ info->total_time = s->total_time;
|
+ info->total_time = s->total_time;
|
||||||
+ if (s->error) {
|
+ if (s->error) {
|
||||||
+ info->has_error = true;
|
|
||||||
+ info->error = g_strdup(error_get_pretty(s->error));
|
+ info->error = g_strdup(error_get_pretty(s->error));
|
||||||
+ }
|
+ }
|
||||||
+ break;
|
+ break;
|
||||||
+ case SAVE_STATE_ACTIVE:
|
+ case SAVE_STATE_ACTIVE:
|
||||||
+ info->has_status = true;
|
|
||||||
+ info->status = g_strdup("active");
|
+ info->status = g_strdup("active");
|
||||||
+ info->has_total_time = true;
|
+ info->has_total_time = true;
|
||||||
+ info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
|
+ info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
|
||||||
+ - s->total_time;
|
+ - s->total_time;
|
||||||
+ break;
|
+ break;
|
||||||
+ case SAVE_STATE_COMPLETED:
|
+ case SAVE_STATE_COMPLETED:
|
||||||
+ info->has_status = true;
|
|
||||||
+ info->status = g_strdup("completed");
|
+ info->status = g_strdup("completed");
|
||||||
+ info->has_total_time = true;
|
+ info->has_total_time = true;
|
||||||
+ info->total_time = s->total_time;
|
+ info->total_time = s->total_time;
|
||||||
|
@ -268,6 +254,7 @@ index 0000000000..79a0cda906
|
||||||
+
|
+
|
||||||
+ if (snap_state.file) {
|
+ if (snap_state.file) {
|
||||||
+ ret = qemu_fclose(snap_state.file);
|
+ ret = qemu_fclose(snap_state.file);
|
||||||
|
+ snap_state.file = NULL;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (snap_state.target) {
|
+ if (snap_state.target) {
|
||||||
|
@ -285,15 +272,13 @@ index 0000000000..79a0cda906
|
||||||
+ blk_unref(snap_state.target);
|
+ blk_unref(snap_state.target);
|
||||||
+ snap_state.target = NULL;
|
+ snap_state.target = NULL;
|
||||||
+
|
+
|
||||||
+ if (snap_state.target_close_wait) {
|
+ qemu_co_sleep_wake(&snap_state.target_close_wait);
|
||||||
+ qemu_co_sleep_wake(snap_state.target_close_wait);
|
|
||||||
+ }
|
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ return ret;
|
+ return ret;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void save_snapshot_error(const char *fmt, ...)
|
+static void G_GNUC_PRINTF(1, 2) save_snapshot_error(const char *fmt, ...)
|
||||||
+{
|
+{
|
||||||
+ va_list ap;
|
+ va_list ap;
|
||||||
+ char *msg;
|
+ char *msg;
|
||||||
|
@ -313,64 +298,9 @@ index 0000000000..79a0cda906
|
||||||
+ snap_state.state = SAVE_STATE_ERROR;
|
+ snap_state.state = SAVE_STATE_ERROR;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int block_state_close(void *opaque, Error **errp)
|
|
||||||
+{
|
|
||||||
+ snap_state.file = NULL;
|
|
||||||
+ return blk_flush(snap_state.target);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+typedef struct BlkRwCo {
|
|
||||||
+ int64_t offset;
|
|
||||||
+ QEMUIOVector *qiov;
|
|
||||||
+ ssize_t ret;
|
|
||||||
+} BlkRwCo;
|
|
||||||
+
|
|
||||||
+static void coroutine_fn block_state_write_entry(void *opaque) {
|
|
||||||
+ BlkRwCo *rwco = opaque;
|
|
||||||
+ rwco->ret = blk_co_pwritev(snap_state.target, rwco->offset, rwco->qiov->size,
|
|
||||||
+ rwco->qiov, 0);
|
|
||||||
+ aio_wait_kick();
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static ssize_t block_state_writev_buffer(void *opaque, struct iovec *iov,
|
|
||||||
+ int iovcnt, int64_t pos, Error **errp)
|
|
||||||
+{
|
|
||||||
+ QEMUIOVector qiov;
|
|
||||||
+ BlkRwCo rwco;
|
|
||||||
+
|
|
||||||
+ assert(pos == snap_state.bs_pos);
|
|
||||||
+ rwco = (BlkRwCo) {
|
|
||||||
+ .offset = pos,
|
|
||||||
+ .qiov = &qiov,
|
|
||||||
+ .ret = NOT_DONE,
|
|
||||||
+ };
|
|
||||||
+
|
|
||||||
+ qemu_iovec_init_external(&qiov, iov, iovcnt);
|
|
||||||
+
|
|
||||||
+ if (qemu_in_coroutine()) {
|
|
||||||
+ block_state_write_entry(&rwco);
|
|
||||||
+ } else {
|
|
||||||
+ Coroutine *co = qemu_coroutine_create(&block_state_write_entry, &rwco);
|
|
||||||
+ bdrv_coroutine_enter(blk_bs(snap_state.target), co);
|
|
||||||
+ BDRV_POLL_WHILE(blk_bs(snap_state.target), rwco.ret == NOT_DONE);
|
|
||||||
+ }
|
|
||||||
+ if (rwco.ret < 0) {
|
|
||||||
+ return rwco.ret;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ snap_state.bs_pos += qiov.size;
|
|
||||||
+ return qiov.size;
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static const QEMUFileOps block_file_ops = {
|
|
||||||
+ .writev_buffer = block_state_writev_buffer,
|
|
||||||
+ .close = block_state_close,
|
|
||||||
+};
|
|
||||||
+
|
|
||||||
+static void process_savevm_finalize(void *opaque)
|
+static void process_savevm_finalize(void *opaque)
|
||||||
+{
|
+{
|
||||||
+ int ret;
|
+ int ret;
|
||||||
+ AioContext *iohandler_ctx = iohandler_get_aio_context();
|
|
||||||
+ MigrationState *ms = migrate_get_current();
|
+ MigrationState *ms = migrate_get_current();
|
||||||
+
|
+
|
||||||
+ bool aborted = savevm_aborted();
|
+ bool aborted = savevm_aborted();
|
||||||
|
@ -387,9 +317,7 @@ index 0000000000..79a0cda906
|
||||||
+ * so move it back. It can stay in the main context and live out its live
|
+ * so move it back. It can stay in the main context and live out its live
|
||||||
+ * there, since we're done with it after this method ends anyway.
|
+ * there, since we're done with it after this method ends anyway.
|
||||||
+ */
|
+ */
|
||||||
+ aio_context_acquire(iohandler_ctx);
|
|
||||||
+ blk_set_aio_context(snap_state.target, qemu_get_aio_context(), NULL);
|
+ blk_set_aio_context(snap_state.target, qemu_get_aio_context(), NULL);
|
||||||
+ aio_context_release(iohandler_ctx);
|
|
||||||
+
|
+
|
||||||
+ ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
|
+ ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
|
@ -401,7 +329,7 @@ index 0000000000..79a0cda906
|
||||||
+ (void)qemu_savevm_state_complete_precopy(snap_state.file, false, false);
|
+ (void)qemu_savevm_state_complete_precopy(snap_state.file, false, false);
|
||||||
+ ret = qemu_file_get_error(snap_state.file);
|
+ ret = qemu_file_get_error(snap_state.file);
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
+ save_snapshot_error("qemu_savevm_state_iterate error %d", ret);
|
+ save_snapshot_error("qemu_savevm_state_complete_precopy error %d", ret);
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
@ -422,8 +350,11 @@ index 0000000000..79a0cda906
|
||||||
+ } else if (snap_state.state == SAVE_STATE_ACTIVE) {
|
+ } else if (snap_state.state == SAVE_STATE_ACTIVE) {
|
||||||
+ snap_state.state = SAVE_STATE_COMPLETED;
|
+ snap_state.state = SAVE_STATE_COMPLETED;
|
||||||
+ } else if (aborted) {
|
+ } else if (aborted) {
|
||||||
+ save_snapshot_error("process_savevm_cleanup: found aborted state: %d",
|
+ /*
|
||||||
+ snap_state.state);
|
+ * If there was an error, there's no need to set a new one here.
|
||||||
|
+ * If the snapshot was canceled, leave setting the state to
|
||||||
|
+ * qmp_savevm_end(), which is waked by save_snapshot_cleanup().
|
||||||
|
+ */
|
||||||
+ } else {
|
+ } else {
|
||||||
+ save_snapshot_error("process_savevm_cleanup: invalid state: %d",
|
+ save_snapshot_error("process_savevm_cleanup: invalid state: %d",
|
||||||
+ snap_state.state);
|
+ snap_state.state);
|
||||||
|
@ -455,18 +386,32 @@ index 0000000000..79a0cda906
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ while (snap_state.state == SAVE_STATE_ACTIVE) {
|
+ while (snap_state.state == SAVE_STATE_ACTIVE) {
|
||||||
+ uint64_t pending_size, pend_precopy, pend_compatible, pend_postcopy;
|
+ uint64_t pending_size, pend_precopy, pend_postcopy;
|
||||||
|
+ uint64_t threshold = 400 * 1000;
|
||||||
+
|
+
|
||||||
+ /* pending is expected to be called without iothread lock */
|
+ /*
|
||||||
+ qemu_mutex_unlock_iothread();
|
+ * pending_{estimate,exact} are expected to be called without iothread
|
||||||
+ qemu_savevm_state_pending(snap_state.file, 0, &pend_precopy, &pend_compatible, &pend_postcopy);
|
+ * lock. Similar to what is done in migration.c, call the exact variant
|
||||||
+ qemu_mutex_lock_iothread();
|
+ * only once pend_precopy in the estimate is below the threshold.
|
||||||
|
+ */
|
||||||
|
+ bql_unlock();
|
||||||
|
+ qemu_savevm_state_pending_estimate(&pend_precopy, &pend_postcopy);
|
||||||
|
+ if (pend_precopy <= threshold) {
|
||||||
|
+ qemu_savevm_state_pending_exact(&pend_precopy, &pend_postcopy);
|
||||||
|
+ }
|
||||||
|
+ bql_lock();
|
||||||
|
+ pending_size = pend_precopy + pend_postcopy;
|
||||||
+
|
+
|
||||||
+ pending_size = pend_precopy + pend_compatible + pend_postcopy;
|
+ /*
|
||||||
|
+ * A guest reaching this cutoff is dirtying lots of RAM. It should be
|
||||||
|
+ * large enough so that the guest can't dirty this much between the
|
||||||
|
+ * check and the guest actually being stopped, but it should be small
|
||||||
|
+ * enough to avoid long downtimes for non-hibernation snapshots.
|
||||||
|
+ */
|
||||||
|
+ maxlen = blk_getlength(snap_state.target) - 100*1024*1024;
|
||||||
+
|
+
|
||||||
+ maxlen = blk_getlength(snap_state.target) - 30*1024*1024;
|
+ /* Note that there is no progress for pend_postcopy when iterating */
|
||||||
+
|
+ if (pend_precopy > threshold && snap_state.bs_pos + pending_size < maxlen) {
|
||||||
+ if (pending_size > 400000 && snap_state.bs_pos + pending_size < maxlen) {
|
|
||||||
+ ret = qemu_savevm_state_iterate(snap_state.file, false);
|
+ ret = qemu_savevm_state_iterate(snap_state.file, false);
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
+ save_snapshot_error("qemu_savevm_state_iterate error %d", ret);
|
+ save_snapshot_error("qemu_savevm_state_iterate error %d", ret);
|
||||||
|
@ -475,11 +420,7 @@ index 0000000000..79a0cda906
|
||||||
+ DPRINTF("savevm iterate pending size %lu ret %d\n", pending_size, ret);
|
+ DPRINTF("savevm iterate pending size %lu ret %d\n", pending_size, ret);
|
||||||
+ } else {
|
+ } else {
|
||||||
+ qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER, NULL);
|
+ qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER, NULL);
|
||||||
+ ret = global_state_store();
|
+ global_state_store();
|
||||||
+ if (ret) {
|
|
||||||
+ save_snapshot_error("global_state_store error %d", ret);
|
|
||||||
+ break;
|
|
||||||
+ }
|
|
||||||
+
|
+
|
||||||
+ DPRINTF("savevm iterate complete\n");
|
+ DPRINTF("savevm iterate complete\n");
|
||||||
+ break;
|
+ break;
|
||||||
|
@ -498,19 +439,25 @@ index 0000000000..79a0cda906
|
||||||
+ * so move there now and after every flush.
|
+ * so move there now and after every flush.
|
||||||
+ */
|
+ */
|
||||||
+ aio_co_reschedule_self(qemu_get_aio_context());
|
+ aio_co_reschedule_self(qemu_get_aio_context());
|
||||||
+ for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
|
+ bdrv_graph_co_rdlock();
|
||||||
|
+ bs = bdrv_first(&it);
|
||||||
|
+ bdrv_graph_co_rdunlock();
|
||||||
|
+ while (bs) {
|
||||||
+ /* target has BDRV_O_NO_FLUSH, no sense calling bdrv_flush on it */
|
+ /* target has BDRV_O_NO_FLUSH, no sense calling bdrv_flush on it */
|
||||||
+ if (bs == blk_bs(snap_state.target)) {
|
+ if (bs != blk_bs(snap_state.target)) {
|
||||||
+ continue;
|
+ AioContext *bs_ctx = bdrv_get_aio_context(bs);
|
||||||
+ }
|
+ if (bs_ctx != qemu_get_aio_context()) {
|
||||||
+
|
+ DPRINTF("savevm: async flushing drive %s\n", bs->filename);
|
||||||
+ AioContext *bs_ctx = bdrv_get_aio_context(bs);
|
+ aio_co_reschedule_self(bs_ctx);
|
||||||
+ if (bs_ctx != qemu_get_aio_context()) {
|
+ bdrv_graph_co_rdlock();
|
||||||
+ DPRINTF("savevm: async flushing drive %s\n", bs->filename);
|
+ bdrv_flush(bs);
|
||||||
+ aio_co_reschedule_self(bs_ctx);
|
+ bdrv_graph_co_rdunlock();
|
||||||
+ bdrv_flush(bs);
|
+ aio_co_reschedule_self(qemu_get_aio_context());
|
||||||
+ aio_co_reschedule_self(qemu_get_aio_context());
|
+ }
|
||||||
+ }
|
+ }
|
||||||
|
+ bdrv_graph_co_rdlock();
|
||||||
|
+ bs = bdrv_next(&it);
|
||||||
|
+ bdrv_graph_co_rdunlock();
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ DPRINTF("timing: async flushing took %ld ms\n",
|
+ DPRINTF("timing: async flushing took %ld ms\n",
|
||||||
|
@ -519,7 +466,7 @@ index 0000000000..79a0cda906
|
||||||
+ qemu_bh_schedule(snap_state.finalize_bh);
|
+ qemu_bh_schedule(snap_state.finalize_bh);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+void qmp_savevm_start(bool has_statefile, const char *statefile, Error **errp)
|
+void qmp_savevm_start(const char *statefile, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ Error *local_err = NULL;
|
+ Error *local_err = NULL;
|
||||||
+ MigrationState *ms = migrate_get_current();
|
+ MigrationState *ms = migrate_get_current();
|
||||||
|
@ -533,12 +480,12 @@ index 0000000000..79a0cda906
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (migration_is_running(ms->state)) {
|
+ if (migration_is_running()) {
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, QERR_MIGRATION_ACTIVE);
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, QERR_MIGRATION_ACTIVE);
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (migrate_use_block()) {
|
+ if (migrate_block()) {
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
||||||
+ "Block migration and snapshots are incompatible");
|
+ "Block migration and snapshots are incompatible");
|
||||||
+ return;
|
+ return;
|
||||||
|
@ -549,13 +496,14 @@ index 0000000000..79a0cda906
|
||||||
+ snap_state.bs_pos = 0;
|
+ snap_state.bs_pos = 0;
|
||||||
+ snap_state.total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
|
+ snap_state.total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
|
||||||
+ snap_state.blocker = NULL;
|
+ snap_state.blocker = NULL;
|
||||||
|
+ snap_state.target_close_wait = (QemuCoSleep){ .to_wake = NULL };
|
||||||
+
|
+
|
||||||
+ if (snap_state.error) {
|
+ if (snap_state.error) {
|
||||||
+ error_free(snap_state.error);
|
+ error_free(snap_state.error);
|
||||||
+ snap_state.error = NULL;
|
+ snap_state.error = NULL;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (!has_statefile) {
|
+ if (!statefile) {
|
||||||
+ vm_stop(RUN_STATE_SAVE_VM);
|
+ vm_stop(RUN_STATE_SAVE_VM);
|
||||||
+ snap_state.state = SAVE_STATE_COMPLETED;
|
+ snap_state.state = SAVE_STATE_COMPLETED;
|
||||||
+ return;
|
+ return;
|
||||||
|
@ -575,7 +523,9 @@ index 0000000000..79a0cda906
|
||||||
+ goto restart;
|
+ goto restart;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ snap_state.file = qemu_fopen_ops(&snap_state, &block_file_ops);
|
+ QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(snap_state.target,
|
||||||
|
+ &snap_state.bs_pos));
|
||||||
|
+ snap_state.file = qemu_file_new_output(ioc);
|
||||||
+
|
+
|
||||||
+ if (!snap_state.file) {
|
+ if (!snap_state.file) {
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
||||||
|
@ -587,8 +537,10 @@ index 0000000000..79a0cda906
|
||||||
+ * State is cleared in process_savevm_co, but has to be initialized
|
+ * State is cleared in process_savevm_co, but has to be initialized
|
||||||
+ * here (blocking main thread, from QMP) to avoid race conditions.
|
+ * here (blocking main thread, from QMP) to avoid race conditions.
|
||||||
+ */
|
+ */
|
||||||
+ migrate_init(ms);
|
+ if (migrate_init(ms, errp)) {
|
||||||
+ memset(&ram_counters, 0, sizeof(ram_counters));
|
+ return;
|
||||||
|
+ }
|
||||||
|
+ memset(&mig_stats, 0, sizeof(mig_stats));
|
||||||
+ ms->to_dst_file = snap_state.file;
|
+ ms->to_dst_file = snap_state.file;
|
||||||
+
|
+
|
||||||
+ error_setg(&snap_state.blocker, "block device is in use by savevm");
|
+ error_setg(&snap_state.blocker, "block device is in use by savevm");
|
||||||
|
@ -597,10 +549,8 @@ index 0000000000..79a0cda906
|
||||||
+ snap_state.state = SAVE_STATE_ACTIVE;
|
+ snap_state.state = SAVE_STATE_ACTIVE;
|
||||||
+ snap_state.finalize_bh = qemu_bh_new(process_savevm_finalize, &snap_state);
|
+ snap_state.finalize_bh = qemu_bh_new(process_savevm_finalize, &snap_state);
|
||||||
+ snap_state.co = qemu_coroutine_create(&process_savevm_co, NULL);
|
+ snap_state.co = qemu_coroutine_create(&process_savevm_co, NULL);
|
||||||
+ qemu_mutex_unlock_iothread();
|
|
||||||
+ qemu_savevm_state_header(snap_state.file);
|
+ qemu_savevm_state_header(snap_state.file);
|
||||||
+ qemu_savevm_state_setup(snap_state.file);
|
+ qemu_savevm_state_setup(snap_state.file);
|
||||||
+ qemu_mutex_lock_iothread();
|
|
||||||
+
|
+
|
||||||
+ /* Async processing from here on out happens in iohandler context, so let
|
+ /* Async processing from here on out happens in iohandler context, so let
|
||||||
+ * the target bdrv have its home there.
|
+ * the target bdrv have its home there.
|
||||||
|
@ -621,29 +571,10 @@ index 0000000000..79a0cda906
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+void coroutine_fn qmp_savevm_end(Error **errp)
|
+static void coroutine_fn wait_for_close_co(void *opaque)
|
||||||
+{
|
+{
|
||||||
+ int64_t timeout;
|
+ int64_t timeout;
|
||||||
+
|
+
|
||||||
+ if (snap_state.state == SAVE_STATE_DONE) {
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
+ "VM snapshot not started\n");
|
|
||||||
+ return;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (snap_state.state == SAVE_STATE_ACTIVE) {
|
|
||||||
+ snap_state.state = SAVE_STATE_CANCELLED;
|
|
||||||
+ goto wait_for_close;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (snap_state.saved_vm_running) {
|
|
||||||
+ vm_start();
|
|
||||||
+ snap_state.saved_vm_running = false;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ snap_state.state = SAVE_STATE_DONE;
|
|
||||||
+
|
|
||||||
+wait_for_close:
|
|
||||||
+ if (!snap_state.target) {
|
+ if (!snap_state.target) {
|
||||||
+ DPRINTF("savevm-end: no target file open\n");
|
+ DPRINTF("savevm-end: no target file open\n");
|
||||||
+ return;
|
+ return;
|
||||||
|
@ -653,9 +584,8 @@ index 0000000000..79a0cda906
|
||||||
+ * call exits the statefile will be closed and can be removed immediately */
|
+ * call exits the statefile will be closed and can be removed immediately */
|
||||||
+ DPRINTF("savevm-end: waiting for cleanup\n");
|
+ DPRINTF("savevm-end: waiting for cleanup\n");
|
||||||
+ timeout = 30L * 1000 * 1000 * 1000;
|
+ timeout = 30L * 1000 * 1000 * 1000;
|
||||||
+ qemu_co_sleep_ns_wakeable(snap_state.target_close_wait,
|
+ qemu_co_sleep_ns_wakeable(&snap_state.target_close_wait,
|
||||||
+ QEMU_CLOCK_REALTIME, timeout);
|
+ QEMU_CLOCK_REALTIME, timeout);
|
||||||
+ snap_state.target_close_wait = NULL;
|
|
||||||
+ if (snap_state.target) {
|
+ if (snap_state.target) {
|
||||||
+ save_snapshot_error("timeout waiting for target file close in "
|
+ save_snapshot_error("timeout waiting for target file close in "
|
||||||
+ "qmp_savevm_end");
|
+ "qmp_savevm_end");
|
||||||
|
@ -664,45 +594,39 @@ index 0000000000..79a0cda906
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
+ // File closed and no other error, so ensure next snapshot can be started.
|
||||||
|
+ if (snap_state.state != SAVE_STATE_ERROR) {
|
||||||
|
+ snap_state.state = SAVE_STATE_DONE;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
+ DPRINTF("savevm-end: cleanup done\n");
|
+ DPRINTF("savevm-end: cleanup done\n");
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+// FIXME: Deprecated
|
+void qmp_savevm_end(Error **errp)
|
||||||
+void qmp_snapshot_drive(const char *device, const char *name, Error **errp)
|
|
||||||
+{
|
+{
|
||||||
+ // Compatibility to older qemu-server.
|
+ if (snap_state.state == SAVE_STATE_DONE) {
|
||||||
+ qmp_blockdev_snapshot_internal_sync(device, name, errp);
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
||||||
+}
|
+ "VM snapshot not started\n");
|
||||||
+
|
+ return;
|
||||||
+// FIXME: Deprecated
|
|
||||||
+void qmp_delete_drive_snapshot(const char *device, const char *name,
|
|
||||||
+ Error **errp)
|
|
||||||
+{
|
|
||||||
+ // Compatibility to older qemu-server.
|
|
||||||
+ (void)qmp_blockdev_snapshot_delete_internal_sync(device, false, NULL,
|
|
||||||
+ true, name, errp);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static ssize_t loadstate_get_buffer(void *opaque, uint8_t *buf, int64_t pos,
|
|
||||||
+ size_t size, Error **errp)
|
|
||||||
+{
|
|
||||||
+ BlockBackend *be = opaque;
|
|
||||||
+ int64_t maxlen = blk_getlength(be);
|
|
||||||
+ if (pos > maxlen) {
|
|
||||||
+ return -EIO;
|
|
||||||
+ }
|
+ }
|
||||||
+ if ((pos + size) > maxlen) {
|
|
||||||
+ size = maxlen - pos - 1;
|
|
||||||
+ }
|
|
||||||
+ if (size == 0) {
|
|
||||||
+ return 0;
|
|
||||||
+ }
|
|
||||||
+ return blk_pread(be, pos, buf, size);
|
|
||||||
+}
|
|
||||||
+
|
+
|
||||||
+static const QEMUFileOps loadstate_file_ops = {
|
+ Coroutine *wait_for_close = qemu_coroutine_create(wait_for_close_co, NULL);
|
||||||
+ .get_buffer = loadstate_get_buffer,
|
+
|
||||||
+};
|
+ if (snap_state.state == SAVE_STATE_ACTIVE) {
|
||||||
|
+ snap_state.state = SAVE_STATE_CANCELLED;
|
||||||
|
+ qemu_coroutine_enter(wait_for_close);
|
||||||
|
+ return;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (snap_state.saved_vm_running) {
|
||||||
|
+ vm_start();
|
||||||
|
+ snap_state.saved_vm_running = false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ snap_state.state = SAVE_STATE_DONE;
|
||||||
|
+
|
||||||
|
+ qemu_coroutine_enter(wait_for_close);
|
||||||
|
+}
|
||||||
+
|
+
|
||||||
+int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
+int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
||||||
+{
|
+{
|
||||||
|
@ -711,6 +635,7 @@ index 0000000000..79a0cda906
|
||||||
+ Error *blocker = NULL;
|
+ Error *blocker = NULL;
|
||||||
+
|
+
|
||||||
+ QEMUFile *f;
|
+ QEMUFile *f;
|
||||||
|
+ size_t bs_pos = 0;
|
||||||
+ int ret = -EINVAL;
|
+ int ret = -EINVAL;
|
||||||
+
|
+
|
||||||
+ be = blk_new_open(filename, NULL, NULL, 0, &local_err);
|
+ be = blk_new_open(filename, NULL, NULL, 0, &local_err);
|
||||||
|
@ -724,7 +649,7 @@ index 0000000000..79a0cda906
|
||||||
+ blk_op_block_all(be, blocker);
|
+ blk_op_block_all(be, blocker);
|
||||||
+
|
+
|
||||||
+ /* restore the VM state */
|
+ /* restore the VM state */
|
||||||
+ f = qemu_fopen_ops(be, &loadstate_file_ops);
|
+ f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
||||||
+ if (!f) {
|
+ if (!f) {
|
||||||
+ error_setg(errp, "Could not open VM state file");
|
+ error_setg(errp, "Could not open VM state file");
|
||||||
+ goto the_end;
|
+ goto the_end;
|
||||||
|
@ -737,6 +662,10 @@ index 0000000000..79a0cda906
|
||||||
+ dirty_bitmap_mig_before_vm_start();
|
+ dirty_bitmap_mig_before_vm_start();
|
||||||
+
|
+
|
||||||
+ qemu_fclose(f);
|
+ qemu_fclose(f);
|
||||||
|
+
|
||||||
|
+ /* state_destroy assumes a real migration which would have added a yank */
|
||||||
|
+ yank_register_instance(MIGRATION_YANK_INSTANCE, &error_abort);
|
||||||
|
+
|
||||||
+ migration_incoming_state_destroy();
|
+ migration_incoming_state_destroy();
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
+ error_setg_errno(errp, -ret, "Error while loading VM state");
|
+ error_setg_errno(errp, -ret, "Error while loading VM state");
|
||||||
|
@ -754,39 +683,28 @@ index 0000000000..79a0cda906
|
||||||
+ return ret;
|
+ return ret;
|
||||||
+}
|
+}
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
||||||
index c8b97909e7..64a84cf4ee 100644
|
index 871898ac46..ef4634e5c1 100644
|
||||||
--- a/monitor/hmp-cmds.c
|
--- a/monitor/hmp-cmds.c
|
||||||
+++ b/monitor/hmp-cmds.c
|
+++ b/monitor/hmp-cmds.c
|
||||||
@@ -1961,6 +1961,63 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
|
@@ -22,6 +22,7 @@
|
||||||
hmp_handle_error(mon, err);
|
#include "monitor/monitor-internal.h"
|
||||||
}
|
#include "qapi/error.h"
|
||||||
|
#include "qapi/qapi-commands-control.h"
|
||||||
|
+#include "qapi/qapi-commands-migration.h"
|
||||||
|
#include "qapi/qapi-commands-misc.h"
|
||||||
|
#include "qapi/qmp/qdict.h"
|
||||||
|
#include "qemu/cutils.h"
|
||||||
|
@@ -443,3 +444,40 @@ void hmp_info_mtree(Monitor *mon, const QDict *qdict)
|
||||||
|
|
||||||
|
mtree_info(flatview, dispatch_tree, owner, disabled);
|
||||||
|
}
|
||||||
|
+
|
||||||
+void hmp_savevm_start(Monitor *mon, const QDict *qdict)
|
+void hmp_savevm_start(Monitor *mon, const QDict *qdict)
|
||||||
+{
|
+{
|
||||||
+ Error *errp = NULL;
|
+ Error *errp = NULL;
|
||||||
+ const char *statefile = qdict_get_try_str(qdict, "statefile");
|
+ const char *statefile = qdict_get_try_str(qdict, "statefile");
|
||||||
+
|
+
|
||||||
+ qmp_savevm_start(statefile != NULL, statefile, &errp);
|
+ qmp_savevm_start(statefile, &errp);
|
||||||
+ hmp_handle_error(mon, errp);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+void hmp_snapshot_drive(Monitor *mon, const QDict *qdict)
|
|
||||||
+{
|
|
||||||
+ Error *errp = NULL;
|
|
||||||
+ const char *name = qdict_get_str(qdict, "name");
|
|
||||||
+ const char *device = qdict_get_str(qdict, "device");
|
|
||||||
+
|
|
||||||
+ qmp_snapshot_drive(device, name, &errp);
|
|
||||||
+ hmp_handle_error(mon, errp);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+void hmp_delete_drive_snapshot(Monitor *mon, const QDict *qdict)
|
|
||||||
+{
|
|
||||||
+ Error *errp = NULL;
|
|
||||||
+ const char *name = qdict_get_str(qdict, "name");
|
|
||||||
+ const char *device = qdict_get_str(qdict, "device");
|
|
||||||
+
|
|
||||||
+ qmp_delete_drive_snapshot(device, name, &errp);
|
|
||||||
+ hmp_handle_error(mon, errp);
|
+ hmp_handle_error(mon, errp);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
@ -803,7 +721,7 @@ index c8b97909e7..64a84cf4ee 100644
|
||||||
+ SaveVMInfo *info;
|
+ SaveVMInfo *info;
|
||||||
+ info = qmp_query_savevm(NULL);
|
+ info = qmp_query_savevm(NULL);
|
||||||
+
|
+
|
||||||
+ if (info->has_status) {
|
+ if (info->status) {
|
||||||
+ monitor_printf(mon, "savevm status: %s\n", info->status);
|
+ monitor_printf(mon, "savevm status: %s\n", info->status);
|
||||||
+ monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
|
+ monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
|
||||||
+ info->total_time);
|
+ info->total_time);
|
||||||
|
@ -813,21 +731,17 @@ index c8b97909e7..64a84cf4ee 100644
|
||||||
+ if (info->has_bytes) {
|
+ if (info->has_bytes) {
|
||||||
+ monitor_printf(mon, "Bytes saved: %"PRIu64"\n", info->bytes);
|
+ monitor_printf(mon, "Bytes saved: %"PRIu64"\n", info->bytes);
|
||||||
+ }
|
+ }
|
||||||
+ if (info->has_error) {
|
+ if (info->error) {
|
||||||
+ monitor_printf(mon, "Error: %s\n", info->error);
|
+ monitor_printf(mon, "Error: %s\n", info->error);
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
|
||||||
void hmp_info_iothreads(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
IOThreadInfoList *info_list = qmp_query_iothreads(NULL);
|
|
||||||
diff --git a/qapi/migration.json b/qapi/migration.json
|
diff --git a/qapi/migration.json b/qapi/migration.json
|
||||||
index 1124a2dda8..3d72b3e3f3 100644
|
index 8c65b90328..ed20d066cd 100644
|
||||||
--- a/qapi/migration.json
|
--- a/qapi/migration.json
|
||||||
+++ b/qapi/migration.json
|
+++ b/qapi/migration.json
|
||||||
@@ -247,6 +247,40 @@
|
@@ -297,6 +297,40 @@
|
||||||
'*compression': 'CompressionStats',
|
'*dirty-limit-throttle-time-per-round': 'uint64',
|
||||||
'*socket-address': ['SocketAddress'] } }
|
'*dirty-limit-ring-full-time': 'uint64'} }
|
||||||
|
|
||||||
+##
|
+##
|
||||||
+# @SaveVMInfo:
|
+# @SaveVMInfo:
|
||||||
|
@ -867,10 +781,10 @@ index 1124a2dda8..3d72b3e3f3 100644
|
||||||
# @query-migrate:
|
# @query-migrate:
|
||||||
#
|
#
|
||||||
diff --git a/qapi/misc.json b/qapi/misc.json
|
diff --git a/qapi/misc.json b/qapi/misc.json
|
||||||
index 5c2ca3b556..9bc14e1032 100644
|
index ec30e5c570..3c68633f68 100644
|
||||||
--- a/qapi/misc.json
|
--- a/qapi/misc.json
|
||||||
+++ b/qapi/misc.json
|
+++ b/qapi/misc.json
|
||||||
@@ -431,6 +431,38 @@
|
@@ -454,6 +454,24 @@
|
||||||
##
|
##
|
||||||
{ 'command': 'query-fdsets', 'returns': ['FdsetInfo'] }
|
{ 'command': 'query-fdsets', 'returns': ['FdsetInfo'] }
|
||||||
|
|
||||||
|
@ -879,41 +793,27 @@ index 5c2ca3b556..9bc14e1032 100644
|
||||||
+#
|
+#
|
||||||
+# Prepare for snapshot and halt VM. Save VM state to statefile.
|
+# Prepare for snapshot and halt VM. Save VM state to statefile.
|
||||||
+#
|
+#
|
||||||
|
+# @statefile: target file that state should be written to.
|
||||||
|
+#
|
||||||
+##
|
+##
|
||||||
+{ 'command': 'savevm-start', 'data': { '*statefile': 'str' } }
|
+{ 'command': 'savevm-start', 'data': { '*statefile': 'str' } }
|
||||||
+
|
+
|
||||||
+##
|
+##
|
||||||
+# @snapshot-drive:
|
|
||||||
+#
|
|
||||||
+# Create an internal drive snapshot.
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'command': 'snapshot-drive', 'data': { 'device': 'str', 'name': 'str' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @delete-drive-snapshot:
|
|
||||||
+#
|
|
||||||
+# Delete a drive snapshot.
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'command': 'delete-drive-snapshot', 'data': { 'device': 'str', 'name': 'str' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @savevm-end:
|
+# @savevm-end:
|
||||||
+#
|
+#
|
||||||
+# Resume VM after a snapshot.
|
+# Resume VM after a snapshot.
|
||||||
+#
|
+#
|
||||||
+##
|
+##
|
||||||
+{ 'command': 'savevm-end', 'coroutine': true }
|
+{ 'command': 'savevm-end' }
|
||||||
+
|
+
|
||||||
##
|
##
|
||||||
# @CommandLineParameterType:
|
# @CommandLineParameterType:
|
||||||
#
|
#
|
||||||
diff --git a/qemu-options.hx b/qemu-options.hx
|
diff --git a/qemu-options.hx b/qemu-options.hx
|
||||||
index 83aa59a920..002ba697e9 100644
|
index 8ce85d4559..511ab9415e 100644
|
||||||
--- a/qemu-options.hx
|
--- a/qemu-options.hx
|
||||||
+++ b/qemu-options.hx
|
+++ b/qemu-options.hx
|
||||||
@@ -4131,6 +4131,18 @@ SRST
|
@@ -4610,6 +4610,18 @@ SRST
|
||||||
Start right away with a saved state (``loadvm`` in monitor)
|
Start right away with a saved state (``loadvm`` in monitor)
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
|
@ -932,22 +832,22 @@ index 83aa59a920..002ba697e9 100644
|
||||||
#ifndef _WIN32
|
#ifndef _WIN32
|
||||||
DEF("daemonize", 0, QEMU_OPTION_daemonize, \
|
DEF("daemonize", 0, QEMU_OPTION_daemonize, \
|
||||||
"-daemonize daemonize QEMU after initializing\n", QEMU_ARCH_ALL)
|
"-daemonize daemonize QEMU after initializing\n", QEMU_ARCH_ALL)
|
||||||
diff --git a/softmmu/vl.c b/softmmu/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index 5ca11e7469..220c67cd32 100644
|
index c644222982..2738ab7c91 100644
|
||||||
--- a/softmmu/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/softmmu/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -150,6 +150,7 @@ static const char *incoming;
|
@@ -163,6 +163,7 @@ static const char *accelerators;
|
||||||
static const char *loadvm;
|
static bool have_custom_ram_size;
|
||||||
static const char *accelerators;
|
static const char *ram_memdev_id;
|
||||||
static QDict *machine_opts_dict;
|
static QDict *machine_opts_dict;
|
||||||
+static const char *loadstate;
|
+static const char *loadstate;
|
||||||
static QTAILQ_HEAD(, ObjectOption) object_opts = QTAILQ_HEAD_INITIALIZER(object_opts);
|
static QTAILQ_HEAD(, ObjectOption) object_opts = QTAILQ_HEAD_INITIALIZER(object_opts);
|
||||||
static ram_addr_t maxram_size;
|
static QTAILQ_HEAD(, DeviceOption) device_opts = QTAILQ_HEAD_INITIALIZER(device_opts);
|
||||||
static uint64_t ram_slots;
|
static int display_remote;
|
||||||
@@ -2700,6 +2701,12 @@ void qmp_x_exit_preconfig(Error **errp)
|
@@ -2712,6 +2713,12 @@ void qmp_x_exit_preconfig(Error **errp)
|
||||||
autostart = 0;
|
RunState state = autostart ? RUN_STATE_RUNNING : runstate_get();
|
||||||
exit(1);
|
load_snapshot(loadvm, NULL, false, NULL, &error_fatal);
|
||||||
}
|
load_snapshot_resume(state);
|
||||||
+ } else if (loadstate) {
|
+ } else if (loadstate) {
|
||||||
+ Error *local_err = NULL;
|
+ Error *local_err = NULL;
|
||||||
+ if (load_snapshot_from_blockdev(loadstate, &local_err) < 0) {
|
+ if (load_snapshot_from_blockdev(loadstate, &local_err) < 0) {
|
||||||
|
@ -957,7 +857,7 @@ index 5ca11e7469..220c67cd32 100644
|
||||||
}
|
}
|
||||||
if (replay_mode != REPLAY_MODE_NONE) {
|
if (replay_mode != REPLAY_MODE_NONE) {
|
||||||
replay_vmstate_init();
|
replay_vmstate_init();
|
||||||
@@ -3238,6 +3245,9 @@ void qemu_init(int argc, char **argv, char **envp)
|
@@ -3259,6 +3266,9 @@ void qemu_init(int argc, char **argv)
|
||||||
case QEMU_OPTION_loadvm:
|
case QEMU_OPTION_loadvm:
|
||||||
loadvm = optarg;
|
loadvm = optarg;
|
||||||
break;
|
break;
|
|
@ -0,0 +1,217 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
|
Date: Mon, 4 May 2020 11:05:08 +0200
|
||||||
|
Subject: [PATCH] PVE: add optional buffer size to QEMUFile
|
||||||
|
|
||||||
|
So we can use a 4M buffer for savevm-async which should
|
||||||
|
increase performance storing the state onto ceph.
|
||||||
|
|
||||||
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
|
[increase max IOV count in QEMUFile to actually write more data]
|
||||||
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to removal of QEMUFileOps]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
migration/qemu-file.c | 50 +++++++++++++++++++++++++++-------------
|
||||||
|
migration/qemu-file.h | 2 ++
|
||||||
|
migration/savevm-async.c | 5 ++--
|
||||||
|
3 files changed, 39 insertions(+), 18 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
|
||||||
|
index a10882d47f..19c1de0472 100644
|
||||||
|
--- a/migration/qemu-file.c
|
||||||
|
+++ b/migration/qemu-file.c
|
||||||
|
@@ -35,8 +35,8 @@
|
||||||
|
#include "rdma.h"
|
||||||
|
#include "io/channel-file.h"
|
||||||
|
|
||||||
|
-#define IO_BUF_SIZE 32768
|
||||||
|
-#define MAX_IOV_SIZE MIN_CONST(IOV_MAX, 64)
|
||||||
|
+#define DEFAULT_IO_BUF_SIZE 32768
|
||||||
|
+#define MAX_IOV_SIZE MIN_CONST(IOV_MAX, 256)
|
||||||
|
|
||||||
|
struct QEMUFile {
|
||||||
|
QIOChannel *ioc;
|
||||||
|
@@ -44,7 +44,8 @@ struct QEMUFile {
|
||||||
|
|
||||||
|
int buf_index;
|
||||||
|
int buf_size; /* 0 when writing */
|
||||||
|
- uint8_t buf[IO_BUF_SIZE];
|
||||||
|
+ size_t buf_allocated_size;
|
||||||
|
+ uint8_t *buf;
|
||||||
|
|
||||||
|
DECLARE_BITMAP(may_free, MAX_IOV_SIZE);
|
||||||
|
struct iovec iov[MAX_IOV_SIZE];
|
||||||
|
@@ -101,7 +102,9 @@ int qemu_file_shutdown(QEMUFile *f)
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
-static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
||||||
|
+static QEMUFile *qemu_file_new_impl(QIOChannel *ioc,
|
||||||
|
+ bool is_writable,
|
||||||
|
+ size_t buffer_size)
|
||||||
|
{
|
||||||
|
QEMUFile *f;
|
||||||
|
|
||||||
|
@@ -110,6 +113,8 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
||||||
|
object_ref(ioc);
|
||||||
|
f->ioc = ioc;
|
||||||
|
f->is_writable = is_writable;
|
||||||
|
+ f->buf_allocated_size = buffer_size;
|
||||||
|
+ f->buf = malloc(buffer_size);
|
||||||
|
|
||||||
|
return f;
|
||||||
|
}
|
||||||
|
@@ -120,17 +125,27 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
||||||
|
*/
|
||||||
|
QEMUFile *qemu_file_get_return_path(QEMUFile *f)
|
||||||
|
{
|
||||||
|
- return qemu_file_new_impl(f->ioc, !f->is_writable);
|
||||||
|
+ return qemu_file_new_impl(f->ioc, !f->is_writable, DEFAULT_IO_BUF_SIZE);
|
||||||
|
}
|
||||||
|
|
||||||
|
QEMUFile *qemu_file_new_output(QIOChannel *ioc)
|
||||||
|
{
|
||||||
|
- return qemu_file_new_impl(ioc, true);
|
||||||
|
+ return qemu_file_new_impl(ioc, true, DEFAULT_IO_BUF_SIZE);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+QEMUFile *qemu_file_new_output_sized(QIOChannel *ioc, size_t buffer_size)
|
||||||
|
+{
|
||||||
|
+ return qemu_file_new_impl(ioc, true, buffer_size);
|
||||||
|
}
|
||||||
|
|
||||||
|
QEMUFile *qemu_file_new_input(QIOChannel *ioc)
|
||||||
|
{
|
||||||
|
- return qemu_file_new_impl(ioc, false);
|
||||||
|
+ return qemu_file_new_impl(ioc, false, DEFAULT_IO_BUF_SIZE);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+QEMUFile *qemu_file_new_input_sized(QIOChannel *ioc, size_t buffer_size)
|
||||||
|
+{
|
||||||
|
+ return qemu_file_new_impl(ioc, false, buffer_size);
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
@@ -328,7 +343,7 @@ static ssize_t coroutine_mixed_fn qemu_fill_buffer(QEMUFile *f)
|
||||||
|
do {
|
||||||
|
len = qio_channel_read(f->ioc,
|
||||||
|
(char *)f->buf + pending,
|
||||||
|
- IO_BUF_SIZE - pending,
|
||||||
|
+ f->buf_allocated_size - pending,
|
||||||
|
&local_error);
|
||||||
|
if (len == QIO_CHANNEL_ERR_BLOCK) {
|
||||||
|
if (qemu_in_coroutine()) {
|
||||||
|
@@ -368,6 +383,9 @@ int qemu_fclose(QEMUFile *f)
|
||||||
|
ret = ret2;
|
||||||
|
}
|
||||||
|
g_clear_pointer(&f->ioc, object_unref);
|
||||||
|
+
|
||||||
|
+ free(f->buf);
|
||||||
|
+
|
||||||
|
error_free(f->last_error_obj);
|
||||||
|
g_free(f);
|
||||||
|
trace_qemu_file_fclose();
|
||||||
|
@@ -416,7 +434,7 @@ static void add_buf_to_iovec(QEMUFile *f, size_t len)
|
||||||
|
{
|
||||||
|
if (!add_to_iovec(f, f->buf + f->buf_index, len, false)) {
|
||||||
|
f->buf_index += len;
|
||||||
|
- if (f->buf_index == IO_BUF_SIZE) {
|
||||||
|
+ if (f->buf_index == f->buf_allocated_size) {
|
||||||
|
qemu_fflush(f);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -441,7 +459,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, size_t size)
|
||||||
|
}
|
||||||
|
|
||||||
|
while (size > 0) {
|
||||||
|
- l = IO_BUF_SIZE - f->buf_index;
|
||||||
|
+ l = f->buf_allocated_size - f->buf_index;
|
||||||
|
if (l > size) {
|
||||||
|
l = size;
|
||||||
|
}
|
||||||
|
@@ -587,8 +605,8 @@ size_t coroutine_mixed_fn qemu_peek_buffer(QEMUFile *f, uint8_t **buf, size_t si
|
||||||
|
size_t index;
|
||||||
|
|
||||||
|
assert(!qemu_file_is_writable(f));
|
||||||
|
- assert(offset < IO_BUF_SIZE);
|
||||||
|
- assert(size <= IO_BUF_SIZE - offset);
|
||||||
|
+ assert(offset < f->buf_allocated_size);
|
||||||
|
+ assert(size <= f->buf_allocated_size - offset);
|
||||||
|
|
||||||
|
/* The 1st byte to read from */
|
||||||
|
index = f->buf_index + offset;
|
||||||
|
@@ -638,7 +656,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
||||||
|
size_t res;
|
||||||
|
uint8_t *src;
|
||||||
|
|
||||||
|
- res = qemu_peek_buffer(f, &src, MIN(pending, IO_BUF_SIZE), 0);
|
||||||
|
+ res = qemu_peek_buffer(f, &src, MIN(pending, f->buf_allocated_size), 0);
|
||||||
|
if (res == 0) {
|
||||||
|
return done;
|
||||||
|
}
|
||||||
|
@@ -672,7 +690,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
||||||
|
*/
|
||||||
|
size_t coroutine_mixed_fn qemu_get_buffer_in_place(QEMUFile *f, uint8_t **buf, size_t size)
|
||||||
|
{
|
||||||
|
- if (size < IO_BUF_SIZE) {
|
||||||
|
+ if (size < f->buf_allocated_size) {
|
||||||
|
size_t res;
|
||||||
|
uint8_t *src = NULL;
|
||||||
|
|
||||||
|
@@ -697,7 +715,7 @@ int coroutine_mixed_fn qemu_peek_byte(QEMUFile *f, int offset)
|
||||||
|
int index = f->buf_index + offset;
|
||||||
|
|
||||||
|
assert(!qemu_file_is_writable(f));
|
||||||
|
- assert(offset < IO_BUF_SIZE);
|
||||||
|
+ assert(offset < f->buf_allocated_size);
|
||||||
|
|
||||||
|
if (index >= f->buf_size) {
|
||||||
|
qemu_fill_buffer(f);
|
||||||
|
@@ -811,7 +829,7 @@ static int qemu_compress_data(z_stream *stream, uint8_t *dest, size_t dest_len,
|
||||||
|
ssize_t qemu_put_compression_data(QEMUFile *f, z_stream *stream,
|
||||||
|
const uint8_t *p, size_t size)
|
||||||
|
{
|
||||||
|
- ssize_t blen = IO_BUF_SIZE - f->buf_index - sizeof(int32_t);
|
||||||
|
+ ssize_t blen = f->buf_allocated_size - f->buf_index - sizeof(int32_t);
|
||||||
|
|
||||||
|
if (blen < compressBound(size)) {
|
||||||
|
return -1;
|
||||||
|
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
|
||||||
|
index 32fd4a34fd..36a0cd8cc8 100644
|
||||||
|
--- a/migration/qemu-file.h
|
||||||
|
+++ b/migration/qemu-file.h
|
||||||
|
@@ -30,7 +30,9 @@
|
||||||
|
#include "io/channel.h"
|
||||||
|
|
||||||
|
QEMUFile *qemu_file_new_input(QIOChannel *ioc);
|
||||||
|
+QEMUFile *qemu_file_new_input_sized(QIOChannel *ioc, size_t buffer_size);
|
||||||
|
QEMUFile *qemu_file_new_output(QIOChannel *ioc);
|
||||||
|
+QEMUFile *qemu_file_new_output_sized(QIOChannel *ioc, size_t buffer_size);
|
||||||
|
int qemu_fclose(QEMUFile *f);
|
||||||
|
|
||||||
|
/*
|
||||||
|
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
||||||
|
index 72cf6588c2..fb4e8ea689 100644
|
||||||
|
--- a/migration/savevm-async.c
|
||||||
|
+++ b/migration/savevm-async.c
|
||||||
|
@@ -379,7 +379,7 @@ void qmp_savevm_start(const char *statefile, Error **errp)
|
||||||
|
|
||||||
|
QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(snap_state.target,
|
||||||
|
&snap_state.bs_pos));
|
||||||
|
- snap_state.file = qemu_file_new_output(ioc);
|
||||||
|
+ snap_state.file = qemu_file_new_output_sized(ioc, 4 * 1024 * 1024);
|
||||||
|
|
||||||
|
if (!snap_state.file) {
|
||||||
|
error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
||||||
|
@@ -503,7 +503,8 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
||||||
|
blk_op_block_all(be, blocker);
|
||||||
|
|
||||||
|
/* restore the VM state */
|
||||||
|
- f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
||||||
|
+ f = qemu_file_new_input_sized(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)),
|
||||||
|
+ 4 * 1024 * 1024);
|
||||||
|
if (!f) {
|
||||||
|
error_setg(errp, "Could not open VM state file");
|
||||||
|
goto the_end;
|
|
@ -4,30 +4,34 @@ Date: Mon, 6 Apr 2020 12:16:47 +0200
|
||||||
Subject: [PATCH] PVE: block: add the zeroinit block driver filter
|
Subject: [PATCH] PVE: block: add the zeroinit block driver filter
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to changed function signatures
|
||||||
|
adhere to block graph lock requirements
|
||||||
|
use dedicated function to open file child]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/meson.build | 1 +
|
block/meson.build | 1 +
|
||||||
block/zeroinit.c | 196 ++++++++++++++++++++++++++++++++++++++++++++++
|
block/zeroinit.c | 207 ++++++++++++++++++++++++++++++++++++++++++++++
|
||||||
2 files changed, 197 insertions(+)
|
2 files changed, 208 insertions(+)
|
||||||
create mode 100644 block/zeroinit.c
|
create mode 100644 block/zeroinit.c
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 0450914c7a..7a0bc3df09 100644
|
index e1f03fd773..b530e117b5 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -41,6 +41,7 @@ block_ss.add(files(
|
@@ -39,6 +39,7 @@ block_ss.add(files(
|
||||||
'vmdk.c',
|
'throttle.c',
|
||||||
'vpc.c',
|
'throttle-groups.c',
|
||||||
'write-threshold.c',
|
'write-threshold.c',
|
||||||
+ 'zeroinit.c',
|
+ 'zeroinit.c',
|
||||||
), zstd, zlib, gnutls)
|
), zstd, zlib, gnutls)
|
||||||
|
|
||||||
softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
system_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
||||||
diff --git a/block/zeroinit.c b/block/zeroinit.c
|
diff --git a/block/zeroinit.c b/block/zeroinit.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..5529627f7e
|
index 0000000000..7998c9332d
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/zeroinit.c
|
+++ b/block/zeroinit.c
|
||||||
@@ -0,0 +1,196 @@
|
@@ -0,0 +1,207 @@
|
||||||
+/*
|
+/*
|
||||||
+ * Filter to fake a zero-initialized block device.
|
+ * Filter to fake a zero-initialized block device.
|
||||||
+ *
|
+ *
|
||||||
|
@ -41,6 +45,8 @@ index 0000000000..5529627f7e
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include "qapi/error.h"
|
+#include "qapi/error.h"
|
||||||
+#include "block/block_int.h"
|
+#include "block/block_int.h"
|
||||||
|
+#include "block/block-io.h"
|
||||||
|
+#include "block/graph-lock.h"
|
||||||
+#include "qapi/qmp/qdict.h"
|
+#include "qapi/qmp/qdict.h"
|
||||||
+#include "qapi/qmp/qstring.h"
|
+#include "qapi/qmp/qstring.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
|
@ -106,10 +112,9 @@ index 0000000000..5529627f7e
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ /* Open the raw file */
|
+ /* Open the raw file */
|
||||||
+ bs->file = bdrv_open_child(qemu_opt_get(opts, "x-next"), options, "next",
|
+ ret = bdrv_open_file_child(qemu_opt_get(opts, "x-next"), options, "next",
|
||||||
+ bs, &child_of_bds, BDRV_CHILD_FILTERED, false, &local_err);
|
+ bs, &local_err);
|
||||||
+ if (local_err) {
|
+ if (ret < 0) {
|
||||||
+ ret = -EINVAL;
|
|
||||||
+ error_propagate(errp, local_err);
|
+ error_propagate(errp, local_err);
|
||||||
+ goto fail;
|
+ goto fail;
|
||||||
+ }
|
+ }
|
||||||
|
@ -120,7 +125,9 @@ index 0000000000..5529627f7e
|
||||||
+ ret = 0;
|
+ ret = 0;
|
||||||
+fail:
|
+fail:
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
|
+ bdrv_graph_wrlock();
|
||||||
+ bdrv_unref_child(bs, bs->file);
|
+ bdrv_unref_child(bs, bs->file);
|
||||||
|
+ bdrv_graph_wrunlock();
|
||||||
+ }
|
+ }
|
||||||
+ qemu_opts_del(opts);
|
+ qemu_opts_del(opts);
|
||||||
+ return ret;
|
+ return ret;
|
||||||
|
@ -132,28 +139,32 @@ index 0000000000..5529627f7e
|
||||||
+ (void)s;
|
+ (void)s;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int64_t zeroinit_getlength(BlockDriverState *bs)
|
+static coroutine_fn int64_t GRAPH_RDLOCK
|
||||||
|
+zeroinit_co_getlength(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_getlength(bs->file->bs);
|
+ return bdrv_co_getlength(bs->file->bs);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn zeroinit_co_preadv(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags)
|
+zeroinit_co_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
|
+ return bdrv_co_preadv(bs->file, offset, bytes, qiov, flags);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn zeroinit_co_pwrite_zeroes(BlockDriverState *bs, int64_t offset,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ int count, BdrvRequestFlags flags)
|
+zeroinit_co_pwrite_zeroes(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ BDRVZeroinitState *s = bs->opaque;
|
+ BDRVZeroinitState *s = bs->opaque;
|
||||||
+ if (offset >= s->extents)
|
+ if (offset >= s->extents)
|
||||||
+ return 0;
|
+ return 0;
|
||||||
+ return bdrv_pwrite_zeroes(bs->file, offset, count, flags);
|
+ return bdrv_pwrite_zeroes(bs->file, offset, bytes, flags);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn zeroinit_co_pwritev(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags)
|
+zeroinit_co_pwritev(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ BDRVZeroinitState *s = bs->opaque;
|
+ BDRVZeroinitState *s = bs->opaque;
|
||||||
+ int64_t extents = offset + bytes;
|
+ int64_t extents = offset + bytes;
|
||||||
|
@ -162,33 +173,37 @@ index 0000000000..5529627f7e
|
||||||
+ return bdrv_co_pwritev(bs->file, offset, bytes, qiov, flags);
|
+ return bdrv_co_pwritev(bs->file, offset, bytes, qiov, flags);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static coroutine_fn int zeroinit_co_flush(BlockDriverState *bs)
|
+static coroutine_fn int GRAPH_RDLOCK
|
||||||
|
+zeroinit_co_flush(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_flush(bs->file->bs);
|
+ return bdrv_co_flush(bs->file->bs);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int zeroinit_has_zero_init(BlockDriverState *bs)
|
+static int GRAPH_RDLOCK
|
||||||
|
+zeroinit_has_zero_init(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ BDRVZeroinitState *s = bs->opaque;
|
+ BDRVZeroinitState *s = bs->opaque;
|
||||||
+ return s->has_zero_init;
|
+ return s->has_zero_init;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn zeroinit_co_pdiscard(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ int64_t offset, int count)
|
+zeroinit_co_pdiscard(BlockDriverState *bs, int64_t offset, int64_t bytes)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_pdiscard(bs->file, offset, count);
|
+ return bdrv_co_pdiscard(bs->file, offset, bytes);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int zeroinit_co_truncate(BlockDriverState *bs, int64_t offset,
|
+static int GRAPH_RDLOCK
|
||||||
+ _Bool exact, PreallocMode prealloc,
|
+zeroinit_co_truncate(BlockDriverState *bs, int64_t offset, _Bool exact,
|
||||||
+ BdrvRequestFlags req_flags, Error **errp)
|
+ PreallocMode prealloc, BdrvRequestFlags req_flags,
|
||||||
|
+ Error **errp)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_truncate(bs->file, offset, exact, prealloc, req_flags, errp);
|
+ return bdrv_co_truncate(bs->file, offset, exact, prealloc, req_flags, errp);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int zeroinit_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
|
+static coroutine_fn int GRAPH_RDLOCK
|
||||||
|
+zeroinit_co_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_get_info(bs->file->bs, bdi);
|
+ return bdrv_co_get_info(bs->file->bs, bdi);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static BlockDriver bdrv_zeroinit = {
|
+static BlockDriver bdrv_zeroinit = {
|
||||||
|
@ -199,7 +214,7 @@ index 0000000000..5529627f7e
|
||||||
+ .bdrv_parse_filename = zeroinit_parse_filename,
|
+ .bdrv_parse_filename = zeroinit_parse_filename,
|
||||||
+ .bdrv_file_open = zeroinit_open,
|
+ .bdrv_file_open = zeroinit_open,
|
||||||
+ .bdrv_close = zeroinit_close,
|
+ .bdrv_close = zeroinit_close,
|
||||||
+ .bdrv_getlength = zeroinit_getlength,
|
+ .bdrv_co_getlength = zeroinit_co_getlength,
|
||||||
+ .bdrv_child_perm = bdrv_default_perms,
|
+ .bdrv_child_perm = bdrv_default_perms,
|
||||||
+ .bdrv_co_flush_to_disk = zeroinit_co_flush,
|
+ .bdrv_co_flush_to_disk = zeroinit_co_flush,
|
||||||
+
|
+
|
||||||
|
@ -215,7 +230,7 @@ index 0000000000..5529627f7e
|
||||||
+ .bdrv_co_pdiscard = zeroinit_co_pdiscard,
|
+ .bdrv_co_pdiscard = zeroinit_co_pdiscard,
|
||||||
+
|
+
|
||||||
+ .bdrv_co_truncate = zeroinit_co_truncate,
|
+ .bdrv_co_truncate = zeroinit_co_truncate,
|
||||||
+ .bdrv_get_info = zeroinit_get_info,
|
+ .bdrv_co_get_info = zeroinit_co_get_info,
|
||||||
+};
|
+};
|
||||||
+
|
+
|
||||||
+static void bdrv_zeroinit_init(void)
|
+static void bdrv_zeroinit_init(void)
|
|
@ -10,16 +10,16 @@ Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
---
|
---
|
||||||
qemu-options.hx | 3 +++
|
qemu-options.hx | 3 +++
|
||||||
softmmu/vl.c | 8 ++++++++
|
system/vl.c | 8 ++++++++
|
||||||
2 files changed, 11 insertions(+)
|
2 files changed, 11 insertions(+)
|
||||||
|
|
||||||
diff --git a/qemu-options.hx b/qemu-options.hx
|
diff --git a/qemu-options.hx b/qemu-options.hx
|
||||||
index 002ba697e9..a05959b9f1 100644
|
index 511ab9415e..92e301d545 100644
|
||||||
--- a/qemu-options.hx
|
--- a/qemu-options.hx
|
||||||
+++ b/qemu-options.hx
|
+++ b/qemu-options.hx
|
||||||
@@ -1005,6 +1005,9 @@ DEFHEADING()
|
@@ -1237,6 +1237,9 @@ legacy PC, they are not recommended for modern configurations.
|
||||||
|
|
||||||
DEFHEADING(Block device options:)
|
ERST
|
||||||
|
|
||||||
+DEF("id", HAS_ARG, QEMU_OPTION_id,
|
+DEF("id", HAS_ARG, QEMU_OPTION_id,
|
||||||
+ "-id n set the VMID", QEMU_ARCH_ALL)
|
+ "-id n set the VMID", QEMU_ARCH_ALL)
|
||||||
|
@ -27,11 +27,11 @@ index 002ba697e9..a05959b9f1 100644
|
||||||
DEF("fda", HAS_ARG, QEMU_OPTION_fda,
|
DEF("fda", HAS_ARG, QEMU_OPTION_fda,
|
||||||
"-fda/-fdb file use 'file' as floppy disk 0/1 image\n", QEMU_ARCH_ALL)
|
"-fda/-fdb file use 'file' as floppy disk 0/1 image\n", QEMU_ARCH_ALL)
|
||||||
DEF("fdb", HAS_ARG, QEMU_OPTION_fdb, "", QEMU_ARCH_ALL)
|
DEF("fdb", HAS_ARG, QEMU_OPTION_fdb, "", QEMU_ARCH_ALL)
|
||||||
diff --git a/softmmu/vl.c b/softmmu/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index 220c67cd32..d87cf6e103 100644
|
index 2738ab7c91..20ebf2c920 100644
|
||||||
--- a/softmmu/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/softmmu/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -2736,6 +2736,7 @@ void qemu_init(int argc, char **argv, char **envp)
|
@@ -2748,6 +2748,7 @@ void qemu_init(int argc, char **argv)
|
||||||
MachineClass *machine_class;
|
MachineClass *machine_class;
|
||||||
bool userconfig = true;
|
bool userconfig = true;
|
||||||
FILE *vmstate_dump_file = NULL;
|
FILE *vmstate_dump_file = NULL;
|
||||||
|
@ -39,9 +39,9 @@ index 220c67cd32..d87cf6e103 100644
|
||||||
|
|
||||||
qemu_add_opts(&qemu_drive_opts);
|
qemu_add_opts(&qemu_drive_opts);
|
||||||
qemu_add_drive_opts(&qemu_legacy_drive_opts);
|
qemu_add_drive_opts(&qemu_legacy_drive_opts);
|
||||||
@@ -3360,6 +3361,13 @@ void qemu_init(int argc, char **argv, char **envp)
|
@@ -3371,6 +3372,13 @@ void qemu_init(int argc, char **argv)
|
||||||
case QEMU_OPTION_smp:
|
machine_parse_property_opt(qemu_find_opts("smp-opts"),
|
||||||
machine_parse_property_opt(qemu_find_opts("smp-opts"), "smp", optarg, &error_fatal);
|
"smp", optarg);
|
||||||
break;
|
break;
|
||||||
+ case QEMU_OPTION_id:
|
+ case QEMU_OPTION_id:
|
||||||
+ vm_id = strtol(optarg, (char **)&optarg, 10);
|
+ vm_id = strtol(optarg, (char **)&optarg, 10);
|
||||||
|
@ -50,6 +50,6 @@ index 220c67cd32..d87cf6e103 100644
|
||||||
+ exit(1);
|
+ exit(1);
|
||||||
+ }
|
+ }
|
||||||
+ break;
|
+ break;
|
||||||
|
#ifdef CONFIG_VNC
|
||||||
case QEMU_OPTION_vnc:
|
case QEMU_OPTION_vnc:
|
||||||
vnc_parse(optarg);
|
vnc_parse(optarg);
|
||||||
break;
|
|
|
@ -11,10 +11,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 9 insertions(+)
|
1 file changed, 9 insertions(+)
|
||||||
|
|
||||||
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
|
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
|
||||||
index 2a20982066..7968ad5a93 100644
|
index d8fc1e2815..789694b8b3 100644
|
||||||
--- a/hw/intc/apic_common.c
|
--- a/hw/intc/apic_common.c
|
||||||
+++ b/hw/intc/apic_common.c
|
+++ b/hw/intc/apic_common.c
|
||||||
@@ -278,6 +278,15 @@ static void apic_reset_common(DeviceState *dev)
|
@@ -263,6 +263,15 @@ static void apic_reset_common(DeviceState *dev)
|
||||||
info->vapic_base_update(s);
|
info->vapic_base_update(s);
|
||||||
|
|
||||||
apic_init_reset(dev);
|
apic_init_reset(dev);
|
|
@ -9,14 +9,14 @@ Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
---
|
---
|
||||||
block/file-posix.c | 59 ++++++++++++++++++++++++++++++--------------
|
block/file-posix.c | 59 ++++++++++++++++++++++++++++++--------------
|
||||||
qapi/block-core.json | 3 ++-
|
qapi/block-core.json | 7 +++++-
|
||||||
2 files changed, 42 insertions(+), 20 deletions(-)
|
2 files changed, 46 insertions(+), 20 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/file-posix.c b/block/file-posix.c
|
diff --git a/block/file-posix.c b/block/file-posix.c
|
||||||
index 3ac5177cbb..907aa3f22e 100644
|
index 43bc0bd520..60e98c87f1 100644
|
||||||
--- a/block/file-posix.c
|
--- a/block/file-posix.c
|
||||||
+++ b/block/file-posix.c
|
+++ b/block/file-posix.c
|
||||||
@@ -2443,6 +2443,7 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2876,6 +2876,7 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
int fd;
|
int fd;
|
||||||
uint64_t perm, shared;
|
uint64_t perm, shared;
|
||||||
int result = 0;
|
int result = 0;
|
||||||
|
@ -24,7 +24,7 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
|
|
||||||
/* Validate options and set default values */
|
/* Validate options and set default values */
|
||||||
assert(options->driver == BLOCKDEV_DRIVER_FILE);
|
assert(options->driver == BLOCKDEV_DRIVER_FILE);
|
||||||
@@ -2483,19 +2484,22 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2916,19 +2917,22 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
perm = BLK_PERM_WRITE | BLK_PERM_RESIZE;
|
perm = BLK_PERM_WRITE | BLK_PERM_RESIZE;
|
||||||
shared = BLK_PERM_ALL & ~BLK_PERM_RESIZE;
|
shared = BLK_PERM_ALL & ~BLK_PERM_RESIZE;
|
||||||
|
|
||||||
|
@ -59,7 +59,7 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Clear the file by truncating it to 0 */
|
/* Clear the file by truncating it to 0 */
|
||||||
@@ -2549,13 +2553,15 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2982,13 +2986,15 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
}
|
}
|
||||||
|
|
||||||
out_unlock:
|
out_unlock:
|
||||||
|
@ -82,7 +82,7 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
}
|
}
|
||||||
|
|
||||||
out_close:
|
out_close:
|
||||||
@@ -2580,6 +2586,7 @@ static int coroutine_fn raw_co_create_opts(BlockDriver *drv,
|
@@ -3012,6 +3018,7 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
PreallocMode prealloc;
|
PreallocMode prealloc;
|
||||||
char *buf = NULL;
|
char *buf = NULL;
|
||||||
Error *local_err = NULL;
|
Error *local_err = NULL;
|
||||||
|
@ -90,7 +90,7 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
|
|
||||||
/* Skip file: protocol prefix */
|
/* Skip file: protocol prefix */
|
||||||
strstart(filename, "file:", &filename);
|
strstart(filename, "file:", &filename);
|
||||||
@@ -2602,6 +2609,18 @@ static int coroutine_fn raw_co_create_opts(BlockDriver *drv,
|
@@ -3034,6 +3041,18 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -109,7 +109,7 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
options = (BlockdevCreateOptions) {
|
options = (BlockdevCreateOptions) {
|
||||||
.driver = BLOCKDEV_DRIVER_FILE,
|
.driver = BLOCKDEV_DRIVER_FILE,
|
||||||
.u.file = {
|
.u.file = {
|
||||||
@@ -2613,6 +2632,8 @@ static int coroutine_fn raw_co_create_opts(BlockDriver *drv,
|
@@ -3045,6 +3064,8 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
.nocow = nocow,
|
.nocow = nocow,
|
||||||
.has_extent_size_hint = has_extent_size_hint,
|
.has_extent_size_hint = has_extent_size_hint,
|
||||||
.extent_size_hint = extent_size_hint,
|
.extent_size_hint = extent_size_hint,
|
||||||
|
@ -119,10 +119,21 @@ index 3ac5177cbb..907aa3f22e 100644
|
||||||
};
|
};
|
||||||
return raw_co_create(&options, errp);
|
return raw_co_create(&options, errp);
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 6356a63695..fdfa579d00 100644
|
index 905da8be72..3db587a6e4 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -4341,7 +4341,8 @@
|
@@ -4956,6 +4956,10 @@
|
||||||
|
# @extent-size-hint: Extent size hint to add to the image file; 0 for
|
||||||
|
# not adding an extent size hint (default: 1 MB, since 5.1)
|
||||||
|
#
|
||||||
|
+# @locking: whether to enable file locking. If set to 'auto', only
|
||||||
|
+# enable when Open File Descriptor (OFD) locking API is available
|
||||||
|
+# (default: auto).
|
||||||
|
+#
|
||||||
|
# Since: 2.12
|
||||||
|
##
|
||||||
|
{ 'struct': 'BlockdevCreateOptionsFile',
|
||||||
|
@@ -4963,7 +4967,8 @@
|
||||||
'size': 'size',
|
'size': 'size',
|
||||||
'*preallocation': 'PreallocMode',
|
'*preallocation': 'PreallocMode',
|
||||||
'*nocow': 'bool',
|
'*nocow': 'bool',
|
|
@ -18,10 +18,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 1 insertion(+), 2 deletions(-)
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
||||||
index 6b8cfcf6d8..3ec67e32d3 100644
|
index 589c9524f8..2505dd658a 100644
|
||||||
--- a/monitor/qmp.c
|
--- a/monitor/qmp.c
|
||||||
+++ b/monitor/qmp.c
|
+++ b/monitor/qmp.c
|
||||||
@@ -519,8 +519,7 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
@@ -536,8 +536,7 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
||||||
qemu_chr_fe_set_echo(&mon->common.chr, true);
|
qemu_chr_fe_set_echo(&mon->common.chr, true);
|
||||||
|
|
||||||
/* Note: we run QMP monitor in I/O thread when @chr supports that */
|
/* Note: we run QMP monitor in I/O thread when @chr supports that */
|
|
@ -26,10 +26,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine.c b/hw/core/machine.c
|
diff --git a/hw/core/machine.c b/hw/core/machine.c
|
||||||
index 2cf2f321f9..e0f857820d 100644
|
index 4273de16a0..83f1fc0293 100644
|
||||||
--- a/hw/core/machine.c
|
--- a/hw/core/machine.c
|
||||||
+++ b/hw/core/machine.c
|
+++ b/hw/core/machine.c
|
||||||
@@ -107,7 +107,8 @@ GlobalProperty hw_compat_4_0[] = {
|
@@ -162,7 +162,8 @@ GlobalProperty hw_compat_4_0[] = {
|
||||||
{ "virtio-vga", "edid", "false" },
|
{ "virtio-vga", "edid", "false" },
|
||||||
{ "virtio-gpu-device", "edid", "false" },
|
{ "virtio-gpu-device", "edid", "false" },
|
||||||
{ "virtio-device", "use-started", "false" },
|
{ "virtio-device", "use-started", "false" },
|
|
@ -11,78 +11,79 @@ and only if 'is-current').
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to QAPI changes]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
hw/core/machine-qmp-cmds.c | 6 ++++++
|
hw/core/machine-qmp-cmds.c | 5 +++++
|
||||||
include/hw/boards.h | 2 ++
|
include/hw/boards.h | 2 ++
|
||||||
qapi/machine.json | 4 +++-
|
qapi/machine.json | 4 +++-
|
||||||
softmmu/vl.c | 25 +++++++++++++++++++++++++
|
system/vl.c | 25 +++++++++++++++++++++++++
|
||||||
4 files changed, 36 insertions(+), 1 deletion(-)
|
4 files changed, 35 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
||||||
index 8f8d5d5276..370e66d9cc 100644
|
index 314351cdff..628a3537c5 100644
|
||||||
--- a/hw/core/machine-qmp-cmds.c
|
--- a/hw/core/machine-qmp-cmds.c
|
||||||
+++ b/hw/core/machine-qmp-cmds.c
|
+++ b/hw/core/machine-qmp-cmds.c
|
||||||
@@ -102,6 +102,12 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
@@ -94,6 +94,11 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
||||||
if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
||||||
info->has_is_current = true;
|
info->has_is_current = true;
|
||||||
info->is_current = true;
|
info->is_current = true;
|
||||||
+
|
+
|
||||||
+ // PVE version string only exists for current machine
|
+ // PVE version string only exists for current machine
|
||||||
+ if (mc->pve_version) {
|
+ if (mc->pve_version) {
|
||||||
+ info->has_pve_version = true;
|
|
||||||
+ info->pve_version = g_strdup(mc->pve_version);
|
+ info->pve_version = g_strdup(mc->pve_version);
|
||||||
+ }
|
+ }
|
||||||
}
|
}
|
||||||
|
|
||||||
if (mc->default_cpu_type) {
|
if (mc->default_cpu_type) {
|
||||||
diff --git a/include/hw/boards.h b/include/hw/boards.h
|
diff --git a/include/hw/boards.h b/include/hw/boards.h
|
||||||
index accd6eff35..1b16728389 100644
|
index 8b8f6d5c00..dd6d0a1447 100644
|
||||||
--- a/include/hw/boards.h
|
--- a/include/hw/boards.h
|
||||||
+++ b/include/hw/boards.h
|
+++ b/include/hw/boards.h
|
||||||
@@ -205,6 +205,8 @@ struct MachineClass {
|
@@ -246,6 +246,8 @@ struct MachineClass {
|
||||||
const char *desc;
|
const char *desc;
|
||||||
const char *deprecation_reason;
|
const char *deprecation_reason;
|
||||||
|
|
||||||
+ const char *pve_version;
|
+ const char *pve_version;
|
||||||
+
|
+
|
||||||
void (*init)(MachineState *state);
|
void (*init)(MachineState *state);
|
||||||
void (*reset)(MachineState *state);
|
void (*reset)(MachineState *state, ShutdownCause reason);
|
||||||
void (*wakeup)(MachineState *state);
|
void (*wakeup)(MachineState *state);
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index cf120ac343..a6f483af4f 100644
|
index a024d5b05d..1d69bffaa0 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -160,6 +160,8 @@
|
@@ -168,6 +168,8 @@
|
||||||
#
|
#
|
||||||
# @default-ram-id: the default ID of initial RAM memory backend (since 5.2)
|
# @acpi: machine type supports ACPI (since 8.0)
|
||||||
#
|
#
|
||||||
+# @pve-version: custom PVE version suffix specified as 'machine+pveN'
|
+# @pve-version: custom PVE version suffix specified as 'machine+pveN'
|
||||||
+#
|
+#
|
||||||
# Since: 1.2
|
# Since: 1.2
|
||||||
##
|
##
|
||||||
{ 'struct': 'MachineInfo',
|
{ 'struct': 'MachineInfo',
|
||||||
@@ -167,7 +169,7 @@
|
@@ -175,7 +177,7 @@
|
||||||
'*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
'*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
||||||
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
||||||
'deprecated': 'bool', '*default-cpu-type': 'str',
|
'deprecated': 'bool', '*default-cpu-type': 'str',
|
||||||
- '*default-ram-id': 'str' } }
|
- '*default-ram-id': 'str', 'acpi': 'bool' } }
|
||||||
+ '*default-ram-id': 'str', '*pve-version': 'str' } }
|
+ '*default-ram-id': 'str', 'acpi': 'bool', '*pve-version': 'str' } }
|
||||||
|
|
||||||
##
|
##
|
||||||
# @query-machines:
|
# @query-machines:
|
||||||
diff --git a/softmmu/vl.c b/softmmu/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index d87cf6e103..e9d40065bc 100644
|
index 20ebf2c920..4d39e32097 100644
|
||||||
--- a/softmmu/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/softmmu/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -1621,6 +1621,7 @@ static const QEMUOption *lookup_opt(int argc, char **argv,
|
@@ -1659,6 +1659,7 @@ static const QEMUOption *lookup_opt(int argc, char **argv,
|
||||||
static MachineClass *select_machine(QDict *qdict, Error **errp)
|
static MachineClass *select_machine(QDict *qdict, Error **errp)
|
||||||
{
|
{
|
||||||
const char *optarg = qdict_get_try_str(qdict, "type");
|
const char *machine_type = qdict_get_try_str(qdict, "type");
|
||||||
+ const char *pvever = qdict_get_try_str(qdict, "pvever");
|
+ const char *pvever = qdict_get_try_str(qdict, "pvever");
|
||||||
GSList *machines = object_class_get_list(TYPE_MACHINE, false);
|
GSList *machines = object_class_get_list(TYPE_MACHINE, false);
|
||||||
MachineClass *machine_class;
|
MachineClass *machine_class;
|
||||||
Error *local_err = NULL;
|
Error *local_err = NULL;
|
||||||
@@ -1638,6 +1639,11 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
|
@@ -1676,6 +1677,11 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -94,7 +95,7 @@ index d87cf6e103..e9d40065bc 100644
|
||||||
g_slist_free(machines);
|
g_slist_free(machines);
|
||||||
if (local_err) {
|
if (local_err) {
|
||||||
error_append_hint(&local_err, "Use -machine help to list supported machines\n");
|
error_append_hint(&local_err, "Use -machine help to list supported machines\n");
|
||||||
@@ -3312,12 +3318,31 @@ void qemu_init(int argc, char **argv, char **envp)
|
@@ -3313,12 +3319,31 @@ void qemu_init(int argc, char **argv)
|
||||||
case QEMU_OPTION_machine:
|
case QEMU_OPTION_machine:
|
||||||
{
|
{
|
||||||
bool help;
|
bool help;
|
59
debian/patches/pve/0026-block-backup-move-bcs-bitmap-initialization-to-job-c.patch
vendored
Normal file
59
debian/patches/pve/0026-block-backup-move-bcs-bitmap-initialization-to-job-c.patch
vendored
Normal file
|
@ -0,0 +1,59 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Wed, 2 Mar 2022 08:35:05 +0100
|
||||||
|
Subject: [PATCH] block/backup: move bcs bitmap initialization to job creation
|
||||||
|
|
||||||
|
For backing up the state of multiple disks from the same time, a job
|
||||||
|
for each disk has to be created. It's convenient if the jobs don't
|
||||||
|
have to be started at the same time and if operation of the VM can be
|
||||||
|
resumed after job creation. This would lead to a window between job
|
||||||
|
creation and running the job, where writes can happen. But no writes
|
||||||
|
should happen between setting up the copy-before-write filter and
|
||||||
|
setting up the block copy state bitmap, because then new writes would
|
||||||
|
just pass through.
|
||||||
|
|
||||||
|
Commit 06e0a9c16405c0a4c1eca33cf286cc04c42066a2 moved initalization of
|
||||||
|
the bitmap to setting up the copy-before-write filter when sync_mode
|
||||||
|
is not MIRROR_SYNC_MODE_BITMAP. Ensure that the bitmap is initialized
|
||||||
|
upon job creation for the remaining case too, by moving the
|
||||||
|
backup_init_bcs_bitmap call to backup_job_create.
|
||||||
|
|
||||||
|
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/backup.c | 8 ++++----
|
||||||
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
|
index 3dd2e229d2..eba5b11493 100644
|
||||||
|
--- a/block/backup.c
|
||||||
|
+++ b/block/backup.c
|
||||||
|
@@ -237,8 +237,8 @@ static void backup_init_bcs_bitmap(BackupBlockJob *job)
|
||||||
|
true);
|
||||||
|
} else if (job->sync_mode == MIRROR_SYNC_MODE_TOP) {
|
||||||
|
/*
|
||||||
|
- * We can't hog the coroutine to initialize this thoroughly.
|
||||||
|
- * Set a flag and resume work when we are able to yield safely.
|
||||||
|
+ * Initialization is costly here. Simply set a flag and let the
|
||||||
|
+ * backup_run coroutine resume work once it can yield safely.
|
||||||
|
*/
|
||||||
|
block_copy_set_skip_unallocated(job->bcs, true);
|
||||||
|
}
|
||||||
|
@@ -252,8 +252,6 @@ static int coroutine_fn backup_run(Job *job, Error **errp)
|
||||||
|
BackupBlockJob *s = container_of(job, BackupBlockJob, common.job);
|
||||||
|
int ret;
|
||||||
|
|
||||||
|
- backup_init_bcs_bitmap(s);
|
||||||
|
-
|
||||||
|
if (s->sync_mode == MIRROR_SYNC_MODE_TOP) {
|
||||||
|
int64_t offset = 0;
|
||||||
|
int64_t count;
|
||||||
|
@@ -502,6 +500,8 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
&error_abort);
|
||||||
|
bdrv_graph_wrunlock();
|
||||||
|
|
||||||
|
+ backup_init_bcs_bitmap(job);
|
||||||
|
+
|
||||||
|
return &job->common;
|
||||||
|
|
||||||
|
error:
|
|
@ -3,64 +3,70 @@ From: Dietmar Maurer <dietmar@proxmox.com>
|
||||||
Date: Mon, 6 Apr 2020 12:16:57 +0200
|
Date: Mon, 6 Apr 2020 12:16:57 +0200
|
||||||
Subject: [PATCH] PVE-Backup: add vma backup format code
|
Subject: [PATCH] PVE-Backup: add vma backup format code
|
||||||
|
|
||||||
|
Notes about partial restoring: skipping a certain drive is done via a
|
||||||
|
map line of the form skip=drive-scsi0. Since in PVE, most archives are
|
||||||
|
compressed and piped to vma for restore, it's not easily possible to
|
||||||
|
skip reads.
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
[FE: create: register all streams before entering coroutines]
|
[FE: improvements during create
|
||||||
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
|
allow partial restore]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/meson.build | 2 +
|
block/meson.build | 2 +
|
||||||
meson.build | 5 +
|
meson.build | 5 +
|
||||||
vma-reader.c | 857 ++++++++++++++++++++++++++++++++++++++++++++++
|
vma-reader.c | 870 ++++++++++++++++++++++++++++++++++++++++++++
|
||||||
vma-writer.c | 790 ++++++++++++++++++++++++++++++++++++++++++
|
vma-writer.c | 817 +++++++++++++++++++++++++++++++++++++++++
|
||||||
vma.c | 851 +++++++++++++++++++++++++++++++++++++++++++++
|
vma.c | 901 ++++++++++++++++++++++++++++++++++++++++++++++
|
||||||
vma.h | 150 ++++++++
|
vma.h | 150 ++++++++
|
||||||
6 files changed, 2655 insertions(+)
|
6 files changed, 2745 insertions(+)
|
||||||
create mode 100644 vma-reader.c
|
create mode 100644 vma-reader.c
|
||||||
create mode 100644 vma-writer.c
|
create mode 100644 vma-writer.c
|
||||||
create mode 100644 vma.c
|
create mode 100644 vma.c
|
||||||
create mode 100644 vma.h
|
create mode 100644 vma.h
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 7a0bc3df09..9ce9246194 100644
|
index b530e117b5..b245daa98e 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -44,6 +44,8 @@ block_ss.add(files(
|
@@ -42,6 +42,8 @@ block_ss.add(files(
|
||||||
'zeroinit.c',
|
'zeroinit.c',
|
||||||
), zstd, zlib, gnutls)
|
), zstd, zlib, gnutls)
|
||||||
|
|
||||||
+block_ss.add(files('../vma-writer.c'), libuuid)
|
+block_ss.add(files('../vma-writer.c'), libuuid)
|
||||||
+
|
+
|
||||||
softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
system_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
||||||
|
system_ss.add(files('block-ram-registrar.c'))
|
||||||
|
|
||||||
block_ss.add(when: 'CONFIG_QCOW1', if_true: files('qcow.c'))
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index b3e7ec0e92..cc46eabb42 100644
|
index 91a0aa64c6..620cc594b2 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -1064,6 +1064,8 @@ keyutils = dependency('libkeyutils', required: false,
|
@@ -1922,6 +1922,8 @@ endif
|
||||||
|
|
||||||
has_gettid = cc.has_function('gettid')
|
has_gettid = cc.has_function('gettid')
|
||||||
|
|
||||||
+libuuid = cc.find_library('uuid', required: true)
|
+libuuid = cc.find_library('uuid', required: true)
|
||||||
+
|
+
|
||||||
# Malloc tests
|
# libselinux
|
||||||
|
selinux = dependency('libselinux',
|
||||||
malloc = []
|
required: get_option('selinux'),
|
||||||
@@ -2743,6 +2745,9 @@ if have_tools
|
@@ -4023,6 +4025,9 @@ if have_tools
|
||||||
qemu_nbd = executable('qemu-nbd', files('qemu-nbd.c'),
|
dependencies: [blockdev, qemuutil, gnutls, selinux],
|
||||||
dependencies: [blockdev, qemuutil, gnutls], install: true)
|
install: true)
|
||||||
|
|
||||||
+ vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
+ vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
||||||
+ dependencies: [authz, block, crypto, io, qom], install: true)
|
+ dependencies: [authz, block, crypto, io, qom], install: true)
|
||||||
+
|
+
|
||||||
subdir('storage-daemon')
|
subdir('storage-daemon')
|
||||||
subdir('contrib/rdmacm-mux')
|
|
||||||
subdir('contrib/elf2dmp')
|
foreach exe: [ 'qemu-img', 'qemu-io', 'qemu-nbd', 'qemu-storage-daemon']
|
||||||
diff --git a/vma-reader.c b/vma-reader.c
|
diff --git a/vma-reader.c b/vma-reader.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..2b1d1cdab3
|
index 0000000000..d0b6721812
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma-reader.c
|
+++ b/vma-reader.c
|
||||||
@@ -0,0 +1,857 @@
|
@@ -0,0 +1,870 @@
|
||||||
+/*
|
+/*
|
||||||
+ * VMA: Virtual Machine Archive
|
+ * VMA: Virtual Machine Archive
|
||||||
+ *
|
+ *
|
||||||
|
@ -78,11 +84,11 @@ index 0000000000..2b1d1cdab3
|
||||||
+#include <glib.h>
|
+#include <glib.h>
|
||||||
+#include <uuid/uuid.h>
|
+#include <uuid/uuid.h>
|
||||||
+
|
+
|
||||||
+#include "qemu-common.h"
|
|
||||||
+#include "qemu/timer.h"
|
+#include "qemu/timer.h"
|
||||||
+#include "qemu/ratelimit.h"
|
+#include "qemu/ratelimit.h"
|
||||||
+#include "vma.h"
|
+#include "vma.h"
|
||||||
+#include "block/block.h"
|
+#include "block/block.h"
|
||||||
|
+#include "block/graph-lock.h"
|
||||||
+#include "sysemu/block-backend.h"
|
+#include "sysemu/block-backend.h"
|
||||||
+
|
+
|
||||||
+static unsigned char zero_vma_block[VMA_BLOCK_SIZE];
|
+static unsigned char zero_vma_block[VMA_BLOCK_SIZE];
|
||||||
|
@ -92,6 +98,7 @@ index 0000000000..2b1d1cdab3
|
||||||
+ bool write_zeroes;
|
+ bool write_zeroes;
|
||||||
+ unsigned long *bitmap;
|
+ unsigned long *bitmap;
|
||||||
+ int bitmap_size;
|
+ int bitmap_size;
|
||||||
|
+ bool skip;
|
||||||
+} VmaRestoreState;
|
+} VmaRestoreState;
|
||||||
+
|
+
|
||||||
+struct VmaReader {
|
+struct VmaReader {
|
||||||
|
@ -255,6 +262,9 @@ index 0000000000..2b1d1cdab3
|
||||||
+ if (vmar->rstate[i].bitmap) {
|
+ if (vmar->rstate[i].bitmap) {
|
||||||
+ g_free(vmar->rstate[i].bitmap);
|
+ g_free(vmar->rstate[i].bitmap);
|
||||||
+ }
|
+ }
|
||||||
|
+ if (vmar->rstate[i].target) {
|
||||||
|
+ blk_unref(vmar->rstate[i].target);
|
||||||
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (vmar->md5csum) {
|
+ if (vmar->md5csum) {
|
||||||
|
@ -486,13 +496,14 @@ index 0000000000..2b1d1cdab3
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void allocate_rstate(VmaReader *vmar, guint8 dev_id,
|
+static void allocate_rstate(VmaReader *vmar, guint8 dev_id,
|
||||||
+ BlockBackend *target, bool write_zeroes)
|
+ BlockBackend *target, bool write_zeroes, bool skip)
|
||||||
+{
|
+{
|
||||||
+ assert(vmar);
|
+ assert(vmar);
|
||||||
+ assert(dev_id);
|
+ assert(dev_id);
|
||||||
+
|
+
|
||||||
+ vmar->rstate[dev_id].target = target;
|
+ vmar->rstate[dev_id].target = target;
|
||||||
+ vmar->rstate[dev_id].write_zeroes = write_zeroes;
|
+ vmar->rstate[dev_id].write_zeroes = write_zeroes;
|
||||||
|
+ vmar->rstate[dev_id].skip = skip;
|
||||||
+
|
+
|
||||||
+ int64_t size = vmar->devinfo[dev_id].size;
|
+ int64_t size = vmar->devinfo[dev_id].size;
|
||||||
+
|
+
|
||||||
|
@ -507,28 +518,30 @@ index 0000000000..2b1d1cdab3
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id, BlockBackend *target,
|
+int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id, BlockBackend *target,
|
||||||
+ bool write_zeroes, Error **errp)
|
+ bool write_zeroes, bool skip, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ assert(vmar);
|
+ assert(vmar);
|
||||||
+ assert(target != NULL);
|
+ assert(target != NULL || skip);
|
||||||
+ assert(dev_id);
|
+ assert(dev_id);
|
||||||
+ assert(vmar->rstate[dev_id].target == NULL);
|
+ assert(vmar->rstate[dev_id].target == NULL && !vmar->rstate[dev_id].skip);
|
||||||
+
|
+
|
||||||
+ int64_t size = blk_getlength(target);
|
+ if (target != NULL) {
|
||||||
+ int64_t size_diff = size - vmar->devinfo[dev_id].size;
|
+ int64_t size = blk_getlength(target);
|
||||||
|
+ int64_t size_diff = size - vmar->devinfo[dev_id].size;
|
||||||
+
|
+
|
||||||
+ /* storage types can have different size restrictions, so it
|
+ /* storage types can have different size restrictions, so it
|
||||||
+ * is not always possible to create an image with exact size.
|
+ * is not always possible to create an image with exact size.
|
||||||
+ * So we tolerate a size difference up to 4MB.
|
+ * So we tolerate a size difference up to 4MB.
|
||||||
+ */
|
+ */
|
||||||
+ if ((size_diff < 0) || (size_diff > 4*1024*1024)) {
|
+ if ((size_diff < 0) || (size_diff > 4*1024*1024)) {
|
||||||
+ error_setg(errp, "vma_reader_register_bs for stream %s failed - "
|
+ error_setg(errp, "vma_reader_register_bs for stream %s failed - "
|
||||||
+ "unexpected size %zd != %zd", vmar->devinfo[dev_id].devname,
|
+ "unexpected size %zd != %zd", vmar->devinfo[dev_id].devname,
|
||||||
+ size, vmar->devinfo[dev_id].size);
|
+ size, vmar->devinfo[dev_id].size);
|
||||||
+ return -1;
|
+ return -1;
|
||||||
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ allocate_rstate(vmar, dev_id, target, write_zeroes);
|
+ allocate_rstate(vmar, dev_id, target, write_zeroes, skip);
|
||||||
+
|
+
|
||||||
+ return 0;
|
+ return 0;
|
||||||
+}
|
+}
|
||||||
|
@ -586,10 +599,12 @@ index 0000000000..2b1d1cdab3
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+ } else {
|
+ } else {
|
||||||
+ int res = blk_pwrite(target, sector_num * BDRV_SECTOR_SIZE, buf, nb_sectors * BDRV_SECTOR_SIZE, 0);
|
+ int res = blk_pwrite(target, sector_num * BDRV_SECTOR_SIZE, nb_sectors * BDRV_SECTOR_SIZE, buf, 0);
|
||||||
+ if (res < 0) {
|
+ if (res < 0) {
|
||||||
|
+ bdrv_graph_rdlock_main_loop();
|
||||||
+ error_setg(errp, "blk_pwrite to %s failed (%d)",
|
+ error_setg(errp, "blk_pwrite to %s failed (%d)",
|
||||||
+ bdrv_get_device_name(blk_bs(target)), res);
|
+ bdrv_get_device_name(blk_bs(target)), res);
|
||||||
|
+ bdrv_graph_rdunlock_main_loop();
|
||||||
+ return -1;
|
+ return -1;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
|
@ -621,19 +636,23 @@ index 0000000000..2b1d1cdab3
|
||||||
+ VmaRestoreState *rstate = &vmar->rstate[dev_id];
|
+ VmaRestoreState *rstate = &vmar->rstate[dev_id];
|
||||||
+ BlockBackend *target = NULL;
|
+ BlockBackend *target = NULL;
|
||||||
+
|
+
|
||||||
|
+ bool skip = rstate->skip;
|
||||||
|
+
|
||||||
+ if (dev_id != vmar->vmstate_stream) {
|
+ if (dev_id != vmar->vmstate_stream) {
|
||||||
+ target = rstate->target;
|
+ target = rstate->target;
|
||||||
+ if (!verify && !target) {
|
+ if (!verify && !target && !skip) {
|
||||||
+ error_setg(errp, "got wrong dev id %d", dev_id);
|
+ error_setg(errp, "got wrong dev id %d", dev_id);
|
||||||
+ return -1;
|
+ return -1;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (vma_reader_get_bitmap(rstate, cluster_num)) {
|
+ if (!skip) {
|
||||||
+ error_setg(errp, "found duplicated cluster %zd for stream %s",
|
+ if (vma_reader_get_bitmap(rstate, cluster_num)) {
|
||||||
+ cluster_num, vmar->devinfo[dev_id].devname);
|
+ error_setg(errp, "found duplicated cluster %zd for stream %s",
|
||||||
+ return -1;
|
+ cluster_num, vmar->devinfo[dev_id].devname);
|
||||||
|
+ return -1;
|
||||||
|
+ }
|
||||||
|
+ vma_reader_set_bitmap(rstate, cluster_num, 1);
|
||||||
+ }
|
+ }
|
||||||
+ vma_reader_set_bitmap(rstate, cluster_num, 1);
|
|
||||||
+
|
+
|
||||||
+ max_sector = vmar->devinfo[dev_id].size/BDRV_SECTOR_SIZE;
|
+ max_sector = vmar->devinfo[dev_id].size/BDRV_SECTOR_SIZE;
|
||||||
+ } else {
|
+ } else {
|
||||||
|
@ -679,7 +698,7 @@ index 0000000000..2b1d1cdab3
|
||||||
+ return -1;
|
+ return -1;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (!verify) {
|
+ if (!verify && !skip) {
|
||||||
+ int nb_sectors = end_sector - sector_num;
|
+ int nb_sectors = end_sector - sector_num;
|
||||||
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
||||||
+ buf + start, sector_num, nb_sectors,
|
+ buf + start, sector_num, nb_sectors,
|
||||||
|
@ -715,7 +734,7 @@ index 0000000000..2b1d1cdab3
|
||||||
+ return -1;
|
+ return -1;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (!verify) {
|
+ if (!verify && !skip) {
|
||||||
+ int nb_sectors = end_sector - sector_num;
|
+ int nb_sectors = end_sector - sector_num;
|
||||||
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
||||||
+ buf + start, sector_num,
|
+ buf + start, sector_num,
|
||||||
|
@ -740,7 +759,7 @@ index 0000000000..2b1d1cdab3
|
||||||
+ vmar->partial_zero_cluster_data += zero_size;
|
+ vmar->partial_zero_cluster_data += zero_size;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (rstate->write_zeroes && !verify) {
|
+ if (rstate->write_zeroes && !verify && !skip) {
|
||||||
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
+ if (restore_write_data(vmar, dev_id, target, vmstate_fd,
|
||||||
+ zero_vma_block, sector_num,
|
+ zero_vma_block, sector_num,
|
||||||
+ nb_sectors, errp) < 0) {
|
+ nb_sectors, errp) < 0) {
|
||||||
|
@ -911,7 +930,7 @@ index 0000000000..2b1d1cdab3
|
||||||
+
|
+
|
||||||
+ for (dev_id = 1; dev_id < 255; dev_id++) {
|
+ for (dev_id = 1; dev_id < 255; dev_id++) {
|
||||||
+ if (vma_reader_get_device_info(vmar, dev_id)) {
|
+ if (vma_reader_get_device_info(vmar, dev_id)) {
|
||||||
+ allocate_rstate(vmar, dev_id, NULL, false);
|
+ allocate_rstate(vmar, dev_id, NULL, false, false);
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
@ -920,10 +939,10 @@ index 0000000000..2b1d1cdab3
|
||||||
+
|
+
|
||||||
diff --git a/vma-writer.c b/vma-writer.c
|
diff --git a/vma-writer.c b/vma-writer.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..11d8321ffd
|
index 0000000000..a466652a5d
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma-writer.c
|
+++ b/vma-writer.c
|
||||||
@@ -0,0 +1,790 @@
|
@@ -0,0 +1,817 @@
|
||||||
+/*
|
+/*
|
||||||
+ * VMA: Virtual Machine Archive
|
+ * VMA: Virtual Machine Archive
|
||||||
+ *
|
+ *
|
||||||
|
@ -939,6 +958,8 @@ index 0000000000..11d8321ffd
|
||||||
+
|
+
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include <glib.h>
|
+#include <glib.h>
|
||||||
|
+#include <linux/magic.h>
|
||||||
|
+#include <sys/vfs.h>
|
||||||
+#include <uuid/uuid.h>
|
+#include <uuid/uuid.h>
|
||||||
+
|
+
|
||||||
+#include "vma.h"
|
+#include "vma.h"
|
||||||
|
@ -947,6 +968,8 @@ index 0000000000..11d8321ffd
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
+#include "qemu/coroutine.h"
|
+#include "qemu/coroutine.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
|
+#include "qemu/error-report.h"
|
||||||
|
+#include "qemu/memalign.h"
|
||||||
+
|
+
|
||||||
+#define DEBUG_VMA 0
|
+#define DEBUG_VMA 0
|
||||||
+
|
+
|
||||||
|
@ -1129,10 +1152,10 @@ index 0000000000..11d8321ffd
|
||||||
+{
|
+{
|
||||||
+ assert(qemu_in_coroutine());
|
+ assert(qemu_in_coroutine());
|
||||||
+ AioContext *ctx = qemu_get_current_aio_context();
|
+ AioContext *ctx = qemu_get_current_aio_context();
|
||||||
+ aio_set_fd_handler(ctx, fd, false, NULL, (IOHandler *)qemu_coroutine_enter,
|
+ aio_set_fd_handler(ctx, fd, NULL, (IOHandler *)qemu_coroutine_enter, NULL,
|
||||||
+ NULL, qemu_coroutine_self());
|
+ NULL, qemu_coroutine_self());
|
||||||
+ qemu_coroutine_yield();
|
+ qemu_coroutine_yield();
|
||||||
+ aio_set_fd_handler(ctx, fd, false, NULL, NULL, NULL, NULL);
|
+ aio_set_fd_handler(ctx, fd, NULL, NULL, NULL, NULL, NULL);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static ssize_t coroutine_fn
|
+static ssize_t coroutine_fn
|
||||||
|
@ -1181,6 +1204,23 @@ index 0000000000..11d8321ffd
|
||||||
+ return (done == bytes) ? bytes : -1;
|
+ return (done == bytes) ? bytes : -1;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
+static bool is_path_tmpfs(const char *path) {
|
||||||
|
+ struct statfs fs;
|
||||||
|
+ int ret;
|
||||||
|
+
|
||||||
|
+ do {
|
||||||
|
+ ret = statfs(path, &fs);
|
||||||
|
+ } while (ret != 0 && errno == EINTR);
|
||||||
|
+
|
||||||
|
+ if (ret != 0) {
|
||||||
|
+ warn_report("statfs call for %s failed, assuming not tmpfs - %s\n",
|
||||||
|
+ path, strerror(errno));
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ return fs.f_type == TMPFS_MAGIC;
|
||||||
|
+}
|
||||||
|
+
|
||||||
+VmaWriter *vma_writer_create(const char *filename, uuid_t uuid, Error **errp)
|
+VmaWriter *vma_writer_create(const char *filename, uuid_t uuid, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ const char *p;
|
+ const char *p;
|
||||||
|
@ -1230,12 +1270,19 @@ index 0000000000..11d8321ffd
|
||||||
+ }
|
+ }
|
||||||
+ /* try to use O_NONBLOCK */
|
+ /* try to use O_NONBLOCK */
|
||||||
+ fcntl(vmaw->fd, F_SETFL, fcntl(vmaw->fd, F_GETFL)|O_NONBLOCK);
|
+ fcntl(vmaw->fd, F_SETFL, fcntl(vmaw->fd, F_GETFL)|O_NONBLOCK);
|
||||||
+ } else {
|
+ } else {
|
||||||
+ oflags = O_NONBLOCK|O_DIRECT|O_WRONLY|O_EXCL;
|
+ gchar *dirname = g_path_get_dirname(filename);
|
||||||
|
+ oflags = O_NONBLOCK|O_WRONLY|O_EXCL;
|
||||||
|
+ if (!is_path_tmpfs(dirname)) {
|
||||||
|
+ oflags |= O_DIRECT;
|
||||||
|
+ }
|
||||||
|
+ g_free(dirname);
|
||||||
+ vmaw->fd = qemu_create(filename, oflags, 0644, errp);
|
+ vmaw->fd = qemu_create(filename, oflags, 0644, errp);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (vmaw->fd < 0) {
|
+ if (vmaw->fd < 0) {
|
||||||
|
+ error_free(*errp);
|
||||||
|
+ *errp = NULL;
|
||||||
+ error_setg(errp, "can't open file %s - %s\n", filename,
|
+ error_setg(errp, "can't open file %s - %s\n", filename,
|
||||||
+ g_strerror(errno));
|
+ g_strerror(errno));
|
||||||
+ goto err;
|
+ goto err;
|
||||||
|
@ -1470,17 +1517,16 @@ index 0000000000..11d8321ffd
|
||||||
+ int i;
|
+ int i;
|
||||||
+
|
+
|
||||||
+ g_assert(vmaw != NULL);
|
+ g_assert(vmaw != NULL);
|
||||||
|
+ g_assert(status != NULL);
|
||||||
+
|
+
|
||||||
+ if (status) {
|
+ status->status = vmaw->status;
|
||||||
+ status->status = vmaw->status;
|
+ g_strlcpy(status->errmsg, vmaw->errmsg, sizeof(status->errmsg));
|
||||||
+ g_strlcpy(status->errmsg, vmaw->errmsg, sizeof(status->errmsg));
|
+ for (i = 0; i <= 255; i++) {
|
||||||
+ for (i = 0; i <= 255; i++) {
|
+ status->stream_info[i] = vmaw->stream_info[i];
|
||||||
+ status->stream_info[i] = vmaw->stream_info[i];
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ uuid_unparse_lower(vmaw->uuid, status->uuid_str);
|
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
+ uuid_unparse_lower(vmaw->uuid, status->uuid_str);
|
||||||
|
+
|
||||||
+ status->closed = vmaw->closed;
|
+ status->closed = vmaw->closed;
|
||||||
+
|
+
|
||||||
+ return vmaw->status;
|
+ return vmaw->status;
|
||||||
|
@ -1716,10 +1762,10 @@ index 0000000000..11d8321ffd
|
||||||
+}
|
+}
|
||||||
diff --git a/vma.c b/vma.c
|
diff --git a/vma.c b/vma.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..df542b7732
|
index 0000000000..bb715e9061
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma.c
|
+++ b/vma.c
|
||||||
@@ -0,0 +1,851 @@
|
@@ -0,0 +1,901 @@
|
||||||
+/*
|
+/*
|
||||||
+ * VMA: Virtual Machine Archive
|
+ * VMA: Virtual Machine Archive
|
||||||
+ *
|
+ *
|
||||||
|
@ -1737,11 +1783,11 @@ index 0000000000..df542b7732
|
||||||
+#include <glib.h>
|
+#include <glib.h>
|
||||||
+
|
+
|
||||||
+#include "vma.h"
|
+#include "vma.h"
|
||||||
+#include "qemu-common.h"
|
|
||||||
+#include "qemu/module.h"
|
+#include "qemu/module.h"
|
||||||
+#include "qemu/error-report.h"
|
+#include "qemu/error-report.h"
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
|
+#include "qemu/memalign.h"
|
||||||
+#include "qapi/qmp/qdict.h"
|
+#include "qapi/qmp/qdict.h"
|
||||||
+#include "sysemu/block-backend.h"
|
+#include "sysemu/block-backend.h"
|
||||||
+
|
+
|
||||||
|
@ -1753,7 +1799,7 @@ index 0000000000..df542b7732
|
||||||
+ "vma list <filename>\n"
|
+ "vma list <filename>\n"
|
||||||
+ "vma config <filename> [-c config]\n"
|
+ "vma config <filename> [-c config]\n"
|
||||||
+ "vma create <filename> [-c config] pathname ...\n"
|
+ "vma create <filename> [-c config] pathname ...\n"
|
||||||
+ "vma extract <filename> [-r <fifo>] <targetdir>\n"
|
+ "vma extract <filename> [-d <drive-list>] [-r <fifo>] <targetdir>\n"
|
||||||
+ "vma verify <filename> [-v]\n"
|
+ "vma verify <filename> [-v]\n"
|
||||||
+ ;
|
+ ;
|
||||||
+
|
+
|
||||||
|
@ -1860,6 +1906,7 @@ index 0000000000..df542b7732
|
||||||
+ char *throttling_group;
|
+ char *throttling_group;
|
||||||
+ char *cache;
|
+ char *cache;
|
||||||
+ bool write_zero;
|
+ bool write_zero;
|
||||||
|
+ bool skip;
|
||||||
+} RestoreMap;
|
+} RestoreMap;
|
||||||
+
|
+
|
||||||
+static bool try_parse_option(char **line, const char *optname, char **out, const char *inbuf) {
|
+static bool try_parse_option(char **line, const char *optname, char **out, const char *inbuf) {
|
||||||
|
@ -1897,9 +1944,10 @@ index 0000000000..df542b7732
|
||||||
+ const char *filename;
|
+ const char *filename;
|
||||||
+ const char *dirname;
|
+ const char *dirname;
|
||||||
+ const char *readmap = NULL;
|
+ const char *readmap = NULL;
|
||||||
|
+ gchar **drive_list = NULL;
|
||||||
+
|
+
|
||||||
+ for (;;) {
|
+ for (;;) {
|
||||||
+ c = getopt(argc, argv, "hvr:");
|
+ c = getopt(argc, argv, "hvd:r:");
|
||||||
+ if (c == -1) {
|
+ if (c == -1) {
|
||||||
+ break;
|
+ break;
|
||||||
+ }
|
+ }
|
||||||
|
@ -1908,6 +1956,9 @@ index 0000000000..df542b7732
|
||||||
+ case 'h':
|
+ case 'h':
|
||||||
+ help();
|
+ help();
|
||||||
+ break;
|
+ break;
|
||||||
|
+ case 'd':
|
||||||
|
+ drive_list = g_strsplit(optarg, ",", 254);
|
||||||
|
+ break;
|
||||||
+ case 'r':
|
+ case 'r':
|
||||||
+ readmap = optarg;
|
+ readmap = optarg;
|
||||||
+ break;
|
+ break;
|
||||||
|
@ -1967,76 +2018,89 @@ index 0000000000..df542b7732
|
||||||
+ char *bps = NULL;
|
+ char *bps = NULL;
|
||||||
+ char *group = NULL;
|
+ char *group = NULL;
|
||||||
+ char *cache = NULL;
|
+ char *cache = NULL;
|
||||||
|
+ char *devname = NULL;
|
||||||
|
+ bool skip = false;
|
||||||
|
+ uint64_t bps_value = 0;
|
||||||
|
+ const char *path = NULL;
|
||||||
|
+ bool write_zero = true;
|
||||||
|
+
|
||||||
+ if (!line || line[0] == '\0' || !strcmp(line, "done\n")) {
|
+ if (!line || line[0] == '\0' || !strcmp(line, "done\n")) {
|
||||||
+ break;
|
+ break;
|
||||||
+ }
|
+ }
|
||||||
+ int len = strlen(line);
|
+ int len = strlen(line);
|
||||||
+ if (line[len - 1] == '\n') {
|
+ if (line[len - 1] == '\n') {
|
||||||
+ line[len - 1] = '\0';
|
+ line[len - 1] = '\0';
|
||||||
+ if (len == 1) {
|
+ len = len - 1;
|
||||||
|
+ if (len == 0) {
|
||||||
+ break;
|
+ break;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ while (1) {
|
+ if (strncmp(line, "skip", 4) == 0) {
|
||||||
+ if (!try_parse_option(&line, "format", &format, inbuf) &&
|
+ if (len < 6 || line[4] != '=') {
|
||||||
+ !try_parse_option(&line, "throttling.bps", &bps, inbuf) &&
|
+ g_error("read map failed - option 'skip' has no value ('%s')",
|
||||||
+ !try_parse_option(&line, "throttling.group", &group, inbuf) &&
|
+ inbuf);
|
||||||
+ !try_parse_option(&line, "cache", &cache, inbuf))
|
+ } else {
|
||||||
+ {
|
+ devname = line + 5;
|
||||||
+ break;
|
+ skip = true;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ uint64_t bps_value = 0;
|
|
||||||
+ if (bps) {
|
|
||||||
+ bps_value = verify_u64(bps);
|
|
||||||
+ g_free(bps);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ const char *path;
|
|
||||||
+ bool write_zero;
|
|
||||||
+ if (line[0] == '0' && line[1] == ':') {
|
|
||||||
+ path = line + 2;
|
|
||||||
+ write_zero = false;
|
|
||||||
+ } else if (line[0] == '1' && line[1] == ':') {
|
|
||||||
+ path = line + 2;
|
|
||||||
+ write_zero = true;
|
|
||||||
+ } else {
|
+ } else {
|
||||||
+ g_error("read map failed - parse error ('%s')", inbuf);
|
+ while (1) {
|
||||||
|
+ if (!try_parse_option(&line, "format", &format, inbuf) &&
|
||||||
|
+ !try_parse_option(&line, "throttling.bps", &bps, inbuf) &&
|
||||||
|
+ !try_parse_option(&line, "throttling.group", &group, inbuf) &&
|
||||||
|
+ !try_parse_option(&line, "cache", &cache, inbuf))
|
||||||
|
+ {
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (bps) {
|
||||||
|
+ bps_value = verify_u64(bps);
|
||||||
|
+ g_free(bps);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (line[0] == '0' && line[1] == ':') {
|
||||||
|
+ path = line + 2;
|
||||||
|
+ write_zero = false;
|
||||||
|
+ } else if (line[0] == '1' && line[1] == ':') {
|
||||||
|
+ path = line + 2;
|
||||||
|
+ write_zero = true;
|
||||||
|
+ } else {
|
||||||
|
+ g_error("read map failed - parse error ('%s')", inbuf);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ path = extract_devname(path, &devname, -1);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ char *devname = NULL;
|
|
||||||
+ path = extract_devname(path, &devname, -1);
|
|
||||||
+ if (!devname) {
|
+ if (!devname) {
|
||||||
+ g_error("read map failed - no dev name specified ('%s')",
|
+ g_error("read map failed - no dev name specified ('%s')",
|
||||||
+ inbuf);
|
+ inbuf);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ RestoreMap *map = g_new0(RestoreMap, 1);
|
+ RestoreMap *restore_map = g_new0(RestoreMap, 1);
|
||||||
+ map->devname = g_strdup(devname);
|
+ restore_map->devname = g_strdup(devname);
|
||||||
+ map->path = g_strdup(path);
|
+ restore_map->path = g_strdup(path);
|
||||||
+ map->format = format;
|
+ restore_map->format = format;
|
||||||
+ map->throttling_bps = bps_value;
|
+ restore_map->throttling_bps = bps_value;
|
||||||
+ map->throttling_group = group;
|
+ restore_map->throttling_group = group;
|
||||||
+ map->cache = cache;
|
+ restore_map->cache = cache;
|
||||||
+ map->write_zero = write_zero;
|
+ restore_map->write_zero = write_zero;
|
||||||
|
+ restore_map->skip = skip;
|
||||||
+
|
+
|
||||||
+ g_hash_table_insert(devmap, map->devname, map);
|
+ g_hash_table_insert(devmap, restore_map->devname, restore_map);
|
||||||
+
|
+
|
||||||
+ };
|
+ };
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ int i;
|
+ int i;
|
||||||
+ int vmstate_fd = -1;
|
+ int vmstate_fd = -1;
|
||||||
+ guint8 vmstate_stream = 0;
|
+ bool drive_rename_bitmap[255];
|
||||||
+
|
+ memset(drive_rename_bitmap, 0, sizeof(drive_rename_bitmap));
|
||||||
+ BlockBackend *blk = NULL;
|
|
||||||
+
|
+
|
||||||
+ for (i = 1; i < 255; i++) {
|
+ for (i = 1; i < 255; i++) {
|
||||||
+ VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
|
+ VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
|
||||||
+ if (di && (strcmp(di->devname, "vmstate") == 0)) {
|
+ if (di && (strcmp(di->devname, "vmstate") == 0)) {
|
||||||
+ vmstate_stream = i;
|
|
||||||
+ char *statefn = g_strdup_printf("%s/vmstate.bin", dirname);
|
+ char *statefn = g_strdup_printf("%s/vmstate.bin", dirname);
|
||||||
+ vmstate_fd = open(statefn, O_WRONLY|O_CREAT|O_EXCL, 0644);
|
+ vmstate_fd = open(statefn, O_WRONLY|O_CREAT|O_EXCL, 0644);
|
||||||
+ if (vmstate_fd < 0) {
|
+ if (vmstate_fd < 0) {
|
||||||
|
@ -2052,8 +2116,25 @@ index 0000000000..df542b7732
|
||||||
+ const char *cache = NULL;
|
+ const char *cache = NULL;
|
||||||
+ int flags = BDRV_O_RDWR;
|
+ int flags = BDRV_O_RDWR;
|
||||||
+ bool write_zero = true;
|
+ bool write_zero = true;
|
||||||
|
+ bool skip = false;
|
||||||
+
|
+
|
||||||
+ if (readmap) {
|
+ BlockBackend *blk = NULL;
|
||||||
|
+
|
||||||
|
+ if (drive_list) {
|
||||||
|
+ skip = true;
|
||||||
|
+ int j;
|
||||||
|
+ for (j = 0; drive_list[j]; j++) {
|
||||||
|
+ if (strcmp(drive_list[j], di->devname) == 0) {
|
||||||
|
+ skip = false;
|
||||||
|
+ drive_rename_bitmap[i] = true;
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+ } else {
|
||||||
|
+ drive_rename_bitmap[i] = true;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (!skip && readmap) {
|
||||||
+ RestoreMap *map;
|
+ RestoreMap *map;
|
||||||
+ map = (RestoreMap *)g_hash_table_lookup(devmap, di->devname);
|
+ map = (RestoreMap *)g_hash_table_lookup(devmap, di->devname);
|
||||||
+ if (map == NULL) {
|
+ if (map == NULL) {
|
||||||
|
@ -2065,7 +2146,8 @@ index 0000000000..df542b7732
|
||||||
+ throttling_group = map->throttling_group;
|
+ throttling_group = map->throttling_group;
|
||||||
+ cache = map->cache;
|
+ cache = map->cache;
|
||||||
+ write_zero = map->write_zero;
|
+ write_zero = map->write_zero;
|
||||||
+ } else {
|
+ skip = map->skip;
|
||||||
|
+ } else if (!skip) {
|
||||||
+ devfn = g_strdup_printf("%s/tmp-disk-%s.raw",
|
+ devfn = g_strdup_printf("%s/tmp-disk-%s.raw",
|
||||||
+ dirname, di->devname);
|
+ dirname, di->devname);
|
||||||
+ printf("DEVINFO %s %zd\n", devfn, di->size);
|
+ printf("DEVINFO %s %zd\n", devfn, di->size);
|
||||||
|
@ -2083,57 +2165,60 @@ index 0000000000..df542b7732
|
||||||
+ write_zero = false;
|
+ write_zero = false;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ size_t devlen = strlen(devfn);
|
+ if (!skip) {
|
||||||
+ QDict *options = NULL;
|
+ size_t devlen = strlen(devfn);
|
||||||
+ bool writethrough;
|
+ QDict *options = NULL;
|
||||||
+ if (format) {
|
+ bool writethrough;
|
||||||
+ /* explicit format from commandline */
|
+ if (format) {
|
||||||
+ options = qdict_new();
|
+ /* explicit format from commandline */
|
||||||
+ qdict_put_str(options, "driver", format);
|
+ options = qdict_new();
|
||||||
+ } else if ((devlen > 4 && strcmp(devfn+devlen-4, ".raw") == 0) ||
|
+ qdict_put_str(options, "driver", format);
|
||||||
+ strncmp(devfn, "/dev/", 5) == 0)
|
+ } else if ((devlen > 4 && strcmp(devfn+devlen-4, ".raw") == 0) ||
|
||||||
+ {
|
+ strncmp(devfn, "/dev/", 5) == 0)
|
||||||
+ /* This part is now deprecated for PVE as well (just as qemu
|
+ {
|
||||||
+ * deprecated not specifying an explicit raw format, too.
|
+ /* This part is now deprecated for PVE as well (just as qemu
|
||||||
+ */
|
+ * deprecated not specifying an explicit raw format, too.
|
||||||
+ /* explicit raw format */
|
+ */
|
||||||
+ options = qdict_new();
|
+ /* explicit raw format */
|
||||||
+ qdict_put_str(options, "driver", "raw");
|
+ options = qdict_new();
|
||||||
+ }
|
+ qdict_put_str(options, "driver", "raw");
|
||||||
+ if (cache && bdrv_parse_cache_mode(cache, &flags, &writethrough)) {
|
|
||||||
+ g_error("invalid cache option: %s\n", cache);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (errp || !(blk = blk_new_open(devfn, NULL, options, flags, &errp))) {
|
|
||||||
+ g_error("can't open file %s - %s", devfn,
|
|
||||||
+ error_get_pretty(errp));
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (cache) {
|
|
||||||
+ blk_set_enable_write_cache(blk, !writethrough);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (throttling_group) {
|
|
||||||
+ blk_io_limits_enable(blk, throttling_group);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (throttling_bps) {
|
|
||||||
+ if (!throttling_group) {
|
|
||||||
+ blk_io_limits_enable(blk, devfn);
|
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ ThrottleConfig cfg;
|
+ if (cache && bdrv_parse_cache_mode(cache, &flags, &writethrough)) {
|
||||||
+ throttle_config_init(&cfg);
|
+ g_error("invalid cache option: %s\n", cache);
|
||||||
+ cfg.buckets[THROTTLE_BPS_WRITE].avg = throttling_bps;
|
+ }
|
||||||
+ Error *err = NULL;
|
+
|
||||||
+ if (!throttle_is_valid(&cfg, &err)) {
|
+ if (errp || !(blk = blk_new_open(devfn, NULL, options, flags, &errp))) {
|
||||||
+ error_report_err(err);
|
+ g_error("can't open file %s - %s", devfn,
|
||||||
+ g_error("failed to apply throttling");
|
+ error_get_pretty(errp));
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (cache) {
|
||||||
|
+ blk_set_enable_write_cache(blk, !writethrough);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (throttling_group) {
|
||||||
|
+ blk_io_limits_enable(blk, throttling_group);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (throttling_bps) {
|
||||||
|
+ if (!throttling_group) {
|
||||||
|
+ blk_io_limits_enable(blk, devfn);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ ThrottleConfig cfg;
|
||||||
|
+ throttle_config_init(&cfg);
|
||||||
|
+ cfg.buckets[THROTTLE_BPS_WRITE].avg = throttling_bps;
|
||||||
|
+ Error *err = NULL;
|
||||||
|
+ if (!throttle_is_valid(&cfg, &err)) {
|
||||||
|
+ error_report_err(err);
|
||||||
|
+ g_error("failed to apply throttling");
|
||||||
|
+ }
|
||||||
|
+ blk_set_io_limits(blk, &cfg);
|
||||||
+ }
|
+ }
|
||||||
+ blk_set_io_limits(blk, &cfg);
|
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (vma_reader_register_bs(vmar, i, blk, write_zero, &errp) < 0) {
|
+ if (vma_reader_register_bs(vmar, i, blk, write_zero, skip, &errp) < 0) {
|
||||||
+ g_error("%s", error_get_pretty(errp));
|
+ g_error("%s", error_get_pretty(errp));
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
@ -2143,6 +2228,10 @@ index 0000000000..df542b7732
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
+ if (drive_list) {
|
||||||
|
+ g_strfreev(drive_list);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
+ if (vma_reader_restore(vmar, vmstate_fd, verbose, &errp) < 0) {
|
+ if (vma_reader_restore(vmar, vmstate_fd, verbose, &errp) < 0) {
|
||||||
+ g_error("restore failed - %s", error_get_pretty(errp));
|
+ g_error("restore failed - %s", error_get_pretty(errp));
|
||||||
+ }
|
+ }
|
||||||
|
@ -2150,7 +2239,7 @@ index 0000000000..df542b7732
|
||||||
+ if (!readmap) {
|
+ if (!readmap) {
|
||||||
+ for (i = 1; i < 255; i++) {
|
+ for (i = 1; i < 255; i++) {
|
||||||
+ VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
|
+ VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
|
||||||
+ if (di && (i != vmstate_stream)) {
|
+ if (di && drive_rename_bitmap[i]) {
|
||||||
+ char *tmpfn = g_strdup_printf("%s/tmp-disk-%s.raw",
|
+ char *tmpfn = g_strdup_printf("%s/tmp-disk-%s.raw",
|
||||||
+ dirname, di->devname);
|
+ dirname, di->devname);
|
||||||
+ char *fn = g_strdup_printf("%s/disk-%s.raw",
|
+ char *fn = g_strdup_printf("%s/disk-%s.raw",
|
||||||
|
@ -2165,8 +2254,6 @@ index 0000000000..df542b7732
|
||||||
+
|
+
|
||||||
+ vma_reader_destroy(vmar);
|
+ vma_reader_destroy(vmar);
|
||||||
+
|
+
|
||||||
+ blk_unref(blk);
|
|
||||||
+
|
|
||||||
+ bdrv_close_all();
|
+ bdrv_close_all();
|
||||||
+
|
+
|
||||||
+ return ret;
|
+ return ret;
|
||||||
|
@ -2251,7 +2338,7 @@ index 0000000000..df542b7732
|
||||||
+ struct iovec iov;
|
+ struct iovec iov;
|
||||||
+ QEMUIOVector qiov;
|
+ QEMUIOVector qiov;
|
||||||
+
|
+
|
||||||
+ int64_t start, end;
|
+ int64_t start, end, readlen;
|
||||||
+ int ret = 0;
|
+ int ret = 0;
|
||||||
+
|
+
|
||||||
+ unsigned char *buf = blk_blockalign(job->target, VMA_CLUSTER_SIZE);
|
+ unsigned char *buf = blk_blockalign(job->target, VMA_CLUSTER_SIZE);
|
||||||
|
@ -2265,16 +2352,24 @@ index 0000000000..df542b7732
|
||||||
+ iov.iov_len = VMA_CLUSTER_SIZE;
|
+ iov.iov_len = VMA_CLUSTER_SIZE;
|
||||||
+ qemu_iovec_init_external(&qiov, &iov, 1);
|
+ qemu_iovec_init_external(&qiov, &iov, 1);
|
||||||
+
|
+
|
||||||
|
+ if (start + 1 == end) {
|
||||||
|
+ memset(buf, 0, VMA_CLUSTER_SIZE);
|
||||||
|
+ readlen = job->len - start * VMA_CLUSTER_SIZE;
|
||||||
|
+ assert(readlen > 0 && readlen <= VMA_CLUSTER_SIZE);
|
||||||
|
+ } else {
|
||||||
|
+ readlen = VMA_CLUSTER_SIZE;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
+ ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE,
|
+ ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE,
|
||||||
+ VMA_CLUSTER_SIZE, &qiov, 0);
|
+ readlen, &qiov, 0);
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
+ vma_writer_set_error(job->vmaw, "read error", -1);
|
+ vma_writer_set_error(job->vmaw, "read error");
|
||||||
+ goto out;
|
+ goto out;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ size_t zb = 0;
|
+ size_t zb = 0;
|
||||||
+ if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) {
|
+ if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) {
|
||||||
+ vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed", -1);
|
+ vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed");
|
||||||
+ goto out;
|
+ goto out;
|
||||||
+ }
|
+ }
|
||||||
+ }
|
+ }
|
||||||
|
@ -2292,7 +2387,7 @@ index 0000000000..df542b7732
|
||||||
+
|
+
|
||||||
+static int create_archive(int argc, char **argv)
|
+static int create_archive(int argc, char **argv)
|
||||||
+{
|
+{
|
||||||
+ int i, c;
|
+ int c;
|
||||||
+ int verbose = 0;
|
+ int verbose = 0;
|
||||||
+ const char *archivename;
|
+ const char *archivename;
|
||||||
+ GList *backup_coroutines = NULL;
|
+ GList *backup_coroutines = NULL;
|
||||||
|
@ -2450,6 +2545,7 @@ index 0000000000..df542b7732
|
||||||
+ vma_writer_get_status(vmaw, &vmastat);
|
+ vma_writer_get_status(vmaw, &vmastat);
|
||||||
+
|
+
|
||||||
+ if (verbose) {
|
+ if (verbose) {
|
||||||
|
+ int i;
|
||||||
+ for (i = 0; i < 256; i++) {
|
+ for (i = 0; i < 256; i++) {
|
||||||
+ VmaStreamInfo *si = &vmastat.stream_info[i];
|
+ VmaStreamInfo *si = &vmastat.stream_info[i];
|
||||||
+ if (si->size) {
|
+ if (si->size) {
|
||||||
|
@ -2573,7 +2669,7 @@ index 0000000000..df542b7732
|
||||||
+}
|
+}
|
||||||
diff --git a/vma.h b/vma.h
|
diff --git a/vma.h b/vma.h
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..c895c97f6d
|
index 0000000000..86d2873aa5
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma.h
|
+++ b/vma.h
|
||||||
@@ -0,0 +1,150 @@
|
@@ -0,0 +1,150 @@
|
||||||
|
@ -2711,7 +2807,7 @@ index 0000000000..c895c97f6d
|
||||||
+int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw);
|
+int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw);
|
||||||
+
|
+
|
||||||
+int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status);
|
+int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status);
|
||||||
+void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...);
|
+void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
|
||||||
+
|
+
|
||||||
+
|
+
|
||||||
+VmaReader *vma_reader_create(const char *filename, Error **errp);
|
+VmaReader *vma_reader_create(const char *filename, Error **errp);
|
||||||
|
@ -2721,7 +2817,7 @@ index 0000000000..c895c97f6d
|
||||||
+VmaDeviceInfo *vma_reader_get_device_info(VmaReader *vmar, guint8 dev_id);
|
+VmaDeviceInfo *vma_reader_get_device_info(VmaReader *vmar, guint8 dev_id);
|
||||||
+int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id,
|
+int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id,
|
||||||
+ BlockBackend *target, bool write_zeroes,
|
+ BlockBackend *target, bool write_zeroes,
|
||||||
+ Error **errp);
|
+ bool skip, Error **errp);
|
||||||
+int vma_reader_restore(VmaReader *vmar, int vmstate_fd, bool verbose,
|
+int vma_reader_restore(VmaReader *vmar, int vmstate_fd, bool verbose,
|
||||||
+ Error **errp);
|
+ Error **errp);
|
||||||
+int vma_reader_verify(VmaReader *vmar, bool verbose, Error **errp);
|
+int vma_reader_verify(VmaReader *vmar, bool verbose, Error **errp);
|
File diff suppressed because it is too large
Load Diff
|
@ -9,21 +9,23 @@ Subject: [PATCH] PVE-Backup: add backup-dump block driver
|
||||||
- job.c: make job_should_pause non-static
|
- job.c: make job_should_pause non-static
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to coroutine changes]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/backup-dump.c | 168 ++++++++++++++++++++++++++++++++++++++
|
block/backup-dump.c | 172 +++++++++++++++++++++++++++++++
|
||||||
block/backup.c | 32 +++-----
|
block/backup.c | 30 ++----
|
||||||
block/meson.build | 1 +
|
block/meson.build | 1 +
|
||||||
include/block/block_int.h | 35 ++++++++
|
include/block/block_int-common.h | 35 +++++++
|
||||||
job.c | 3 +-
|
job.c | 3 +-
|
||||||
5 files changed, 216 insertions(+), 23 deletions(-)
|
5 files changed, 218 insertions(+), 23 deletions(-)
|
||||||
create mode 100644 block/backup-dump.c
|
create mode 100644 block/backup-dump.c
|
||||||
|
|
||||||
diff --git a/block/backup-dump.c b/block/backup-dump.c
|
diff --git a/block/backup-dump.c b/block/backup-dump.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..93d7f46950
|
index 0000000000..e46abf1070
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/backup-dump.c
|
+++ b/block/backup-dump.c
|
||||||
@@ -0,0 +1,168 @@
|
@@ -0,0 +1,172 @@
|
||||||
+/*
|
+/*
|
||||||
+ * BlockDriver to send backup data stream to a callback function
|
+ * BlockDriver to send backup data stream to a callback function
|
||||||
+ *
|
+ *
|
||||||
|
@ -35,7 +37,8 @@ index 0000000000..93d7f46950
|
||||||
+ */
|
+ */
|
||||||
+
|
+
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include "qemu-common.h"
|
+
|
||||||
|
+#include "qapi/qmp/qdict.h"
|
||||||
+#include "qom/object_interfaces.h"
|
+#include "qom/object_interfaces.h"
|
||||||
+#include "block/block_int.h"
|
+#include "block/block_int.h"
|
||||||
+
|
+
|
||||||
|
@ -46,7 +49,8 @@ index 0000000000..93d7f46950
|
||||||
+ void *dump_cb_data;
|
+ void *dump_cb_data;
|
||||||
+} BDRVBackupDumpState;
|
+} BDRVBackupDumpState;
|
||||||
+
|
+
|
||||||
+static int qemu_backup_dump_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
|
+static coroutine_fn int qemu_backup_dump_co_get_info(BlockDriverState *bs,
|
||||||
|
+ BlockDriverInfo *bdi)
|
||||||
+{
|
+{
|
||||||
+ BDRVBackupDumpState *s = bs->opaque;
|
+ BDRVBackupDumpState *s = bs->opaque;
|
||||||
+
|
+
|
||||||
|
@ -87,7 +91,7 @@ index 0000000000..93d7f46950
|
||||||
+ /* Nothing to do. */
|
+ /* Nothing to do. */
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int64_t qemu_backup_dump_getlength(BlockDriverState *bs)
|
+static coroutine_fn int64_t qemu_backup_dump_co_getlength(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ BDRVBackupDumpState *s = bs->opaque;
|
+ BDRVBackupDumpState *s = bs->opaque;
|
||||||
+
|
+
|
||||||
|
@ -147,8 +151,8 @@ index 0000000000..93d7f46950
|
||||||
+
|
+
|
||||||
+ .bdrv_close = qemu_backup_dump_close,
|
+ .bdrv_close = qemu_backup_dump_close,
|
||||||
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
|
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
|
||||||
+ .bdrv_getlength = qemu_backup_dump_getlength,
|
+ .bdrv_co_getlength = qemu_backup_dump_co_getlength,
|
||||||
+ .bdrv_get_info = qemu_backup_dump_get_info,
|
+ .bdrv_co_get_info = qemu_backup_dump_co_get_info,
|
||||||
+
|
+
|
||||||
+ .bdrv_co_writev = qemu_backup_dump_co_writev,
|
+ .bdrv_co_writev = qemu_backup_dump_co_writev,
|
||||||
+
|
+
|
||||||
|
@ -167,7 +171,7 @@ index 0000000000..93d7f46950
|
||||||
+block_init(bdrv_backup_dump_init);
|
+block_init(bdrv_backup_dump_init);
|
||||||
+
|
+
|
||||||
+
|
+
|
||||||
+BlockDriverState *bdrv_backup_dump_create(
|
+BlockDriverState *coroutine_fn bdrv_co_backup_dump_create(
|
||||||
+ int dump_cb_block_size,
|
+ int dump_cb_block_size,
|
||||||
+ uint64_t byte_size,
|
+ uint64_t byte_size,
|
||||||
+ BackupDumpFunc *dump_cb,
|
+ BackupDumpFunc *dump_cb,
|
||||||
|
@ -175,9 +179,11 @@ index 0000000000..93d7f46950
|
||||||
+ Error **errp)
|
+ Error **errp)
|
||||||
+{
|
+{
|
||||||
+ BDRVBackupDumpState *state;
|
+ BDRVBackupDumpState *state;
|
||||||
+ BlockDriverState *bs = bdrv_new_open_driver(
|
|
||||||
+ &bdrv_backup_dump_drive, NULL, BDRV_O_RDWR, errp);
|
|
||||||
+
|
+
|
||||||
|
+ QDict *options = qdict_new();
|
||||||
|
+ qdict_put_str(options, "driver", "backup-dump-drive");
|
||||||
|
+
|
||||||
|
+ BlockDriverState *bs = bdrv_co_open(NULL, NULL, options, BDRV_O_RDWR, errp);
|
||||||
+ if (!bs) {
|
+ if (!bs) {
|
||||||
+ return NULL;
|
+ return NULL;
|
||||||
+ }
|
+ }
|
||||||
|
@ -193,16 +199,16 @@ index 0000000000..93d7f46950
|
||||||
+ return bs;
|
+ return bs;
|
||||||
+}
|
+}
|
||||||
diff --git a/block/backup.c b/block/backup.c
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
index bd3614ce70..8bae9b060e 100644
|
index eba5b11493..1963e47ab9 100644
|
||||||
--- a/block/backup.c
|
--- a/block/backup.c
|
||||||
+++ b/block/backup.c
|
+++ b/block/backup.c
|
||||||
@@ -31,28 +31,6 @@
|
@@ -29,28 +29,6 @@
|
||||||
|
|
||||||
#define BACKUP_CLUSTER_SIZE_DEFAULT (1 << 16)
|
#include "block/copy-before-write.h"
|
||||||
|
|
||||||
-typedef struct BackupBlockJob {
|
-typedef struct BackupBlockJob {
|
||||||
- BlockJob common;
|
- BlockJob common;
|
||||||
- BlockDriverState *backup_top;
|
- BlockDriverState *cbw;
|
||||||
- BlockDriverState *source_bs;
|
- BlockDriverState *source_bs;
|
||||||
- BlockDriverState *target_bs;
|
- BlockDriverState *target_bs;
|
||||||
-
|
-
|
||||||
|
@ -225,11 +231,10 @@ index bd3614ce70..8bae9b060e 100644
|
||||||
static const BlockJobDriver backup_job_driver;
|
static const BlockJobDriver backup_job_driver;
|
||||||
|
|
||||||
static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret)
|
static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret)
|
||||||
@@ -504,6 +482,16 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
@@ -462,6 +440,14 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
goto error;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
+ cluster_size = backup_calculate_cluster_size(target, errp);
|
cluster_size = block_copy_cluster_size(bcs);
|
||||||
+ if (cluster_size < 0) {
|
+ if (cluster_size < 0) {
|
||||||
+ goto error;
|
+ goto error;
|
||||||
+ }
|
+ }
|
||||||
|
@ -238,12 +243,11 @@ index bd3614ce70..8bae9b060e 100644
|
||||||
+ if (bdrv_get_info(bs, &bdi) == 0) {
|
+ if (bdrv_get_info(bs, &bdi) == 0) {
|
||||||
+ cluster_size = MAX(cluster_size, bdi.cluster_size);
|
+ cluster_size = MAX(cluster_size, bdi.cluster_size);
|
||||||
+ }
|
+ }
|
||||||
+
|
|
||||||
/*
|
if (perf->max_chunk && perf->max_chunk < cluster_size) {
|
||||||
* If source is in backing chain of target assume that target is going to be
|
error_setg(errp, "Required max-chunk (%" PRIi64 ") is less than backup "
|
||||||
* used for "image fleecing", i.e. it should represent a kind of snapshot of
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 9ce9246194..19bc2b7cbb 100644
|
index b245daa98e..e99914eaa4 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -4,6 +4,7 @@ block_ss.add(files(
|
@@ -4,6 +4,7 @@ block_ss.add(files(
|
||||||
|
@ -251,28 +255,28 @@ index 9ce9246194..19bc2b7cbb 100644
|
||||||
'amend.c',
|
'amend.c',
|
||||||
'backup.c',
|
'backup.c',
|
||||||
+ 'backup-dump.c',
|
+ 'backup-dump.c',
|
||||||
'backup-top.c',
|
|
||||||
'blkdebug.c',
|
'blkdebug.c',
|
||||||
'blklogwrites.c',
|
'blklogwrites.c',
|
||||||
diff --git a/include/block/block_int.h b/include/block/block_int.h
|
'blkverify.c',
|
||||||
index 11442893d0..8f6135e6a5 100644
|
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h
|
||||||
--- a/include/block/block_int.h
|
index 761276127e..b3e6697613 100644
|
||||||
+++ b/include/block/block_int.h
|
--- a/include/block/block_int-common.h
|
||||||
|
+++ b/include/block/block_int-common.h
|
||||||
@@ -26,6 +26,7 @@
|
@@ -26,6 +26,7 @@
|
||||||
|
|
||||||
#include "block/accounting.h"
|
#include "block/aio.h"
|
||||||
#include "block/block.h"
|
#include "block/block-common.h"
|
||||||
+#include "block/block-copy.h"
|
+#include "block/block-copy.h"
|
||||||
#include "block/aio-wait.h"
|
#include "block/block-global-state.h"
|
||||||
#include "qemu/queue.h"
|
#include "block/snapshot.h"
|
||||||
#include "qemu/coroutine.h"
|
#include "qemu/iov.h"
|
||||||
@@ -63,6 +64,40 @@
|
@@ -60,6 +61,40 @@
|
||||||
|
|
||||||
#define BLOCK_PROBE_BUF_SIZE 512
|
#define BLOCK_PROBE_BUF_SIZE 512
|
||||||
|
|
||||||
+typedef int BackupDumpFunc(void *opaque, uint64_t offset, uint64_t bytes, const void *buf);
|
+typedef int BackupDumpFunc(void *opaque, uint64_t offset, uint64_t bytes, const void *buf);
|
||||||
+
|
+
|
||||||
+BlockDriverState *bdrv_backuo_dump_create(
|
+BlockDriverState *coroutine_fn bdrv_co_backup_dump_create(
|
||||||
+ int dump_cb_block_size,
|
+ int dump_cb_block_size,
|
||||||
+ uint64_t byte_size,
|
+ uint64_t byte_size,
|
||||||
+ BackupDumpFunc *dump_cb,
|
+ BackupDumpFunc *dump_cb,
|
||||||
|
@ -284,7 +288,7 @@ index 11442893d0..8f6135e6a5 100644
|
||||||
+typedef struct BlockCopyState BlockCopyState;
|
+typedef struct BlockCopyState BlockCopyState;
|
||||||
+typedef struct BackupBlockJob {
|
+typedef struct BackupBlockJob {
|
||||||
+ BlockJob common;
|
+ BlockJob common;
|
||||||
+ BlockDriverState *backup_top;
|
+ BlockDriverState *cbw;
|
||||||
+ BlockDriverState *source_bs;
|
+ BlockDriverState *source_bs;
|
||||||
+ BlockDriverState *target_bs;
|
+ BlockDriverState *target_bs;
|
||||||
+
|
+
|
||||||
|
@ -308,16 +312,16 @@ index 11442893d0..8f6135e6a5 100644
|
||||||
BDRV_TRACKED_READ,
|
BDRV_TRACKED_READ,
|
||||||
BDRV_TRACKED_WRITE,
|
BDRV_TRACKED_WRITE,
|
||||||
diff --git a/job.c b/job.c
|
diff --git a/job.c b/job.c
|
||||||
index e7a5d28854..44eec9a441 100644
|
index 660ce22c56..baf54c8d60 100644
|
||||||
--- a/job.c
|
--- a/job.c
|
||||||
+++ b/job.c
|
+++ b/job.c
|
||||||
@@ -269,7 +269,8 @@ static bool job_started(Job *job)
|
@@ -331,7 +331,8 @@ static bool job_started_locked(Job *job)
|
||||||
return job->co;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
-static bool job_should_pause(Job *job)
|
/* Called with job_mutex held. */
|
||||||
+bool job_should_pause(Job *job);
|
-static bool job_should_pause_locked(Job *job)
|
||||||
+bool job_should_pause(Job *job)
|
+bool job_should_pause_locked(Job *job);
|
||||||
|
+bool job_should_pause_locked(Job *job)
|
||||||
{
|
{
|
||||||
return job->pause_count > 0;
|
return job->pause_count > 0;
|
||||||
}
|
}
|
|
@ -7,14 +7,14 @@ Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
---
|
---
|
||||||
include/qemu/job.h | 12 ++++++++++++
|
include/qemu/job.h | 12 ++++++++++++
|
||||||
job.c | 31 +++++++++++++++++++++++++++++++
|
job.c | 34 ++++++++++++++++++++++++++++++++++
|
||||||
2 files changed, 43 insertions(+)
|
2 files changed, 46 insertions(+)
|
||||||
|
|
||||||
diff --git a/include/qemu/job.h b/include/qemu/job.h
|
diff --git a/include/qemu/job.h b/include/qemu/job.h
|
||||||
index 41162ed494..6662c63519 100644
|
index 2b873f2576..528cd6acb9 100644
|
||||||
--- a/include/qemu/job.h
|
--- a/include/qemu/job.h
|
||||||
+++ b/include/qemu/job.h
|
+++ b/include/qemu/job.h
|
||||||
@@ -285,6 +285,18 @@ typedef enum JobCreateFlags {
|
@@ -362,6 +362,18 @@ void job_unlock(void);
|
||||||
*/
|
*/
|
||||||
JobTxn *job_txn_new(void);
|
JobTxn *job_txn_new(void);
|
||||||
|
|
||||||
|
@ -34,10 +34,10 @@ index 41162ed494..6662c63519 100644
|
||||||
* Release a reference that was previously acquired with job_txn_add_job or
|
* Release a reference that was previously acquired with job_txn_add_job or
|
||||||
* job_txn_new. If it's the last reference to the object, it will be freed.
|
* job_txn_new. If it's the last reference to the object, it will be freed.
|
||||||
diff --git a/job.c b/job.c
|
diff --git a/job.c b/job.c
|
||||||
index 44eec9a441..a0753ff2f1 100644
|
index baf54c8d60..3ac5e5cde2 100644
|
||||||
--- a/job.c
|
--- a/job.c
|
||||||
+++ b/job.c
|
+++ b/job.c
|
||||||
@@ -72,6 +72,8 @@ struct JobTxn {
|
@@ -94,6 +94,8 @@ struct JobTxn {
|
||||||
|
|
||||||
/* Reference count */
|
/* Reference count */
|
||||||
int refcnt;
|
int refcnt;
|
||||||
|
@ -45,8 +45,8 @@ index 44eec9a441..a0753ff2f1 100644
|
||||||
+ bool sequential;
|
+ bool sequential;
|
||||||
};
|
};
|
||||||
|
|
||||||
/* Right now, this mutex is only needed to synchronize accesses to job->busy
|
void job_lock(void)
|
||||||
@@ -102,6 +104,25 @@ JobTxn *job_txn_new(void)
|
@@ -119,6 +121,25 @@ JobTxn *job_txn_new(void)
|
||||||
return txn;
|
return txn;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -69,20 +69,23 @@ index 44eec9a441..a0753ff2f1 100644
|
||||||
+ job_start(first);
|
+ job_start(first);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
static void job_txn_ref(JobTxn *txn)
|
/* Called with job_mutex held. */
|
||||||
|
static void job_txn_ref_locked(JobTxn *txn)
|
||||||
{
|
{
|
||||||
txn->refcnt++;
|
@@ -1042,6 +1063,12 @@ static void job_completed_txn_success_locked(Job *job)
|
||||||
@@ -850,6 +871,9 @@ static void job_completed_txn_success(Job *job)
|
|
||||||
*/
|
*/
|
||||||
QLIST_FOREACH(other_job, &txn->jobs, txn_list) {
|
QLIST_FOREACH(other_job, &txn->jobs, txn_list) {
|
||||||
if (!job_is_completed(other_job)) {
|
if (!job_is_completed_locked(other_job)) {
|
||||||
+ if (txn->sequential) {
|
+ if (txn->sequential) {
|
||||||
|
+ job_unlock();
|
||||||
|
+ /* Needs to be called without holding the job lock */
|
||||||
+ job_start(other_job);
|
+ job_start(other_job);
|
||||||
|
+ job_lock();
|
||||||
+ }
|
+ }
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
assert(other_job->ret == 0);
|
assert(other_job->ret == 0);
|
||||||
@@ -1020,6 +1044,13 @@ int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error **errp)
|
@@ -1253,6 +1280,13 @@ int job_finish_sync_locked(Job *job,
|
||||||
return -EBUSY;
|
return -EBUSY;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -90,9 +93,9 @@ index 44eec9a441..a0753ff2f1 100644
|
||||||
+ * of cancelling, these have not begun work so job_enter won't do anything,
|
+ * of cancelling, these have not begun work so job_enter won't do anything,
|
||||||
+ * let's ensure they are marked as ABORTING if required */
|
+ * let's ensure they are marked as ABORTING if required */
|
||||||
+ if (job->status == JOB_STATUS_CREATED && job->txn->sequential) {
|
+ if (job->status == JOB_STATUS_CREATED && job->txn->sequential) {
|
||||||
+ job_update_rc(job);
|
+ job_update_rc_locked(job);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
AIO_WAIT_WHILE(job->aio_context,
|
job_unlock();
|
||||||
(job_enter(job), !job_is_completed(job)));
|
AIO_WAIT_WHILE_UNLOCKED(job->aio_context,
|
||||||
|
(job_enter(job), !job_is_completed(job)));
|
|
@ -1,452 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Mon, 29 Jun 2020 11:06:03 +0200
|
|
||||||
Subject: [PATCH] PVE-Backup: Add dirty-bitmap tracking for incremental backups
|
|
||||||
|
|
||||||
Uses QEMU's existing MIRROR_SYNC_MODE_BITMAP and a dirty-bitmap on top
|
|
||||||
of all backed-up drives. This will only execute the data-write callback
|
|
||||||
for any changed chunks, the PBS rust code will reuse chunks from the
|
|
||||||
previous index for everything it doesn't receive if reuse_index is true.
|
|
||||||
|
|
||||||
On error or cancellation, remove all dirty bitmaps to ensure
|
|
||||||
consistency.
|
|
||||||
|
|
||||||
Add PBS/incremental specific information to query backup info QMP and
|
|
||||||
HMP commands.
|
|
||||||
|
|
||||||
Only supported for PBS backups.
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/monitor/block-hmp-cmds.c | 1 +
|
|
||||||
monitor/hmp-cmds.c | 45 ++++++++++----
|
|
||||||
proxmox-backup-client.c | 3 +-
|
|
||||||
proxmox-backup-client.h | 1 +
|
|
||||||
pve-backup.c | 103 ++++++++++++++++++++++++++++++---
|
|
||||||
qapi/block-core.json | 12 +++-
|
|
||||||
6 files changed, 142 insertions(+), 23 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
|
||||||
index 1e29681d30..3fca3ce3e9 100644
|
|
||||||
--- a/block/monitor/block-hmp-cmds.c
|
|
||||||
+++ b/block/monitor/block-hmp-cmds.c
|
|
||||||
@@ -1042,6 +1042,7 @@ void hmp_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
false, NULL, // PBS fingerprint
|
|
||||||
false, NULL, // PBS backup-id
|
|
||||||
false, 0, // PBS backup-time
|
|
||||||
+ false, false, // PBS incremental
|
|
||||||
true, dir ? BACKUP_FORMAT_DIR : BACKUP_FORMAT_VMA,
|
|
||||||
false, NULL, false, NULL, !!devlist,
|
|
||||||
devlist, qdict_haskey(qdict, "speed"), speed, &error);
|
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
|
||||||
index 7efcd2d641..b2b5f1298b 100644
|
|
||||||
--- a/monitor/hmp-cmds.c
|
|
||||||
+++ b/monitor/hmp-cmds.c
|
|
||||||
@@ -221,19 +221,42 @@ void hmp_info_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
monitor_printf(mon, "End time: %s", ctime(&info->end_time));
|
|
||||||
}
|
|
||||||
|
|
||||||
- int per = (info->has_total && info->total &&
|
|
||||||
- info->has_transferred && info->transferred) ?
|
|
||||||
- (info->transferred * 100)/info->total : 0;
|
|
||||||
- int zero_per = (info->has_total && info->total &&
|
|
||||||
- info->has_zero_bytes && info->zero_bytes) ?
|
|
||||||
- (info->zero_bytes * 100)/info->total : 0;
|
|
||||||
monitor_printf(mon, "Backup file: %s\n", info->backup_file);
|
|
||||||
monitor_printf(mon, "Backup uuid: %s\n", info->uuid);
|
|
||||||
- monitor_printf(mon, "Total size: %zd\n", info->total);
|
|
||||||
- monitor_printf(mon, "Transferred bytes: %zd (%d%%)\n",
|
|
||||||
- info->transferred, per);
|
|
||||||
- monitor_printf(mon, "Zero bytes: %zd (%d%%)\n",
|
|
||||||
- info->zero_bytes, zero_per);
|
|
||||||
+
|
|
||||||
+ if (!(info->has_total && info->total)) {
|
|
||||||
+ // this should not happen normally
|
|
||||||
+ monitor_printf(mon, "Total size: %d\n", 0);
|
|
||||||
+ } else {
|
|
||||||
+ bool incremental = false;
|
|
||||||
+ size_t total_or_dirty = info->total;
|
|
||||||
+ if (info->has_transferred) {
|
|
||||||
+ if (info->has_dirty && info->dirty) {
|
|
||||||
+ if (info->dirty < info->total) {
|
|
||||||
+ total_or_dirty = info->dirty;
|
|
||||||
+ incremental = true;
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ int per = (info->transferred * 100)/total_or_dirty;
|
|
||||||
+
|
|
||||||
+ monitor_printf(mon, "Backup mode: %s\n", incremental ? "incremental" : "full");
|
|
||||||
+
|
|
||||||
+ int zero_per = (info->has_zero_bytes && info->zero_bytes) ?
|
|
||||||
+ (info->zero_bytes * 100)/info->total : 0;
|
|
||||||
+ monitor_printf(mon, "Total size: %zd\n", info->total);
|
|
||||||
+ monitor_printf(mon, "Transferred bytes: %zd (%d%%)\n",
|
|
||||||
+ info->transferred, per);
|
|
||||||
+ monitor_printf(mon, "Zero bytes: %zd (%d%%)\n",
|
|
||||||
+ info->zero_bytes, zero_per);
|
|
||||||
+
|
|
||||||
+ if (info->has_reused) {
|
|
||||||
+ int reused_per = (info->reused * 100)/total_or_dirty;
|
|
||||||
+ monitor_printf(mon, "Reused bytes: %zd (%d%%)\n",
|
|
||||||
+ info->reused, reused_per);
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
|
|
||||||
qapi_free_BackupStatus(info);
|
|
||||||
diff --git a/proxmox-backup-client.c b/proxmox-backup-client.c
|
|
||||||
index a8f6653a81..4ce7bc0b5e 100644
|
|
||||||
--- a/proxmox-backup-client.c
|
|
||||||
+++ b/proxmox-backup-client.c
|
|
||||||
@@ -89,6 +89,7 @@ proxmox_backup_co_register_image(
|
|
||||||
ProxmoxBackupHandle *pbs,
|
|
||||||
const char *device_name,
|
|
||||||
uint64_t size,
|
|
||||||
+ bool incremental,
|
|
||||||
Error **errp)
|
|
||||||
{
|
|
||||||
Coroutine *co = qemu_coroutine_self();
|
|
||||||
@@ -98,7 +99,7 @@ proxmox_backup_co_register_image(
|
|
||||||
int pbs_res = -1;
|
|
||||||
|
|
||||||
proxmox_backup_register_image_async(
|
|
||||||
- pbs, device_name, size ,proxmox_backup_schedule_wake, &waker, &pbs_res, &pbs_err);
|
|
||||||
+ pbs, device_name, size, incremental, proxmox_backup_schedule_wake, &waker, &pbs_res, &pbs_err);
|
|
||||||
qemu_coroutine_yield();
|
|
||||||
if (pbs_res < 0) {
|
|
||||||
if (errp) error_setg(errp, "backup register image failed: %s", pbs_err ? pbs_err : "unknown error");
|
|
||||||
diff --git a/proxmox-backup-client.h b/proxmox-backup-client.h
|
|
||||||
index 1dda8b7d8f..8cbf645b2c 100644
|
|
||||||
--- a/proxmox-backup-client.h
|
|
||||||
+++ b/proxmox-backup-client.h
|
|
||||||
@@ -32,6 +32,7 @@ proxmox_backup_co_register_image(
|
|
||||||
ProxmoxBackupHandle *pbs,
|
|
||||||
const char *device_name,
|
|
||||||
uint64_t size,
|
|
||||||
+ bool incremental,
|
|
||||||
Error **errp);
|
|
||||||
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 66868dec14..6cdbd40529 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -28,6 +28,8 @@
|
|
||||||
*
|
|
||||||
*/
|
|
||||||
|
|
||||||
+const char *PBS_BITMAP_NAME = "pbs-incremental-dirty-bitmap";
|
|
||||||
+
|
|
||||||
static struct PVEBackupState {
|
|
||||||
struct {
|
|
||||||
// Everithing accessed from qmp_backup_query command is protected using lock
|
|
||||||
@@ -39,7 +41,9 @@ static struct PVEBackupState {
|
|
||||||
uuid_t uuid;
|
|
||||||
char uuid_str[37];
|
|
||||||
size_t total;
|
|
||||||
+ size_t dirty;
|
|
||||||
size_t transferred;
|
|
||||||
+ size_t reused;
|
|
||||||
size_t zero_bytes;
|
|
||||||
} stat;
|
|
||||||
int64_t speed;
|
|
||||||
@@ -66,6 +70,7 @@ typedef struct PVEBackupDevInfo {
|
|
||||||
uint8_t dev_id;
|
|
||||||
bool completed;
|
|
||||||
char targetfile[PATH_MAX];
|
|
||||||
+ BdrvDirtyBitmap *bitmap;
|
|
||||||
BlockDriverState *target;
|
|
||||||
} PVEBackupDevInfo;
|
|
||||||
|
|
||||||
@@ -105,11 +110,12 @@ static bool pvebackup_error_or_canceled(void)
|
|
||||||
return error_or_canceled;
|
|
||||||
}
|
|
||||||
|
|
||||||
-static void pvebackup_add_transfered_bytes(size_t transferred, size_t zero_bytes)
|
|
||||||
+static void pvebackup_add_transfered_bytes(size_t transferred, size_t zero_bytes, size_t reused)
|
|
||||||
{
|
|
||||||
qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
backup_state.stat.zero_bytes += zero_bytes;
|
|
||||||
backup_state.stat.transferred += transferred;
|
|
||||||
+ backup_state.stat.reused += reused;
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -148,7 +154,8 @@ pvebackup_co_dump_pbs_cb(
|
|
||||||
pvebackup_propagate_error(local_err);
|
|
||||||
return pbs_res;
|
|
||||||
} else {
|
|
||||||
- pvebackup_add_transfered_bytes(size, !buf ? size : 0);
|
|
||||||
+ size_t reused = (pbs_res == 0) ? size : 0;
|
|
||||||
+ pvebackup_add_transfered_bytes(size, !buf ? size : 0, reused);
|
|
||||||
}
|
|
||||||
|
|
||||||
return size;
|
|
||||||
@@ -208,11 +215,11 @@ pvebackup_co_dump_vma_cb(
|
|
||||||
} else {
|
|
||||||
if (remaining >= VMA_CLUSTER_SIZE) {
|
|
||||||
assert(ret == VMA_CLUSTER_SIZE);
|
|
||||||
- pvebackup_add_transfered_bytes(VMA_CLUSTER_SIZE, zero_bytes);
|
|
||||||
+ pvebackup_add_transfered_bytes(VMA_CLUSTER_SIZE, zero_bytes, 0);
|
|
||||||
remaining -= VMA_CLUSTER_SIZE;
|
|
||||||
} else {
|
|
||||||
assert(ret == remaining);
|
|
||||||
- pvebackup_add_transfered_bytes(remaining, zero_bytes);
|
|
||||||
+ pvebackup_add_transfered_bytes(remaining, zero_bytes, 0);
|
|
||||||
remaining = 0;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -248,6 +255,18 @@ static void coroutine_fn pvebackup_co_cleanup(void *unused)
|
|
||||||
if (local_err != NULL) {
|
|
||||||
pvebackup_propagate_error(local_err);
|
|
||||||
}
|
|
||||||
+ } else {
|
|
||||||
+ // on error or cancel we cannot ensure synchronization of dirty
|
|
||||||
+ // bitmaps with backup server, so remove all and do full backup next
|
|
||||||
+ GList *l = backup_state.di_list;
|
|
||||||
+ while (l) {
|
|
||||||
+ PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
+ l = g_list_next(l);
|
|
||||||
+
|
|
||||||
+ if (di->bitmap) {
|
|
||||||
+ bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
|
|
||||||
proxmox_backup_disconnect(backup_state.pbs);
|
|
||||||
@@ -303,6 +322,12 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
// remove self from job queue
|
|
||||||
backup_state.di_list = g_list_remove(backup_state.di_list, di);
|
|
||||||
|
|
||||||
+ if (di->bitmap && ret < 0) {
|
|
||||||
+ // on error or cancel we cannot ensure synchronization of dirty
|
|
||||||
+ // bitmaps with backup server, so remove all and do full backup next
|
|
||||||
+ bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
g_free(di);
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
@@ -472,12 +497,18 @@ static bool create_backup_jobs(void) {
|
|
||||||
|
|
||||||
assert(di->target != NULL);
|
|
||||||
|
|
||||||
+ MirrorSyncMode sync_mode = MIRROR_SYNC_MODE_FULL;
|
|
||||||
+ BitmapSyncMode bitmap_mode = BITMAP_SYNC_MODE_NEVER;
|
|
||||||
+ if (di->bitmap) {
|
|
||||||
+ sync_mode = MIRROR_SYNC_MODE_BITMAP;
|
|
||||||
+ bitmap_mode = BITMAP_SYNC_MODE_ON_SUCCESS;
|
|
||||||
+ }
|
|
||||||
AioContext *aio_context = bdrv_get_aio_context(di->bs);
|
|
||||||
aio_context_acquire(aio_context);
|
|
||||||
|
|
||||||
BlockJob *job = backup_job_create(
|
|
||||||
- NULL, di->bs, di->target, backup_state.speed, MIRROR_SYNC_MODE_FULL, NULL,
|
|
||||||
- BITMAP_SYNC_MODE_NEVER, false, NULL, &perf, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
|
|
||||||
+ NULL, di->bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
|
||||||
+ bitmap_mode, false, NULL, &perf, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
|
|
||||||
JOB_DEFAULT, pvebackup_complete_cb, di, NULL, &local_err);
|
|
||||||
|
|
||||||
aio_context_release(aio_context);
|
|
||||||
@@ -528,6 +559,8 @@ typedef struct QmpBackupTask {
|
|
||||||
const char *fingerprint;
|
|
||||||
bool has_fingerprint;
|
|
||||||
int64_t backup_time;
|
|
||||||
+ bool has_use_dirty_bitmap;
|
|
||||||
+ bool use_dirty_bitmap;
|
|
||||||
bool has_format;
|
|
||||||
BackupFormat format;
|
|
||||||
bool has_config_file;
|
|
||||||
@@ -619,6 +652,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
|
|
||||||
size_t total = 0;
|
|
||||||
+ size_t dirty = 0;
|
|
||||||
|
|
||||||
l = di_list;
|
|
||||||
while (l) {
|
|
||||||
@@ -656,6 +690,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
int dump_cb_block_size = PROXMOX_BACKUP_DEFAULT_CHUNK_SIZE; // Hardcoded (4M)
|
|
||||||
firewall_name = "fw.conf";
|
|
||||||
|
|
||||||
+ bool use_dirty_bitmap = task->has_use_dirty_bitmap && task->use_dirty_bitmap;
|
|
||||||
+
|
|
||||||
char *pbs_err = NULL;
|
|
||||||
pbs = proxmox_backup_new(
|
|
||||||
task->backup_file,
|
|
||||||
@@ -675,7 +711,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
|
|
||||||
- if (proxmox_backup_co_connect(pbs, task->errp) < 0)
|
|
||||||
+ int connect_result = proxmox_backup_co_connect(pbs, task->errp);
|
|
||||||
+ if (connect_result < 0)
|
|
||||||
goto err;
|
|
||||||
|
|
||||||
/* register all devices */
|
|
||||||
@@ -686,9 +723,40 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
|
|
||||||
const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
|
|
||||||
- int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, task->errp);
|
|
||||||
- if (dev_id < 0)
|
|
||||||
+ BdrvDirtyBitmap *bitmap = bdrv_find_dirty_bitmap(di->bs, PBS_BITMAP_NAME);
|
|
||||||
+ bool expect_only_dirty = false;
|
|
||||||
+
|
|
||||||
+ if (use_dirty_bitmap) {
|
|
||||||
+ if (bitmap == NULL) {
|
|
||||||
+ bitmap = bdrv_create_dirty_bitmap(di->bs, dump_cb_block_size, PBS_BITMAP_NAME, task->errp);
|
|
||||||
+ if (!bitmap) {
|
|
||||||
+ goto err;
|
|
||||||
+ }
|
|
||||||
+ } else {
|
|
||||||
+ expect_only_dirty = proxmox_backup_check_incremental(pbs, devname, di->size) != 0;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (expect_only_dirty) {
|
|
||||||
+ dirty += bdrv_get_dirty_count(bitmap);
|
|
||||||
+ } else {
|
|
||||||
+ /* mark entire bitmap as dirty to make full backup */
|
|
||||||
+ bdrv_set_dirty_bitmap(bitmap, 0, di->size);
|
|
||||||
+ dirty += di->size;
|
|
||||||
+ }
|
|
||||||
+ di->bitmap = bitmap;
|
|
||||||
+ } else {
|
|
||||||
+ dirty += di->size;
|
|
||||||
+
|
|
||||||
+ /* after a full backup the old dirty bitmap is invalid anyway */
|
|
||||||
+ if (bitmap != NULL) {
|
|
||||||
+ bdrv_release_dirty_bitmap(bitmap);
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, expect_only_dirty, task->errp);
|
|
||||||
+ if (dev_id < 0) {
|
|
||||||
goto err;
|
|
||||||
+ }
|
|
||||||
|
|
||||||
if (!(di->target = bdrv_backup_dump_create(dump_cb_block_size, di->size, pvebackup_co_dump_pbs_cb, di, task->errp))) {
|
|
||||||
goto err;
|
|
||||||
@@ -697,6 +765,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
di->dev_id = dev_id;
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_VMA) {
|
|
||||||
+ dirty = total;
|
|
||||||
+
|
|
||||||
vmaw = vma_writer_create(task->backup_file, uuid, &local_err);
|
|
||||||
if (!vmaw) {
|
|
||||||
if (local_err) {
|
|
||||||
@@ -724,6 +794,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_DIR) {
|
|
||||||
+ dirty = total;
|
|
||||||
+
|
|
||||||
if (mkdir(task->backup_file, 0640) != 0) {
|
|
||||||
error_setg_errno(task->errp, errno, "can't create directory '%s'\n",
|
|
||||||
task->backup_file);
|
|
||||||
@@ -796,8 +868,10 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
char *uuid_str = g_strdup(backup_state.stat.uuid_str);
|
|
||||||
|
|
||||||
backup_state.stat.total = total;
|
|
||||||
+ backup_state.stat.dirty = dirty;
|
|
||||||
backup_state.stat.transferred = 0;
|
|
||||||
backup_state.stat.zero_bytes = 0;
|
|
||||||
+ backup_state.stat.reused = format == BACKUP_FORMAT_PBS && dirty >= total ? 0 : total - dirty;
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
@@ -821,6 +895,10 @@ err:
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
l = g_list_next(l);
|
|
||||||
|
|
||||||
+ if (di->bitmap) {
|
|
||||||
+ bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
if (di->target) {
|
|
||||||
bdrv_unref(di->target);
|
|
||||||
}
|
|
||||||
@@ -862,6 +940,7 @@ UuidInfo *qmp_backup(
|
|
||||||
bool has_fingerprint, const char *fingerprint,
|
|
||||||
bool has_backup_id, const char *backup_id,
|
|
||||||
bool has_backup_time, int64_t backup_time,
|
|
||||||
+ bool has_use_dirty_bitmap, bool use_dirty_bitmap,
|
|
||||||
bool has_format, BackupFormat format,
|
|
||||||
bool has_config_file, const char *config_file,
|
|
||||||
bool has_firewall_file, const char *firewall_file,
|
|
||||||
@@ -880,6 +959,8 @@ UuidInfo *qmp_backup(
|
|
||||||
.backup_id = backup_id,
|
|
||||||
.has_backup_time = has_backup_time,
|
|
||||||
.backup_time = backup_time,
|
|
||||||
+ .has_use_dirty_bitmap = has_use_dirty_bitmap,
|
|
||||||
+ .use_dirty_bitmap = use_dirty_bitmap,
|
|
||||||
.has_format = has_format,
|
|
||||||
.format = format,
|
|
||||||
.has_config_file = has_config_file,
|
|
||||||
@@ -948,10 +1029,14 @@ BackupStatus *qmp_query_backup(Error **errp)
|
|
||||||
|
|
||||||
info->has_total = true;
|
|
||||||
info->total = backup_state.stat.total;
|
|
||||||
+ info->has_dirty = true;
|
|
||||||
+ info->dirty = backup_state.stat.dirty;
|
|
||||||
info->has_zero_bytes = true;
|
|
||||||
info->zero_bytes = backup_state.stat.zero_bytes;
|
|
||||||
info->has_transferred = true;
|
|
||||||
info->transferred = backup_state.stat.transferred;
|
|
||||||
+ info->has_reused = true;
|
|
||||||
+ info->reused = backup_state.stat.reused;
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index c5d604693f..a138ad08d4 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -712,8 +712,13 @@
|
|
||||||
#
|
|
||||||
# @total: total amount of bytes involved in the backup process
|
|
||||||
#
|
|
||||||
+# @dirty: with incremental mode (PBS) this is the amount of bytes involved
|
|
||||||
+# in the backup process which are marked dirty.
|
|
||||||
+#
|
|
||||||
# @transferred: amount of bytes already backed up.
|
|
||||||
#
|
|
||||||
+# @reused: amount of bytes reused due to deduplication.
|
|
||||||
+#
|
|
||||||
# @zero-bytes: amount of 'zero' bytes detected.
|
|
||||||
#
|
|
||||||
# @start-time: time (epoch) when backup job started.
|
|
||||||
@@ -726,8 +731,8 @@
|
|
||||||
#
|
|
||||||
##
|
|
||||||
{ 'struct': 'BackupStatus',
|
|
||||||
- 'data': {'*status': 'str', '*errmsg': 'str', '*total': 'int',
|
|
||||||
- '*transferred': 'int', '*zero-bytes': 'int',
|
|
||||||
+ 'data': {'*status': 'str', '*errmsg': 'str', '*total': 'int', '*dirty': 'int',
|
|
||||||
+ '*transferred': 'int', '*zero-bytes': 'int', '*reused': 'int',
|
|
||||||
'*start-time': 'int', '*end-time': 'int',
|
|
||||||
'*backup-file': 'str', '*uuid': 'str' } }
|
|
||||||
|
|
||||||
@@ -770,6 +775,8 @@
|
|
||||||
#
|
|
||||||
# @backup-time: backup timestamp (Unix epoch, required for format 'pbs')
|
|
||||||
#
|
|
||||||
+# @use-dirty-bitmap: use dirty bitmap to detect incremental changes since last job (optional for format 'pbs')
|
|
||||||
+#
|
|
||||||
# Returns: the uuid of the backup job
|
|
||||||
#
|
|
||||||
##
|
|
||||||
@@ -780,6 +787,7 @@
|
|
||||||
'*fingerprint': 'str',
|
|
||||||
'*backup-id': 'str',
|
|
||||||
'*backup-time': 'int',
|
|
||||||
+ '*use-dirty-bitmap': 'bool',
|
|
||||||
'*format': 'BackupFormat',
|
|
||||||
'*config-file': 'str',
|
|
||||||
'*firewall-file': 'str',
|
|
File diff suppressed because it is too large
Load Diff
|
@ -1,219 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Dietmar Maurer <dietmar@proxmox.com>
|
|
||||||
Date: Thu, 9 Jul 2020 12:53:08 +0200
|
|
||||||
Subject: [PATCH] PVE: various PBS fixes
|
|
||||||
|
|
||||||
pbs: fix crypt and compress parameters
|
|
||||||
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
||||||
|
|
||||||
PVE: handle PBS write callback with big blocks correctly
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
|
|
||||||
PVE: add zero block handling to PBS dump callback
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/monitor/block-hmp-cmds.c | 4 ++-
|
|
||||||
pve-backup.c | 59 ++++++++++++++++++++++++++--------
|
|
||||||
qapi/block-core.json | 6 ++++
|
|
||||||
3 files changed, 55 insertions(+), 14 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
|
||||||
index 3fca3ce3e9..69254396d5 100644
|
|
||||||
--- a/block/monitor/block-hmp-cmds.c
|
|
||||||
+++ b/block/monitor/block-hmp-cmds.c
|
|
||||||
@@ -1042,7 +1042,9 @@ void hmp_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
false, NULL, // PBS fingerprint
|
|
||||||
false, NULL, // PBS backup-id
|
|
||||||
false, 0, // PBS backup-time
|
|
||||||
- false, false, // PBS incremental
|
|
||||||
+ false, false, // PBS use-dirty-bitmap
|
|
||||||
+ false, false, // PBS compress
|
|
||||||
+ false, false, // PBS encrypt
|
|
||||||
true, dir ? BACKUP_FORMAT_DIR : BACKUP_FORMAT_VMA,
|
|
||||||
false, NULL, false, NULL, !!devlist,
|
|
||||||
devlist, qdict_haskey(qdict, "speed"), speed, &error);
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 6cdbd40529..7527885251 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -8,6 +8,7 @@
|
|
||||||
#include "block/blockjob.h"
|
|
||||||
#include "qapi/qapi-commands-block.h"
|
|
||||||
#include "qapi/qmp/qerror.h"
|
|
||||||
+#include "qemu/cutils.h"
|
|
||||||
|
|
||||||
/* PVE backup state and related function */
|
|
||||||
|
|
||||||
@@ -67,6 +68,7 @@ opts_init(pvebackup_init);
|
|
||||||
typedef struct PVEBackupDevInfo {
|
|
||||||
BlockDriverState *bs;
|
|
||||||
size_t size;
|
|
||||||
+ uint64_t block_size;
|
|
||||||
uint8_t dev_id;
|
|
||||||
bool completed;
|
|
||||||
char targetfile[PATH_MAX];
|
|
||||||
@@ -135,10 +137,13 @@ pvebackup_co_dump_pbs_cb(
|
|
||||||
PVEBackupDevInfo *di = opaque;
|
|
||||||
|
|
||||||
assert(backup_state.pbs);
|
|
||||||
+ assert(buf);
|
|
||||||
|
|
||||||
Error *local_err = NULL;
|
|
||||||
int pbs_res = -1;
|
|
||||||
|
|
||||||
+ bool is_zero_block = size == di->block_size && buffer_is_zero(buf, size);
|
|
||||||
+
|
|
||||||
qemu_co_mutex_lock(&backup_state.dump_callback_mutex);
|
|
||||||
|
|
||||||
// avoid deadlock if job is cancelled
|
|
||||||
@@ -147,16 +152,28 @@ pvebackup_co_dump_pbs_cb(
|
|
||||||
return -1;
|
|
||||||
}
|
|
||||||
|
|
||||||
- pbs_res = proxmox_backup_co_write_data(backup_state.pbs, di->dev_id, buf, start, size, &local_err);
|
|
||||||
+ uint64_t transferred = 0;
|
|
||||||
+ uint64_t reused = 0;
|
|
||||||
+ while (transferred < size) {
|
|
||||||
+ uint64_t left = size - transferred;
|
|
||||||
+ uint64_t to_transfer = left < di->block_size ? left : di->block_size;
|
|
||||||
+
|
|
||||||
+ pbs_res = proxmox_backup_co_write_data(backup_state.pbs, di->dev_id,
|
|
||||||
+ is_zero_block ? NULL : buf + transferred, start + transferred,
|
|
||||||
+ to_transfer, &local_err);
|
|
||||||
+ transferred += to_transfer;
|
|
||||||
+
|
|
||||||
+ if (pbs_res < 0) {
|
|
||||||
+ pvebackup_propagate_error(local_err);
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.dump_callback_mutex);
|
|
||||||
+ return pbs_res;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ reused += pbs_res == 0 ? to_transfer : 0;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
qemu_co_mutex_unlock(&backup_state.dump_callback_mutex);
|
|
||||||
-
|
|
||||||
- if (pbs_res < 0) {
|
|
||||||
- pvebackup_propagate_error(local_err);
|
|
||||||
- return pbs_res;
|
|
||||||
- } else {
|
|
||||||
- size_t reused = (pbs_res == 0) ? size : 0;
|
|
||||||
- pvebackup_add_transfered_bytes(size, !buf ? size : 0, reused);
|
|
||||||
- }
|
|
||||||
+ pvebackup_add_transfered_bytes(size, is_zero_block ? size : 0, reused);
|
|
||||||
|
|
||||||
return size;
|
|
||||||
}
|
|
||||||
@@ -178,6 +195,7 @@ pvebackup_co_dump_vma_cb(
|
|
||||||
int ret = -1;
|
|
||||||
|
|
||||||
assert(backup_state.vmaw);
|
|
||||||
+ assert(buf);
|
|
||||||
|
|
||||||
uint64_t remaining = size;
|
|
||||||
|
|
||||||
@@ -204,9 +222,7 @@ pvebackup_co_dump_vma_cb(
|
|
||||||
qemu_co_mutex_unlock(&backup_state.dump_callback_mutex);
|
|
||||||
|
|
||||||
++cluster_num;
|
|
||||||
- if (buf) {
|
|
||||||
- buf += VMA_CLUSTER_SIZE;
|
|
||||||
- }
|
|
||||||
+ buf += VMA_CLUSTER_SIZE;
|
|
||||||
if (ret < 0) {
|
|
||||||
Error *local_err = NULL;
|
|
||||||
vma_writer_error_propagate(backup_state.vmaw, &local_err);
|
|
||||||
@@ -569,6 +585,10 @@ typedef struct QmpBackupTask {
|
|
||||||
const char *firewall_file;
|
|
||||||
bool has_devlist;
|
|
||||||
const char *devlist;
|
|
||||||
+ bool has_compress;
|
|
||||||
+ bool compress;
|
|
||||||
+ bool has_encrypt;
|
|
||||||
+ bool encrypt;
|
|
||||||
bool has_speed;
|
|
||||||
int64_t speed;
|
|
||||||
Error **errp;
|
|
||||||
@@ -692,6 +712,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
|
|
||||||
bool use_dirty_bitmap = task->has_use_dirty_bitmap && task->use_dirty_bitmap;
|
|
||||||
|
|
||||||
+
|
|
||||||
char *pbs_err = NULL;
|
|
||||||
pbs = proxmox_backup_new(
|
|
||||||
task->backup_file,
|
|
||||||
@@ -701,8 +722,10 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
task->has_password ? task->password : NULL,
|
|
||||||
task->has_keyfile ? task->keyfile : NULL,
|
|
||||||
task->has_key_password ? task->key_password : NULL,
|
|
||||||
+ task->has_compress ? task->compress : true,
|
|
||||||
+ task->has_encrypt ? task->encrypt : task->has_keyfile,
|
|
||||||
task->has_fingerprint ? task->fingerprint : NULL,
|
|
||||||
- &pbs_err);
|
|
||||||
+ &pbs_err);
|
|
||||||
|
|
||||||
if (!pbs) {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
@@ -721,6 +744,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
l = g_list_next(l);
|
|
||||||
|
|
||||||
+ di->block_size = dump_cb_block_size;
|
|
||||||
+
|
|
||||||
const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
|
|
||||||
BdrvDirtyBitmap *bitmap = bdrv_find_dirty_bitmap(di->bs, PBS_BITMAP_NAME);
|
|
||||||
@@ -941,6 +966,8 @@ UuidInfo *qmp_backup(
|
|
||||||
bool has_backup_id, const char *backup_id,
|
|
||||||
bool has_backup_time, int64_t backup_time,
|
|
||||||
bool has_use_dirty_bitmap, bool use_dirty_bitmap,
|
|
||||||
+ bool has_compress, bool compress,
|
|
||||||
+ bool has_encrypt, bool encrypt,
|
|
||||||
bool has_format, BackupFormat format,
|
|
||||||
bool has_config_file, const char *config_file,
|
|
||||||
bool has_firewall_file, const char *firewall_file,
|
|
||||||
@@ -951,6 +978,8 @@ UuidInfo *qmp_backup(
|
|
||||||
.backup_file = backup_file,
|
|
||||||
.has_password = has_password,
|
|
||||||
.password = password,
|
|
||||||
+ .has_keyfile = has_keyfile,
|
|
||||||
+ .keyfile = keyfile,
|
|
||||||
.has_key_password = has_key_password,
|
|
||||||
.key_password = key_password,
|
|
||||||
.has_fingerprint = has_fingerprint,
|
|
||||||
@@ -961,6 +990,10 @@ UuidInfo *qmp_backup(
|
|
||||||
.backup_time = backup_time,
|
|
||||||
.has_use_dirty_bitmap = has_use_dirty_bitmap,
|
|
||||||
.use_dirty_bitmap = use_dirty_bitmap,
|
|
||||||
+ .has_compress = has_compress,
|
|
||||||
+ .compress = compress,
|
|
||||||
+ .has_encrypt = has_encrypt,
|
|
||||||
+ .encrypt = encrypt,
|
|
||||||
.has_format = has_format,
|
|
||||||
.format = format,
|
|
||||||
.has_config_file = has_config_file,
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index a138ad08d4..a75f1b4687 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -777,6 +777,10 @@
|
|
||||||
#
|
|
||||||
# @use-dirty-bitmap: use dirty bitmap to detect incremental changes since last job (optional for format 'pbs')
|
|
||||||
#
|
|
||||||
+# @compress: use compression (optional for format 'pbs', defaults to true)
|
|
||||||
+#
|
|
||||||
+# @encrypt: use encryption ((optional for format 'pbs', defaults to true if there is a keyfile)
|
|
||||||
+#
|
|
||||||
# Returns: the uuid of the backup job
|
|
||||||
#
|
|
||||||
##
|
|
||||||
@@ -788,6 +792,8 @@
|
|
||||||
'*backup-id': 'str',
|
|
||||||
'*backup-time': 'int',
|
|
||||||
'*use-dirty-bitmap': 'bool',
|
|
||||||
+ '*compress': 'bool',
|
|
||||||
+ '*encrypt': 'bool',
|
|
||||||
'*format': 'BackupFormat',
|
|
||||||
'*config-file': 'str',
|
|
||||||
'*firewall-file': 'str',
|
|
|
@ -5,17 +5,19 @@ Subject: [PATCH] PVE-Backup: pbs-restore - new command to restore from proxmox
|
||||||
backup server
|
backup server
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[WB: add namespace support]
|
||||||
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
---
|
---
|
||||||
meson.build | 4 +
|
meson.build | 4 +
|
||||||
pbs-restore.c | 224 ++++++++++++++++++++++++++++++++++++++++++++++++++
|
pbs-restore.c | 236 ++++++++++++++++++++++++++++++++++++++++++++++++++
|
||||||
2 files changed, 228 insertions(+)
|
2 files changed, 240 insertions(+)
|
||||||
create mode 100644 pbs-restore.c
|
create mode 100644 pbs-restore.c
|
||||||
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index 7d7e474313..dd1c5bdb4e 100644
|
index d16b97cf3c..6de51c34cb 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -2749,6 +2749,10 @@ if have_tools
|
@@ -4029,6 +4029,10 @@ if have_tools
|
||||||
vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
||||||
dependencies: [authz, block, crypto, io, qom], install: true)
|
dependencies: [authz, block, crypto, io, qom], install: true)
|
||||||
|
|
||||||
|
@ -24,14 +26,14 @@ index 7d7e474313..dd1c5bdb4e 100644
|
||||||
+ libproxmox_backup_qemu], install: true)
|
+ libproxmox_backup_qemu], install: true)
|
||||||
+
|
+
|
||||||
subdir('storage-daemon')
|
subdir('storage-daemon')
|
||||||
subdir('contrib/rdmacm-mux')
|
|
||||||
subdir('contrib/elf2dmp')
|
foreach exe: [ 'qemu-img', 'qemu-io', 'qemu-nbd', 'qemu-storage-daemon']
|
||||||
diff --git a/pbs-restore.c b/pbs-restore.c
|
diff --git a/pbs-restore.c b/pbs-restore.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..4d3f925a1b
|
index 0000000000..f03d9bab8d
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/pbs-restore.c
|
+++ b/pbs-restore.c
|
||||||
@@ -0,0 +1,224 @@
|
@@ -0,0 +1,236 @@
|
||||||
+/*
|
+/*
|
||||||
+ * Qemu image restore helper for Proxmox Backup
|
+ * Qemu image restore helper for Proxmox Backup
|
||||||
+ *
|
+ *
|
||||||
|
@ -50,7 +52,6 @@ index 0000000000..4d3f925a1b
|
||||||
+#include <getopt.h>
|
+#include <getopt.h>
|
||||||
+#include <string.h>
|
+#include <string.h>
|
||||||
+
|
+
|
||||||
+#include "qemu-common.h"
|
|
||||||
+#include "qemu/module.h"
|
+#include "qemu/module.h"
|
||||||
+#include "qemu/error-report.h"
|
+#include "qemu/error-report.h"
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
|
@ -64,7 +65,7 @@ index 0000000000..4d3f925a1b
|
||||||
+static void help(void)
|
+static void help(void)
|
||||||
+{
|
+{
|
||||||
+ const char *help_msg =
|
+ const char *help_msg =
|
||||||
+ "usage: pbs-restore [--repository <repo>] snapshot archive-name target [command options]\n"
|
+ "usage: pbs-restore [--repository <repo>] [--ns namespace] snapshot archive-name target [command options]\n"
|
||||||
+ ;
|
+ ;
|
||||||
+
|
+
|
||||||
+ printf("%s", help_msg);
|
+ printf("%s", help_msg);
|
||||||
|
@ -96,7 +97,7 @@ index 0000000000..4d3f925a1b
|
||||||
+ }
|
+ }
|
||||||
+ res = blk_pwrite_zeroes(callback_data->target, offset, data_len, 0);
|
+ res = blk_pwrite_zeroes(callback_data->target, offset, data_len, 0);
|
||||||
+ } else {
|
+ } else {
|
||||||
+ res = blk_pwrite(callback_data->target, offset, data, data_len, 0);
|
+ res = blk_pwrite(callback_data->target, offset, data_len, data, 0);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (res < 0) {
|
+ if (res < 0) {
|
||||||
|
@ -112,6 +113,7 @@ index 0000000000..4d3f925a1b
|
||||||
+ Error *main_loop_err = NULL;
|
+ Error *main_loop_err = NULL;
|
||||||
+ const char *format = "raw";
|
+ const char *format = "raw";
|
||||||
+ const char *repository = NULL;
|
+ const char *repository = NULL;
|
||||||
|
+ const char *backup_ns = NULL;
|
||||||
+ const char *keyfile = NULL;
|
+ const char *keyfile = NULL;
|
||||||
+ int verbose = false;
|
+ int verbose = false;
|
||||||
+ bool skip_zero = false;
|
+ bool skip_zero = false;
|
||||||
|
@ -125,6 +127,7 @@ index 0000000000..4d3f925a1b
|
||||||
+ {"verbose", no_argument, 0, 'v'},
|
+ {"verbose", no_argument, 0, 'v'},
|
||||||
+ {"format", required_argument, 0, 'f'},
|
+ {"format", required_argument, 0, 'f'},
|
||||||
+ {"repository", required_argument, 0, 'r'},
|
+ {"repository", required_argument, 0, 'r'},
|
||||||
|
+ {"ns", required_argument, 0, 'n'},
|
||||||
+ {"keyfile", required_argument, 0, 'k'},
|
+ {"keyfile", required_argument, 0, 'k'},
|
||||||
+ {0, 0, 0, 0}
|
+ {0, 0, 0, 0}
|
||||||
+ };
|
+ };
|
||||||
|
@ -145,6 +148,9 @@ index 0000000000..4d3f925a1b
|
||||||
+ case 'r':
|
+ case 'r':
|
||||||
+ repository = g_strdup(argv[optind - 1]);
|
+ repository = g_strdup(argv[optind - 1]);
|
||||||
+ break;
|
+ break;
|
||||||
|
+ case 'n':
|
||||||
|
+ backup_ns = g_strdup(argv[optind - 1]);
|
||||||
|
+ break;
|
||||||
+ case 'k':
|
+ case 'k':
|
||||||
+ keyfile = g_strdup(argv[optind - 1]);
|
+ keyfile = g_strdup(argv[optind - 1]);
|
||||||
+ break;
|
+ break;
|
||||||
|
@ -195,8 +201,16 @@ index 0000000000..4d3f925a1b
|
||||||
+ fprintf(stderr, "connecting to repository '%s'\n", repository);
|
+ fprintf(stderr, "connecting to repository '%s'\n", repository);
|
||||||
+ }
|
+ }
|
||||||
+ char *pbs_error = NULL;
|
+ char *pbs_error = NULL;
|
||||||
+ ProxmoxRestoreHandle *conn = proxmox_restore_new(
|
+ ProxmoxRestoreHandle *conn = proxmox_restore_new_ns(
|
||||||
+ repository, snapshot, password, keyfile, key_password, fingerprint, &pbs_error);
|
+ repository,
|
||||||
|
+ snapshot,
|
||||||
|
+ backup_ns,
|
||||||
|
+ password,
|
||||||
|
+ keyfile,
|
||||||
|
+ key_password,
|
||||||
|
+ fingerprint,
|
||||||
|
+ &pbs_error
|
||||||
|
+ );
|
||||||
+ if (conn == NULL) {
|
+ if (conn == NULL) {
|
||||||
+ fprintf(stderr, "restore failed: %s\n", pbs_error);
|
+ fprintf(stderr, "restore failed: %s\n", pbs_error);
|
||||||
+ return -1;
|
+ return -1;
|
|
@ -7,35 +7,40 @@ Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
[error cleanups, file_open implementation]
|
[error cleanups, file_open implementation]
|
||||||
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[WB: add namespace support]
|
||||||
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
||||||
|
[FE: adapt to changed function signatures
|
||||||
|
make pbs_co_preadv return values consistent with QEMU
|
||||||
|
getlength is now a coroutine function]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/meson.build | 3 +
|
block/meson.build | 2 +
|
||||||
block/pbs.c | 271 +++++++++++++++++++++++++++++++++++++++++++
|
block/pbs.c | 313 +++++++++++++++++++++++++++++++++++++++++++
|
||||||
configure | 9 ++
|
meson.build | 2 +-
|
||||||
meson.build | 1 +
|
qapi/block-core.json | 29 ++++
|
||||||
qapi/block-core.json | 13 +++
|
qapi/pragma.json | 1 +
|
||||||
5 files changed, 297 insertions(+)
|
5 files changed, 346 insertions(+), 1 deletion(-)
|
||||||
create mode 100644 block/pbs.c
|
create mode 100644 block/pbs.c
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 9e433daf2e..e3ed5ac97c 100644
|
index 6bba803f94..1945e04eeb 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -51,6 +51,9 @@ block_ss.add(files(
|
@@ -49,6 +49,8 @@ block_ss.add(files(
|
||||||
'../pve-backup.c',
|
'../pve-backup.c',
|
||||||
), libproxmox_backup_qemu)
|
), libproxmox_backup_qemu)
|
||||||
|
|
||||||
+block_ss.add(when: 'CONFIG_PBS_BDRV', if_true: files('pbs.c'))
|
+block_ss.add(files('pbs.c'), libproxmox_backup_qemu)
|
||||||
+block_ss.add(when: 'CONFIG_PBS_BDRV', if_true: libproxmox_backup_qemu)
|
|
||||||
+
|
+
|
||||||
|
|
||||||
softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
system_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
||||||
|
system_ss.add(files('block-ram-registrar.c'))
|
||||||
diff --git a/block/pbs.c b/block/pbs.c
|
diff --git a/block/pbs.c b/block/pbs.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..78dad0dcc4
|
index 0000000000..aee66c2e93
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/pbs.c
|
+++ b/block/pbs.c
|
||||||
@@ -0,0 +1,271 @@
|
@@ -0,0 +1,313 @@
|
||||||
+/*
|
+/*
|
||||||
+ * Proxmox Backup Server read-only block driver
|
+ * Proxmox Backup Server read-only block driver
|
||||||
+ */
|
+ */
|
||||||
|
@ -48,10 +53,12 @@ index 0000000000..78dad0dcc4
|
||||||
+#include "qemu/option.h"
|
+#include "qemu/option.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
+#include "block/block_int.h"
|
+#include "block/block_int.h"
|
||||||
|
+#include "block/block-io.h"
|
||||||
+
|
+
|
||||||
+#include <proxmox-backup-qemu.h>
|
+#include <proxmox-backup-qemu.h>
|
||||||
+
|
+
|
||||||
+#define PBS_OPT_REPOSITORY "repository"
|
+#define PBS_OPT_REPOSITORY "repository"
|
||||||
|
+#define PBS_OPT_NAMESPACE "namespace"
|
||||||
+#define PBS_OPT_SNAPSHOT "snapshot"
|
+#define PBS_OPT_SNAPSHOT "snapshot"
|
||||||
+#define PBS_OPT_ARCHIVE "archive"
|
+#define PBS_OPT_ARCHIVE "archive"
|
||||||
+#define PBS_OPT_KEYFILE "keyfile"
|
+#define PBS_OPT_KEYFILE "keyfile"
|
||||||
|
@ -61,10 +68,11 @@ index 0000000000..78dad0dcc4
|
||||||
+
|
+
|
||||||
+typedef struct {
|
+typedef struct {
|
||||||
+ ProxmoxRestoreHandle *conn;
|
+ ProxmoxRestoreHandle *conn;
|
||||||
+ char aid;
|
+ uint8_t aid;
|
||||||
+ int64_t length;
|
+ int64_t length;
|
||||||
+
|
+
|
||||||
+ char *repository;
|
+ char *repository;
|
||||||
|
+ char *namespace;
|
||||||
+ char *snapshot;
|
+ char *snapshot;
|
||||||
+ char *archive;
|
+ char *archive;
|
||||||
+} BDRVPBSState;
|
+} BDRVPBSState;
|
||||||
|
@ -79,6 +87,11 @@ index 0000000000..78dad0dcc4
|
||||||
+ .help = "The server address and repository to connect to.",
|
+ .help = "The server address and repository to connect to.",
|
||||||
+ },
|
+ },
|
||||||
+ {
|
+ {
|
||||||
|
+ .name = PBS_OPT_NAMESPACE,
|
||||||
|
+ .type = QEMU_OPT_STRING,
|
||||||
|
+ .help = "Optional: The snapshot's namespace.",
|
||||||
|
+ },
|
||||||
|
+ {
|
||||||
+ .name = PBS_OPT_SNAPSHOT,
|
+ .name = PBS_OPT_SNAPSHOT,
|
||||||
+ .type = QEMU_OPT_STRING,
|
+ .type = QEMU_OPT_STRING,
|
||||||
+ .help = "The snapshot to read.",
|
+ .help = "The snapshot to read.",
|
||||||
|
@ -114,7 +127,7 @@ index 0000000000..78dad0dcc4
|
||||||
+
|
+
|
||||||
+
|
+
|
||||||
+// filename format:
|
+// filename format:
|
||||||
+// pbs:repository=<repo>,snapshot=<snap>,password=<pw>,key_password=<kpw>,fingerprint=<fp>,archive=<archive>
|
+// pbs:repository=<repo>,namespace=<ns>,snapshot=<snap>,password=<pw>,key_password=<kpw>,fingerprint=<fp>,archive=<archive>
|
||||||
+static void pbs_parse_filename(const char *filename, QDict *options,
|
+static void pbs_parse_filename(const char *filename, QDict *options,
|
||||||
+ Error **errp)
|
+ Error **errp)
|
||||||
+{
|
+{
|
||||||
|
@ -150,6 +163,7 @@ index 0000000000..78dad0dcc4
|
||||||
+ s->archive = g_strdup(qemu_opt_get(opts, PBS_OPT_ARCHIVE));
|
+ s->archive = g_strdup(qemu_opt_get(opts, PBS_OPT_ARCHIVE));
|
||||||
+ const char *keyfile = qemu_opt_get(opts, PBS_OPT_KEYFILE);
|
+ const char *keyfile = qemu_opt_get(opts, PBS_OPT_KEYFILE);
|
||||||
+ const char *password = qemu_opt_get(opts, PBS_OPT_PASSWORD);
|
+ const char *password = qemu_opt_get(opts, PBS_OPT_PASSWORD);
|
||||||
|
+ const char *namespace = qemu_opt_get(opts, PBS_OPT_NAMESPACE);
|
||||||
+ const char *fingerprint = qemu_opt_get(opts, PBS_OPT_FINGERPRINT);
|
+ const char *fingerprint = qemu_opt_get(opts, PBS_OPT_FINGERPRINT);
|
||||||
+ const char *key_password = qemu_opt_get(opts, PBS_OPT_ENCRYPTION_PASSWORD);
|
+ const char *key_password = qemu_opt_get(opts, PBS_OPT_ENCRYPTION_PASSWORD);
|
||||||
+
|
+
|
||||||
|
@ -162,9 +176,12 @@ index 0000000000..78dad0dcc4
|
||||||
+ if (!key_password) {
|
+ if (!key_password) {
|
||||||
+ key_password = getenv("PBS_ENCRYPTION_PASSWORD");
|
+ key_password = getenv("PBS_ENCRYPTION_PASSWORD");
|
||||||
+ }
|
+ }
|
||||||
|
+ if (namespace) {
|
||||||
|
+ s->namespace = g_strdup(namespace);
|
||||||
|
+ }
|
||||||
+
|
+
|
||||||
+ /* connect to PBS server in read mode */
|
+ /* connect to PBS server in read mode */
|
||||||
+ s->conn = proxmox_restore_new(s->repository, s->snapshot, password,
|
+ s->conn = proxmox_restore_new_ns(s->repository, s->snapshot, s->namespace, password,
|
||||||
+ keyfile, key_password, fingerprint, &pbs_error);
|
+ keyfile, key_password, fingerprint, &pbs_error);
|
||||||
+
|
+
|
||||||
+ /* invalidates qemu_opt_get char pointers from above */
|
+ /* invalidates qemu_opt_get char pointers from above */
|
||||||
|
@ -184,12 +201,18 @@ index 0000000000..78dad0dcc4
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ /* acquire handle and length */
|
+ /* acquire handle and length */
|
||||||
+ s->aid = proxmox_restore_open_image(s->conn, s->archive, &pbs_error);
|
+ ret = proxmox_restore_open_image(s->conn, s->archive, &pbs_error);
|
||||||
+ if (s->aid < 0) {
|
+ if (ret < 0) {
|
||||||
+ if (pbs_error && errp) error_setg(errp, "PBS open_image failed: %s", pbs_error);
|
+ if (pbs_error && errp) error_setg(errp, "PBS open_image failed: %s", pbs_error);
|
||||||
+ if (pbs_error) proxmox_backup_free_error(pbs_error);
|
+ if (pbs_error) proxmox_backup_free_error(pbs_error);
|
||||||
+ return -ENODEV;
|
+ return -ENODEV;
|
||||||
+ }
|
+ }
|
||||||
|
+ if (ret > UINT8_MAX) {
|
||||||
|
+ error_setg(errp, "PBS open_image returned an ID larger than %u", UINT8_MAX);
|
||||||
|
+ return -ENODEV;
|
||||||
|
+ }
|
||||||
|
+ s->aid = ret;
|
||||||
|
+
|
||||||
+ s->length = proxmox_restore_get_image_length(s->conn, s->aid, &pbs_error);
|
+ s->length = proxmox_restore_get_image_length(s->conn, s->aid, &pbs_error);
|
||||||
+ if (s->length < 0) {
|
+ if (s->length < 0) {
|
||||||
+ if (pbs_error && errp) error_setg(errp, "PBS get_image_length failed: %s", pbs_error);
|
+ if (pbs_error && errp) error_setg(errp, "PBS get_image_length failed: %s", pbs_error);
|
||||||
|
@ -209,12 +232,14 @@ index 0000000000..78dad0dcc4
|
||||||
+static void pbs_close(BlockDriverState *bs) {
|
+static void pbs_close(BlockDriverState *bs) {
|
||||||
+ BDRVPBSState *s = bs->opaque;
|
+ BDRVPBSState *s = bs->opaque;
|
||||||
+ g_free(s->repository);
|
+ g_free(s->repository);
|
||||||
|
+ g_free(s->namespace);
|
||||||
+ g_free(s->snapshot);
|
+ g_free(s->snapshot);
|
||||||
+ g_free(s->archive);
|
+ g_free(s->archive);
|
||||||
+ proxmox_restore_disconnect(s->conn);
|
+ proxmox_restore_disconnect(s->conn);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int64_t pbs_getlength(BlockDriverState *bs)
|
+static coroutine_fn int64_t GRAPH_RDLOCK
|
||||||
|
+pbs_co_getlength(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ BDRVPBSState *s = bs->opaque;
|
+ BDRVPBSState *s = bs->opaque;
|
||||||
+ return s->length;
|
+ return s->length;
|
||||||
|
@ -231,21 +256,35 @@ index 0000000000..78dad0dcc4
|
||||||
+ aio_co_schedule(rcb->ctx, rcb->co);
|
+ aio_co_schedule(rcb->ctx, rcb->co);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static coroutine_fn int pbs_co_preadv(BlockDriverState *bs,
|
+static coroutine_fn int GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes,
|
+pbs_co_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
+ QEMUIOVector *qiov, int flags)
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ BDRVPBSState *s = bs->opaque;
|
+ BDRVPBSState *s = bs->opaque;
|
||||||
+ int ret;
|
+ int ret;
|
||||||
+ char *pbs_error = NULL;
|
+ char *pbs_error = NULL;
|
||||||
+ uint8_t *buf = malloc(bytes);
|
+ uint8_t *buf;
|
||||||
|
+ bool inline_buf = true;
|
||||||
|
+
|
||||||
|
+ /* for single-buffer IO vectors we can fast-path the write directly to it */
|
||||||
|
+ if (qiov->niov == 1 && qiov->iov->iov_len >= bytes) {
|
||||||
|
+ buf = qiov->iov->iov_base;
|
||||||
|
+ } else {
|
||||||
|
+ inline_buf = false;
|
||||||
|
+ buf = g_malloc(bytes);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (offset < 0 || bytes < 0) {
|
||||||
|
+ fprintf(stderr, "unexpected negative 'offset' or 'bytes' value!\n");
|
||||||
|
+ return -EIO;
|
||||||
|
+ }
|
||||||
+
|
+
|
||||||
+ ReadCallbackData rcb = {
|
+ ReadCallbackData rcb = {
|
||||||
+ .co = qemu_coroutine_self(),
|
+ .co = qemu_coroutine_self(),
|
||||||
+ .ctx = bdrv_get_aio_context(bs),
|
+ .ctx = bdrv_get_aio_context(bs),
|
||||||
+ };
|
+ };
|
||||||
+
|
+
|
||||||
+ proxmox_restore_read_image_at_async(s->conn, s->aid, buf, offset, bytes,
|
+ proxmox_restore_read_image_at_async(s->conn, s->aid, buf, (uint64_t)offset, (uint64_t)bytes,
|
||||||
+ read_callback, (void *) &rcb, &ret, &pbs_error);
|
+ read_callback, (void *) &rcb, &ret, &pbs_error);
|
||||||
+
|
+
|
||||||
+ qemu_coroutine_yield();
|
+ qemu_coroutine_yield();
|
||||||
|
@ -256,26 +295,34 @@ index 0000000000..78dad0dcc4
|
||||||
+ return -EIO;
|
+ return -EIO;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ qemu_iovec_from_buf(qiov, 0, buf, bytes);
|
+ if (!inline_buf) {
|
||||||
+ free(buf);
|
+ qemu_iovec_from_buf(qiov, 0, buf, bytes);
|
||||||
|
+ g_free(buf);
|
||||||
|
+ }
|
||||||
+
|
+
|
||||||
+ return ret;
|
+ return 0;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static coroutine_fn int pbs_co_pwritev(BlockDriverState *bs,
|
+static coroutine_fn int GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes,
|
+pbs_co_pwritev(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
+ QEMUIOVector *qiov, int flags)
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ fprintf(stderr, "pbs-bdrv: cannot write to backup file, make sure "
|
+ fprintf(stderr, "pbs-bdrv: cannot write to backup file, make sure "
|
||||||
+ "any attached disk devices are set to read-only!\n");
|
+ "any attached disk devices are set to read-only!\n");
|
||||||
+ return -EPERM;
|
+ return -EPERM;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void pbs_refresh_filename(BlockDriverState *bs)
|
+static void GRAPH_RDLOCK
|
||||||
|
+pbs_refresh_filename(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ BDRVPBSState *s = bs->opaque;
|
+ BDRVPBSState *s = bs->opaque;
|
||||||
+ snprintf(bs->exact_filename, sizeof(bs->exact_filename), "%s/%s(%s)",
|
+ if (s->namespace) {
|
||||||
+ s->repository, s->snapshot, s->archive);
|
+ snprintf(bs->exact_filename, sizeof(bs->exact_filename), "%s/%s:%s(%s)",
|
||||||
|
+ s->repository, s->namespace, s->snapshot, s->archive);
|
||||||
|
+ } else {
|
||||||
|
+ snprintf(bs->exact_filename, sizeof(bs->exact_filename), "%s/%s(%s)",
|
||||||
|
+ s->repository, s->snapshot, s->archive);
|
||||||
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static const char *const pbs_strong_runtime_opts[] = {
|
+static const char *const pbs_strong_runtime_opts[] = {
|
||||||
|
@ -292,7 +339,7 @@ index 0000000000..78dad0dcc4
|
||||||
+ .bdrv_file_open = pbs_file_open,
|
+ .bdrv_file_open = pbs_file_open,
|
||||||
+ .bdrv_open = pbs_open,
|
+ .bdrv_open = pbs_open,
|
||||||
+ .bdrv_close = pbs_close,
|
+ .bdrv_close = pbs_close,
|
||||||
+ .bdrv_getlength = pbs_getlength,
|
+ .bdrv_co_getlength = pbs_co_getlength,
|
||||||
+
|
+
|
||||||
+ .bdrv_co_preadv = pbs_co_preadv,
|
+ .bdrv_co_preadv = pbs_co_preadv,
|
||||||
+ .bdrv_co_pwritev = pbs_co_pwritev,
|
+ .bdrv_co_pwritev = pbs_co_pwritev,
|
||||||
|
@ -307,72 +354,32 @@ index 0000000000..78dad0dcc4
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+block_init(bdrv_pbs_init);
|
+block_init(bdrv_pbs_init);
|
||||||
diff --git a/configure b/configure
|
|
||||||
index 6e308ed77f..869e97c72f 100755
|
|
||||||
--- a/configure
|
|
||||||
+++ b/configure
|
|
||||||
@@ -428,6 +428,7 @@ vdi=${default_feature:-yes}
|
|
||||||
vvfat=${default_feature:-yes}
|
|
||||||
qed=${default_feature:-yes}
|
|
||||||
parallels=${default_feature:-yes}
|
|
||||||
+pbs_bdrv="yes"
|
|
||||||
libxml2="auto"
|
|
||||||
debug_mutex="no"
|
|
||||||
libpmem="auto"
|
|
||||||
@@ -1486,6 +1487,10 @@ for opt do
|
|
||||||
;;
|
|
||||||
--enable-parallels) parallels="yes"
|
|
||||||
;;
|
|
||||||
+ --disable-pbs-bdrv) pbs_bdrv="no"
|
|
||||||
+ ;;
|
|
||||||
+ --enable-pbs-bdrv) pbs_bdrv="yes"
|
|
||||||
+ ;;
|
|
||||||
--disable-vhost-user) vhost_user="no"
|
|
||||||
;;
|
|
||||||
--enable-vhost-user) vhost_user="yes"
|
|
||||||
@@ -1956,6 +1961,7 @@ disabled with --disable-FEATURE, default is enabled if available
|
|
||||||
vvfat vvfat image format support
|
|
||||||
qed qed image format support
|
|
||||||
parallels parallels image format support
|
|
||||||
+ pbs-bdrv Proxmox backup server read-only block driver support
|
|
||||||
crypto-afalg Linux AF_ALG crypto backend driver
|
|
||||||
capstone capstone disassembler support
|
|
||||||
debug-mutex mutex debugging support
|
|
||||||
@@ -4624,6 +4630,9 @@ fi
|
|
||||||
if test "$linux_aio" = "yes" ; then
|
|
||||||
echo "CONFIG_LINUX_AIO=y" >> $config_host_mak
|
|
||||||
fi
|
|
||||||
+if test "$pbs_bdrv" = "yes" ; then
|
|
||||||
+ echo "CONFIG_PBS_BDRV=y" >> $config_host_mak
|
|
||||||
+fi
|
|
||||||
if test "$vhost_scsi" = "yes" ; then
|
|
||||||
echo "CONFIG_VHOST_SCSI=y" >> $config_host_mak
|
|
||||||
fi
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index dd1c5bdb4e..45c1f2de73 100644
|
index 6de51c34cb..3bc039f60f 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -3111,6 +3111,7 @@ summary_info += {'lzfse support': liblzfse.found()}
|
@@ -4477,7 +4477,7 @@ summary_info += {'bzip2 support': libbzip2}
|
||||||
summary_info += {'zstd support': zstd.found()}
|
summary_info += {'lzfse support': liblzfse}
|
||||||
summary_info += {'NUMA host support': config_host.has_key('CONFIG_NUMA')}
|
summary_info += {'zstd support': zstd}
|
||||||
summary_info += {'libxml2': libxml2.found()}
|
summary_info += {'NUMA host support': numa}
|
||||||
|
-summary_info += {'capstone': capstone}
|
||||||
+summary_info += {'PBS bdrv support': config_host.has_key('CONFIG_PBS_BDRV')}
|
+summary_info += {'PBS bdrv support': config_host.has_key('CONFIG_PBS_BDRV')}
|
||||||
summary_info += {'capstone': capstone_opt == 'disabled' ? false : capstone_opt}
|
summary_info += {'libpmem support': libpmem}
|
||||||
summary_info += {'libpmem support': libpmem.found()}
|
summary_info += {'libdaxctl support': libdaxctl}
|
||||||
summary_info += {'libdaxctl support': libdaxctl.found()}
|
summary_info += {'libudev': libudev}
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index a75f1b4687..e4d0c923a4 100644
|
index d05fffce1d..e7cf3d94f3 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -2982,6 +2982,7 @@
|
@@ -3457,6 +3457,7 @@
|
||||||
'luks', 'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 'parallels',
|
'parallels', 'preallocate', 'qcow', 'qcow2', 'qed', 'quorum',
|
||||||
'preallocate', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
|
'raw', 'rbd',
|
||||||
{ 'name': 'replication', 'if': 'defined(CONFIG_REPLICATION)' },
|
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
||||||
+ 'pbs',
|
+ 'pbs',
|
||||||
'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
|
'ssh', 'throttle', 'vdi', 'vhdx',
|
||||||
|
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
||||||
##
|
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
||||||
@@ -3045,6 +3046,17 @@
|
@@ -3543,6 +3544,33 @@
|
||||||
{ 'struct': 'BlockdevOptionsNull',
|
{ 'struct': 'BlockdevOptionsNull',
|
||||||
'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
|
'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
|
||||||
|
|
||||||
|
@ -381,20 +388,48 @@ index a75f1b4687..e4d0c923a4 100644
|
||||||
+#
|
+#
|
||||||
+# Driver specific block device options for the PBS backend.
|
+# Driver specific block device options for the PBS backend.
|
||||||
+#
|
+#
|
||||||
|
+# @repository: Proxmox Backup Server repository.
|
||||||
|
+#
|
||||||
|
+# @snapshot: backup snapshots ID.
|
||||||
|
+#
|
||||||
|
+# @archive: archive name.
|
||||||
|
+#
|
||||||
|
+# @keyfile: keyfile to use for encryption.
|
||||||
|
+#
|
||||||
|
+# @password: password to use for connection.
|
||||||
|
+#
|
||||||
|
+# @fingerprint: backup server fingerprint.
|
||||||
|
+#
|
||||||
|
+# @key_password: password to unlock key.
|
||||||
|
+#
|
||||||
|
+# @namespace: namespace where backup snapshot lives.
|
||||||
|
+#
|
||||||
+##
|
+##
|
||||||
+{ 'struct': 'BlockdevOptionsPbs',
|
+{ 'struct': 'BlockdevOptionsPbs',
|
||||||
+ 'data': { 'repository': 'str', 'snapshot': 'str', 'archive': 'str',
|
+ 'data': { 'repository': 'str', 'snapshot': 'str', 'archive': 'str',
|
||||||
+ '*keyfile': 'str', '*password': 'str', '*fingerprint': 'str',
|
+ '*keyfile': 'str', '*password': 'str', '*fingerprint': 'str',
|
||||||
+ '*key_password': 'str' } }
|
+ '*key_password': 'str', '*namespace': 'str' } }
|
||||||
+
|
+
|
||||||
##
|
##
|
||||||
# @BlockdevOptionsNVMe:
|
# @BlockdevOptionsNVMe:
|
||||||
#
|
#
|
||||||
@@ -4263,6 +4275,7 @@
|
@@ -4977,6 +5005,7 @@
|
||||||
'nfs': 'BlockdevOptionsNfs',
|
'nfs': 'BlockdevOptionsNfs',
|
||||||
'null-aio': 'BlockdevOptionsNull',
|
'null-aio': 'BlockdevOptionsNull',
|
||||||
'null-co': 'BlockdevOptionsNull',
|
'null-co': 'BlockdevOptionsNull',
|
||||||
+ 'pbs': 'BlockdevOptionsPbs',
|
+ 'pbs': 'BlockdevOptionsPbs',
|
||||||
'nvme': 'BlockdevOptionsNVMe',
|
'nvme': 'BlockdevOptionsNVMe',
|
||||||
'parallels': 'BlockdevOptionsGenericFormat',
|
'nvme-io_uring': { 'type': 'BlockdevOptionsNvmeIoUring',
|
||||||
'preallocate':'BlockdevOptionsPreallocate',
|
'if': 'CONFIG_BLKIO' },
|
||||||
|
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
||||||
|
index be8fa304c5..7ff46bd128 100644
|
||||||
|
--- a/qapi/pragma.json
|
||||||
|
+++ b/qapi/pragma.json
|
||||||
|
@@ -100,6 +100,7 @@
|
||||||
|
'BlockInfo', # query-block
|
||||||
|
'BlockdevAioOptions', # blockdev-add, -blockdev
|
||||||
|
'BlockdevDriver', # blockdev-add, query-blockstats, ...
|
||||||
|
+ 'BlockdevOptionsPbs', # for PBS backwards compat
|
||||||
|
'BlockdevVmdkAdapterType', # blockdev-create (to match VMDK spec)
|
||||||
|
'BlockdevVmdkSubformat', # blockdev-create (to match VMDK spec)
|
||||||
|
'ColoCompareProperties', # object_add, -object
|
|
@ -1,74 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 8 Jul 2020 11:57:53 +0200
|
|
||||||
Subject: [PATCH] PVE: add query_proxmox_support QMP command
|
|
||||||
|
|
||||||
Generic interface for future use, currently used for PBS dirty-bitmap
|
|
||||||
backup support.
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
[PVE: query-proxmox-support: include library version]
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 9 +++++++++
|
|
||||||
qapi/block-core.json | 29 +++++++++++++++++++++++++++++
|
|
||||||
2 files changed, 38 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 7527885251..8cba8e97d3 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -1075,3 +1075,12 @@ BackupStatus *qmp_query_backup(Error **errp)
|
|
||||||
|
|
||||||
return info;
|
|
||||||
}
|
|
||||||
+
|
|
||||||
+ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
|
||||||
+{
|
|
||||||
+ ProxmoxSupportStatus *ret = g_malloc0(sizeof(*ret));
|
|
||||||
+ ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
|
||||||
+ ret->pbs_dirty_bitmap = true;
|
|
||||||
+ ret->pbs_dirty_bitmap_savevm = true;
|
|
||||||
+ return ret;
|
|
||||||
+}
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index e4d0c923a4..3eebe7ff71 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -822,6 +822,35 @@
|
|
||||||
##
|
|
||||||
{ 'command': 'backup-cancel' }
|
|
||||||
|
|
||||||
+##
|
|
||||||
+# @ProxmoxSupportStatus:
|
|
||||||
+#
|
|
||||||
+# Contains info about supported features added by Proxmox.
|
|
||||||
+#
|
|
||||||
+# @pbs-dirty-bitmap: True if dirty-bitmap-incremental backups to PBS are
|
|
||||||
+# supported.
|
|
||||||
+#
|
|
||||||
+# @pbs-dirty-bitmap-savevm: True if 'dirty-bitmaps' migration capability can
|
|
||||||
+# safely be set for savevm-async.
|
|
||||||
+#
|
|
||||||
+# @pbs-library-version: Running version of libproxmox-backup-qemu0 library.
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'struct': 'ProxmoxSupportStatus',
|
|
||||||
+ 'data': { 'pbs-dirty-bitmap': 'bool',
|
|
||||||
+ 'pbs-dirty-bitmap-savevm': 'bool',
|
|
||||||
+ 'pbs-library-version': 'str' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @query-proxmox-support:
|
|
||||||
+#
|
|
||||||
+# Returns information about supported features added by Proxmox.
|
|
||||||
+#
|
|
||||||
+# Returns: @ProxmoxSupportStatus
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'command': 'query-proxmox-support', 'returns': 'ProxmoxSupportStatus' }
|
|
||||||
+
|
|
||||||
##
|
|
||||||
# @BlockDeviceTimedStats:
|
|
||||||
#
|
|
|
@ -1,441 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 19 Aug 2020 17:02:00 +0200
|
|
||||||
Subject: [PATCH] PVE: add query-pbs-bitmap-info QMP call
|
|
||||||
|
|
||||||
Returns advanced information about dirty bitmaps used (or not used) for
|
|
||||||
the latest PBS backup.
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
monitor/hmp-cmds.c | 28 ++++++-----
|
|
||||||
pve-backup.c | 117 ++++++++++++++++++++++++++++++++-----------
|
|
||||||
qapi/block-core.json | 56 +++++++++++++++++++++
|
|
||||||
3 files changed, 159 insertions(+), 42 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
|
||||||
index b2b5f1298b..7a449edafa 100644
|
|
||||||
--- a/monitor/hmp-cmds.c
|
|
||||||
+++ b/monitor/hmp-cmds.c
|
|
||||||
@@ -198,6 +198,7 @@ void hmp_info_mice(Monitor *mon, const QDict *qdict)
|
|
||||||
void hmp_info_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
BackupStatus *info;
|
|
||||||
+ PBSBitmapInfoList *bitmap_info;
|
|
||||||
|
|
||||||
info = qmp_query_backup(NULL);
|
|
||||||
|
|
||||||
@@ -228,26 +229,29 @@ void hmp_info_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
// this should not happen normally
|
|
||||||
monitor_printf(mon, "Total size: %d\n", 0);
|
|
||||||
} else {
|
|
||||||
- bool incremental = false;
|
|
||||||
size_t total_or_dirty = info->total;
|
|
||||||
- if (info->has_transferred) {
|
|
||||||
- if (info->has_dirty && info->dirty) {
|
|
||||||
- if (info->dirty < info->total) {
|
|
||||||
- total_or_dirty = info->dirty;
|
|
||||||
- incremental = true;
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
+ bitmap_info = qmp_query_pbs_bitmap_info(NULL);
|
|
||||||
+
|
|
||||||
+ while (bitmap_info) {
|
|
||||||
+ monitor_printf(mon, "Drive %s:\n",
|
|
||||||
+ bitmap_info->value->drive);
|
|
||||||
+ monitor_printf(mon, " bitmap action: %s\n",
|
|
||||||
+ PBSBitmapAction_str(bitmap_info->value->action));
|
|
||||||
+ monitor_printf(mon, " size: %zd\n",
|
|
||||||
+ bitmap_info->value->size);
|
|
||||||
+ monitor_printf(mon, " dirty: %zd\n",
|
|
||||||
+ bitmap_info->value->dirty);
|
|
||||||
+ bitmap_info = bitmap_info->next;
|
|
||||||
}
|
|
||||||
|
|
||||||
- int per = (info->transferred * 100)/total_or_dirty;
|
|
||||||
-
|
|
||||||
- monitor_printf(mon, "Backup mode: %s\n", incremental ? "incremental" : "full");
|
|
||||||
+ qapi_free_PBSBitmapInfoList(bitmap_info);
|
|
||||||
|
|
||||||
int zero_per = (info->has_zero_bytes && info->zero_bytes) ?
|
|
||||||
(info->zero_bytes * 100)/info->total : 0;
|
|
||||||
monitor_printf(mon, "Total size: %zd\n", info->total);
|
|
||||||
+ int trans_per = (info->transferred * 100)/total_or_dirty;
|
|
||||||
monitor_printf(mon, "Transferred bytes: %zd (%d%%)\n",
|
|
||||||
- info->transferred, per);
|
|
||||||
+ info->transferred, trans_per);
|
|
||||||
monitor_printf(mon, "Zero bytes: %zd (%d%%)\n",
|
|
||||||
info->zero_bytes, zero_per);
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 8cba8e97d3..22420db26a 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -46,6 +46,7 @@ static struct PVEBackupState {
|
|
||||||
size_t transferred;
|
|
||||||
size_t reused;
|
|
||||||
size_t zero_bytes;
|
|
||||||
+ GList *bitmap_list;
|
|
||||||
} stat;
|
|
||||||
int64_t speed;
|
|
||||||
VmaWriter *vmaw;
|
|
||||||
@@ -672,7 +673,6 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
|
|
||||||
size_t total = 0;
|
|
||||||
- size_t dirty = 0;
|
|
||||||
|
|
||||||
l = di_list;
|
|
||||||
while (l) {
|
|
||||||
@@ -693,18 +693,33 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
|
|
||||||
uuid_generate(uuid);
|
|
||||||
|
|
||||||
+ qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+ backup_state.stat.reused = 0;
|
|
||||||
+
|
|
||||||
+ /* clear previous backup's bitmap_list */
|
|
||||||
+ if (backup_state.stat.bitmap_list) {
|
|
||||||
+ GList *bl = backup_state.stat.bitmap_list;
|
|
||||||
+ while (bl) {
|
|
||||||
+ g_free(((PBSBitmapInfo *)bl->data)->drive);
|
|
||||||
+ g_free(bl->data);
|
|
||||||
+ bl = g_list_next(bl);
|
|
||||||
+ }
|
|
||||||
+ g_list_free(backup_state.stat.bitmap_list);
|
|
||||||
+ backup_state.stat.bitmap_list = NULL;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
if (format == BACKUP_FORMAT_PBS) {
|
|
||||||
if (!task->has_password) {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'password'");
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
if (!task->has_backup_id) {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-id'");
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
if (!task->has_backup_time) {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-time'");
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
int dump_cb_block_size = PROXMOX_BACKUP_DEFAULT_CHUNK_SIZE; // Hardcoded (4M)
|
|
||||||
@@ -731,12 +746,12 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"proxmox_backup_new failed: %s", pbs_err);
|
|
||||||
proxmox_backup_free_error(pbs_err);
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
int connect_result = proxmox_backup_co_connect(pbs, task->errp);
|
|
||||||
if (connect_result < 0)
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
|
|
||||||
/* register all devices */
|
|
||||||
l = di_list;
|
|
||||||
@@ -747,6 +762,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
di->block_size = dump_cb_block_size;
|
|
||||||
|
|
||||||
const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
+ PBSBitmapAction action = PBS_BITMAP_ACTION_NOT_USED;
|
|
||||||
+ size_t dirty = di->size;
|
|
||||||
|
|
||||||
BdrvDirtyBitmap *bitmap = bdrv_find_dirty_bitmap(di->bs, PBS_BITMAP_NAME);
|
|
||||||
bool expect_only_dirty = false;
|
|
||||||
@@ -755,49 +772,59 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (bitmap == NULL) {
|
|
||||||
bitmap = bdrv_create_dirty_bitmap(di->bs, dump_cb_block_size, PBS_BITMAP_NAME, task->errp);
|
|
||||||
if (!bitmap) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
+ action = PBS_BITMAP_ACTION_NEW;
|
|
||||||
} else {
|
|
||||||
expect_only_dirty = proxmox_backup_check_incremental(pbs, devname, di->size) != 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (expect_only_dirty) {
|
|
||||||
- dirty += bdrv_get_dirty_count(bitmap);
|
|
||||||
+ /* track clean chunks as reused */
|
|
||||||
+ dirty = MIN(bdrv_get_dirty_count(bitmap), di->size);
|
|
||||||
+ backup_state.stat.reused += di->size - dirty;
|
|
||||||
+ action = PBS_BITMAP_ACTION_USED;
|
|
||||||
} else {
|
|
||||||
/* mark entire bitmap as dirty to make full backup */
|
|
||||||
bdrv_set_dirty_bitmap(bitmap, 0, di->size);
|
|
||||||
- dirty += di->size;
|
|
||||||
+ if (action != PBS_BITMAP_ACTION_NEW) {
|
|
||||||
+ action = PBS_BITMAP_ACTION_INVALID;
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
di->bitmap = bitmap;
|
|
||||||
} else {
|
|
||||||
- dirty += di->size;
|
|
||||||
-
|
|
||||||
/* after a full backup the old dirty bitmap is invalid anyway */
|
|
||||||
if (bitmap != NULL) {
|
|
||||||
bdrv_release_dirty_bitmap(bitmap);
|
|
||||||
+ action = PBS_BITMAP_ACTION_NOT_USED_REMOVED;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, expect_only_dirty, task->errp);
|
|
||||||
if (dev_id < 0) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!(di->target = bdrv_backup_dump_create(dump_cb_block_size, di->size, pvebackup_co_dump_pbs_cb, di, task->errp))) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
di->dev_id = dev_id;
|
|
||||||
+
|
|
||||||
+ PBSBitmapInfo *info = g_malloc(sizeof(*info));
|
|
||||||
+ info->drive = g_strdup(devname);
|
|
||||||
+ info->action = action;
|
|
||||||
+ info->size = di->size;
|
|
||||||
+ info->dirty = dirty;
|
|
||||||
+ backup_state.stat.bitmap_list = g_list_append(backup_state.stat.bitmap_list, info);
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_VMA) {
|
|
||||||
- dirty = total;
|
|
||||||
-
|
|
||||||
vmaw = vma_writer_create(task->backup_file, uuid, &local_err);
|
|
||||||
if (!vmaw) {
|
|
||||||
if (local_err) {
|
|
||||||
error_propagate(task->errp, local_err);
|
|
||||||
}
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* register all devices for vma writer */
|
|
||||||
@@ -807,7 +834,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
l = g_list_next(l);
|
|
||||||
|
|
||||||
if (!(di->target = bdrv_backup_dump_create(VMA_CLUSTER_SIZE, di->size, pvebackup_co_dump_vma_cb, di, task->errp))) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
@@ -815,16 +842,14 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (di->dev_id <= 0) {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"register_stream failed");
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_DIR) {
|
|
||||||
- dirty = total;
|
|
||||||
-
|
|
||||||
if (mkdir(task->backup_file, 0640) != 0) {
|
|
||||||
error_setg_errno(task->errp, errno, "can't create directory '%s'\n",
|
|
||||||
task->backup_file);
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
backup_dir = task->backup_file;
|
|
||||||
|
|
||||||
@@ -841,18 +866,18 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
di->size, flags, false, &local_err);
|
|
||||||
if (local_err) {
|
|
||||||
error_propagate(task->errp, local_err);
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
di->target = bdrv_open(di->targetfile, NULL, NULL, flags, &local_err);
|
|
||||||
if (!di->target) {
|
|
||||||
error_propagate(task->errp, local_err);
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "unknown backup format");
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
|
||||||
@@ -860,7 +885,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (task->has_config_file) {
|
|
||||||
if (pvebackup_co_add_config(task->config_file, config_name, format, backup_dir,
|
|
||||||
vmaw, pbs, task->errp) != 0) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -868,12 +893,11 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (task->has_firewall_file) {
|
|
||||||
if (pvebackup_co_add_config(task->firewall_file, firewall_name, format, backup_dir,
|
|
||||||
vmaw, pbs, task->errp) != 0) {
|
|
||||||
- goto err;
|
|
||||||
+ goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
/* initialize global backup_state now */
|
|
||||||
-
|
|
||||||
- qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+ /* note: 'reused' and 'bitmap_list' are initialized earlier */
|
|
||||||
|
|
||||||
if (backup_state.stat.error) {
|
|
||||||
error_free(backup_state.stat.error);
|
|
||||||
@@ -893,10 +917,9 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
char *uuid_str = g_strdup(backup_state.stat.uuid_str);
|
|
||||||
|
|
||||||
backup_state.stat.total = total;
|
|
||||||
- backup_state.stat.dirty = dirty;
|
|
||||||
+ backup_state.stat.dirty = total - backup_state.stat.reused;
|
|
||||||
backup_state.stat.transferred = 0;
|
|
||||||
backup_state.stat.zero_bytes = 0;
|
|
||||||
- backup_state.stat.reused = format == BACKUP_FORMAT_PBS && dirty >= total ? 0 : total - dirty;
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
@@ -913,6 +936,9 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
task->result = uuid_info;
|
|
||||||
return;
|
|
||||||
|
|
||||||
+err_mutex:
|
|
||||||
+ qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
+
|
|
||||||
err:
|
|
||||||
|
|
||||||
l = di_list;
|
|
||||||
@@ -1076,11 +1102,42 @@ BackupStatus *qmp_query_backup(Error **errp)
|
|
||||||
return info;
|
|
||||||
}
|
|
||||||
|
|
||||||
+PBSBitmapInfoList *qmp_query_pbs_bitmap_info(Error **errp)
|
|
||||||
+{
|
|
||||||
+ PBSBitmapInfoList *head = NULL, **p_next = &head;
|
|
||||||
+
|
|
||||||
+ qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+
|
|
||||||
+ GList *l = backup_state.stat.bitmap_list;
|
|
||||||
+ while (l) {
|
|
||||||
+ PBSBitmapInfo *info = (PBSBitmapInfo *)l->data;
|
|
||||||
+ l = g_list_next(l);
|
|
||||||
+
|
|
||||||
+ /* clone bitmap info to avoid auto free after QMP marshalling */
|
|
||||||
+ PBSBitmapInfo *info_ret = g_malloc0(sizeof(*info_ret));
|
|
||||||
+ info_ret->drive = g_strdup(info->drive);
|
|
||||||
+ info_ret->action = info->action;
|
|
||||||
+ info_ret->size = info->size;
|
|
||||||
+ info_ret->dirty = info->dirty;
|
|
||||||
+
|
|
||||||
+ PBSBitmapInfoList *info_list = g_malloc0(sizeof(*info_list));
|
|
||||||
+ info_list->value = info_ret;
|
|
||||||
+
|
|
||||||
+ *p_next = info_list;
|
|
||||||
+ p_next = &info_list->next;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
+
|
|
||||||
+ return head;
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
|
||||||
{
|
|
||||||
ProxmoxSupportStatus *ret = g_malloc0(sizeof(*ret));
|
|
||||||
ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
|
||||||
ret->pbs_dirty_bitmap = true;
|
|
||||||
ret->pbs_dirty_bitmap_savevm = true;
|
|
||||||
+ ret->query_bitmap_info = true;
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index 3eebe7ff71..170c13984d 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -830,6 +830,8 @@
|
|
||||||
# @pbs-dirty-bitmap: True if dirty-bitmap-incremental backups to PBS are
|
|
||||||
# supported.
|
|
||||||
#
|
|
||||||
+# @query-bitmap-info: True if the 'query-pbs-bitmap-info' QMP call is supported.
|
|
||||||
+#
|
|
||||||
# @pbs-dirty-bitmap-savevm: True if 'dirty-bitmaps' migration capability can
|
|
||||||
# safely be set for savevm-async.
|
|
||||||
#
|
|
||||||
@@ -838,6 +840,7 @@
|
|
||||||
##
|
|
||||||
{ 'struct': 'ProxmoxSupportStatus',
|
|
||||||
'data': { 'pbs-dirty-bitmap': 'bool',
|
|
||||||
+ 'query-bitmap-info': 'bool',
|
|
||||||
'pbs-dirty-bitmap-savevm': 'bool',
|
|
||||||
'pbs-library-version': 'str' } }
|
|
||||||
|
|
||||||
@@ -851,6 +854,59 @@
|
|
||||||
##
|
|
||||||
{ 'command': 'query-proxmox-support', 'returns': 'ProxmoxSupportStatus' }
|
|
||||||
|
|
||||||
+##
|
|
||||||
+# @PBSBitmapAction:
|
|
||||||
+#
|
|
||||||
+# An action taken on a dirty-bitmap when a backup job was started.
|
|
||||||
+#
|
|
||||||
+# @not-used: Bitmap mode was not enabled.
|
|
||||||
+#
|
|
||||||
+# @not-used-removed: Bitmap mode was not enabled, but a bitmap from a
|
|
||||||
+# previous backup still existed and was removed.
|
|
||||||
+#
|
|
||||||
+# @new: A new bitmap was attached to the drive for this backup.
|
|
||||||
+#
|
|
||||||
+# @used: An existing bitmap will be used to only backup changed data.
|
|
||||||
+#
|
|
||||||
+# @invalid: A bitmap existed, but had to be cleared since it's associated
|
|
||||||
+# base snapshot did not match the base given for the current job or
|
|
||||||
+# the crypt mode has changed.
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'enum': 'PBSBitmapAction',
|
|
||||||
+ 'data': ['not-used', 'not-used-removed', 'new', 'used', 'invalid'] }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @PBSBitmapInfo:
|
|
||||||
+#
|
|
||||||
+# Contains information about dirty bitmaps used for each drive in a PBS backup.
|
|
||||||
+#
|
|
||||||
+# @drive: The underlying drive.
|
|
||||||
+#
|
|
||||||
+# @action: The action that was taken when the backup started.
|
|
||||||
+#
|
|
||||||
+# @size: The total size of the drive.
|
|
||||||
+#
|
|
||||||
+# @dirty: How much of the drive is considered dirty and will be backed up,
|
|
||||||
+# or 'size' if everything will be.
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'struct': 'PBSBitmapInfo',
|
|
||||||
+ 'data': { 'drive': 'str', 'action': 'PBSBitmapAction', 'size': 'int',
|
|
||||||
+ 'dirty': 'int' } }
|
|
||||||
+
|
|
||||||
+##
|
|
||||||
+# @query-pbs-bitmap-info:
|
|
||||||
+#
|
|
||||||
+# Returns information about dirty bitmaps used on the most recently started
|
|
||||||
+# backup. Returns nothing when the last backup was not using PBS or if no
|
|
||||||
+# backup occured in this session.
|
|
||||||
+#
|
|
||||||
+# Returns: @PBSBitmapInfo
|
|
||||||
+#
|
|
||||||
+##
|
|
||||||
+{ 'command': 'query-pbs-bitmap-info', 'returns': ['PBSBitmapInfo'] }
|
|
||||||
+
|
|
||||||
##
|
|
||||||
# @BlockDeviceTimedStats:
|
|
||||||
#
|
|
|
@ -9,50 +9,51 @@ fitting.
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
---
|
---
|
||||||
meson.build | 2 ++
|
meson.build | 3 ++-
|
||||||
os-posix.c | 7 +++++--
|
os-posix.c | 7 +++++--
|
||||||
2 files changed, 7 insertions(+), 2 deletions(-)
|
2 files changed, 7 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index 45c1f2de73..44071acbb7 100644
|
index 3bc039f60f..067e8956a7 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -1065,6 +1065,7 @@ keyutils = dependency('libkeyutils', required: false,
|
@@ -1923,6 +1923,7 @@ endif
|
||||||
has_gettid = cc.has_function('gettid')
|
has_gettid = cc.has_function('gettid')
|
||||||
|
|
||||||
libuuid = cc.find_library('uuid', required: true)
|
libuuid = cc.find_library('uuid', required: true)
|
||||||
+libsystemd = cc.find_library('systemd', required: true)
|
+libsystemd = cc.find_library('systemd', required: true)
|
||||||
libproxmox_backup_qemu = cc.find_library('proxmox_backup_qemu', required: true)
|
libproxmox_backup_qemu = cc.find_library('proxmox_backup_qemu', required: true)
|
||||||
|
|
||||||
# Malloc tests
|
# libselinux
|
||||||
@@ -2246,6 +2247,7 @@ if have_block
|
@@ -3530,7 +3531,7 @@ if have_block
|
||||||
# os-posix.c contains POSIX-specific functions used by qemu-storage-daemon,
|
if host_os == 'windows'
|
||||||
# os-win32.c does not
|
system_ss.add(files('os-win32.c'))
|
||||||
blockdev_ss.add(when: 'CONFIG_POSIX', if_true: files('os-posix.c'))
|
else
|
||||||
+ blockdev_ss.add(when: 'CONFIG_POSIX', if_true: libsystemd)
|
- blockdev_ss.add(files('os-posix.c'))
|
||||||
softmmu_ss.add(when: 'CONFIG_WIN32', if_true: [files('os-win32.c')])
|
+ blockdev_ss.add(files('os-posix.c'), libsystemd)
|
||||||
|
endif
|
||||||
endif
|
endif
|
||||||
|
|
||||||
diff --git a/os-posix.c b/os-posix.c
|
diff --git a/os-posix.c b/os-posix.c
|
||||||
index ae6c9f2a5e..36807806bf 100644
|
index a4284e2c07..197a2120fd 100644
|
||||||
--- a/os-posix.c
|
--- a/os-posix.c
|
||||||
+++ b/os-posix.c
|
+++ b/os-posix.c
|
||||||
@@ -28,6 +28,8 @@
|
@@ -29,6 +29,8 @@
|
||||||
#include <pwd.h>
|
#include <pwd.h>
|
||||||
#include <grp.h>
|
#include <grp.h>
|
||||||
#include <libgen.h>
|
#include <libgen.h>
|
||||||
+#include <systemd/sd-journal.h>
|
+#include <systemd/sd-journal.h>
|
||||||
+#include <syslog.h>
|
+#include <syslog.h>
|
||||||
|
|
||||||
#include "qemu-common.h"
|
#include "qemu/error-report.h"
|
||||||
/* Needed early for CONFIG_BSD etc. */
|
#include "qemu/log.h"
|
||||||
@@ -291,9 +293,10 @@ void os_setup_post(void)
|
@@ -302,9 +304,10 @@ void os_setup_post(void)
|
||||||
|
|
||||||
dup2(fd, 0);
|
dup2(fd, 0);
|
||||||
dup2(fd, 1);
|
dup2(fd, 1);
|
||||||
- /* In case -D is given do not redirect stderr to /dev/null */
|
- /* In case -D is given do not redirect stderr to /dev/null */
|
||||||
+ /* In case -D is given do not redirect stderr to journal */
|
+ /* In case -D is given do not redirect stderr to journal */
|
||||||
if (!qemu_logfile) {
|
if (!qemu_log_enabled()) {
|
||||||
- dup2(fd, 2);
|
- dup2(fd, 2);
|
||||||
+ int journal_fd = sd_journal_stream_fd("QEMU", LOG_ERR, 0);
|
+ int journal_fd = sd_journal_stream_fd("QEMU", LOG_ERR, 0);
|
||||||
+ dup2(journal_fd, 2);
|
+ dup2(journal_fd, 2);
|
|
@ -13,21 +13,23 @@ safe migration is possible and makes sense.
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: split up state_pending for 8.0]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
include/migration/misc.h | 3 ++
|
include/migration/misc.h | 3 ++
|
||||||
migration/meson.build | 2 +
|
migration/meson.build | 2 +
|
||||||
migration/migration.c | 1 +
|
migration/migration.c | 1 +
|
||||||
migration/pbs-state.c | 106 +++++++++++++++++++++++++++++++++++++++
|
migration/pbs-state.c | 104 +++++++++++++++++++++++++++++++++++++++
|
||||||
pve-backup.c | 1 +
|
pve-backup.c | 1 +
|
||||||
qapi/block-core.json | 6 +++
|
qapi/block-core.json | 6 +++
|
||||||
6 files changed, 119 insertions(+)
|
6 files changed, 117 insertions(+)
|
||||||
create mode 100644 migration/pbs-state.c
|
create mode 100644 migration/pbs-state.c
|
||||||
|
|
||||||
diff --git a/include/migration/misc.h b/include/migration/misc.h
|
diff --git a/include/migration/misc.h b/include/migration/misc.h
|
||||||
index 465906710d..4f0aeceb6f 100644
|
index c9e200f4eb..12c99ebc69 100644
|
||||||
--- a/include/migration/misc.h
|
--- a/include/migration/misc.h
|
||||||
+++ b/include/migration/misc.h
|
+++ b/include/migration/misc.h
|
||||||
@@ -75,4 +75,7 @@ bool migration_in_bg_snapshot(void);
|
@@ -117,4 +117,7 @@ bool migration_in_bg_snapshot(void);
|
||||||
/* migration/block-dirty-bitmap.c */
|
/* migration/block-dirty-bitmap.c */
|
||||||
void dirty_bitmap_mig_init(void);
|
void dirty_bitmap_mig_init(void);
|
||||||
|
|
||||||
|
@ -36,38 +38,37 @@ index 465906710d..4f0aeceb6f 100644
|
||||||
+
|
+
|
||||||
#endif
|
#endif
|
||||||
diff --git a/migration/meson.build b/migration/meson.build
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
index ea9aedeefc..c27dc9bd97 100644
|
index 800f12a60d..35a4306183 100644
|
||||||
--- a/migration/meson.build
|
--- a/migration/meson.build
|
||||||
+++ b/migration/meson.build
|
+++ b/migration/meson.build
|
||||||
@@ -7,8 +7,10 @@ migration_files = files(
|
@@ -7,7 +7,9 @@ migration_files = files(
|
||||||
'qemu-file-channel.c',
|
'vmstate.c',
|
||||||
'qemu-file.c',
|
'qemu-file.c',
|
||||||
'yank_functions.c',
|
'yank_functions.c',
|
||||||
+ 'pbs-state.c',
|
+ 'pbs-state.c',
|
||||||
)
|
)
|
||||||
softmmu_ss.add(migration_files)
|
+system_ss.add(libproxmox_backup_qemu)
|
||||||
+softmmu_ss.add(libproxmox_backup_qemu)
|
|
||||||
|
|
||||||
softmmu_ss.add(files(
|
system_ss.add(files(
|
||||||
'block-dirty-bitmap.c',
|
'block-dirty-bitmap.c',
|
||||||
diff --git a/migration/migration.c b/migration/migration.c
|
diff --git a/migration/migration.c b/migration/migration.c
|
||||||
index 041b8451a6..9df2eed75e 100644
|
index 86bf76e925..b8d7e471a4 100644
|
||||||
--- a/migration/migration.c
|
--- a/migration/migration.c
|
||||||
+++ b/migration/migration.c
|
+++ b/migration/migration.c
|
||||||
@@ -218,6 +218,7 @@ void migration_object_init(void)
|
@@ -239,6 +239,7 @@ void migration_object_init(void)
|
||||||
blk_mig_init();
|
blk_mig_init();
|
||||||
ram_mig_init();
|
ram_mig_init();
|
||||||
dirty_bitmap_mig_init();
|
dirty_bitmap_mig_init();
|
||||||
+ pbs_state_mig_init();
|
+ pbs_state_mig_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
void migration_cancel(void)
|
typedef struct {
|
||||||
diff --git a/migration/pbs-state.c b/migration/pbs-state.c
|
diff --git a/migration/pbs-state.c b/migration/pbs-state.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..29f2b3860d
|
index 0000000000..887e998b9e
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/migration/pbs-state.c
|
+++ b/migration/pbs-state.c
|
||||||
@@ -0,0 +1,106 @@
|
@@ -0,0 +1,104 @@
|
||||||
+/*
|
+/*
|
||||||
+ * PBS (dirty-bitmap) state migration
|
+ * PBS (dirty-bitmap) state migration
|
||||||
+ */
|
+ */
|
||||||
|
@ -86,11 +87,8 @@ index 0000000000..29f2b3860d
|
||||||
+/* state is accessed via this static variable directly, 'opaque' is NULL */
|
+/* state is accessed via this static variable directly, 'opaque' is NULL */
|
||||||
+static PBSState pbs_state;
|
+static PBSState pbs_state;
|
||||||
+
|
+
|
||||||
+static void pbs_state_save_pending(QEMUFile *f, void *opaque,
|
+static void pbs_state_pending(void *opaque, uint64_t *must_precopy,
|
||||||
+ uint64_t max_size,
|
+ uint64_t *can_postcopy)
|
||||||
+ uint64_t *res_precopy_only,
|
|
||||||
+ uint64_t *res_compatible,
|
|
||||||
+ uint64_t *res_postcopy_only)
|
|
||||||
+{
|
+{
|
||||||
+ /* we send everything in save_setup, so nothing is ever pending */
|
+ /* we send everything in save_setup, so nothing is ever pending */
|
||||||
+}
|
+}
|
||||||
|
@ -160,7 +158,8 @@ index 0000000000..29f2b3860d
|
||||||
+static SaveVMHandlers savevm_pbs_state_handlers = {
|
+static SaveVMHandlers savevm_pbs_state_handlers = {
|
||||||
+ .save_setup = pbs_state_save_setup,
|
+ .save_setup = pbs_state_save_setup,
|
||||||
+ .has_postcopy = pbs_state_has_postcopy,
|
+ .has_postcopy = pbs_state_has_postcopy,
|
||||||
+ .save_live_pending = pbs_state_save_pending,
|
+ .state_pending_exact = pbs_state_pending,
|
||||||
|
+ .state_pending_estimate = pbs_state_pending,
|
||||||
+ .is_active_iterate = pbs_state_is_active_iterate,
|
+ .is_active_iterate = pbs_state_is_active_iterate,
|
||||||
+ .load_state = pbs_state_load,
|
+ .load_state = pbs_state_load,
|
||||||
+ .is_active = pbs_state_is_active,
|
+ .is_active = pbs_state_is_active,
|
||||||
|
@ -175,22 +174,22 @@ index 0000000000..29f2b3860d
|
||||||
+ NULL);
|
+ NULL);
|
||||||
+}
|
+}
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
index 9c20ef3a5e..59ccb38ceb 100644
|
index c755bf302b..5ebb6a3947 100644
|
||||||
--- a/pve-backup.c
|
--- a/pve-backup.c
|
||||||
+++ b/pve-backup.c
|
+++ b/pve-backup.c
|
||||||
@@ -1132,6 +1132,7 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
@@ -1085,6 +1085,7 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
||||||
ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
||||||
ret->pbs_dirty_bitmap = true;
|
ret->pbs_dirty_bitmap = true;
|
||||||
ret->pbs_dirty_bitmap_savevm = true;
|
ret->pbs_dirty_bitmap_savevm = true;
|
||||||
+ ret->pbs_dirty_bitmap_migration = true;
|
+ ret->pbs_dirty_bitmap_migration = true;
|
||||||
ret->query_bitmap_info = true;
|
ret->query_bitmap_info = true;
|
||||||
return ret;
|
ret->pbs_masterkey = true;
|
||||||
}
|
ret->backup_max_workers = true;
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index a0d1d278e9..e5de769dc1 100644
|
index e7cf3d94f3..282e2e8a8c 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -838,6 +838,11 @@
|
@@ -1004,6 +1004,11 @@
|
||||||
# @pbs-dirty-bitmap-savevm: True if 'dirty-bitmaps' migration capability can
|
# @pbs-dirty-bitmap-savevm: True if 'dirty-bitmaps' migration capability can
|
||||||
# safely be set for savevm-async.
|
# safely be set for savevm-async.
|
||||||
#
|
#
|
||||||
|
@ -199,14 +198,14 @@ index a0d1d278e9..e5de769dc1 100644
|
||||||
+# migration cap if this is false/unset may lead
|
+# migration cap if this is false/unset may lead
|
||||||
+# to crashes on migration!
|
+# to crashes on migration!
|
||||||
+#
|
+#
|
||||||
# @pbs-library-version: Running version of libproxmox-backup-qemu0 library.
|
# @pbs-masterkey: True if the QMP backup call supports the 'master_keyfile'
|
||||||
|
# parameter.
|
||||||
#
|
#
|
||||||
##
|
@@ -1017,6 +1022,7 @@
|
||||||
@@ -845,6 +850,7 @@
|
|
||||||
'data': { 'pbs-dirty-bitmap': 'bool',
|
'data': { 'pbs-dirty-bitmap': 'bool',
|
||||||
'query-bitmap-info': 'bool',
|
'query-bitmap-info': 'bool',
|
||||||
'pbs-dirty-bitmap-savevm': 'bool',
|
'pbs-dirty-bitmap-savevm': 'bool',
|
||||||
+ 'pbs-dirty-bitmap-migration': 'bool',
|
+ 'pbs-dirty-bitmap-migration': 'bool',
|
||||||
'pbs-library-version': 'str' } }
|
'pbs-masterkey': 'bool',
|
||||||
|
'pbs-library-version': 'str',
|
||||||
##
|
'backup-max-workers': 'bool' } }
|
|
@ -19,10 +19,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
|
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
|
||||||
index 35f5ef688d..c4640925e7 100644
|
index 2708abf3d7..fb17c01308 100644
|
||||||
--- a/migration/block-dirty-bitmap.c
|
--- a/migration/block-dirty-bitmap.c
|
||||||
+++ b/migration/block-dirty-bitmap.c
|
+++ b/migration/block-dirty-bitmap.c
|
||||||
@@ -538,7 +538,7 @@ static int add_bitmaps_to_list(DBMSaveState *s, BlockDriverState *bs,
|
@@ -540,7 +540,7 @@ static int add_bitmaps_to_list(DBMSaveState *s, BlockDriverState *bs,
|
||||||
|
|
||||||
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
|
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
|
||||||
error_report_err(local_err);
|
error_report_err(local_err);
|
|
@ -1,294 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Thu, 20 Aug 2020 14:25:00 +0200
|
|
||||||
Subject: [PATCH] PVE-Backup: Use a transaction to synchronize job states
|
|
||||||
|
|
||||||
By using a JobTxn, we can sync dirty bitmaps only when *all* jobs were
|
|
||||||
successful - meaning we don't need to remove them when the backup fails,
|
|
||||||
since QEMU's BITMAP_SYNC_MODE_ON_SUCCESS will now handle that for us.
|
|
||||||
|
|
||||||
To keep the rate-limiting and IO impact from before, we use a sequential
|
|
||||||
transaction, so drives will still be backed up one after the other.
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 169 +++++++++++++++------------------------------------
|
|
||||||
1 file changed, 50 insertions(+), 119 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 22420db26a..2e628d68e4 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -52,6 +52,7 @@ static struct PVEBackupState {
|
|
||||||
VmaWriter *vmaw;
|
|
||||||
ProxmoxBackupHandle *pbs;
|
|
||||||
GList *di_list;
|
|
||||||
+ JobTxn *txn;
|
|
||||||
QemuMutex backup_mutex;
|
|
||||||
CoMutex dump_callback_mutex;
|
|
||||||
} backup_state;
|
|
||||||
@@ -71,32 +72,12 @@ typedef struct PVEBackupDevInfo {
|
|
||||||
size_t size;
|
|
||||||
uint64_t block_size;
|
|
||||||
uint8_t dev_id;
|
|
||||||
- bool completed;
|
|
||||||
char targetfile[PATH_MAX];
|
|
||||||
BdrvDirtyBitmap *bitmap;
|
|
||||||
BlockDriverState *target;
|
|
||||||
+ BlockJob *job;
|
|
||||||
} PVEBackupDevInfo;
|
|
||||||
|
|
||||||
-static void pvebackup_run_next_job(void);
|
|
||||||
-
|
|
||||||
-static BlockJob *
|
|
||||||
-lookup_active_block_job(PVEBackupDevInfo *di)
|
|
||||||
-{
|
|
||||||
- if (!di->completed && di->bs) {
|
|
||||||
- for (BlockJob *job = block_job_next(NULL); job; job = block_job_next(job)) {
|
|
||||||
- if (job->job.driver->job_type != JOB_TYPE_BACKUP) {
|
|
||||||
- continue;
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- BackupBlockJob *bjob = container_of(job, BackupBlockJob, common);
|
|
||||||
- if (bjob && bjob->source_bs == di->bs) {
|
|
||||||
- return job;
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
- return NULL;
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
static void pvebackup_propagate_error(Error *err)
|
|
||||||
{
|
|
||||||
qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
@@ -272,18 +253,6 @@ static void coroutine_fn pvebackup_co_cleanup(void *unused)
|
|
||||||
if (local_err != NULL) {
|
|
||||||
pvebackup_propagate_error(local_err);
|
|
||||||
}
|
|
||||||
- } else {
|
|
||||||
- // on error or cancel we cannot ensure synchronization of dirty
|
|
||||||
- // bitmaps with backup server, so remove all and do full backup next
|
|
||||||
- GList *l = backup_state.di_list;
|
|
||||||
- while (l) {
|
|
||||||
- PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
- l = g_list_next(l);
|
|
||||||
-
|
|
||||||
- if (di->bitmap) {
|
|
||||||
- bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
}
|
|
||||||
|
|
||||||
proxmox_backup_disconnect(backup_state.pbs);
|
|
||||||
@@ -322,8 +291,6 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
|
|
||||||
qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
|
|
||||||
- di->completed = true;
|
|
||||||
-
|
|
||||||
if (ret < 0) {
|
|
||||||
Error *local_err = NULL;
|
|
||||||
error_setg(&local_err, "job failed with err %d - %s", ret, strerror(-ret));
|
|
||||||
@@ -336,20 +303,17 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
|
|
||||||
block_on_coroutine_fn(pvebackup_complete_stream, di);
|
|
||||||
|
|
||||||
- // remove self from job queue
|
|
||||||
+ // remove self from job list
|
|
||||||
backup_state.di_list = g_list_remove(backup_state.di_list, di);
|
|
||||||
|
|
||||||
- if (di->bitmap && ret < 0) {
|
|
||||||
- // on error or cancel we cannot ensure synchronization of dirty
|
|
||||||
- // bitmaps with backup server, so remove all and do full backup next
|
|
||||||
- bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
g_free(di);
|
|
||||||
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
+ /* call cleanup if we're the last job */
|
|
||||||
+ if (!g_list_first(backup_state.di_list)) {
|
|
||||||
+ block_on_coroutine_fn(pvebackup_co_cleanup, NULL);
|
|
||||||
+ }
|
|
||||||
|
|
||||||
- pvebackup_run_next_job();
|
|
||||||
+ qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
static void pvebackup_cancel(void)
|
|
||||||
@@ -371,36 +335,28 @@ static void pvebackup_cancel(void)
|
|
||||||
proxmox_backup_abort(backup_state.pbs, "backup canceled");
|
|
||||||
}
|
|
||||||
|
|
||||||
+ /* it's enough to cancel one job in the transaction, the rest will follow
|
|
||||||
+ * automatically */
|
|
||||||
+ GList *bdi = g_list_first(backup_state.di_list);
|
|
||||||
+ BlockJob *cancel_job = bdi && bdi->data ?
|
|
||||||
+ ((PVEBackupDevInfo *)bdi->data)->job :
|
|
||||||
+ NULL;
|
|
||||||
+
|
|
||||||
+ /* ref the job before releasing the mutex, just to be safe */
|
|
||||||
+ if (cancel_job) {
|
|
||||||
+ job_ref(&cancel_job->job);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ /* job_cancel_sync may enter the job, so we need to release the
|
|
||||||
+ * backup_mutex to avoid deadlock */
|
|
||||||
qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
|
|
||||||
- for(;;) {
|
|
||||||
-
|
|
||||||
- BlockJob *next_job = NULL;
|
|
||||||
-
|
|
||||||
- qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- GList *l = backup_state.di_list;
|
|
||||||
- while (l) {
|
|
||||||
- PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
- l = g_list_next(l);
|
|
||||||
-
|
|
||||||
- BlockJob *job = lookup_active_block_job(di);
|
|
||||||
- if (job != NULL) {
|
|
||||||
- next_job = job;
|
|
||||||
- break;
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- if (next_job) {
|
|
||||||
- AioContext *aio_context = next_job->job.aio_context;
|
|
||||||
- aio_context_acquire(aio_context);
|
|
||||||
- job_cancel_sync(&next_job->job);
|
|
||||||
- aio_context_release(aio_context);
|
|
||||||
- } else {
|
|
||||||
- break;
|
|
||||||
- }
|
|
||||||
+ if (cancel_job) {
|
|
||||||
+ AioContext *aio_context = cancel_job->job.aio_context;
|
|
||||||
+ aio_context_acquire(aio_context);
|
|
||||||
+ job_cancel_sync(&cancel_job->job);
|
|
||||||
+ job_unref(&cancel_job->job);
|
|
||||||
+ aio_context_release(aio_context);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -459,51 +415,19 @@ static int coroutine_fn pvebackup_co_add_config(
|
|
||||||
goto out;
|
|
||||||
}
|
|
||||||
|
|
||||||
-bool job_should_pause(Job *job);
|
|
||||||
-
|
|
||||||
-static void pvebackup_run_next_job(void)
|
|
||||||
-{
|
|
||||||
- assert(!qemu_in_coroutine());
|
|
||||||
-
|
|
||||||
- qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- GList *l = backup_state.di_list;
|
|
||||||
- while (l) {
|
|
||||||
- PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
- l = g_list_next(l);
|
|
||||||
-
|
|
||||||
- BlockJob *job = lookup_active_block_job(di);
|
|
||||||
-
|
|
||||||
- if (job) {
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- AioContext *aio_context = job->job.aio_context;
|
|
||||||
- aio_context_acquire(aio_context);
|
|
||||||
-
|
|
||||||
- if (job_should_pause(&job->job)) {
|
|
||||||
- bool error_or_canceled = pvebackup_error_or_canceled();
|
|
||||||
- if (error_or_canceled) {
|
|
||||||
- job_cancel_sync(&job->job);
|
|
||||||
- } else {
|
|
||||||
- job_resume(&job->job);
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
- aio_context_release(aio_context);
|
|
||||||
- return;
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- block_on_coroutine_fn(pvebackup_co_cleanup, NULL); // no more jobs, run cleanup
|
|
||||||
-
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
static bool create_backup_jobs(void) {
|
|
||||||
|
|
||||||
assert(!qemu_in_coroutine());
|
|
||||||
|
|
||||||
Error *local_err = NULL;
|
|
||||||
|
|
||||||
+ /* create job transaction to synchronize bitmap commit and cancel all
|
|
||||||
+ * jobs in case one errors */
|
|
||||||
+ if (backup_state.txn) {
|
|
||||||
+ job_txn_unref(backup_state.txn);
|
|
||||||
+ }
|
|
||||||
+ backup_state.txn = job_txn_new_seq();
|
|
||||||
+
|
|
||||||
BackupPerf perf = { .max_workers = 16 };
|
|
||||||
|
|
||||||
/* create and start all jobs (paused state) */
|
|
||||||
@@ -526,7 +450,7 @@ static bool create_backup_jobs(void) {
|
|
||||||
BlockJob *job = backup_job_create(
|
|
||||||
NULL, di->bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
|
||||||
bitmap_mode, false, NULL, &perf, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
|
|
||||||
- JOB_DEFAULT, pvebackup_complete_cb, di, NULL, &local_err);
|
|
||||||
+ JOB_DEFAULT, pvebackup_complete_cb, di, backup_state.txn, &local_err);
|
|
||||||
|
|
||||||
aio_context_release(aio_context);
|
|
||||||
|
|
||||||
@@ -538,7 +462,8 @@ static bool create_backup_jobs(void) {
|
|
||||||
pvebackup_propagate_error(create_job_err);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
- job_start(&job->job);
|
|
||||||
+
|
|
||||||
+ di->job = job;
|
|
||||||
|
|
||||||
bdrv_unref(di->target);
|
|
||||||
di->target = NULL;
|
|
||||||
@@ -556,6 +481,10 @@ static bool create_backup_jobs(void) {
|
|
||||||
bdrv_unref(di->target);
|
|
||||||
di->target = NULL;
|
|
||||||
}
|
|
||||||
+
|
|
||||||
+ if (di->job) {
|
|
||||||
+ job_unref(&di->job->job);
|
|
||||||
+ }
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -946,10 +875,6 @@ err:
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
l = g_list_next(l);
|
|
||||||
|
|
||||||
- if (di->bitmap) {
|
|
||||||
- bdrv_release_dirty_bitmap(di->bitmap);
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
if (di->target) {
|
|
||||||
bdrv_unref(di->target);
|
|
||||||
}
|
|
||||||
@@ -1038,9 +963,15 @@ UuidInfo *qmp_backup(
|
|
||||||
block_on_coroutine_fn(pvebackup_co_prepare, &task);
|
|
||||||
|
|
||||||
if (*errp == NULL) {
|
|
||||||
- create_backup_jobs();
|
|
||||||
+ bool errors = create_backup_jobs();
|
|
||||||
qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
- pvebackup_run_next_job();
|
|
||||||
+
|
|
||||||
+ if (!errors) {
|
|
||||||
+ /* start the first job in the transaction
|
|
||||||
+ * note: this might directly enter the job, so we need to do this
|
|
||||||
+ * after unlocking the backup_mutex */
|
|
||||||
+ job_txn_start_seq(backup_state.txn);
|
|
||||||
+ }
|
|
||||||
} else {
|
|
||||||
qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
|
@ -21,10 +21,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 30 insertions(+)
|
1 file changed, 30 insertions(+)
|
||||||
|
|
||||||
diff --git a/block/iscsi.c b/block/iscsi.c
|
diff --git a/block/iscsi.c b/block/iscsi.c
|
||||||
index 4d2a416ce7..c345d30812 100644
|
index 2ff14b7472..46f275fbf7 100644
|
||||||
--- a/block/iscsi.c
|
--- a/block/iscsi.c
|
||||||
+++ b/block/iscsi.c
|
+++ b/block/iscsi.c
|
||||||
@@ -1372,12 +1372,42 @@ static char *get_initiator_name(QemuOpts *opts)
|
@@ -1392,12 +1392,42 @@ static char *get_initiator_name(QemuOpts *opts)
|
||||||
const char *name;
|
const char *name;
|
||||||
char *iscsi_name;
|
char *iscsi_name;
|
||||||
UuidInfo *uuid_info;
|
UuidInfo *uuid_info;
|
|
@ -1,501 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Mon, 28 Sep 2020 13:40:51 +0200
|
|
||||||
Subject: [PATCH] PVE-Backup: Don't block on finishing and cleanup
|
|
||||||
create_backup_jobs
|
|
||||||
|
|
||||||
proxmox_backup_co_finish is already async, but previously we would wait
|
|
||||||
for the coroutine using block_on_coroutine_fn(). Avoid this by
|
|
||||||
scheduling pvebackup_co_complete_stream (and thus pvebackup_co_cleanup)
|
|
||||||
as a real coroutine when calling from pvebackup_complete_cb. This is ok,
|
|
||||||
since complete_stream uses the backup_mutex internally to synchronize,
|
|
||||||
and other streams can happily continue writing in the meantime anyway.
|
|
||||||
|
|
||||||
To accomodate, backup_mutex is converted to a CoMutex. This means
|
|
||||||
converting every user to a coroutine. This is not just useful here, but
|
|
||||||
will come in handy once this series[0] is merged, and QMP calls can be
|
|
||||||
yield-able coroutines too. Then we can also finally get rid of
|
|
||||||
block_on_coroutine_fn.
|
|
||||||
|
|
||||||
Cases of aio_context_acquire/release from within what is now a coroutine
|
|
||||||
are changed to aio_co_reschedule_self, which works since a running
|
|
||||||
coroutine always holds the aio lock for the context it is running in.
|
|
||||||
|
|
||||||
job_cancel_sync is called from a BH since it can't be run from a
|
|
||||||
coroutine (uses AIO_WAIT_WHILE internally).
|
|
||||||
|
|
||||||
Same thing for create_backup_jobs, which is converted to a BH too.
|
|
||||||
|
|
||||||
To communicate the finishing state, a new property is introduced to
|
|
||||||
query-backup: 'finishing'. A new state is explicitly not used, since
|
|
||||||
that would break compatibility with older qemu-server versions.
|
|
||||||
|
|
||||||
Also fix create_backup_jobs:
|
|
||||||
|
|
||||||
No more weird bool returns, just the standard "errp" format used
|
|
||||||
everywhere else too. With this, if backup_job_create fails, the error
|
|
||||||
message is actually returned over QMP and can be shown to the user.
|
|
||||||
|
|
||||||
To facilitate correct cleanup on such an error, we call
|
|
||||||
create_backup_jobs as a bottom half directly from pvebackup_co_prepare.
|
|
||||||
This additionally allows us to actually hold the backup_mutex during
|
|
||||||
operation.
|
|
||||||
|
|
||||||
Also add a job_cancel_sync before job_unref, since a job must be in
|
|
||||||
STATUS_NULL to be deleted by unref, which could trigger an assert
|
|
||||||
before.
|
|
||||||
|
|
||||||
[0] https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg03515.html
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 217 ++++++++++++++++++++++++++++---------------
|
|
||||||
qapi/block-core.json | 5 +-
|
|
||||||
2 files changed, 144 insertions(+), 78 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 2e628d68e4..9c20ef3a5e 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -33,7 +33,9 @@ const char *PBS_BITMAP_NAME = "pbs-incremental-dirty-bitmap";
|
|
||||||
|
|
||||||
static struct PVEBackupState {
|
|
||||||
struct {
|
|
||||||
- // Everithing accessed from qmp_backup_query command is protected using lock
|
|
||||||
+ // Everything accessed from qmp_backup_query command is protected using
|
|
||||||
+ // this lock. Do NOT hold this lock for long times, as it is sometimes
|
|
||||||
+ // acquired from coroutines, and thus any wait time may block the guest.
|
|
||||||
QemuMutex lock;
|
|
||||||
Error *error;
|
|
||||||
time_t start_time;
|
|
||||||
@@ -47,20 +49,22 @@ static struct PVEBackupState {
|
|
||||||
size_t reused;
|
|
||||||
size_t zero_bytes;
|
|
||||||
GList *bitmap_list;
|
|
||||||
+ bool finishing;
|
|
||||||
+ bool starting;
|
|
||||||
} stat;
|
|
||||||
int64_t speed;
|
|
||||||
VmaWriter *vmaw;
|
|
||||||
ProxmoxBackupHandle *pbs;
|
|
||||||
GList *di_list;
|
|
||||||
JobTxn *txn;
|
|
||||||
- QemuMutex backup_mutex;
|
|
||||||
+ CoMutex backup_mutex;
|
|
||||||
CoMutex dump_callback_mutex;
|
|
||||||
} backup_state;
|
|
||||||
|
|
||||||
static void pvebackup_init(void)
|
|
||||||
{
|
|
||||||
qemu_mutex_init(&backup_state.stat.lock);
|
|
||||||
- qemu_mutex_init(&backup_state.backup_mutex);
|
|
||||||
+ qemu_co_mutex_init(&backup_state.backup_mutex);
|
|
||||||
qemu_co_mutex_init(&backup_state.dump_callback_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -72,6 +76,7 @@ typedef struct PVEBackupDevInfo {
|
|
||||||
size_t size;
|
|
||||||
uint64_t block_size;
|
|
||||||
uint8_t dev_id;
|
|
||||||
+ int completed_ret; // INT_MAX if not completed
|
|
||||||
char targetfile[PATH_MAX];
|
|
||||||
BdrvDirtyBitmap *bitmap;
|
|
||||||
BlockDriverState *target;
|
|
||||||
@@ -227,12 +232,12 @@ pvebackup_co_dump_vma_cb(
|
|
||||||
}
|
|
||||||
|
|
||||||
// assumes the caller holds backup_mutex
|
|
||||||
-static void coroutine_fn pvebackup_co_cleanup(void *unused)
|
|
||||||
+static void coroutine_fn pvebackup_co_cleanup(void)
|
|
||||||
{
|
|
||||||
assert(qemu_in_coroutine());
|
|
||||||
|
|
||||||
qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
- backup_state.stat.end_time = time(NULL);
|
|
||||||
+ backup_state.stat.finishing = true;
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
if (backup_state.vmaw) {
|
|
||||||
@@ -261,35 +266,29 @@ static void coroutine_fn pvebackup_co_cleanup(void *unused)
|
|
||||||
|
|
||||||
g_list_free(backup_state.di_list);
|
|
||||||
backup_state.di_list = NULL;
|
|
||||||
+
|
|
||||||
+ qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+ backup_state.stat.end_time = time(NULL);
|
|
||||||
+ backup_state.stat.finishing = false;
|
|
||||||
+ qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
}
|
|
||||||
|
|
||||||
-// assumes the caller holds backup_mutex
|
|
||||||
-static void coroutine_fn pvebackup_complete_stream(void *opaque)
|
|
||||||
+static void coroutine_fn pvebackup_co_complete_stream(void *opaque)
|
|
||||||
{
|
|
||||||
PVEBackupDevInfo *di = opaque;
|
|
||||||
+ int ret = di->completed_ret;
|
|
||||||
|
|
||||||
- bool error_or_canceled = pvebackup_error_or_canceled();
|
|
||||||
-
|
|
||||||
- if (backup_state.vmaw) {
|
|
||||||
- vma_writer_close_stream(backup_state.vmaw, di->dev_id);
|
|
||||||
+ qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+ bool starting = backup_state.stat.starting;
|
|
||||||
+ qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
+ if (starting) {
|
|
||||||
+ /* in 'starting' state, no tasks have been run yet, meaning we can (and
|
|
||||||
+ * must) skip all cleanup, as we don't know what has and hasn't been
|
|
||||||
+ * initialized yet. */
|
|
||||||
+ return;
|
|
||||||
}
|
|
||||||
|
|
||||||
- if (backup_state.pbs && !error_or_canceled) {
|
|
||||||
- Error *local_err = NULL;
|
|
||||||
- proxmox_backup_co_close_image(backup_state.pbs, di->dev_id, &local_err);
|
|
||||||
- if (local_err != NULL) {
|
|
||||||
- pvebackup_propagate_error(local_err);
|
|
||||||
- }
|
|
||||||
- }
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
-static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
-{
|
|
||||||
- assert(!qemu_in_coroutine());
|
|
||||||
-
|
|
||||||
- PVEBackupDevInfo *di = opaque;
|
|
||||||
-
|
|
||||||
- qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
+ qemu_co_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
|
|
||||||
if (ret < 0) {
|
|
||||||
Error *local_err = NULL;
|
|
||||||
@@ -301,7 +300,19 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
|
|
||||||
assert(di->target == NULL);
|
|
||||||
|
|
||||||
- block_on_coroutine_fn(pvebackup_complete_stream, di);
|
|
||||||
+ bool error_or_canceled = pvebackup_error_or_canceled();
|
|
||||||
+
|
|
||||||
+ if (backup_state.vmaw) {
|
|
||||||
+ vma_writer_close_stream(backup_state.vmaw, di->dev_id);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (backup_state.pbs && !error_or_canceled) {
|
|
||||||
+ Error *local_err = NULL;
|
|
||||||
+ proxmox_backup_co_close_image(backup_state.pbs, di->dev_id, &local_err);
|
|
||||||
+ if (local_err != NULL) {
|
|
||||||
+ pvebackup_propagate_error(local_err);
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
|
|
||||||
// remove self from job list
|
|
||||||
backup_state.di_list = g_list_remove(backup_state.di_list, di);
|
|
||||||
@@ -310,21 +321,49 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
|
|
||||||
/* call cleanup if we're the last job */
|
|
||||||
if (!g_list_first(backup_state.di_list)) {
|
|
||||||
- block_on_coroutine_fn(pvebackup_co_cleanup, NULL);
|
|
||||||
+ pvebackup_co_cleanup();
|
|
||||||
}
|
|
||||||
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
-static void pvebackup_cancel(void)
|
|
||||||
+static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
{
|
|
||||||
- assert(!qemu_in_coroutine());
|
|
||||||
+ PVEBackupDevInfo *di = opaque;
|
|
||||||
+ di->completed_ret = ret;
|
|
||||||
|
|
||||||
+ /*
|
|
||||||
+ * Schedule stream cleanup in async coroutine. close_image and finish might
|
|
||||||
+ * take a while, so we can't block on them here. This way it also doesn't
|
|
||||||
+ * matter if we're already running in a coroutine or not.
|
|
||||||
+ * Note: di is a pointer to an entry in the global backup_state struct, so
|
|
||||||
+ * it stays valid.
|
|
||||||
+ */
|
|
||||||
+ Coroutine *co = qemu_coroutine_create(pvebackup_co_complete_stream, di);
|
|
||||||
+ aio_co_enter(qemu_get_aio_context(), co);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+/*
|
|
||||||
+ * job_cancel(_sync) does not like to be called from coroutines, so defer to
|
|
||||||
+ * main loop processing via a bottom half.
|
|
||||||
+ */
|
|
||||||
+static void job_cancel_bh(void *opaque) {
|
|
||||||
+ CoCtxData *data = (CoCtxData*)opaque;
|
|
||||||
+ Job *job = (Job*)data->data;
|
|
||||||
+ AioContext *job_ctx = job->aio_context;
|
|
||||||
+ aio_context_acquire(job_ctx);
|
|
||||||
+ job_cancel_sync(job);
|
|
||||||
+ aio_context_release(job_ctx);
|
|
||||||
+ aio_co_enter(data->ctx, data->co);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static void coroutine_fn pvebackup_co_cancel(void *opaque)
|
|
||||||
+{
|
|
||||||
Error *cancel_err = NULL;
|
|
||||||
error_setg(&cancel_err, "backup canceled");
|
|
||||||
pvebackup_propagate_error(cancel_err);
|
|
||||||
|
|
||||||
- qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
+ qemu_co_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
|
|
||||||
if (backup_state.vmaw) {
|
|
||||||
/* make sure vma writer does not block anymore */
|
|
||||||
@@ -342,27 +381,22 @@ static void pvebackup_cancel(void)
|
|
||||||
((PVEBackupDevInfo *)bdi->data)->job :
|
|
||||||
NULL;
|
|
||||||
|
|
||||||
- /* ref the job before releasing the mutex, just to be safe */
|
|
||||||
if (cancel_job) {
|
|
||||||
- job_ref(&cancel_job->job);
|
|
||||||
+ CoCtxData data = {
|
|
||||||
+ .ctx = qemu_get_current_aio_context(),
|
|
||||||
+ .co = qemu_coroutine_self(),
|
|
||||||
+ .data = &cancel_job->job,
|
|
||||||
+ };
|
|
||||||
+ aio_bh_schedule_oneshot(data.ctx, job_cancel_bh, &data);
|
|
||||||
+ qemu_coroutine_yield();
|
|
||||||
}
|
|
||||||
|
|
||||||
- /* job_cancel_sync may enter the job, so we need to release the
|
|
||||||
- * backup_mutex to avoid deadlock */
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- if (cancel_job) {
|
|
||||||
- AioContext *aio_context = cancel_job->job.aio_context;
|
|
||||||
- aio_context_acquire(aio_context);
|
|
||||||
- job_cancel_sync(&cancel_job->job);
|
|
||||||
- job_unref(&cancel_job->job);
|
|
||||||
- aio_context_release(aio_context);
|
|
||||||
- }
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
void qmp_backup_cancel(Error **errp)
|
|
||||||
{
|
|
||||||
- pvebackup_cancel();
|
|
||||||
+ block_on_coroutine_fn(pvebackup_co_cancel, NULL);
|
|
||||||
}
|
|
||||||
|
|
||||||
// assumes the caller holds backup_mutex
|
|
||||||
@@ -415,10 +449,18 @@ static int coroutine_fn pvebackup_co_add_config(
|
|
||||||
goto out;
|
|
||||||
}
|
|
||||||
|
|
||||||
-static bool create_backup_jobs(void) {
|
|
||||||
+/*
|
|
||||||
+ * backup_job_create can *not* be run from a coroutine (and requires an
|
|
||||||
+ * acquired AioContext), so this can't either.
|
|
||||||
+ * The caller is responsible that backup_mutex is held nonetheless.
|
|
||||||
+ */
|
|
||||||
+static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
|
|
||||||
assert(!qemu_in_coroutine());
|
|
||||||
|
|
||||||
+ CoCtxData *data = (CoCtxData*)opaque;
|
|
||||||
+ Error **errp = (Error**)data->data;
|
|
||||||
+
|
|
||||||
Error *local_err = NULL;
|
|
||||||
|
|
||||||
/* create job transaction to synchronize bitmap commit and cancel all
|
|
||||||
@@ -454,24 +496,19 @@ static bool create_backup_jobs(void) {
|
|
||||||
|
|
||||||
aio_context_release(aio_context);
|
|
||||||
|
|
||||||
- if (!job || local_err != NULL) {
|
|
||||||
- Error *create_job_err = NULL;
|
|
||||||
- error_setg(&create_job_err, "backup_job_create failed: %s",
|
|
||||||
+ di->job = job;
|
|
||||||
+
|
|
||||||
+ if (!job || local_err) {
|
|
||||||
+ error_setg(errp, "backup_job_create failed: %s",
|
|
||||||
local_err ? error_get_pretty(local_err) : "null");
|
|
||||||
-
|
|
||||||
- pvebackup_propagate_error(create_job_err);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
- di->job = job;
|
|
||||||
-
|
|
||||||
bdrv_unref(di->target);
|
|
||||||
di->target = NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
- bool errors = pvebackup_error_or_canceled();
|
|
||||||
-
|
|
||||||
- if (errors) {
|
|
||||||
+ if (*errp) {
|
|
||||||
l = backup_state.di_list;
|
|
||||||
while (l) {
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
@@ -483,12 +520,17 @@ static bool create_backup_jobs(void) {
|
|
||||||
}
|
|
||||||
|
|
||||||
if (di->job) {
|
|
||||||
+ AioContext *ctx = di->job->job.aio_context;
|
|
||||||
+ aio_context_acquire(ctx);
|
|
||||||
+ job_cancel_sync(&di->job->job);
|
|
||||||
job_unref(&di->job->job);
|
|
||||||
+ aio_context_release(ctx);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
- return errors;
|
|
||||||
+ /* return */
|
|
||||||
+ aio_co_enter(data->ctx, data->co);
|
|
||||||
}
|
|
||||||
|
|
||||||
typedef struct QmpBackupTask {
|
|
||||||
@@ -525,11 +567,12 @@ typedef struct QmpBackupTask {
|
|
||||||
UuidInfo *result;
|
|
||||||
} QmpBackupTask;
|
|
||||||
|
|
||||||
-// assumes the caller holds backup_mutex
|
|
||||||
static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
{
|
|
||||||
assert(qemu_in_coroutine());
|
|
||||||
|
|
||||||
+ qemu_co_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
+
|
|
||||||
QmpBackupTask *task = opaque;
|
|
||||||
|
|
||||||
task->result = NULL; // just to be sure
|
|
||||||
@@ -550,8 +593,9 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
const char *firewall_name = "qemu-server.fw";
|
|
||||||
|
|
||||||
if (backup_state.di_list) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
+ error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"previous backup not finished");
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -618,6 +662,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
di->size = size;
|
|
||||||
total += size;
|
|
||||||
+
|
|
||||||
+ di->completed_ret = INT_MAX;
|
|
||||||
}
|
|
||||||
|
|
||||||
uuid_generate(uuid);
|
|
||||||
@@ -849,6 +895,8 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
backup_state.stat.dirty = total - backup_state.stat.reused;
|
|
||||||
backup_state.stat.transferred = 0;
|
|
||||||
backup_state.stat.zero_bytes = 0;
|
|
||||||
+ backup_state.stat.finishing = false;
|
|
||||||
+ backup_state.stat.starting = true;
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
@@ -863,6 +911,33 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
uuid_info->UUID = uuid_str;
|
|
||||||
|
|
||||||
task->result = uuid_info;
|
|
||||||
+
|
|
||||||
+ /* Run create_backup_jobs_bh outside of coroutine (in BH) but keep
|
|
||||||
+ * backup_mutex locked. This is fine, a CoMutex can be held across yield
|
|
||||||
+ * points, and we'll release it as soon as the BH reschedules us.
|
|
||||||
+ */
|
|
||||||
+ CoCtxData waker = {
|
|
||||||
+ .co = qemu_coroutine_self(),
|
|
||||||
+ .ctx = qemu_get_current_aio_context(),
|
|
||||||
+ .data = &local_err,
|
|
||||||
+ };
|
|
||||||
+ aio_bh_schedule_oneshot(waker.ctx, create_backup_jobs_bh, &waker);
|
|
||||||
+ qemu_coroutine_yield();
|
|
||||||
+
|
|
||||||
+ if (local_err) {
|
|
||||||
+ error_propagate(task->errp, local_err);
|
|
||||||
+ goto err;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
+
|
|
||||||
+ qemu_mutex_lock(&backup_state.stat.lock);
|
|
||||||
+ backup_state.stat.starting = false;
|
|
||||||
+ qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
+
|
|
||||||
+ /* start the first job in the transaction */
|
|
||||||
+ job_txn_start_seq(backup_state.txn);
|
|
||||||
+
|
|
||||||
return;
|
|
||||||
|
|
||||||
err_mutex:
|
|
||||||
@@ -885,6 +960,7 @@ err:
|
|
||||||
g_free(di);
|
|
||||||
}
|
|
||||||
g_list_free(di_list);
|
|
||||||
+ backup_state.di_list = NULL;
|
|
||||||
|
|
||||||
if (devs) {
|
|
||||||
g_strfreev(devs);
|
|
||||||
@@ -905,6 +981,8 @@ err:
|
|
||||||
}
|
|
||||||
|
|
||||||
task->result = NULL;
|
|
||||||
+
|
|
||||||
+ qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -958,24 +1036,8 @@ UuidInfo *qmp_backup(
|
|
||||||
.errp = errp,
|
|
||||||
};
|
|
||||||
|
|
||||||
- qemu_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
block_on_coroutine_fn(pvebackup_co_prepare, &task);
|
|
||||||
|
|
||||||
- if (*errp == NULL) {
|
|
||||||
- bool errors = create_backup_jobs();
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
-
|
|
||||||
- if (!errors) {
|
|
||||||
- /* start the first job in the transaction
|
|
||||||
- * note: this might directly enter the job, so we need to do this
|
|
||||||
- * after unlocking the backup_mutex */
|
|
||||||
- job_txn_start_seq(backup_state.txn);
|
|
||||||
- }
|
|
||||||
- } else {
|
|
||||||
- qemu_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
return task.result;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -1027,6 +1089,7 @@ BackupStatus *qmp_query_backup(Error **errp)
|
|
||||||
info->transferred = backup_state.stat.transferred;
|
|
||||||
info->has_reused = true;
|
|
||||||
info->reused = backup_state.stat.reused;
|
|
||||||
+ info->finishing = backup_state.stat.finishing;
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index 170c13984d..a0d1d278e9 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -729,12 +729,15 @@
|
|
||||||
#
|
|
||||||
# @uuid: uuid for this backup job
|
|
||||||
#
|
|
||||||
+# @finishing: if status='active' and finishing=true, then the backup process is
|
|
||||||
+# waiting for the target to finish.
|
|
||||||
+#
|
|
||||||
##
|
|
||||||
{ 'struct': 'BackupStatus',
|
|
||||||
'data': {'*status': 'str', '*errmsg': 'str', '*total': 'int', '*dirty': 'int',
|
|
||||||
'*transferred': 'int', '*zero-bytes': 'int', '*reused': 'int',
|
|
||||||
'*start-time': 'int', '*end-time': 'int',
|
|
||||||
- '*backup-file': 'str', '*uuid': 'str' } }
|
|
||||||
+ '*backup-file': 'str', '*uuid': 'str', 'finishing': 'bool' } }
|
|
||||||
|
|
||||||
##
|
|
||||||
# @BackupFormat:
|
|
|
@ -11,10 +11,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/block/stream.c b/block/stream.c
|
diff --git a/block/stream.c b/block/stream.c
|
||||||
index 97bee482dc..50093c9f57 100644
|
index 7031eef12b..d2da83ae7c 100644
|
||||||
--- a/block/stream.c
|
--- a/block/stream.c
|
||||||
+++ b/block/stream.c
|
+++ b/block/stream.c
|
||||||
@@ -28,7 +28,7 @@ enum {
|
@@ -27,7 +27,7 @@ enum {
|
||||||
* large enough to process multiple clusters in a single call, so
|
* large enough to process multiple clusters in a single call, so
|
||||||
* that populating contiguous regions of the image is efficient.
|
* that populating contiguous regions of the image is efficient.
|
||||||
*/
|
*/
|
|
@ -19,23 +19,33 @@ well.
|
||||||
This only worked if the target supports backing images, so up until now
|
This only worked if the target supports backing images, so up until now
|
||||||
only for qcow2, with alloc-track any driver for the target can be used.
|
only for qcow2, with alloc-track any driver for the target can be used.
|
||||||
|
|
||||||
If 'auto-remove' is set, alloc-track will automatically detach itself
|
Replacing the node cannot be done in the
|
||||||
once the backing image is removed. It will be replaced by 'file'.
|
track_co_change_backing_file() callback, because replacing a node
|
||||||
|
cannot happen in a coroutine and requires the block graph lock
|
||||||
|
exclusively. Could either become a special option for the stream job,
|
||||||
|
or maybe the upcoming blockdev-replace QMP command can be used in the
|
||||||
|
future.
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
[FE: adapt to changed function signatures
|
||||||
|
make error return value consistent with QEMU
|
||||||
|
avoid premature break during read
|
||||||
|
adhere to block graph lock requirements]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/alloc-track.c | 345 ++++++++++++++++++++++++++++++++++++++++++++
|
block/alloc-track.c | 366 ++++++++++++++++++++++++++++++++++++++++++++
|
||||||
block/meson.build | 1 +
|
block/meson.build | 1 +
|
||||||
2 files changed, 346 insertions(+)
|
block/stream.c | 34 ++++
|
||||||
|
3 files changed, 401 insertions(+)
|
||||||
create mode 100644 block/alloc-track.c
|
create mode 100644 block/alloc-track.c
|
||||||
|
|
||||||
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..35f2737c89
|
index 0000000000..b9f8ea9137
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/alloc-track.c
|
+++ b/block/alloc-track.c
|
||||||
@@ -0,0 +1,345 @@
|
@@ -0,0 +1,366 @@
|
||||||
+/*
|
+/*
|
||||||
+ * Node to allow backing images to be applied to any node. Assumes a blank
|
+ * Node to allow backing images to be applied to any node. Assumes a blank
|
||||||
+ * image to begin with, only new writes are tracked as allocated, thus this
|
+ * image to begin with, only new writes are tracked as allocated, thus this
|
||||||
|
@ -51,9 +61,12 @@ index 0000000000..35f2737c89
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include "qapi/error.h"
|
+#include "qapi/error.h"
|
||||||
+#include "block/block_int.h"
|
+#include "block/block_int.h"
|
||||||
|
+#include "block/dirty-bitmap.h"
|
||||||
|
+#include "block/graph-lock.h"
|
||||||
+#include "qapi/qmp/qdict.h"
|
+#include "qapi/qmp/qdict.h"
|
||||||
+#include "qapi/qmp/qstring.h"
|
+#include "qapi/qmp/qstring.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
|
+#include "qemu/error-report.h"
|
||||||
+#include "qemu/option.h"
|
+#include "qemu/option.h"
|
||||||
+#include "qemu/module.h"
|
+#include "qemu/module.h"
|
||||||
+#include "sysemu/block-backend.h"
|
+#include "sysemu/block-backend.h"
|
||||||
|
@ -62,12 +75,12 @@ index 0000000000..35f2737c89
|
||||||
+
|
+
|
||||||
+typedef enum DropState {
|
+typedef enum DropState {
|
||||||
+ DropNone,
|
+ DropNone,
|
||||||
+ DropRequested,
|
|
||||||
+ DropInProgress,
|
+ DropInProgress,
|
||||||
+} DropState;
|
+} DropState;
|
||||||
+
|
+
|
||||||
+typedef struct {
|
+typedef struct {
|
||||||
+ BdrvDirtyBitmap *bitmap;
|
+ BdrvDirtyBitmap *bitmap;
|
||||||
|
+ uint64_t granularity;
|
||||||
+ DropState drop_state;
|
+ DropState drop_state;
|
||||||
+ bool auto_remove;
|
+ bool auto_remove;
|
||||||
+} BDRVAllocTrackState;
|
+} BDRVAllocTrackState;
|
||||||
|
@ -86,26 +99,29 @@ index 0000000000..35f2737c89
|
||||||
+ },
|
+ },
|
||||||
+};
|
+};
|
||||||
+
|
+
|
||||||
+static void track_refresh_limits(BlockDriverState *bs, Error **errp)
|
+static void GRAPH_RDLOCK
|
||||||
|
+track_refresh_limits(BlockDriverState *bs, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ BlockDriverInfo bdi;
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
+
|
+
|
||||||
+ if (!bs->file) {
|
+ if (!bs->file) {
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ /* always use alignment from underlying write device so RMW cycle for
|
+ /*
|
||||||
+ * bdrv_pwritev reads data from our backing via track_co_preadv (no partial
|
+ * Always use alignment from underlying write device so RMW cycle for
|
||||||
+ * cluster allocation in 'file') */
|
+ * bdrv_pwritev reads data from our backing via track_co_preadv. Also use at
|
||||||
+ bdrv_get_info(bs->file->bs, &bdi);
|
+ * least the bitmap granularity.
|
||||||
|
+ */
|
||||||
+ bs->bl.request_alignment = MAX(bs->file->bs->bl.request_alignment,
|
+ bs->bl.request_alignment = MAX(bs->file->bs->bl.request_alignment,
|
||||||
+ MAX(bdi.cluster_size, BDRV_SECTOR_SIZE));
|
+ s->granularity);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int track_open(BlockDriverState *bs, QDict *options, int flags,
|
+static int track_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
+ Error **errp)
|
+ Error **errp)
|
||||||
+{
|
+{
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
|
+ BdrvChild *file = NULL;
|
||||||
+ QemuOpts *opts;
|
+ QemuOpts *opts;
|
||||||
+ Error *local_err = NULL;
|
+ Error *local_err = NULL;
|
||||||
+ int ret = 0;
|
+ int ret = 0;
|
||||||
|
@ -121,18 +137,45 @@ index 0000000000..35f2737c89
|
||||||
+ s->auto_remove = qemu_opt_get_bool(opts, TRACK_OPT_AUTO_REMOVE, false);
|
+ s->auto_remove = qemu_opt_get_bool(opts, TRACK_OPT_AUTO_REMOVE, false);
|
||||||
+
|
+
|
||||||
+ /* open the target (write) node, backing will be attached by block layer */
|
+ /* open the target (write) node, backing will be attached by block layer */
|
||||||
+ bs->file = bdrv_open_child(NULL, options, "file", bs, &child_of_bds,
|
+ file = bdrv_open_child(NULL, options, "file", bs, &child_of_bds,
|
||||||
+ BDRV_CHILD_DATA | BDRV_CHILD_METADATA, false,
|
+ BDRV_CHILD_DATA | BDRV_CHILD_METADATA, false,
|
||||||
+ &local_err);
|
+ &local_err);
|
||||||
|
+ bdrv_graph_wrlock();
|
||||||
|
+ bs->file = file;
|
||||||
|
+ bdrv_graph_wrunlock();
|
||||||
+ if (local_err) {
|
+ if (local_err) {
|
||||||
+ ret = -EINVAL;
|
+ ret = -EINVAL;
|
||||||
+ error_propagate(errp, local_err);
|
+ error_propagate(errp, local_err);
|
||||||
+ goto fail;
|
+ goto fail;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
|
+ bdrv_graph_rdlock_main_loop();
|
||||||
|
+ BlockDriverInfo bdi = {0};
|
||||||
|
+ ret = bdrv_get_info(bs->file->bs, &bdi);
|
||||||
|
+ if (ret < 0) {
|
||||||
|
+ /*
|
||||||
|
+ * Not a hard failure. Worst that can happen is partial cluster
|
||||||
|
+ * allocation in the write target. However, the driver here returns its
|
||||||
|
+ * allocation status based on the dirty bitmap, so any other data that
|
||||||
|
+ * maps to such a cluster will still be copied later by a stream job (or
|
||||||
|
+ * during writes to that cluster).
|
||||||
|
+ */
|
||||||
|
+ warn_report("alloc-track: unable to query cluster size for write target: %s",
|
||||||
|
+ strerror(ret));
|
||||||
|
+ }
|
||||||
|
+ ret = 0;
|
||||||
|
+ /*
|
||||||
|
+ * Always consider alignment from underlying write device so RMW cycle for
|
||||||
|
+ * bdrv_pwritev reads data from our backing via track_co_preadv. Also try to
|
||||||
|
+ * avoid partial cluster allocation in the write target by considering the
|
||||||
|
+ * cluster size.
|
||||||
|
+ */
|
||||||
|
+ s->granularity = MAX(bs->file->bs->bl.request_alignment,
|
||||||
|
+ MAX(bdi.cluster_size, BDRV_SECTOR_SIZE));
|
||||||
+ track_refresh_limits(bs, errp);
|
+ track_refresh_limits(bs, errp);
|
||||||
+ uint64_t gran = bs->bl.request_alignment;
|
+ s->bitmap = bdrv_create_dirty_bitmap(bs->file->bs, s->granularity, NULL,
|
||||||
+ s->bitmap = bdrv_create_dirty_bitmap(bs->file->bs, gran, NULL, &local_err);
|
+ &local_err);
|
||||||
|
+ bdrv_graph_rdunlock_main_loop();
|
||||||
+ if (local_err) {
|
+ if (local_err) {
|
||||||
+ ret = -EIO;
|
+ ret = -EIO;
|
||||||
+ error_propagate(errp, local_err);
|
+ error_propagate(errp, local_err);
|
||||||
|
@ -143,7 +186,9 @@ index 0000000000..35f2737c89
|
||||||
+
|
+
|
||||||
+fail:
|
+fail:
|
||||||
+ if (ret < 0) {
|
+ if (ret < 0) {
|
||||||
|
+ bdrv_graph_wrlock();
|
||||||
+ bdrv_unref_child(bs, bs->file);
|
+ bdrv_unref_child(bs, bs->file);
|
||||||
|
+ bdrv_graph_wrunlock();
|
||||||
+ if (s->bitmap) {
|
+ if (s->bitmap) {
|
||||||
+ bdrv_release_dirty_bitmap(s->bitmap);
|
+ bdrv_release_dirty_bitmap(s->bitmap);
|
||||||
+ }
|
+ }
|
||||||
|
@ -160,13 +205,15 @@ index 0000000000..35f2737c89
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int64_t track_getlength(BlockDriverState *bs)
|
+static coroutine_fn int64_t GRAPH_RDLOCK
|
||||||
|
+track_co_getlength(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_getlength(bs->file->bs);
|
+ return bdrv_co_getlength(bs->file->bs);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn track_co_preadv(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags)
|
+track_co_preadv(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
+ QEMUIOVector local_qiov;
|
+ QEMUIOVector local_qiov;
|
||||||
|
@ -177,6 +224,11 @@ index 0000000000..35f2737c89
|
||||||
+ int64_t local_bytes;
|
+ int64_t local_bytes;
|
||||||
+ bool alloc;
|
+ bool alloc;
|
||||||
+
|
+
|
||||||
|
+ if (offset < 0 || bytes < 0) {
|
||||||
|
+ fprintf(stderr, "unexpected negative 'offset' or 'bytes' value!\n");
|
||||||
|
+ return -EIO;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
+ /* a read request can span multiple granularity-sized chunks, and can thus
|
+ /* a read request can span multiple granularity-sized chunks, and can thus
|
||||||
+ * contain blocks with different allocation status - we could just iterate
|
+ * contain blocks with different allocation status - we could just iterate
|
||||||
+ * granularity-wise, but for better performance use bdrv_dirty_bitmap_next_X
|
+ * granularity-wise, but for better performance use bdrv_dirty_bitmap_next_X
|
||||||
|
@ -207,7 +259,8 @@ index 0000000000..35f2737c89
|
||||||
+ ret = bdrv_co_preadv(bs->backing, local_offset, local_bytes,
|
+ ret = bdrv_co_preadv(bs->backing, local_offset, local_bytes,
|
||||||
+ &local_qiov, flags);
|
+ &local_qiov, flags);
|
||||||
+ } else {
|
+ } else {
|
||||||
+ ret = qemu_iovec_memset(&local_qiov, cur_offset, 0, local_bytes);
|
+ qemu_iovec_memset(&local_qiov, cur_offset, 0, local_bytes);
|
||||||
|
+ ret = 0;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (ret != 0) {
|
+ if (ret != 0) {
|
||||||
|
@ -218,36 +271,39 @@ index 0000000000..35f2737c89
|
||||||
+ return ret;
|
+ return ret;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn track_co_pwritev(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags)
|
+track_co_pwritev(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ QEMUIOVector *qiov, BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_pwritev(bs->file, offset, bytes, qiov, flags);
|
+ return bdrv_co_pwritev(bs->file, offset, bytes, qiov, flags);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn track_co_pwrite_zeroes(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ int64_t offset, int count, BdrvRequestFlags flags)
|
+track_co_pwrite_zeroes(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
+ BdrvRequestFlags flags)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_pwrite_zeroes(bs->file, offset, count, flags);
|
+ return bdrv_co_pwrite_zeroes(bs->file, offset, bytes, flags);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn track_co_pdiscard(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ int64_t offset, int count)
|
+track_co_pdiscard(BlockDriverState *bs, int64_t offset, int64_t bytes)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_pdiscard(bs->file, offset, count);
|
+ return bdrv_co_pdiscard(bs->file, offset, bytes);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static coroutine_fn int track_co_flush(BlockDriverState *bs)
|
+static coroutine_fn int GRAPH_RDLOCK
|
||||||
|
+track_co_flush(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ return bdrv_co_flush(bs->file->bs);
|
+ return bdrv_co_flush(bs->file->bs);
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static int coroutine_fn track_co_block_status(BlockDriverState *bs,
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
+ bool want_zero,
|
+track_co_block_status(BlockDriverState *bs, bool want_zero,
|
||||||
+ int64_t offset,
|
+ int64_t offset,
|
||||||
+ int64_t bytes,
|
+ int64_t bytes,
|
||||||
+ int64_t *pnum,
|
+ int64_t *pnum,
|
||||||
+ int64_t *map,
|
+ int64_t *map,
|
||||||
+ BlockDriverState **file)
|
+ BlockDriverState **file)
|
||||||
+{
|
+{
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
+
|
+
|
||||||
|
@ -273,10 +329,10 @@ index 0000000000..35f2737c89
|
||||||
+ return 0;
|
+ return 0;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void track_child_perm(BlockDriverState *bs, BdrvChild *c,
|
+static void GRAPH_RDLOCK
|
||||||
+ BdrvChildRole role, BlockReopenQueue *reopen_queue,
|
+track_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
+ uint64_t perm, uint64_t shared,
|
+ BlockReopenQueue *reopen_queue, uint64_t perm, uint64_t shared,
|
||||||
+ uint64_t *nperm, uint64_t *nshared)
|
+ uint64_t *nperm, uint64_t *nshared)
|
||||||
+{
|
+{
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
+
|
+
|
||||||
|
@ -299,53 +355,28 @@ index 0000000000..35f2737c89
|
||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+static void track_drop(void *opaque)
|
+static int coroutine_fn GRAPH_RDLOCK
|
||||||
|
+track_co_change_backing_file(BlockDriverState *bs, const char *backing_file,
|
||||||
|
+ const char *backing_fmt)
|
||||||
+{
|
+{
|
||||||
+ BlockDriverState *bs = (BlockDriverState*)opaque;
|
+ /*
|
||||||
+ BlockDriverState *file = bs->file->bs;
|
+ * Note that the actual backing file graph change is already done in the
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
+ * stream job itself with bdrv_set_backing_hd_drained(), so no need to
|
||||||
+
|
+ * actually do anything here. But still needs to be implemented, to make
|
||||||
+ assert(file);
|
+ * our caller (i.e. bdrv_co_change_backing_file() do the right thing).
|
||||||
+
|
+ *
|
||||||
+ /* we rely on the fact that we're not used anywhere else, so let's wait
|
+ * FIXME
|
||||||
+ * until we're only used once - in the drive connected to the guest (and one
|
+ * We'd like to auto-remove ourselves from the block graph, but it cannot
|
||||||
+ * ref is held by bdrv_ref in track_change_backing_file) */
|
+ * be done from a coroutine. Currently done in the stream job, where it
|
||||||
+ if (bs->refcnt > 2) {
|
+ * kinda fits better, but in the long-term, a special parameter would be
|
||||||
+ aio_bh_schedule_oneshot(qemu_get_aio_context(), track_drop, opaque);
|
+ * nice (or done via qemu-server via upcoming blockdev-replace QMP command).
|
||||||
+ return;
|
+ */
|
||||||
+ }
|
+ if (backing_file == NULL) {
|
||||||
+ AioContext *aio_context = bdrv_get_aio_context(bs);
|
+ BDRVAllocTrackState *s = bs->opaque;
|
||||||
+ aio_context_acquire(aio_context);
|
+ bdrv_drained_begin(bs);
|
||||||
+
|
+ s->drop_state = DropInProgress;
|
||||||
+ bdrv_drained_begin(bs);
|
+ bdrv_child_refresh_perms(bs, bs->file, &error_abort);
|
||||||
+
|
+ bdrv_drained_end(bs);
|
||||||
+ /* now that we're drained, we can safely set 'DropInProgress' */
|
|
||||||
+ s->drop_state = DropInProgress;
|
|
||||||
+ bdrv_child_refresh_perms(bs, bs->file, &error_abort);
|
|
||||||
+
|
|
||||||
+ bdrv_replace_node(bs, file, &error_abort);
|
|
||||||
+ bdrv_set_backing_hd(bs, NULL, &error_abort);
|
|
||||||
+ bdrv_drained_end(bs);
|
|
||||||
+ bdrv_unref(bs);
|
|
||||||
+ aio_context_release(aio_context);
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static int track_change_backing_file(BlockDriverState *bs,
|
|
||||||
+ const char *backing_file,
|
|
||||||
+ const char *backing_fmt)
|
|
||||||
+{
|
|
||||||
+ BDRVAllocTrackState *s = bs->opaque;
|
|
||||||
+ if (s->auto_remove && s->drop_state == DropNone &&
|
|
||||||
+ backing_file == NULL && backing_fmt == NULL)
|
|
||||||
+ {
|
|
||||||
+ /* backing file has been disconnected, there's no longer any use for
|
|
||||||
+ * this node, so let's remove ourselves from the block graph - we need
|
|
||||||
+ * to schedule this for later however, since when this function is
|
|
||||||
+ * called, the blockjob modifying us is probably not done yet and has a
|
|
||||||
+ * blocker on 'bs' */
|
|
||||||
+ s->drop_state = DropRequested;
|
|
||||||
+ bdrv_ref(bs);
|
|
||||||
+ aio_bh_schedule_oneshot(qemu_get_aio_context(), track_drop, (void*)bs);
|
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ return 0;
|
+ return 0;
|
||||||
|
@ -357,7 +388,7 @@ index 0000000000..35f2737c89
|
||||||
+
|
+
|
||||||
+ .bdrv_file_open = track_open,
|
+ .bdrv_file_open = track_open,
|
||||||
+ .bdrv_close = track_close,
|
+ .bdrv_close = track_close,
|
||||||
+ .bdrv_getlength = track_getlength,
|
+ .bdrv_co_getlength = track_co_getlength,
|
||||||
+ .bdrv_child_perm = track_child_perm,
|
+ .bdrv_child_perm = track_child_perm,
|
||||||
+ .bdrv_refresh_limits = track_refresh_limits,
|
+ .bdrv_refresh_limits = track_refresh_limits,
|
||||||
+
|
+
|
||||||
|
@ -372,7 +403,7 @@ index 0000000000..35f2737c89
|
||||||
+ .supports_backing = true,
|
+ .supports_backing = true,
|
||||||
+
|
+
|
||||||
+ .bdrv_co_block_status = track_co_block_status,
|
+ .bdrv_co_block_status = track_co_block_status,
|
||||||
+ .bdrv_change_backing_file = track_change_backing_file,
|
+ .bdrv_co_change_backing_file = track_co_change_backing_file,
|
||||||
+};
|
+};
|
||||||
+
|
+
|
||||||
+static void bdrv_alloc_track_init(void)
|
+static void bdrv_alloc_track_init(void)
|
||||||
|
@ -382,7 +413,7 @@ index 0000000000..35f2737c89
|
||||||
+
|
+
|
||||||
+block_init(bdrv_alloc_track_init);
|
+block_init(bdrv_alloc_track_init);
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index e3ed5ac97c..d1ee260048 100644
|
index 1945e04eeb..2873f3a25a 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -2,6 +2,7 @@ block_ss.add(genh)
|
@@ -2,6 +2,7 @@ block_ss.add(genh)
|
||||||
|
@ -393,3 +424,48 @@ index e3ed5ac97c..d1ee260048 100644
|
||||||
'amend.c',
|
'amend.c',
|
||||||
'backup.c',
|
'backup.c',
|
||||||
'backup-dump.c',
|
'backup-dump.c',
|
||||||
|
diff --git a/block/stream.c b/block/stream.c
|
||||||
|
index d2da83ae7c..f941cba14e 100644
|
||||||
|
--- a/block/stream.c
|
||||||
|
+++ b/block/stream.c
|
||||||
|
@@ -120,6 +120,40 @@ static int stream_prepare(Job *job)
|
||||||
|
ret = -EPERM;
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
+
|
||||||
|
+ /*
|
||||||
|
+ * This cannot be done in the co_change_backing_file callback, because
|
||||||
|
+ * bdrv_replace_node() cannot be done in a coroutine. The latter also
|
||||||
|
+ * requires the graph lock exclusively. Only required for the
|
||||||
|
+ * alloc-track driver.
|
||||||
|
+ *
|
||||||
|
+ * The long-term plan is to either have an explicit parameter for the
|
||||||
|
+ * stream job or use the upcoming blockdev-replace QMP command.
|
||||||
|
+ */
|
||||||
|
+ if (base_id == NULL && strcmp(unfiltered_bs->drv->format_name, "alloc-track") == 0) {
|
||||||
|
+ BlockDriverState *file_bs;
|
||||||
|
+
|
||||||
|
+ bdrv_graph_rdlock_main_loop();
|
||||||
|
+ file_bs = unfiltered_bs->file->bs;
|
||||||
|
+ bdrv_graph_rdunlock_main_loop();
|
||||||
|
+
|
||||||
|
+ bdrv_ref(unfiltered_bs); // unrefed by bdrv_replace_node()
|
||||||
|
+ bdrv_drained_begin(file_bs);
|
||||||
|
+ bdrv_graph_wrlock();
|
||||||
|
+
|
||||||
|
+ bdrv_replace_node(unfiltered_bs, file_bs, &local_err);
|
||||||
|
+
|
||||||
|
+ bdrv_graph_wrunlock();
|
||||||
|
+ bdrv_drained_end(file_bs);
|
||||||
|
+ bdrv_unref(unfiltered_bs);
|
||||||
|
+
|
||||||
|
+ if (local_err) {
|
||||||
|
+ error_prepend(&local_err, "failed to replace alloc-track node: ");
|
||||||
|
+ error_report_err(local_err);
|
||||||
|
+ ret = -EPERM;
|
||||||
|
+ goto out;
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
out:
|
81
debian/patches/pve/0039-Revert-block-rbd-workaround-for-ceph-issue-53784.patch
vendored
Normal file
81
debian/patches/pve/0039-Revert-block-rbd-workaround-for-ceph-issue-53784.patch
vendored
Normal file
|
@ -0,0 +1,81 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 23 Jun 2022 14:00:05 +0200
|
||||||
|
Subject: [PATCH] Revert "block/rbd: workaround for ceph issue #53784"
|
||||||
|
|
||||||
|
This reverts commit fc176116cdea816ceb8dd969080b2b95f58edbc0 in
|
||||||
|
preparation to revert 0347a8fd4c3faaedf119be04c197804be40a384b.
|
||||||
|
|
||||||
|
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/rbd.c | 42 ++----------------------------------------
|
||||||
|
1 file changed, 2 insertions(+), 40 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
|
index 63f60d41be..367db42dce 100644
|
||||||
|
--- a/block/rbd.c
|
||||||
|
+++ b/block/rbd.c
|
||||||
|
@@ -1515,7 +1515,6 @@ static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
||||||
|
int status, r;
|
||||||
|
RBDDiffIterateReq req = { .offs = offset };
|
||||||
|
uint64_t features, flags;
|
||||||
|
- uint64_t head = 0;
|
||||||
|
|
||||||
|
assert(offset + bytes <= s->image_size);
|
||||||
|
|
||||||
|
@@ -1543,43 +1542,7 @@ static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
||||||
|
return status;
|
||||||
|
}
|
||||||
|
|
||||||
|
-#if LIBRBD_VERSION_CODE < LIBRBD_VERSION(1, 17, 0)
|
||||||
|
- /*
|
||||||
|
- * librbd had a bug until early 2022 that affected all versions of ceph that
|
||||||
|
- * supported fast-diff. This bug results in reporting of incorrect offsets
|
||||||
|
- * if the offset parameter to rbd_diff_iterate2 is not object aligned.
|
||||||
|
- * Work around this bug by rounding down the offset to object boundaries.
|
||||||
|
- * This is OK because we call rbd_diff_iterate2 with whole_object = true.
|
||||||
|
- * However, this workaround only works for non cloned images with default
|
||||||
|
- * striping.
|
||||||
|
- *
|
||||||
|
- * See: https://tracker.ceph.com/issues/53784
|
||||||
|
- */
|
||||||
|
-
|
||||||
|
- /* check if RBD image has non-default striping enabled */
|
||||||
|
- if (features & RBD_FEATURE_STRIPINGV2) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
-#pragma GCC diagnostic push
|
||||||
|
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
|
||||||
|
- /*
|
||||||
|
- * check if RBD image is a clone (= has a parent).
|
||||||
|
- *
|
||||||
|
- * rbd_get_parent_info is deprecated from Nautilus onwards, but the
|
||||||
|
- * replacement rbd_get_parent is not present in Luminous and Mimic.
|
||||||
|
- */
|
||||||
|
- if (rbd_get_parent_info(s->image, NULL, 0, NULL, 0, NULL, 0) != -ENOENT) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
-#pragma GCC diagnostic pop
|
||||||
|
-
|
||||||
|
- head = req.offs & (s->object_size - 1);
|
||||||
|
- req.offs -= head;
|
||||||
|
- bytes += head;
|
||||||
|
-#endif
|
||||||
|
-
|
||||||
|
- r = rbd_diff_iterate2(s->image, NULL, req.offs, bytes, true, true,
|
||||||
|
+ r = rbd_diff_iterate2(s->image, NULL, offset, bytes, true, true,
|
||||||
|
qemu_rbd_diff_iterate_cb, &req);
|
||||||
|
if (r < 0 && r != QEMU_RBD_EXIT_DIFF_ITERATE2) {
|
||||||
|
return status;
|
||||||
|
@@ -1598,8 +1561,7 @@ static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
||||||
|
status = BDRV_BLOCK_ZERO | BDRV_BLOCK_OFFSET_VALID;
|
||||||
|
}
|
||||||
|
|
||||||
|
- assert(req.bytes > head);
|
||||||
|
- *pnum = req.bytes - head;
|
||||||
|
+ *pnum = req.bytes;
|
||||||
|
return status;
|
||||||
|
}
|
||||||
|
|
36
debian/patches/pve/0040-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch
vendored
Normal file
36
debian/patches/pve/0040-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch
vendored
Normal file
|
@ -0,0 +1,36 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 23 Jun 2022 14:00:07 +0200
|
||||||
|
Subject: [PATCH] Revert "block/rbd: fix handling of holes in
|
||||||
|
.bdrv_co_block_status"
|
||||||
|
|
||||||
|
This reverts commit 9e302f64bb407a9bb097b626da97228c2654cfee in
|
||||||
|
preparation to revert 0347a8fd4c3faaedf119be04c197804be40a384b.
|
||||||
|
|
||||||
|
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/rbd.c | 10 +++++-----
|
||||||
|
1 file changed, 5 insertions(+), 5 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
|
index 367db42dce..347b121626 100644
|
||||||
|
--- a/block/rbd.c
|
||||||
|
+++ b/block/rbd.c
|
||||||
|
@@ -1474,11 +1474,11 @@ static int qemu_rbd_diff_iterate_cb(uint64_t offs, size_t len,
|
||||||
|
RBDDiffIterateReq *req = opaque;
|
||||||
|
|
||||||
|
assert(req->offs + req->bytes <= offs);
|
||||||
|
-
|
||||||
|
- /* treat a hole like an unallocated area and bail out */
|
||||||
|
- if (!exists) {
|
||||||
|
- return 0;
|
||||||
|
- }
|
||||||
|
+ /*
|
||||||
|
+ * we do not diff against a snapshot so we should never receive a callback
|
||||||
|
+ * for a hole.
|
||||||
|
+ */
|
||||||
|
+ assert(exists);
|
||||||
|
|
||||||
|
if (!req->exists && offs > req->offs) {
|
||||||
|
/*
|
|
@ -1,598 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Tue, 26 Jan 2021 15:45:30 +0100
|
|
||||||
Subject: [PATCH] PVE: Use coroutine QMP for backup/cancel_backup
|
|
||||||
|
|
||||||
Finally turn backup QMP calls into coroutines, now that it's possible.
|
|
||||||
This has the benefit that calls are asynchronous to the main loop, i.e.
|
|
||||||
long running operations like connecting to a PBS server will no longer
|
|
||||||
hang the VM.
|
|
||||||
|
|
||||||
Additionally, it allows us to get rid of block_on_coroutine_fn, which
|
|
||||||
was always a hacky workaround.
|
|
||||||
|
|
||||||
While we're already spring cleaning, also remove the QmpBackupTask
|
|
||||||
struct, since we can now put the 'prepare' function directly into
|
|
||||||
qmp_backup and thus no longer need those giant walls of text.
|
|
||||||
|
|
||||||
(Note that for our patches to work with 5.2.0 this change is actually
|
|
||||||
required, otherwise monitor_get_fd() fails as we're not in a QMP
|
|
||||||
coroutine, but one we start ourselves - we could of course set the
|
|
||||||
monitor for that coroutine ourselves, but let's just fix it the right
|
|
||||||
way instead)
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/monitor/block-hmp-cmds.c | 4 +-
|
|
||||||
hmp-commands.hx | 2 +
|
|
||||||
proxmox-backup-client.c | 31 -----
|
|
||||||
pve-backup.c | 232 ++++++++++-----------------------
|
|
||||||
qapi/block-core.json | 4 +-
|
|
||||||
5 files changed, 77 insertions(+), 196 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
|
||||||
index 69254396d5..b838586fc0 100644
|
|
||||||
--- a/block/monitor/block-hmp-cmds.c
|
|
||||||
+++ b/block/monitor/block-hmp-cmds.c
|
|
||||||
@@ -1016,7 +1016,7 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
|
|
||||||
g_free(global_snapshots);
|
|
||||||
}
|
|
||||||
|
|
||||||
-void hmp_backup_cancel(Monitor *mon, const QDict *qdict)
|
|
||||||
+void coroutine_fn hmp_backup_cancel(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
Error *error = NULL;
|
|
||||||
|
|
||||||
@@ -1025,7 +1025,7 @@ void hmp_backup_cancel(Monitor *mon, const QDict *qdict)
|
|
||||||
hmp_handle_error(mon, error);
|
|
||||||
}
|
|
||||||
|
|
||||||
-void hmp_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
+void coroutine_fn hmp_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
{
|
|
||||||
Error *error = NULL;
|
|
||||||
|
|
||||||
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
|
||||||
index 7faba36b39..dca4e58858 100644
|
|
||||||
--- a/hmp-commands.hx
|
|
||||||
+++ b/hmp-commands.hx
|
|
||||||
@@ -109,6 +109,7 @@ ERST
|
|
||||||
"\n\t\t\t Use -d to dump data into a directory instead"
|
|
||||||
"\n\t\t\t of using VMA format.",
|
|
||||||
.cmd = hmp_backup,
|
|
||||||
+ .coroutine = true,
|
|
||||||
},
|
|
||||||
|
|
||||||
SRST
|
|
||||||
@@ -122,6 +123,7 @@ ERST
|
|
||||||
.params = "",
|
|
||||||
.help = "cancel the current VM backup",
|
|
||||||
.cmd = hmp_backup_cancel,
|
|
||||||
+ .coroutine = true,
|
|
||||||
},
|
|
||||||
|
|
||||||
SRST
|
|
||||||
diff --git a/proxmox-backup-client.c b/proxmox-backup-client.c
|
|
||||||
index 4ce7bc0b5e..0923037dec 100644
|
|
||||||
--- a/proxmox-backup-client.c
|
|
||||||
+++ b/proxmox-backup-client.c
|
|
||||||
@@ -5,37 +5,6 @@
|
|
||||||
|
|
||||||
/* Proxmox Backup Server client bindings using coroutines */
|
|
||||||
|
|
||||||
-typedef struct BlockOnCoroutineWrapper {
|
|
||||||
- AioContext *ctx;
|
|
||||||
- CoroutineEntry *entry;
|
|
||||||
- void *entry_arg;
|
|
||||||
- bool finished;
|
|
||||||
-} BlockOnCoroutineWrapper;
|
|
||||||
-
|
|
||||||
-static void coroutine_fn block_on_coroutine_wrapper(void *opaque)
|
|
||||||
-{
|
|
||||||
- BlockOnCoroutineWrapper *wrapper = opaque;
|
|
||||||
- wrapper->entry(wrapper->entry_arg);
|
|
||||||
- wrapper->finished = true;
|
|
||||||
- aio_wait_kick();
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
-void block_on_coroutine_fn(CoroutineEntry *entry, void *entry_arg)
|
|
||||||
-{
|
|
||||||
- assert(!qemu_in_coroutine());
|
|
||||||
-
|
|
||||||
- AioContext *ctx = qemu_get_current_aio_context();
|
|
||||||
- BlockOnCoroutineWrapper wrapper = {
|
|
||||||
- .finished = false,
|
|
||||||
- .entry = entry,
|
|
||||||
- .entry_arg = entry_arg,
|
|
||||||
- .ctx = ctx,
|
|
||||||
- };
|
|
||||||
- Coroutine *wrapper_co = qemu_coroutine_create(block_on_coroutine_wrapper, &wrapper);
|
|
||||||
- aio_co_enter(ctx, wrapper_co);
|
|
||||||
- AIO_WAIT_WHILE(ctx, !wrapper.finished);
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
// This is called from another thread, so we use aio_co_schedule()
|
|
||||||
static void proxmox_backup_schedule_wake(void *data) {
|
|
||||||
CoCtxData *waker = (CoCtxData *)data;
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 59ccb38ceb..f858003a06 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -357,7 +357,7 @@ static void job_cancel_bh(void *opaque) {
|
|
||||||
aio_co_enter(data->ctx, data->co);
|
|
||||||
}
|
|
||||||
|
|
||||||
-static void coroutine_fn pvebackup_co_cancel(void *opaque)
|
|
||||||
+void coroutine_fn qmp_backup_cancel(Error **errp)
|
|
||||||
{
|
|
||||||
Error *cancel_err = NULL;
|
|
||||||
error_setg(&cancel_err, "backup canceled");
|
|
||||||
@@ -394,11 +394,6 @@ static void coroutine_fn pvebackup_co_cancel(void *opaque)
|
|
||||||
qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
-void qmp_backup_cancel(Error **errp)
|
|
||||||
-{
|
|
||||||
- block_on_coroutine_fn(pvebackup_co_cancel, NULL);
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
// assumes the caller holds backup_mutex
|
|
||||||
static int coroutine_fn pvebackup_co_add_config(
|
|
||||||
const char *file,
|
|
||||||
@@ -533,50 +528,27 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
aio_co_enter(data->ctx, data->co);
|
|
||||||
}
|
|
||||||
|
|
||||||
-typedef struct QmpBackupTask {
|
|
||||||
- const char *backup_file;
|
|
||||||
- bool has_password;
|
|
||||||
- const char *password;
|
|
||||||
- bool has_keyfile;
|
|
||||||
- const char *keyfile;
|
|
||||||
- bool has_key_password;
|
|
||||||
- const char *key_password;
|
|
||||||
- bool has_backup_id;
|
|
||||||
- const char *backup_id;
|
|
||||||
- bool has_backup_time;
|
|
||||||
- const char *fingerprint;
|
|
||||||
- bool has_fingerprint;
|
|
||||||
- int64_t backup_time;
|
|
||||||
- bool has_use_dirty_bitmap;
|
|
||||||
- bool use_dirty_bitmap;
|
|
||||||
- bool has_format;
|
|
||||||
- BackupFormat format;
|
|
||||||
- bool has_config_file;
|
|
||||||
- const char *config_file;
|
|
||||||
- bool has_firewall_file;
|
|
||||||
- const char *firewall_file;
|
|
||||||
- bool has_devlist;
|
|
||||||
- const char *devlist;
|
|
||||||
- bool has_compress;
|
|
||||||
- bool compress;
|
|
||||||
- bool has_encrypt;
|
|
||||||
- bool encrypt;
|
|
||||||
- bool has_speed;
|
|
||||||
- int64_t speed;
|
|
||||||
- Error **errp;
|
|
||||||
- UuidInfo *result;
|
|
||||||
-} QmpBackupTask;
|
|
||||||
-
|
|
||||||
-static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
+UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
+ const char *backup_file,
|
|
||||||
+ bool has_password, const char *password,
|
|
||||||
+ bool has_keyfile, const char *keyfile,
|
|
||||||
+ bool has_key_password, const char *key_password,
|
|
||||||
+ bool has_fingerprint, const char *fingerprint,
|
|
||||||
+ bool has_backup_id, const char *backup_id,
|
|
||||||
+ bool has_backup_time, int64_t backup_time,
|
|
||||||
+ bool has_use_dirty_bitmap, bool use_dirty_bitmap,
|
|
||||||
+ bool has_compress, bool compress,
|
|
||||||
+ bool has_encrypt, bool encrypt,
|
|
||||||
+ bool has_format, BackupFormat format,
|
|
||||||
+ bool has_config_file, const char *config_file,
|
|
||||||
+ bool has_firewall_file, const char *firewall_file,
|
|
||||||
+ bool has_devlist, const char *devlist,
|
|
||||||
+ bool has_speed, int64_t speed, Error **errp)
|
|
||||||
{
|
|
||||||
assert(qemu_in_coroutine());
|
|
||||||
|
|
||||||
qemu_co_mutex_lock(&backup_state.backup_mutex);
|
|
||||||
|
|
||||||
- QmpBackupTask *task = opaque;
|
|
||||||
-
|
|
||||||
- task->result = NULL; // just to be sure
|
|
||||||
-
|
|
||||||
BlockBackend *blk;
|
|
||||||
BlockDriverState *bs = NULL;
|
|
||||||
const char *backup_dir = NULL;
|
|
||||||
@@ -593,17 +565,17 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
const char *firewall_name = "qemu-server.fw";
|
|
||||||
|
|
||||||
if (backup_state.di_list) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"previous backup not finished");
|
|
||||||
qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
- return;
|
|
||||||
+ return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Todo: try to auto-detect format based on file name */
|
|
||||||
- BackupFormat format = task->has_format ? task->format : BACKUP_FORMAT_VMA;
|
|
||||||
+ format = has_format ? format : BACKUP_FORMAT_VMA;
|
|
||||||
|
|
||||||
- if (task->has_devlist) {
|
|
||||||
- devs = g_strsplit_set(task->devlist, ",;:", -1);
|
|
||||||
+ if (has_devlist) {
|
|
||||||
+ devs = g_strsplit_set(devlist, ",;:", -1);
|
|
||||||
|
|
||||||
gchar **d = devs;
|
|
||||||
while (d && *d) {
|
|
||||||
@@ -611,14 +583,14 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (blk) {
|
|
||||||
bs = blk_bs(blk);
|
|
||||||
if (!bdrv_is_inserted(bs)) {
|
|
||||||
- error_setg(task->errp, QERR_DEVICE_HAS_NO_MEDIUM, *d);
|
|
||||||
+ error_setg(errp, QERR_DEVICE_HAS_NO_MEDIUM, *d);
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
|
||||||
di->bs = bs;
|
|
||||||
di_list = g_list_append(di_list, di);
|
|
||||||
} else {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_DEVICE_NOT_FOUND,
|
|
||||||
+ error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
|
|
||||||
"Device '%s' not found", *d);
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
@@ -641,7 +613,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!di_list) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "empty device list");
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "empty device list");
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -651,13 +623,13 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
while (l) {
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
l = g_list_next(l);
|
|
||||||
- if (bdrv_op_is_blocked(di->bs, BLOCK_OP_TYPE_BACKUP_SOURCE, task->errp)) {
|
|
||||||
+ if (bdrv_op_is_blocked(di->bs, BLOCK_OP_TYPE_BACKUP_SOURCE, errp)) {
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
|
|
||||||
ssize_t size = bdrv_getlength(di->bs);
|
|
||||||
if (size < 0) {
|
|
||||||
- error_setg_errno(task->errp, -di->size, "bdrv_getlength failed");
|
|
||||||
+ error_setg_errno(errp, -di->size, "bdrv_getlength failed");
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
di->size = size;
|
|
||||||
@@ -684,47 +656,44 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (format == BACKUP_FORMAT_PBS) {
|
|
||||||
- if (!task->has_password) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'password'");
|
|
||||||
+ if (!has_password) {
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'password'");
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
- if (!task->has_backup_id) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-id'");
|
|
||||||
+ if (!has_backup_id) {
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-id'");
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
- if (!task->has_backup_time) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-time'");
|
|
||||||
+ if (!has_backup_time) {
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "missing parameter 'backup-time'");
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
int dump_cb_block_size = PROXMOX_BACKUP_DEFAULT_CHUNK_SIZE; // Hardcoded (4M)
|
|
||||||
firewall_name = "fw.conf";
|
|
||||||
|
|
||||||
- bool use_dirty_bitmap = task->has_use_dirty_bitmap && task->use_dirty_bitmap;
|
|
||||||
-
|
|
||||||
-
|
|
||||||
char *pbs_err = NULL;
|
|
||||||
pbs = proxmox_backup_new(
|
|
||||||
- task->backup_file,
|
|
||||||
- task->backup_id,
|
|
||||||
- task->backup_time,
|
|
||||||
+ backup_file,
|
|
||||||
+ backup_id,
|
|
||||||
+ backup_time,
|
|
||||||
dump_cb_block_size,
|
|
||||||
- task->has_password ? task->password : NULL,
|
|
||||||
- task->has_keyfile ? task->keyfile : NULL,
|
|
||||||
- task->has_key_password ? task->key_password : NULL,
|
|
||||||
- task->has_compress ? task->compress : true,
|
|
||||||
- task->has_encrypt ? task->encrypt : task->has_keyfile,
|
|
||||||
- task->has_fingerprint ? task->fingerprint : NULL,
|
|
||||||
+ has_password ? password : NULL,
|
|
||||||
+ has_keyfile ? keyfile : NULL,
|
|
||||||
+ has_key_password ? key_password : NULL,
|
|
||||||
+ has_compress ? compress : true,
|
|
||||||
+ has_encrypt ? encrypt : has_keyfile,
|
|
||||||
+ has_fingerprint ? fingerprint : NULL,
|
|
||||||
&pbs_err);
|
|
||||||
|
|
||||||
if (!pbs) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"proxmox_backup_new failed: %s", pbs_err);
|
|
||||||
proxmox_backup_free_error(pbs_err);
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
- int connect_result = proxmox_backup_co_connect(pbs, task->errp);
|
|
||||||
+ int connect_result = proxmox_backup_co_connect(pbs, errp);
|
|
||||||
if (connect_result < 0)
|
|
||||||
goto err_mutex;
|
|
||||||
|
|
||||||
@@ -743,9 +712,9 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
BdrvDirtyBitmap *bitmap = bdrv_find_dirty_bitmap(di->bs, PBS_BITMAP_NAME);
|
|
||||||
bool expect_only_dirty = false;
|
|
||||||
|
|
||||||
- if (use_dirty_bitmap) {
|
|
||||||
+ if (has_use_dirty_bitmap && use_dirty_bitmap) {
|
|
||||||
if (bitmap == NULL) {
|
|
||||||
- bitmap = bdrv_create_dirty_bitmap(di->bs, dump_cb_block_size, PBS_BITMAP_NAME, task->errp);
|
|
||||||
+ bitmap = bdrv_create_dirty_bitmap(di->bs, dump_cb_block_size, PBS_BITMAP_NAME, errp);
|
|
||||||
if (!bitmap) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
@@ -775,12 +744,12 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
- int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, expect_only_dirty, task->errp);
|
|
||||||
+ int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, expect_only_dirty, errp);
|
|
||||||
if (dev_id < 0) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
- if (!(di->target = bdrv_backup_dump_create(dump_cb_block_size, di->size, pvebackup_co_dump_pbs_cb, di, task->errp))) {
|
|
||||||
+ if (!(di->target = bdrv_backup_dump_create(dump_cb_block_size, di->size, pvebackup_co_dump_pbs_cb, di, errp))) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -794,10 +763,10 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
backup_state.stat.bitmap_list = g_list_append(backup_state.stat.bitmap_list, info);
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_VMA) {
|
|
||||||
- vmaw = vma_writer_create(task->backup_file, uuid, &local_err);
|
|
||||||
+ vmaw = vma_writer_create(backup_file, uuid, &local_err);
|
|
||||||
if (!vmaw) {
|
|
||||||
if (local_err) {
|
|
||||||
- error_propagate(task->errp, local_err);
|
|
||||||
+ error_propagate(errp, local_err);
|
|
||||||
}
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
@@ -808,25 +777,25 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
|
|
||||||
l = g_list_next(l);
|
|
||||||
|
|
||||||
- if (!(di->target = bdrv_backup_dump_create(VMA_CLUSTER_SIZE, di->size, pvebackup_co_dump_vma_cb, di, task->errp))) {
|
|
||||||
+ if (!(di->target = bdrv_backup_dump_create(VMA_CLUSTER_SIZE, di->size, pvebackup_co_dump_vma_cb, di, errp))) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
di->dev_id = vma_writer_register_stream(vmaw, devname, di->size);
|
|
||||||
if (di->dev_id <= 0) {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"register_stream failed");
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else if (format == BACKUP_FORMAT_DIR) {
|
|
||||||
- if (mkdir(task->backup_file, 0640) != 0) {
|
|
||||||
- error_setg_errno(task->errp, errno, "can't create directory '%s'\n",
|
|
||||||
- task->backup_file);
|
|
||||||
+ if (mkdir(backup_file, 0640) != 0) {
|
|
||||||
+ error_setg_errno(errp, errno, "can't create directory '%s'\n",
|
|
||||||
+ backup_file);
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
- backup_dir = task->backup_file;
|
|
||||||
+ backup_dir = backup_file;
|
|
||||||
|
|
||||||
l = di_list;
|
|
||||||
while (l) {
|
|
||||||
@@ -840,34 +809,34 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
bdrv_img_create(di->targetfile, "raw", NULL, NULL, NULL,
|
|
||||||
di->size, flags, false, &local_err);
|
|
||||||
if (local_err) {
|
|
||||||
- error_propagate(task->errp, local_err);
|
|
||||||
+ error_propagate(errp, local_err);
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
di->target = bdrv_open(di->targetfile, NULL, NULL, flags, &local_err);
|
|
||||||
if (!di->target) {
|
|
||||||
- error_propagate(task->errp, local_err);
|
|
||||||
+ error_propagate(errp, local_err);
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
- error_set(task->errp, ERROR_CLASS_GENERIC_ERROR, "unknown backup format");
|
|
||||||
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "unknown backup format");
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
|
||||||
/* add configuration file to archive */
|
|
||||||
- if (task->has_config_file) {
|
|
||||||
- if (pvebackup_co_add_config(task->config_file, config_name, format, backup_dir,
|
|
||||||
- vmaw, pbs, task->errp) != 0) {
|
|
||||||
+ if (has_config_file) {
|
|
||||||
+ if (pvebackup_co_add_config(config_file, config_name, format, backup_dir,
|
|
||||||
+ vmaw, pbs, errp) != 0) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/* add firewall file to archive */
|
|
||||||
- if (task->has_firewall_file) {
|
|
||||||
- if (pvebackup_co_add_config(task->firewall_file, firewall_name, format, backup_dir,
|
|
||||||
- vmaw, pbs, task->errp) != 0) {
|
|
||||||
+ if (has_firewall_file) {
|
|
||||||
+ if (pvebackup_co_add_config(firewall_file, firewall_name, format, backup_dir,
|
|
||||||
+ vmaw, pbs, errp) != 0) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -885,7 +854,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
if (backup_state.stat.backup_file) {
|
|
||||||
g_free(backup_state.stat.backup_file);
|
|
||||||
}
|
|
||||||
- backup_state.stat.backup_file = g_strdup(task->backup_file);
|
|
||||||
+ backup_state.stat.backup_file = g_strdup(backup_file);
|
|
||||||
|
|
||||||
uuid_copy(backup_state.stat.uuid, uuid);
|
|
||||||
uuid_unparse_lower(uuid, backup_state.stat.uuid_str);
|
|
||||||
@@ -900,7 +869,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
|
|
||||||
- backup_state.speed = (task->has_speed && task->speed > 0) ? task->speed : 0;
|
|
||||||
+ backup_state.speed = (has_speed && speed > 0) ? speed : 0;
|
|
||||||
|
|
||||||
backup_state.vmaw = vmaw;
|
|
||||||
backup_state.pbs = pbs;
|
|
||||||
@@ -910,8 +879,6 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
uuid_info = g_malloc0(sizeof(*uuid_info));
|
|
||||||
uuid_info->UUID = uuid_str;
|
|
||||||
|
|
||||||
- task->result = uuid_info;
|
|
||||||
-
|
|
||||||
/* Run create_backup_jobs_bh outside of coroutine (in BH) but keep
|
|
||||||
* backup_mutex locked. This is fine, a CoMutex can be held across yield
|
|
||||||
* points, and we'll release it as soon as the BH reschedules us.
|
|
||||||
@@ -925,7 +892,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
qemu_coroutine_yield();
|
|
||||||
|
|
||||||
if (local_err) {
|
|
||||||
- error_propagate(task->errp, local_err);
|
|
||||||
+ error_propagate(errp, local_err);
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -938,7 +905,7 @@ static void coroutine_fn pvebackup_co_prepare(void *opaque)
|
|
||||||
/* start the first job in the transaction */
|
|
||||||
job_txn_start_seq(backup_state.txn);
|
|
||||||
|
|
||||||
- return;
|
|
||||||
+ return uuid_info;
|
|
||||||
|
|
||||||
err_mutex:
|
|
||||||
qemu_mutex_unlock(&backup_state.stat.lock);
|
|
||||||
@@ -969,7 +936,7 @@ err:
|
|
||||||
if (vmaw) {
|
|
||||||
Error *err = NULL;
|
|
||||||
vma_writer_close(vmaw, &err);
|
|
||||||
- unlink(task->backup_file);
|
|
||||||
+ unlink(backup_file);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (pbs) {
|
|
||||||
@@ -980,65 +947,8 @@ err:
|
|
||||||
rmdir(backup_dir);
|
|
||||||
}
|
|
||||||
|
|
||||||
- task->result = NULL;
|
|
||||||
-
|
|
||||||
qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
- return;
|
|
||||||
-}
|
|
||||||
-
|
|
||||||
-UuidInfo *qmp_backup(
|
|
||||||
- const char *backup_file,
|
|
||||||
- bool has_password, const char *password,
|
|
||||||
- bool has_keyfile, const char *keyfile,
|
|
||||||
- bool has_key_password, const char *key_password,
|
|
||||||
- bool has_fingerprint, const char *fingerprint,
|
|
||||||
- bool has_backup_id, const char *backup_id,
|
|
||||||
- bool has_backup_time, int64_t backup_time,
|
|
||||||
- bool has_use_dirty_bitmap, bool use_dirty_bitmap,
|
|
||||||
- bool has_compress, bool compress,
|
|
||||||
- bool has_encrypt, bool encrypt,
|
|
||||||
- bool has_format, BackupFormat format,
|
|
||||||
- bool has_config_file, const char *config_file,
|
|
||||||
- bool has_firewall_file, const char *firewall_file,
|
|
||||||
- bool has_devlist, const char *devlist,
|
|
||||||
- bool has_speed, int64_t speed, Error **errp)
|
|
||||||
-{
|
|
||||||
- QmpBackupTask task = {
|
|
||||||
- .backup_file = backup_file,
|
|
||||||
- .has_password = has_password,
|
|
||||||
- .password = password,
|
|
||||||
- .has_keyfile = has_keyfile,
|
|
||||||
- .keyfile = keyfile,
|
|
||||||
- .has_key_password = has_key_password,
|
|
||||||
- .key_password = key_password,
|
|
||||||
- .has_fingerprint = has_fingerprint,
|
|
||||||
- .fingerprint = fingerprint,
|
|
||||||
- .has_backup_id = has_backup_id,
|
|
||||||
- .backup_id = backup_id,
|
|
||||||
- .has_backup_time = has_backup_time,
|
|
||||||
- .backup_time = backup_time,
|
|
||||||
- .has_use_dirty_bitmap = has_use_dirty_bitmap,
|
|
||||||
- .use_dirty_bitmap = use_dirty_bitmap,
|
|
||||||
- .has_compress = has_compress,
|
|
||||||
- .compress = compress,
|
|
||||||
- .has_encrypt = has_encrypt,
|
|
||||||
- .encrypt = encrypt,
|
|
||||||
- .has_format = has_format,
|
|
||||||
- .format = format,
|
|
||||||
- .has_config_file = has_config_file,
|
|
||||||
- .config_file = config_file,
|
|
||||||
- .has_firewall_file = has_firewall_file,
|
|
||||||
- .firewall_file = firewall_file,
|
|
||||||
- .has_devlist = has_devlist,
|
|
||||||
- .devlist = devlist,
|
|
||||||
- .has_speed = has_speed,
|
|
||||||
- .speed = speed,
|
|
||||||
- .errp = errp,
|
|
||||||
- };
|
|
||||||
-
|
|
||||||
- block_on_coroutine_fn(pvebackup_co_prepare, &task);
|
|
||||||
-
|
|
||||||
- return task.result;
|
|
||||||
+ return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
BackupStatus *qmp_query_backup(Error **errp)
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index e5de769dc1..afa67c28d2 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -801,7 +801,7 @@
|
|
||||||
'*config-file': 'str',
|
|
||||||
'*firewall-file': 'str',
|
|
||||||
'*devlist': 'str', '*speed': 'int' },
|
|
||||||
- 'returns': 'UuidInfo' }
|
|
||||||
+ 'returns': 'UuidInfo', 'coroutine': true }
|
|
||||||
|
|
||||||
##
|
|
||||||
# @query-backup:
|
|
||||||
@@ -823,7 +823,7 @@
|
|
||||||
# Notes: This command succeeds even if there is no backup process running.
|
|
||||||
#
|
|
||||||
##
|
|
||||||
-{ 'command': 'backup-cancel' }
|
|
||||||
+{ 'command': 'backup-cancel', 'coroutine': true }
|
|
||||||
|
|
||||||
##
|
|
||||||
# @ProxmoxSupportStatus:
|
|
162
debian/patches/pve/0041-Revert-block-rbd-implement-bdrv_co_block_status.patch
vendored
Normal file
162
debian/patches/pve/0041-Revert-block-rbd-implement-bdrv_co_block_status.patch
vendored
Normal file
|
@ -0,0 +1,162 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Tue, 17 May 2022 09:46:02 +0200
|
||||||
|
Subject: [PATCH] Revert "block/rbd: implement bdrv_co_block_status"
|
||||||
|
|
||||||
|
During backup, bdrv_co_block_status is called for each block copy
|
||||||
|
chunk. When RBD is used, the current implementation with
|
||||||
|
rbd_diff_iterate2() using whole_object=true takes about linearly more
|
||||||
|
time, depending on the image size. Since there are linearly more
|
||||||
|
chunks, the slowdown is quadratic, becoming unacceptable for large
|
||||||
|
images (starting somewhere between 500-1000 GiB in my testing).
|
||||||
|
|
||||||
|
This reverts commit 0347a8fd4c3faaedf119be04c197804be40a384b as a
|
||||||
|
stop-gap measure, until it's clear how to make the implemenation
|
||||||
|
more efficient.
|
||||||
|
|
||||||
|
Upstream bug report:
|
||||||
|
https://gitlab.com/qemu-project/qemu/-/issues/1026
|
||||||
|
|
||||||
|
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/rbd.c | 112 ----------------------------------------------------
|
||||||
|
1 file changed, 112 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
|
index 347b121626..e61b359b97 100644
|
||||||
|
--- a/block/rbd.c
|
||||||
|
+++ b/block/rbd.c
|
||||||
|
@@ -108,12 +108,6 @@ typedef struct RBDTask {
|
||||||
|
int64_t ret;
|
||||||
|
} RBDTask;
|
||||||
|
|
||||||
|
-typedef struct RBDDiffIterateReq {
|
||||||
|
- uint64_t offs;
|
||||||
|
- uint64_t bytes;
|
||||||
|
- bool exists;
|
||||||
|
-} RBDDiffIterateReq;
|
||||||
|
-
|
||||||
|
static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
||||||
|
BlockdevOptionsRbd *opts, bool cache,
|
||||||
|
const char *keypairs, const char *secretid,
|
||||||
|
@@ -1460,111 +1454,6 @@ static ImageInfoSpecific *qemu_rbd_get_specific_info(BlockDriverState *bs,
|
||||||
|
return spec_info;
|
||||||
|
}
|
||||||
|
|
||||||
|
-/*
|
||||||
|
- * rbd_diff_iterate2 allows to interrupt the exection by returning a negative
|
||||||
|
- * value in the callback routine. Choose a value that does not conflict with
|
||||||
|
- * an existing exitcode and return it if we want to prematurely stop the
|
||||||
|
- * execution because we detected a change in the allocation status.
|
||||||
|
- */
|
||||||
|
-#define QEMU_RBD_EXIT_DIFF_ITERATE2 -9000
|
||||||
|
-
|
||||||
|
-static int qemu_rbd_diff_iterate_cb(uint64_t offs, size_t len,
|
||||||
|
- int exists, void *opaque)
|
||||||
|
-{
|
||||||
|
- RBDDiffIterateReq *req = opaque;
|
||||||
|
-
|
||||||
|
- assert(req->offs + req->bytes <= offs);
|
||||||
|
- /*
|
||||||
|
- * we do not diff against a snapshot so we should never receive a callback
|
||||||
|
- * for a hole.
|
||||||
|
- */
|
||||||
|
- assert(exists);
|
||||||
|
-
|
||||||
|
- if (!req->exists && offs > req->offs) {
|
||||||
|
- /*
|
||||||
|
- * we started in an unallocated area and hit the first allocated
|
||||||
|
- * block. req->bytes must be set to the length of the unallocated area
|
||||||
|
- * before the allocated area. stop further processing.
|
||||||
|
- */
|
||||||
|
- req->bytes = offs - req->offs;
|
||||||
|
- return QEMU_RBD_EXIT_DIFF_ITERATE2;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- if (req->exists && offs > req->offs + req->bytes) {
|
||||||
|
- /*
|
||||||
|
- * we started in an allocated area and jumped over an unallocated area,
|
||||||
|
- * req->bytes contains the length of the allocated area before the
|
||||||
|
- * unallocated area. stop further processing.
|
||||||
|
- */
|
||||||
|
- return QEMU_RBD_EXIT_DIFF_ITERATE2;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- req->bytes += len;
|
||||||
|
- req->exists = true;
|
||||||
|
-
|
||||||
|
- return 0;
|
||||||
|
-}
|
||||||
|
-
|
||||||
|
-static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
||||||
|
- bool want_zero, int64_t offset,
|
||||||
|
- int64_t bytes, int64_t *pnum,
|
||||||
|
- int64_t *map,
|
||||||
|
- BlockDriverState **file)
|
||||||
|
-{
|
||||||
|
- BDRVRBDState *s = bs->opaque;
|
||||||
|
- int status, r;
|
||||||
|
- RBDDiffIterateReq req = { .offs = offset };
|
||||||
|
- uint64_t features, flags;
|
||||||
|
-
|
||||||
|
- assert(offset + bytes <= s->image_size);
|
||||||
|
-
|
||||||
|
- /* default to all sectors allocated */
|
||||||
|
- status = BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
|
||||||
|
- *map = offset;
|
||||||
|
- *file = bs;
|
||||||
|
- *pnum = bytes;
|
||||||
|
-
|
||||||
|
- /* check if RBD image supports fast-diff */
|
||||||
|
- r = rbd_get_features(s->image, &features);
|
||||||
|
- if (r < 0) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
- if (!(features & RBD_FEATURE_FAST_DIFF)) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- /* check if RBD fast-diff result is valid */
|
||||||
|
- r = rbd_get_flags(s->image, &flags);
|
||||||
|
- if (r < 0) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
- if (flags & RBD_FLAG_FAST_DIFF_INVALID) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- r = rbd_diff_iterate2(s->image, NULL, offset, bytes, true, true,
|
||||||
|
- qemu_rbd_diff_iterate_cb, &req);
|
||||||
|
- if (r < 0 && r != QEMU_RBD_EXIT_DIFF_ITERATE2) {
|
||||||
|
- return status;
|
||||||
|
- }
|
||||||
|
- assert(req.bytes <= bytes);
|
||||||
|
- if (!req.exists) {
|
||||||
|
- if (r == 0) {
|
||||||
|
- /*
|
||||||
|
- * rbd_diff_iterate2 does not invoke callbacks for unallocated
|
||||||
|
- * areas. This here catches the case where no callback was
|
||||||
|
- * invoked at all (req.bytes == 0).
|
||||||
|
- */
|
||||||
|
- assert(req.bytes == 0);
|
||||||
|
- req.bytes = bytes;
|
||||||
|
- }
|
||||||
|
- status = BDRV_BLOCK_ZERO | BDRV_BLOCK_OFFSET_VALID;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
- *pnum = req.bytes;
|
||||||
|
- return status;
|
||||||
|
-}
|
||||||
|
-
|
||||||
|
static int64_t coroutine_fn qemu_rbd_co_getlength(BlockDriverState *bs)
|
||||||
|
{
|
||||||
|
BDRVRBDState *s = bs->opaque;
|
||||||
|
@@ -1800,7 +1689,6 @@ static BlockDriver bdrv_rbd = {
|
||||||
|
#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES
|
||||||
|
.bdrv_co_pwrite_zeroes = qemu_rbd_co_pwrite_zeroes,
|
||||||
|
#endif
|
||||||
|
- .bdrv_co_block_status = qemu_rbd_co_block_status,
|
||||||
|
|
||||||
|
.bdrv_snapshot_create = qemu_rbd_snap_create,
|
||||||
|
.bdrv_snapshot_delete = qemu_rbd_snap_remove,
|
|
@ -1,98 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 10 Feb 2021 11:07:06 +0100
|
|
||||||
Subject: [PATCH] PBS: add master key support
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
this requires a new enough libproxmox-backup-qemu0, and allows querying
|
|
||||||
from the PVE side to avoid QMP calls with unsupported parameters.
|
|
||||||
|
|
||||||
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/monitor/block-hmp-cmds.c | 1 +
|
|
||||||
pve-backup.c | 3 +++
|
|
||||||
qapi/block-core.json | 7 +++++++
|
|
||||||
3 files changed, 11 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
|
||||||
index b838586fc0..5b52b93232 100644
|
|
||||||
--- a/block/monitor/block-hmp-cmds.c
|
|
||||||
+++ b/block/monitor/block-hmp-cmds.c
|
|
||||||
@@ -1039,6 +1039,7 @@ void coroutine_fn hmp_backup(Monitor *mon, const QDict *qdict)
|
|
||||||
false, NULL, // PBS password
|
|
||||||
false, NULL, // PBS keyfile
|
|
||||||
false, NULL, // PBS key_password
|
|
||||||
+ false, NULL, // PBS master_keyfile
|
|
||||||
false, NULL, // PBS fingerprint
|
|
||||||
false, NULL, // PBS backup-id
|
|
||||||
false, 0, // PBS backup-time
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index f858003a06..04ebfc1e33 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -533,6 +533,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
bool has_password, const char *password,
|
|
||||||
bool has_keyfile, const char *keyfile,
|
|
||||||
bool has_key_password, const char *key_password,
|
|
||||||
+ bool has_master_keyfile, const char *master_keyfile,
|
|
||||||
bool has_fingerprint, const char *fingerprint,
|
|
||||||
bool has_backup_id, const char *backup_id,
|
|
||||||
bool has_backup_time, int64_t backup_time,
|
|
||||||
@@ -681,6 +682,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
has_password ? password : NULL,
|
|
||||||
has_keyfile ? keyfile : NULL,
|
|
||||||
has_key_password ? key_password : NULL,
|
|
||||||
+ has_master_keyfile ? master_keyfile : NULL,
|
|
||||||
has_compress ? compress : true,
|
|
||||||
has_encrypt ? encrypt : has_keyfile,
|
|
||||||
has_fingerprint ? fingerprint : NULL,
|
|
||||||
@@ -1044,5 +1046,6 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
|
||||||
ret->pbs_dirty_bitmap_savevm = true;
|
|
||||||
ret->pbs_dirty_bitmap_migration = true;
|
|
||||||
ret->query_bitmap_info = true;
|
|
||||||
+ ret->pbs_masterkey = true;
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
|
||||||
index afa67c28d2..84e4406d21 100644
|
|
||||||
--- a/qapi/block-core.json
|
|
||||||
+++ b/qapi/block-core.json
|
|
||||||
@@ -772,6 +772,8 @@
|
|
||||||
#
|
|
||||||
# @key-password: password for keyfile (optional for format 'pbs')
|
|
||||||
#
|
|
||||||
+# @master-keyfile: PEM-formatted master public keyfile (optional for format 'pbs')
|
|
||||||
+#
|
|
||||||
# @fingerprint: server cert fingerprint (optional for format 'pbs')
|
|
||||||
#
|
|
||||||
# @backup-id: backup ID (required for format 'pbs')
|
|
||||||
@@ -791,6 +793,7 @@
|
|
||||||
'*password': 'str',
|
|
||||||
'*keyfile': 'str',
|
|
||||||
'*key-password': 'str',
|
|
||||||
+ '*master-keyfile': 'str',
|
|
||||||
'*fingerprint': 'str',
|
|
||||||
'*backup-id': 'str',
|
|
||||||
'*backup-time': 'int',
|
|
||||||
@@ -843,6 +846,9 @@
|
|
||||||
# migration cap if this is false/unset may lead
|
|
||||||
# to crashes on migration!
|
|
||||||
#
|
|
||||||
+# @pbs-masterkey: True if the QMP backup call supports the 'master_keyfile'
|
|
||||||
+# parameter.
|
|
||||||
+#
|
|
||||||
# @pbs-library-version: Running version of libproxmox-backup-qemu0 library.
|
|
||||||
#
|
|
||||||
##
|
|
||||||
@@ -851,6 +857,7 @@
|
|
||||||
'query-bitmap-info': 'bool',
|
|
||||||
'pbs-dirty-bitmap-savevm': 'bool',
|
|
||||||
'pbs-dirty-bitmap-migration': 'bool',
|
|
||||||
+ 'pbs-masterkey': 'bool',
|
|
||||||
'pbs-library-version': 'str' } }
|
|
||||||
|
|
||||||
##
|
|
43
debian/patches/pve/0042-alloc-track-error-out-when-auto-remove-is-not-set.patch
vendored
Normal file
43
debian/patches/pve/0042-alloc-track-error-out-when-auto-remove-is-not-set.patch
vendored
Normal file
|
@ -0,0 +1,43 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Tue, 26 Mar 2024 14:57:51 +0100
|
||||||
|
Subject: [PATCH] alloc-track: error out when auto-remove is not set
|
||||||
|
|
||||||
|
Since replacing the node now happens in the stream job, where the
|
||||||
|
option cannot be read from (it's internal to the driver), it will
|
||||||
|
always be treated as on.
|
||||||
|
|
||||||
|
qemu-server will always set it, make sure to have other users notice
|
||||||
|
the change (should they even exist). The option can be fully dropped
|
||||||
|
in the future while adding a version guard in qemu-server.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
block/alloc-track.c | 7 +++++--
|
||||||
|
1 file changed, 5 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
|
index b9f8ea9137..f3ed2935c4 100644
|
||||||
|
--- a/block/alloc-track.c
|
||||||
|
+++ b/block/alloc-track.c
|
||||||
|
@@ -34,7 +34,6 @@ typedef struct {
|
||||||
|
BdrvDirtyBitmap *bitmap;
|
||||||
|
uint64_t granularity;
|
||||||
|
DropState drop_state;
|
||||||
|
- bool auto_remove;
|
||||||
|
} BDRVAllocTrackState;
|
||||||
|
|
||||||
|
static QemuOptsList runtime_opts = {
|
||||||
|
@@ -86,7 +85,11 @@ static int track_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
goto fail;
|
||||||
|
}
|
||||||
|
|
||||||
|
- s->auto_remove = qemu_opt_get_bool(opts, TRACK_OPT_AUTO_REMOVE, false);
|
||||||
|
+ if (!qemu_opt_get_bool(opts, TRACK_OPT_AUTO_REMOVE, false)) {
|
||||||
|
+ error_setg(errp, "alloc-track: requires auto-remove option to be set to on");
|
||||||
|
+ ret = -EINVAL;
|
||||||
|
+ goto fail;
|
||||||
|
+ }
|
||||||
|
|
||||||
|
/* open the target (write) node, backing will be attached by block layer */
|
||||||
|
file = bdrv_open_child(NULL, options, "file", bs, &child_of_bds,
|
|
@ -1,53 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 9 Dec 2020 11:46:57 +0100
|
|
||||||
Subject: [PATCH] PVE: block/pbs: fast-path reads without allocation if
|
|
||||||
possible
|
|
||||||
|
|
||||||
...and switch over to g_malloc/g_free while at it to align with other
|
|
||||||
QEMU code.
|
|
||||||
|
|
||||||
Tracing shows the fast-path is taken almost all the time, though not
|
|
||||||
100% so the slow one is still necessary.
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/pbs.c | 17 ++++++++++++++---
|
|
||||||
1 file changed, 14 insertions(+), 3 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/block/pbs.c b/block/pbs.c
|
|
||||||
index 78dad0dcc4..ac54e816c0 100644
|
|
||||||
--- a/block/pbs.c
|
|
||||||
+++ b/block/pbs.c
|
|
||||||
@@ -200,7 +200,16 @@ static coroutine_fn int pbs_co_preadv(BlockDriverState *bs,
|
|
||||||
BDRVPBSState *s = bs->opaque;
|
|
||||||
int ret;
|
|
||||||
char *pbs_error = NULL;
|
|
||||||
- uint8_t *buf = malloc(bytes);
|
|
||||||
+ uint8_t *buf;
|
|
||||||
+ bool inline_buf = true;
|
|
||||||
+
|
|
||||||
+ /* for single-buffer IO vectors we can fast-path the write directly to it */
|
|
||||||
+ if (qiov->niov == 1 && qiov->iov->iov_len >= bytes) {
|
|
||||||
+ buf = qiov->iov->iov_base;
|
|
||||||
+ } else {
|
|
||||||
+ inline_buf = false;
|
|
||||||
+ buf = g_malloc(bytes);
|
|
||||||
+ }
|
|
||||||
|
|
||||||
ReadCallbackData rcb = {
|
|
||||||
.co = qemu_coroutine_self(),
|
|
||||||
@@ -218,8 +227,10 @@ static coroutine_fn int pbs_co_preadv(BlockDriverState *bs,
|
|
||||||
return -EIO;
|
|
||||||
}
|
|
||||||
|
|
||||||
- qemu_iovec_from_buf(qiov, 0, buf, bytes);
|
|
||||||
- free(buf);
|
|
||||||
+ if (!inline_buf) {
|
|
||||||
+ qemu_iovec_from_buf(qiov, 0, buf, bytes);
|
|
||||||
+ g_free(buf);
|
|
||||||
+ }
|
|
||||||
|
|
||||||
return ret;
|
|
||||||
}
|
|
84
debian/patches/pve/0043-alloc-track-avoid-seemingly-superfluous-child-permis.patch
vendored
Normal file
84
debian/patches/pve/0043-alloc-track-avoid-seemingly-superfluous-child-permis.patch
vendored
Normal file
|
@ -0,0 +1,84 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Wed, 27 Mar 2024 11:15:39 +0100
|
||||||
|
Subject: [PATCH] alloc-track: avoid seemingly superfluous child permission
|
||||||
|
update
|
||||||
|
|
||||||
|
Doesn't seem necessary nowadays (maybe after commit "alloc-track: fix
|
||||||
|
deadlock during drop" where the dropping is not rescheduled and delayed
|
||||||
|
anymore or some upstream change). Should there really be some issue,
|
||||||
|
instead of having a drop state, this could also be just based off the
|
||||||
|
fact whether there is still a backing child.
|
||||||
|
|
||||||
|
Dumping the cumulative (shared) permissions for the BDS with a debug
|
||||||
|
print yields the same values after this patch and with QEMU 8.1,
|
||||||
|
namely 3 and 5.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
block/alloc-track.c | 26 --------------------------
|
||||||
|
1 file changed, 26 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
|
index f3ed2935c4..29138dcc49 100644
|
||||||
|
--- a/block/alloc-track.c
|
||||||
|
+++ b/block/alloc-track.c
|
||||||
|
@@ -25,15 +25,9 @@
|
||||||
|
|
||||||
|
#define TRACK_OPT_AUTO_REMOVE "auto-remove"
|
||||||
|
|
||||||
|
-typedef enum DropState {
|
||||||
|
- DropNone,
|
||||||
|
- DropInProgress,
|
||||||
|
-} DropState;
|
||||||
|
-
|
||||||
|
typedef struct {
|
||||||
|
BdrvDirtyBitmap *bitmap;
|
||||||
|
uint64_t granularity;
|
||||||
|
- DropState drop_state;
|
||||||
|
} BDRVAllocTrackState;
|
||||||
|
|
||||||
|
static QemuOptsList runtime_opts = {
|
||||||
|
@@ -137,8 +131,6 @@ static int track_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
goto fail;
|
||||||
|
}
|
||||||
|
|
||||||
|
- s->drop_state = DropNone;
|
||||||
|
-
|
||||||
|
fail:
|
||||||
|
if (ret < 0) {
|
||||||
|
bdrv_graph_wrlock();
|
||||||
|
@@ -289,18 +281,8 @@ track_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
BlockReopenQueue *reopen_queue, uint64_t perm, uint64_t shared,
|
||||||
|
uint64_t *nperm, uint64_t *nshared)
|
||||||
|
{
|
||||||
|
- BDRVAllocTrackState *s = bs->opaque;
|
||||||
|
-
|
||||||
|
*nshared = BLK_PERM_ALL;
|
||||||
|
|
||||||
|
- /* in case we're currently dropping ourselves, claim to not use any
|
||||||
|
- * permissions at all - which is fine, since from this point on we will
|
||||||
|
- * never issue a read or write anymore */
|
||||||
|
- if (s->drop_state == DropInProgress) {
|
||||||
|
- *nperm = 0;
|
||||||
|
- return;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
if (role & BDRV_CHILD_DATA) {
|
||||||
|
*nperm = perm & DEFAULT_PERM_PASSTHROUGH;
|
||||||
|
} else {
|
||||||
|
@@ -326,14 +308,6 @@ track_co_change_backing_file(BlockDriverState *bs, const char *backing_file,
|
||||||
|
* kinda fits better, but in the long-term, a special parameter would be
|
||||||
|
* nice (or done via qemu-server via upcoming blockdev-replace QMP command).
|
||||||
|
*/
|
||||||
|
- if (backing_file == NULL) {
|
||||||
|
- BDRVAllocTrackState *s = bs->opaque;
|
||||||
|
- bdrv_drained_begin(bs);
|
||||||
|
- s->drop_state = DropInProgress;
|
||||||
|
- bdrv_child_refresh_perms(bs, bs->file, &error_abort);
|
||||||
|
- bdrv_drained_end(bs);
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
133
debian/patches/pve/0044-copy-before-write-allow-specifying-minimum-cluster-s.patch
vendored
Normal file
133
debian/patches/pve/0044-copy-before-write-allow-specifying-minimum-cluster-s.patch
vendored
Normal file
|
@ -0,0 +1,133 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:26 +0200
|
||||||
|
Subject: [PATCH] copy-before-write: allow specifying minimum cluster size
|
||||||
|
|
||||||
|
Useful to make discard-source work in the context of backup fleecing
|
||||||
|
when the fleecing image has a larger granularity than the backup
|
||||||
|
target.
|
||||||
|
|
||||||
|
Copy-before-write operations will use at least this granularity and in
|
||||||
|
particular, discard requests to the source node will too. If the
|
||||||
|
granularity is too small, they will just be aligned down in
|
||||||
|
cbw_co_pdiscard_snapshot() and thus effectively ignored.
|
||||||
|
|
||||||
|
The QAPI uses uint32 so the value will be non-negative, but still fit
|
||||||
|
into a uint64_t.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 17 +++++++++++++----
|
||||||
|
block/copy-before-write.c | 3 ++-
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
qapi/block-core.json | 8 +++++++-
|
||||||
|
4 files changed, 23 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index cc618e4561..12d662e9d4 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -310,6 +310,7 @@ void block_copy_set_copy_opts(BlockCopyState *s, bool use_copy_range,
|
||||||
|
}
|
||||||
|
|
||||||
|
static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
int ret;
|
||||||
|
@@ -335,7 +336,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
"used. If the actual block size of the target exceeds "
|
||||||
|
"this default, the backup may be unusable",
|
||||||
|
BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
- return BLOCK_COPY_CLUSTER_SIZE_DEFAULT;
|
||||||
|
+ return MAX(min_cluster_size, BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
} else if (ret < 0 && !target_does_cow) {
|
||||||
|
error_setg_errno(errp, -ret,
|
||||||
|
"Couldn't determine the cluster size of the target image, "
|
||||||
|
@@ -345,16 +346,18 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
return ret;
|
||||||
|
} else if (ret < 0 && target_does_cow) {
|
||||||
|
/* Not fatal; just trudge on ahead. */
|
||||||
|
- return BLOCK_COPY_CLUSTER_SIZE_DEFAULT;
|
||||||
|
+ return MAX(min_cluster_size, BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
}
|
||||||
|
|
||||||
|
- return MAX(BLOCK_COPY_CLUSTER_SIZE_DEFAULT, bdi.cluster_size);
|
||||||
|
+ return MAX(min_cluster_size,
|
||||||
|
+ MAX(BLOCK_COPY_CLUSTER_SIZE_DEFAULT, bdi.cluster_size));
|
||||||
|
}
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
ERRP_GUARD();
|
||||||
|
@@ -365,7 +368,13 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
|
||||||
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
|
- cluster_size = block_copy_calculate_cluster_size(target->bs, errp);
|
||||||
|
+ if (min_cluster_size && !is_power_of_2(min_cluster_size)) {
|
||||||
|
+ error_setg(errp, "min-cluster-size needs to be a power of 2");
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ cluster_size = block_copy_calculate_cluster_size(target->bs,
|
||||||
|
+ min_cluster_size, errp);
|
||||||
|
if (cluster_size < 0) {
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 853e01a1eb..47b3cdd09f 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -477,7 +477,8 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
|
||||||
|
s->discard_source = flags & BDRV_O_CBW_DISCARD_SOURCE;
|
||||||
|
s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap,
|
||||||
|
- flags & BDRV_O_CBW_DISCARD_SOURCE, errp);
|
||||||
|
+ flags & BDRV_O_CBW_DISCARD_SOURCE,
|
||||||
|
+ opts->min_cluster_size, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index bdc703bacd..77857c6c68 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -28,6 +28,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
/* Function should be called prior any actual copy request */
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 282e2e8a8c..9caf04cbe9 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -4926,12 +4926,18 @@
|
||||||
|
# @on-cbw-error parameter will decide how this failure is handled.
|
||||||
|
# Default 0. (Since 7.1)
|
||||||
|
#
|
||||||
|
+# @min-cluster-size: Minimum size of blocks used by copy-before-write
|
||||||
|
+# operations. Has to be a power of 2. No effect if smaller than
|
||||||
|
+# the maximum of the target's cluster size and 64 KiB. Default 0.
|
||||||
|
+# (Since 8.1)
|
||||||
|
+#
|
||||||
|
# Since: 6.2
|
||||||
|
##
|
||||||
|
{ 'struct': 'BlockdevOptionsCbw',
|
||||||
|
'base': 'BlockdevOptionsGenericFormat',
|
||||||
|
'data': { 'target': 'BlockdevRef', '*bitmap': 'BlockDirtyBitmap',
|
||||||
|
- '*on-cbw-error': 'OnCbwError', '*cbw-timeout': 'uint32' } }
|
||||||
|
+ '*on-cbw-error': 'OnCbwError', '*cbw-timeout': 'uint32',
|
||||||
|
+ '*min-cluster-size': 'uint32' } }
|
||||||
|
|
||||||
|
##
|
||||||
|
# @BlockdevOptions:
|
106
debian/patches/pve/0045-backup-add-minimum-cluster-size-to-performance-optio.patch
vendored
Normal file
106
debian/patches/pve/0045-backup-add-minimum-cluster-size-to-performance-optio.patch
vendored
Normal file
|
@ -0,0 +1,106 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:27 +0200
|
||||||
|
Subject: [PATCH] backup: add minimum cluster size to performance options
|
||||||
|
|
||||||
|
Useful to make discard-source work in the context of backup fleecing
|
||||||
|
when the fleecing image has a larger granularity than the backup
|
||||||
|
target.
|
||||||
|
|
||||||
|
Backup/block-copy will use at least this granularity for copy operations
|
||||||
|
and in particular, discard requests to the backup source will too. If
|
||||||
|
the granularity is too small, they will just be aligned down in
|
||||||
|
cbw_co_pdiscard_snapshot() and thus effectively ignored.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/backup.c | 2 +-
|
||||||
|
block/copy-before-write.c | 2 ++
|
||||||
|
block/copy-before-write.h | 1 +
|
||||||
|
blockdev.c | 3 +++
|
||||||
|
qapi/block-core.json | 9 +++++++--
|
||||||
|
5 files changed, 14 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
|
index 1963e47ab9..fe69723ada 100644
|
||||||
|
--- a/block/backup.c
|
||||||
|
+++ b/block/backup.c
|
||||||
|
@@ -434,7 +434,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
}
|
||||||
|
|
||||||
|
cbw = bdrv_cbw_append(bs, target, filter_node_name, discard_source,
|
||||||
|
- &bcs, errp);
|
||||||
|
+ perf->min_cluster_size, &bcs, errp);
|
||||||
|
if (!cbw) {
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 47b3cdd09f..bba58326d7 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -546,6 +546,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
@@ -564,6 +565,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
}
|
||||||
|
qdict_put_str(opts, "file", bdrv_get_node_name(source));
|
||||||
|
qdict_put_str(opts, "target", bdrv_get_node_name(target));
|
||||||
|
+ qdict_put_int(opts, "min-cluster-size", min_cluster_size);
|
||||||
|
|
||||||
|
top = bdrv_insert_node(source, opts, flags, errp);
|
||||||
|
if (!top) {
|
||||||
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
|
index 01af0cd3c4..dc6cafe7fa 100644
|
||||||
|
--- a/block/copy-before-write.h
|
||||||
|
+++ b/block/copy-before-write.h
|
||||||
|
@@ -40,6 +40,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp);
|
||||||
|
void bdrv_cbw_drop(BlockDriverState *bs);
|
||||||
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
|
index 1054a69279..cbe224387b 100644
|
||||||
|
--- a/blockdev.c
|
||||||
|
+++ b/blockdev.c
|
||||||
|
@@ -2654,6 +2654,9 @@ static BlockJob *do_backup_common(BackupCommon *backup,
|
||||||
|
if (backup->x_perf->has_max_chunk) {
|
||||||
|
perf.max_chunk = backup->x_perf->max_chunk;
|
||||||
|
}
|
||||||
|
+ if (backup->x_perf->has_min_cluster_size) {
|
||||||
|
+ perf.min_cluster_size = backup->x_perf->min_cluster_size;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((backup->sync == MIRROR_SYNC_MODE_BITMAP) ||
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 9caf04cbe9..df934647ed 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -1790,11 +1790,16 @@
|
||||||
|
# it should not be less than job cluster size which is calculated
|
||||||
|
# as maximum of target image cluster size and 64k. Default 0.
|
||||||
|
#
|
||||||
|
+# @min-cluster-size: Minimum size of blocks used by copy-before-write
|
||||||
|
+# and background copy operations. Has to be a power of 2. No
|
||||||
|
+# effect if smaller than the maximum of the target's cluster size
|
||||||
|
+# and 64 KiB. Default 0. (Since 8.1)
|
||||||
|
+#
|
||||||
|
# Since: 6.0
|
||||||
|
##
|
||||||
|
{ 'struct': 'BackupPerf',
|
||||||
|
- 'data': { '*use-copy-range': 'bool',
|
||||||
|
- '*max-workers': 'int', '*max-chunk': 'int64' } }
|
||||||
|
+ 'data': { '*use-copy-range': 'bool', '*max-workers': 'int',
|
||||||
|
+ '*max-chunk': 'int64', '*min-cluster-size': 'uint32' } }
|
||||||
|
|
||||||
|
##
|
||||||
|
# @BackupCommon:
|
|
@ -1,33 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Tue, 2 Mar 2021 16:11:54 +0100
|
|
||||||
Subject: [PATCH] block/io: accept NULL qiov in bdrv_pad_request
|
|
||||||
|
|
||||||
Some operations, e.g. block-stream, perform reads while discarding the
|
|
||||||
results (only copy-on-read matters). In this case they will pass NULL as
|
|
||||||
the target QEMUIOVector, which will however trip bdrv_pad_request, since
|
|
||||||
it wants to extend its passed vector.
|
|
||||||
|
|
||||||
Simply check for NULL and do nothing, there's no reason to pad the
|
|
||||||
target if it will be discarded anyway.
|
|
||||||
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
block/io.c | 4 ++++
|
|
||||||
1 file changed, 4 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/block/io.c b/block/io.c
|
|
||||||
index f38e7f81d8..28c3a712b6 100644
|
|
||||||
--- a/block/io.c
|
|
||||||
+++ b/block/io.c
|
|
||||||
@@ -1764,6 +1764,10 @@ static int bdrv_pad_request(BlockDriverState *bs,
|
|
||||||
{
|
|
||||||
int ret;
|
|
||||||
|
|
||||||
+ if (!qiov) {
|
|
||||||
+ return 0;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
bdrv_check_qiov_request(*offset, *bytes, *qiov, *qiov_offset, &error_abort);
|
|
||||||
|
|
||||||
if (!bdrv_init_padding(bs, *offset, *bytes, pad)) {
|
|
|
@ -0,0 +1,337 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:28 +0200
|
||||||
|
Subject: [PATCH] PVE backup: add fleecing option
|
||||||
|
|
||||||
|
When a fleecing option is given, it is expected that each device has
|
||||||
|
a corresponding "-fleecing" block device already attached, except for
|
||||||
|
EFI disk and TPM state, where fleecing is never used.
|
||||||
|
|
||||||
|
The following graph was adapted from [0] which also contains more
|
||||||
|
details about fleecing.
|
||||||
|
|
||||||
|
[guest]
|
||||||
|
|
|
||||||
|
| root
|
||||||
|
v file
|
||||||
|
[copy-before-write]<------[snapshot-access]
|
||||||
|
| |
|
||||||
|
| file | target
|
||||||
|
v v
|
||||||
|
[source] [fleecing]
|
||||||
|
|
||||||
|
For fleecing, a copy-before-write filter is inserted on top of the
|
||||||
|
source node, as well as a snapshot-access node pointing to the filter
|
||||||
|
node which allows to read the consistent state of the image at the
|
||||||
|
time it was inserted. New guest writes are passed through the
|
||||||
|
copy-before-write filter which will first copy over old data to the
|
||||||
|
fleecing image in case that old data is still needed by the
|
||||||
|
snapshot-access node.
|
||||||
|
|
||||||
|
The backup process will sequentially read from the snapshot access,
|
||||||
|
which has a bitmap and knows whether to read from the original image
|
||||||
|
or the fleecing image to get the "snapshot" state, i.e. data from the
|
||||||
|
source image at the time when the copy-before-write filter was
|
||||||
|
inserted. After reading, the copied sections are discarded from the
|
||||||
|
fleecing image to reduce space usage.
|
||||||
|
|
||||||
|
All of this can be restricted by an initial dirty bitmap to parts of
|
||||||
|
the source image that are required for an incremental backup.
|
||||||
|
|
||||||
|
For discard to work, it is necessary that the fleecing image does not
|
||||||
|
have a larger cluster size than the backup job granularity. Since
|
||||||
|
querying that size does not always work, e.g. for RBD with krbd, the
|
||||||
|
cluster size will not be reported, a minimum of 4 MiB is used. A job
|
||||||
|
with PBS target already has at least this granularity, so it's just
|
||||||
|
relevant for other targets. I.e. edge cases where this minimum is not
|
||||||
|
enough should be very rare in practice. If ever necessary in the
|
||||||
|
future, can still add a passed-in value for the backup QMP command to
|
||||||
|
override.
|
||||||
|
|
||||||
|
Additionally, the cbw-timeout and on-cbw-error=break-snapshot options
|
||||||
|
are set when installing the copy-before-write filter and
|
||||||
|
snapshot-access. When an error or timeout occurs, the problematic (and
|
||||||
|
each further) snapshot operation will fail and thus cancel the backup
|
||||||
|
instead of breaking the guest write.
|
||||||
|
|
||||||
|
Note that job_id cannot be inferred from the snapshot-access bs because
|
||||||
|
it has no parent, so just pass the one from the original bs.
|
||||||
|
|
||||||
|
[0]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg876056.html
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/monitor/block-hmp-cmds.c | 1 +
|
||||||
|
pve-backup.c | 135 ++++++++++++++++++++++++++++++++-
|
||||||
|
qapi/block-core.json | 10 ++-
|
||||||
|
3 files changed, 142 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
||||||
|
index 5000c084c5..70b3de4c7e 100644
|
||||||
|
--- a/block/monitor/block-hmp-cmds.c
|
||||||
|
+++ b/block/monitor/block-hmp-cmds.c
|
||||||
|
@@ -1043,6 +1043,7 @@ void coroutine_fn hmp_backup(Monitor *mon, const QDict *qdict)
|
||||||
|
NULL, NULL,
|
||||||
|
devlist, qdict_haskey(qdict, "speed"), speed,
|
||||||
|
false, 0, // BackupPerf max-workers
|
||||||
|
+ false, false, // fleecing
|
||||||
|
&error);
|
||||||
|
|
||||||
|
hmp_handle_error(mon, error);
|
||||||
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
|
index 5ebb6a3947..a747d12d3d 100644
|
||||||
|
--- a/pve-backup.c
|
||||||
|
+++ b/pve-backup.c
|
||||||
|
@@ -7,9 +7,11 @@
|
||||||
|
#include "sysemu/blockdev.h"
|
||||||
|
#include "block/block_int-global-state.h"
|
||||||
|
#include "block/blockjob.h"
|
||||||
|
+#include "block/copy-before-write.h"
|
||||||
|
#include "block/dirty-bitmap.h"
|
||||||
|
#include "block/graph-lock.h"
|
||||||
|
#include "qapi/qapi-commands-block.h"
|
||||||
|
+#include "qapi/qmp/qdict.h"
|
||||||
|
#include "qapi/qmp/qerror.h"
|
||||||
|
#include "qemu/cutils.h"
|
||||||
|
|
||||||
|
@@ -80,8 +82,15 @@ static void pvebackup_init(void)
|
||||||
|
// initialize PVEBackupState at startup
|
||||||
|
opts_init(pvebackup_init);
|
||||||
|
|
||||||
|
+typedef struct PVEBackupFleecingInfo {
|
||||||
|
+ BlockDriverState *bs;
|
||||||
|
+ BlockDriverState *cbw;
|
||||||
|
+ BlockDriverState *snapshot_access;
|
||||||
|
+} PVEBackupFleecingInfo;
|
||||||
|
+
|
||||||
|
typedef struct PVEBackupDevInfo {
|
||||||
|
BlockDriverState *bs;
|
||||||
|
+ PVEBackupFleecingInfo fleecing;
|
||||||
|
size_t size;
|
||||||
|
uint64_t block_size;
|
||||||
|
uint8_t dev_id;
|
||||||
|
@@ -353,6 +362,22 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
||||||
|
PVEBackupDevInfo *di = opaque;
|
||||||
|
di->completed_ret = ret;
|
||||||
|
|
||||||
|
+ /*
|
||||||
|
+ * Handle block-graph specific cleanup (for fleecing) outside of the coroutine, because the work
|
||||||
|
+ * won't be done as a coroutine anyways:
|
||||||
|
+ * - For snapshot_access, allows doing bdrv_unref() directly. Doing it via bdrv_co_unref() would
|
||||||
|
+ * just spawn a BH calling bdrv_unref().
|
||||||
|
+ * - For cbw, draining would need to spawn a BH.
|
||||||
|
+ */
|
||||||
|
+ if (di->fleecing.snapshot_access) {
|
||||||
|
+ bdrv_unref(di->fleecing.snapshot_access);
|
||||||
|
+ di->fleecing.snapshot_access = NULL;
|
||||||
|
+ }
|
||||||
|
+ if (di->fleecing.cbw) {
|
||||||
|
+ bdrv_cbw_drop(di->fleecing.cbw);
|
||||||
|
+ di->fleecing.cbw = NULL;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
/*
|
||||||
|
* Needs to happen outside of coroutine, because it takes the graph write lock.
|
||||||
|
*/
|
||||||
|
@@ -519,9 +544,77 @@ static void create_backup_jobs_bh(void *opaque) {
|
||||||
|
}
|
||||||
|
bdrv_drained_begin(di->bs);
|
||||||
|
|
||||||
|
+ BackupPerf perf = (BackupPerf){ .max_workers = backup_state.perf.max_workers };
|
||||||
|
+
|
||||||
|
+ BlockDriverState *source_bs = di->bs;
|
||||||
|
+ bool discard_source = false;
|
||||||
|
+ bdrv_graph_co_rdlock();
|
||||||
|
+ const char *job_id = bdrv_get_device_name(di->bs);
|
||||||
|
+ bdrv_graph_co_rdunlock();
|
||||||
|
+ if (di->fleecing.bs) {
|
||||||
|
+ QDict *cbw_opts = qdict_new();
|
||||||
|
+ qdict_put_str(cbw_opts, "driver", "copy-before-write");
|
||||||
|
+ qdict_put_str(cbw_opts, "file", bdrv_get_node_name(di->bs));
|
||||||
|
+ qdict_put_str(cbw_opts, "target", bdrv_get_node_name(di->fleecing.bs));
|
||||||
|
+
|
||||||
|
+ if (di->bitmap) {
|
||||||
|
+ /*
|
||||||
|
+ * Only guest writes to parts relevant for the backup need to be intercepted with
|
||||||
|
+ * old data being copied to the fleecing image.
|
||||||
|
+ */
|
||||||
|
+ qdict_put_str(cbw_opts, "bitmap.node", bdrv_get_node_name(di->bs));
|
||||||
|
+ qdict_put_str(cbw_opts, "bitmap.name", bdrv_dirty_bitmap_name(di->bitmap));
|
||||||
|
+ }
|
||||||
|
+ /*
|
||||||
|
+ * Fleecing storage is supposed to be fast and it's better to break backup than guest
|
||||||
|
+ * writes. Certain guest drivers like VirtIO-win have 60 seconds timeout by default, so
|
||||||
|
+ * abort a bit before that.
|
||||||
|
+ */
|
||||||
|
+ qdict_put_str(cbw_opts, "on-cbw-error", "break-snapshot");
|
||||||
|
+ qdict_put_int(cbw_opts, "cbw-timeout", 45);
|
||||||
|
+
|
||||||
|
+ di->fleecing.cbw = bdrv_insert_node(di->bs, cbw_opts, BDRV_O_RDWR, &local_err);
|
||||||
|
+
|
||||||
|
+ if (!di->fleecing.cbw) {
|
||||||
|
+ error_setg(errp, "appending cbw node for fleecing failed: %s",
|
||||||
|
+ local_err ? error_get_pretty(local_err) : "unknown error");
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ QDict *snapshot_access_opts = qdict_new();
|
||||||
|
+ qdict_put_str(snapshot_access_opts, "driver", "snapshot-access");
|
||||||
|
+ qdict_put_str(snapshot_access_opts, "file", bdrv_get_node_name(di->fleecing.cbw));
|
||||||
|
+
|
||||||
|
+ di->fleecing.snapshot_access =
|
||||||
|
+ bdrv_open(NULL, NULL, snapshot_access_opts, BDRV_O_RDWR | BDRV_O_UNMAP, &local_err);
|
||||||
|
+ if (!di->fleecing.snapshot_access) {
|
||||||
|
+ error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
||||||
|
+ local_err ? error_get_pretty(local_err) : "unknown error");
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ source_bs = di->fleecing.snapshot_access;
|
||||||
|
+ discard_source = true;
|
||||||
|
+
|
||||||
|
+ /*
|
||||||
|
+ * bdrv_get_info() just retuns 0 (= doesn't matter) for RBD when using krbd. But discard
|
||||||
|
+ * on the fleecing image won't work if the backup job's granularity is less than the RBD
|
||||||
|
+ * object size (default 4 MiB), so it does matter. Always use at least 4 MiB. With a PBS
|
||||||
|
+ * target, the backup job granularity would already be at least this much.
|
||||||
|
+ */
|
||||||
|
+ perf.min_cluster_size = 4 * 1024 * 1024;
|
||||||
|
+ /*
|
||||||
|
+ * For discard to work, cluster size for the backup job must be at least the same as for
|
||||||
|
+ * the fleecing image.
|
||||||
|
+ */
|
||||||
|
+ BlockDriverInfo bdi;
|
||||||
|
+ if (bdrv_get_info(di->fleecing.bs, &bdi) >= 0) {
|
||||||
|
+ perf.min_cluster_size = MAX(perf.min_cluster_size, bdi.cluster_size);
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
BlockJob *job = backup_job_create(
|
||||||
|
- NULL, di->bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
||||||
|
- bitmap_mode, false, NULL, &backup_state.perf, BLOCKDEV_ON_ERROR_REPORT,
|
||||||
|
+ job_id, source_bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
||||||
|
+ bitmap_mode, false, discard_source, NULL, &perf, BLOCKDEV_ON_ERROR_REPORT,
|
||||||
|
BLOCKDEV_ON_ERROR_REPORT, JOB_DEFAULT, pvebackup_complete_cb, di, backup_state.txn,
|
||||||
|
&local_err);
|
||||||
|
|
||||||
|
@@ -577,6 +670,14 @@ static void create_backup_jobs_bh(void *opaque) {
|
||||||
|
aio_co_enter(data->ctx, data->co);
|
||||||
|
}
|
||||||
|
|
||||||
|
+/*
|
||||||
|
+ * EFI disk and TPM state are small and it's just not worth setting up fleecing for them.
|
||||||
|
+ */
|
||||||
|
+static bool device_uses_fleecing(const char *device_id)
|
||||||
|
+{
|
||||||
|
+ return strncmp(device_id, "drive-efidisk", 13) && strncmp(device_id, "drive-tpmstate", 14);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
/*
|
||||||
|
* Returns a list of device infos, which needs to be freed by the caller. In
|
||||||
|
* case of an error, errp will be set, but the returned value might still be a
|
||||||
|
@@ -584,6 +685,7 @@ static void create_backup_jobs_bh(void *opaque) {
|
||||||
|
*/
|
||||||
|
static GList coroutine_fn GRAPH_RDLOCK *get_device_info(
|
||||||
|
const char *devlist,
|
||||||
|
+ bool fleecing,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
gchar **devs = NULL;
|
||||||
|
@@ -607,6 +709,31 @@ static GList coroutine_fn GRAPH_RDLOCK *get_device_info(
|
||||||
|
}
|
||||||
|
PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
||||||
|
di->bs = bs;
|
||||||
|
+
|
||||||
|
+ if (fleecing && device_uses_fleecing(*d)) {
|
||||||
|
+ g_autofree gchar *fleecing_devid = g_strconcat(*d, "-fleecing", NULL);
|
||||||
|
+ BlockBackend *fleecing_blk = blk_by_name(fleecing_devid);
|
||||||
|
+ if (!fleecing_blk) {
|
||||||
|
+ error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
|
||||||
|
+ "Device '%s' not found", fleecing_devid);
|
||||||
|
+ goto err;
|
||||||
|
+ }
|
||||||
|
+ BlockDriverState *fleecing_bs = blk_bs(fleecing_blk);
|
||||||
|
+ if (!bdrv_co_is_inserted(fleecing_bs)) {
|
||||||
|
+ error_setg(errp, QERR_DEVICE_HAS_NO_MEDIUM, fleecing_devid);
|
||||||
|
+ goto err;
|
||||||
|
+ }
|
||||||
|
+ /*
|
||||||
|
+ * Fleecing image needs to be the same size to act as a cbw target.
|
||||||
|
+ */
|
||||||
|
+ if (bs->total_sectors != fleecing_bs->total_sectors) {
|
||||||
|
+ error_setg(errp, "Size mismatch for '%s' - sector count %ld != %ld",
|
||||||
|
+ fleecing_devid, fleecing_bs->total_sectors, bs->total_sectors);
|
||||||
|
+ goto err;
|
||||||
|
+ }
|
||||||
|
+ di->fleecing.bs = fleecing_bs;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
di_list = g_list_append(di_list, di);
|
||||||
|
d++;
|
||||||
|
}
|
||||||
|
@@ -656,6 +783,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
||||||
|
const char *devlist,
|
||||||
|
bool has_speed, int64_t speed,
|
||||||
|
bool has_max_workers, int64_t max_workers,
|
||||||
|
+ bool has_fleecing, bool fleecing,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
assert(qemu_in_coroutine());
|
||||||
|
@@ -684,7 +812,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
||||||
|
format = has_format ? format : BACKUP_FORMAT_VMA;
|
||||||
|
|
||||||
|
bdrv_graph_co_rdlock();
|
||||||
|
- di_list = get_device_info(devlist, &local_err);
|
||||||
|
+ di_list = get_device_info(devlist, has_fleecing && fleecing, &local_err);
|
||||||
|
bdrv_graph_co_rdunlock();
|
||||||
|
if (local_err) {
|
||||||
|
error_propagate(errp, local_err);
|
||||||
|
@@ -1089,5 +1217,6 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
||||||
|
ret->query_bitmap_info = true;
|
||||||
|
ret->pbs_masterkey = true;
|
||||||
|
ret->backup_max_workers = true;
|
||||||
|
+ ret->backup_fleecing = true;
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index df934647ed..ff441d4258 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -948,6 +948,10 @@
|
||||||
|
#
|
||||||
|
# @max-workers: see @BackupPerf for details. Default 16.
|
||||||
|
#
|
||||||
|
+# @fleecing: perform a backup with fleecing. For each device in @devlist, a
|
||||||
|
+# corresponing '-fleecing' device with the same size already needs to
|
||||||
|
+# be present.
|
||||||
|
+#
|
||||||
|
# Returns: the uuid of the backup job
|
||||||
|
#
|
||||||
|
##
|
||||||
|
@@ -968,7 +972,8 @@
|
||||||
|
'*firewall-file': 'str',
|
||||||
|
'*devlist': 'str',
|
||||||
|
'*speed': 'int',
|
||||||
|
- '*max-workers': 'int' },
|
||||||
|
+ '*max-workers': 'int',
|
||||||
|
+ '*fleecing': 'bool' },
|
||||||
|
'returns': 'UuidInfo', 'coroutine': true }
|
||||||
|
|
||||||
|
##
|
||||||
|
@@ -1014,6 +1019,8 @@
|
||||||
|
#
|
||||||
|
# @pbs-library-version: Running version of libproxmox-backup-qemu0 library.
|
||||||
|
#
|
||||||
|
+# @backup-fleecing: Whether backup fleecing is supported or not.
|
||||||
|
+#
|
||||||
|
# @backup-max-workers: Whether the 'max-workers' @BackupPerf setting is
|
||||||
|
# supported or not.
|
||||||
|
#
|
||||||
|
@@ -1025,6 +1032,7 @@
|
||||||
|
'pbs-dirty-bitmap-migration': 'bool',
|
||||||
|
'pbs-masterkey': 'bool',
|
||||||
|
'pbs-library-version': 'str',
|
||||||
|
+ 'backup-fleecing': 'bool',
|
||||||
|
'backup-max-workers': 'bool' } }
|
||||||
|
|
||||||
|
##
|
117
debian/patches/pve/0047-PVE-backup-improve-error-when-copy-before-write-fail.patch
vendored
Normal file
117
debian/patches/pve/0047-PVE-backup-improve-error-when-copy-before-write-fail.patch
vendored
Normal file
|
@ -0,0 +1,117 @@
|
||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 29 Apr 2024 14:43:58 +0200
|
||||||
|
Subject: [PATCH] PVE backup: improve error when copy-before-write fails for
|
||||||
|
fleecing
|
||||||
|
|
||||||
|
With fleecing, failure for copy-before-write does not fail the guest
|
||||||
|
write, but only sets the snapshot error that is associated to the
|
||||||
|
copy-before-write filter, making further requests to the snapshot
|
||||||
|
access fail with EACCES, which then also fails the job. But that error
|
||||||
|
code is not the root cause of why the backup failed, so bubble up the
|
||||||
|
original snapshot error instead.
|
||||||
|
|
||||||
|
Reported-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Tested-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 18 ++++++++++++------
|
||||||
|
block/copy-before-write.h | 1 +
|
||||||
|
pve-backup.c | 9 +++++++++
|
||||||
|
3 files changed, 22 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index bba58326d7..50cc4c7aae 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -27,6 +27,7 @@
|
||||||
|
#include "qapi/qmp/qjson.h"
|
||||||
|
|
||||||
|
#include "sysemu/block-backend.h"
|
||||||
|
+#include "qemu/atomic.h"
|
||||||
|
#include "qemu/cutils.h"
|
||||||
|
#include "qapi/error.h"
|
||||||
|
#include "block/block_int.h"
|
||||||
|
@@ -74,7 +75,8 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
* @snapshot_error is normally zero. But on first copy-before-write failure
|
||||||
|
* when @on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT, @snapshot_error takes
|
||||||
|
* value of this error (<0). After that all in-flight and further
|
||||||
|
- * snapshot-API requests will fail with that error.
|
||||||
|
+ * snapshot-API requests will fail with that error. To be accessed with
|
||||||
|
+ * atomics.
|
||||||
|
*/
|
||||||
|
int snapshot_error;
|
||||||
|
} BDRVCopyBeforeWriteState;
|
||||||
|
@@ -114,7 +116,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
- if (s->snapshot_error) {
|
||||||
|
+ if (qatomic_read(&s->snapshot_error)) {
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -138,9 +140,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
||||||
|
WITH_QEMU_LOCK_GUARD(&s->lock) {
|
||||||
|
if (ret < 0) {
|
||||||
|
assert(s->on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT);
|
||||||
|
- if (!s->snapshot_error) {
|
||||||
|
- s->snapshot_error = ret;
|
||||||
|
- }
|
||||||
|
+ qatomic_cmpxchg(&s->snapshot_error, 0, ret);
|
||||||
|
} else {
|
||||||
|
bdrv_set_dirty_bitmap(s->done_bitmap, off, end - off);
|
||||||
|
}
|
||||||
|
@@ -214,7 +214,7 @@ cbw_snapshot_read_lock(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
|
||||||
|
QEMU_LOCK_GUARD(&s->lock);
|
||||||
|
|
||||||
|
- if (s->snapshot_error) {
|
||||||
|
+ if (qatomic_read(&s->snapshot_error)) {
|
||||||
|
g_free(req);
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
@@ -585,6 +585,12 @@ void bdrv_cbw_drop(BlockDriverState *bs)
|
||||||
|
bdrv_unref(bs);
|
||||||
|
}
|
||||||
|
|
||||||
|
+int bdrv_cbw_snapshot_error(BlockDriverState *bs)
|
||||||
|
+{
|
||||||
|
+ BDRVCopyBeforeWriteState *s = bs->opaque;
|
||||||
|
+ return qatomic_read(&s->snapshot_error);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
static void cbw_init(void)
|
||||||
|
{
|
||||||
|
bdrv_register(&bdrv_cbw_filter);
|
||||||
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
|
index dc6cafe7fa..a27d2d7d9f 100644
|
||||||
|
--- a/block/copy-before-write.h
|
||||||
|
+++ b/block/copy-before-write.h
|
||||||
|
@@ -44,5 +44,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp);
|
||||||
|
void bdrv_cbw_drop(BlockDriverState *bs);
|
||||||
|
+int bdrv_cbw_snapshot_error(BlockDriverState *bs);
|
||||||
|
|
||||||
|
#endif /* COPY_BEFORE_WRITE_H */
|
||||||
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
|
index a747d12d3d..4e730aa3da 100644
|
||||||
|
--- a/pve-backup.c
|
||||||
|
+++ b/pve-backup.c
|
||||||
|
@@ -374,6 +374,15 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
||||||
|
di->fleecing.snapshot_access = NULL;
|
||||||
|
}
|
||||||
|
if (di->fleecing.cbw) {
|
||||||
|
+ /*
|
||||||
|
+ * With fleecing, failure for cbw does not fail the guest write, but only sets the snapshot
|
||||||
|
+ * error, making further requests to the snapshot fail with EACCES, which then also fail the
|
||||||
|
+ * job. But that code is not the root cause and just confusing, so update it.
|
||||||
|
+ */
|
||||||
|
+ int snapshot_error = bdrv_cbw_snapshot_error(di->fleecing.cbw);
|
||||||
|
+ if (di->completed_ret == -EACCES && snapshot_error) {
|
||||||
|
+ di->completed_ret = snapshot_error;
|
||||||
|
+ }
|
||||||
|
bdrv_cbw_drop(di->fleecing.cbw);
|
||||||
|
di->fleecing.cbw = NULL;
|
||||||
|
}
|
|
@ -1,33 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 26 May 2021 15:26:30 +0200
|
|
||||||
Subject: [PATCH] PVE: whitelist 'invalid' QAPI names for backwards compat
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
qapi/pragma.json | 5 ++++-
|
|
||||||
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
|
||||||
index 7c91ea3685..c3888d654c 100644
|
|
||||||
--- a/qapi/pragma.json
|
|
||||||
+++ b/qapi/pragma.json
|
|
||||||
@@ -12,6 +12,7 @@
|
|
||||||
'device_add',
|
|
||||||
'device_del',
|
|
||||||
'expire_password',
|
|
||||||
+ 'get_link_status',
|
|
||||||
'migrate_cancel',
|
|
||||||
'netdev_add',
|
|
||||||
'netdev_del',
|
|
||||||
@@ -60,6 +61,8 @@
|
|
||||||
'SysEmuTarget', # query-cpu-fast, query-target
|
|
||||||
'UuidInfo', # query-uuid
|
|
||||||
'VncClientInfo', # query-vnc, query-vnc-servers, ...
|
|
||||||
- 'X86CPURegister32' # qom-get of x86 CPU properties
|
|
||||||
+ 'X86CPURegister32', # qom-get of x86 CPU properties
|
|
||||||
# feature-words, filtered-features
|
|
||||||
+ 'BlockdevOptionsPbs', # for PBS backwards compat
|
|
||||||
+ 'BalloonInfo'
|
|
||||||
] } }
|
|
|
@ -1,35 +0,0 @@
|
||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Date: Wed, 26 May 2021 17:36:55 +0200
|
|
||||||
Subject: [PATCH] PVE: savevm-async: register yank before
|
|
||||||
migration_incoming_state_destroy
|
|
||||||
|
|
||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
||||||
---
|
|
||||||
migration/savevm-async.c | 5 +++++
|
|
||||||
1 file changed, 5 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
|
||||||
index 970ee3b3fc..b3ccc069f1 100644
|
|
||||||
--- a/migration/savevm-async.c
|
|
||||||
+++ b/migration/savevm-async.c
|
|
||||||
@@ -19,6 +19,7 @@
|
|
||||||
#include "qemu/timer.h"
|
|
||||||
#include "qemu/main-loop.h"
|
|
||||||
#include "qemu/rcu.h"
|
|
||||||
+#include "qemu/yank.h"
|
|
||||||
|
|
||||||
/* #define DEBUG_SAVEVM_STATE */
|
|
||||||
|
|
||||||
@@ -580,6 +581,10 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
|
||||||
dirty_bitmap_mig_before_vm_start();
|
|
||||||
|
|
||||||
qemu_fclose(f);
|
|
||||||
+
|
|
||||||
+ /* state_destroy assumes a real migration which would have added a yank */
|
|
||||||
+ yank_register_instance(MIGRATION_YANK_INSTANCE, &error_abort);
|
|
||||||
+
|
|
||||||
migration_incoming_state_destroy();
|
|
||||||
if (ret < 0) {
|
|
||||||
error_setg_errno(errp, -ret, "Error while loading VM state");
|
|
|
@ -1,7 +1,20 @@
|
||||||
extra/0001-monitor-qmp-fix-race-with-clients-disconnecting-earl.patch
|
extra/0001-monitor-qmp-fix-race-with-clients-disconnecting-earl.patch
|
||||||
extra/0002-monitor-hmp-add-support-for-flag-argument-with-value.patch
|
extra/0002-scsi-megasas-Internal-cdbs-have-16-byte-length.patch
|
||||||
extra/0003-monitor-refactor-set-expire_password-and-allow-VNC-d.patch
|
extra/0003-ide-avoid-potential-deadlock-when-draining-during-tr.patch
|
||||||
extra/0004-block-mirror-fix-NULL-pointer-dereference-in-mirror_.patch
|
extra/0004-Revert-x86-acpi-workaround-Windows-not-handling-name.patch
|
||||||
|
extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
|
||||||
|
extra/0006-Revert-virtio-pci-fix-use-of-a-released-vector.patch
|
||||||
|
extra/0007-block-copy-before-write-fix-permission.patch
|
||||||
|
extra/0008-block-copy-before-write-support-unligned-snapshot-di.patch
|
||||||
|
extra/0009-block-copy-before-write-create-block_copy-bitmap-in-.patch
|
||||||
|
extra/0010-qapi-blockdev-backup-add-discard-source-parameter.patch
|
||||||
|
extra/0011-hw-virtio-Fix-the-de-initialization-of-vhost-user-de.patch
|
||||||
|
extra/0012-target-arm-Use-float_status-copy-in-sme_fmopa_s.patch
|
||||||
|
extra/0013-target-arm-Use-FPST_F16-for-SME-FMOPA-widening.patch
|
||||||
|
extra/0014-scsi-fix-regression-and-honor-bootindex-again-for-le.patch
|
||||||
|
extra/0015-hw-scsi-lsi53c895a-bump-instruction-limit-in-scripts.patch
|
||||||
|
extra/0016-block-copy-Fix-missing-graph-lock.patch
|
||||||
|
extra/0017-Revert-qemu-char-do-not-operate-on-sources-from-fina.patch
|
||||||
bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch
|
bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch
|
||||||
bitmap-mirror/0002-drive-mirror-add-support-for-conditional-and-always-.patch
|
bitmap-mirror/0002-drive-mirror-add-support-for-conditional-and-always-.patch
|
||||||
bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch
|
bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch
|
||||||
|
@ -14,46 +27,45 @@ pve/0003-PVE-Config-set-the-CPU-model-to-kvm64-32-instead-of-.patch
|
||||||
pve/0004-PVE-Config-ui-spice-default-to-pve-certificates.patch
|
pve/0004-PVE-Config-ui-spice-default-to-pve-certificates.patch
|
||||||
pve/0005-PVE-Config-glusterfs-no-default-logfile-if-daemonize.patch
|
pve/0005-PVE-Config-glusterfs-no-default-logfile-if-daemonize.patch
|
||||||
pve/0006-PVE-Config-rbd-block-rbd-disable-rbd_cache_writethro.patch
|
pve/0006-PVE-Config-rbd-block-rbd-disable-rbd_cache_writethro.patch
|
||||||
pve/0007-PVE-Up-qmp-add-get_link_status.patch
|
pve/0007-PVE-Up-glusterfs-allow-partial-reads.patch
|
||||||
pve/0008-PVE-Up-glusterfs-allow-partial-reads.patch
|
pve/0008-PVE-Up-qemu-img-return-success-on-info-without-snaps.patch
|
||||||
pve/0009-PVE-Up-qemu-img-return-success-on-info-without-snaps.patch
|
pve/0009-PVE-Up-qemu-img-dd-add-osize-and-read-from-to-stdin-.patch
|
||||||
pve/0010-PVE-Up-qemu-img-dd-add-osize-and-read-from-to-stdin-.patch
|
pve/0010-PVE-Up-qemu-img-dd-add-isize-parameter.patch
|
||||||
pve/0011-PVE-Up-qemu-img-dd-add-isize-parameter.patch
|
pve/0011-PVE-Up-qemu-img-dd-add-n-skip_create.patch
|
||||||
pve/0012-PVE-Up-qemu-img-dd-add-n-skip_create.patch
|
pve/0012-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch
|
||||||
pve/0013-PVE-virtio-balloon-improve-query-balloon.patch
|
pve/0013-PVE-virtio-balloon-improve-query-balloon.patch
|
||||||
pve/0014-PVE-qapi-modify-query-machines.patch
|
pve/0014-PVE-qapi-modify-query-machines.patch
|
||||||
pve/0015-PVE-qapi-modify-spice-query.patch
|
pve/0015-PVE-qapi-modify-spice-query.patch
|
||||||
pve/0016-PVE-add-savevm-async-for-background-state-snapshots.patch
|
pve/0016-PVE-add-IOChannel-implementation-for-savevm-async.patch
|
||||||
pve/0017-PVE-add-optional-buffer-size-to-QEMUFile.patch
|
pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch
|
||||||
pve/0018-PVE-block-add-the-zeroinit-block-driver-filter.patch
|
pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch
|
||||||
pve/0019-PVE-Add-dummy-id-command-line-parameter.patch
|
pve/0019-PVE-block-add-the-zeroinit-block-driver-filter.patch
|
||||||
pve/0020-PVE-Config-Revert-target-i386-disable-LINT0-after-re.patch
|
pve/0020-PVE-Add-dummy-id-command-line-parameter.patch
|
||||||
pve/0021-PVE-Up-Config-file-posix-make-locking-optiono-on-cre.patch
|
pve/0021-PVE-Config-Revert-target-i386-disable-LINT0-after-re.patch
|
||||||
pve/0022-PVE-monitor-disable-oob-capability.patch
|
pve/0022-PVE-Up-Config-file-posix-make-locking-optiono-on-cre.patch
|
||||||
pve/0023-PVE-Compat-4.0-used-balloon-qemu-4-0-config-size-fal.patch
|
pve/0023-PVE-monitor-disable-oob-capability.patch
|
||||||
pve/0024-PVE-Allow-version-code-in-machine-type.patch
|
pve/0024-PVE-Compat-4.0-used-balloon-qemu-4-0-config-size-fal.patch
|
||||||
pve/0025-PVE-Backup-add-vma-backup-format-code.patch
|
pve/0025-PVE-Allow-version-code-in-machine-type.patch
|
||||||
pve/0026-PVE-Backup-add-backup-dump-block-driver.patch
|
pve/0026-block-backup-move-bcs-bitmap-initialization-to-job-c.patch
|
||||||
pve/0027-PVE-Backup-proxmox-backup-patches-for-qemu.patch
|
pve/0027-PVE-Backup-add-vma-backup-format-code.patch
|
||||||
pve/0028-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch
|
pve/0028-PVE-Backup-add-backup-dump-block-driver.patch
|
||||||
pve/0029-PVE-Backup-Add-dirty-bitmap-tracking-for-incremental.patch
|
pve/0029-PVE-Add-sequential-job-transaction-support.patch
|
||||||
pve/0030-PVE-various-PBS-fixes.patch
|
pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch
|
||||||
pve/0031-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
|
pve/0031-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch
|
||||||
pve/0032-PVE-add-query_proxmox_support-QMP-command.patch
|
pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
|
||||||
pve/0033-PVE-add-query-pbs-bitmap-info-QMP-call.patch
|
pve/0033-PVE-redirect-stderr-to-journal-when-daemonized.patch
|
||||||
pve/0034-PVE-redirect-stderr-to-journal-when-daemonized.patch
|
pve/0034-PVE-Migrate-dirty-bitmap-state-via-savevm.patch
|
||||||
pve/0035-PVE-Add-sequential-job-transaction-support.patch
|
pve/0035-migration-block-dirty-bitmap-migrate-other-bitmaps-e.patch
|
||||||
pve/0036-PVE-Backup-Use-a-transaction-to-synchronize-job-stat.patch
|
pve/0036-PVE-fall-back-to-open-iscsi-initiatorname.patch
|
||||||
pve/0037-PVE-Backup-Don-t-block-on-finishing-and-cleanup-crea.patch
|
pve/0037-PVE-block-stream-increase-chunk-size.patch
|
||||||
pve/0038-PVE-Migrate-dirty-bitmap-state-via-savevm.patch
|
pve/0038-block-add-alloc-track-driver.patch
|
||||||
pve/0039-migration-block-dirty-bitmap-migrate-other-bitmaps-e.patch
|
pve/0039-Revert-block-rbd-workaround-for-ceph-issue-53784.patch
|
||||||
pve/0040-PVE-fall-back-to-open-iscsi-initiatorname.patch
|
pve/0040-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch
|
||||||
pve/0041-PVE-Use-coroutine-QMP-for-backup-cancel_backup.patch
|
pve/0041-Revert-block-rbd-implement-bdrv_co_block_status.patch
|
||||||
pve/0042-PBS-add-master-key-support.patch
|
pve/0042-alloc-track-error-out-when-auto-remove-is-not-set.patch
|
||||||
pve/0043-PVE-block-pbs-fast-path-reads-without-allocation-if-.patch
|
pve/0043-alloc-track-avoid-seemingly-superfluous-child-permis.patch
|
||||||
pve/0044-PVE-block-stream-increase-chunk-size.patch
|
pve/0044-copy-before-write-allow-specifying-minimum-cluster-s.patch
|
||||||
pve/0045-block-io-accept-NULL-qiov-in-bdrv_pad_request.patch
|
pve/0045-backup-add-minimum-cluster-size-to-performance-optio.patch
|
||||||
pve/0046-block-add-alloc-track-driver.patch
|
pve/0046-PVE-backup-add-fleecing-option.patch
|
||||||
pve/0047-PVE-whitelist-invalid-QAPI-names-for-backwards-compa.patch
|
pve/0047-PVE-backup-improve-error-when-copy-before-write-fail.patch
|
||||||
pve/0048-PVE-savevm-async-register-yank-before-migration_inco.patch
|
pve-qemu-9.0-vitastor.patch
|
||||||
pve-qemu-6.1-vitastor.patch
|
|
||||||
|
|
|
@ -1,7 +1,6 @@
|
||||||
# install the userspace utilities
|
|
||||||
debian/kvm-ifup etc/kvm/
|
|
||||||
debian/kvm-ifdown etc/kvm/
|
|
||||||
|
|
||||||
#install ovmf uefi rom
|
#install ovmf uefi rom
|
||||||
debian/OVMF_CODE-pure-efi.fd usr/share/kvm/
|
debian/OVMF_CODE-pure-efi.fd usr/share/kvm/
|
||||||
debian/OVMF_VARS-pure-efi.fd usr/share/kvm/
|
debian/OVMF_VARS-pure-efi.fd usr/share/kvm/
|
||||||
|
debian/kvm-ifdown etc/kvm/
|
||||||
|
# install the userspace utilities
|
||||||
|
debian/kvm-ifup etc/kvm/
|
||||||
|
|
|
@ -1,16 +1,13 @@
|
||||||
usr/bin/qemu-system-x86_64 usr/bin/kvm
|
|
||||||
|
|
||||||
# qemu-system-i386 and qemu-system-x86_64 provides the same hardware emulation
|
|
||||||
usr/bin/qemu-system-x86_64 usr/bin/qemu-system-i386
|
|
||||||
|
|
||||||
# also use aarch64 for 32 bit arm
|
# also use aarch64 for 32 bit arm
|
||||||
usr/bin/qemu-system-aarch64 usr/bin/qemu-system-arm
|
usr/bin/qemu-system-aarch64 usr/bin/qemu-system-arm
|
||||||
|
usr/bin/qemu-system-x86_64 usr/bin/kvm
|
||||||
|
# qemu-system-i386 and qemu-system-x86_64 provides the same hardware emulation
|
||||||
|
usr/bin/qemu-system-x86_64 usr/bin/qemu-system-i386
|
||||||
# upstream provides a qemu man page,
|
# upstream provides a qemu man page,
|
||||||
# we symlink to kvm for backward compatibility
|
# we symlink to kvm for backward compatibility
|
||||||
# and to qemu-system-{i386,x86_64} to fullfill our 'Provides: qemu-system-x86'
|
# and to qemu-system-{i386,x86_64} to fullfill our 'Provides: qemu-system-x86'
|
||||||
usr/share/man/man1/qemu.1 usr/share/man/man1/kvm.1
|
usr/share/man/man1/qemu.1 usr/share/man/man1/kvm.1
|
||||||
|
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-aarch64.1
|
||||||
|
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-arm.1
|
||||||
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-i386.1
|
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-i386.1
|
||||||
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-x86_64.1
|
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-x86_64.1
|
||||||
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-arm.1
|
|
||||||
usr/share/man/man1/qemu.1 usr/share/man/man1/qemu-system-aarch64.1
|
|
||||||
|
|
|
@ -1,4 +1,7 @@
|
||||||
pve-qemu-kvm: arch-dependent-file-in-usr-share usr/share/kvm/hppa-firmware.img
|
pve-qemu-kvm: arch-dependent-file-in-usr-share [usr/share/kvm/hppa-firmware.img]
|
||||||
pve-qemu-kvm: binary-from-other-architecture usr/share/kvm/hppa-firmware.img
|
pve-qemu-kvm: binary-from-other-architecture [usr/share/kvm/hppa-firmware.img]
|
||||||
pve-qemu-kvm: unstripped-binary-or-object usr/share/kvm/hppa-firmware.img
|
pve-qemu-kvm: embedded-javascript-library please use * [usr/share/doc/pve-qemu-kvm/kvm/_static/*]
|
||||||
pve-qemu-kvm: statically-linked-binary usr/share/kvm/hppa-firmware.img
|
pve-qemu-kvm: groff-message *: warning [*]: can't break line [usr/share/man/*]
|
||||||
|
pve-qemu-kvm: groff-message *: warning [*]: cannot adjust line [usr/share/man/*]
|
||||||
|
pve-qemu-kvm: statically-linked-binary [usr/share/kvm/hppa-firmware.img]
|
||||||
|
pve-qemu-kvm: unstripped-binary-or-object [usr/share/kvm/hppa-firmware.img]
|
||||||
|
|
Some files were not shown because too many files have changed in this diff Show More
Loading…
Reference in New Issue