vitalif
/
react-toolbox
1
0
Fork 0
Code Issues Pull Requests Releases 12 Wiki Activity

Fix mixed up type definitions for Dropdown 

`valueKey` and `labelKey` were listed as theme props.  What's worse, `valueKey` was marked as required, when in fact it should not be present at all on the theme.
old
Zander Otavka 2017-08-12 15:54:50 -07:00 committed by GitHub
parent 61228b10db
commit 47d2f1893f
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
components/dropdown/Dropdown.d.ts vendored
View File

@ -30,10 +30,6 @@ export interface DropdownTheme {
* Used for the the label element.
*/
label?: string;
/**
* Used for setting the label from source
*/
labelKey?: string;
/**
* Used when dropdown has required attribute.
*/
@ -58,10 +54,6 @@ export interface DropdownTheme {
* Used for the list of values.
*/
values?: string;
/**
* Used for setting the value from source
*/
valueKey: string;
}
export interface DropdownProps extends ReactToolbox.Props {
@ -88,6 +80,10 @@ export interface DropdownProps extends ReactToolbox.Props {
* The text string to use for the floating label element.
*/
label?: string;
/**
* Used for setting the label from source
*/
labelKey?: string;
/**
* Name for the input field.
*/
@ -104,6 +100,11 @@ export interface DropdownProps extends ReactToolbox.Props {
* Callback function that is fired when the component is focused.
*/
onFocus?: Function;
/**
* If true, the dropdown has a required attribute.
* @default false
*/
required?: boolean;
/**
* Array of data objects with the data to represent in the dropdown.
*/
@ -121,10 +122,9 @@ export interface DropdownProps extends ReactToolbox.Props {
*/
value?: string | number;
/**
* If true, the dropdown has a required attribute.
* @default false
* Used for setting the value from source
*/
required?: boolean;
valueKey?: string;
}
export class Dropdown extends React.Component<DropdownProps, {}> { }