From e7f521041e94804388108a497696244927c3454c Mon Sep 17 00:00:00 2001
From: dan-kwiat <dan.kwiat@gmail.com>
Date: Sun, 26 Feb 2017 15:39:59 +0000
Subject: [PATCH] Remove unnecessary reference to sliderLength in knobOffset
 method (#1271)

---
 components/slider/Slider.js               | 5 ++---
 components/slider/__tests__/index.spec.js | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/components/slider/Slider.js b/components/slider/Slider.js
index d51ba597..3a7baa5e 100644
--- a/components/slider/Slider.js
+++ b/components/slider/Slider.js
@@ -187,9 +187,8 @@ const factory = (ProgressBar, Input) => {
     }
 
     knobOffset() {
-      const { max, min } = this.props;
-      const translated = this.state.sliderLength * ((this.props.value - min) / (max - min));
-      return (translated * 100) / this.state.sliderLength;
+      const { max, min, value } = this.props;
+      return 100 * ((value - min) / (max - min));
     }
 
     move(position) {
diff --git a/components/slider/__tests__/index.spec.js b/components/slider/__tests__/index.spec.js
index daa36cf7..6a5c429e 100644
--- a/components/slider/__tests__/index.spec.js
+++ b/components/slider/__tests__/index.spec.js
@@ -57,9 +57,8 @@ describe('Slider', () => {
   });
 
   describe('#knobOffset', () => {
-    it('returns the corresponding offset for a given value and slider length/start', () => {
+    it('returns percentage offset of knob for slider with given min/max/value props', () => {
       const slider = shallow(<Slider min={-500} max={500} value={-250} />).instance();
-      slider.setState({ sliderStart: 500, sliderLength: 100 });
       expect(slider.knobOffset()).toEqual(25);
     });
   });