Removed show_changed_paths option. It was originally added as a way to

to disable a buggy and inefficient subversion feature. But it's no
longer neccessary with C. Mike's recent improvements to the subversion
module.

* viewcvs.conf.dist
  (show_changed_paths):
    removed option

* lib/config.py
  (Config.set_defaults)
    removed default assignment

* lib/viewcvs.py
  (run_viewcvs):
    stop passing option value to repository object

* lib/vclib/svn/__init__.py
  (log_helper, fetch_log):
    stop passing option value to log_helper function


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@726 8cb11bc2-c004-0410-86c3-e597b4017df7

lib/config.py

@@ -200,7 +200,6 @@ class Config:
     self.options.show_subdir_lastmod = 0
     self.options.show_logs = 1
     self.options.show_log_in_markup = 1
-    self.options.show_changed_paths = 0
     self.options.cross_copies = 0
     self.options.py2html_path = '.'
     self.options.short_log_len = 80

lib/vclib/svn/__init__.py

@@ -98,7 +98,7 @@ def get_history(svnrepos, full_name):
   return history.histories
 
 
-def log_helper(svnrepos, rev, path, show_changed_paths, pool):
+def log_helper(svnrepos, rev, path, pool):
   rev_root = fs.revision_root(svnrepos.fs_ptr, rev, pool)
   other_paths = []
   changed_paths = fs.paths_changed(rev_root, pool)
@@ -125,13 +125,9 @@ def log_helper(svnrepos, rev, path, show_changed_paths, pool):
        (change.change_kind == fs.path_change_replace):
       copyfrom_rev, copyfrom_path = fs.copied_from(rev_root, path, pool)
 
-    # We're done with this path, so remove it from the changed_paths list.
-    del changed_paths[path]
-
-  # Now, make ChangedPathEntry objects for all the other paths (if
-  # show_changed_paths is set).
-  if show_changed_paths:
-    for other_path in changed_paths.keys():
+  # Now, make ChangedPathEntry objects for all the other paths
+  for other_path in changed_paths.keys():
+    if other_path != path:
       other_paths.append(ChangedPathEntry(_trim_path(other_path)))
 
   # Finally, assemble our LogEntry.
@@ -151,14 +147,12 @@ def fetch_log(svnrepos, full_name, which_rev=None):
     'HEAD' : '1',
     }
   logs = {}
-  show_changed_paths = getattr(svnrepos, 'get_changed_paths', 1)
 
   if which_rev is not None:
     if (which_rev < 0) \
        or (which_rev > fs.youngest_rev(svnrepos.fs_ptr, svnrepos.pool)):
       raise vclib.InvalidRevision(which_rev)
-    entry = log_helper(svnrepos, which_rev, full_name,
-                       show_changed_paths, svnrepos.pool)
+    entry = log_helper(svnrepos, which_rev, full_name, svnrepos.pool)
     if entry:
       logs[which_rev] = entry
   else:
@@ -170,7 +164,7 @@ def fetch_log(svnrepos, full_name, which_rev=None):
     for history_rev in history_revs:
       core.svn_pool_clear(subpool)
       entry = log_helper(svnrepos, history_rev, history_set[history_rev],
-                         show_changed_paths, subpool)
+                         subpool)
       if entry:
         logs[history_rev] = entry        
     core.svn_pool_destroy(subpool)

lib/viewcvs.py

@@ -250,7 +250,6 @@ class Request:
           rev = int(self.query_dict['rev'])
         self.repos = vclib.svn.SubversionRepository(self.rootname,
                                                     self.rootpath, rev)
-        self.repos.get_changed_paths = cfg.options.show_changed_paths
         self.repos.cross_copies = cfg.options.cross_copies
         self.roottype = 'svn'
       except vclib.ReposNotFound:

viewcvs.conf.dist

@@ -400,9 +400,6 @@ show_logs = 1
 # Show log when viewing file contents
 show_log_in_markup = 1
 
-# Show list of changed paths in Subversion logs entries
-show_changed_paths = 0
-
 # Cross filesystem copies when traversing Subversion file revision histories
 cross_copies = 0