Configure ESLint and add it to CI

.gitea/workflows/test.yml

@@ -64,6 +64,13 @@ jobs:
     # leak sanitizer sometimes crashes
     - run: cd /root/vitastor/build && ASAN_OPTIONS=detect_leaks=0 make -j16 test
 
+  npm_lint:
+    runs-on: ubuntu-latest
+    needs: build
+    container: ${{env.TEST_IMAGE}}:${{github.sha}}
+    steps:
+    - run: cd /root/vitastor/mon && npm run lint
+
   test_add_osd:
     runs-on: ubuntu-latest
     needs: build

mon/.eslintrc.js

@@ -0,0 +1,78 @@
+module.exports = {
+    //"parser": "@babel/eslint-parser",
+    "env": {
+        "es6": true,
+        "node": true
+    },
+    "extends": [
+        "eslint:recommended",
+        "plugin:node/recommended"
+    ],
+    "parserOptions": {
+        "ecmaVersion": 2020
+    },
+    //    "sourceType": "module",
+    //    "ecmaFeatures": {
+    //        "experimentalObjectRestSpread": true
+    //    },
+    //    "requireConfigFile": false,
+    //    "babelOptions": {
+    //        "presets": [
+    //            [ "@babel/preset-env", { "targets": { "node": "12" } } ]
+    //        ],
+    //        "retainLines": true
+    //    }
+    //},
+    "plugins": [
+    ],
+    "rules": {
+        "indent": [
+            "error",
+            4
+        ],
+        "brace-style": [
+            "error",
+            "allman",
+            { "allowSingleLine": true }
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ],
+        "require-atomic-updates": [
+            "off"
+        ],
+        "no-useless-escape": [
+            "off"
+        ],
+        "no-control-regex": [
+            "off"
+        ],
+        "no-unused-vars": [
+            "off"
+        ],
+        "no-empty": [
+            "off"
+        ],
+        "no-process-exit": [
+            "off"
+        ],
+        "node/shebang": [
+            "off"
+        ]
+    },
+    "overrides": [
+        {
+            "files": [ "struct-types.compiled.js", "FormulaParser.js" ],
+            "rules": {
+                "indent": "off",
+                "semi": "off",
+                "brace-style": "off"
+            }
+        }
+    ]
+};

mon/dsl_pgs.js

@@ -152,6 +152,7 @@ function parse_pg_dsl(text)
             else if (rule[2] === '(')
             {
                 rule[2] = [];
+                // eslint-disable-next-line no-constant-condition
                 while (true)
                 {
                     if (i > tokens.length-1)

mon/mon.js

@@ -747,6 +747,7 @@ class Mon
         this.save_last_clean_running = true;
         // last_clean_pgs is used to avoid extra data move when observing a series of changes in the cluster
         const new_clean_pgs = { items: {} };
+        // eslint-disable-next-line indent
     next_pool:
         for (const pool_id in this.state.config.pools)
         {
@@ -829,6 +830,7 @@ class Mon
     async become_master()
     {
         const state = { ...this.get_mon_state(), id: ''+this.etcd_lease_id };
+        // eslint-disable-next-line no-constant-condition
         while (1)
         {
             const res = await this.etcd_call('/kv/txn', {
@@ -1316,7 +1318,7 @@ class Mon
             for (const k in rules)
             {
                 if (!levels[k] || typeof rules[k] !== 'string' &&
-                    (!rules[k] instanceof Array ||
+                    (!(rules[k] instanceof Array) ||
                     rules[k].filter(s => typeof s !== 'string' && typeof s !== 'number').length > 0))
                 {
                     if (warn)

mon/package.json

@@ -11,5 +11,15 @@
   "dependencies": {
     "sprintf-js": "^1.1.2",
     "ws": "^7.2.5"
+  },
+  "devDependencies": {
+    "eslint": "^8.0.0",
+    "eslint-plugin-node": "^11.1.0"
+  },
+  "engines": {
+    "node": ">=12.0.0"
+  },
+  "scripts": {
+    "lint": "eslint *.js"
   }
 }

mon/simple-offsets.js

@@ -38,7 +38,7 @@ async function run()
         const st = await fs.stat(options.device);
         options.device_block_size = st.blksize;
         if (st.isBlockDevice())
-            device_size = Number(await system("/sbin/blockdev --getsize64 "+options.device))
+            device_size = Number(await system("/sbin/blockdev --getsize64 "+options.device));
         else
             device_size = st.size;
     }

mon/test-optimize.js

@@ -20,7 +20,7 @@ const osd_tree = {
     },
     500: {
         4: 3.58498,
-//        8: 3.58589,
+        /*8: 3.58589,*/
         9: 3.63869,
     },
     600: {

rpm/vitastor-el7.spec

@@ -104,7 +104,7 @@ rm -rf $RPM_BUILD_ROOT
 %make_install
 . /opt/rh/rh-nodejs12/enable
 cd mon
-npm install
+npm install --production
 cd ..
 mkdir -p %buildroot/usr/lib/vitastor
 cp -r mon %buildroot/usr/lib/vitastor

rpm/vitastor-el8.spec

@@ -101,7 +101,7 @@ Vitastor fio drivers for benchmarking.
 rm -rf $RPM_BUILD_ROOT
 %make_install
 cd mon
-npm install
+npm install --production
 cd ..
 mkdir -p %buildroot/usr/lib/vitastor
 cp -r mon %buildroot/usr/lib/vitastor

rpm/vitastor-el9.spec

@@ -94,7 +94,7 @@ Vitastor fio drivers for benchmarking.
 rm -rf $RPM_BUILD_ROOT
 %cmake_install
 cd mon
-npm install
+npm install --production
 cd ..
 mkdir -p %buildroot/usr/lib/vitastor
 cp -r mon %buildroot/usr/lib/vitastor