Fix cl->read_op being freed without calling the completion callback

2 years ago · f4ea313707
parent b88b76f316
commit f4ea313707
1 changed files with 8 additions and 1 deletions
--- a/messenger.cpp
+++ b/messenger.cpp
@ -348,7 +348,14 @@ void osd_messenger_t::stop_client(int peer_fd)
    }
    if (cl->read_op)
    {
-        delete cl->read_op;
+        if (cl->read_op->callback)
+        {
+            cancel_op(cl->read_op);
+        }
+        else
+        {
+            delete cl->read_op;
+        }
        cl->read_op = NULL;
    }
    for (auto rit = read_ready_clients.begin(); rit != read_ready_clients.end(); rit++)