855 Commits (master)

Author	SHA1	Message	Date
Vitaliy Filippov	5d9d6f32a0	Fix common realloc memory leak mistakes found by cppcheck	2024-01-13 01:30:28 +03:00
Vitaliy Filippov	5280d1d561	Release 1.4.0 ... New features: - Intelligent recovery/rebalance speed auto-tuning to reduce its impact on clients (see README -> Features) - Auto-restoration of dead VDUSE daemons in CSI plugin - Add vitastor-disk update-sb command - Update QEMU for Debian Bookworm to 8.1 and use it for CSI plugin Bug fixes: - Fix pools SOMETIMES staying inactive after stopping a node due to OSDs not reacting to PG state changes caused by incorrect full reload of state from etcd on reconnection - Make monitors retry pool configuration changes quickier which fixes them being unable to apply changes when an ongoing rebalance is quickly making a lot of PGs clean - Fix CSI plugin not accepting array of strings as etcd address in /etc/vitastor/vitastor.conf - Allow multiple interfaces with the same IP address, for "simple routed" full mesh network - Do not ignore loopback addresses for OSD network (to make ECMP setups with frr possible) - Fix a rare client crash during OSD reconnections - Only treat data partitions as existing OSDs in vitastor-disk prepare - Remove etcd parameter from default command examples - Fix reported free space sometimes changing non-immediately after deletion of data from OSDs - Fix a possible OSD crash on print_slow when bs_op is NULL - Use the same etcd_ws_keepalive_interval in mon as in OSD - Fix mon not using values from config when /config/global is not present - Remove pve-storage-portal-dns-list format for vitastor_etcd_address - Parse log_level in cluster_client - Fix vitastor-nbd image existence check not working because of non-zeroed inode_watch fields - Do not warn on EPIPE in client unless log_level is raised explicitly - Fix incorrect error in CSI when searching for the device in /sys - Remove 2 last prints to stdout in etcd_state_client - Fix a possible OSD crash when checking corrupted journal entries	2024-01-12 01:28:33 +03:00
Vitaliy Filippov	2f228fa96a	Only treat data partitions as existing OSDs in vitastor-disk prepare	2023-12-31 11:46:47 +03:00
Vitaliy Filippov	a6ab54b1ba	Do not allow negative util_low/high	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	99ee8596ea	Rename min/max_util to util_low/high	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	c4928e6ecd	Protect from try_send completing the operation immediately ... Fixes a possible use-after-free in case of continue_ops() calling try_send(), then connect_peer() -> set_timer() -> trigger_nearest() -> handle_op_part() -> continue_ops() again	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	8b8c1179a7	Use a separate used_blocks counter for free space stats to hide possibly delayed on-flush deallocation	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	d5a6fa6dd7	Fix possible crash on print_slow when bs_op is NULL	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	1edf86ed26	Aggregate recovery delay using simple mean over last 10 observations (EWMA is shit)	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	5ca7cde612	Experiment/WIP: Try to track "secondary" recovery ops separately	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	751935ddd8	WIP Auto-tune recovery speed	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	d84dee7098	Track recovery op latencies + refactor into a structure	2023-12-31 01:23:17 +03:00
Vitaliy Filippov	f72f14e6a7	Clear old PG states, history, and OSD states on etcd state reload ... Also add protection from etcd watcher messages being split into multiple websocket messages - I'm not sure if etcd actually does that, but it's better to have extra protection anyway. Also check that all etcd watchers are started in the keepalive routine, otherwise it sometimes tries to revive etcd watchers starting with revision=1 which obviously always fails because this revision is nearly always compacted. All these changes should fix an old rarely reproduced bug where SOMETIMES OSDs didn't react to PG config changes which was leading to offline pools on node reboot. It happened on the full reload of state from etcd.	2023-12-24 02:02:13 +03:00
Vitaliy Filippov	178bb0e701	Prevent re-entry into timerfd set_nearest	2023-12-22 02:32:40 +03:00
Vitaliy Filippov	7239cfb91a	Parse log_level in cluster_client	2023-12-20 02:21:23 +03:00
Vitaliy Filippov	7cea642f4a	Fix vitastor-nbd image existence check not working because of non-zeroed inode_watch fields	2023-12-19 01:11:37 +03:00
Vitaliy Filippov	dc615403d9	Do not warn on EPIPE in client unless log_level is raised explicitly	2023-12-17 13:42:26 +03:00
Vitaliy Filippov	1a704e06ab	Allow multiple interfaces with the same IP address, for "simple routed" full mesh network	2023-12-17 13:25:56 +03:00
Vitaliy Filippov	575475de71	Do not ignore loopback addresses for OSD network (to make ECMP setups with frr possible)	2023-12-17 11:55:13 +03:00
Vitaliy Filippov	aca2bef15f	Add vitastor-disk update-sb command	2023-12-14 01:11:42 +03:00
Vitaliy Filippov	691ebd991a	Move 2 last log printfs to stderr from stdout in etcd_state_client	2023-12-08 00:01:52 +03:00
Vitaliy Filippov	6d5df908a3	Fix possible out of bounds when checking invalid journal entries	2023-12-08 00:01:07 +03:00
Vitaliy Filippov	a1c7cc3d8d	Release 1.3.1 ... Hotfix to 1.3.0 - new "journal space reservation" had a bug which caused OSDs to crash with EC and without immediate_commit.	2023-12-04 18:35:09 +03:00
Vitaliy Filippov	a5e3dfbc5a	Oops, 1.3.0 needs a hotfix	2023-12-04 13:45:54 +03:00
Vitaliy Filippov	7972502eaf	Release 1.3.0 ... New features: - RDMA without ODP - much faster and all cards are now supported, not just Mellanox - VDUSE in CSI - faster, more stable and can even recover after CSI pod restart! - Reserve journal space for stabilize requests dynamically to prevent stalls under load with EC - Raise default NBD timeout from 30 to 300 seconds and allow to take it from /etc/vitastor/vitastor.conf - Remove explicit etcdUrl/etcdPrefix K8S storage class parameter support to prevent etcd migration issues for volumes created with these parameters - Support QEMU 8.1 and pve-qemu 8.1 Bug fixes: - Fix RDMA connection (and thus memory) leak - Fix rare crashes under load due to incorrect io_uring queue size tracking - Fix monitor statistics aggregation in case of empty /osd/stats keys - Fix crash on unknown long argument to vitastor-disk - Allow trailing comma in JSONs again - Fix crash on attempts to dump a long listing of objects "to stabilize" or "to rollback" in a slow op	2023-12-04 02:36:43 +03:00
Vitaliy Filippov	845454742d	Fix warning with QEMU 8.1	2023-12-04 01:59:07 +03:00
Vitaliy Filippov	628aa59574	Raise default NBD timeout from 30 to 300 seconds and allow to take it from /etc/vitastor/vitastor.conf	2023-12-02 14:11:14 +03:00
Vitaliy Filippov	19e2d9d6fa	Fix crash on unknown long argument to vitastor-disk	2023-12-01 00:55:51 +03:00
Vitaliy Filippov	b5c020ce0b	Use io_uring SQ size for ringloop capacity - otherwise get_sqe could return NULL when space_left() was > 0 under load ... Raise default io_uring size to 1024 for the same effective capacity as previously	2023-11-20 03:04:06 +03:00
Vitaliy Filippov	6b33ae973d	%d -> %lu	2023-11-20 03:02:26 +03:00
Vitaliy Filippov	cf36445359	Reserve journal space for stabilize requests dynamically to prevent stalls	2023-11-20 03:01:57 +03:00
Vitaliy Filippov	3fd873d263	Add -fno-omit-frame-pointer by default	2023-11-20 02:59:54 +03:00
Vitaliy Filippov	a00e8ae9ed	Fix mismatch journal pos format in vitastor-disk	2023-11-19 15:19:54 +03:00
Vitaliy Filippov	75674545dc	Limit the number of printed object versions in slow op dump (otherwise it may overflow the fixed buffer)	2023-11-13 01:10:28 +03:00
Vitaliy Filippov	225eb2fe3d	Support RDMA without ODP by stupidly copying memory. Disable ODP by default ... ODP is slower than regular RDMA even with memory copy overhead Example numbers: - 3950000 random read iops without ODP vs 240000 iops with ODP - 1447000 random write iops without ODP vs 101000 iops with ODP Reference: https://tkygtr6.github.io/pub/ISPASS21_slides.pdf	2023-11-12 15:03:47 +03:00
Vitaliy Filippov	7e82573ed0	Fix RDMA connection leak which was preventing stable functioning of RDMA :)	2023-11-11 23:40:47 +03:00
Vitaliy Filippov	5524dbdab7	Release 1.2.0 ... New features: - Implement CSI volume expansion - Implement CSI volume snapshots - CSI driver now requires Kubernetes >= 1.20 Bug fixes: - Important bug fix for EC: fix EC n+k, k>=2 read recovery in ISA-L version returning incorrect data when reading at least the second chunk out of multiple missing chunks without reading the first one. All users of EC n+k, k>=2 should upgrade as soon as possible, and upgrade should be conducted with downtime: first stop all clients (VMs/containers), then all OSDs, then upgrade and restart everything. - Fix unstable statistics aggregation in monitor (affecting vitastor-cli status and df) - Make udev not wait for OSDs to start during boot - Do not report negative numbers of offline PGs in vitastor-cli status when changing PG count - Report both old and new PG counts in vitastor-cli df when changing it - Fix OSDs sometimes not starting with "The code only supports journal versions 1 and 2, but it is 2 on disk" error after upgrading from pre-1.0 versions and letting OSDs run for some time - Fix monitors sometimes returning old PG count back after OSD configuration changes - Make monitor PG changes more stable and timeout errors less probable	2023-11-05 01:48:57 +03:00
Vitaliy Filippov	cd3dec06ac	Remove spaces from old->new PG count in df	2023-11-05 01:45:45 +03:00
Vitaliy Filippov	e15b6e7805	Fix "cannot be narrowed" in clang	2023-11-04 18:14:44 +03:00
Vitaliy Filippov	31017d8412	Allow to start with V2 journal with header size from V1, as incorrectly updated by previous versions	2023-11-04 18:13:42 +03:00
Vitaliy Filippov	4819854064	Fix OSDs incorrectly updating journal superblock after upgrade to 1.x from pre-1.x and refusing to start after it	2023-11-04 15:02:24 +03:00
Vitaliy Filippov	1f509cca77	Fix unused capture warnings and void* arithmetic (clang)	2023-11-04 14:55:12 +03:00
Vitaliy Filippov	aa8e8e8271	Add version info to --help output	2023-11-04 13:32:12 +03:00
Vitaliy Filippov	4d79e531c5	Do not print "-X offline" in status when changing pool PG count, print it in df instead	2023-11-04 13:12:13 +03:00
Vitaliy Filippov	30dff8893f	Fix ISA-L version EC recovery with first missing data chunk not being read ... (Yes, all EC n + k with k >= 2 users should upgrade as soon as possible)	2023-11-04 01:34:18 +03:00
Vitaliy Filippov	becf14a705	Add a test for EC with multiple missing data chunks, but without recovery of first of them	2023-11-04 01:34:18 +03:00
Vitaliy Filippov	7c054c6f10	Add "id" to df --json output	2023-11-01 12:46:16 +03:00
Vitaliy Filippov	b4740acf62	Fix operations paused for 0.5-1 second when it happens that io_uring submit is not triggered	2023-10-28 13:18:21 +03:00
Vitaliy Filippov	8222e3c77d	Release 1.1.0 ... New features: - Implement [client writeback cache](docs/config/client.en.md#client_enable_writeback) - Add the third I/O mode: [O_DIRECT|O_SYNC](docs/config/osd.en.md#data_io) (good for Optane) - Reduce load on etcd by splitting OSD lease and statistics reporting intervals: [etcd_stats_interval](docs/config/osd.en.md#etcd_stats_interval) (default 30 sec) - Make MON automatically filter OSDs by layout (block_size/immediate_commit/bitmap_granularity) to prevent "refusing to start PGs of this pool" errors on misconfiguration - Support running fio benchmarks on systems without io_uring - Make QEMU driver compatible with QEMU 8.1 - Document usage of [vhost-user-blk](docs/usage/qemu.en.md#vhost-user-blk) Bug fixes: - Fix resizing disks in QEMU driver (for example, in Proxmox) - Fix "unexpected result" in Proxmox driver by making CLI flush output on exit - Remove unneeded block_size mismatch warnings on pools without matching PGs - Fix possible segfault in vitastor-cli ls -l (usually with deleted pools) - Fix QEMU driver compatibility with systems without io_uring - Fix monitor eating 100% CPU when etcd is down (caused by infinite retries) - Fix potential incorrect write processing with snapshots (not caught in tests but could probably lead to client hangs) - Fix buffer insertion in cluster_client (not caught in tests but could probably lead to incorrect writes in rare cases) - Fix rare OSD crash during sync operation processing - Fix a reenterability issue in cluster_client not reproducible in QEMU/fio, but reproducible with the currently developed K/V database implementation - Fix deletion of the first modified object - OSDs could crash if you modified the same object a lot of times, then deleted it, and then modified it again - Fix the fio_sec_osd test tool	2023-10-28 00:33:06 +03:00
Vitaliy Filippov	be7e76f849	Split etcd_stats_interval out of etcd_report_interval	2023-10-27 01:26:26 +03:00
Vitaliy Filippov	294a754c9e	Allow write-back by default in NBD & NFS	2023-10-27 01:26:26 +03:00
Vitaliy Filippov	8bfea6e7de	Support vitastor_c_create_epoll() in fio driver	2023-10-26 22:57:36 +03:00
Vitaliy Filippov	bac9e34836	Allow to create vitastor_c with plain epoll without uring :-)	2023-10-26 22:57:36 +03:00
Vitaliy Filippov	8aa4d492c1	Allow to use epoll_manager without ringloop	2023-10-26 22:57:36 +03:00
Vitaliy Filippov	9336ee5476	Correctly free manual "small vector" in cluster_client %-)	2023-10-26 22:57:36 +03:00
Vitaliy Filippov	ad30b11519	Add the missing ringloop creation check to vitastor_c_create_uring_json()	2023-10-26 18:07:23 +03:00
Vitaliy Filippov	a061246997	Do not attempt to initialize QEMU driver via vitastor_c_create_qemu_uring() ... It doesn't add any compatibility because vitastor_c_uring_register_eventfd() is added in the same VITASTOR_C_API_VERSION 2.	2023-10-26 17:46:19 +03:00
Vitaliy Filippov	5066e35a49	Fix write-over-delete failing for the very first entry in dirty_db	2023-10-21 17:00:14 +03:00
Vitaliy Filippov	93dc31f3fc	Fix possible segfault in vitastor-cli ls -l	2023-10-18 11:11:41 +03:00
Vitaliy Filippov	f245b56176	Fix another possible reenterability issue in cluster_client ... Non-reproducible in QEMU/FIO, only caught during K/V DB debugging	2023-10-08 11:02:53 +03:00
Vitaliy Filippov	38db53f5ee	Implement client writeback cache ... - Disabled by default, enable with client_enable_writeback=true - Even then only enabled in FIO when -direct is disabled and in QEMU when block device cache is enabled in settings - Can also be enabled in other clients like vitastor-cli using parameter client_writeback_allowed=true, but not recommended	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	cd543a90bc	Prevent stack overflows in cli_merge with CAS and writeback cache	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	f600cc07b0	Autosync in blockstore every autosync_writes, too	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	6a8e530e6b	Add FIXME to timerfd_manager	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	5cadb170b9	Fix possible OSD crash during sync due to missing min_flushed_journal_sector reset	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	e72d4ed1d4	Remove unused bs_sync fields	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	ff479a102d	Make MON filter OSDs by block layout to prevent "refusing to start PGs of this pool" errors on misconfiguration	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	27d0d5b06a	Reads do not have to wait for buffer flushes anymore	2023-09-16 17:52:17 +03:00
Vitaliy Filippov	33950c1ec8	Fix fio_sec_osd attr_len	2023-09-16 17:49:10 +03:00
Vitaliy Filippov	cc0fdc6253	Remove erroneous block_size mismatch warnings on pools without matching PGs	2023-09-08 23:19:04 +03:00
Vitaliy Filippov	79ecd59b10	Flush STDOUT and STDERR before exiting from cli to fix Proxmox "Unexpected result"	2023-09-07 17:30:26 +03:00
Vitaliy Filippov	b7d398be5b	Fix sscanf validation usage (field count instead of null_byte == 0)	2023-09-07 02:34:35 +03:00
Vitaliy Filippov	85e9f67d9d	Add supported_truncate_flags	2023-09-06 17:37:52 +03:00
Vitaliy Filippov	79c6d6f323	Make QEMU driver compatible with QEMU 8.1	2023-08-24 02:23:55 +03:00
Vitaliy Filippov	ae760dbc1d	Fix co_truncate size division by BDRV_SECTOR_SIZE	2023-08-24 01:55:35 +03:00
Vitaliy Filippov	65487da4b1	Do not include msgr_rdma.h into messenger.h	2023-08-24 01:55:35 +03:00
Vitaliy Filippov	7862282938	Extract validation to check_rw(), remove duplicate code with OP_SYNC	2023-08-13 23:49:52 +03:00
Vitaliy Filippov	30ce2bd951	Fix buffer insert in cluster_client	2023-08-12 11:08:50 +03:00
Vitaliy Filippov	b1a0afd10a	Aggregate buffer flushes	2023-08-11 11:26:13 +03:00
Vitaliy Filippov	85b6134910	Return dirty buffers on read in client ... Required at least to return buffers when they need to be replayed, but until they are actually replayed	2023-08-09 00:57:08 +03:00
Vitaliy Filippov	b1b07a393d	Fix incorrect marking op parts as done with snapshots (could probably lead to client hangs)	2023-08-09 00:57:08 +03:00
Vitaliy Filippov	7333022adf	Add a third I/O mode: O_DIRECT|O_SYNC, change parameters to data_io/meta_io/journal_io	2023-08-09 00:57:08 +03:00
Vitaliy Filippov	6acf562e01	Release 1.0.0 ... New features: - Data and metadata checksums! - Metadata checksums are always used with new disk format - Data checksums can be turned on with --data_csum_type crc32c for new OSDs - Checksum block size can be configured - inmemory_metadata now also affects keeping checksums in memory - Linux page cache I/O caching support which can be enabled separately for data, metadata (including checksums) and journal (O_SYNC instead of O_DIRECT) - Details [here](https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/docs/config/layout-osd.en.md#data_csum_type) - Backwards compatibility is preserved, you can use new OSDs with old disks Release also includes bug fixes from [0.9.6](https://git.yourcmc.ru/vitalif/vitastor/releases/tag/v0.9.6). 0.9.6 is moved to "-oldstable" repositories and will be available for some additional time.	2023-07-29 18:57:19 +03:00
Vitaliy Filippov	564df2eb5d	Support using buffered I/O with O_SYNC instead of direct I/O	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	1a4ceb420d	Track used blocks, not object versions	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	21b5124a4b	Document data_csum_type and csum_block_size parameters	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	4181add1f4	Remove creepy "metadata copying" during overwrite ... Instead of it, just do not verify checksums of currently mutated objects. When clean data modification during flush runs in parallel to a read request, that request may read a mix of old and new data. It may even read a mix of multiple flushed versions if it lasts too long... And attempts to verify it using temporary copies of metadata make the algorithm too complex and creepy.	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	a8464c19af	Support keeping checksums on disk (not in memory) ... Definitely beneficial for SSD+HDD setups	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	3c8e4c6b72	Use clean_dyn_size for space check	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	8ef4cf89dc	Log more details about checksum mismatch in big_writes	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	7bfb1639ea	Use find_holes() in flusher for unification	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	628e481c32	Fill journal header to know checksum type & size when dumping journal with --all	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	af6f2046fc	Fix journal read checksum verification with inmemory_journal=false	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	9357e5293e	Call fill_partial_checksum_blocks() correctly in regard to COPY_BUF_CSUM_FILL	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	12851dc07d	Wait for journal reads before checking them in clear_incomplete_csum_block_bits	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	d6ee1ca17c	Use zero checksum size for zero-length writes	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	71674d00cf	Fix journal data checksum mangling on corrupted block overwrite	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	ddb078d5a7	Check journal entry size when checking block checksums	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	d22d56f90a	Fix journal data checksum verification on start	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	eb1331a079	Add more details to "journal entry data is corrupt" messages	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	c5274f655b	...and partially remove the perversion with bitmap inlining	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	45e07d6294	Sadly we have to refcount dyn_data...	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	a8ee391e05	Fix clean block checksum read	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	de48fa3fd2	Allow to forcibly set meta_format	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	874a766b62	Rename meta_version to meta_format	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	384bd8e28f	Support old metadata format in vitastor-disk dump-meta	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	430994f48a	Fix journal big_write simple reads after checksum changes	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	b909d81f41	Fix bitmap-granular checksums	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	e42975ffd1	Fix wait_journal_count not being zeroed	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	93778324e5	Rewrite and fix find_holes into a more obvious version	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	eeb6727170	Fix missing checksum read offset	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	92c6e16eba	Fix checksum verification in big_write journal reads	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	213a9ccb4d	Verify checksums during journal reads	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	a166147110	Add backwards compatibility with non-checksum metadata and journal formats	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	7d532880c3	Implement large csum_block_size support (more than 4k) + refactor blockstore_flush	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	0b0405d115	Implement bitmap-granular (4k) metadata & data checksums	2023-07-29 12:17:18 +03:00
Vitaliy Filippov	e651c93a90	Release 0.9.6 ... - Fix vitastor-disk partition zeroing (sometimes it was writing garbage instead of zeroes) - Fix incorrect EC space statistics in `vitastor-cli status` - Several bug fixes for NFS: - Add . and .. in NFS directory listings - Return FILE_SYNC from NFS writes if immediate_commit is enabled - Return the same "verifier" in NFS COMMIT as in NFS WRITE - Make parallel NFS extending writes work correctly, without conflicts - Handle parallel NFS extending writes without imposing extra load on etcd - Support UTF-8 in vitastor-cli table output - Also allow "0" and "no" as false for inmemory_metadata and inmemory_journal - Use HDD defaults for HDD-only in automatic `vitastor-disk prepare` mode	2023-07-29 10:54:00 +03:00
Vitaliy Filippov	988e90be69	Fix vitastor-disk partition zeroing (it was writing random garbage instead of zeroes :D)	2023-07-28 12:29:07 +03:00
Vitaliy Filippov	700e0e9bff	Handle parallel NFS extending writes without imposing extra load on etcd	2023-07-27 02:26:17 +00:00
Vitaliy Filippov	ab0ca7c00f	Return FILE_SYNC from NFS writes if immediate_commit is enabled	2023-07-26 02:09:47 +03:00
Vitaliy Filippov	f153bc950b	Return the same "verifier" in NFS COMMIT as in NFS WRITE ... This fixes buffered (not O_DIRECT) NFS writes in Linux - previously they were hanging in an infinite loop because COMMIT didn't return the same verifier as previous WRITEs, and NFS kernel client was infinitely retrying the same writes. Also this probably allows for correct NFS failover, at least for the same buffered writes, because NFS clients repeat all write requests until a COMMIT confirms them.	2023-07-26 02:09:47 +03:00
Vitaliy Filippov	425ff8818d	Add . and .. in NFS directory listings ... MC, for example, hangs with infinite listing retries without them	2023-07-26 02:09:47 +03:00
Vitaliy Filippov	9e287a7778	Handle extending writes correctly in NFS proxy ... Previously, multiple parallel writes extending file size through NFS were racing with each other and triggering deletions of part of the written data I.e. if you mounted vitastor-nfs and just copied a file into it in MC then you could end up with only a part of the file actually written	2023-07-26 02:09:43 +03:00
Vitaliy Filippov	f52f58b9e9	Support UTF-8 in vitastor-cli table output	2023-07-25 01:48:57 +00:00
Vitaliy Filippov	1fe6b0c0e2	Also allow "0" and "no" as false for inmemory_metadata and inmemory_journal	2023-07-25 01:48:57 +00:00
Vitaliy Filippov	e4237e9ed8	Enable HDD defaults for HDD-only in automatic `vitastor-disk prepare` mode	2023-07-23 02:33:22 +03:00
Vitaliy Filippov	10a5fd6abb	Release 0.9.5 ... A hotfix to 0.9.4 containing only one bugfix: 100% CPU usage in the new QEMU driver caused by the lack of eventfd reset on io_uring event handling :)	2023-07-21 00:04:41 +03:00
Vitaliy Filippov	1c316ef350	Reset eventfd on every ringloop::loop()	2023-07-21 00:04:41 +03:00
Vitaliy Filippov	0b2d12eef1	Remove has_work, it was unnecessary	2023-07-21 00:04:37 +03:00
Vitaliy Filippov	1c10430ae1	Release 0.9.4 ... - Improve QEMU driver performance by integrating io_uring in it (up to 1.5x total iops improvement) - Fix QEMU driver deadlocks which started to reproduce in qemu-img after iothread fixes - Fix `vitastor-cli status` reporting more etcds than actually exists (fix etcd address duplication in config on reload) - Fix `vitastor-cli ls` crashing on inodes in non-existing pools - Delete old garbage /pool/stats/ keys for non-existing (deleted) pools - Reduce memory usage of etcds initialized by make-etcd script - Fix OSDs almost always crashing on etcd restart due to "revisions were compacted" (support reloading state from etcd) - Fix a crash and a stall possible mostly in HDD setups with small journal and big (512k, 900k) random writes - Add notes about HDDs to documentation. You are officially allowed to use HDD-only Vitastor with HGST/Toshiba/EXOS :)	2023-07-19 02:50:30 +03:00
Vitaliy Filippov	d0e257ee81	Fix non-existing pool handling in `vitastor-cli ls`	2023-07-18 23:52:02 +03:00
Vitaliy Filippov	9815d70ffc	It is impossible to use io_uring with older vitastor-client because it does not have vitastor_c_uring_has_work()	2023-07-18 23:37:53 +03:00
Vitaliy Filippov	4a4627dcab	Do not use bool in C library	2023-07-18 23:37:53 +03:00
Vitaliy Filippov	ba7427020e	Fix deadlocks possible in qemu-img after fixing iothread ... Deadlock was caused by switching QEMU coroutines directly inside vitastor_co_read_bitmap_cb() callback. The correct way is to schedule a BH /BH is a QEMU term for setImmediate() :)/, same as in read and write callbacks.	2023-07-18 23:32:16 +03:00
Vitaliy Filippov	ac7b834af3	Disable journal_no_same_sector_overwrites by default for HDD-only	2023-07-10 00:34:35 +03:00
Vitaliy Filippov	57ad4c3636	Add a note about HDD, enable throttling only for hybrid OSDs	2023-07-09 12:45:11 +03:00
Vitaliy Filippov	b7e4d0c9bf	Fix journal dirty_start position tracking and some debug prints ... Fixes two bugs found during HDD testing :-) 1) OSD crashed with "BUG: Attempt to overwrite used offset of the journal" during `fio -bs=900k -iodepth=128` test with 16 MB journal 2) OSD stalled during `fio -bs=512k -iodepth=128` test with 64 MB journal	2023-07-09 01:17:55 +03:00
Vitaliy Filippov	161a23c966	Support reloading state when etcd says "revisions were compacted" ... Before this change, OSDs almost always died when one of the etcds was restarted, even though the rest of them was still in quorum and the lease was still active	2023-07-07 01:33:48 +03:00
Vitaliy Filippov	45c0694853	Clear etcd_local addresses on reload and also skip duplicates	2023-07-06 00:39:39 +03:00
Vitaliy Filippov	30ac899074	Make QEMU driver compatible with older vitastor_client and with systems without io_uring	2023-07-04 15:51:43 +03:00
Vitaliy Filippov	2348d39cf4	Avoid repeated qemu_uring_handlers, add 2.0-2.7 compatibility	2023-07-04 00:28:23 +03:00
Vitaliy Filippov	3de7929fe5	Integrate v2 - direct epoll	2023-07-04 00:28:23 +03:00
Vitaliy Filippov	07b2196bc2	Integrate QEMU driver with io_uring	2023-07-04 00:28:23 +03:00
Vitaliy Filippov	a612cdca47	Release 0.9.3 ... - Add patch for libvirt 9.0 - Add support for Proxmox VE 8.0 - Fix compatibility of the QEMU driver with iothread (QEMU rebuilds are coming) - Fix vitastor-cli rm-data/rm/merge hanging when some OSDs are down. Allow deletions in unclean cluster at the cost of some data possibly "reappearing" when those OSDs start back. In that case you can just repeat the deletion request using rm-data. - A bunch of bug fixes for snapshots: - Fix snapshot reads often not working at all with snapshot chain size > 2 - Fix optimized snapshot data merge (children to parent) - Fix updating of image name index key during optimized merge - Fix auto-selection preventing the use of optimized merge with only 1 snapshot - Fix incorrect CAS retries during snapshot merge - Fix snapshot merge progress reporting - Fix primary_read bitmap buffers use-after-free which could lead to incorrect allocation map reads - Remove /usr/local/bin path from make-etcd - Some documentation fixes	2023-07-01 00:25:58 +03:00
Vitaliy Filippov	c8d61568b5	Fix primary_read bitmap buffers being freed too early (use-after-free)	2023-06-30 12:47:45 +03:00
Vitaliy Filippov	84ed3c6395	Fix CAS retries during snapshot merge	2023-06-30 02:30:23 +03:00
Vitaliy Filippov	a7b57386c0	Do not print last subcommand result twice during "inverse" snapshot merge	2023-06-30 02:07:10 +03:00
Vitaliy Filippov	9d4ea5f764	Fix inverse parent selection which prevented the use of optimized merge in case of only 1 snapshot	2023-06-30 01:39:11 +03:00
Vitaliy Filippov	000e4944ec	Remove "inverse parent" image name index key from etcd during snapshot merge	2023-06-30 01:23:30 +03:00
Vitaliy Filippov	8426616d89	Warn about unfinished deletions in rm-data	2023-06-30 01:18:25 +03:00
Vitaliy Filippov	1a841344ec	Print progress of all operations during snapshot merge	2023-06-30 01:13:47 +03:00
Vitaliy Filippov	8603b5cb1d	Do not hang on inactive OSDs during delete, report and skip them instead	2023-06-30 00:15:16 +03:00
Vitaliy Filippov	878ccbb6ea	Fix snapshot chain "down-merge" ("up-merge" worked well...)	2023-06-29 00:47:21 +03:00
Vitaliy Filippov	63c2b9832c	Fix chained (snapshot) reads often not working at all with chain size > 2	2023-06-28 18:54:03 +03:00
Vitaliy Filippov	a11ca56fb1	Fix compatibility of the QEMU driver with iothread	2023-06-21 02:11:28 +03:00
Vitaliy Filippov	b84927b340	Fix \n in nbd_proxy	2023-06-19 01:48:58 +03:00
Vitaliy Filippov	926be372fd	Release 0.9.2 ... - Measure and report scrub I/O statistics in vitastor-cli status - Make aggregated statistics in vitastor-cli status much smoother (first derive, then sum instead of first summing and then deriving) - Fix an old rare bug leading to journal corruption (try to use scrub if you think you're affected...) - Do not start EC PGs without at least <data chunks> OSDs in each old set (prevents spurious read errors with EC during reconnections/restarts) - Fix failed assert(!scrub_list_op) on OSD restart with pending scrubs - Fix future planned scrubs not starting because of incorrect time comparison - Build packages for Debian 12 (Bookworm)	2023-06-18 19:44:33 +03:00
Vitaliy Filippov	c74a424930	Report scrub I/O in vitastor-cli status	2023-06-17 21:11:21 +03:00
Vitaliy Filippov	32f2c4dd27	Measure scrub statistics	2023-06-17 20:56:26 +03:00
Vitaliy Filippov	3ad16b9a1a	Fix auto_scrubs not starting because of < vs <= =))	2023-06-17 17:32:21 +03:00
Vitaliy Filippov	1c2df841c2	Fix failed assert(!scrub_list_op) on OSD restart with pending scrubs	2023-06-17 17:02:54 +03:00
Vitaliy Filippov	aa5dacc7a9	Do not start EC PGs without at least pg_data_size connections to old OSDs from each set	2023-06-17 02:16:30 +03:00
Vitaliy Filippov	4fdc49bdc7	Add another assert-type check (it does not fire, just as a safety measure for the future)	2023-06-17 00:07:22 +03:00
Vitaliy Filippov	86b4682975	Put get_trim_pos into the "critical section". Fixes rare journal corruption issue ... The consequence of this issue was that in some very rare cases (only reproduced under load in CI when running 4+ tests in parallel) small write data written to journal could overwrite journal entries. Also add an assert-type safety check to be able to catch this issue in the future again in case of a regression.	2023-06-17 00:06:42 +03:00
Vitaliy Filippov	bdd48e4cf1	Release 0.9.1 ... - Fix "Client XX command out of sync" messages sometimes happening on OSD reconnections - Fix a bug where EC reads parallel with writes to the same object failed with -ERANGE error - Slightly reduce the amount of metadata writes during journal flushing - Correctly unmap NBD volumes when Proxmox forces map_volume use (with SWTPM and maybe some other cases)	2023-06-10 11:42:49 +03:00
Vitaliy Filippov	f9fbea25a4	Remove double write when old and new locations are in the same metadata block ... Also add another metadata entry fool-safety check which, ideally, will never fire %)	2023-06-03 00:47:10 +03:00
Vitaliy Filippov	2c9a10d081	Fix an idiotic bug leading to failed reads with -ERANGE with EC :D	2023-06-03 00:44:52 +03:00
Vitaliy Filippov	150968070f	Slightly improve some debug prints	2023-05-29 01:04:16 +03:00
Vitaliy Filippov	cdfc74665b	Close client FDs only when destroying the client, after handling all async reads/writes ... Fixes "Client XX command out of sync" sometimes happening on reconnections	2023-05-25 00:52:43 +03:00
Vitaliy Filippov	3b4cf29e65	Release 0.9.0 ... New features: - Scrubbing! Check documentation: [auto_scrub](src/branch/master/docs/config/osd.en.md#auto_scrub) - Document online-updatable configuration parameters Bug fixes: - Fix NaN during PG optimisation if there are nonexisting OSDs in node_placement - Fix monitor crash on pool deletion - Clear journal_device and meta_device before initialising the next OSD in automatic mode - Sync unsynced deletes before overwriting them with a lower version (reproducted mostly/only after scrubbing)	2023-05-21 15:07:14 +03:00
Vitaliy Filippov	ce02f47de6	Allow to disable scrub_find_best	2023-05-21 12:33:38 +03:00
Vitaliy Filippov	f1961157f0	Fix brute-force error locator for EC n+k with k > 2	2023-05-21 00:57:14 +03:00
Vitaliy Filippov	88c1ba0790	Fix compile errors with gcc 10	2023-05-20 23:20:09 +03:00
Vitaliy Filippov	fa90b5a4e7	Schedule automatic scrubs correctly (not just after previous scrub)	2023-05-20 23:20:09 +03:00
Vitaliy Filippov	8d40ad99a6	Add scrub documentation	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	6ca20aa194	Allow scrub to fix corrupted object states	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	4bfd994341	Sync unsynced deletes before overwriting them with a lower version	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	59e959dcbb	Do not die when "different versions are returned from subops"	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	a9581f0739	Handle dirty deletes during read correctly O_o	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	105a405b0a	Implement vitastor-cli fix	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	0e5d0e02a9	Add "vitastor-cli describe" command	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	0439981a66	Implement "describe object(s)" operation ... Required to implement fixing inconsistent objects in vitastor-cli	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	6648f6bb6e	Implement ambiguity detection during scrub	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	281be547eb	Implement brute-force error locator for EC	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	0c78dd7178	Add no_scrub flag	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	3c924397e7	Store next scrub timestamp instead of last scrub timestamp	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	c3bd26193d	Implement PG scrub runner	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	43b77d7619	Implement scrubbing "data path" - OSD_OP_SCRUB	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	a6d846863b	Add min/max stripe and limit to OP_LIST	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	8dc427b43c	Retry failed reads (including chained and RMW) from other replicas	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	bf2112653b	Refcount object_states	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	0538a484b3	Add corrupted object state	2023-05-20 23:19:39 +03:00
Vitaliy Filippov	97720fa6b4	Remove unused capture	2023-05-20 22:58:51 +03:00
Vitaliy Filippov	e60e352df6	Improve vitastor-nbd documentation	2023-05-20 22:58:51 +03:00
Vitaliy Filippov	629999f789	Clear journal_device and meta_device before initialising the next OSD in automatic mode	2023-05-15 23:58:55 +03:00
Vitaliy Filippov	5a9e1ede52	Release 0.8.9 ... - The tests are now stable and run in a CI system based on Gitea CI - The release includes final bug fixes for EC: - Implement missing EC recovery of allocation bitmap when built with ISA-L - Fix broken snapshot export with EC (allocation bitmap reads were giving incorrect results previously) - Also fixed bugs manifesting under heavy load: - Fix monitor possibly applying incorrect PG history on retries - Fix monitor incorrectly changing PG count when last_clean_pgs contains less PGs than the new number - Allow writes to wait for free space again, but now correctly (previously dropped in 0.8.2) - Fix a rare segfault in client (handle client stop during incoming stream handling in 1 more place) - Make monitor correctly handle etcd connection errors - it could die instead of connecting to another etcd - Fix OSD rarely being unable to report PG states after a PG was taken over by another OSD - Fixed return code for incomplete EC objects (now EIO) and made cluster client retry this error - Made other small changes for tests: timeouts, nice/ionice for etcd, waiting conditions, NBD device checks and so on	2023-05-14 01:25:09 +03:00
Vitaliy Filippov	de3e609166	Add a FIXME about QEMU driver thread safety	2023-05-14 00:06:09 +03:00
Vitaliy Filippov	11481170f5	Add a FIXME about ENOSPC	2023-05-13 23:59:44 +03:00
Vitaliy Filippov	6442010f93	Skip offline PGs during state reporting when the state is already deleted or taken over by another OSD ... This fixes OSDs being unable to report PG states in rare conditions	2023-05-12 23:17:45 +03:00
Vitaliy Filippov	ce4a8067b5	Handle client stop during incoming stream handling in 1 more place	2023-05-11 01:53:41 +03:00