Delete extra /pool/stats/ keys for non-existing pools

mon/mon.js

@@ -1608,7 +1608,7 @@ class Mon
                 }
             }
         }
-        return inode_stats;
+        return { inode_stats, seen_pools };
     }
 
     serialize_bigints(obj)
@@ -1634,7 +1634,7 @@ class Mon
         const timestamp = Date.now();
         const { object_counts, object_bytes } = this.sum_object_counts();
         let stats = this.sum_op_stats(timestamp, this.prev_stats);
-        let inode_stats = this.sum_inode_stats(
+        let { inode_stats, seen_pools } = this.sum_inode_stats(
             this.prev_stats ? this.prev_stats.inode_stats : null,
             timestamp, this.prev_stats ? this.prev_stats.timestamp : null
         );
@@ -1669,12 +1669,22 @@ class Mon
         }
         for (const pool_id in this.state.pool.stats)
         {
-            const pool_stats = { ...this.state.pool.stats[pool_id] };
-            this.serialize_bigints(pool_stats);
-            txn.push({ requestPut: {
-                key: b64(this.etcd_prefix+'/pool/stats/'+pool_id),
-                value: b64(JSON.stringify(pool_stats)),
-            } });
+            if (!seen_pools[pool_id])
+            {
+                txn.push({ requestDeleteRange: {
+                    key: b64(this.etcd_prefix+'/pool/stats/'+pool_id),
+                } });
+                delete this.state.pool.stats[pool_id];
+            }
+            else
+            {
+                const pool_stats = { ...this.state.pool.stats[pool_id] };
+                this.serialize_bigints(pool_stats);
+                txn.push({ requestPut: {
+                    key: b64(this.etcd_prefix+'/pool/stats/'+pool_id),
+                    value: b64(JSON.stringify(pool_stats)),
+                } });
+            }
         }
         if (txn.length)
         {

src/etcd_state_client.cpp

@@ -187,22 +187,30 @@ void etcd_state_client_t::add_etcd_url(std::string addr)
             check_addr = addr;
         if (pos == std::string::npos)
             addr += "/v3";
+        bool local = false;
         int i;
         for (i = 0; i < local_ips.size(); i++)
         {
             if (local_ips[i] == check_addr)
             {
-                this->etcd_local.push_back(addr);
+                local = true;
                 break;
             }
         }
-        if (i >= local_ips.size())
-            this->etcd_addresses.push_back(addr);
+        auto & to = local ? this->etcd_local : this->etcd_addresses;
+        for (i = 0; i < to.size(); i++)
+        {
+            if (to[i] == addr)
+                break;
+        }
+        if (i >= to.size())
+            to.push_back(addr);
     }
 }
 
 void etcd_state_client_t::parse_config(const json11::Json & config)
 {
+    this->etcd_local.clear();
     this->etcd_addresses.clear();
     if (config["etcd_address"].is_string())
     {